From 728d28e7e4787c987dd45e2701e77b109829ea88 Mon Sep 17 00:00:00 2001
From: imccyu <276526105+imccyu@users.noreply.github.com>
Date: Wed, 29 Jul 2026 00:06:19 +0800
Subject: [PATCH] test: close the coverage gaps on the permission line
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Two real branches gain assertions (effectivePermissionPreset's backward
scan over non-preset events; the popup options() throw when the projection
vanished between availability and open — a sync throw, not a rejection).
The empty ui-permission node half joins the ui-model entry on the
client-lane coverage debt list (same pure-UI plugin shape, same TODO).
---
 packages/client/ui-permission/tests/browser-plugin.spec.ts | 3 +++
 packages/ui/permission/tests/permission.spec.ts            | 3 +++
 vitest.config.ts                                           | 1 +
 3 files changed, 7 insertions(+)

diff --git a/packages/client/ui-permission/tests/browser-plugin.spec.ts b/packages/client/ui-permission/tests/browser-plugin.spec.ts
index 33fc94b3a0..b0beb2b9b9 100644
--- a/packages/client/ui-permission/tests/browser-plugin.spec.ts
+++ b/packages/client/ui-permission/tests/browser-plugin.spec.ts
@@ -81,6 +81,9 @@ describe('ui-permission browser plugin', () => {
     const again = await c.ui.options(proj, new AbortController().signal)
     expect(again.find(option => option.id === 'workspace-write')?.active).toBe(true)
     expect(again.find(option => option.id === 'read-only')?.detail).toBe('Reads only.')
+    // A projection that vanished between availability and open throws.
+    expect(() => c.ui.options({ sessionId: sid('ghost') }, new AbortController().signal))
+      .toThrow(/not available on this host/)
   })
 
   it('a pick submits the /permission line; rejection and unmatched throw', async () => {
diff --git a/packages/ui/permission/tests/permission.spec.ts b/packages/ui/permission/tests/permission.spec.ts
index 864f25629d..05a747de8d 100644
--- a/packages/ui/permission/tests/permission.spec.ts
+++ b/packages/ui/permission/tests/permission.spec.ts
@@ -34,6 +34,9 @@ describe('effectivePermissionPreset', () => {
     session.append('permission/preset', { preset: 'danger-full-access' })
     session.append('permission/preset', { preset: 'workspace-write' })
     expect(effectivePermissionPreset(session.events)).toBe('workspace-write')
+    // The backward scan steps over non-preset events to the latest selection.
+    session.append('sandbox/mode', { mode: 'read-only' })
+    expect(effectivePermissionPreset(session.events)).toBe('workspace-write')
   })
 })
 
diff --git a/vitest.config.ts b/vitest.config.ts
index 16f28449a5..55f172416f 100644
--- a/vitest.config.ts
+++ b/vitest.config.ts
@@ -138,6 +138,7 @@ export default defineConfig({
         'packages/client/ui-command/src/client/service.ts',
         'packages/client/ui-command/src/client/PopupSelectView.tsx',
         'packages/client/ui-model/src/index.ts',
+        'packages/client/ui-permission/src/index.ts',
         'packages/client/ui-model/src/client/ModelSelect.tsx',
         'packages/client/ui-model/src/client/directory.ts',
         'packages/client/ui-model/src/client/index.ts',