From 7a9d7d265753daa4006b613659cbcbbb13133ee8 Mon Sep 17 00:00:00 2001 From: imccyu <276526105+imccyu@users.noreply.github.com> Date: Tue, 11 Aug 2026 21:00:02 +0800 Subject: [PATCH] chore(hygiene): restore the cordis peers and teach knip the split faces `@deepseek-ai/cordis` returns to the peer and dev dependencies of `dsh-client-ui-model` and `dsh-client-ui-skill`; every harness package declares it, and the client type-assembly rename dropped it from both. The commands manifest ships `src` alongside its generated typert faces, matching the `./src/*` export it already declares. knip gains the two directory-picker surface workspaces, whose specs are `.tsx` and matched no default pattern, and ignores `zod` in the commands workspace: that dependency belongs to the generated Remote and Host faces in `lib/`, which knip never scans. The unused `dsh-client-test-runtime` and `dsh-client-connection` dev dependencies are gone; the picker surface's own spec never imported the former, and ui-settings reads the carrier's types through the Remote assembly now. --- knip.json | 22 +++++++++++++++++++ .../ui-directory-picker-native/package.json | 1 - packages/client/ui-model/package.json | 2 ++ packages/client/ui-settings/package.json | 1 - packages/client/ui-skill/package.json | 2 ++ packages/interaction/commands/package.json | 3 ++- pnpm-lock.yaml | 6 +++++ 7 files changed, 34 insertions(+), 3 deletions(-) diff --git a/knip.json b/knip.json index 1f3dcefea8..476641830f 100644 --- a/knip.json +++ b/knip.json @@ -151,6 +151,25 @@ "tests/**/*.tsx" ] }, + "packages/client/ui-directory-picker": { + "entry": [ + "tests/**/*.spec.tsx" + ], + "project": [ + "src/**/*.ts", + "src/**/*.tsx", + "tests/**/*.tsx" + ] + }, + "packages/client/ui-directory-picker-native": { + "entry": [ + "tests/**/*.spec.tsx" + ], + "project": [ + "src/**/*.ts", + "tests/**/*.tsx" + ] + }, "packages/client/ui-deliverables": { "entry": [ "tests/**/*.spec.tsx" @@ -559,6 +578,9 @@ "project": [ "src/**/*.ts", "tests/**/*.ts" + ], + "ignoreDependencies": [ + "zod" ] }, "packages/examples/jsonrpc-demo": { diff --git a/packages/client/ui-directory-picker-native/package.json b/packages/client/ui-directory-picker-native/package.json index 1e0e666f71..f7a0a80bdf 100644 --- a/packages/client/ui-directory-picker-native/package.json +++ b/packages/client/ui-directory-picker-native/package.json @@ -53,7 +53,6 @@ }, "devDependencies": { "@deepseek-ai/dsh-client-runtime": "workspace:^", - "@deepseek-ai/dsh-client-test-runtime": "workspace:^", "@deepseek-ai/dsh-client-ui-slots": "workspace:^", "@deepseek-ai/dsh-client-ui-workspace": "workspace:^", "@deepseek-ai/dsh-invariants": "workspace:^", diff --git a/packages/client/ui-model/package.json b/packages/client/ui-model/package.json index fb53792f04..09e4b5eb85 100644 --- a/packages/client/ui-model/package.json +++ b/packages/client/ui-model/package.json @@ -57,6 +57,7 @@ "@deepseek-ai/dsh-client-ui-slots": "workspace:^", "@deepseek-ai/dsh-invariants": "workspace:^", "clsx": "^2.1.1", + "@deepseek-ai/cordis": "workspace:^", "react": "^18.2.0" }, "devDependencies": { @@ -73,6 +74,7 @@ "@deepseek-ai/dsh-invariants": "workspace:^", "@types/react": "~18.3.1", "clsx": "^2.1.1", + "@deepseek-ai/cordis": "workspace:^", "react": "^18.2.0" }, "files": [ diff --git a/packages/client/ui-settings/package.json b/packages/client/ui-settings/package.json index a46905c440..95575dc666 100644 --- a/packages/client/ui-settings/package.json +++ b/packages/client/ui-settings/package.json @@ -58,7 +58,6 @@ "devDependencies": { "@deepseek-ai/cordis": "workspace:^", "@deepseek-ai/dsh-api-remotes": "workspace:^", - "@deepseek-ai/dsh-client-connection": "workspace:^", "@deepseek-ai/dsh-client-runtime": "workspace:^", "@deepseek-ai/dsh-client-schema-form": "workspace:^", "@deepseek-ai/dsh-client-test-runtime": "workspace:^", diff --git a/packages/client/ui-skill/package.json b/packages/client/ui-skill/package.json index 06df0c7b4a..e5d11fe0e1 100644 --- a/packages/client/ui-skill/package.json +++ b/packages/client/ui-skill/package.json @@ -56,6 +56,7 @@ "@deepseek-ai/dsh-client-ui-slots": "workspace:^", "@deepseek-ai/dsh-client-ui-tool": "workspace:^", "@deepseek-ai/dsh-invariants": "workspace:^", + "@deepseek-ai/cordis": "workspace:^", "react": "^18.2.0" }, "devDependencies": { @@ -71,6 +72,7 @@ "@deepseek-ai/dsh-invariants": "workspace:^", "@testing-library/react": "^16.1.0", "@types/react": "~18.3.1", + "@deepseek-ai/cordis": "workspace:^", "react": "^18.2.0", "react-dom": "^18.2.0" }, diff --git a/packages/interaction/commands/package.json b/packages/interaction/commands/package.json index b654451b37..7b9ade9d26 100644 --- a/packages/interaction/commands/package.json +++ b/packages/interaction/commands/package.json @@ -50,7 +50,8 @@ "lib/typert.host.d.ts", "lib/typert.remote-client.js", "lib/typert.remote-client.d.ts", - "lib/typert.remote-client.d.ts.map" + "lib/typert.remote-client.d.ts.map", + "src" ], "license": "BSD-3-Clause", "peerDependencies": { diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 074a1bac70..2e71c12536 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -2349,6 +2349,9 @@ importers: packages/client/ui-model: devDependencies: + '@deepseek-ai/cordis': + specifier: workspace:^ + version: link:../../../vendor/cordis '@deepseek-ai/dsh-api-remotes': specifier: workspace:^ version: link:../../api/remotes @@ -2838,6 +2841,9 @@ importers: packages/client/ui-skill: devDependencies: + '@deepseek-ai/cordis': + specifier: workspace:^ + version: link:../../../vendor/cordis '@deepseek-ai/dsh-api-remotes': specifier: workspace:^ version: link:../../api/remotes