diff --git a/.agents/notes/implemented/bug-fix/2026-07-29-pnpm-setup-runner-isolation.i18n.yaml b/.agents/notes/implemented/bug-fix/2026-07-29-pnpm-setup-runner-isolation.i18n.yaml new file mode 100644 index 0000000000..fb5ee5debc --- /dev/null +++ b/.agents/notes/implemented/bug-fix/2026-07-29-pnpm-setup-runner-isolation.i18n.yaml @@ -0,0 +1,6 @@ +# Bilingual-pair consistency record (docs/i18n/README.md): the git blob hash of each +# side as of the last confirmed-consistent state. Both languages carry equal authority; +# after editing either side, bring the other along and re-record with: +# pnpm run verify-translation-pairing --write .agents/notes/implemented/bug-fix/2026-07-29-pnpm-setup-runner-isolation.md +2026-07-29-pnpm-setup-runner-isolation.md: 743535d0394cbea0374c412ba6968910ce858de4 +2026-07-29-pnpm-setup-runner-isolation.zh.md: 1e51070f88dead17b9d3f5625e337c558786aba2 diff --git a/.agents/notes/implemented/bug-fix/2026-07-29-pnpm-setup-runner-isolation.md b/.agents/notes/implemented/bug-fix/2026-07-29-pnpm-setup-runner-isolation.md new file mode 100644 index 0000000000..743535d039 --- /dev/null +++ b/.agents/notes/implemented/bug-fix/2026-07-29-pnpm-setup-runner-isolation.md @@ -0,0 +1,27 @@ +# Agent Note: Isolate pnpm setup per GitHub Actions runner + +Status: implemented + +English | [中文](2026-07-29-pnpm-setup-runner-isolation.zh.md) + +## Problem + +`pnpm/action-setup@v4` defaults its install destination to `~/setup-pnpm` and replaces that directory during setup. The self-hosted CI failover runs six GitHub Actions runner services under one VM user, so concurrent jobs shared the same destination. In [run 30375670773](https://github.com/deepseek-harness/deepseek-harness/actions/runs/30375670773), three jobs entered pnpm setup within 73 milliseconds; one setup removed another process's current working directory and two jobs failed in Node's `uv_cwd` initialization. A retry on another runner passed, making the failure timing-dependent rather than a repository-test regression. + +## Decision + +Every `pnpm/action-setup` step in [the primary CI workflow](../../../../.github/workflows/ci.yml) sets `dest: ${{ runner.temp }}/setup-pnpm`. Each runner service owns its temporary directory, so one setup cannot replace another runner's install directory. Persistent store reuse remains separate through `PNPM_CONFIG_STORE_DIR`, as established by the [pnpm provisioning decision](../process/2026-07-26-pnpm-action-setup-for-symmetric-ci-caching.md). + +[The workflow regression test](../../../../scripts/ci-workflow.spec.ts) discovers every `pnpm/action-setup` step in `ci.yml` and rejects one without the runner-private destination. This keeps newly added jobs inside the same isolation boundary. + +## Alternatives considered + +**Serialize failover jobs.** Rejected because it discards the six-runner pool's intended parallelism and turns an action-local directory collision into queueing across otherwise independent jobs. + +**Assign a separate Unix user to every runner service.** This would also separate `HOME`, but it moves the invariant into external VM provisioning and complicates ownership of the deliberately shared persistent pnpm store. The workflow already receives a runner-private temporary directory. + +**Retry failed setup steps.** Rejected because retries only reduce the observed collision rate; another concurrent setup can remove the same shared directory again. + +## Consequences + +pnpm's executable installation is ephemeral and isolated per runner, while package downloads still use the configured persistent or cached store. Hosted jobs use the same explicit destination without changing cache policy. The workflow carries three extra configuration lines per setup step, and the regression test must be updated only if pnpm provisioning intentionally moves to a different isolation mechanism. diff --git a/.agents/notes/implemented/bug-fix/2026-07-29-pnpm-setup-runner-isolation.zh.md b/.agents/notes/implemented/bug-fix/2026-07-29-pnpm-setup-runner-isolation.zh.md new file mode 100644 index 0000000000..1e51070f88 --- /dev/null +++ b/.agents/notes/implemented/bug-fix/2026-07-29-pnpm-setup-runner-isolation.zh.md @@ -0,0 +1,27 @@ +# Agent Note: 按 GitHub Actions runner 隔离 pnpm 设置 + +Status: implemented + +[English](2026-07-29-pnpm-setup-runner-isolation.md) | 中文 + +## 问题 + +`pnpm/action-setup@v4` 的安装目标目录默认为 `~/setup-pnpm`，并会在设置期间替换该目录。自托管 CI 故障切换在同一个 VM 用户下运行六个 GitHub Actions runner 服务，因此并发作业会共用同一目标目录。在 [run 30375670773](https://github.com/deepseek-harness/deepseek-harness/actions/runs/30375670773) 中，三个作业在 73 毫秒内进入 pnpm 设置；其中一个设置过程删除了另一个进程的当前工作目录，导致两个作业在 Node 的 `uv_cwd` 初始化阶段失败。换到另一台 runner 重试后通过，说明该故障取决于时序，并非仓库测试回归。 + +## 决策 + +[主 CI 工作流](../../../../.github/workflows/ci.yml)中的每个 `pnpm/action-setup` 步骤都设置 `dest: ${{ runner.temp }}/setup-pnpm`。每个 runner 服务独占自己的临时目录，因此一个设置过程无法替换另一个 runner 的安装目录。持久 store 的复用仍由 `PNPM_CONFIG_STORE_DIR` 独立处理，遵循 [pnpm 提供机制决策](../process/2026-07-26-pnpm-action-setup-for-symmetric-ci-caching.md)。 + +[工作流回归测试](../../../../scripts/ci-workflow.spec.ts)会找出 `ci.yml` 中的每个 `pnpm/action-setup` 步骤，并拒绝缺少 runner 专属目标目录的步骤。这可确保后续新增的作业也处于同一隔离边界内。 + +## 曾考虑的替代方案 + +**串行执行故障切换作业。** 否决：这会牺牲由六个 runner 组成的池所具备的预期并行能力，并把 action 内部的目录冲突变成原本相互独立作业之间的队列等待。 + +**为每个 runner 服务分配独立的 Unix 用户。** 这同样能够隔离 `HOME`，但会把该不变量转移到外部 VM 配置中，并使刻意共享的持久 pnpm store 的所有权变得复杂。工作流已经获得 runner 专属临时目录。 + +**重试失败的设置步骤。** 否决：重试只能降低观测到的冲突发生率；另一个并发设置过程仍可能再次删除同一个共享目录。 + +## 后果 + +pnpm 可执行文件采用临时安装，并按 runner 隔离；包下载仍使用已配置的持久或缓存 store。托管作业使用相同的显式目标目录，不改变缓存政策。工作流中的每个设置步骤因此增加三行配置；只有在 pnpm 提供机制有意迁移到另一种隔离机制时，才需要更新回归测试。 diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8817fb325d..a8e30b9394 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -59,6 +59,8 @@ jobs: persist-credentials: false - uses: pnpm/action-setup@v4 + with: + dest: ${{ runner.temp }}/setup-pnpm - uses: actions/setup-node@v6 with: @@ -126,6 +128,8 @@ jobs: persist-credentials: false - uses: pnpm/action-setup@v4 + with: + dest: ${{ runner.temp }}/setup-pnpm - uses: actions/setup-node@v6 with: @@ -204,6 +208,8 @@ jobs: ${{ runner.os }}-node-${{ env.PRIMARY_NODE_VERSION }}-eslint-full- - uses: pnpm/action-setup@v4 + with: + dest: ${{ runner.temp }}/setup-pnpm - uses: actions/setup-node@v6 with: @@ -267,6 +273,8 @@ jobs: - uses: actions/checkout@v6 - uses: pnpm/action-setup@v4 + with: + dest: ${{ runner.temp }}/setup-pnpm - uses: actions/setup-node@v6 with: @@ -318,6 +326,8 @@ jobs: persist-credentials: false - uses: pnpm/action-setup@v4 + with: + dest: ${{ runner.temp }}/setup-pnpm - uses: actions/setup-node@v6 with: @@ -418,6 +428,8 @@ jobs: fetch-depth: 2 - uses: pnpm/action-setup@v4 + with: + dest: ${{ runner.temp }}/setup-pnpm - uses: actions/setup-node@v6 with: @@ -495,6 +507,8 @@ jobs: fetch-depth: 0 - uses: pnpm/action-setup@v4 + with: + dest: ${{ runner.temp }}/setup-pnpm - uses: actions/setup-node@v6 with: @@ -528,6 +542,8 @@ jobs: - uses: actions/checkout@v6 - uses: pnpm/action-setup@v4 + with: + dest: ${{ runner.temp }}/setup-pnpm - uses: actions/setup-node@v6 with: @@ -559,6 +575,8 @@ jobs: /t REG_DWORD /f /v "AllowDevelopmentWithoutDevLicense" /d "1" - uses: pnpm/action-setup@v4 + with: + dest: ${{ runner.temp }}/setup-pnpm - uses: actions/setup-node@v6 with: @@ -651,6 +669,8 @@ jobs: - uses: actions/checkout@v6 - uses: pnpm/action-setup@v4 + with: + dest: ${{ runner.temp }}/setup-pnpm # The Windows lanes deliberately skip the store cache like the required # windows job; an empty cache input disables setup-node's caching. @@ -740,6 +760,8 @@ jobs: - uses: actions/checkout@v6 - uses: pnpm/action-setup@v4 + with: + dest: ${{ runner.temp }}/setup-pnpm # Unlike the larger-runner suite, both platforms cache the store here: # the consolidated topology measures cache mechanics as workload. diff --git a/scripts/ci-workflow.spec.ts b/scripts/ci-workflow.spec.ts new file mode 100644 index 0000000000..7febf0049a --- /dev/null +++ b/scripts/ci-workflow.spec.ts @@ -0,0 +1,33 @@ +import { readFileSync } from 'node:fs' +import { resolve } from 'node:path' +import * as yaml from 'js-yaml' +import { describe, expect, it } from 'vitest' + +const root = resolve(import.meta.dirname, '..') +const runnerPrivatePnpmDestination = '${{ runner.temp }}/setup-pnpm' + +describe('CI workflow', () => { + it('isolates every pnpm action setup destination per runner', () => { + const workflow: unknown = yaml.load(readFileSync(resolve(root, '.github/workflows/ci.yml'), 'utf8')) + if (!isRecord(workflow) || !isRecord(workflow.jobs)) throw new TypeError('CI workflow must define jobs') + + const setups = Object.entries(workflow.jobs).flatMap(([jobName, job]) => { + if (!isRecord(job) || !Array.isArray(job.steps)) return [] + return job.steps.flatMap((step) => { + if (!isRecord(step) || typeof step.uses !== 'string' || !step.uses.startsWith('pnpm/action-setup@')) return [] + return [{ jobName, step }] + }) + }) + + expect(setups.length).toBeGreaterThan(0) + for (const { jobName, step } of setups) { + expect(step, `${jobName} must not share pnpm/action-setup's default destination`).toMatchObject({ + with: { dest: runnerPrivatePnpmDestination }, + }) + } + }) +}) + +function isRecord(value: unknown): value is Record { + return typeof value === 'object' && value !== null && !Array.isArray(value) +}