Address the D agentType removal + two #124 review findings on the CC bridge's
subagent points:
- **Payloads from base()**: `subagentStart/StopPayload` bypassed `base()`, so the
SubagentStart/SubagentStop stdin payloads omitted the CC-promised `session_id`
and `cwd`. Replaced both with a single `subagentPayload()` built from `base(child)`
(the child's session_id/cwd when the child is available) + `agent_id` +
`agent_type` (+ `stop_hook_active` on Stop).
- **SubagentStop runs in the child cwd**: the listener called `runPoint(..., {})`
with no agent, so the hook ran in the executor/server cwd. It now looks the
child up via `ctx.get('agents').get(info.id)` — still recoverable because
`subagent/end` fires from the service's detached `.then` BEFORE the tool caller
disposes the child — and passes `{ agent: child }`, matching SubagentStart.
New regression: server cwd ≠ child cwd, a `pwd` SubagentStop hook proves it
ran in the CHILD workspace (proven red by neutering the lookup).
- **agent_type is a constant**: `info.agentType` no longer exists (removed on the
subagent branch); both points now report the `SUBAGENT_TYPE = "general-purpose"`
constant (Claude Code's Task-tool default), so a hooks.json default/`*`/empty
`agent_type` matcher fires. Updated the README matcher-subject note and the
bridge/coverage tests (dropped their agentType emits).
- **e2e comment**: hooks.e2e.ts said `./hooks.json` loads from the session cwd;
corrected to process-level (server launch cwd), with the hook itself running
in the session cwd.
The two bridge plugins that run a user's existing Claude Code / Codex hook
config on the harness's typed interception seams, built on the shared
dsh-hook-protocol library. A bridge is a faithfulness adapter, not a power
tool: anything it does a native cordis plugin does more powerfully — the
bridge exists only to run UNMODIFIED external hooks.
- dsh-hooks-claude: CC dialect. Seven hook points (SessionStart,
UserPromptSubmit, PreToolUse, PostToolUse, Stop, SubagentStart,
SubagentStop), CC per-event stdin payloads, env + ${CLAUDE_PLUGIN_ROOT}/
${CLAUDE_PROJECT_DIR} substitution, literal-or-regex matcher.
- dsh-hooks-codex: Codex dialect — a deliberate subset. Five hook points,
always-regex matcher, snake_case payloads (turn_id/model, no trailing
newline), no env/substitution, block-only decisions.
Both map the neutral merged outcome onto the seam's typed Decision and stamp
an explicit {kind:'plugin'} source on injected context (so it is never
mislabeled as a user prompt). Config parse-failure is contained; only command
hooks run. updatedInput is logged+warned (input rewrite deferred); the Stop
loop-guard is deferred (TODO).
Tests: per-file 100% — config-parse unit branches + per-seam mappings
end-to-end through the REAL loop + REAL bash + REAL shell scripts (scripted
mock model only) + a real-Loader export-shape guard. A keyless ACP snapshot
scenario (hook-prompt-block) proves a UserPromptSubmit hook blocks a prompt
end-to-end (rejected turn -> ACP cancelled, hook/* events in the log); a
with-key e2e (hooks.e2e.ts) proves a PreToolUse hook blocks real bash
(verified on disk). The snapshot normalizer now scrubs hook/result.durationMs.
RFC: docs/rfc/implemented/feature/2026-06-30-hook-bridges.md
Tianyi Cui