/** * Tests for the queue-aware `Agent.cancel()` primitive. `cancel()` is the broad verb — it * clears queued + steering work, aborts an in-flight step, and drops a turn about to start — * whereas a bare step abort (the loop's private `AbortController`) kills only the current step * and leaves the queue intact. The suite covers every landing window plus marker * reset and `whenIdle()` quiescence. * @module dsh-agent-loop/tests/cancel */ import { describe, expect, it } from 'vitest' import { Context } from 'cordis' import LlmService, { type Message } from '@deepseek-ai/dsh-llm' import SessionStore, { SessionId, TurnEndReason } from '@deepseek-ai/dsh-session' import SystemPrompt from '@deepseek-ai/dsh-system-prompt' import ToolRegistry, { defineTool } from '@deepseek-ai/dsh-tools' import AgentRegistry, { type Agent } from '@deepseek-ai/dsh-agent' import AgentLoop from '@deepseek-ai/dsh-agent-loop' import { MockAdapter, textResponse, toolCallResponse } from './mock-adapter.ts' function driverDone(agent: Agent): Promise { return (agent as Agent & { done: Promise }).done } async function harness(adapter: MockAdapter) { const ctx = new Context() await ctx.plugin(LlmService) await ctx.plugin(SessionStore) await ctx.plugin(SystemPrompt) await ctx.plugin(ToolRegistry) await ctx.plugin(AgentRegistry) await ctx.plugin(AgentLoop, { agents: [] }) ctx.llm.registerAdapter(['mock'], adapter) return ctx } function send(agent: Agent, text: string) { agent.send([{ type: 'text', text }]) } /** Resolve on the agent's next idle transition (event-based, not status poll). */ function waitForIdle(ctx: Context, agent: Agent): Promise { return new Promise((resolve) => { const dispose = ctx.on('agent/status', (subject, status) => { if (subject === agent && status === 'idle') { dispose(); resolve() } }) }) } /** All user-message texts recorded in the log (to assert what actually ran). */ function userTexts(agent: Agent): string[] { return agent.session.events .filter(e => e.type === 'user/message') .flatMap(e => e.type === 'user/message' ? e.data.content : []) .flatMap(b => b.type === 'text' ? [b.text] : []) } describe('Agent.cancel()', () => { it('cancel() on an idle agent with nothing queued is a no-op; the next prompt runs (F2 leak guard)', async () => { const adapter = new MockAdapter([textResponse('reply')]) const ctx = await harness(adapter) const agent = ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' }) // The loop is parked at the idle wait with nothing queued. A cancel here must // NOT arm the marker — otherwise the next legitimate prompt would be dropped. agent.cancel('nothing to cancel') send(agent, 'real prompt') await waitForIdle(ctx, agent) // The prompt ran: its user message is in the log and one turn completed. expect(userTexts(agent)).toEqual(['real prompt']) expect(agent.session.events.some(e => e.type === 'turn/end')).toBe(true) }) it('pre-step cancel drops the about-to-start turn (no turn is opened)', async () => { const adapter = new MockAdapter([textResponse('should not run')]) const ctx = await harness(adapter) const agent = ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' }) // send() queues synchronously (status still idle, loop microtask not yet // resumed). Cancel in that pre-step window: the queued turn must not run. send(agent, 'drop me first') send(agent, 'drop me second') agent.cancel('pre-step') // Give the loop a chance to wake and process the cancel. await new Promise(r => setTimeout(r, 30)) // No turn was opened — the queued prompt was dropped, never recorded. expect(userTexts(agent)).toEqual([]) expect(agent.session.events.some(e => e.type === 'turn/start')).toBe(false) expect(agent.status).toBe('idle') }) it('disposal from the running notification drops queued work before turn start', async () => { const adapter = new MockAdapter([textResponse('should not run')]) const ctx = await harness(adapter) const handle = await ctx.agents.create({ sessionId: SessionId('dispose-running-session'), agentOptions: { provider: 'mock', model: 'mock' }, }) const agent = handle.agent const running = Promise.withResolvers() let disposalDone: Promise | undefined ctx.on('agent/status', (subject, status) => { if (subject !== agent || status !== 'running') return disposalDone = handle.dispose() running.resolve(undefined) }) send(agent, 'drop before claim') await running.promise if (disposalDone === undefined) throw new Error('running listener did not start disposal') await disposalDone await driverDone(agent) expect(agent.status).toBe('disposed') expect(agent.session.events.some(event => event.type === 'turn/start')).toBe(false) expect(userTexts(agent)).toEqual([]) expect(adapter.requests).toHaveLength(0) }) it('a whenIdle() waiter registered BEFORE a pre-step cancel resolves (F1 hang guard)', async () => { const adapter = new MockAdapter([textResponse('x')]) const ctx = await harness(adapter) const agent = ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' }) // This waiter cannot rely on a running→idle transition because cancellation // drops the turn before it runs; the skip path must settle it directly. send(agent, 'q') const idle = agent.whenIdle() agent.cancel('pre-step') // Must resolve (not hang). A timeout makes the failure a clear test failure. await Promise.race([ idle, new Promise((_r, reject) => setTimeout(() => { reject(new Error('whenIdle hung after pre-step cancel')) }, 1000)), ]) expect(agent.status).toBe('idle') }) it('cancel() between consecutive turns restores idle and leaves idle steer usable', async () => { const adapter = new MockAdapter([textResponse('first reply'), textResponse('steer reply')]) const ctx = await harness(adapter) const agent = ctx.agentLoop.create(SessionId('between-turn-cancel'), { provider: 'mock', model: 'mock' }) let rejectFirstFlush = true ctx.on('session/flush', (session) => { if (session !== agent.session || !rejectFirstFlush) return rejectFirstFlush = false throw new Error('first flush failed') }) const cancelled = Promise.withResolvers() ctx.on('agent/error', (subject, _turn, _step, error) => { if (subject !== agent || error.message !== 'first flush failed') return // The first hop runs before runLoop resumes from runTurn; the second lands // before its resolved waitForQueued continuation checks cancellation. queueMicrotask(() => { queueMicrotask(() => { agent.cancel('between turns') cancelled.resolve(undefined) }) }) }) const statuses: string[] = [] ctx.on('agent/status', (subject, status) => { if (subject === agent) statuses.push(status) }) send(agent, 'first') send(agent, 'queued tail') await cancelled.promise expect(agent.status).toBe('idle') expect(statuses).toEqual(['running', 'idle']) expect(adapter.requests).toHaveLength(1) expect(agent.session.events.filter(event => event.type === 'turn/start')).toHaveLength(1) expect(userTexts(agent)).toEqual(['first']) let idleResolved = false void agent.whenIdle().then(() => { idleResolved = true }) await Promise.resolve() expect(idleResolved).toBe(true) const idle = waitForIdle(ctx, agent) agent.steer([{ type: 'text', text: 'idle steer' }]) await idle expect(statuses).toEqual(['running', 'idle', 'running', 'idle']) expect(adapter.requests).toHaveLength(2) expect(userTexts(agent)).toEqual(['first', 'idle steer']) }) it('an idle-listener replacement keeps whenIdle pending until the replacement turn finishes', async () => { const adapter = new MockAdapter([textResponse('first reply'), textResponse('replacement reply')]) const ctx = await harness(adapter) const agent = ctx.agentLoop.create(SessionId('between-turn-idle-listener'), { provider: 'mock', model: 'mock' }) let rejectFirstFlush = true ctx.on('session/flush', (session) => { if (session !== agent.session || !rejectFirstFlush) return rejectFirstFlush = false throw new Error('first flush failed') }) ctx.on('agent/error', (subject, _turn, _step, error) => { if (subject !== agent || error.message !== 'first flush failed') return queueMicrotask(() => { queueMicrotask(() => { agent.cancel('between turns') }) }) }) const replacementRegistered = Promise.withResolvers() let replacementObservation: Promise<{ status: string; requests: number; turns: number }> | undefined ctx.on('agent/status', (subject, status) => { if (subject !== agent || status !== 'idle' || replacementObservation !== undefined) return send(agent, 'replacement') replacementObservation = agent.whenIdle().then(() => ({ status: agent.status, requests: adapter.requests.length, turns: agent.session.events.filter(event => event.type === 'turn/start').length, })) replacementRegistered.resolve(undefined) }) send(agent, 'first') send(agent, 'cancelled tail') await replacementRegistered.promise if (replacementObservation === undefined) throw new Error('idle listener did not register replacement work') await expect(replacementObservation).resolves.toEqual({ status: 'idle', requests: 2, turns: 2 }) expect(userTexts(agent)).toEqual(['first', 'replacement']) }) it('idle-listener cancellation settles its waiter without cancelling later work', async () => { const adapter = new MockAdapter([textResponse('first reply'), textResponse('later reply')]) const ctx = await harness(adapter) const agent = ctx.agentLoop.create(SessionId('idle-listener-cancel'), { provider: 'mock', model: 'mock' }) const replacementRegistered = Promise.withResolvers() let replacementObservation: Promise<{ status: string; requests: number; turns: number }> | undefined ctx.on('agent/status', (subject, status) => { if (subject !== agent || status !== 'idle' || replacementObservation !== undefined) return send(agent, 'cancelled replacement') replacementObservation = agent.whenIdle().then(() => ({ status: agent.status, requests: adapter.requests.length, turns: agent.session.events.filter(event => event.type === 'turn/start').length, })) agent.cancel('idle listener') replacementRegistered.resolve(undefined) }) send(agent, 'first') await replacementRegistered.promise if (replacementObservation === undefined) throw new Error('idle listener did not register replacement work') await expect(Promise.race([ replacementObservation, new Promise((_resolve, reject) => setTimeout(() => { reject(new Error('whenIdle hung after idle-listener cancel')) }, 1000)), ])).resolves.toEqual({ status: 'idle', requests: 1, turns: 1 }) const idle = waitForIdle(ctx, agent) send(agent, 'later') await idle expect(adapter.requests).toHaveLength(2) expect(userTexts(agent)).toEqual(['first', 'later']) }) it('replacement work queued after idle-listener cancellation still runs', async () => { const adapter = new MockAdapter([textResponse('first reply'), textResponse('replacement reply')]) const ctx = await harness(adapter) const agent = ctx.agentLoop.create(SessionId('idle-listener-post-cancel-send'), { provider: 'mock', model: 'mock' }) const replacementRegistered = Promise.withResolvers() let replacementIdle: Promise | undefined ctx.on('agent/status', (subject, status) => { if (subject !== agent || status !== 'idle' || replacementIdle !== undefined) return send(agent, 'cancelled replacement') agent.cancel('idle listener') send(agent, 'surviving replacement') replacementIdle = agent.whenIdle() replacementRegistered.resolve(undefined) }) send(agent, 'first') await replacementRegistered.promise if (replacementIdle === undefined) throw new Error('idle listener did not register replacement work') await replacementIdle expect(adapter.requests).toHaveLength(2) expect(userTexts(agent)).toEqual(['first', 'surviving replacement']) }) it('cancel() mid-step aborts the active turn and drops every queued tail item', async () => { const adapter = new MockAdapter(['hang']) const ctx = await harness(adapter) const agent = ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' }) const reasons: TurnEndReason[] = [] ctx.on('session/event', (_s, event) => { if (event.type === 'turn/end') reasons.push(event.data.reason) }) send(agent, 'go') await new Promise(r => setTimeout(r, 30)) expect(agent.status).toBe('running') send(agent, 'queued tail') agent.cancel('mid-step') await waitForIdle(ctx, agent) expect(reasons).toEqual([{ kind: 'aborted', reason: 'mid-step' }]) expect(userTexts(agent)).toEqual(['go']) expect(agent.session.events.filter(event => event.type === 'turn/start')).toHaveLength(1) expect(adapter.requests).toHaveLength(1) }) it('cancel() with no reason defaults to "cancelled" when aborting an in-flight step', async () => { const adapter = new MockAdapter(['hang']) const ctx = await harness(adapter) const agent = ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' }) const reasons: TurnEndReason[] = [] ctx.on('session/event', (_s, event) => { if (event.type === 'turn/end') reasons.push(event.data.reason) }) send(agent, 'go') await new Promise(r => setTimeout(r, 30)) agent.cancel() // no reason → default 'cancelled' await waitForIdle(ctx, agent) expect(reasons).toEqual([{ kind: 'aborted', reason: 'cancelled' }]) }) it('cancel from an assistant/message observer skips execution but balances replay', async () => { const adapter = new MockAdapter([ toolCallResponse('c1', 'danger', {}), textResponse('recovered after cancellation'), ]) const ctx = await harness(adapter) let executions = 0 ctx.tools.register(defineTool({ name: 'danger', description: 'must not run after cancellation', parameters: {}, async execute() { executions += 1 return [{ type: 'text', text: 'ran' }] }, })) const agent = ctx.agentLoop.create(SessionId('cancel-after-assistant-message'), { provider: 'mock', model: 'mock' }) const dispose = ctx.on('session/event', (session, event) => { if (session === agent.session && event.type === 'assistant/message') { agent.cancel('cancelled after assistant message') } }) const reasons: TurnEndReason[] = [] ctx.on('session/event', (_session, event) => { if (event.type === 'turn/end') reasons.push(event.data.reason) }) send(agent, 'go') await waitForIdle(ctx, agent) dispose() expect(executions).toBe(0) expect(reasons).toEqual([{ kind: 'aborted', reason: 'cancelled after assistant message' }]) const call = agent.session.events.find(event => event.type === 'tool/call') const result = agent.session.events.find(event => event.type === 'tool/result') expect(call?.type === 'tool/call' ? call.data.callId : undefined).toBe('c1') expect(result?.type === 'tool/result' ? result.data : undefined).toMatchObject({ callId: 'c1', isError: true, error: { name: 'AbortError', code: 'ABORTED' }, }) send(agent, 'continue safely') await waitForIdle(ctx, agent) const replayedResult = adapter.requests[1]!.messages .flatMap(message => message.content) .find(block => block.type === 'tool-result') expect(replayedResult).toMatchObject({ toolCallId: 'c1', isError: true }) expect(reasons).toEqual([ { kind: 'aborted', reason: 'cancelled after assistant message' }, { kind: 'completed' }, ]) }) it('a prompt sent AFTER a cancelled turn settles runs normally (marker reset)', async () => { const adapter = new MockAdapter(['hang', textResponse('second reply')]) const ctx = await harness(adapter) const agent = ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' }) // First turn hangs; cancel it mid-step. send(agent, 'first') await new Promise(r => setTimeout(r, 30)) agent.cancel('cancel first') await waitForIdle(ctx, agent) // The marker must have been reset after the cancelled turn — a fresh prompt // runs to completion rather than being dropped by a stale marker. send(agent, 'second') await waitForIdle(ctx, agent) expect(userTexts(agent)).toContain('second') // The second turn completed (its reply was streamed). const reasons = agent.session.events.filter(e => e.type === 'turn/end') expect(reasons.length).toBe(2) }) it('cancel from inside the agent/session-prefix waterfall drops the step (prefix-composition window)', async () => { const adapter = new MockAdapter([textResponse('should not stream')]) const ctx = await harness(adapter) const agent = ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' }) // Prefix composition runs before the pre-step seam on the instance's first // step; a cancel landing inside it must drop the about-to-start step // without running the seam or the model. let streamed = false ctx.on('session/event', (_s, event) => { if (event.type === 'assistant/chunk') streamed = true }) ctx.on('agent/session-prefix', async (_agent, _prefix, _signal, next) => { agent.cancel('from prefix composition') return next() }) const reasons: TurnEndReason[] = [] ctx.on('session/event', (_s, event) => { if (event.type === 'turn/end') reasons.push(event.data.reason) }) send(agent, 'go') await waitForIdle(ctx, agent) expect(streamed).toBe(false) expect(reasons).toEqual([{ kind: 'aborted', reason: 'from prefix composition' }]) }) it('disposal from inside the agent/session-prefix waterfall ends the turn disposed (prefix-composition window)', async () => { const adapter = new MockAdapter([textResponse('should not stream')]) const ctx = new Context() await ctx.plugin(LlmService) await ctx.plugin(SessionStore) await ctx.plugin(SystemPrompt) await ctx.plugin(ToolRegistry) await ctx.plugin(AgentRegistry) await ctx.plugin(AgentLoop, { agents: [] }) ctx.llm.registerAdapter(['mock'], adapter) const handle = await ctx.agents.create({ sessionId: SessionId('dispose-prefix-session'), agentOptions: { provider: 'mock', model: 'mock' }, }) const agent = handle.agent let disposalDone: Promise | undefined let streamed = false ctx.on('session/event', (_s, event) => { if (event.type === 'assistant/chunk') streamed = true }) ctx.on('agent/session-prefix', async (_agent, _prefix, _signal, next) => { disposalDone = handle.dispose() return next() }) send(agent, 'go') await new Promise(resolve => setTimeout(resolve, 0)) await disposalDone await driverDone(agent) // No step opened, no model call ran, and the turn closed disposed. expect(streamed).toBe(false) expect(adapter.requests).toHaveLength(0) const turnEnd = agent.session.events.findLast(e => e.type === 'turn/end') expect(turnEnd?.type === 'turn/end' && turnEnd.data.reason).toEqual({ kind: 'disposed' }) }) it('a cancel-interrupted prefix composition is discarded: the next send recomposes and ships the fresh prefix (stale-cache guard)', async () => { const adapter = new MockAdapter([textResponse('reply')]) const ctx = await harness(adapter) const agent = ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' }) // The interrupted first composition must not cache its degraded empty value; // the next prompt recomposes and logs/sends the fresh prefix. const opener: Message = { role: 'user', content: [{ type: 'text', text: 'fresh opener' }] } let compositions = 0 ctx.on('agent/session-prefix', async (_agent, _prefix, _signal, next): Promise => { compositions += 1 if (compositions === 1) { agent.cancel('mid-composition') return next() } return [opener, ...await next()] }) send(agent, 'dropped') await waitForIdle(ctx, agent) send(agent, 'real prompt') await waitForIdle(ctx, agent) expect(compositions).toBe(2) expect(adapter.requests).toHaveLength(1) expect(adapter.requests[0]?.messages[0]).toEqual(opener) const headerEvent = agent.session.events.find(e => e.type === 'request/header') expect(headerEvent?.type === 'request/header' && headerEvent.data.header.messagePrefix).toEqual([opener]) }) it('cancel from a synchronous turn/start session-event listener drops the step (step-start window)', async () => { const adapter = new MockAdapter([textResponse('should not stream')]) const ctx = await harness(adapter) const agent = ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' }) // A turn/start listener fires before a step controller exists, so the // turn-scoped marker—not step abort—must drop the pending step. let streamed = false ctx.on('session/event', (_s, event) => { if (event.type === 'assistant/chunk') streamed = true }) const dispose = ctx.on('session/event', (session, event) => { if (session === agent.session && event.type === 'turn/start') agent.cancel('from turn-start') }) const reasons: TurnEndReason[] = [] ctx.on('session/event', (_s, event) => { if (event.type === 'turn/end') reasons.push(event.data.reason) }) send(agent, 'go') await waitForIdle(ctx, agent) dispose() // No step streamed (the model never ran), and the turn ended aborted with // the CALLER's reason — the marker carries `cancel(reason)` through even // though no AbortController observed it in this window. expect(streamed).toBe(false) expect(reasons).toEqual([{ kind: 'aborted', reason: 'from turn-start' }]) }) it('cancel from a synchronous step/start session-event listener drops the step (post-step-start window)', async () => { const adapter = new MockAdapter([textResponse('should not stream')]) const ctx = await harness(adapter) const agent = ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' }) // A step/start session-event listener fires AFTER step/start is appended // (and after the pre-step seam), so cancelling there lands in the SECOND // cancel check (the one that must closeStep() to balance the already-open // step) — distinct from a turn-start cancel, caught before the step opens. let streamed = false ctx.on('session/event', (_s, event) => { if (event.type === 'assistant/chunk') streamed = true }) const dispose = ctx.on('session/event', (session, event) => { if (session === agent.session && event.type === 'step/start') agent.cancel('from step-start') }) const reasons: TurnEndReason[] = [] ctx.on('session/event', (_s, event) => { if (event.type === 'turn/end') reasons.push(event.data.reason) }) send(agent, 'go') await waitForIdle(ctx, agent) dispose() // No step streamed, the turn ended aborted with the caller's reason, and the // log is balanced (the open step was closed by the cancel branch). expect(streamed).toBe(false) expect(reasons).toEqual([{ kind: 'aborted', reason: 'from step-start' }]) const types = agent.session.events.map(e => e.type) expect(types.filter(t => t === 'step/start').length).toBe(types.filter(t => t === 'step/end').length) }) it('disposal from a synchronous step/start session-event listener closes the open step as disposed', async () => { const adapter = new MockAdapter([textResponse('should not stream')]) const ctx = new Context() await ctx.plugin(LlmService) await ctx.plugin(SessionStore) await ctx.plugin(SystemPrompt) await ctx.plugin(ToolRegistry) await ctx.plugin(AgentRegistry) await ctx.plugin(AgentLoop, { agents: [] }) ctx.llm.registerAdapter(['mock'], adapter) const handle = await ctx.agents.create({ sessionId: SessionId('dispose-step-start-session'), agentOptions: { provider: 'mock', model: 'mock' }, }) const agent = handle.agent let disposalDone: Promise | undefined let streamed = false ctx.on('session/event', (_s, event) => { if (event.type === 'assistant/chunk') streamed = true }) ctx.on('session/event', (session, event) => { if (session === agent.session && event.type === 'step/start') disposalDone = handle.dispose() }) send(agent, 'go') await disposalDone await driverDone(agent) expect(streamed).toBe(false) expect(adapter.requests).toHaveLength(0) const turnEnd = agent.session.events.findLast(e => e.type === 'turn/end') expect(turnEnd?.type === 'turn/end' && turnEnd.data.reason).toEqual({ kind: 'disposed' }) const types = agent.session.events.map(e => e.type) expect(types.filter(t => t === 'step/start').length).toBe(types.filter(t => t === 'step/end').length) }) it('cancel during the continuation window ends the turn aborted and runs no further step', async () => { // A continuation-waterfall listener cancels DURING the continuation decision // (the finished step's AbortController is already cleared), and votes to // continue — but the turn-scoped marker checked right after must end the turn // `aborted` and run NO second step. const adapter = new MockAdapter([textResponse('one'), textResponse('two')]) const ctx = await harness(adapter) const agent = ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' }) let steps = 0 const reasons: TurnEndReason[] = [] ctx.on('session/event', (_session, event) => { if (event.type === 'step/start') steps += 1 if (event.type === 'turn/end') reasons.push(event.data.reason) }) let continued = false ctx.on('agent/turn-continuation', async (subject, _turn, _default, next) => { if (subject === agent && !continued) { continued = true agent.cancel('from continuation') return { action: 'continue' as const } // vote to continue — the post-waterfall marker check must override } return next() }) send(agent, 'go') await waitForIdle(ctx, agent) // Only ONE step ran (the second was cancelled in the continuation window), // and the turn ended aborted with the CALLER's reason (carried by the // marker, since the finished step's AbortController was already cleared). expect(steps).toBe(1) expect(reasons).toEqual([{ kind: 'aborted', reason: 'from continuation' }]) }) it('cancel from a synchronous agent/status(running) listener drops the turn (window 2)', async () => { const adapter = new MockAdapter([textResponse('should not run')]) const ctx = await harness(adapter) const agent = ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' }) // `agent/status` is synchronous, so cancellation can land after the first // pre-step check; the second check must drop the now-empty turn. let streamed = false ctx.on('session/event', (_s, event) => { if (event.type === 'assistant/chunk') streamed = true }) const dispose = ctx.on('agent/status', (subject, status) => { if (subject === agent && status === 'running') agent.cancel('from running listener') }) send(agent, 'go') await waitForIdle(ctx, agent) dispose() // No turn opened, no step streamed, and a later prompt still runs (the marker // was reset). expect(streamed).toBe(false) expect(agent.session.events.some(e => e.type === 'turn/start')).toBe(false) }) it('window 2: whenIdle() does NOT resolve early when a running listener cancels then queues replacement work', async () => { // Cancellation must not settle idle while replacement work remains queued. const adapter = new MockAdapter([textResponse('A reply'), textResponse('B reply')]) const ctx = await harness(adapter) const agent = ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' }) let replaced = false const dispose = ctx.on('agent/status', (subject, status) => { if (subject !== agent || status !== 'running' || replaced) return replaced = true agent.cancel('drop A') send(agent, 'B') }) send(agent, 'A') const idle = agent.whenIdle() await idle dispose() // whenIdle() resolved only AFTER B's turn ran: B's user message + a turn/end // are in the log, and A was dropped. expect(userTexts(agent)).toContain('B') expect(userTexts(agent)).not.toContain('A') expect(agent.session.events.some(e => e.type === 'turn/end')).toBe(true) }) it('whenIdle() does NOT resolve early when a new prompt is queued during a pre-step cancel', async () => { // The subtle race: a whenIdle() waiter is registered for prompt A; cancel() clears A; // prompt B is queued before the loop resumes from the idle wait. const adapter = new MockAdapter([textResponse('A reply'), textResponse('B reply')]) const ctx = await harness(adapter) const agent = ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' }) send(agent, 'A') // queues A (status still idle, loop microtask pending) const idle = agent.whenIdle() // registers a waiter (idle + hasQueued → no fast path) agent.cancel('drop A') // arms marker, clears A send(agent, 'B') // B races in before the loop resumes // whenIdle() must resolve only after B's turn fully ran — by which point B's user message // and a turn/end are in the log. await idle expect(userTexts(agent)).toContain('B') expect(agent.session.events.some(e => e.type === 'turn/end')).toBe(true) // A was dropped (never ran); only B's turn is recorded. expect(userTexts(agent)).not.toContain('A') }) it("cancel clears the turn's steering — it is not re-enqueued as a fresh turn", async () => { const adapter = new MockAdapter(['hang']) const ctx = await harness(adapter) const agent = ctx.agentLoop.create(SessionId('a1'), { provider: 'mock', model: 'mock' }) send(agent, 'go') await new Promise(r => setTimeout(r, 30)) expect(agent.status).toBe('running') // Steer (joins the running turn's steering FIFO), then cancel: the steering // must be dropped, NOT re-enqueued as a new queued turn. agent.steer([{ type: 'text', text: 'steer text' }]) agent.cancel('cancel with steering') await waitForIdle(ctx, agent) // After the cancelled turn settles, the agent is idle with NO follow-up turn // started from the dropped steering. await new Promise(r => setTimeout(r, 30)) expect(agent.status).toBe('idle') const turnStarts = agent.session.events.filter(e => e.type === 'turn/start') expect(turnStarts.length).toBe(1) // only the original (cancelled) turn // The steering text was dropped — it never reached the log. const flat = agent.session.events .filter(e => e.type === 'steering/message') .flatMap(e => e.type === 'steering/message' ? e.data.content : []) .flatMap(b => b.type === 'text' ? [b.text] : []) expect(flat).not.toContain('steer text') }) })