import { describe, expect, expectTypeOf, it } from 'vitest' import { Context } from 'cordis' import { carrierKeyOf, createScope, isScopeCarrier, scopeHost, scopeOf, scopeTarget } from '@deepseek-ai/dsh-scope' import type { Scope, ScopeKey, Scoped } from '@deepseek-ai/dsh-scope' declare module 'cordis' { interface Events { /** * Test-only event for exercising scope-filtered dispatch. * @param value - opaque payload recorded by listeners. * @mode emit */ 'scope-test/ping'(value: string): void /** * Test-only waterfall for exercising carrier `this` shape. * @param value - seed value listeners may wrap. * @mode waterfall */ 'scope-test/echo'(value: string, next: () => string): string } } /** Mount a host plugin and mint a scope inside it, returning both. */ async function mintScope(ctx: Context, key: object): Promise { let scope!: Scope await ctx.plugin((inner: Context) => { scope = createScope(inner, key) }) return scope } describe('createScope', () => { it('rejects primitive keys but accepts callable objects (matching ScopeKey)', async () => { const ctx = new Context() // Typed through `unknown` so the ScopeKey type cannot argue the assertion // away: this test exercises exactly the callers the typechecker misses. const badKeys: unknown[] = ['k', null] for (const bad of badKeys) { expect(() => createScope(ctx, bad as ScopeKey)).toThrow(/must be a non-null object or function/) } const callable = Object.assign(() => {}, { nameForTest: 'callable-key' }) const scope = await mintScope(ctx, callable) expect(scopeOf(scope.ctx)).toBe(callable) await scope.dispose() }) it('tags the scoped context, readable through derivations (nearest tag wins)', async () => { const ctx = new Context() const key = { name: 'a' } const inner = { name: 'a.inner' } const scope = await mintScope(ctx, key) expect(scopeOf(scope.ctx)).toBe(key) // An extend of the scoped context inherits the tag through the prototype chain. expect(scopeOf(scope.ctx.extend({}))).toBe(key) // A plain context carries no tag. expect(scopeOf(ctx)).toBeUndefined() // A fiber mounted UNDER the scoped context reads as that scope… let mountedCtx!: Context await scope.ctx.plugin((c: Context) => { mountedCtx = c }) expect(scopeOf(mountedCtx)).toBe(key) // …and a nested scope shadows the outer tag (nearest wins). const nested = createScope(scope.ctx, inner) expect(scopeOf(nested.ctx)).toBe(inner) }) it('is usable synchronously: registrations land before the fiber activates', async () => { const ctx = new Context() const events: string[] = [] await ctx.plugin((inner: Context) => { const scope = createScope(inner, { name: 'sync' }) // Same tick as createScope — no await between mint and use. scope.ctx.effect(() => () => void events.push('effect-disposed')) scope.ctx.on('scope-test/ping', value => void events.push(`heard:${value}`)) events.push('registered') }) ctx.emit(scopeTarget(ctx, undefined), 'scope-test/ping', 'nobody') expect(events).toEqual(['registered']) }) it('dispose() unwinds registrations, is idempotent, and inerts the context', async () => { const ctx = new Context() const scope = await mintScope(ctx, { name: 'd' }) const order: string[] = [] scope.ctx.effect(() => () => void order.push('a')) scope.ctx.effect(() => () => void order.push('b')) await scope.dispose() expect(order).toEqual(['b', 'a']) // LIFO within the scope fiber // Repeat dispose: the underlying cordis disposer returns undefined; the // wrapper still resolves. await expect(scope.dispose()).resolves.toBeUndefined() // Registration through a disposed scope throws INACTIVE_EFFECT. expect(() => scope.ctx.effect(() => () => {})).toThrow(/inactive context/) }) it('dispose() follows a rawDispose-first race through async quiescence', async () => { const ctx = new Context() const scope = await mintScope(ctx, { name: 'raw-first' }) const gate = Promise.withResolvers() let cleanupFinished = false scope.ctx.effect(() => async () => { await gate.promise cleanupFinished = true }) const raw = Promise.resolve(scope.rawDispose()) let publicSettled = false const publicDispose = scope.dispose().then(() => { publicSettled = true }) await Promise.resolve() expect(publicSettled).toBe(false) expect(cleanupFinished).toBe(false) gate.resolve(undefined) await Promise.all([raw, publicDispose]) expect(cleanupFinished).toBe(true) await expect(scope.dispose()).resolves.toBeUndefined() }) it('rawDispose is the exact cordis disposer: yielding it nests the scope at its position', async () => { const ctx = new Context() const order: string[] = [] let composite!: () => Promise | void await ctx.plugin((inner: Context) => { composite = inner.effect(function* () { yield () => void order.push('outermost') // disposed LAST const scope = createScope(inner, { name: 'nested' }) scope.ctx.effect(() => () => void order.push('scope-registration')) yield scope.rawDispose // disposed SECOND — nested by identity yield () => void order.push('innermost') // disposed FIRST }) }) await composite() // The scope disposed exactly at its yield position (between the two // neighbours), not as a concurrent sibling of the composite. expect(order).toEqual(['innermost', 'scope-registration', 'outermost']) }) }) describe('scopeTarget dispatch filtering', () => { it('scoped listeners hear only their key; untagged listeners hear everything', async () => { const ctx = new Context() const keyA = { name: 'A' } const keyB = { name: 'B' } const scopeA = await mintScope(ctx, keyA) const scopeB = await mintScope(ctx, keyB) const heard: string[] = [] ctx.on('scope-test/ping', value => void heard.push(`global:${value}`)) scopeA.ctx.on('scope-test/ping', value => void heard.push(`A:${value}`)) scopeB.ctx.on('scope-test/ping', value => void heard.push(`B:${value}`)) ctx.emit(scopeTarget(ctx, keyA), 'scope-test/ping', 'to-A') ctx.emit(scopeTarget(ctx, keyB), 'scope-test/ping', 'to-B') ctx.emit(scopeTarget(ctx, undefined), 'scope-test/ping', 'to-nobody') expect(heard).toEqual([ 'global:to-A', 'A:to-A', 'global:to-B', 'B:to-B', 'global:to-nobody', ]) }) it('{ global: true } listeners bypass scope filtering entirely', async () => { const ctx = new Context() const keyA = { name: 'A' } const scopeA = await mintScope(ctx, keyA) const heard: string[] = [] scopeA.ctx.on('scope-test/ping', value => void heard.push(`escape:${value}`), { global: true }) ctx.emit(scopeTarget(ctx, { name: 'other' }), 'scope-test/ping', 'foreign') ctx.emit(scopeTarget(ctx, undefined), 'scope-test/ping', 'nobody') expect(heard).toEqual(['escape:foreign', 'escape:nobody']) }) it("composes the base's own Context.filter (a rejecting base filter wins)", async () => { const ctx = new Context() const keyA = { name: 'A' } const scopeA = await mintScope(ctx, keyA) const heard: string[] = [] ctx.on('scope-test/ping', value => void heard.push(`global:${value}`)) scopeA.ctx.on('scope-test/ping', value => void heard.push(`A:${value}`)) // A base whose own filter rejects every listener context: nothing fires, // scoped or not — the scope predicate never overrides the base's veto. const vetoBase = { [Context.filter]: () => false } ctx.emit(scopeTarget(vetoBase, keyA), 'scope-test/ping', 'vetoed') expect(heard).toEqual([]) // A base whose filter accepts delegates to the scope predicate. const openBase = { [Context.filter]: () => true } ctx.emit(scopeTarget(openBase, keyA), 'scope-test/ping', 'open') expect(heard).toEqual(['global:open', 'A:open']) }) it('keeps listener `this` base-shaped through the carrier (waterfall)', async () => { const ctx = new Context() const base = { label: 'the-base' } let seenLabel: string | undefined ctx.on('scope-test/echo', function (this: { label: string }, value, next) { seenLabel = this.label return `${next()}+${value}` }) const result = ctx.waterfall(scopeTarget(base, undefined), 'scope-test/echo', 'v', () => 'seed') expect(result).toBe('seed+v') expect(seenLabel).toBe('the-base') }) it('is transparent for subjects with native #private fields: methods and getters through the carrier reach the real object', () => { // The ds-review-bot regression: cordis hands the carrier to listeners as // `this` (typed Scoped), so subject method calls through it are a // supported shape. A proxy that delegates with the PROXY as receiver // (cordis withProps) throws TypeError on any native #private the method // or getter touches; the carrier must delegate with the BASE as receiver // and bind retrieved methods to it. class Subject { #count = 0 bump(): number { return ++this.#count } get count(): number { return this.#count } } const subject = new Subject() const carrier = scopeTarget(subject, subject) expect(carrier.bump()).toBe(1) // method call: bound to the base expect(subject.count).toBe(1) // ...and it mutated the REAL object expect(carrier.count).toBe(1) // getter: runs with the base as receiver // The get trap returns the method already bound to the base; // detachability IS the assertion. // eslint-disable-next-line @typescript-eslint/unbound-method const detached = carrier.bump expect(detached()).toBe(2) }) it('delegates sets to the base and leaves frozen own function props unbound (proxy invariant)', () => { const frozenFn = (): string => 'frozen' const base: { mutable: number; pinned: () => string; toString: () => string } = { mutable: 0, pinned: frozenFn, toString: () => 'base-str', } Object.defineProperty(base, 'pinned', { value: frozenFn, writable: false, configurable: false }) const carrier = scopeTarget(base, undefined) carrier.mutable = 7 expect(base.mutable).toBe(7) // sets land on the base, not a detached overlay // A non-configurable, non-writable own data prop must be reported // unchanged (binding it would violate the proxy get invariant). expect(carrier.pinned).toBe(frozenFn) // The overlay literal inherits Object.prototype; hasOwn (not `in`) keeps // it from shadowing the subject's own prototype-surface members. expect(String(carrier)).toBe('base-str') }) it('honors the get invariant even when an overlay key collides with a frozen own prop of the base', () => { // Pathological but engine-enforced: a base whose own [Context.filter] is // a non-configurable, non-writable data prop pins what any proxy over it // may report for that key. The carrier must yield the base's value (an // overlay there would be a runtime TypeError from the engine, not a // filtering choice). Such a base forgoes scope filtering by construction. const pinnedFilter = (): boolean => true const base = {} Object.defineProperty(base, Context.filter, { value: pinnedFilter, writable: false, configurable: false }) const carrier = scopeTarget(base, { name: 'key' }) expect((carrier as Record)[Context.filter]).toBe(pinnedFilter) }) it('keeps the real constructor: class identity survives the carrier', () => { class Subject { work(): string { return 'w' } } const subject = new Subject() const carrier = scopeTarget(subject, subject) // `constructor` is looked up, never invoked as a subject method — binding // it would break `carrier.constructor === Subject` for no benefit. expect(carrier.constructor).toBe(Subject) }) }) describe('carrier marks', () => { it('isScopeCarrier / carrierKeyOf distinguish carriers, keys, and bare subjects', () => { const base = { name: 'base' } const key = { name: 'key' } const keyed = scopeTarget(base, key) const subjectless = scopeTarget(base, undefined) expect(isScopeCarrier(keyed)).toBe(true) expect(carrierKeyOf(keyed)).toBe(key) expect(isScopeCarrier(subjectless)).toBe(true) expect(carrierKeyOf(subjectless)).toBeUndefined() expect(isScopeCarrier(base)).toBe(false) expect(carrierKeyOf(base)).toBeUndefined() expect(isScopeCarrier(null)).toBe(false) expect(isScopeCarrier('x')).toBe(false) }) it('brands the carrier type (compile-time)', () => { const base = { name: 'base' } const carrier = scopeTarget(base, undefined) expectTypeOf(carrier).toExtend>() // A bare subject is NOT assignable where a carrier is demanded. expectTypeOf(base).not.toExtend>() }) }) describe('scopeHost', () => { it('mints scopes that reach the injected services; dispose unwinds them all', async () => { const ctx = new Context() ctx.provide('answers', { value: 42 }) const host = await scopeHost(ctx, ['answers']) const scope = host.mint({ name: 'a' }) expect((scope.ctx as Context & { answers: { value: number } }).answers.value).toBe(42) const order: string[] = [] scope.ctx.effect(() => () => void order.push('scoped-disposed')) await host.dispose() expect(order).toEqual(['scoped-disposed']) expect(() => scope.ctx.effect(() => () => {})).toThrow(/inactive context/) }) it('dispose waits for a child whose raw disposer won the race', async () => { const ctx = new Context() ctx.provide('answers', { value: 42 }) const host = await scopeHost(ctx, ['answers']) const scope = host.mint({ name: 'raw-first-child' }) const gate = Promise.withResolvers() let cleanupFinished = false scope.ctx.effect(() => async () => { await gate.promise cleanupFinished = true }) const raw = Promise.resolve(scope.rawDispose()) let hostSettled = false const hostDispose = host.dispose().then(() => { hostSettled = true }) await Promise.resolve() expect(hostSettled).toBe(false) gate.resolve(undefined) await Promise.all([raw, hostDispose]) expect(cleanupFinished).toBe(true) await expect(host.dispose()).resolves.toBeUndefined() }) it('reaches every child before surfacing one or multiple disposal failures', async () => { const oneCtx = new Context() oneCtx.provide('answers', { value: 42 }) const oneHost = await scopeHost(oneCtx, ['answers']) const one = oneHost.mint({ name: 'one' }) one.dispose = () => Promise.reject(new Error('one failed')) await expect(oneHost.dispose()).rejects.toThrow('one failed') const manyCtx = new Context() manyCtx.provide('answers', { value: 42 }) const manyHost = await scopeHost(manyCtx, ['answers']) const a = manyHost.mint({ name: 'a' }) const b = manyHost.mint({ name: 'b' }) a.dispose = () => Promise.reject(new Error('a failed')) b.dispose = () => Promise.reject(new Error('b failed')) await expect(manyHost.dispose()).rejects.toMatchObject({ name: 'AggregateError', message: 'scopeHost: disposal failed', errors: [expect.objectContaining({ message: 'a failed' }), expect.objectContaining({ message: 'b failed' })], }) }) it('fails LOUD naming absent services instead of resolving as a silent no-op host', async () => { const ctx = new Context() await expect(scopeHost(ctx, ['tools', 'systemPrompt'])) .rejects.toThrow('scopeHost: services "tools", "systemPrompt" not available') }) it('names a single absent service in the singular', async () => { const ctx = new Context() await expect(scopeHost(ctx, ['tools'])).rejects.toThrow('scopeHost: service "tools" not available') }) })