Yichen Jiang
184e164091
One shared ctx.tasks registry (branded <kind>-N ids, owner-fenced read/kill/wait/list, attachSurface misconfiguration fence, reported-flag notice dedup, atomic register) + dsh-tool-tasks (task_output/task_list/ task_kill, completion-notice injection, background prompt habit). Producers opt in via their own enableRunInBackground config: bash (stream kind; seam slimmed to resolve/run/start returning a BashProcess handle, bash_output/bash_kill deleted) and subagent (final-output kind; done settles after run.dispose()). Owner disposal drains tasks through the new awaited ctx.agents.onCleanup seam in the loop's disposal chain. Both RFCs moved to implemented/; docs, catalogs, snapshots re-pinned.
79 lines
2.6 KiB
TypeScript
79 lines
2.6 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
import { Context } from 'cordis'
|
|
import { BashExecutor } from '@deepseek-ai/dsh-bash'
|
|
import type { BashExecRequest, BashExecSpec, BashProcess, BashProcessRead, BashRunResult } from '@deepseek-ai/dsh-bash'
|
|
|
|
/**
|
|
* Minimal concrete executor: canned foreground results, a hand-built process
|
|
* handle. The seam is TASK-FREE (start returns a {@link BashProcess} handle;
|
|
* task semantics live in `ctx.tasks`), so this stub is all an implementation
|
|
* owes the abstract class.
|
|
*/
|
|
class StubExecutor extends BashExecutor {
|
|
resolve(request: BashExecRequest): BashExecSpec {
|
|
return {
|
|
command: request.command,
|
|
workdir: request.workdir ?? '/stub',
|
|
timeoutMs: request.timeoutMs ?? 1000,
|
|
...request.signal ? { signal: request.signal } : {},
|
|
}
|
|
}
|
|
|
|
async run(spec: BashExecSpec): Promise<BashRunResult> {
|
|
return {
|
|
exitCode: 0,
|
|
signal: null,
|
|
timedOut: false,
|
|
aborted: false,
|
|
timeoutMs: spec.timeoutMs,
|
|
stdout: { text: 'ok', truncated: false },
|
|
stderr: { text: '', truncated: false },
|
|
}
|
|
}
|
|
|
|
start(spec: BashExecSpec): BashProcess {
|
|
const proc: BashProcess = {
|
|
command: spec.command,
|
|
status: 'running',
|
|
exitCode: null,
|
|
signal: null,
|
|
done: Promise.resolve(),
|
|
readOutput: (): BashProcessRead => ({ delta: '', lossy: false }),
|
|
kill: (): boolean => {
|
|
if (proc.status !== 'running') return false
|
|
proc.status = 'killed'
|
|
return true
|
|
},
|
|
}
|
|
return proc
|
|
}
|
|
}
|
|
|
|
describe('BashExecutor service seam', () => {
|
|
it('a concrete subclass registers as ctx.bash and serves the abstract API', async () => {
|
|
const ctx = new Context()
|
|
await ctx.plugin(StubExecutor)
|
|
const spec = ctx.bash.resolve({ command: 'echo hi' })
|
|
expect(spec).toEqual({ command: 'echo hi', workdir: '/stub', timeoutMs: 1000 })
|
|
|
|
const result = await ctx.bash.run(spec)
|
|
expect(result.exitCode).toBe(0)
|
|
expect(result.stdout.text).toBe('ok')
|
|
|
|
const proc = ctx.bash.start(spec)
|
|
expect(proc.command).toBe('echo hi')
|
|
expect(proc.status).toBe('running')
|
|
expect(proc.readOutput()).toEqual({ delta: '', lossy: false })
|
|
expect(proc.kill()).toBe(true)
|
|
expect(proc.kill()).toBe(false) // already settled → no-op
|
|
await proc.done
|
|
})
|
|
|
|
it('loading a second implementation throws (one bash service per context — cordis standard)', async () => {
|
|
const ctx = new Context()
|
|
await ctx.plugin(StubExecutor)
|
|
class SecondExecutor extends StubExecutor {}
|
|
await expect(ctx.plugin(SecondExecutor)).rejects.toThrow(/service "bash" has been registered/)
|
|
})
|
|
})
|