imccyu
1b0ea07bce
The definitive slot model for the web client, replacing the first-generation
define/register two-step, ScopedSlots whitelist faces, and binding handles:
- 'root' is the only a-priori slot (SlotsService built-in); the shell renders
exactly ctx.slots.renderSlot('root', {}).
- register is the single API: children = slot declaration + render
authorization + runtime spec in one options object; misconfiguration fails
loud at load (duplicate declaration, undeclared contribution, one store
handle under two scopes).
- Component props arrive in four auto-derived shares: PropsRuntime<K>
(owner params + session/global standard kits via declare-merge),
PropsRenderSlots<S>, PropsStore<H>, and the inject business face.
sessionId is framework-supplied; hooks are framework-made only.
- Framework store seat: defineStore factories declare schema/actions/persist;
read = useStore, write = baked actions only; store scope derives from the
mounting entry; per-session persist keys and clearPersisted lifecycle.
- inject factories read the apply closure's own ctx (binding handles retired;
root-ctx back door closed); SessionProvider is self-wired render-prop.
- Rendering sits behind the SlotRenderer install seam; runtime stays
React-free; ownership ledger keyed to the single entry axis closes the
stale-authority window (StaleAuthorizationError probes).
Docs: the slot type-chain note is refreshed in place as the slot system
standard RFC (bilingual pair re-recorded); the web client architecture RFC
defers its slot sections there; packages/client/AGENTS.md gains the slot and
props discipline; gui-testing/web-styling notes drop missions/ references.
Tests: suites rewritten to the standard (props fed directly, real store
engines via createXXXStore().create(), no render machinery); load-time
negative samples for declaration/authorization/store conflicts; verified by
real-host playwright run (three columns, empty state, collapse, keyed session
remount, cross-slot selection sharing).
docs(ui-sidebar): point contract reference at the committed slot standard RFC
missions/ is workspace-local and never committed; the README must not cite it.
58 lines
2.0 KiB
TypeScript
58 lines
2.0 KiB
TypeScript
/**
|
|
* LayoutService behavior: the cross-plugin panel-action face. Geometry
|
|
* lives in the entry store (layout-store.spec.ts) — here we assert the
|
|
* delegation seam: attachPanels wiring, the three actions forwarding, the
|
|
* unwired fail-loud, and re-attach overwriting a stale action set.
|
|
*/
|
|
import { describe, expect, it, vi } from 'vitest'
|
|
import { LayoutService } from '@deepseek-ai/dsh-client-ui-layout/src/client/service.ts'
|
|
import type { PanelActions } from '@deepseek-ai/dsh-client-ui-layout/src/client/service.ts'
|
|
|
|
function fakePanels(): PanelActions {
|
|
return {
|
|
setSidebar: vi.fn(),
|
|
setDetails: vi.fn(),
|
|
toggleSidebar: vi.fn(),
|
|
openDetails: vi.fn(),
|
|
closeDetails: vi.fn(),
|
|
}
|
|
}
|
|
|
|
describe('LayoutService', () => {
|
|
it('forwards the three panel actions to the attached set', () => {
|
|
const service = new LayoutService()
|
|
const panels = fakePanels()
|
|
service.attachPanels(panels)
|
|
|
|
service.toggleSidebar()
|
|
service.openDetails()
|
|
service.closeDetails()
|
|
|
|
expect(panels.toggleSidebar).toHaveBeenCalledTimes(1)
|
|
expect(panels.openDetails).toHaveBeenCalledTimes(1)
|
|
expect(panels.closeDetails).toHaveBeenCalledTimes(1)
|
|
expect(panels.setSidebar).not.toHaveBeenCalled()
|
|
expect(panels.setDetails).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('fails loud before the root entry wired its actions', () => {
|
|
const service = new LayoutService()
|
|
expect(() => { service.toggleSidebar() }).toThrow(/panel actions not wired/)
|
|
expect(() => { service.openDetails() }).toThrow(/panel actions not wired/)
|
|
expect(() => { service.closeDetails() }).toThrow(/panel actions not wired/)
|
|
})
|
|
|
|
it('re-attach overwrites the stale action set (entry re-register)', () => {
|
|
const service = new LayoutService()
|
|
const stale = fakePanels()
|
|
const fresh = fakePanels()
|
|
service.attachPanels(stale)
|
|
service.attachPanels(fresh)
|
|
|
|
service.toggleSidebar()
|
|
|
|
expect(stale.toggleSidebar).not.toHaveBeenCalled()
|
|
expect(fresh.toggleSidebar).toHaveBeenCalledTimes(1)
|
|
})
|
|
})
|