imccyu
1b0ea07bce
The definitive slot model for the web client, replacing the first-generation
define/register two-step, ScopedSlots whitelist faces, and binding handles:
- 'root' is the only a-priori slot (SlotsService built-in); the shell renders
exactly ctx.slots.renderSlot('root', {}).
- register is the single API: children = slot declaration + render
authorization + runtime spec in one options object; misconfiguration fails
loud at load (duplicate declaration, undeclared contribution, one store
handle under two scopes).
- Component props arrive in four auto-derived shares: PropsRuntime<K>
(owner params + session/global standard kits via declare-merge),
PropsRenderSlots<S>, PropsStore<H>, and the inject business face.
sessionId is framework-supplied; hooks are framework-made only.
- Framework store seat: defineStore factories declare schema/actions/persist;
read = useStore, write = baked actions only; store scope derives from the
mounting entry; per-session persist keys and clearPersisted lifecycle.
- inject factories read the apply closure's own ctx (binding handles retired;
root-ctx back door closed); SessionProvider is self-wired render-prop.
- Rendering sits behind the SlotRenderer install seam; runtime stays
React-free; ownership ledger keyed to the single entry axis closes the
stale-authority window (StaleAuthorizationError probes).
Docs: the slot type-chain note is refreshed in place as the slot system
standard RFC (bilingual pair re-recorded); the web client architecture RFC
defers its slot sections there; packages/client/AGENTS.md gains the slot and
props discipline; gui-testing/web-styling notes drop missions/ references.
Tests: suites rewritten to the standard (props fed directly, real store
engines via createXXXStore().create(), no render machinery); load-time
negative samples for declaration/authorization/store conflicts; verified by
real-host playwright run (three columns, empty state, collapse, keyed session
remount, cross-slot selection sharing).
docs(ui-sidebar): point contract reference at the committed slot standard RFC
missions/ is workspace-local and never committed; the README must not cite it.
43 lines
1.7 KiB
TypeScript
43 lines
1.7 KiB
TypeScript
// Dynamic-key escape hatches and untouched-key behavior of the terminal core.
|
|
import { describe, expect, it } from 'vitest'
|
|
import type { SlotComponent } from '@deepseek-ai/dsh-client-ui-slots'
|
|
import { SlotCore } from '@deepseek-ai/dsh-client-ui-slots'
|
|
|
|
declare module '@deepseek-ai/dsh-client-ui-slots' {
|
|
interface SlotMap {
|
|
'surface.a': { kind: 'single'; scope: 'root' }
|
|
'surface.b': { kind: 'single'; scope: 'root' }
|
|
}
|
|
}
|
|
|
|
const Comp: SlotComponent<object> = () => null
|
|
|
|
describe('dynamic-key escape hatch', () => {
|
|
it('specDynamic reads wide-typed specs for string keys; undefined while undeclared', () => {
|
|
const core = new SlotCore()
|
|
expect(core.specDynamic('surface.a')).toBeUndefined()
|
|
core.register({ name: 'root', children: { 'surface.a': { kind: 'single', scope: 'root' } } }, Comp as never)
|
|
expect(core.specDynamic('surface.a')).toEqual({ kind: 'single', scope: 'root' })
|
|
expect(core.specDynamic('never.declared')).toBeUndefined()
|
|
})
|
|
|
|
it('spec() narrows by SlotMap key', () => {
|
|
const core = new SlotCore()
|
|
core.register({ name: 'root', children: { 'surface.a': { kind: 'single', scope: 'root' } } }, Comp as never)
|
|
expect(core.spec('surface.a')).toEqual({ kind: 'single', scope: 'root' })
|
|
expect(core.spec('surface.b')).toBeUndefined()
|
|
})
|
|
|
|
it('entries/getVersion on an untouched key return the frozen empty array and 0', () => {
|
|
const core = new SlotCore()
|
|
expect(core.entries('surface.b')).toHaveLength(0)
|
|
expect(core.entries('surface.b')).toBe(core.entries('surface.b'))
|
|
expect(core.getVersion('surface.b')).toBe(0)
|
|
})
|
|
|
|
it('isLive is false for entries the core never held', () => {
|
|
const core = new SlotCore()
|
|
expect(core.isLive({ component: Comp, options: {} })).toBe(false)
|
|
})
|
|
})
|