imccyu
d804c9c94d
The summary blank bit switches from log emptiness to the absence of any turn/start: standalone plugin events — command lifecycle records, plan/mode, session titles, goal metadata — no longer surface a fresh session in lists or steal the New Session view. Running /plan (or /goal) on a blank session keeps it blank and reusable; the first accepted prompt's turn clears it. Both carriers share one predicate (summarize + the host/session-added frame); the cold path keeps its constant false with the index-read rationale; the client mirror already flips only on prompt acceptance and needed no change.
78 lines
3.3 KiB
TypeScript
78 lines
3.3 KiB
TypeScript
/**
|
|
* The summary blank bit means "conversation not started" (no turn has run),
|
|
* not "log empty": standalone plugin events — command lifecycle records,
|
|
* plan/mode, session titles — never flip it, so running /plan or /goal on a
|
|
* fresh session keeps it list-hidden and reusable, while the first accepted
|
|
* prompt's turn/start clears it. The host/session-added frame shares the
|
|
* same predicate function (covered by the workspace spec's frame assertion).
|
|
*/
|
|
|
|
import { describe, expect, it } from 'vitest'
|
|
import { Context } from 'cordis'
|
|
import AgentRegistry from '@deepseek-ai/dsh-agent'
|
|
import type { Agent } from '@deepseek-ai/dsh-agent'
|
|
import SessionStore from '@deepseek-ai/dsh-session'
|
|
import type { Session } from '@deepseek-ai/dsh-session'
|
|
import UserInteractionService from '@deepseek-ai/dsh-user-interaction'
|
|
import { CommandId } from '@deepseek-ai/dsh-commands/brand'
|
|
import type { ApiProxy, RpcRequest } from '@deepseek-ai/dsh-host-apiproxy/api'
|
|
import { RpcId } from '@deepseek-ai/dsh-host-apiproxy/api/rpc'
|
|
import { createApiProxy } from '@deepseek-ai/dsh-host-apiproxy'
|
|
|
|
let nextRpc = 1
|
|
function request<P>(payload: P): RpcRequest<P> {
|
|
return { rpcId: RpcId(`blank-${String(nextRpc++)}`), payload }
|
|
}
|
|
|
|
async function harness(): Promise<{ ctx: Context; api: ApiProxy; attach: (session: Session) => void }> {
|
|
const ctx = new Context()
|
|
await ctx.plugin(SessionStore)
|
|
await ctx.plugin(UserInteractionService)
|
|
await ctx.plugin(AgentRegistry)
|
|
return {
|
|
ctx,
|
|
api: createApiProxy(ctx, { provider: 'p', model: 'm', cwd: '/tmp', workspaceRoot: '/tmp' }),
|
|
attach: (session) => {
|
|
ctx.agents.register({ id: session.id, session, status: 'idle', ctx } as Agent)
|
|
},
|
|
}
|
|
}
|
|
|
|
/** Append the standalone (non-conversation) event family a fresh session can accumulate. */
|
|
function appendStandalone(session: Session): void {
|
|
session.append('command/run', {
|
|
commandId: CommandId('blank-cmd-1'), name: 'plan', args: '', source: { kind: 'user' },
|
|
})
|
|
session.append('plan/mode', { active: true })
|
|
session.append('command/done', { commandId: CommandId('blank-cmd-1'), kind: 'success', text: 'Plan mode on.' })
|
|
session.append('session/title', {
|
|
title: 'standalone title', messageSeqs: [], source: { kind: 'fallback' },
|
|
})
|
|
}
|
|
|
|
async function listBlank(api: ApiProxy, id: string): Promise<boolean | undefined> {
|
|
const response = await api.sessions.list(request({}))
|
|
if (!response.result.ok) throw new Error('list failed')
|
|
return response.result.value.items.find(item => item.sessionId === id)?.blank
|
|
}
|
|
|
|
describe('summary blank = conversation not started', () => {
|
|
it('standalone events (command lifecycle, plan/mode, title) keep the session blank', async () => {
|
|
const { ctx, api, attach } = await harness()
|
|
const session = ctx.sessions.create()
|
|
attach(session)
|
|
expect(await listBlank(api, session.id)).toBe(true)
|
|
appendStandalone(session)
|
|
expect(await listBlank(api, session.id)).toBe(true)
|
|
})
|
|
|
|
it('the first turn clears blank', async () => {
|
|
const { ctx, api, attach } = await harness()
|
|
const session = ctx.sessions.create()
|
|
attach(session)
|
|
appendStandalone(session)
|
|
session.append('turn/start', { turn: 0, trigger: { kind: 'message', source: { kind: 'user' } } })
|
|
expect(await listBlank(api, session.id)).toBe(false)
|
|
})
|
|
})
|