Tianyi Cui
3fc35c91ff
git mv per the regrouping RFC: the five human-collaboration seams and tui join packages/interaction/, app-boot becomes packages/boot/, and jsonrpc joins the renamed scaffold/ (formerly sdk/) as its server half beside client/protocol/create-sdk/helper/scripts/telemetry, whose folders drop the legacy sdk- prefix. Three new group README triplets replace the ui/ and sdk/ ones; tsconfig references/paths/globs, knip keys, vitest globs, gate scripts, catalogs, docs, and the lockfile follow. Adds the four settled FIXME rename markers (dsh-sdk-server, dsh-sdk-telemetry, dsh-sdk-helper, dsh-sdk-scripts). The scaffold folders diverge from their npm names until those renames land, so tsconfig.base.json maps the three affected names explicitly beside the group wildcard. Also repairs two pre-existing stale-path classes the strengthened sweep surfaced: docs/web-styling.md's retired web-ui host package and type-model spec fixture-literal joins. app-boot's three Loader-composition specs time out at the default 5s under full-suite parallel load on this filesystem (pre-existing; pass isolated with --testTimeout=30000); interaction/scaffold/boot suites otherwise green (687 passed).
107 lines
4.2 KiB
TypeScript
107 lines
4.2 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
import { Context } from 'cordis'
|
|
import SessionStore, { Session, SessionId } from '@deepseek-ai/dsh-session'
|
|
import { ApprovalRequestId } from '@deepseek-ai/dsh-user-approval'
|
|
import * as ApprovalInvariant from '@deepseek-ai/dsh-user-approval/invariant'
|
|
import InvariantService from '@deepseek-ai/dsh-invariants'
|
|
|
|
async function setup(): Promise<Context> {
|
|
const ctx = new Context()
|
|
await ctx.plugin(SessionStore)
|
|
await ctx.plugin(InvariantService)
|
|
await ctx.plugin(ApprovalInvariant)
|
|
return ctx
|
|
}
|
|
|
|
function startTurn(session: Session): void {
|
|
session.append('turn/start', { turn: 1 })
|
|
}
|
|
|
|
describe('approval invariants', () => {
|
|
it('accepts paired audit events and closed policy values', async () => {
|
|
const ctx = await setup()
|
|
const session = ctx.sessions.create()
|
|
startTurn(session)
|
|
const id = ApprovalRequestId('ask-1')
|
|
session.append('approval/asked', { id, toolName: 'bash' })
|
|
session.append('approval/decided', { id, outcome: 'allowed-once' })
|
|
session.append('approval/policy', { policy: 'never' })
|
|
})
|
|
|
|
it('rebuilds an unmatched question from an existing session', async () => {
|
|
const ctx = new Context()
|
|
await ctx.plugin(SessionStore)
|
|
const session = ctx.sessions.create()
|
|
session.append('turn/start', { turn: 1 })
|
|
const id = ApprovalRequestId('ask-resume')
|
|
session.append('approval/asked', { id, toolName: 'bash' })
|
|
await ctx.plugin(InvariantService)
|
|
await ctx.plugin(ApprovalInvariant)
|
|
expect(() => session.append('approval/decided', { id, outcome: 'cancelled' })).not.toThrow()
|
|
session.append('turn/end', { turn: 1, reason: { kind: 'completed' } })
|
|
})
|
|
|
|
it('adopts a bare session first observed through publication', async () => {
|
|
const ctx = await setup()
|
|
const session = Session.create(SessionId('bare-approval-session'))
|
|
const id = ApprovalRequestId('bare-ask')
|
|
const asked = {
|
|
type: 'approval/asked', seq: 0, time: 0, data: { id, toolName: 'bash' },
|
|
} as const
|
|
const decided = {
|
|
type: 'approval/decided', seq: 1, time: 1, data: { id, outcome: 'rejected' as const },
|
|
} as const
|
|
expect(() => {
|
|
ctx.emit('session/event', session, {
|
|
type: 'turn/start', seq: 0, time: 0,
|
|
data: { turn: 1 },
|
|
})
|
|
ctx.emit('session/event', session, asked)
|
|
ctx.emit('session/event', session, decided)
|
|
}).not.toThrow()
|
|
})
|
|
|
|
it('rejects audit events outside any open turn', async () => {
|
|
const ctx = await setup()
|
|
const session = ctx.sessions.create()
|
|
expect(() => session.append('approval/asked', {
|
|
id: ApprovalRequestId('ask-1'), toolName: 'bash',
|
|
})).toThrow(/outside any open turn/)
|
|
expect(() => session.append('approval/decided', {
|
|
id: ApprovalRequestId('ask-1'), outcome: 'rejected',
|
|
})).toThrow(/outside any open turn/)
|
|
})
|
|
|
|
it('rejects an unenclosed audit event when replaying an existing session', async () => {
|
|
const ctx = new Context()
|
|
await ctx.plugin(SessionStore)
|
|
const session = ctx.sessions.create()
|
|
startTurn(session)
|
|
session.append('turn/end', { turn: 1, reason: { kind: 'completed' } })
|
|
session.append('approval/asked', {
|
|
id: ApprovalRequestId('ask-replay'), toolName: 'bash',
|
|
})
|
|
await ctx.plugin(InvariantService)
|
|
await expect(ctx.plugin(ApprovalInvariant).then(() => undefined)).rejects.toThrow(/outside any open turn/)
|
|
})
|
|
|
|
it('rejects malformed and unpaired audit events', async () => {
|
|
const ctx = await setup()
|
|
const session = ctx.sessions.create()
|
|
startTurn(session)
|
|
const id = ApprovalRequestId('ask-1')
|
|
expect(() => session.append('approval/asked', { id, toolName: '' }))
|
|
.toThrow(/toolName must be non-empty/)
|
|
session.append('approval/asked', { id, toolName: 'bash' })
|
|
expect(() => session.append('approval/asked', { id, toolName: 'bash' }))
|
|
.toThrow(/repeated open id/)
|
|
expect(() => session.append('approval/decided', {
|
|
id: ApprovalRequestId('missing'), outcome: 'rejected',
|
|
})).toThrow(/no matching approval\/asked/)
|
|
expect(() => session.append('approval/decided', { id, outcome: 'maybe' as never }))
|
|
.toThrow(/unknown outcome/)
|
|
expect(() => session.append('approval/policy', { policy: 'always' as never }))
|
|
.toThrow(/unknown policy/)
|
|
})
|
|
})
|