Tianyi Cui
4f291953ea
Round 1 of Codex review on the extraction PR.
- (B) EOF-exit race: the 200ms flush-then-exit setTimeout was untracked, so a
fiber/HMR dispose within that window could not cancel it and the process
would still exit. Track the handle and clear it in the disposer; coalesce
re-entrant maybeExit() calls onto the one pending timer. Regression tests for
both (dispose-within-window cancels; repeated idle schedules once).
- (B/doc) ui-stdio rendering is global, not scoped by config.agent (faithful to
the original copies — agent scopes only input + the EOF-exit gate). Corrected
the README + Config JSDoc, which overclaimed "drive and render".
- (C) createStdioChat is exported and driven directly by tests/programmatic
callers that bypass schemastery validation, so default welcome/agent in the
helper (?? 'ready.'/'main') instead of trusting the cast. Test for empty config.
- (A/doc) docs/rfc/.../acp-snapshot-tests.md asserted the replay plugin
deliberately stays in examples/ ("don't split preemptively") — now false since
this PR packages it. Added a superseding note with the why (coverage gate).
All gates green: typecheck, lint, test:coverage (891, 100%), doc-sync,
test:e2e (6 keyless pass), test:snapshot unaffected.
16 lines
192 B
Plaintext
16 lines
192 B
Plaintext
CLAUDE.local.md
|
|
.env
|
|
node_modules/
|
|
lib/
|
|
*.tsbuildinfo
|
|
pnpm-debug.log
|
|
.pnpm-store/
|
|
examples/*/*.jsonl
|
|
.sessions/
|
|
examples/*/.sessions/
|
|
coverage/
|
|
.doc-typecheck-*/
|
|
.humanize/
|
|
.vscode/
|
|
.DS_Store
|