# Conflicts: # docs/config-catalog.md # docs/cordis-catalog/events.md # docs/cordis-catalog/services.md # docs/event-producer-consumer.md # docs/persistence-catalog.md # examples/acp-agent/cordis.yml # examples/acp-agent/tests/snapshots/advanced-toolchain/session.1.jsonl # examples/acp-agent/tests/snapshots/advanced-toolchain/session.2.jsonl # examples/acp-agent/tests/snapshots/advanced-toolchain/session.jsonl # examples/acp-agent/tests/snapshots/both-mode-turn/session.jsonl # examples/acp-agent/tests/snapshots/permission-switching/session.jsonl # examples/acp-agent/tests/snapshots/skill-load/session.jsonl # examples/acp-agent/tests/snapshots/text-turn/session.jsonl # packages/bash/bash-sandbox/src/index.ts # packages/bash/bash/src/types.ts # packages/bash/tool-bash/src/index.ts # packages/fs/fs/src/index.ts # packages/sandbox/sandbox-policy/src/session-mode.ts # packages/ui/permission/src/index.ts # packages/ui/permission/tests/permission.spec.ts # scripts/doc-budgets.manifest.json
208 lines
9.4 KiB
TypeScript
208 lines
9.4 KiB
TypeScript
/**
|
|
* Sandbox-consuming bash executor. It wraps the exact local bash argv through
|
|
* `ctx.sandbox`, inherits local process mechanics, and reports the selected
|
|
* mode, enforcement, and denial facts. Runner failure means the command never
|
|
* ran: foreground calls throw `SANDBOX_UNAVAILABLE`, while settled background
|
|
* tasks carry `runnerFailed`. The tool owns approval and passes per-call modes.
|
|
* @module @deepseek-ai/dsh-bash-sandbox
|
|
*/
|
|
|
|
import { Context } from 'cordis'
|
|
import type { BashExecRequest, BashExecSpec, BashRunResult, BashTask, BashTaskId } from '@deepseek-ai/dsh-bash'
|
|
import { SandboxUnavailableError } from '@deepseek-ai/dsh-sandbox'
|
|
import type { ConfinedSandboxMode, SandboxEnforcement, SandboxMode } from '@deepseek-ai/dsh-sandbox'
|
|
import type {} from '@deepseek-ai/dsh-sandbox-policy'
|
|
import { LocalBashExecutor } from '@deepseek-ai/dsh-bash-local'
|
|
import type { Config as LocalConfig } from '@deepseek-ai/dsh-bash-local'
|
|
|
|
/**
|
|
* Plugin config: the local executor's knobs, verbatim. The sandbox policy —
|
|
* the default mode and the `workspace-write` boundary root — is NOT here: it
|
|
* lives on `ctx.sandboxPolicy` (`@deepseek-ai/dsh-sandbox-policy`), the one
|
|
* home both enforcing families read, so bash and fs can never confine to
|
|
* different roots. The runner choice is likewise the `ctx.sandbox` provider's
|
|
* config, not this executor's.
|
|
*/
|
|
export type Config = LocalConfig
|
|
|
|
/**
|
|
* Quote one string as a single-quoted POSIX shell word (embedded single
|
|
* quotes become `'\''`), so a wrapped argv element survives the outer
|
|
* `bash -c` re-parse byte-for-byte.
|
|
* @param text - the raw argv element to quote.
|
|
* @returns the single-quoted shell word.
|
|
*/
|
|
export function shellQuote(text: string): string {
|
|
return `'${text.replaceAll("'", String.raw`'\''`)}'`
|
|
}
|
|
|
|
/**
|
|
* Conservatively classify a nonzero, non-signal run using only the selected
|
|
* backend's denial signatures. Text inference may miss a denial or match
|
|
* unrelated stderr in that dialect; it never uses another backend's terms.
|
|
* @param result - the settled foreground run to classify.
|
|
* @param signatures - the active wrap's denial dialect, case-insensitive stderr substrings.
|
|
* @returns whether the run's failure reads as a sandbox denial.
|
|
*/
|
|
export function classifyDenial(result: BashRunResult, signatures: readonly string[]): boolean {
|
|
return matchesSignature(result.exitCode, result.stderr.text, signatures)
|
|
}
|
|
|
|
/**
|
|
* Classify a nonzero run using the selected backend's runner-failure
|
|
* signatures. Callers check this before denial because runner diagnostics may
|
|
* contain denial words; the command did not run.
|
|
* @param result - the settled foreground run to classify.
|
|
* @param signatures - the active wrap's runner-failure signatures,
|
|
* case-insensitive stderr substrings.
|
|
* @returns whether the run's failure reads as the runner itself failing.
|
|
*/
|
|
export function classifyRunnerFailure(result: BashRunResult, signatures: readonly string[]): boolean {
|
|
return matchesSignature(result.exitCode, result.stderr.text, signatures)
|
|
}
|
|
|
|
/**
|
|
* The classifier core shared by foreground results and settled background
|
|
* tasks: failed AND signature present. Lowercases BOTH sides — the seam
|
|
* declares its signatures case-insensitive, and producers compose them from
|
|
* runtime data of any case (an `argv0` path, `No such file or directory`).
|
|
*/
|
|
function matchesSignature(exitCode: number | null, stderr: string, signatures: readonly string[]): boolean {
|
|
if (exitCode === null || exitCode === 0) return false
|
|
const lowered = stderr.toLowerCase()
|
|
return signatures.some(signature => lowered.includes(signature.toLowerCase()))
|
|
}
|
|
|
|
/**
|
|
* Registers as `ctx.bash` in place of the local executor and requires a
|
|
* `ctx.sandbox` provider plus `ctx.sandboxPolicy`; the tool layer is
|
|
* unchanged. The policy default (mode + workspace root, from
|
|
* `ctx.sandboxPolicy`) is the fallback, while a session override or approved
|
|
* one-shot escalation may select each call's mode. The prompt does not state
|
|
* the standing mode; `result.sandbox` reports the mode and enforcement
|
|
* actually used.
|
|
*/
|
|
export class SandboxBashExecutor extends LocalBashExecutor {
|
|
static inject = ['sandbox', 'sandboxPolicy']
|
|
|
|
// No own Config: the sandbox default (mode + workspaceRoot) moved to
|
|
// ctx.sandboxPolicy, so this executor inherits LocalBashExecutor's Config
|
|
// verbatim (the config catalog walks the inherited static).
|
|
|
|
private readonly mode: SandboxMode
|
|
private readonly workspaceRoot: string
|
|
/**
|
|
* Per-task mode and wrap facts retained until settlement. Overlapping tasks
|
|
* may use different modes or provider facts, so one latest-wrap field would
|
|
* misclassify earlier completions.
|
|
*/
|
|
private readonly taskFacts = new Map<BashTaskId, {
|
|
mode: ConfinedSandboxMode
|
|
enforcement: SandboxEnforcement
|
|
denialSignatures: readonly string[]
|
|
runnerFailureSignatures: readonly string[]
|
|
}>()
|
|
|
|
constructor(ctx: Context, config: Config) {
|
|
super(ctx, config)
|
|
// The sandbox default (mode + workspaceRoot) is the one shared policy home
|
|
// both enforcing families read; injecting sandboxPolicy guarantees it is
|
|
// constructed first. workspaceRoot arrives already resolved absolute.
|
|
this.mode = ctx.sandboxPolicy.defaultMode
|
|
this.workspaceRoot = ctx.sandboxPolicy.workspaceRoot
|
|
}
|
|
|
|
/** The configured default mode — the capability fact the tool layer reads. */
|
|
override get sandboxMode(): SandboxMode {
|
|
return this.mode
|
|
}
|
|
|
|
/**
|
|
* Stamp the effective mode onto the spec — the request's explicit override
|
|
* (an approved escalation), else this executor's configured default — so
|
|
* defaulting stays an explicit resolve step and `run()`/`start()` read the
|
|
* spec, never the config.
|
|
*/
|
|
override resolve(request: BashExecRequest): BashExecSpec {
|
|
return { ...super.resolve(request), sandboxMode: request.sandboxMode ?? this.mode }
|
|
}
|
|
|
|
override async run(spec: BashExecSpec): Promise<BashRunResult> {
|
|
// resolve() always stamps the mode; the cast records that invariant
|
|
// (mirrors the constructor's config casts).
|
|
const mode = spec.sandboxMode as SandboxMode
|
|
if (mode === 'danger-full-access') {
|
|
const result = await super.run(spec)
|
|
return { ...result, sandbox: { mode, denied: false } }
|
|
}
|
|
const confined = this.confine(spec.command, mode)
|
|
const result = await super.run({ ...spec, command: confined.command })
|
|
// Runner failure outranks denial because the command did not run. Throw the
|
|
// same fail-closed error as confine-time discovery with the first stderr line.
|
|
if (classifyRunnerFailure(result, confined.runnerFailureSignatures)) {
|
|
throw new SandboxUnavailableError(mode, result.stderr.text.trim().split('\n')[0])
|
|
}
|
|
return { ...result, sandbox: { mode, denied: classifyDenial(result, confined.denialSignatures), enforcement: confined.enforcement } }
|
|
}
|
|
|
|
override start(spec: BashExecSpec): BashTask {
|
|
// Same stamped-by-resolve invariant as run().
|
|
const mode = spec.sandboxMode as SandboxMode
|
|
if (mode === 'danger-full-access') return super.start(spec)
|
|
// Classification needs settled stderr. Store facts synchronously after
|
|
// spawn, before the earliest process completion can be observed.
|
|
const confined = this.confine(spec.command, mode)
|
|
const task = super.start({ ...spec, command: confined.command })
|
|
const { enforcement, denialSignatures, runnerFailureSignatures } = confined
|
|
this.taskFacts.set(task.id, { mode, enforcement, denialSignatures, runnerFailureSignatures })
|
|
return task
|
|
}
|
|
|
|
/**
|
|
* Stamp per-task sandbox facts before completion listeners and `done` settle.
|
|
* Full-access tasks have no facts; signal deaths are not denials.
|
|
*/
|
|
protected override notifyTaskDone(task: BashTask): void {
|
|
const facts = this.taskFacts.get(task.id)
|
|
if (facts !== undefined) {
|
|
this.taskFacts.delete(task.id)
|
|
const stderr = this.collectedStderr(task.id)
|
|
// Runner failure outranks denial. Background settlement has no throw
|
|
// channel, so this fact is its counterpart to the foreground exception.
|
|
const runnerFailed = matchesSignature(task.exitCode, stderr, facts.runnerFailureSignatures)
|
|
task.sandbox = {
|
|
mode: facts.mode,
|
|
denied: !runnerFailed && matchesSignature(task.exitCode, stderr, facts.denialSignatures),
|
|
enforcement: facts.enforcement,
|
|
...(runnerFailed ? { runnerFailed } : {}),
|
|
}
|
|
}
|
|
super.notifyTaskDone(task)
|
|
}
|
|
|
|
/**
|
|
* Wrap one shell command via the `ctx.sandbox` provider: hand over the
|
|
* exact `['bash', '-c', command]` argv this executor would spawn, get back
|
|
* the confined argv, and re-assemble it into the `exec …` command string
|
|
* the inherited spawn path runs (the outer `bash -c` that `runBash` spawns
|
|
* `exec`s into the runner, so no extra shell lingers). Provider errors
|
|
* (fail-closed `SANDBOX_UNAVAILABLE`) propagate to the caller unchanged.
|
|
*/
|
|
private confine(command: string, mode: ConfinedSandboxMode): {
|
|
command: string
|
|
enforcement: SandboxEnforcement
|
|
denialSignatures: readonly string[]
|
|
runnerFailureSignatures: readonly string[]
|
|
} {
|
|
const confined = this.ctx.sandbox.confine(['bash', '-c', command], { mode, workspaceRoot: this.workspaceRoot })
|
|
return {
|
|
command: `exec ${confined.argv.map(shellQuote).join(' ')}`,
|
|
enforcement: confined.enforcement,
|
|
denialSignatures: confined.denialSignatures,
|
|
runnerFailureSignatures: confined.runnerFailureSignatures,
|
|
}
|
|
}
|
|
}
|
|
|
|
export default SandboxBashExecutor
|