Tianyi Cui
64ce7caedc
Resolve the inline review feedback on PR #18 (all verified against the codebase, the published @agentclientprotocol/sdk@0.25.1 tarball, and Cordis fiber semantics): - 009: dsh-session owns SessionMeta (persistence re-exports) to avoid a package cycle; split mutable summary into a sidecar so the event log stays append-only and list/load can return it; pick one load-repair rule (resume from the last complete turn/end, overwrite the orphan). - 010: SDK has a zod peer dep + runtime zod/v4 import (drop "zero runtime deps"); session/new needs a create seam taking {sessionId, meta}; propose an abstract create/resume factory on dsh-agent so the bridge depends on the interface not the loop, and observe agent/status for quiescence since agent.done is LoopAgent-only; add the explicit TurnEndReason -> ACP StopReason wire mapping + test; reject non-empty additionalDirectories for the MVP; remove the EOF blank line. - 011: ctx.extend() does not create a disposable fiber — use a real per-session disposer scope.
RFCs
Proposals for substantial future work — reviewed before implementation, unlike ADRs (which record decisions already made). Each RFC groups a related set of ideas from the quality/robustness proposal (2026-06-11); statuses move proposed → accepted → implemented (then usually graduate to an ADR).
| # | Title | Status |
|---|---|---|
| 001 | Property-based testing for protocol-shaped code | implemented |
| 002 | Mutation testing as the coverage counterweight | proposed |
| 003 | Deterministic tests + replay invariant fixture + race stress | proposed |
| 004 | Architectural rules: dependency-cruiser, adapter conformance kit | proposed |
| 005 | Runtime arg validation, structured error taxonomy, dev-mode invariants | implemented |
| 006 | Doc-sync enforcement and API extractor reports | implemented (pts 1-2; pt 3 deferred) |
| 007 | Supply chain checks and vendor drift verification | proposed |
| 008 | Deep-readonly public surfaces | implemented (revised) |
| 009 | Durable session persistence — abstract, append-only, event-based store | proposed |
| 010 | Agent Client Protocol (ACP) support for external editors | proposed |
| 011 | Multiplex concurrent ACP sessions over one connection | proposed |