kingwl
7a2dff8b11
Four ds-review-bot findings: - examples/tui-agent composed dsh-mode without the now-required modes.plan.section, so the TUI leaf failed at Loader startup (the keyless smoke only asserts the banner and missed it); graft the same deployment plan instructions the ACP leaf carries. - The prompt-submit and turn-continuation flushes ran before next(), so a session/set_mode arriving while a downstream async listener (the shipped hooks listeners' shape) awaited applied one request late; both listeners now prepend and flush after next(), matching the request-error wrapper, with a regression test pinning the ordering. - An HMR unload during the exit_plan_mode review let a later approval write into the disposed service and claim an exit whose flush could never land; the execute path now checks the fiber lifetime after the await and fails the call (the mode stays plan; the model re-presents). - resolveConfig accepted empty/untrimmed mode names that list()/ACP then advertised while the package invariant rejected their selection, desynchronizing the picker; names are validated non-empty and trimmed at load, the same shape the invariant enforces.
mode/ — session-mode policy family
Session modes: named, logged, per-agent collaboration states, with plan mode as the first shipped definition. A single product package — there is no interface/implementation seam here, because a mode's variable part is a config value (the section text), not a swappable implementation.
| Package | Role | ctx key |
|---|---|---|
mode/ |
mode/set vocabulary + fold, the ctx.modes service (list/get/set with the turn-boundary flush), the mode:policy guidance section, and the model-facing exit_plan_mode review tool |
ctx.modes |
The mode in force is a pure function of the session log (SessionEventMap['mode/set'], last one wins), so resume and fork restore it with no extra machinery. The deployment supplies plan instructions through Cordis config, while exit_plan_mode remains registered in every mode to keep the request tool catalog stable. UIs read flips off session/event; the ACP bridge maps the vocabulary to the session-mode picker, and a composed command registry gains the plugin-registered /mode command. Design: plan-mode Agent Note.