0 Fork 0

Files

T

Tianyi Cui 2cb3866126 fix(downgrade): sync README marker references with source

Codex CLI review flagged 2 READMEs still referencing old TODO markers
after source had been updated to XXX:

- packages/bash-local/README.md: TODO(stateful-shell) → XXX(stateful-shell)
- packages/tool-bash/README.md:   TODO(tool-bash-owner-hmr) → XXX(tool-bash-owner-hmr)

2026-06-18 07:42:13 +08:00

src

fix: correct marker classifications per repo standard

2026-06-18 07:12:01 +08:00

tests

Add bash execution: dsh-bash seam, dsh-bash-local impl, dsh-tool-bash tools

2026-06-13 18:28:10 +08:00

package.json

feat: migrate to pnpm

2026-06-16 14:55:37 +08:00

README.md

fix(downgrade): sync README marker references with source

2026-06-18 07:42:13 +08:00

tsconfig.json

Add bash execution: dsh-bash seam, dsh-bash-local impl, dsh-tool-bash tools

2026-06-13 18:28:10 +08:00

README.md

@deepseek-ai/dsh-bash-local

Local-subprocess implementation of the @deepseek-ai/dsh-bash executor seam: LocalBashExecutor spawns bash -c <command> per call in its own process group, collects bounded output with full-stream spill files, and escalates kills SIGTERM→SIGKILL across the whole group.

Config

- id: bash
  name: '@deepseek-ai/dsh-bash-local'
  config:
    cwd: /path/to/workspace   # default: process.cwd()
    timeoutMs: 120000          # default foreground timeout
    maxTimeoutMs: 600000       # cap for per-call overrides
    maxOutputBytes: 64000      # per-stream in-memory cap; overflow spills to disk

Behavior (and where it came from)

Design surveyed against the bash tools of Claude Code, OpenCode, Codex, and pi; the notable choices:

Spawn per call, no shell state — every call is a fresh non-login bash -c (deterministic; no rc files). All four surveyed tools spawn per call. XXX(stateful-shell) in src/run.ts records the two proven stateful designs (Claude Code's cwd-only persistence; Codex's PTY exec sessions) for when real workflows demand them.
Process-group kills with escalation — children are spawned detached (own process group); kills send SIGTERM to the group, then SIGKILL after a 3s grace (OpenCode's escalation; pipelines and subshells die with the parent). ESRCH is tolerated; daemons that re-parent away from the group can still survive — same caveat as the surveyed tools.
Tail-keep truncation + spill files — output beyond maxOutputBytes keeps the in-memory TAIL (errors/results cluster at the end — pi/OpenCode rationale) while the FULL stream is appended to a temp file whose path is reported. The model can grep/tail the spill file with bash itself.
Model-friendly env — NO_COLOR=1 TERM=dumb PAGER=cat GIT_PAGER=cat (Codex's hardcoded set) so pagers and ANSI color don't garble results.
Background tasks — start() returns immediately, no timeout applies (Claude Code detaches timeouts when backgrounding), readOutput() is incremental with whole-stream byte offsets, and disposal kills everything.

Sandboxing

TODO(permissions/sandbox): execution policy does NOT belong in this package. Wrap the tools/execute waterfall (veto/ask) or implement a sandboxing BashExecutor — see docs/architecture.md § plugin checklist. Reference points: Claude Code wraps commands in sandbox-exec/bubblewrap; Codex applies seatbelt/landlock plus an execpolicy prefix-rule engine.