Holistic-review fixes for integration gaps the per-commit reviews missed: - CI now runs `pnpm run test:snapshot` (a step after the coverage gate). It was wired into pre-push but not .github/workflows/ci.yml, so the RFC/AGENTS claim that snapshot replay runs in the default PR gate was only half-true — CI is the real gate. - vitest.snapshot.config.ts loads the repo .env ONLY when DSH_SNAPSHOT=record. Loading it unconditionally contradicted the replay safety story (replay must never reach the network), and runScenario forwards process.env to the child. Non-ENOENT load errors now surface instead of being swallowed. - start.ts: the graceful-shutdown comment said "RECORD runs" but the path applies to both snapshot modes (replay also closes stdin → dispose → exit). - docs/development.md: list the new pre-push snapshot job and the CI snapshot gate.
5.4 KiB
Development guide
This guide covers the local setup needed to work on DeepSeek Harness and understand the local hooks, daily checks, and CI gates.
Prerequisites
- Node.js 24 or newer. The repo declares
node >=24; CI runs the matrix on Node 24 and 26. - Corepack-enabled pnpm. The repo pins
pnpm@11.7.0inpackage.json; runcorepack enableifpnpm --versiondoes not resolve through Corepack. - Git.
- Optional: a DeepSeek API key for the coding-agent demo and real-API e2e tests.
First-time setup
Install dependencies from the repo root:
pnpm install
The install also runs the root postinstall script, which installs lefthook from the repo dev dependency.
If hooks are missing because dependencies were restored from cache or postinstall was skipped, install them manually:
pnpm exec lefthook install
Run typecheck once after a fresh clone:
pnpm run typecheck
That first typecheck builds declaration output used by type-aware linting for vendored packages. Without it, pnpm run lint can report unresolved-type no-unsafe-* errors even when source code is fine.
If you are preparing to push from a fresh clone or worktree, also build once:
pnpm run build
pnpm run hygiene includes publint, which validates package entrypoints against the built lib/*.js files. A fresh worktree has no bundled JS until pnpm run build runs.
Environment variables
The real DeepSeek adapter and coding-agent demo read credentials from the environment or from a gitignored .env at the repo root:
DEEPSEEK_API_KEY=sk-...
DEEPSEEK_BASE_URL=https://... # optional
DEEPSEEK_BASE_URL is optional and defaults to the public API. Never commit real credentials. The real-API e2e suites self-skip when DEEPSEEK_API_KEY is not set.
Git hooks
lefthook is configured in lefthook.yml as an early local checkpoint before review:
pre-commitruns staged-file ESLint fixes,pnpm run typecheck, and the vendor manifest guard.pre-pushrunspnpm run test,pnpm run test:snapshot,pnpm run hygiene,pnpm run doc-sync, andpnpm run verify-module-graph.
The vendor manifest guard checks that changes under vendor/*/src are staged with the matching vendor/README.md manifest update. See vendor/README.md before editing vendored code.
These hooks do not exactly mirror CI. Notably, pre-push runs unit tests without coverage, while CI runs pnpm run test:coverage; CI also runs an echo-agent smoke test and exercises the matrix on Node 24 and 26.
CI gates
The GitHub workflow runs these gates on each pull request:
pnpm install --frozen-lockfilepnpm run constraintspnpm run typecheckpnpm run lintpnpm run doc-syncpnpm run verify-module-graphpnpm run test:coveragepnpm run test:snapshotpnpm run buildpnpm run knip && pnpm run publint- an echo-agent smoke test that checks the demo's tool call, tool result, and JSONL output
pnpm run hygiene is the local shorthand for pnpm run knip && pnpm run publint && pnpm run constraints; CI splits pnpm run constraints into its own earlier step, then runs pnpm run knip && pnpm run publint after pnpm run build.
Daily commands
Use these from the repo root:
pnpm run test # unit tests
pnpm run test:coverage # unit tests with per-file coverage gates
pnpm run test:e2e # real-API tests; self-skips without DEEPSEEK_API_KEY
pnpm run typecheck # build declarations, then typecheck source, tests, and examples
pnpm run lint # eslint .
pnpm run lint:fix # eslint . --fix
pnpm run doc-typecheck # compile checked TypeScript snippets in Markdown docs
pnpm run verify-event-taxonomy # compare docs/architecture.md event names with source
pnpm run verify-md-wrap # fail on hard-wrapped prose paragraphs in docs/README markdown
pnpm run doc-sync # doc-typecheck, event taxonomy, and markdown wrap verification
pnpm run gen-module-graph # regenerate docs/module-graph.md from package peerDeps
pnpm run verify-module-graph # fail if docs/module-graph.md is stale
pnpm run build # build declarations and JS bundles
pnpm run hygiene # knip, publint, and workspace constraints
When changing package public behavior, update the relevant README or JSDoc in the same change. pnpm run doc-sync catches checked TypeScript snippets, event-taxonomy drift, and hard-wrapped markdown prose, but broader prose/API sync still needs review.
Demos
The echo demo does not need API credentials:
pnpm run demo:echo
The coding-agent demo uses the real DeepSeek adapter and needs DEEPSEEK_API_KEY in the environment or repo-root .env:
pnpm run demo:coding
TODO markers
Use one of three comment tags to flag known issues in the code, ordered by urgency:
FIXME— an issue that should block a new release. A release should not ship with an openFIXMEunless reviewers explicitly agree the change can be merged anyway.TODO— an issue that should be fixed soon, once we have the resources.XXX— an issue that we may fix someday; lowest priority, no commitment.
Pick the tag that matches the urgency so anyone scanning the code can tell a release blocker from a someday-maybe.
Architecture context
Read docs/architecture.md before changing anything under packages/. The codebase is built around Cordis plugins, event-sourced sessions, typed service seams, and explicit extension points.