Tianyi Cui
bfb034830f
vitest coverage (v8 provider) with per-file 100% thresholds for statements, branches, functions, and lines. Scope: our runtime source only — types-only files, vendor/ (upstream code), and examples/ (exercised by the demo smoke test) are excluded. yarn test:coverage runs the gate. 59 tests added to close every gap: llm generate-waterfall and adapter disposal; assembler edge protocol (duplicate block-start, stragglers after block-end, id fallback, usage omission, invariant violation); the whole Inbox surface incl. the wakeup-overwrite race; LoopAgent disposed-state throws and double-stop idempotence; config-driven agent creation; loop backstop catches (throwing turn-start/turn-end listeners, non-Error throws, non-JSON tool arguments); system-prompt dynamic sections and disposer paths; tools errorMessage fallbacks and the full schema-DSL emission matrix. Genuinely unreachable defensive guards carry /* v8 ignore */ comments with stated reasons rather than deletion (132 tests total).
dsh-system-prompt
System prompt assembly registry. Plugins contribute ordered text sections and
tool-schema providers; the agent loop calls assemble() once per step.
Service: SystemPrompt (ctx key: systemPrompt)
Public API
ctx.systemPrompt.section(section: PromptSection): () => voidContribute a section. Disposed with the calling fiber.ctx.systemPrompt.tools(provider: () => ToolSchema[]): () => voidContribute tool schemas (evaluated at each assembly). Disposed with the calling fiber.ctx.systemPrompt.assemble(): Promise<PromptAssembly>Assemble the current prompt. Runs through thesystem-prompt/assemblewaterfall.
Events
| Event | Mode | Purpose |
|---|---|---|
system-prompt/assemble |
waterfall | Mutate/extend the assembly before it reaches the model |
system-prompt/change |
emit | A section or tool provider was registered or unregistered |
Key types
PromptSection—{ name, order, text: string | (() => string) }. Sections are concatenated in ascendingorder.PromptAssembly—{ sections: PromptSection[], tools: ToolSchema[] }. Tool schemas are part of the assembly by design: "what the model is told it can do" is one coherent thing, even though adapters transmit schemas as a separate wire field.renderPrompt(assembly)— joins section texts with blank lines.
Merge-extensible: plugins can declare extra fields on PromptAssembly via
declaration merging.
Extension points
- Section providers: AGENTS.md reader, cwd notifier, persona config, etc.
- Tool schema providers:
ToolRegistryregisters itself as a tool provider automatically. - The
system-prompt/assemblewaterfall: mutate or replace the assembly (system-prompt configurability, dynamic tool filtering).
What is NOT here
- Any hardcoded prompt text — every section comes from plugins.
- Prompt compaction (belongs on the
agent/requestseam indsh-agent).