The review caught the pwshCoverageExclusions comment claiming the inverse of the code's behavior: a bare-PATH probe FAILING grants the exemption, so a win32 host where only install-location pwsh (or 5.1) resolves kept the exemption while its suites ran - over-exempting, never tightening. resolvePwshPath/candidatePwshPaths move to the dependency-free pwsh-local/src/resolve.ts (index.ts re-exports; public API unchanged) and vitest.config.ts probes with that shared definition, so the exemption is active exactly when the suites skip. The two spec headers stop saying 'on PATH' for a probe that is deliberately not PATH-only, and the parity note records the abort backport as the one both-ways parity change (both languages, pairing re-recorded); catalogs regenerated for the line shift.
155 lines
6.4 KiB
TypeScript
155 lines
6.4 KiB
TypeScript
/**
|
|
* Integration tests: the REAL `@deepseek-ai/dsh-pwsh-local` executor plus the
|
|
* `pwsh` tool, exercised through `ctx.tools.execute()` with a real PowerShell
|
|
* process. These verify the world — actual commands run, stdout/stderr come
|
|
* back, exit codes render, timeouts abort, background tasks settle through the
|
|
* generic task runtime, and per-session cwd resolution works. The suite
|
|
* self-skips when no usable `pwsh` resolves (a CI accommodation for hosts without
|
|
* PowerShell); the fake-executor suite (tools.spec.ts) carries the coverage
|
|
* gate.
|
|
*/
|
|
|
|
import { afterEach, beforeEach, describe, expect, it } from 'vitest'
|
|
import { mkdtemp, rm, writeFile } from 'node:fs/promises'
|
|
import { tmpdir } from 'node:os'
|
|
import { join } from 'node:path'
|
|
import { spawnSync } from 'node:child_process'
|
|
import { Context } from 'cordis'
|
|
import { CallId } from '@deepseek-ai/dsh-llm'
|
|
import SystemPrompt from '@deepseek-ai/dsh-system-prompt'
|
|
import ToolRegistry, { TOOL_ABORTED } from '@deepseek-ai/dsh-tools'
|
|
import LocalTaskService from '@deepseek-ai/dsh-tasks-local'
|
|
import * as ToolTasks from '@deepseek-ai/dsh-tool-tasks'
|
|
import LocalSubprocessService from '@deepseek-ai/dsh-subprocess-local'
|
|
import { PwshLocalExecutor, resolvePwshPath } from '@deepseek-ai/dsh-pwsh-local'
|
|
import * as ToolPwsh from '@deepseek-ai/dsh-tool-pwsh'
|
|
import * as BashEnvPlugin from '@deepseek-ai/dsh-bash-env'
|
|
|
|
const testToolSignal = new AbortController().signal
|
|
|
|
// The probe follows the executor's own resolution (Program Files installs on
|
|
// Windows are found even when bare `pwsh` is not on PATH).
|
|
const hasPwsh = spawnSync(resolvePwshPath(), ['-NoLogo', '-NoProfile', '-NonInteractive', '-Command', '$true'], { encoding: 'utf8' }).status === 0
|
|
|
|
/** Normalize PowerShell's platform line endings (CRLF on Windows, LF elsewhere). */
|
|
const lf = (text: string): string => text.replace(/\r\n/g, '\n')
|
|
|
|
let dir: string
|
|
let ctx: Context
|
|
|
|
let callCounter = 0
|
|
function call(name: string, args: unknown, agentObj?: object, signal?: AbortSignal) {
|
|
return ctx.tools.execute({
|
|
signal: signal ?? testToolSignal,
|
|
callId: CallId(`it-${++callCounter}`),
|
|
name,
|
|
arguments: args,
|
|
...agentObj ? { agent: agentObj as never } : {},
|
|
})
|
|
}
|
|
|
|
function text(result: { content: { type: string; text?: string }[] }): string {
|
|
return result.content.filter(b => b.type === 'text').map(b => b.text).join('')
|
|
}
|
|
|
|
describe.skipIf(!hasPwsh)('pwsh tool over the real pwsh executor', () => {
|
|
beforeEach(async () => {
|
|
dir = await mkdtemp(join(tmpdir(), 'dsh-tool-pwsh-'))
|
|
await writeFile(join(dir, 'greeting.txt'), 'hello pwsh\n')
|
|
|
|
ctx = new Context()
|
|
await ctx.plugin(SystemPrompt)
|
|
await ctx.plugin(ToolRegistry)
|
|
await ctx.plugin(LocalTaskService)
|
|
await ctx.plugin(ToolTasks)
|
|
await ctx.plugin(LocalSubprocessService)
|
|
await ctx.plugin(BashEnvPlugin)
|
|
await ctx.plugin(PwshLocalExecutor, { timeoutMs: 20_000, graceMs: 200 })
|
|
await ctx.plugin(ToolPwsh)
|
|
})
|
|
|
|
afterEach(async () => {
|
|
await rm(dir, { recursive: true, force: true })
|
|
})
|
|
|
|
const agent = () => ({ session: { header: { id: 'session-int', cwd: dir } } })
|
|
|
|
it('runs a command and returns stdout with no marker on a clean exit', async () => {
|
|
const result = await call('pwsh', { command: 'Write-Output hi', description: 'say hi' }, agent())
|
|
expect(result.isError).toBe(false)
|
|
if (result.isError) throw new Error('expected pwsh success')
|
|
expect(result.value).toMatchObject({ kind: 'foreground', exitCode: 0 })
|
|
expect(lf(text(result))).toBe('hi\n')
|
|
})
|
|
|
|
it('returns stderr in a marked section and a nonzero exit as a marker, not an error', async () => {
|
|
const result = await call('pwsh', {
|
|
command: '[Console]::Error.WriteLine("boom"); exit 3',
|
|
description: 'fail loudly',
|
|
}, agent())
|
|
expect(result.isError).toBe(false)
|
|
expect(lf(text(result))).toBe('[stderr]\nboom\n[exit code: 3]')
|
|
})
|
|
|
|
it('resolves relative paths in the session workspace', async () => {
|
|
const result = await call('pwsh', {
|
|
command: 'Get-Content greeting.txt',
|
|
description: 'read greeting',
|
|
}, agent())
|
|
expect(result.isError).toBe(false)
|
|
expect(lf(text(result))).toBe('hello pwsh\n')
|
|
})
|
|
|
|
it('a per-call timeout kills the run and reports the timed-out marker, not an error', async () => {
|
|
const result = await call('pwsh', {
|
|
command: 'Start-Sleep -Seconds 60',
|
|
description: 'sleep forever',
|
|
timeoutMs: 100,
|
|
}, agent())
|
|
expect(result.isError).toBe(false)
|
|
if (result.isError) throw new Error('expected a timed-out foreground result')
|
|
expect(result.value).toMatchObject({ kind: 'foreground', timedOut: true, aborted: false })
|
|
// Windows reports the forced termination as exit 1 without a signal;
|
|
// POSIX reports SIGTERM — the timeout marker is the stable fact.
|
|
expect(lf(text(result))).toContain('[timed out after 100ms]')
|
|
})
|
|
|
|
it('an upstream cancellation aborts the run', async () => {
|
|
const controller = new AbortController()
|
|
const pending = call('pwsh', {
|
|
command: 'Start-Sleep -Seconds 60',
|
|
description: 'sleep forever',
|
|
}, agent(), controller.signal)
|
|
setTimeout(() => { controller.abort() }, 50)
|
|
const result = await pending
|
|
expect(result.isError).toBe(true)
|
|
expect(result.error).toMatchObject({ info: { name: 'AbortError', code: TOOL_ABORTED } })
|
|
})
|
|
|
|
it('a background run settles through the REAL task_output tool', async () => {
|
|
const started = await call('pwsh', {
|
|
command: 'Start-Sleep -Milliseconds 300; Write-Output bg-done',
|
|
description: 'background greeting',
|
|
run_in_background: true,
|
|
})
|
|
expect(started.isError).toBe(false)
|
|
if (started.isError) throw new Error('expected background pwsh success')
|
|
expect(started.value).toMatchObject({ kind: 'background' })
|
|
const taskId = (started.value as { taskId: string }).taskId
|
|
|
|
// The output delta and the terminal status can land in separate reads
|
|
// (Windows flushes the child pipe at exit), so collect incrementally —
|
|
// the same two-step shape as the bash background suite.
|
|
const deadline = Date.now() + 10_000
|
|
let output = ''
|
|
while (Date.now() < deadline) {
|
|
const read = await call('task_output', { task_id: taskId })
|
|
output += text(read)
|
|
if (output.includes('bg-done') && output.includes('[status: completed, exit code: 0]')) break
|
|
await new Promise(resolve => setTimeout(resolve, 50))
|
|
}
|
|
expect(output).toContain('bg-done')
|
|
expect(output).toContain('[status: completed, exit code: 0]')
|
|
})
|
|
})
|