imccyu
1b0ea07bce
The definitive slot model for the web client, replacing the first-generation
define/register two-step, ScopedSlots whitelist faces, and binding handles:
- 'root' is the only a-priori slot (SlotsService built-in); the shell renders
exactly ctx.slots.renderSlot('root', {}).
- register is the single API: children = slot declaration + render
authorization + runtime spec in one options object; misconfiguration fails
loud at load (duplicate declaration, undeclared contribution, one store
handle under two scopes).
- Component props arrive in four auto-derived shares: PropsRuntime<K>
(owner params + session/global standard kits via declare-merge),
PropsRenderSlots<S>, PropsStore<H>, and the inject business face.
sessionId is framework-supplied; hooks are framework-made only.
- Framework store seat: defineStore factories declare schema/actions/persist;
read = useStore, write = baked actions only; store scope derives from the
mounting entry; per-session persist keys and clearPersisted lifecycle.
- inject factories read the apply closure's own ctx (binding handles retired;
root-ctx back door closed); SessionProvider is self-wired render-prop.
- Rendering sits behind the SlotRenderer install seam; runtime stays
React-free; ownership ledger keyed to the single entry axis closes the
stale-authority window (StaleAuthorizationError probes).
Docs: the slot type-chain note is refreshed in place as the slot system
standard RFC (bilingual pair re-recorded); the web client architecture RFC
defers its slot sections there; packages/client/AGENTS.md gains the slot and
props discipline; gui-testing/web-styling notes drop missions/ references.
Tests: suites rewritten to the standard (props fed directly, real store
engines via createXXXStore().create(), no render machinery); load-time
negative samples for declaration/authorization/store conflicts; verified by
real-host playwright run (three columns, empty state, collapse, keyed session
remount, cross-slot selection sharing).
docs(ui-sidebar): point contract reference at the committed slot standard RFC
missions/ is workspace-local and never committed; the README must not cite it.
50 lines
2.3 KiB
TypeScript
50 lines
2.3 KiB
TypeScript
/**
|
|
* Runtime invariant companion: the 'slots/changed' emission-order audit —
|
|
* a fired key must already carry a bumped version (emission follows the
|
|
* applied mutation), bogus payloads fail loud, foreign events pass.
|
|
*/
|
|
import { Context } from 'cordis'
|
|
import { describe, expect, it } from 'vitest'
|
|
import InvariantService from '@deepseek-ai/dsh-invariants'
|
|
import * as RuntimeInvariant from '../src/invariant.ts'
|
|
import { SlotsService } from '../src/client/slots.ts'
|
|
|
|
async function setup(): Promise<Context> {
|
|
const ctx = new Context()
|
|
await ctx.plugin(InvariantService, { enabled: true })
|
|
await ctx.plugin(RuntimeInvariant).await()
|
|
return ctx
|
|
}
|
|
|
|
const emit = (ctx: Context, event: string, ...args: unknown[]): void => {
|
|
;(ctx.emit as (event: string, ...args: unknown[]) => void)(event, ...args)
|
|
}
|
|
|
|
describe('runtime slots/changed invariant', () => {
|
|
it('passes foreign events and a legitimate mutation-then-emission sequence', async () => {
|
|
const ctx = await setup()
|
|
expect(() => { emit(ctx, 'unrelated/event', 'x') }).not.toThrow()
|
|
await ctx.plugin(SlotsService).await() // fiber must reach ACTIVE — the audit reads strict ctx.get
|
|
// A real registration bumps the version first and re-emits through
|
|
// onMutate — the audit sees version > 0 and stays quiet. (Erased call:
|
|
// the typed register face rides the wave-1 ui-slots types.)
|
|
const slots = ctx.slots as unknown as { register(options: object, component: unknown): () => void }
|
|
expect(() => slots.register({ name: 'root' }, () => null)).not.toThrow()
|
|
})
|
|
|
|
it('fails loud on a missing key and on an emission with no applied mutation', async () => {
|
|
const ctx = await setup()
|
|
expect(() => { emit(ctx, 'slots/changed', '') }).toThrow(/without a slot key/)
|
|
expect(() => { emit(ctx, 'slots/changed', 42) }).toThrow(/without a slot key/)
|
|
await ctx.plugin(SlotsService).await()
|
|
// Hand-emitted key that never saw a mutation: version 0 → violation.
|
|
expect(() => { emit(ctx, 'slots/changed', 'never-mutated') })
|
|
.toThrow(/before any mutation bumped its version/)
|
|
})
|
|
|
|
it('stays quiet when no slots service is mounted (nothing to audit against)', async () => {
|
|
const ctx = await setup()
|
|
expect(() => { emit(ctx, 'slots/changed', 'any-key') }).not.toThrow()
|
|
})
|
|
})
|