Hypatia May
cec32faa4e
Reform the compaction blueprint so a runaway turn survives and the design
stops drifting across review rounds:
- Drop in-flight-turn protection ("layer 2"). Retention is a uniform tail→head
whole-unit walk; the only structural guard is step-alignment. A single turn
that alone exceeds the window now compacts its own early closed steps instead
of being retained verbatim (the failure mode that motivated this).
- Move auto-compaction off the agent/request waterfall onto a new awaited
agent/pre-request loop seam, fired before history derivation. Compaction
mutates the surface; the loop derives once from the result — no double-derive,
and a listener structurally cannot act on not-yet-derived messages.
- Tighten compactIfNeeded to required (session, system, model, signal).
- Enforce a single-pass convergence invariant in resolveConfig: reject configs
where summarizationMaxTokens + retainTokens exceeds the threshold, so a
compaction can never immediately re-trigger.
- Document the crash vs recoverable failure taxonomy; core session repair stays
compaction-agnostic (a log-only orphaned compact/start is inert).
- Wire dsh-compact-basic into examples/coding-agent and add a with-key
compaction e2e (compaction's first real-world exercise + runaway net).
- Rewrite the RFC to encode the blueprint and move it to implemented/.
The runaway-turn snapshot is a named deferred follow-up: dsh-llm-replay cannot
yet serve the interleaved summarization model call.
96 lines
4.2 KiB
TypeScript
96 lines
4.2 KiB
TypeScript
import { mkdtemp, rm, writeFile } from 'node:fs/promises'
|
|
import { tmpdir } from 'node:os'
|
|
import { join } from 'node:path'
|
|
import { afterEach, describe, expect, it } from 'vitest'
|
|
import type { Context } from 'cordis'
|
|
import { AgentId } from '@deepseek-ai/dsh-agent'
|
|
import { codingHarness, finalText, SYSTEM_PROMPT, waitForIdle } from './harness.ts'
|
|
|
|
/**
|
|
* The compaction smoke test: a real model runs a multi-step bash task with a
|
|
* deliberately tiny context window, so the auto-compaction listener fires
|
|
* MID-SESSION and summarizes the older history into a checkpoint. This is the
|
|
* first end-to-end exercise of the compaction seam (it is wired nowhere else),
|
|
* and the runaway-survival regression net — it proves a session that grows past
|
|
* the window keeps running rather than overflowing. Key-gated.
|
|
*
|
|
* Verifies the WORLD, not the agent's self-report: a compact/start…end pair
|
|
* landed in the real session log, the surface actually shrank (a replace node
|
|
* exists and shadowed older nodes), and the agent still produced a final answer
|
|
* after compaction (so the summarized history did not break the conversation).
|
|
*/
|
|
|
|
let workdir: string | undefined
|
|
let ctx: Context | undefined
|
|
|
|
afterEach(async () => {
|
|
await ctx?.fiber.dispose()
|
|
ctx = undefined
|
|
if (workdir !== undefined) await rm(workdir, { recursive: true, force: true })
|
|
workdir = undefined
|
|
})
|
|
|
|
describe.skipIf(!process.env.DEEPSEEK_API_KEY)('compaction: a long session compacts mid-flight and keeps running', () => {
|
|
it('summarizes older history into a checkpoint without breaking the task', async () => {
|
|
workdir = await mkdtemp(join(tmpdir(), 'dsh-compaction-'))
|
|
// A few files for the model to read, so multiple bash steps accumulate
|
|
// surface nodes (tool calls + results) and grow the history.
|
|
for (let i = 1; i <= 4; i++) {
|
|
await writeFile(join(workdir, `file${i}.txt`), `This is file number ${i}. `.repeat(40))
|
|
}
|
|
|
|
// Tiny window so a handful of steps crosses the threshold. The convergence
|
|
// invariant requires summarizationMaxTokens + retainTokens <= window *
|
|
// ratio = floor(8000 * 0.5) = 4000; 1500 + 2000 = 3500 <= 4000.
|
|
ctx = await codingHarness(workdir, {
|
|
compact: {
|
|
contextWindow: 8000,
|
|
thresholdRatio: 0.5,
|
|
retainTokens: 2000,
|
|
summarizationMaxTokens: 1500,
|
|
},
|
|
})
|
|
const agent = ctx.agentLoop.create(AgentId('e2e-compaction'), {
|
|
model: 'deepseek-v4-flash',
|
|
systemPrompt: SYSTEM_PROMPT,
|
|
})
|
|
|
|
agent.send([{
|
|
type: 'text',
|
|
text: 'Read file1.txt, file2.txt, file3.txt, and file4.txt one at a time using cat '
|
|
+ '(a separate bash command for each). After reading all four, tell me how many '
|
|
+ 'files you read and the number mentioned in file1.txt.',
|
|
}])
|
|
await waitForIdle(ctx, agent)
|
|
|
|
const events = [...agent.session.events]
|
|
|
|
// A compaction ran: the start…end bracket landed in the real log.
|
|
const starts = events.filter(e => e.type === 'compact/start')
|
|
const ends = events.filter(e => e.type === 'compact/end')
|
|
expect(starts.length).toBeGreaterThan(0)
|
|
expect(ends.length).toBe(starts.length) // every start was released
|
|
|
|
// It succeeded at least once: a compact/summary provenance event and a
|
|
// replace-op user/message (the surface mutation) both landed.
|
|
const summaries = events.filter(e => e.type === 'compact/summary')
|
|
expect(summaries.length).toBeGreaterThan(0)
|
|
const replaceNode = events.find((e) => {
|
|
const se = e as unknown as { type: string; surfaceOp?: unknown }
|
|
return se.type === 'user/message' && typeof se.surfaceOp === 'object' && se.surfaceOp !== null
|
|
})
|
|
expect(replaceNode).toBeDefined()
|
|
|
|
// The summary shadowed real older nodes (the surface shrank vs. the raw
|
|
// message-producing event count).
|
|
const summaryData = summaries[0]!.data as { shadowedSeqs: number[] }
|
|
expect(summaryData.shadowedSeqs.length).toBeGreaterThan(0)
|
|
|
|
// The conversation survived compaction: the agent produced a final answer
|
|
// that reflects the work (it read four files).
|
|
const answer = finalText(events).toLowerCase()
|
|
expect(answer.length).toBeGreaterThan(0)
|
|
expect(answer).toMatch(/\b(4|four)\b/)
|
|
}, 240_000)
|
|
})
|