Dudu-0223
d01f5f73b7
Introduce web access as a first-class capability seam so the model-facing web tools stay stable while backends change. dsh-web owns ctx.web as a provider registry with registration-order-independent selection and the WebError taxonomy; dsh-web-search-exa, dsh-web-search-perplexity, and dsh-web-fetch-local register capabilities into it; dsh-tool-web is the sole owner of the model-facing web_search/web_fetch schemas, prompt sections, and HTML-to-markdown presentation. Search and fetch are deliberately one seam. Providers ship as namespace plugins that register into ctx.web (like an LlmAdapter into ctx.llm), not key-owning services, since multiple search providers cannot each own the key. Tool registration follows product enablement, not backend availability, so load order/credentials never enter the model contract; the seam resolves the provider at execution time and surfaces a structured WebError otherwise. Moves the RFC to implemented/ amended to match what shipped. Example/app configs are intentionally not wired yet (RFC migration step 6).
50 lines
2.3 KiB
TypeScript
50 lines
2.3 KiB
TypeScript
/**
|
|
* Real-load-path guard for @deepseek-ai/dsh-tool-web. `tool-web` is a NAMESPACE
|
|
* plugin with `inject` — so a stray `export default apply` would make the cordis
|
|
* Loader's `unwrapExports` (`exports.default ?? exports`) collapse the module to
|
|
* the bare `apply` function, DROPPING `inject`. The plugin would then read
|
|
* `ctx.web` without having injected it and throw `cannot get property … without
|
|
* inject` the moment it loads (postmortem 0001).
|
|
*
|
|
* A hand-built `ctx.plugin({ apply, inject })` mount CANNOT catch that — it
|
|
* bypasses `unwrapExports`. So this test unwraps the module through the REAL
|
|
* `Loader.prototype.unwrapExports` and mounts the result over `ctx.web`,
|
|
* exercising the exact path the Loader uses. Prove the guard bites: add
|
|
* `export default apply` to `src/index.ts`, watch this go red, revert.
|
|
*/
|
|
|
|
import { describe, expect, it } from 'vitest'
|
|
import { Context } from 'cordis'
|
|
import Loader from '@cordisjs/plugin-loader'
|
|
import SystemPrompt from '@deepseek-ai/dsh-system-prompt'
|
|
import ToolRegistry from '@deepseek-ai/dsh-tools'
|
|
import WebService from '@deepseek-ai/dsh-web'
|
|
import * as toolWeb from '@deepseek-ai/dsh-tool-web'
|
|
|
|
describe('dsh-tool-web real-load-path guard', () => {
|
|
it('has no default export and keeps name/inject/Config through unwrapExports', () => {
|
|
expect('default' in toolWeb).toBe(false)
|
|
|
|
const loader = Object.create(Loader.prototype) as Loader
|
|
const unwrapped = loader.unwrapExports(toolWeb) as Record<string, unknown>
|
|
expect(unwrapped).toBe(toolWeb)
|
|
expect(unwrapped.name).toBe('tool-web')
|
|
expect(unwrapped.inject).toEqual(['tools', 'web', 'systemPrompt'])
|
|
expect(typeof unwrapped.apply).toBe('function')
|
|
})
|
|
|
|
it('boots over ctx.web through the unwrapped module without an inject error', async () => {
|
|
const ctx = new Context()
|
|
await ctx.plugin(SystemPrompt)
|
|
await ctx.plugin(ToolRegistry)
|
|
await ctx.plugin(WebService, {})
|
|
|
|
const loader = Object.create(Loader.prototype) as Loader
|
|
const unwrapped = loader.unwrapExports(toolWeb) as Parameters<Context['plugin']>[0]
|
|
// A collapsed export shape (dropped inject) would throw "without inject" here.
|
|
const fiber = await ctx.plugin(unwrapped)
|
|
expect(ctx.tools.schemas().map(s => s.name)).toEqual(expect.arrayContaining(['web_search', 'web_fetch']))
|
|
await fiber.dispose()
|
|
})
|
|
})
|