Tianyi Cui
8adcbceeed
The two bridge plugins that run a user's existing Claude Code / Codex hook
config on the harness's typed interception seams, built on the shared
dsh-hook-protocol library. A bridge is a faithfulness adapter, not a power
tool: anything it does a native cordis plugin does more powerfully — the
bridge exists only to run UNMODIFIED external hooks.
- dsh-hooks-claude: CC dialect. Seven hook points (SessionStart,
UserPromptSubmit, PreToolUse, PostToolUse, Stop, SubagentStart,
SubagentStop), CC per-event stdin payloads, env + ${CLAUDE_PLUGIN_ROOT}/
${CLAUDE_PROJECT_DIR} substitution, literal-or-regex matcher.
- dsh-hooks-codex: Codex dialect — a deliberate subset. Five hook points,
always-regex matcher, snake_case payloads (turn_id/model, no trailing
newline), no env/substitution, block-only decisions.
Both map the neutral merged outcome onto the seam's typed Decision and stamp
an explicit {kind:'plugin'} source on injected context (so it is never
mislabeled as a user prompt). Config parse-failure is contained; only command
hooks run. updatedInput is logged+warned (input rewrite deferred); the Stop
loop-guard is deferred (TODO).
Tests: per-file 100% — config-parse unit branches + per-seam mappings
end-to-end through the REAL loop + REAL bash + REAL shell scripts (scripted
mock model only) + a real-Loader export-shape guard. A keyless ACP snapshot
scenario (hook-prompt-block) proves a UserPromptSubmit hook blocks a prompt
end-to-end (rejected turn -> ACP cancelled, hook/* events in the log); a
with-key e2e (hooks.e2e.ts) proves a PreToolUse hook blocks real bash
(verified on disk). The snapshot normalizer now scrubs hook/result.durationMs.
RFC: docs/rfc/implemented/feature/2026-06-30-hook-bridges.md
69 lines
3.3 KiB
TypeScript
69 lines
3.3 KiB
TypeScript
import { describe, expect, it } from 'vitest'
|
|
import { parseCodexConfig, CODEX_EVENTS } from '@deepseek-ai/dsh-hooks-codex/src/config.ts'
|
|
|
|
describe('parseCodexConfig', () => {
|
|
it('honors only the five Codex events, dropping unknown ones', () => {
|
|
const { config } = parseCodexConfig({
|
|
PreToolUse: [{ hooks: [{ type: 'command', command: 'a.sh' }] }],
|
|
SubagentStop: [{ hooks: [{ type: 'command', command: 'b.sh' }] }], // not a Codex event
|
|
Notification: [{ hooks: [{ type: 'command', command: 'c.sh' }] }], // not a Codex event
|
|
})
|
|
expect(Object.keys(config)).toEqual(['PreToolUse'])
|
|
expect(CODEX_EVENTS).toContain('PreToolUse')
|
|
expect(CODEX_EVENTS).not.toContain('SubagentStop' as never)
|
|
})
|
|
|
|
it('accepts both timeout and the timeoutSec alias, no substitution', () => {
|
|
const { config } = parseCodexConfig({
|
|
Stop: [{ hooks: [{ type: 'command', command: '${NOT_SUBSTITUTED}/s.sh', timeout: 10 }] }],
|
|
UserPromptSubmit: [{ hooks: [{ type: 'command', command: 'u.sh', timeoutSec: 20 }] }],
|
|
})
|
|
// Codex does NO substitution — the literal ${…} survives.
|
|
expect(config.Stop).toEqual([{ hooks: [{ command: '${NOT_SUBSTITUTED}/s.sh', timeoutSec: 10 }] }])
|
|
expect(config.UserPromptSubmit).toEqual([{ hooks: [{ command: 'u.sh', timeoutSec: 20 }] }])
|
|
})
|
|
|
|
it('skips non-command and async:true hooks (recorded)', () => {
|
|
const { config, skipped } = parseCodexConfig({
|
|
PreToolUse: [{ hooks: [
|
|
{ type: 'prompt' },
|
|
{ type: 'command', command: 'sync.sh' },
|
|
{ type: 'command', command: 'bg.sh', async: true },
|
|
] }],
|
|
})
|
|
expect(config.PreToolUse).toEqual([{ hooks: [{ command: 'sync.sh' }] }])
|
|
expect(skipped).toEqual([{ event: 'PreToolUse', reason: 'unsupported "prompt" hook' }, { event: 'PreToolUse', reason: 'async hook' }])
|
|
})
|
|
|
|
it('parses the { hooks: … } wrapper and the bare map identically', () => {
|
|
const groups = { Stop: [{ hooks: [{ type: 'command', command: 's.sh' }] }] }
|
|
expect(parseCodexConfig(groups).config).toEqual(parseCodexConfig({ hooks: groups }).config)
|
|
})
|
|
|
|
it('drops malformed entries and a non-object top level without throwing', () => {
|
|
expect(parseCodexConfig(null).config).toEqual({})
|
|
expect(parseCodexConfig({ PreToolUse: 'no' }).config).toEqual({})
|
|
expect(parseCodexConfig({ Stop: [7, { hooks: 'x' }, { hooks: [{ type: 'command', command: 9 }] }] }).config).toEqual({})
|
|
})
|
|
|
|
it('skips a non-object element inside a hooks array, keeping the valid sibling', () => {
|
|
const { config } = parseCodexConfig({ Stop: [{ hooks: [null, 7, { type: 'command', command: 's.sh' }] }] })
|
|
expect(config.Stop).toEqual([{ hooks: [{ command: 's.sh' }] }])
|
|
})
|
|
|
|
it('treats a hook with no `type` field as a command (the default)', () => {
|
|
const { config } = parseCodexConfig({ Stop: [{ hooks: [{ command: 's.sh' }] }] })
|
|
expect(config.Stop).toEqual([{ hooks: [{ command: 's.sh' }] }])
|
|
})
|
|
|
|
it('omits the matcher key for a match-all group', () => {
|
|
const { config } = parseCodexConfig({ Stop: [{ hooks: [{ type: 'command', command: 's.sh' }] }] })
|
|
expect('matcher' in config.Stop![0]!).toBe(false)
|
|
})
|
|
|
|
it('keeps a matcher when present', () => {
|
|
const { config } = parseCodexConfig({ PreToolUse: [{ matcher: '^Bash$', hooks: [{ type: 'command', command: 'b.sh' }] }] })
|
|
expect(config.PreToolUse![0]!.matcher).toBe('^Bash$')
|
|
})
|
|
})
|