Tianyi Cui
66e56bd395
Codex review of PR #88 found three issues in the example-app extraction: A1 — examples/coding-agent/README.md's plugin table still listed the OLD direct-wired leaf entries (agent-loop, session-persistence, src/stdio-chat.ts — the whole src/ dir is gone). Rewrite it to the four real leaf entries the current cordis.yml loads (hmr, llm-deepseek, bash, stdio-agent), noting that tool-bash/persistence/agent/loop now live inside the agent-core + stdio-agent bundles. A2 — the three new app/spine packages (agent-core, stdio-agent, acp-agent) export NO `inject`, so a stray `export default apply` would let unwrapExports collapse the module and silently DROP name/Config WITHOUT crashing — the real-load-path smokes would stay green. agent-core is never Loader-unwrapped at all. Add an explicit export-shape guard per package: assert no `default` export and that the real Loader.unwrapExports leaves name/Config/apply intact. Verified each fails when `export default apply` is added. B — soften "structurally unreachable / cannot wire a stdout logger" overclaims in the acp-agent/agent-core READMEs and the implemented RFC: a leaf CAN still add a sibling logger entry; the accurate claim is the app omits one so the default leaf has nothing to get wrong. Keep the safety directive (never add a stdout logger to an ACP leaf).
93 lines
4.4 KiB
TypeScript
93 lines
4.4 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import { Context } from 'cordis'
|
|
import Loader from '@cordisjs/plugin-loader'
|
|
import { AgentId } from '@deepseek-ai/dsh-agent'
|
|
import * as stdioAgent from '../src/index.ts'
|
|
|
|
/**
|
|
* Unit coverage for the @deepseek-ai/dsh-stdio-agent app plugin: mounting it
|
|
* composes the console logger, the agent-core spine (pre-creating the `main`
|
|
* agent from the app config), the JSONL backend, and the readline UI in one
|
|
* `ctx.plugin`. The forwarded `model`/`systemPrompt` reach the pre-created
|
|
* agent; `persistenceRoot`/`welcome`/`resumeSessionId` route to their backends.
|
|
*
|
|
* `hmr` is NOT part of this plugin (it is a leaf entry — a Loader-only dev
|
|
* plugin the in-process tier cannot import); the REAL Loader-path guard (export
|
|
* shape, `unwrapExports`, the whole subprocess tree incl. `hmr`) is the keyless
|
|
* echo smoke in `examples/echo-agent`. Here we assert the composition + config
|
|
* forwarding the unit tier can reach.
|
|
*/
|
|
async function mount(config: stdioAgent.Config): Promise<Context> {
|
|
const ctx = new Context()
|
|
await ctx.plugin(stdioAgent, config)
|
|
// The app mounts its children inside apply() (not awaited there); let their
|
|
// fibers settle so the spine services + the pre-created agent are ready.
|
|
await new Promise(resolve => setTimeout(resolve, 80))
|
|
return ctx
|
|
}
|
|
|
|
describe('dsh-stdio-agent app', () => {
|
|
it('composes the spine + front-door cluster and pre-creates the main agent', async () => {
|
|
const ctx = await mount({ model: 'mock', systemPrompt: 'hi', persistenceRoot: '/tmp/dsh-stdio-agent-spec' })
|
|
// The spine services (brought up by the agent-core bundle) are all present.
|
|
expect(ctx.get('agents')).toBeDefined()
|
|
expect(ctx.get('agentLoop')).toBeDefined()
|
|
expect(ctx.get('sessionPersistence')).toBeDefined()
|
|
// The pre-created `main` agent the UI drives.
|
|
expect(ctx.get('agents')?.get(AgentId('main'))).toBeDefined()
|
|
await ctx.fiber.dispose()
|
|
})
|
|
|
|
it('defaults persistenceRoot and welcome when omitted', async () => {
|
|
// Direct apply (NOT via ctx.plugin, which validates+defaults the config
|
|
// first) so the runtime `?? './.sessions'` / `?? 'ready.'` fallbacks on
|
|
// apply()'s last two lines are the ones that fire — covering a
|
|
// schema-bypassing direct-mount caller.
|
|
const ctx = new Context()
|
|
stdioAgent.apply(ctx, { model: 'mock', systemPrompt: 'hi' })
|
|
await new Promise(resolve => setTimeout(resolve, 80))
|
|
expect(ctx.get('sessionPersistence')).toBeDefined()
|
|
expect(ctx.get('agents')?.get(AgentId('main'))).toBeDefined()
|
|
await ctx.fiber.dispose()
|
|
})
|
|
|
|
it('forwards resumeSessionId onto the pre-created agent when set', async () => {
|
|
// A resume id defers agent creation until persistence loads; with no backing
|
|
// session the resume is contained + logged, so no `main` agent registers —
|
|
// the branch that maps resumeSessionId through is what this covers.
|
|
const ctx = await mount({
|
|
model: 'mock',
|
|
systemPrompt: 'hi',
|
|
persistenceRoot: '/tmp/dsh-stdio-agent-spec-resume',
|
|
resumeSessionId: 'no-such-session',
|
|
})
|
|
expect(ctx.get('agents')?.get(AgentId('main'))).toBeUndefined()
|
|
await ctx.fiber.dispose()
|
|
})
|
|
|
|
it('exposes its name and Config schema', () => {
|
|
expect(stdioAgent.name).toBe('stdio-agent')
|
|
expect(stdioAgent.Config).toBeDefined()
|
|
})
|
|
|
|
it('has the namespace-plugin export shape (no stray default) so the Loader keeps name/Config/apply', () => {
|
|
// Postmortem 0001 guard: a stray `export default apply` makes the Loader's
|
|
// `unwrapExports` (`exports.default ?? exports`) collapse the module to the
|
|
// bare `apply` function, DROPPING the named `name`/`Config`. This package has
|
|
// no `inject` export, so that collapse would NOT crash at load (the keyless
|
|
// echo smoke would still boot the tree) — it would silently lose its config
|
|
// schema. So guard the shape directly here: assert no `default` export, and
|
|
// that the real `unwrapExports` leaves `name`/`Config`/`apply` intact. Adding
|
|
// `export default` to src/index.ts fails this test.
|
|
expect('default' in stdioAgent).toBe(false)
|
|
expect(typeof stdioAgent.apply).toBe('function')
|
|
|
|
const loader = Object.create(Loader.prototype) as Loader
|
|
const unwrapped = loader.unwrapExports(stdioAgent) as Record<string, unknown>
|
|
expect(unwrapped).toBe(stdioAgent)
|
|
expect(unwrapped.name).toBe('stdio-agent')
|
|
expect(unwrapped.Config).toBeDefined()
|
|
expect(typeof unwrapped.apply).toBe('function')
|
|
})
|
|
})
|