Turtle
db432c1e74
fix(install): correct a false claim about shell assignment semantics
...
Review flagged the resolve_dir comment: it claimed `x=$(cmd) || fallback`
never fires "because the assignment succeeds even when the substitution
fails." That is wrong — command substitution propagates exit status and the
fallback does fire, confirmed in sh, bash, dash, and zsh.
Reproducing the original code shows the fallback also worked, so the second
"recurrence" the Agent Note described never existed. Both real defects were
the same one: comparing a resolved path against an unresolved one. The note
now says that instead of inventing a mechanism.
resolve_dir keeps its `|| printf` because it makes every caller a plain
assignment, so no site can compare against an empty path by forgetting its
own fallback — the reason is now stated accurately.
Also from review: REPO_COMMON is now resolved on both branches, matching
REPO_ROOT, and _repo_root notes why it is already physical without its own
resolve_dir call.
2026-07-31 23:40:40 +08:00
..
2026-07-23 23:12:56 +08:00
2026-07-31 17:44:13 +08:00
2026-07-26 23:29:46 +08:00
2026-07-18 13:03:44 +08:00
2026-07-27 00:53:07 +08:00
2026-07-27 00:01:39 +08:00
2026-07-30 01:29:18 +08:00
2026-07-30 01:29:18 +08:00
2026-07-28 01:02:43 +08:00
2026-07-28 01:02:43 +08:00
2026-07-19 21:24:42 +08:00
2026-06-11 15:07:55 +08:00
2026-07-27 18:55:13 +08:00
2026-07-29 00:45:52 +08:00
2026-07-26 02:51:58 +08:00
2026-07-26 02:51:58 +08:00
2026-07-28 09:53:32 +08:00
2026-07-30 00:05:00 +08:00
2026-07-27 18:43:00 +08:00
2026-07-25 00:10:37 +08:00
2026-07-23 00:39:55 +08:00
2026-07-20 16:33:44 +08:00
2026-07-20 16:33:44 +08:00
2026-07-29 23:55:12 +08:00
2026-07-31 02:55:37 +08:00
2026-07-31 02:55:37 +08:00
2026-07-30 14:56:39 +08:00
2026-07-29 21:15:42 +08:00
2026-07-26 23:14:28 +08:00
2026-07-30 14:33:36 +08:00
2026-07-19 19:26:38 +08:00
2026-07-22 16:24:44 +08:00
2026-07-27 06:21:53 +08:00
2026-07-19 22:52:03 +08:00
2026-07-29 23:55:12 +08:00
2026-07-31 17:57:11 +08:00
2026-07-30 19:57:17 +08:00
2026-07-30 21:19:17 +08:00
2026-07-24 01:40:25 +08:00
2026-07-28 00:00:51 +08:00
2026-07-23 03:59:05 +08:00
2026-07-31 17:16:37 +08:00
2026-07-31 17:16:37 +08:00
2026-07-30 21:14:03 +08:00
2026-07-27 02:31:07 +08:00
2026-07-30 15:18:06 +08:00
2026-07-30 20:17:04 -07:00
2026-07-30 20:52:35 -07:00
2026-07-31 23:40:40 +08:00
2026-07-27 03:28:39 +08:00
2026-07-29 23:26:16 +08:00
2026-07-27 12:02:39 +08:00
2026-07-26 23:44:52 +08:00
2026-07-29 23:36:08 +08:00
2026-07-15 19:11:20 +08:00
2026-07-21 00:25:38 +08:00
2026-07-21 00:25:38 +08:00
2026-07-26 02:52:48 +08:00
2026-07-26 02:52:48 +08:00
2026-07-22 16:55:39 +08:00
2026-07-31 13:47:51 +08:00
2026-07-31 13:43:03 +08:00
2026-07-27 21:27:42 +08:00
2026-07-27 12:02:39 +08:00
2026-07-27 00:53:07 +08:00
2026-07-31 10:26:05 +08:00
2026-07-31 10:33:53 +08:00
2026-07-29 23:39:49 +08:00
2026-07-29 23:39:49 +08:00
2026-07-26 23:44:52 +08:00
2026-07-27 03:54:33 +08:00
2026-07-27 03:54:33 +08:00
2026-07-30 20:15:40 +08:00
2026-07-31 10:41:44 +08:00
2026-07-31 10:41:44 +08:00
2026-07-27 02:31:07 +08:00
2026-07-27 02:31:07 +08:00
2026-07-28 10:28:49 -07:00
2026-07-26 15:51:24 +08:00
2026-07-28 10:28:49 -07:00
2026-07-27 09:39:54 +08:00
2026-07-23 22:41:53 +08:00
2026-07-23 23:12:56 +08:00
2026-07-23 23:12:56 +08:00
2026-07-26 00:30:20 +08:00
2026-07-31 17:57:11 +08:00
2026-07-19 23:15:23 +08:00
2026-07-19 23:15:23 +08:00
2026-07-27 00:01:39 +08:00
2026-07-26 23:14:28 +08:00
2026-07-21 20:15:09 +08:00
2026-07-26 23:14:28 +08:00
2026-07-31 02:00:14 -07:00
2026-07-13 23:27:00 +08:00
2026-07-19 22:52:03 +08:00
2026-07-29 14:32:11 +08:00
2026-07-27 18:53:30 +08:00
2026-07-26 23:06:00 +08:00
2026-07-27 18:53:30 +08:00
2026-07-15 16:38:22 +08:00
2026-07-20 00:38:37 +08:00
2026-07-27 06:21:53 +08:00
2026-07-19 22:52:03 +08:00
2026-07-31 11:02:45 +08:00
2026-07-26 23:14:28 +08:00
2026-07-28 04:34:05 -07:00
2026-07-23 23:12:56 +08:00
2026-07-27 12:02:39 +08:00
2026-07-30 21:49:33 +08:00
2026-07-28 16:16:10 +08:00