imccyu
bbde18caff
Four rounds of structural rework on the conversation surface, converging on one registration model for the whole client: - Review fixes: open() leaves the inject factory (SessionsService owns the semantic); ConversationService mounts via ctx.plugin(); the bespoke view registry retires into the 'conversation.view' list slot. - Ring alignment: createChatView factory retired (components get everything through checkable shares at the register call site); the hand-rolled t/i18n threading is deleted wholesale — a future framework-level i18n will supply t as a standard prop keyed by slot name, so no interim manual channel. - Toolview dissolution: ToolViewRegistry / ToolViewResolver / ToolViewOutlet / ctx.toolviews retire. Tool rows are entries of the 'conversation.chat.toolview' keyed slot (scope: session) declared by the chat entry; ToolRowOwnerProps is the unified owner payload; GenericToolCard becomes the call-site fallback; registrants are plain plugins (inject ['slots','conversation'] as the load-order seam); session-dimension dispatch moves into components (useSessions reads parentId); trajectory/waterfall gain same-shape slots the day they render tool rows (RendersCheck rejects empty declarations). Slot names mirror the composition path (<domain>.<entry>.<hole>). - Staging follows current: cell()/binding() are pure resolution (render-safe); the constructor subscribes to the list store and followCurrent opens the event window when the current session changes — staging IS the open signal, business verbs are the timing, React render/commit is decoupled from window lifecycle. A masked current (projection gap) keeps the stage untouched so deferred teardown semantics survive reconnects. Agent Note: .agents/notes/implemented/architecture/ 2026-07-23-toolview-dissolution.md (bilingual pair) records the decision, the four rejected alternatives, and the accepted semantic changes; the web client architecture note and packages/client/AGENTS.md carry the current-state narrative. Verified: typecheck 0, duplication 0 clones (478 files), full coverage run 6190 passed with zero threshold errors, knip 0, doc-sync 24/24, client aggregate tsc 0, render-count checks (one commit per chunk, zero row re-renders under streaming) green.
87 lines
3.6 KiB
TypeScript
87 lines
3.6 KiB
TypeScript
// @vitest-environment jsdom
|
|
/**
|
|
* Real tsdown artifact shape: lib/client.js hands off through
|
|
* window.DSHClientProxy.loadPlugin, resolves externals through the injected
|
|
* require, returns the export surface (apply + inject), and a mounted apply
|
|
* registers both view tabs into a real SlotsService ring. Skips when dist/ is
|
|
* not built (`pnpm --filter @deepseek-ai/dsh-client-ui-trajectory bundle`).
|
|
*/
|
|
import { readFileSync } from 'node:fs'
|
|
import { resolve } from 'node:path'
|
|
import { Context } from 'cordis'
|
|
import { afterEach, describe, expect, it } from 'vitest'
|
|
import { SlotsService } from '@deepseek-ai/dsh-client-runtime/client'
|
|
|
|
const PLUGIN_ID = '@deepseek-ai/dsh-client-ui-trajectory'
|
|
|
|
interface Handoff { id: string; factory: (require: (spec: string) => unknown) => Record<string, unknown> }
|
|
type Win = { DSHClientProxy?: { loadPlugin(h: Handoff): void } }
|
|
|
|
function readBundle(): string | undefined {
|
|
try {
|
|
// import.meta.url is http-scheme in the jsdom pool; vitest runs from the
|
|
// repo root, so resolve the artifact repo-relatively instead.
|
|
return readFileSync(resolve('packages/client/ui-trajectory/lib/client.js'), 'utf8')
|
|
} catch {
|
|
return undefined
|
|
}
|
|
}
|
|
|
|
afterEach(() => {
|
|
delete (window as Win).DSHClientProxy
|
|
for (const el of document.querySelectorAll('style')) el.remove()
|
|
})
|
|
|
|
describe('tsdown client artifact', () => {
|
|
const code = readBundle()
|
|
|
|
async function loadArtifact() {
|
|
let handoff: Handoff | undefined
|
|
;(window as Win).DSHClientProxy = { loadPlugin: (h) => { handoff = h } }
|
|
// Same execution form the loader uses (inline script eval, window scope) —
|
|
// the implied-eval ban targets accidental string execution, not this
|
|
// deliberate bundle-execution fixture.
|
|
// eslint-disable-next-line @typescript-eslint/no-implied-eval, @typescript-eslint/no-unsafe-call
|
|
new Function(code!)()
|
|
expect(handoff).toBeDefined()
|
|
const modules = new Map<string, unknown>([
|
|
['react', await import('react')],
|
|
['react/jsx-runtime', await import('react/jsx-runtime')],
|
|
])
|
|
const surface = handoff!.factory((spec) => {
|
|
if (!modules.has(spec)) throw new Error(`unexpected require: ${spec}`)
|
|
return modules.get(spec)
|
|
})
|
|
return { handoff: handoff!, surface }
|
|
}
|
|
|
|
it.skipIf(code === undefined)('hands off with the manifest id and a DI-require factory', async () => {
|
|
const { handoff, surface } = await loadArtifact()
|
|
expect(handoff.id).toBe(PLUGIN_ID)
|
|
expect(surface.apply).toBeTypeOf('function')
|
|
expect(surface.inject).toEqual(['slots'])
|
|
})
|
|
|
|
it.skipIf(code === undefined)('mounted as an object plugin, apply registers both view tabs on the real ring', async () => {
|
|
const { surface } = await loadArtifact()
|
|
const ctx = new Context()
|
|
const slots = new SlotsService(ctx)
|
|
// The conversation entry's role: the ring must be declared before riders land.
|
|
slots.register({
|
|
name: 'root',
|
|
children: { 'conversation.view': { kind: 'list', scope: 'session' } },
|
|
}, (_p: { renderSlot?: unknown }) => null)
|
|
const fiber = ctx.plugin(surface as { apply: (ctx: Context) => void })
|
|
await fiber.await()
|
|
expect(slots.entries('conversation.view').map(e => e.options.id)).toEqual(['trajectory', 'waterfall'])
|
|
await fiber.dispose()
|
|
expect(slots.entries('conversation.view')).toHaveLength(0)
|
|
})
|
|
|
|
it.skipIf(code === undefined)('injects plugin-tagged module CSS during factory execution', async () => {
|
|
await loadArtifact()
|
|
const tags = document.querySelectorAll(`style[data-plugin=${JSON.stringify(PLUGIN_ID)}]`)
|
|
expect(tags.length).toBeGreaterThan(0)
|
|
})
|
|
})
|