imccyu
ea8b1178cd
Sidebar session list grows the figma 239-10458 feature set and the
workspace/session browsing region moves wholesale into ui-workspace:
- Group-by menu (WorkSpace / In one list): flat mode lists every session
top-level, strictly newest-first; the choice persists across reloads.
- Session rows get a 500ms hover detail card (title / relative time /
status line) and a ... menu (Rename / Fork session / Delete session,
visual-only for now); workspace headers get ... with Rename (wired) and
Delete workspace (visual-only).
- workspace.rename RPC: trims, rejects duplicate titles on the create
chain (workspace-name-conflict), no-op on same title; modal dialog with
client-side duplicate pre-check.
- workspace.insertSessionBefore RPC (DOM-insertBefore semantics, omitted
anchor appends): HTML5 drag reorder of root sessions inside a workspace
group; order truth stays host-side, the view refreshes from the
response/changed frame.
- Activity pinning removed: the session/event touchSession chain is gone;
workspace accounts are manually owned (new sessions prepend, explicit
reordering only). Contracts and tests updated, api catalog regenerated.
- ui-sidebar reduced to the column shell (brand, fold state machine, New
Session, Settings) exposing one sidebar.workspaces hole with a two-fact
owner share {wide, expandSidebar}; ui-workspace owns the whole region
(header, search, grouped/flat lists, dialogs, drag) plus the picker via
a shared WorkspaceCreateFlow. The old sidebar.workspace picker slot and
its deferral indirection are gone.
- ui-primitives: Menu gains label entries, danger rows, and
closeOnPointerLeave; new HoverCard (portaled, open-delay, disabled
guard). Hover card and row menu never coexist.
84 lines
3.1 KiB
TypeScript
84 lines
3.1 KiB
TypeScript
// @vitest-environment jsdom
|
|
import { afterEach, describe, expect, it, vi } from 'vitest'
|
|
import { cleanup, fireEvent, render, screen } from '@testing-library/react'
|
|
import type { SidebarRootComponentProps, SidebarSectionOwnerProps } from '../src/client/contract/slots.ts'
|
|
import { SidebarRoot } from '../src/client/SidebarRoot.tsx'
|
|
|
|
afterEach(() => {
|
|
cleanup()
|
|
vi.useRealTimers()
|
|
})
|
|
|
|
// The shell never reads the global hooks itself, but they ride the standard
|
|
// props share; stub them as never-called functions.
|
|
const neverHook = (() => { throw new Error('shell must not read global hooks') }) as never
|
|
|
|
function mountShell({ collapsed = false, width = 300 }: { collapsed?: boolean; width?: number } = {}) {
|
|
const startSession = vi.fn()
|
|
const toggleSidebar = vi.fn()
|
|
let regionOwner: SidebarSectionOwnerProps | undefined
|
|
let current = { collapsed, width }
|
|
const root = () => (
|
|
<SidebarRoot
|
|
collapsed={current.collapsed} width={current.width}
|
|
useSessions={neverHook} useWorkspaces={neverHook}
|
|
startSession={startSession} toggleSidebar={toggleSidebar}
|
|
renderSlot={((_key: string, owner: SidebarSectionOwnerProps) => {
|
|
regionOwner = owner
|
|
return <div data-testid="region" data-wide={owner.wide} />
|
|
}) as SidebarRootComponentProps['renderSlot']}
|
|
/>
|
|
)
|
|
const view = render(root())
|
|
return {
|
|
startSession,
|
|
toggleSidebar,
|
|
regionOwner: () => {
|
|
if (regionOwner === undefined) throw new Error('region owner not rendered')
|
|
return regionOwner
|
|
},
|
|
rerender(next: Partial<typeof current>) {
|
|
current = { ...current, ...next }
|
|
view.rerender(root())
|
|
},
|
|
}
|
|
}
|
|
|
|
describe('SidebarRoot shell', () => {
|
|
it('routes New Session and the column toggle', () => {
|
|
const b = mountShell()
|
|
fireEvent.click(screen.getByRole('button', { name: 'New session' }))
|
|
expect(b.startSession).toHaveBeenCalledWith()
|
|
fireEvent.click(screen.getByRole('button', { name: 'Collapse sidebar' }))
|
|
expect(b.toggleSidebar).toHaveBeenCalledOnce()
|
|
})
|
|
|
|
it('hands the region its wide flag and clamps expandSidebar to the collapsed state', () => {
|
|
const b = mountShell()
|
|
expect(b.regionOwner().wide).toBe(true)
|
|
// Expanded: the request is a no-op (no accidental collapse).
|
|
b.regionOwner().expandSidebar()
|
|
expect(b.toggleSidebar).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('keeps the region mounted through collapse and expands on its request', () => {
|
|
vi.useFakeTimers()
|
|
const b = mountShell()
|
|
b.rerender({ collapsed: true })
|
|
// Wide content survives the crossfade window, then settles into the rail.
|
|
expect(b.regionOwner().wide).toBe(true)
|
|
vi.advanceTimersByTime(200)
|
|
b.rerender({})
|
|
expect(b.regionOwner().wide).toBe(false)
|
|
expect(screen.getByTestId('region')).toBeTruthy()
|
|
b.regionOwner().expandSidebar()
|
|
expect(b.toggleSidebar).toHaveBeenCalledOnce()
|
|
})
|
|
|
|
it('renders statically collapsed on a cold start (no crossfade classes)', () => {
|
|
const b = mountShell({ collapsed: true })
|
|
expect(b.regionOwner().wide).toBe(false)
|
|
expect(screen.getByRole('button', { name: 'Open sidebar' })).toBeTruthy()
|
|
})
|
|
})
|