A. SQLite 并发写失败被吞(高概率根因): - DSN 追加 _busy_timeout=5000&_journal_mode=WAL&_synchronous=NORMAL, WAL 下读不阻塞写,消除瞬时 SQLITE_BUSY - UpdateMessagesFlags 不再吞 MarkReadState/MarkFlagged 错误: 出错记日志并返回 error(客户端收到 NO 会重试) - Web MarkRead/Delete 同款静默丢错补日志 B. 客户端 seq 视图错位(集成测试复现后修复): - 真实服务器+脚本客户端测试复现:客户端按日期倒序自编号发 seq 式 STORE 时,旧排序(id ASC)把最旧邮件标为已读 - 规范排序改为 date DESC, id DESC(最新在前),与主流客户端 默认视图一致;buildNewMessageUpdate 改用 seqOf 取真实序号 - 新增 UID STORE / 服务器下发 seq STORE / 自编号 seq STORE 集成测试 注:go-imap v1.2.1 存在库内 *conn.silent() 数据竞争(启用推送后 必然触发),集成测试以 //go:build !race 排除,-race 下由单元测试 覆盖推送逻辑
191 lines
5.9 KiB
Go
191 lines
5.9 KiB
Go
//go:build !race
|
||
|
||
// 集成测试:启动真实 IMAP 监听 + 脚本客户端(go-imap client)。
|
||
// 注意:仅在非 -race 构建下运行——go-imap v1.2.1 存在库内数据竞争
|
||
// (cmd_selected.go STORE 写 *conn.silent() vs listenUpdates 读),
|
||
// 启用 backend 推送(Updates != nil)时必然触发,-race 下会误报。
|
||
// 推送逻辑的竞态覆盖由单元测试(notify_test.go)承担。
|
||
package imap_server
|
||
|
||
import (
|
||
"net"
|
||
"path/filepath"
|
||
"testing"
|
||
"time"
|
||
|
||
"mail_go/config"
|
||
"mail_go/internal/connhub"
|
||
"mail_go/internal/db"
|
||
"mail_go/internal/store"
|
||
|
||
"github.com/emersion/go-imap"
|
||
"github.com/emersion/go-imap/client"
|
||
"golang.org/x/crypto/bcrypt"
|
||
"gorm.io/driver/sqlite"
|
||
"gorm.io/gorm"
|
||
)
|
||
|
||
// startIntegrationServer 启动一个真实的 IMAP 监听(随机端口)供客户端测试。
|
||
func startIntegrationServer(t *testing.T) (*store.Stores, string) {
|
||
t.Helper()
|
||
gdb, err := gorm.Open(sqlite.Open(filepath.Join(t.TempDir(), "test.db")), &gorm.Config{})
|
||
if err != nil {
|
||
t.Fatalf("open sqlite: %v", err)
|
||
}
|
||
if err := gdb.AutoMigrate(&db.User{}, &db.Domain{}, &db.Message{}, &db.ProtocolLog{}, &db.BanEntry{}); err != nil {
|
||
t.Fatalf("migrate: %v", err)
|
||
}
|
||
stores := store.NewStores(gdb)
|
||
|
||
domain := &db.Domain{Name: "example.com"}
|
||
if err := stores.Domains.Create(domain); err != nil {
|
||
t.Fatalf("create domain: %v", err)
|
||
}
|
||
hashed, _ := bcrypt.GenerateFromPassword([]byte("secret123"), bcrypt.DefaultCost)
|
||
user := &db.User{Username: "alice", DomainID: domain.ID, PasswordHash: string(hashed), IsActive: true}
|
||
if err := stores.Users.Create(user); err != nil {
|
||
t.Fatalf("create user: %v", err)
|
||
}
|
||
|
||
srv := NewIMAPServer(config.IMAPConfig{}, stores, nil, config.BanConfig{}, connhub.New())
|
||
ln, err := net.Listen("tcp", "127.0.0.1:0")
|
||
if err != nil {
|
||
t.Fatalf("listen: %v", err)
|
||
}
|
||
t.Cleanup(func() { ln.Close() })
|
||
|
||
imapSrv := srv.newServer(ln.Addr().String(), nil)
|
||
go imapSrv.Serve(ln)
|
||
|
||
return stores, ln.Addr().String()
|
||
}
|
||
|
||
// seedMailbox 创建 n 封按时间递增的邮件(id 与 date 顺序一致时 id ASC == date ASC)。
|
||
func seedMailbox(t *testing.T, stores *store.Stores, userID uint, n int) []uint {
|
||
t.Helper()
|
||
ids := make([]uint, 0, n)
|
||
base := time.Now().Add(-time.Duration(n) * time.Hour)
|
||
for i := 0; i < n; i++ {
|
||
msg := &db.Message{
|
||
UserID: userID,
|
||
Folder: "INBOX",
|
||
FromAddr: "x@y",
|
||
ToAddr: "alice@example.com",
|
||
Subject: "m",
|
||
Date: base.Add(time.Duration(i) * time.Hour), // 时间递增:id 越大日期越新
|
||
CreatedAt: time.Now(),
|
||
}
|
||
if err := stores.Mails.Create(msg); err != nil {
|
||
t.Fatalf("create message: %v", err)
|
||
}
|
||
ids = append(ids, msg.ID)
|
||
}
|
||
return ids
|
||
}
|
||
|
||
func loginAndSelect(t *testing.T, addr string) *client.Client {
|
||
t.Helper()
|
||
c, err := client.Dial(addr)
|
||
if err != nil {
|
||
t.Fatalf("dial: %v", err)
|
||
}
|
||
t.Cleanup(func() { c.Logout() })
|
||
if err := c.Login("alice@example.com", "secret123"); err != nil {
|
||
t.Fatalf("login: %v", err)
|
||
}
|
||
if _, err := c.Select("INBOX", false); err != nil {
|
||
t.Fatalf("select: %v", err)
|
||
}
|
||
return c
|
||
}
|
||
|
||
// uidOf returns the message id of the newest message by date.
|
||
func assertReadState(t *testing.T, stores *store.Stores, msgID uint, want bool) {
|
||
t.Helper()
|
||
msg, err := stores.Mails.GetByID(msgID)
|
||
if err != nil {
|
||
t.Fatalf("get msg: %v", err)
|
||
}
|
||
if msg.IsRead != want {
|
||
t.Fatalf("msg %d IsRead = %v, want %v", msgID, msg.IsRead, want)
|
||
}
|
||
}
|
||
|
||
// TestUidStorePersists 验证 UID STORE +FLAGS(\Seen) 持久化(RFC 标准流程)。
|
||
func TestUidStorePersists(t *testing.T) {
|
||
stores, addr := startIntegrationServer(t)
|
||
ids := seedMailbox(t, stores, 1, 3)
|
||
|
||
c := loginAndSelect(t, addr)
|
||
seqset := new(imap.SeqSet)
|
||
seqset.AddNum(uint32(ids[1])) // UID = 第二条消息
|
||
ch := make(chan *imap.Message, 1)
|
||
if err := c.UidStore(seqset, imap.AddFlags, []interface{}{imap.SeenFlag}, ch); err != nil {
|
||
t.Fatalf("uid store: %v", err)
|
||
}
|
||
<-ch
|
||
|
||
assertReadState(t, stores, ids[1], true)
|
||
assertReadState(t, stores, ids[0], false)
|
||
assertReadState(t, stores, ids[2], false)
|
||
}
|
||
|
||
// TestSeqStoreServerIssued 验证客户端用服务器下发的序号(FETCH 结果)做
|
||
// seq 式 STORE:任何排序下都应正确持久化。
|
||
func TestSeqStoreServerIssued(t *testing.T) {
|
||
stores, addr := startIntegrationServer(t)
|
||
ids := seedMailbox(t, stores, 1, 3)
|
||
|
||
c := loginAndSelect(t, addr)
|
||
|
||
// 拉取全部消息,找到 ids[2](最新一封)的服务器序号
|
||
seqsetAll := new(imap.SeqSet)
|
||
seqsetAll.AddRange(1, 3)
|
||
messages := make(chan *imap.Message, 3)
|
||
if err := c.Fetch(seqsetAll, []imap.FetchItem{imap.FetchFlags, imap.FetchUid}, messages); err != nil {
|
||
t.Fatalf("fetch: %v", err)
|
||
}
|
||
var targetSeq uint32
|
||
for m := range messages {
|
||
if m.Uid == uint32(ids[2]) {
|
||
targetSeq = m.SeqNum
|
||
}
|
||
}
|
||
if targetSeq == 0 {
|
||
t.Fatal("target message not found in fetch")
|
||
}
|
||
|
||
seqset := new(imap.SeqSet)
|
||
seqset.AddNum(targetSeq)
|
||
ch := make(chan *imap.Message, 1)
|
||
if err := c.Store(seqset, imap.AddFlags, []interface{}{imap.SeenFlag}, ch); err != nil {
|
||
t.Fatalf("store: %v", err)
|
||
}
|
||
<-ch
|
||
|
||
assertReadState(t, stores, ids[2], true)
|
||
}
|
||
|
||
// TestSeqStoreClientSelfNumbered 复现风险场景:客户端不信任服务器序号,
|
||
// 按自己的视图(日期倒序,最新在前)自行编号后发 seq 式 STORE。
|
||
// 服务器规范排序必须与常见客户端视图一致(date DESC, id DESC),
|
||
// 否则会把另一封邮件标为已读、目标邮件永远未读。
|
||
func TestSeqStoreClientSelfNumbered(t *testing.T) {
|
||
stores, addr := startIntegrationServer(t)
|
||
ids := seedMailbox(t, stores, 1, 3) // 3 封,日期递增,最新的是 ids[2]
|
||
|
||
c := loginAndSelect(t, addr)
|
||
|
||
// 客户端按日期倒序视图:最新一封 = seq 1
|
||
seqset := new(imap.SeqSet)
|
||
seqset.AddNum(1)
|
||
ch := make(chan *imap.Message, 1)
|
||
if err := c.Store(seqset, imap.AddFlags, []interface{}{imap.SeenFlag}, ch); err != nil {
|
||
t.Fatalf("store: %v", err)
|
||
}
|
||
<-ch
|
||
|
||
// 客户端意图是标记最新一封(ids[2])为已读
|
||
assertReadState(t, stores, ids[2], true)
|
||
}
|