fix a lot of nuisances reported by cppcheck (#4872)

* fix a lot of nuisances reported by cppcheck * fix portduino
2024-09-25 19:09:06 -05:00
parent 118809fbfc
commit 12481b568a
18 changed files with 33 additions and 35 deletions
@@ -167,12 +167,12 @@ bool CryptoEngine::setDHKey(uint32_t nodeNum)
 void CryptoEngine::hash(uint8_t *bytes, size_t numBytes)
 {
    SHA256 hash;
-    size_t posn, len;
+    size_t posn;
    uint8_t size = numBytes;
    uint8_t inc = 16;
    hash.reset();
    for (posn = 0; posn < size; posn += inc) {
-        len = size - posn;
+        size_t len = size - posn;
        if (len > inc)
            len = inc;
        hash.update(bytes + posn, len);