kevin/meshtastic_firmware
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

NimbleBluetooth: reuse BLE_HS_CONN_HANDLE_NONE instead of creating a different constant to represent no connection

Browse Source
This commit is contained in:
Mike Robbins
2025-10-19 11:10:14 -04:00
parent f6eede8597
commit 126954c2ed
1 changed files with 8 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/nimble/NimbleBluetooth.cpp
+8 -8
View File
@@ -49,7 +49,7 @@ NimBLECharacteristic *logRadioCharacteristic;
NimBLEServer *bleServer; NimBLEServer *bleServer;
static bool passkeyShowing; static bool passkeyShowing;
static std::atomic<int32_t> nimbleBluetoothConnHandle{-1}; // actual handles are uint16_t, so -1 means "no connection" static std::atomic<uint16_t> nimbleBluetoothConnHandle{BLE_HS_CONN_HANDLE_NONE}; // BLE_HS_CONN_HANDLE_NONE means "no connection"
class BluetoothPhoneAPI : public PhoneAPI, public concurrency::OSThread class BluetoothPhoneAPI : public PhoneAPI, public concurrency::OSThread
{ {
@@ -178,9 +178,9 @@ class BluetoothPhoneAPI : public PhoneAPI, public concurrency::OSThread
// Prefer high throughput during config/setup, at the cost of high power consumption (for a few seconds) // Prefer high throughput during config/setup, at the cost of high power consumption (for a few seconds)
if (bleServer && isConnected()) { if (bleServer && isConnected()) {
int32_t conn_handle = nimbleBluetoothConnHandle.load(); uint16_t conn_handle = nimbleBluetoothConnHandle.load();
if (conn_handle != -1) { if (conn_handle != BLE_HS_CONN_HANDLE_NONE) {
requestHighThroughputConnection(static_cast<uint16_t>(conn_handle)); requestHighThroughputConnection(conn_handle);
} }
} }
} }
@@ -191,9 +191,9 @@ class BluetoothPhoneAPI : public PhoneAPI, public concurrency::OSThread
// Switch to lower power consumption BLE connection params for steady-state use after config/setup is complete // Switch to lower power consumption BLE connection params for steady-state use after config/setup is complete
if (bleServer && isConnected()) { if (bleServer && isConnected()) {
int32_t conn_handle = nimbleBluetoothConnHandle.load(); uint16_t conn_handle = nimbleBluetoothConnHandle.load();
if (conn_handle != -1) { if (conn_handle != BLE_HS_CONN_HANDLE_NONE) {
requestLowerPowerConnection(static_cast<uint16_t>(conn_handle)); requestLowerPowerConnection(conn_handle);
} }
} }
} }
@@ -710,7 +710,7 @@ class NimbleBluetoothServerCallback : public NimBLEServerCallbacks
// Clear the last ToRadio packet buffer to avoid rejecting first packet from new connection // Clear the last ToRadio packet buffer to avoid rejecting first packet from new connection
memset(lastToRadio, 0, sizeof(lastToRadio)); memset(lastToRadio, 0, sizeof(lastToRadio));
nimbleBluetoothConnHandle = -1; // -1 means "no connection" nimbleBluetoothConnHandle = BLE_HS_CONN_HANDLE_NONE; // BLE_HS_CONN_HANDLE_NONE means "no connection"
#ifdef NIMBLE_TWO #ifdef NIMBLE_TWO
// Restart Advertising // Restart Advertising