fix: zero entire public key array instead of only first byte (#9619)
This commit is contained in:
+1
-1
@@ -1772,7 +1772,7 @@ void NodeDB::addFromContact(meshtastic_SharedContact contact)
|
|||||||
info->has_device_metrics = false;
|
info->has_device_metrics = false;
|
||||||
info->has_position = false;
|
info->has_position = false;
|
||||||
info->user.public_key.size = 0;
|
info->user.public_key.size = 0;
|
||||||
info->user.public_key.bytes[0] = 0;
|
memset(info->user.public_key.bytes, 0, sizeof(info->user.public_key.bytes));
|
||||||
} else {
|
} else {
|
||||||
/* Clients are sending add_contact before every text message DM (because clients may hold a larger node database with
|
/* Clients are sending add_contact before every text message DM (because clients may hold a larger node database with
|
||||||
* public keys than the radio holds). However, we don't want to update last_heard just because we sent someone a DM!
|
* public keys than the radio holds). However, we don't want to update last_heard just because we sent someone a DM!
|
||||||
|
|||||||
@@ -391,7 +391,7 @@ bool AdminModule::handleReceivedProtobuf(const meshtastic_MeshPacket &mp, meshta
|
|||||||
node->has_device_metrics = false;
|
node->has_device_metrics = false;
|
||||||
node->has_position = false;
|
node->has_position = false;
|
||||||
node->user.public_key.size = 0;
|
node->user.public_key.size = 0;
|
||||||
node->user.public_key.bytes[0] = 0;
|
memset(node->user.public_key.bytes, 0, sizeof(node->user.public_key.bytes));
|
||||||
saveChanges(SEGMENT_NODEDATABASE, false);
|
saveChanges(SEGMENT_NODEDATABASE, false);
|
||||||
}
|
}
|
||||||
break;
|
break;
|
||||||
|
|||||||
@@ -148,7 +148,7 @@ meshtastic_MeshPacket *NodeInfoModule::allocReply()
|
|||||||
|
|
||||||
// Strip the public key if the user is licensed
|
// Strip the public key if the user is licensed
|
||||||
if (u.is_licensed && u.public_key.size > 0) {
|
if (u.is_licensed && u.public_key.size > 0) {
|
||||||
u.public_key.bytes[0] = 0;
|
memset(u.public_key.bytes, 0, sizeof(u.public_key.bytes));
|
||||||
u.public_key.size = 0;
|
u.public_key.size = 0;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user