fix(Power): refactor EXT_CHRG_DETECT to compile-time macros (#10191)

Mirror the EXT_PWR_DETECT pattern: replace runtime static variables
(ext_chrg_detect_mode, ext_chrg_detect_value) with compile-time macros.
Auto-infer EXT_CHRG_DETECT_VALUE from EXT_CHRG_DETECT_MODE when the mode
is INPUT_PULLUP (→ LOW) or INPUT_PULLDOWN (→ HIGH); default to HIGH.

This fixes inverted polarity on variants that define EXT_CHRG_DETECT_MODE
INPUT_PULLUP without an explicit EXT_CHRG_DETECT_VALUE (e.g. russell):
previously the runtime default of HIGH caused isCharging() to return the
opposite of the correct value. With auto-inference the correct LOW active
level is now derived at compile time.

Remove the now-redundant EXT_CHRG_DETECT_VALUE HIGH from ELECROW-ThinkNode-M4
variant.h since HIGH is the inferred default.


Assisted-by: Claude Sonnet 4.6 <noreply@anthropic.com>

Signed-off-by: Andrew Yong <noreply@example.com>
Co-authored-by: Jonathan Bennett <jbennett@incomsystems.biz>

This commit is contained in:

Andrew Yong

2026-04-23 13:24:05 -05:00

committed by

GitHub

co-authored by

GitHub

Jonathan Bennett

parent 22d50fe437

commit 2ed7bba5e7

2 changed files with 13 additions and 13 deletions

									
										variants/nrf52840/ELECROW-ThinkNode-M4/variant.h
									
		-1
	
												View File
												
				@@ -85,7 +85,6 @@ static const uint8_t A0 = PIN_A0;

				// charger status

				#define EXT_CHRG_DETECT (32 + 6)

				#define EXT_CHRG_DETECT_VALUE HIGH

				// SPI

				#define SPI_INTERFACES_COUNT 1