From 6c61f12b101bc56516e8a5c4940fbd4d1e509a3f Mon Sep 17 00:00:00 2001 From: oscgonfer Date: Sun, 31 May 2026 20:00:02 +0200 Subject: [PATCH] Move address, bus and port to TelemetrySensor --- src/modules/Telemetry/Sensor/PMSA003ISensor.h | 3 --- src/modules/Telemetry/Sensor/SCD30Sensor.h | 3 --- src/modules/Telemetry/Sensor/SCD4XSensor.h | 3 --- src/modules/Telemetry/Sensor/SEN5XSensor.h | 3 --- src/modules/Telemetry/Sensor/SFA30Sensor.h | 3 --- src/modules/Telemetry/Sensor/TelemetrySensor.h | 5 +++++ 6 files changed, 5 insertions(+), 15 deletions(-) diff --git a/src/modules/Telemetry/Sensor/PMSA003ISensor.h b/src/modules/Telemetry/Sensor/PMSA003ISensor.h index ce7bba4bb..51af73087 100644 --- a/src/modules/Telemetry/Sensor/PMSA003ISensor.h +++ b/src/modules/Telemetry/Sensor/PMSA003ISensor.h @@ -34,10 +34,7 @@ class PMSA003ISensor : public TelemetrySensor uint32_t pmMeasureStarted = 0; uint8_t buffer[PMSA003I_FRAME_LENGTH]{}; - TwoWire *_bus{}; - uint8_t _address{}; #ifdef PMSA003I_I2C_CLOCK_SPEED - ScanI2C::I2CPort _port = ScanI2C::I2CPort::NO_I2C; ReClockI2C reClockI2C; #endif }; diff --git a/src/modules/Telemetry/Sensor/SCD30Sensor.h b/src/modules/Telemetry/Sensor/SCD30Sensor.h index 64ca73420..373d8e41c 100644 --- a/src/modules/Telemetry/Sensor/SCD30Sensor.h +++ b/src/modules/Telemetry/Sensor/SCD30Sensor.h @@ -13,10 +13,7 @@ class SCD30Sensor : public TelemetrySensor { private: SensirionI2cScd30 scd30; - TwoWire *_bus{}; - uint8_t _address{}; #ifdef SCD30_I2C_CLOCK_SPEED - ScanI2C::I2CPort _port = ScanI2C::I2CPort::NO_I2C; ReClockI2C reClockI2C; #endif diff --git a/src/modules/Telemetry/Sensor/SCD4XSensor.h b/src/modules/Telemetry/Sensor/SCD4XSensor.h index 03ff4abc2..50df60bd3 100644 --- a/src/modules/Telemetry/Sensor/SCD4XSensor.h +++ b/src/modules/Telemetry/Sensor/SCD4XSensor.h @@ -16,10 +16,7 @@ class SCD4XSensor : public TelemetrySensor { private: SensirionI2cScd4x scd4x; - TwoWire *_bus{}; - uint8_t _address{}; #ifdef SCD4X_I2C_CLOCK_SPEED - ScanI2C::I2CPort _port = ScanI2C::I2CPort::NO_I2C; ReClockI2C reClockI2C; #endif diff --git a/src/modules/Telemetry/Sensor/SEN5XSensor.h b/src/modules/Telemetry/Sensor/SEN5XSensor.h index a6608d30c..e63d5fc68 100644 --- a/src/modules/Telemetry/Sensor/SEN5XSensor.h +++ b/src/modules/Telemetry/Sensor/SEN5XSensor.h @@ -61,10 +61,7 @@ struct _SEN5XMeasurements { class SEN5XSensor : public TelemetrySensor { private: - TwoWire *_bus{}; - uint8_t _address{}; #ifdef SEN5X_I2C_CLOCK_SPEED - ScanI2C::I2CPort _port = ScanI2C::I2CPort::NO_I2C; ReClockI2C reClockI2C; #endif diff --git a/src/modules/Telemetry/Sensor/SFA30Sensor.h b/src/modules/Telemetry/Sensor/SFA30Sensor.h index 299a9fdf0..009138b90 100644 --- a/src/modules/Telemetry/Sensor/SFA30Sensor.h +++ b/src/modules/Telemetry/Sensor/SFA30Sensor.h @@ -20,10 +20,7 @@ class SFA30Sensor : public TelemetrySensor uint32_t measureStarted = 0; SensirionI2cSfa3x sfa30; - TwoWire *_bus{}; - uint8_t _address{}; #ifdef SFA30_I2C_CLOCK_SPEED - ScanI2C::I2CPort _port = ScanI2C::I2CPort::NO_I2C; ReClockI2C reClockI2C; #endif diff --git a/src/modules/Telemetry/Sensor/TelemetrySensor.h b/src/modules/Telemetry/Sensor/TelemetrySensor.h index 47deaa936..2c87c0e23 100644 --- a/src/modules/Telemetry/Sensor/TelemetrySensor.h +++ b/src/modules/Telemetry/Sensor/TelemetrySensor.h @@ -56,6 +56,11 @@ class TelemetrySensor } const char *sensorName; + // TODO: Rename? + uint8_t _address = 0; + TwoWire *_bus{}; + ScanI2C::I2CPort _port = ScanI2C::I2CPort::NO_I2C; + // TODO: delete after migration bool hasSensor() { return nodeTelemetrySensorsMap[sensorType].first > 0; }