I thought git would be smart enough to understand all the whitespace changes but even with all the flags I know to make it ignore theses it still blows up if there are identical changes on both sides.
I have a solution but it require creating a new commit at the merge base for each conflicting PR and merging it into develop.
I don't think blowing up all PRs is worth for now, maybe if we can coordinate this for V3 let's say.
This reverts commit 0d11331d18.
This commit is contained in:
@@ -212,8 +212,8 @@
|
||||
// -----------------------------------------------------------------------------
|
||||
|
||||
// If an SPI-related pin used by the LoRa module isn't defined, use the conventional pin number for it.
|
||||
// FIXME: these pins should really be defined in each variant.h file to prevent breakages if the defaults change,
|
||||
// currently many ESP32 variants don't define these pins in their variant.h file.
|
||||
// FIXME: these pins should really be defined in each variant.h file to prevent breakages if the defaults change, currently many
|
||||
// ESP32 variants don't define these pins in their variant.h file.
|
||||
#ifndef LORA_SCK
|
||||
#define LORA_SCK 5
|
||||
#endif
|
||||
|
||||
Reference in New Issue
Block a user