deepseek-harness

0 Fork 0

Files

T

Tianyi Cui 9e2833d15a fix review findings: drop the false "closing ACP connection" whenIdle() example

The whenIdle() JSDoc cited "a closing ACP connection" as a non-owner that
awaits whenIdle(). That is false against the code: ACP OWNS its agent handles
and tears them down via rec.dispose()/handle.dispose() (quiesce() at
packages/ui/acp/src/index.ts:666-686), never whenIdle(). The only whenIdle()
consumers are tests (acp dispose/turns/edges specs, agent specs) — which is
genuinely why the primitive stays (a test harness programs against the seam),
but the contract doc must not claim a production ACP path uses it.

Replace the parenthetical with truthful non-owning observers (a test awaiting a
turn to settle, a monitor) and state explicitly that an OWNER does not need
whenIdle() because AgentHandle.dispose() already awaits the loop-exit promise.

- packages/core/agent/src/types.ts: the Agent.whenIdle() contract JSDoc.
- docs/core-data-structures/core.md: the type-equiv mirror (re-copied verbatim).
- Regenerate the cordis catalog (whenIdle source line shifted).

2026-06-21 10:21:32 +08:00

bash.md

feat(types): brand bash ids + stop brand erosion; extract Branded to dsh-brand

2026-06-21 07:19:59 +08:00

core.md

fix review findings: drop the false "closing ACP connection" whenIdle() example

2026-06-21 10:21:32 +08:00

llm-streaming.md

simplify(llm): drop unconsumed adapter-change event and assembled call surfaces

2026-06-21 01:27:41 +08:00

persistence.md

fix review findings: stale seam docs + race-free doneFor test helper