Files
kevin d2b3caa81f fix(quota): 入站投递强制附件配额,删除路径清理附件并回退配额
安全审计 #19/#20(security_todo.md P1):

- 新增 store.PurgeMessages 共享清理入口:删附件文件、回退配额、
  删附件记录、删邮件记录,Web/IMAP/POP3 三条删除路径同源
- IMAP EXPUNGE(含 UID 分支)与 POP3 expungeDeleted 接入,修复
  协议删除只删记录导致的"幽灵配额"与附件文件泄漏
- Web purgeMessages 改为委托同一入口,消除三处重复实现
- SMTP 入站投递前按收件人原子预扣附件配额(TryReserveQuota),
  任一收件人超限整封拒收并返回 452 临时失败(避免 go-smtp 将
  普通 error 映射为 554 永久失败);Sent 副本尽力而为不回滚整封
- saveMessage 返回实际落库字节数,reconcileQuota 对账退还差额
  (覆盖收件人被删/落库失败/部分附件失败)
- NewIMAPServer/NewPOP3Server 注入 AttachmentStorage
- 新增 4 项单测(配额拒收/正常记账/对账回退/POP3 删除清理)
- security_todo.md 勾选 #19/#20,登记存量发现 #27(IncrementFail
  并发首建窗口丢失更新,待决策)
2026-08-28 13:59:50 +08:00

349 lines
11 KiB
Go

package smtp_server
import (
"bytes"
"errors"
"fmt"
"testing"
"time"
"mail_go/config"
"mail_go/internal/db"
"mail_go/internal/storage"
"mail_go/internal/store"
"github.com/emersion/go-sasl"
"github.com/emersion/go-smtp"
"gorm.io/driver/sqlite"
"gorm.io/gorm"
)
// testMultipartMessage builds an RFC 5322 message with one text part and one
// base64 attachment.
func testMultipartMessage() []byte {
const boundary = "X"
return []byte(fmt.Sprintf(
"From: sender@example.com\r\n"+
"To: rcpt@lmve.net\r\n"+
"Subject: with attachment\r\n"+
"MIME-Version: 1.0\r\n"+
"Content-Type: multipart/mixed; boundary=\"%s\"\r\n"+
"\r\n"+
"--%s\r\n"+
"Content-Type: text/plain; charset=utf-8\r\n"+
"\r\n"+
"hello body\r\n"+
"--%s\r\n"+
"Content-Type: text/plain; name=\"test.txt\"\r\n"+
"Content-Transfer-Encoding: base64\r\n"+
"Content-Disposition: attachment; filename=\"test.txt\"\r\n"+
"\r\n"+
"aGVsbG8gd29ybGQ=\r\n"+
"--%s--\r\n",
boundary, boundary, boundary, boundary))
}
func TestParseSMTPMessageExtractsAttachmentData(t *testing.T) {
parsed, err := parseSMTPMessage(testMultipartMessage())
if err != nil {
t.Fatalf("parseSMTPMessage: %v", err)
}
if parsed.textBody != "hello body" {
t.Fatalf("unexpected text body: %q", parsed.textBody)
}
if len(parsed.attachments) != 1 {
t.Fatalf("expected 1 attachment, got %d", len(parsed.attachments))
}
att := parsed.attachments[0]
if att.fileName != "test.txt" {
t.Fatalf("unexpected filename: %q", att.fileName)
}
if string(att.data) != "hello world" {
t.Fatalf("unexpected attachment data: %q", att.data)
}
}
func TestSaveMessagePersistsAttachments(t *testing.T) {
gdb, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{})
if err != nil {
t.Fatalf("open sqlite: %v", err)
}
if err := gdb.AutoMigrate(&db.User{}, &db.Domain{}, &db.Message{}, &db.Attachment{}, &db.BanEntry{}, &db.OutboundMessage{}, &db.ProtocolLog{}); err != nil {
t.Fatalf("migrate: %v", err)
}
stores := store.NewStores(gdb)
attStorage := storage.NewAttachmentStorage(t.TempDir())
srv := &SMTPServer{stores: stores, storage: attStorage}
sess := &smtpSession{backend: &smtpBackend{server: srv}}
data := testMultipartMessage()
parsed, err := parseSMTPMessage(data)
if err != nil {
t.Fatalf("parseSMTPMessage: %v", err)
}
user := &db.User{Username: "rcpt", PasswordHash: "x", DomainID: 0, IsActive: true}
if err := stores.Users.Create(user); err != nil {
t.Fatalf("create user: %v", err)
}
if _, _, err := sess.saveMessage(user.ID, "INBOX", parsed, data, false); err != nil {
t.Fatalf("saveMessage: %v", err)
}
msgs, err := stores.Mails.ListAllByUserAndFolder(user.ID, "INBOX")
if err != nil || len(msgs) != 1 {
t.Fatalf("expected 1 inbox message, got %d (err=%v)", len(msgs), err)
}
atts, err := stores.Attachments.ListByMessage(msgs[0].ID)
if err != nil {
t.Fatalf("ListByMessage: %v", err)
}
if len(atts) != 1 {
t.Fatalf("expected 1 attachment record, got %d", len(atts))
}
att := atts[0]
if att.FileName != "test.txt" || att.FileSize != int64(len("hello world")) {
t.Fatalf("unexpected attachment record: %+v", att)
}
// The file must exist on disk with the original content.
content, err := attStorage.Read(att.FilePath)
if err != nil {
t.Fatalf("read attachment from disk: %v", err)
}
if !bytes.Equal(content, []byte("hello world")) {
t.Fatalf("attachment content mismatch: %q", content)
}
}
// TestSessionLoggingRecordsAuthFailure 验证认证失败的会话在 Logout 时写入协议日志。
func TestSessionLoggingRecordsAuthFailure(t *testing.T) {
gdb, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{})
if err != nil {
t.Fatalf("open sqlite: %v", err)
}
if err := gdb.AutoMigrate(&db.User{}, &db.Domain{}, &db.Message{}, &db.Attachment{}, &db.BanEntry{}, &db.OutboundMessage{}, &db.ProtocolLog{}); err != nil {
t.Fatalf("migrate: %v", err)
}
stores := store.NewStores(gdb)
srv := &SMTPServer{stores: stores, banCfg: config.BanConfig{MaxFailAttempts: 5, BanDurationMin: 30}}
sess := &smtpSession{
backend: &smtpBackend{server: srv, mode: smtpModeSubmission},
clientIP: "203.0.113.7",
startedAt: time.Now(),
port: 587,
}
// 触发一次认证(用户名不存在 → 失败)
mech, err := sess.Auth(sasl.Plain)
if err != nil {
t.Fatalf("Auth: %v", err)
}
// SASL PLAIN 凭据格式: authzid\0authcid\0passwd
if _, _, err := mech.Next([]byte("\x00no-such-user\x00wrong-pass")); err == nil {
t.Fatal("expected auth failure for unknown user")
}
// 直接调用 Logout 模拟连接结束
if err := sess.Logout(); err != nil {
t.Fatalf("Logout: %v", err)
}
logs, total, err := stores.ProtocolLogs.List(1, 10, store.ProtocolLogFilter{})
if err != nil {
t.Fatalf("list: %v", err)
}
if total != 1 {
t.Fatalf("expected 1 log, got %d", total)
}
log := logs[0]
if log.Protocol != db.ProtocolSMTP || log.Port != 587 || log.ClientIP != "203.0.113.7" {
t.Fatalf("unexpected log: %+v", log)
}
if log.Success {
t.Fatalf("expected failure, got %+v", log)
}
if log.FailReason == "" {
t.Fatal("expected fail reason")
}
if log.Username != "no-such-user" {
t.Fatalf("username = %q", log.Username)
}
}
// TestSessionLoggingRecordsDelivery 验证投递成功的会话写入成功日志。
func TestSessionLoggingRecordsDelivery(t *testing.T) {
gdb, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{})
if err != nil {
t.Fatalf("open sqlite: %v", err)
}
if err := gdb.AutoMigrate(&db.User{}, &db.Domain{}, &db.Message{}, &db.Attachment{}, &db.BanEntry{}, &db.OutboundMessage{}, &db.ProtocolLog{}); err != nil {
t.Fatalf("migrate: %v", err)
}
stores := store.NewStores(gdb)
attStorage := storage.NewAttachmentStorage(t.TempDir())
srv := &SMTPServer{stores: stores, storage: attStorage}
sess := &smtpSession{
backend: &smtpBackend{server: srv, mode: smtpModeInbound},
clientIP: "203.0.113.8",
startedAt: time.Now(),
port: 25,
rcpts: make([]string, 0),
}
if err := sess.Mail("sender@example.com", nil); err != nil {
t.Fatalf("Mail: %v", err)
}
if err := sess.Logout(); err != nil {
t.Fatalf("Logout: %v", err)
}
logs, total, err := stores.ProtocolLogs.List(1, 10, store.ProtocolLogFilter{})
if err != nil {
t.Fatalf("list: %v", err)
}
if total != 1 {
t.Fatalf("expected 1 log, got %d", total)
}
if !logs[0].Success {
t.Fatalf("expected success, got %+v", logs[0])
}
}
// newQuotaTestSession 构造带真实存储的入站会话(配额逻辑不触碰连接,
// 直接构造会话即可单测)。
func newQuotaTestSession(t *testing.T, quotaBytes, usedBytes int64) (*smtpSession, *store.Stores, *storage.AttachmentStorage, *db.User) {
t.Helper()
gdb, err := gorm.Open(sqlite.Open(":memory:"), &gorm.Config{})
if err != nil {
t.Fatalf("open sqlite: %v", err)
}
if err := gdb.AutoMigrate(&db.User{}, &db.Domain{}, &db.Message{}, &db.Attachment{}, &db.BanEntry{}, &db.OutboundMessage{}, &db.ProtocolLog{}); err != nil {
t.Fatalf("migrate: %v", err)
}
stores := store.NewStores(gdb)
attStorage := storage.NewAttachmentStorage(t.TempDir())
srv := &SMTPServer{stores: stores, storage: attStorage}
sess := &smtpSession{
backend: &smtpBackend{server: srv, mode: smtpModeInbound},
clientIP: "203.0.113.10",
startedAt: time.Now(),
port: 25,
rcpts: make([]string, 0),
}
domain := &db.Domain{Name: "example.com"}
if err := stores.Domains.Create(domain); err != nil {
t.Fatalf("create domain: %v", err)
}
user := &db.User{Username: "alice", PasswordHash: "x", DomainID: domain.ID, IsActive: true, QuotaBytes: quotaBytes, UsedBytes: usedBytes}
if err := stores.Users.Create(user); err != nil {
t.Fatalf("create user: %v", err)
}
if err := sess.Rcpt("alice@example.com", nil); err != nil {
t.Fatalf("Rcpt: %v", err)
}
return sess, stores, attStorage, user
}
// TestInboundQuotaRejectsOverQuotaRecipient 验证收件人配额不足时整封以
// 452 临时失败拒收,不落库、不改配额(已预扣份额全部回退)。
func TestInboundQuotaRejectsOverQuotaRecipient(t *testing.T) {
sess, stores, _, user := newQuotaTestSession(t, 5, 5)
parsed, err := parseSMTPMessage(testMultipartMessage())
if err != nil {
t.Fatalf("parseSMTPMessage: %v", err)
}
_, _, qerr := sess.reserveLocalQuota(attachmentSize(parsed))
if qerr == nil {
t.Fatal("expected 452 for over-quota recipient")
}
var smtpErr *smtp.SMTPError
if !errors.As(qerr, &smtpErr) || smtpErr.Code != 452 {
t.Fatalf("expected 452 SMTPError, got %v", qerr)
}
if count, _ := stores.Mails.CountAll(); count != 0 {
t.Fatalf("expected 0 messages after rejection, got %d", count)
}
u, err := stores.Users.GetByID(user.ID)
if err != nil {
t.Fatalf("GetByID: %v", err)
}
if u.UsedBytes != 5 {
t.Fatalf("used_bytes = %d, want 5 (unchanged)", u.UsedBytes)
}
}
// TestInboundQuotaDeliversWithinQuota 验证配额充足时正常投递:预扣量与
// 实际落库量一致,对账不产生退还,附件文件与记录就位。
func TestInboundQuotaDeliversWithinQuota(t *testing.T) {
sess, stores, attStorage, user := newQuotaTestSession(t, 1<<20, 0)
parsed, err := parseSMTPMessage(testMultipartMessage())
if err != nil {
t.Fatalf("parseSMTPMessage: %v", err)
}
attTotal := attachmentSize(parsed) // "hello world" = 11 字节
rcptUser, charged, qerr := sess.reserveLocalQuota(attTotal)
if qerr != nil {
t.Fatalf("reserveLocalQuota: %v", qerr)
}
if rcptUser["alice@example.com"] != user.ID || charged[user.ID] != attTotal {
t.Fatalf("unexpected reservation: rcptUser=%v charged=%v", rcptUser, charged)
}
msg, stored, err := sess.saveMessage(user.ID, "INBOX", parsed, testMultipartMessage(), false)
if err != nil {
t.Fatalf("saveMessage: %v", err)
}
if stored != attTotal {
t.Fatalf("stored = %d, want %d", stored, attTotal)
}
sess.reconcileQuota(charged, map[uint]int64{user.ID: stored})
atts, err := stores.Attachments.ListByMessage(msg.ID)
if err != nil || len(atts) != 1 {
t.Fatalf("expected 1 attachment, got %d (err=%v)", len(atts), err)
}
if content, err := attStorage.Read(atts[0].FilePath); err != nil || !bytes.Equal(content, []byte("hello world")) {
t.Fatalf("attachment file missing or wrong content (err=%v)", err)
}
u, err := stores.Users.GetByID(user.ID)
if err != nil {
t.Fatalf("GetByID: %v", err)
}
if u.UsedBytes != attTotal {
t.Fatalf("used_bytes = %d, want %d", u.UsedBytes, attTotal)
}
}
// TestInboundQuotaReconcilesRefund 验证附件未落库(投递失败等)时,对账
// 把预扣量完全回退,配额不泄漏。
func TestInboundQuotaReconcilesRefund(t *testing.T) {
sess, stores, _, user := newQuotaTestSession(t, 1<<20, 0)
parsed, err := parseSMTPMessage(testMultipartMessage())
if err != nil {
t.Fatalf("parseSMTPMessage: %v", err)
}
_, charged, qerr := sess.reserveLocalQuota(attachmentSize(parsed))
if qerr != nil {
t.Fatalf("reserveLocalQuota: %v", qerr)
}
// 模拟投递失败:stored 为空 → 对账全额回退
sess.reconcileQuota(charged, map[uint]int64{})
u, err := stores.Users.GetByID(user.ID)
if err != nil {
t.Fatalf("GetByID: %v", err)
}
if u.UsedBytes != 0 {
t.Fatalf("used_bytes = %d, want 0 after refund", u.UsedBytes)
}
}