Short circuit invalid nodenum check in ham mode.

Until signing is implemented, this will prevent the nodenum from being regenerated upon each reboot.

.claude/settings.json

@@ -6,9 +6,8 @@
         "hooks": [
           {
             "type": "command",
-            "command": "f=$(tr -d '\\n' | grep -o '\"file_path\"[[:space:]]*:[[:space:]]*\"[^\"]*\"' | head -1 | sed 's/.*:[[:space:]]*\"//; s/\"$//'); [ -n \"$f\" ] && [ -f \"$f\" ] || exit 0; t=$(command -v trunk || echo \"$HOME/.cache/trunk/launcher/trunk\"); [ -x \"$t\" ] || { echo \"trunk-fmt hook: trunk not found; its launcher needs curl or wget to bootstrap the CLI (see 'Formatting & the trunk toolchain' in .github/copilot-instructions.md)\" >&2; exit 1; }; out=$(\"$t\" fmt --force \"$f\" 2>&1) || { echo \"trunk-fmt hook: trunk fmt failed on $f: $out\" >&2; exit 1; }",
-            "timeout": 120,
-            "statusMessage": "Formatting (trunk)..."
+            "command": "python3 -c \"import json,sys,subprocess,shutil,os; f=json.load(sys.stdin).get('tool_input',{}).get('file_path',''); t=shutil.which('trunk') or os.path.expanduser('~/.cache/trunk/launcher/trunk'); f and os.path.exists(t) and subprocess.run([t,'fmt','--force',f],stderr=subprocess.DEVNULL)\" 2>/dev/null || true",
+            "statusMessage": "Formatting..."
           }
         ]
       }

.github/copilot-instructions.md

@@ -191,24 +191,7 @@ Writers go through `setNodeStatus`, `updatePosition`, `updateTelemetry` (which d
 
 ### Eviction
 
-Every code path that drops a node from the header table must also evict the satellites. The single chokepoint is `eraseNodeSatellites(NodeNum)`; it's already called from `getOrCreateMeshNode`'s oldest-boring eviction, `demoteOldestHotNodesToWarm` (the over-cap warm-tier migration), `removeNodeByNum`, both branches of `resetNodes`, `cleanupMeshDB`, `addFromContact`'s ignored-branch, and `AdminModule`'s `set_ignored_node`. Add new eviction sites here, not by calling `.erase()` directly. (Note: `enforceSatelliteCaps`/`evictSatelliteOverCap` call `.erase()` directly on purpose — that's a satellite-only cap trim where the node _stays_ in the header, a different operation from this chokepoint.)
-
-### Warm tier (long-tail identity)
-
-On every arch except STM32WL and bare nRF52832 (`WARM_NODE_COUNT > 0`), a node evicted from the header table is not forgotten outright: `WarmNodeStore` (`src/mesh/WarmNodeStore.{h,cpp}`) keeps a 40 B `{num, last_heard, public_key}` record per evicted node — primarily so PKI DMs to/from a long-tail node keep decrypting without re-running a NodeInfo exchange (the rest of `NodeInfoLite` rebuilds from traffic in seconds).
-
-- **Write:** `getOrCreateMeshNode`'s eviction and `demoteOldestHotNodesToWarm` (the over-cap boot migration) call `warmStore.absorb(num, last_heard, key)` _before_ the node leaves the header.
-- **Read-back:** `getOrCreateMeshNode` calls `warmStore.take()` to rehydrate `last_heard` + key when a warm node is re-admitted; `copyPublicKey()` falls back to the warm tier so the PKI send path finds keys for evicted peers.
-- **Persistence:** nRF52840 uses a 12 KB raw-flash record-ring at `0xEA000` (below LittleFS; append + replay + compact-on-rotate, link-guarded by `nrf52840_s140_v7.ld` and `extra_scripts/nrf52_warm_region.py`). Everywhere else: a `/prefs/warm.dat` snapshot flushed by `saveIfDirty()` on the node-DB save cadence.
-- **Tunables** (`mesh-pb-constants.h`): `WARM_NODE_COUNT` (per-arch; `0` disables the tier) and `MAX_NUM_NODES` (hot cap — 120 on nRF52840/generic ESP32 to fit the 28 KB LittleFS; ESP32-S3 keeps its flash-scaled 100/200/250, portduino 250). Verbose migration/self-care tracing routes through `LOG_MIGRATION`, gated by `MESHTASTIC_NODEDB_MIGRATION_VERBOSE`.
-
-### Satellite caps
-
-Only the freshest `MAX_SATELLITE_NODES` nodes keep satellite payloads; the rest of the header table carries just the `NodeInfoLite`. The cap is **per-platform**: 40 on RAM-constrained parts (nRF52840, generic ESP32) since the four maps live in internal SRAM (not PSRAM, ~408 B/node across the four), and 250 on flash-rich hosts (ESP32-S3, portduino) so every hot node can carry rich data as before the cap existed. `enforceSatelliteCaps()` trims each map to the cap on load (returns whether it trimmed); `evictSatelliteOverCap()` trims before each insert. Eviction is by the owning node's hot `last_heard` (stalest first, demoted/absent nodes rank as `last_heard==0`); self is never trimmed.
-
-### On-boot self-care
-
-`NodeDB::nodeDBSelfCare()` runs once identity is established (the constructor after key (re)gen, and `reloadFromDisk()` — _not_ inside `loadFromDisk`, where `getNodeNum()` is still 0). It confirms self is present (warns if a non-empty DB is missing us — a foreign/over-cap file), pins self to index 0, demotes/trims only **non-self** overflow into the warm tier, then rewrites `nodes.proto` **once** and only if it healed something — and never while encrypted storage is locked (it would persist placeholder defaults). `loadFromDisk` deliberately leaves the loaded store untrimmed for this pass.
+Every code path that drops a node from the header table must also evict the satellites. The single chokepoint is `eraseNodeSatellites(NodeNum)`; it's already called from `getOrCreateMeshNode`'s oldest-boring eviction, `removeNodeByNum`, both branches of `resetNodes`, `cleanupMeshDB`, `addFromContact`'s ignored-branch, and `AdminModule`'s `set_ignored_node`. Add new eviction sites here, not by calling `.erase()` directly.
 
 ### Sync flow: thin NodeInfo + post-COMPLETE_ID replay (no opt-in)
 
@@ -300,15 +283,6 @@ firmware/
 
 ## Coding Conventions
 
-### Formatting & the trunk toolchain
-
-`trunk fmt` is the project formatter (`trunk_check` CI rejects unformatted code). For Claude Code users, `.claude/settings.json` ships a PostToolUse hook that runs `trunk fmt --force` on every file the agent writes or edits. The hook is pure sh/grep/sed — no python or jq required — but trunk itself must be able to run:
-
-- Trunk's launcher (`~/.cache/trunk/launcher/trunk`, or `trunk` on PATH) downloads the CLI version pinned in `.trunk/trunk.yaml` on first use and again whenever that pin is bumped. **The launcher needs `curl` or `wget`**; without one it fails with "Cannot download… please install curl or wget", and the hook surfaces that as a warning on every write.
-- No curl/wget available (e.g. a minimal WSL image)? Bootstrap by hand with any Python (PlatformIO bundles one at `~/.platformio/penv/bin/python`): download `https://trunk.io/releases/<ver>/trunk-<ver>-linux-x86_64.tar.gz` and place the `trunk` binary at `~/.cache/trunk/cli/<ver>-linux-x86_64/trunk` (chmod +x), where `<ver>` is the `cli.version` from `.trunk/trunk.yaml`.
-- The hook fails loudly by design (visible warning, non-blocking). Silent no-op formatting hooks hide real breakage — don't re-add `2>/dev/null || true` around the whole thing.
-- More generally: don't assume a stock Linux userland in hooks or helper scripts — minimal WSL/container images may lack `python3`, `curl`, `wget`, and `jq`. Prefer plain sh + coreutils, or PlatformIO's bundled Python for anything heavier.
-
 ### General Style
 
 - Follow existing code style - run `trunk fmt` before commits

.github/workflows/flasher-link-comment.yml

@@ -1,187 +0,0 @@
-name: Post Web Flasher Link Comment
-
-on:
-  workflow_run:
-    workflows: [CI]
-    types: [completed]
-
-permissions:
-  pull-requests: write
-  actions: read
-
-jobs:
-  post-flasher-link:
-    if: >
-      github.event.workflow_run.event == 'pull_request' &&
-      github.event.workflow_run.conclusion != 'cancelled' &&
-      github.repository == 'meshtastic/firmware'
-    continue-on-error: true
-    runs-on: ubuntu-latest
-    steps:
-      # Per-board manifests carry the firmware's own metadata (activelySupported,
-      # displayName, ...) generated from each target's custom_meshtastic_* config.
-      - name: Download board manifests
-        uses: actions/download-artifact@v8
-        continue-on-error: true
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          run-id: ${{ github.event.workflow_run.id }}
-          pattern: manifest-*
-          path: ./manifests
-          merge-multiple: true
-
-      - name: Post or update web flasher link comment
-        uses: actions/github-script@v8
-        with:
-          script: |
-            const marker = '<!-- web-flasher-link -->';
-            const run = context.payload.workflow_run;
-            const { owner, repo } = context.repo;
-
-            // Resolve the PR by matching the run's head SHA against the repo's open
-            // PRs. workflow_run.pull_requests is empty for fork PRs, and
-            // listPullRequestsAssociatedWithCommit won't return an open fork PR by
-            // its head commit — but pulls.list includes fork PRs. Matching on head
-            // SHA also enforces that the run is for the PR's current commit, so stale
-            // re-runs of an outdated commit won't match.
-            const openPrs = await github.paginate(github.rest.pulls.list, {
-              owner, repo, state: 'open', per_page: 100,
-            });
-            const pr = openPrs.find((p) => p.head.sha === run.head_sha);
-            if (!pr) {
-              core.info(`No open pull request matches commit ${run.head_sha}; skipping.`);
-              return;
-            }
-            const prNumber = pr.number;
-
-            // Restrict to trusted authors. NOTE: author_association is computed for
-            // the GITHUB_TOKEN, which cannot see *private/concealed* org memberships —
-            // those members come back as CONTRIBUTOR, not MEMBER. So gating on MEMBER
-            // alone silently excludes most maintainers. We allow the trusted set the
-            // token can actually identify (members, collaborators, and anyone with a
-            // previously merged PR). For strict members-only you'd need an org-read
-            // App/PAT token to call orgs.checkMembershipForUser.
-            const allowedAssociations = ['OWNER', 'MEMBER', 'COLLABORATOR', 'CONTRIBUTOR'];
-            if (!allowedAssociations.includes(pr.author_association)) {
-              core.info(`Author association ${pr.author_association} is not trusted; skipping.`);
-              return;
-            }
-
-            // Require at least one per-arch firmware artifact from gather-artifacts
-            const artifacts = await github.paginate(github.rest.actions.listWorkflowRunArtifacts, {
-              owner, repo, run_id: run.id, per_page: 100,
-            });
-            const archRe = /^firmware-(esp32|esp32s3|esp32c3|esp32c6|nrf52840|rp2040|rp2350|stm32)-(\d+\.\d+\.\d+\.[0-9a-f]+)$/;
-            const archArtifacts = artifacts.filter((a) => archRe.test(a.name) && !a.expired);
-            if (archArtifacts.length === 0) {
-              core.info('No per-arch firmware artifacts found; skipping.');
-              return;
-            }
-
-            const version = archRe.exec(archArtifacts[0].name)[2];
-            const expiresAt = archArtifacts[0].expires_at
-              ? new Date(archArtifacts[0].expires_at).toISOString().slice(0, 10)
-              : null;
-
-            // Read each built board's manifest (.mt.json). activelySupported,
-            // displayName and architecture come straight from the board's
-            // custom_meshtastic_* platformio config, so the list is in sync with
-            // the firmware itself — no external device database needed.
-            const fs = require('fs');
-            let boards = [];
-            try {
-              boards = fs.readdirSync('./manifests')
-                .filter((f) => f.endsWith('.mt.json'))
-                .map((f) => {
-                  try { return JSON.parse(fs.readFileSync(`./manifests/${f}`, 'utf8')); }
-                  catch { return null; }
-                })
-                .filter((m) => m && m.activelySupported === true && m.platformioTarget)
-                .map((m) => ({
-                  board: m.platformioTarget,
-                  platform: m.architecture || '',
-                  // displayName is maintainer-authored text; escape table-breaking pipes
-                  displayName: String(m.displayName || m.platformioTarget).replace(/\|/g, '\\|'),
-                  image: Array.isArray(m.images) && m.images[0] ? String(m.images[0]) : '',
-                }))
-                .sort((a, b) => a.board.localeCompare(b.board));
-            } catch (e) {
-              core.warning(`Could not read board manifests: ${e.message}`);
-            }
-
-            const flasherUrl = `https://flasher.meshtastic.org/?pr=${prNumber}`;
-            // Device illustrations are served by the flasher from the same image
-            // names the manifest declares (custom_meshtastic_images). The flasher
-            // serves its SPA shell (HTML, 200) for unknown paths, so confirm each
-            // image really resolves to an image before linking it.
-            const imageBase = 'https://flasher.meshtastic.org/img/devices/';
-            await Promise.all(boards.map(async (b) => {
-              if (!b.image) return;
-              try {
-                const res = await fetch(`${imageBase}${encodeURIComponent(b.image)}`);
-                const type = res.headers.get('content-type') || '';
-                if (!res.ok || !type.startsWith('image/')) b.image = '';
-              } catch { b.image = ''; }
-            }));
-
-            const boardLines = boards
-              .map((b) => {
-                const img = b.image ? `<img src="${imageBase}${encodeURIComponent(b.image)}" alt="" height="34">` : '';
-                return `| ${img} | ${b.displayName} | [\`${b.board}\`](${flasherUrl}&device=${encodeURIComponent(b.board)}) | ${b.platform} |`;
-              })
-              .join('\n');
-
-            // Shields.io badges. Only non-user-controlled, charset-constrained values
-            // (version, commit sha, counts, dates) go into badge URLs — never board
-            // names or the PR title — so the rendered comment cannot be spoofed.
-            const shieldText = (s) =>
-              encodeURIComponent(String(s).replace(/-/g, '--').replace(/_/g, '__').replace(/ /g, '_'));
-            const shield = (label, message, color) =>
-              `https://img.shields.io/badge/${shieldText(label)}-${shieldText(message)}-${color}`;
-            const buttonUrl =
-              `https://img.shields.io/badge/${shieldText('Flash this PR in the Web Flasher')}-2C2D3C?style=for-the-badge`;
-            const badges = [
-              `![firmware](${shield('firmware', version, '67EA94')})`,
-              `![commit](${shield('commit', run.head_sha.slice(0, 7), '2C2D3C')})`,
-              `![boards](${shield('boards', boards.length, '5C6BC0')})`,
-            ];
-            if (expiresAt) badges.push(`![expires](${shield('expires', expiresAt, '9A4E00')})`);
-
-            // Only render the board table when there are supported boards to list
-            const boardTable = boards.length > 0 ? [
-              `<details><summary>Supported boards built by this PR (${boards.length})</summary>`,
-              '',
-              '| | Device | Board | Platform |',
-              '| --- | --- | --- | --- |',
-              boardLines,
-              '',
-              '</details>',
-              '',
-            ] : [];
-
-            const body = [
-              marker,
-              '## ⚡ Try this PR in the Web Flasher',
-              '',
-              `[![Flash this PR in the Web Flasher](${buttonUrl})](${flasherUrl})`,
-              '',
-              badges.join(' '),
-              '',
-              '> [!WARNING]',
-              '> This is an automated, unreviewed CI test build. Back up your device configuration',
-              '> before flashing, and only flash devices you are able to recover.',
-              '',
-              ...boardTable,
-              `*Build artifacts expire${expiresAt ? ` on ${expiresAt}` : ' after 30 days'}. Updated for \`${run.head_sha.slice(0, 7)}\`.*`,
-            ].join('\n');
-
-            // Sticky comment: update in place when the marker is found
-            const comments = await github.paginate(github.rest.issues.listComments, {
-              owner, repo, issue_number: prNumber, per_page: 100,
-            });
-            const existing = comments.find((c) => c.body?.includes(marker));
-            if (existing) {
-              await github.rest.issues.updateComment({ owner, repo, comment_id: existing.id, body });
-            } else {
-              await github.rest.issues.createComment({ owner, repo, issue_number: prNumber, body });
-            }

.github/workflows/flasher-link-placeholder.yml

@@ -1,62 +0,0 @@
-name: Post Web Flasher Build Placeholder
-
-# Drops an immediate "build in progress" comment when a PR opens, so the web
-# flasher entry shows up right away. The real CI-driven workflow
-# (flasher-link-comment.yml) later replaces it in place via the shared marker.
-#
-# SECURITY: this uses pull_request_target (write token, runs for fork PRs) but is
-# safe because it never checks out or runs PR code and posts a fully static body
-# — no PR title, branch name, or other untrusted input is used anywhere.
-
-on:
-  pull_request_target:
-    types: [opened, reopened]
-
-permissions:
-  pull-requests: write
-
-jobs:
-  post-placeholder:
-    if: github.repository == 'meshtastic/firmware'
-    continue-on-error: true
-    runs-on: ubuntu-latest
-    steps:
-      - name: Post web flasher build-in-progress placeholder
-        uses: actions/github-script@v8
-        with:
-          script: |
-            const marker = '<!-- web-flasher-link -->';
-            const { owner, repo } = context.repo;
-            const pr = context.payload.pull_request;
-
-            // Trusted authors only (matches the real workflow). author_association
-            // can't reflect private org membership for the token, so concealed
-            // members appear as CONTRIBUTOR — include it, or maintainers are excluded.
-            const allowedAssociations = ['OWNER', 'MEMBER', 'COLLABORATOR', 'CONTRIBUTOR'];
-            if (!allowedAssociations.includes(pr.author_association)) {
-              core.info(`Author association ${pr.author_association} is not trusted; skipping.`);
-              return;
-            }
-
-            // Only seed a placeholder when no flasher comment exists yet — never
-            // overwrite a real (or existing placeholder) comment.
-            const comments = await github.paginate(github.rest.issues.listComments, {
-              owner, repo, issue_number: pr.number, per_page: 100,
-            });
-            if (comments.some((c) => c.body?.includes(marker))) {
-              core.info('Flasher comment already exists; nothing to do.');
-              return;
-            }
-
-            const body = [
-              marker,
-              '## ⚡ Try this PR in the Web Flasher',
-              '',
-              '> [!NOTE]',
-              '> Building this pull request… the flash button, badges and supported-board',
-              '> list will appear here automatically once CI finishes.',
-            ].join('\n');
-
-            await github.rest.issues.createComment({
-              owner, repo, issue_number: pr.number, body,
-            });

.github/workflows/main_matrix.yml

@@ -82,9 +82,8 @@ jobs:
       fail-fast: false
       matrix:
         check: ${{ fromJson(needs.setup.outputs.check) }}
-    # Runs on GitHub-hosted runners so checks don't compete with builds for the
-    # self-hosted 'arctastic' pool (which builds use).
-    runs-on: ubuntu-latest
+    # Use 'arctastic' self-hosted runner pool when checking in the main repo
+    runs-on: ${{ github.repository_owner == 'meshtastic' && 'arctastic' || 'ubuntu-latest' }}
     if: ${{ github.event_name != 'workflow_dispatch' && github.repository == 'meshtastic/firmware' }}
     steps:
       - uses: actions/checkout@v6
@@ -287,11 +286,11 @@ jobs:
             --limit 1 --json databaseId --jq '.[0].databaseId // empty')
           if [ -n "$RUN_ID" ]; then
             ARTIFACT_NAME=$(gh api "repos/${{ github.repository }}/actions/runs/${RUN_ID}/artifacts" \
-              --jq '.artifacts[] | select(.name | startswith("firmware-sizes-")) | select(.expired == false) | .name' | head -1)
+              --jq '.artifacts[] | select(.name | startswith("firmware-sizes-")) | .name' | head -1)
             if [ -n "$ARTIFACT_NAME" ]; then
               gh run download "$RUN_ID" -R "${{ github.repository }}" \
                 --name "$ARTIFACT_NAME" --dir ./baseline-develop/
-              cp "./baseline-develop/current-sizes.json" ./develop-sizes.json
+              cp "./baseline-develop/${ARTIFACT_NAME}/current-sizes.json" ./develop-sizes.json
               echo "found=true" >> "$GITHUB_OUTPUT"
             else
               echo "found=false" >> "$GITHUB_OUTPUT"
@@ -312,11 +311,11 @@ jobs:
             --limit 1 --json databaseId --jq '.[0].databaseId // empty')
           if [ -n "$RUN_ID" ]; then
             ARTIFACT_NAME=$(gh api "repos/${{ github.repository }}/actions/runs/${RUN_ID}/artifacts" \
-              --jq '.artifacts[] | select(.name | startswith("firmware-sizes-")) | select(.expired == false) | .name' | head -1)
+              --jq '.artifacts[] | select(.name | startswith("firmware-sizes-")) | .name' | head -1)
             if [ -n "$ARTIFACT_NAME" ]; then
               gh run download "$RUN_ID" -R "${{ github.repository }}" \
                 --name "$ARTIFACT_NAME" --dir ./baseline-master/
-              cp "./baseline-master/current-sizes.json" ./master-sizes.json
+              cp "./baseline-master/${ARTIFACT_NAME}/current-sizes.json" ./master-sizes.json
               echo "found=true" >> "$GITHUB_OUTPUT"
             else
               echo "found=false" >> "$GITHUB_OUTPUT"

.github/workflows/test_native.yml

@@ -37,33 +37,13 @@ jobs:
           sed -i -e "s#${PWD}#.#" coverage_base.info # Make paths relative.
 
       - name: Integration test
-        # Cap the whole step: if the simulator ever fails to exit (e.g. the
-        # exit_simulator admin path regresses again) the job must fail fast,
-        # not run to GitHub's 6-hour limit.
-        timeout-minutes: 5
         run: |
           .pio/build/coverage/meshtasticd -s &
           PID=$!
-          trap 'kill "$PID" 2>/dev/null || true' EXIT
           timeout 20 bash -c "until ls -al /proc/$PID/fd | grep socket; do sleep 1; done"
           echo "Simulator started, launching python test..."
           python3 -c 'from meshtastic.test import testSimulator; testSimulator()'
-          # The Python harness sends exit_simulator and exits; the simulator is
-          # expected to terminate on its own. Give it a moment, then verify.
-          # If it is still alive the exit handshake is broken — fail loudly and
-          # do NOT fall through to `wait`, which would otherwise block until the
-          # job's hard timeout.
-          for i in $(seq 1 10); do
-            kill -0 "$PID" 2>/dev/null || break
-            sleep 1
-          done
-          if kill -0 "$PID" 2>/dev/null; then
-            echo "::error title=Simulator did not exit::meshtasticd ignored exit_simulator and is still running after the integration test. The exit_simulator admin path is broken (see AdminModule::handleReceivedProtobuf, ARCH_PORTDUINO bypass). Killing it to avoid a 6-hour CI overrun."
-            kill -9 "$PID" 2>/dev/null || true
-            wait "$PID" 2>/dev/null || true
-            exit 1
-          fi
-          wait "$PID" 2>/dev/null || true
+          wait
 
       - name: Capture coverage information
         if: always() # run this step even if previous step failed
@@ -161,14 +141,6 @@ jobs:
           name: platformio-test-report-${{ steps.version.outputs.long }}
           merge-multiple: true
 
-      - name: Drop no-status testsuites from the report
-        # PlatformIO emits a self-closing <testsuite tests="0"/> row for every test_* dir
-        # crossed with every hardware variant it cannot run on the native host (~4900 rows).
-        # They carry no pass/fail/skip status and bury the suites that actually ran. Strip
-        # them so the Test Report lists only suites with a real status. Only the copy the
-        # reporter renders is trimmed; the uploaded artifact keeps the full XML.
-        run: sed -i -E 's#<testsuite [^>]*tests="0"[^>]*/>##g' testreport.xml
-
       - name: Test Report
         uses: dorny/test-reporter@v3.0.0
         with:

.vscode/settings.json

@@ -10,6 +10,5 @@
   },
   "[powershell]": {
     "editor.defaultFormatter": "ms-vscode.powershell"
-  },
-  "idf.currentSetup": "C:/Espressif/frameworks/esp-idf-v5.3.1/"
+  }
 }

AGENTS.md

@@ -64,7 +64,7 @@ Key rotation to never trigger casually: only the **full** factory reset (`factor
 - **One MCP call per serial port at a time.** The port lock is exclusive; concurrent calls deadlock. Sequence: open → read/mutate → close, then next device.
 - **`userPrefs.jsonc` is session state during tests.** The `_session_userprefs` fixture snapshots + restores it; never edit it from inside a test.
 - **Don't speculate about firmware root causes.** When evidence doesn't support a classification, say "unknown" and list what would disambiguate.
-- **Run `trunk fmt` before proposing a commit.** The `trunk_check` CI gate will reject unformatted code. Claude Code runs it automatically via the PostToolUse hook in `.claude/settings.json`; trunk's launcher needs `curl` or `wget` to bootstrap its pinned CLI — see **Formatting & the trunk toolchain** in `.github/copilot-instructions.md` for the no-curl bootstrap procedure.
+- **Run `trunk fmt` before proposing a commit.** The `trunk_check` CI gate will reject unformatted code.
 - **`confirm=True` on destructive MCP tools is a real gate, not a formality.** Don't bypass it via auto-approve settings.
 - **Keep code comments minimal — one or two lines, max.** Comment only when the _why_ isn't obvious from the code; never restate what the next line does. No multi-paragraph block comments explaining straightforward changes. The diff and commit message carry the rationale; the code carries the behavior.
 - **Use `Throttle` for time-based rate limiting, not raw `millis()` math.** `src/mesh/Throttle.h` provides `Throttle::isWithinTimespanMs(lastMs, intervalMs)` (returns true while inside the cooldown) and `Throttle::execute(&lastMs, intervalMs, func)` (function-pointer form that updates the timestamp on fire). Use these for any "did N ms pass since X" check — raw `millis() > lastMs + N` is rollover-unsafe (breaks after ~49.7 days) and inconsistent with the rest of the codebase. The helpers compute `now - lastMs` with unsigned subtraction, which wraps correctly.

SECURITY.md

@@ -10,35 +10,3 @@
 ## Reporting a Vulnerability
 
 We support the private reporting of potential security vulnerabilities. Please go to the Security tab to file a report with a description of the potential vulnerability and reproduction scripts (preferred) or steps, and our developers will review.
-
-Before filing, please read the Security Model below. Behavior whose only precondition is local API access to a node, or possession of a channel's pre-shared key, is intended by design and is not considered a vulnerability.
-
-## Security Model
-
-Meshtastic is an off-grid mesh protocol that runs on constrained microcontrollers within a 256 byte LoRa packet limit. These constraints shape its security design and rule out the heavier schemes used by IP-based protocols. This section summarizes what the firmware protects, the assumptions it rests on, and its known limits. Fuller write-ups are in the documentation:
-
-- Encryption overview: https://meshtastic.org/docs/overview/encryption/
-- Technical reference: https://meshtastic.org/docs/development/reference/encryption-technical/
-- Known limitations and future work: https://meshtastic.org/docs/about/overview/encryption/limitations/
-
-### Cryptographic mechanisms
-
-- Channels are encrypted with a pre-shared key (PSK) using AES256-CTR. Channel traffic is encrypted but not authenticated, so anyone holding the PSK can read channel messages and can send messages as any node on that channel.
-- Direct messages and admin messages use public key cryptography (x25519 key exchange with AES-CCM), providing confidentiality, authentication, and integrity between nodes on 2.5.0 or newer that have exchanged keys.
-- Admin sessions use short-lived session IDs to limit replay of control messages.
-
-### Local trust boundary
-
-A client connected to a node over Bluetooth, USB serial, WiFi, or Ethernet has full local API access. From that connection it can read decrypted traffic, send messages as the node, change configuration (subject to managed mode), and read the node's private key for backup. This is intended behavior. The firmware trusts the local link the same way a phone or laptop trusts a directly attached device, and anything within reach of that connection (a shared LAN, a USB cable to an untrusted host, a paired phone) should be treated as part of the node itself.
-
-### Node identity (Trust On First Use)
-
-There is no central authority to sign node keys. The first public key a node hears for a given node number is the one it binds to that node number, a Trust On First Use (TOFU) model that is a hard requirement of a decentralized mesh. Clients and firmware reduce the impact of this by keeping favorited nodes from rolling out of the node database and by flagging public-key changes in the client UI.
-
-Firmware 2.8.X adds XEdDSA packet signing to further secure node identity claims and the authenticity of subsequent messages. It reuses each node's existing x25519 key pair to produce signatures, so a receiver can verify that a packet came from the holder of the bound key. Once a node has been seen signing, unsigned packets claiming that identity can be rejected.
-
-### Known limitations
-
-- No perfect forward secrecy. Traffic captured today can be decrypted later if a key is compromised, for example through a lost node or a mishandled channel key.
-- Channel messages are not authenticated, as noted above. Although as of 2.8, channel messages will be xedDSA signed as a means of verification that is non-breaking.
-- Setting WiFi credentials, or performing any other local administration, on an ESP32 over an untrusted network exposes that traffic, including the credentials, to the network. Provision and administer nodes over a trusted channel instead: Bluetooth, USB serial, or remote admin over the mesh. There is no current roadmap item to secure local administration over untrusted WiFi, though it may be addressed in a future release.

bin/config.d/lora-NebraHat_1W.yaml

@@ -1,19 +0,0 @@
-# https://github.com/wehooper4/Meshtastic-Hardware/tree/main/NebraHat
-# Use for 1 watt hat
-Meta:
-  name: NebraHat 1W
-  support: community
-  compatible:
-    - raspberry-pi
-
-Lora:
-  Module: sx1262  # Nebra SX1262 Pi Hat - 1W
-  DIO2_AS_RF_SWITCH: true
-  DIO3_TCXO_VOLTAGE: true
-#  CS: 8          # Newer version of MeshtasticD do not need this? If issues uncomment this line
-  IRQ: 22
-  Busy: 4
-  Reset: 18
-  RXen: 25  
-I2C:
-  I2CDevice: /dev/i2c-1

bin/config.d/lora-NebraHat_2W.yaml

@@ -1,20 +0,0 @@
-# https://github.com/wehooper4/Meshtastic-Hardware/tree/main/NebraHat
-# Use for 2 watt hat
-Meta:
-  name: NebraHat 2W
-  support: community
-  compatible:
-    - raspberry-pi
-
-Lora:
-  Module: sx1262  # Nebra SX1262 Pi Hat - 2W
-  DIO2_AS_RF_SWITCH: true
-  DIO3_TCXO_VOLTAGE: true
-  SX126X_MAX_POWER: 8
-#  CS: 8          # Newer version of MeshtasticD do not need this? If issues uncomment this line
-  IRQ: 22
-  Busy: 4
-  Reset: 18
-  RXen: 25
-I2C:
-  I2CDevice: /dev/i2c-1

bin/config.d/lora-RAK6421-13300-slot1.yaml

@@ -18,4 +18,4 @@ Lora:
   DIO3_TCXO_VOLTAGE: true
   DIO2_AS_RF_SWITCH: true
   spidev: spidev0.0
-  # CS: 8
+  # CS: 8

bin/config.d/lora-RAK6421-13300-slot2.yaml

@@ -18,4 +18,4 @@ Lora:
   DIO3_TCXO_VOLTAGE: true
   DIO2_AS_RF_SWITCH: true
   spidev: spidev0.1
-  # CS: 7
+  # CS: 7

bin/config.d/lora-ZebraHat_1W.yaml

@@ -1,19 +0,0 @@
-# https://github.com/wehooper4/Meshtastic-Hardware/tree/main/ZebraHAT
-# Use for 1 watt hat
-Meta:
-  name: ZebraHat 1W
-  support: community
-  compatible:
-    - raspberry-pi
-
-Lora:
-  Module: sx1262  # Zebra SX1262 Pi Hat - 1W
-  DIO2_AS_RF_SWITCH: true
-  DIO3_TCXO_VOLTAGE: true
-  SX126X_MAX_POWER: 18 
-  CS: 24
-  IRQ: 22
-  Busy: 27
-  Reset: 17
-I2C:
-  I2CDevice: /dev/i2c-1

bin/config.d/lora-ZebraHat_2W.yaml

@@ -1,20 +0,0 @@
-# https://github.com/wehooper4/Meshtastic-Hardware/tree/main/ZebraHAT
-# Use for 2 watt hat
-Meta:
-  name: ZebraHat 2W
-  support: community
-  compatible:
-    - raspberry-pi
-
-Lora:
-  Module: sx1262  # Zebra SX1262 Pi Hat - 2W
-  DIO2_AS_RF_SWITCH: true
-  DIO3_TCXO_VOLTAGE: true
-  SX126X_MAX_POWER: 8 
-  CS: 24
-  IRQ: 22
-  Busy: 27
-  Reset: 17
-  RXen: 25
-I2C:
-  I2CDevice: /dev/i2c-1

bin/config.d/lora-ecb41-pge-RAK6421-13300-slot2.yaml

@@ -29,8 +29,6 @@ Lora:
     - pin: 50 # GPIO1_C2 (physical 16)
       gpiochip: 1
       line: 18
-  DIO3_TCXO_VOLTAGE: true
-  DIO2_AS_RF_SWITCH: true
   spidev: spidev0.1
   # CS: # GPIO0_A7 (SPI1_CSN1, physical 26)
   #   pin: 7

bin/config.d/lora-ecb41-pge-RAK6421-13302-slot2.yaml

@@ -29,8 +29,6 @@ Lora:
     - pin: 50 # GPIO1_C2 (physical 16)
       gpiochip: 1
       line: 18
-  DIO3_TCXO_VOLTAGE: true
-  DIO2_AS_RF_SWITCH: true
   spidev: spidev0.1
   # CS: # GPIO0_A7 (SPI1_CSN1, physical 26)
   #   pin: 7

bin/config.d/lora-lyra-zero-BQ-SG3-BQ35LORA900V1M-slot1.yaml

@@ -1,29 +0,0 @@
-# Station G3 + BQ35LORA900V1M Primary Slot
-# Board Doc: https://wiki.bqvoy.com/en/devkits/station-g3
-Meta:
-  name: B&Q Station G3 + BQ35LORA900V1M Primary Slot
-  support: official
-  compatible:
-    - luckfox-lyra-zero-w # Armbian
-
-Lora:
-  Module: sx1262
-  IRQ: # GPIO0_A5 (physical 15)
-    pin: 5
-    gpiochip: 0
-    line: 5
-  Reset: # GPIO1_D1 (physical 36)
-    pin: 57
-    gpiochip: 1
-    line: 25
-  Busy: # GPIO0_B4 (physical 18)
-    pin: 12
-    gpiochip: 0
-    line: 12
-  DIO3_TCXO_VOLTAGE: true
-  DIO2_AS_RF_SWITCH: true
-  spidev: spidev0.0
-  # CS: # GPIO0_B2 (physical 24)
-  #   pin: 10
-  #   gpiochip: 0
-  #   line: 10

bin/config.d/lora-lyra-zero-RAK6421-13300-slot2.yaml

@@ -29,8 +29,6 @@ Lora:
     - pin: 13 # GPIO0_B5
       gpiochip: 0
       line: 13
-  DIO3_TCXO_VOLTAGE: true
-  DIO2_AS_RF_SWITCH: true
   spidev: spidev0.1
   # CS: # GPIO0_B1
   #   pin: 9

bin/config.d/lora-lyra-zero-RAK6421-13302-slot2.yaml

@@ -29,8 +29,6 @@ Lora:
     - pin: 13 # GPIO0_B5
       gpiochip: 0
       line: 13
-  DIO3_TCXO_VOLTAGE: true
-  DIO2_AS_RF_SWITCH: true
   spidev: spidev0.1
   # CS: # GPIO0_B1
   #   pin: 9

bin/config.d/lora-ok3506-RAK6421-13300-slot2.yaml

@@ -31,8 +31,6 @@ Lora:
     - pin: 103 # GPIO3_A7 (physical 16)
       gpiochip: 3
       line: 7
-  DIO3_TCXO_VOLTAGE: true
-  DIO2_AS_RF_SWITCH: true
   spidev: spidev0.1
   # CS: # GPIO0_B7 (SPI0_CSN1, physical 26)
   #   pin: 15

bin/config.d/lora-ok3506-RAK6421-13302-slot2.yaml

@@ -31,8 +31,6 @@ Lora:
     - pin: 103 # GPIO3_A7 (physical 16)
       gpiochip: 3
       line: 7
-  DIO3_TCXO_VOLTAGE: true
-  DIO2_AS_RF_SWITCH: true
   spidev: spidev0.1
   # CS: # GPIO0_B7 (SPI0_CSN1, physical 26)
   #   pin: 15

bin/config.d/lora-rpi-BQ-SG3-BQ35LORA900V1M-slot1.yaml

@@ -1,17 +0,0 @@
-# Station G3 + BQ35LORA900V1M Primary Slot
-# Board Doc: https://wiki.bqvoy.com/en/devkits/station-g3
-Meta:
-  name: B&Q Station G3 + BQ35LORA900V1M Primary Slot
-  support: official
-  compatible:
-    - raspberry-pi
-
-Lora:
-  Module: sx1262
-  IRQ: 22
-  Reset: 16
-  Busy: 24
-  DIO3_TCXO_VOLTAGE: true
-  DIO2_AS_RF_SWITCH: true
-  spidev: spidev0.0
-  #CS: 8

bin/config.d/lora-usb-meshtoad-e22.yaml

@@ -1,5 +1,3 @@
-# This config works with all revisions of the Meshtoad USB radio.
-
 Meta:
   name: meshtoad-e22
   support: official

bin/eth-ota-upload.py

@@ -1,252 +0,0 @@
-#!/usr/bin/env python3
-"""
-Meshtastic Ethernet OTA Upload Tool
-
-Uploads firmware to RP2350-based Meshtastic devices via Ethernet (W5500).
-Compresses firmware with GZIP and sends it over TCP using the MOTA protocol.
-Authenticates using SHA256 challenge-response with a pre-shared key (PSK).
-
-Usage:
-    python bin/eth-ota-upload.py --host 192.168.1.100 firmware.bin
-    python bin/eth-ota-upload.py --host 192.168.1.100 --psk mySecretKey firmware.bin
-    python bin/eth-ota-upload.py --host 192.168.1.100 --psk-hex 6d65736874... firmware.bin
-"""
-
-import argparse
-import gzip
-import hashlib
-import socket
-import struct
-import sys
-import time
-
-# Default PSK matching the firmware default: "meshtastic_ota_default_psk_v1!!!"
-DEFAULT_PSK = b"meshtastic_ota_default_psk_v1!!!"
-
-
-def crc32(data: bytes) -> int:
-    """Compute CRC32 matching ErriezCRC32 (standard CRC32 with final XOR)."""
-    import binascii
-
-    return binascii.crc32(data) & 0xFFFFFFFF
-
-
-def load_firmware(path: str) -> bytes:
-    """Load firmware file, compressing with GZIP if not already compressed."""
-    # Reject UF2 files — OTA requires raw .bin firmware
-    if path.lower().endswith(".uf2"):
-        bin_path = path.rsplit(".", 1)[0] + ".bin"
-        print(f"ERROR: UF2 files cannot be used for OTA updates.")
-        print(f"       The Updater/picoOTA expects raw .bin firmware.")
-        print(f"       Try: {bin_path}")
-        sys.exit(1)
-
-    with open(path, "rb") as f:
-        data = f.read()
-
-    # Check if already GZIP compressed (magic bytes 1f 8b)
-    if data[:2] == b"\x1f\x8b":
-        print(f"Firmware already GZIP compressed: {len(data):,} bytes")
-        return data
-
-    print(f"Firmware raw size: {len(data):,} bytes")
-    compressed = gzip.compress(data, compresslevel=9)
-    ratio = len(compressed) / len(data) * 100
-    print(f"GZIP compressed: {len(compressed):,} bytes ({ratio:.1f}%)")
-    return compressed
-
-
-def authenticate(sock: socket.socket, psk: bytes) -> bool:
-    """Perform SHA256 challenge-response authentication with the device."""
-    # Receive 32-byte nonce from server
-    nonce = b""
-    while len(nonce) < 32:
-        chunk = sock.recv(32 - len(nonce))
-        if not chunk:
-            print("ERROR: Connection closed during authentication")
-            return False
-        nonce += chunk
-
-    # Compute SHA256(nonce || PSK)
-    h = hashlib.sha256()
-    h.update(nonce)
-    h.update(psk)
-    response = h.digest()
-
-    # Send 32-byte response
-    sock.sendall(response)
-
-    # Wait for auth result (1 byte)
-    result = sock.recv(1)
-    if not result:
-        print("ERROR: No authentication response")
-        return False
-
-    if result[0] == 0x06:  # ACK
-        print("Authentication successful.")
-        return True
-    elif result[0] == 0x07:  # OTA_ERR_AUTH
-        print("ERROR: Authentication failed — wrong PSK")
-        return False
-    else:
-        print(f"ERROR: Unexpected auth response 0x{result[0]:02X}")
-        return False
-
-
-def upload_firmware(host: str, port: int, firmware: bytes, psk: bytes, timeout: float) -> bool:
-    """Upload firmware over TCP using the MOTA protocol with PSK authentication."""
-    fw_crc = crc32(firmware)
-    fw_size = len(firmware)
-
-    print(f"Connecting to {host}:{port}...")
-    sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
-    sock.settimeout(timeout)
-
-    try:
-        sock.connect((host, port))
-        print("Connected.")
-
-        # Step 1: Authenticate
-        print("Authenticating...")
-        if not authenticate(sock, psk):
-            return False
-
-        # Step 2: Send 12-byte MOTA header: magic(4) + size(4) + crc32(4)
-        header = struct.pack("<4sII", b"MOTA", fw_size, fw_crc)
-        sock.sendall(header)
-        print(f"Header sent: size={fw_size:,}, CRC32=0x{fw_crc:08X}")
-
-        # Wait for ACK (1 byte)
-        ack = sock.recv(1)
-        if not ack or ack[0] != 0x06:
-            error_codes = {
-                0x02: "Size error",
-                0x04: "Invalid magic",
-                0x05: "Update.begin() failed",
-            }
-            code = ack[0] if ack else 0xFF
-            msg = error_codes.get(code, f"Unknown error 0x{code:02X}")
-            print(f"ERROR: Server rejected header: {msg}")
-            return False
-
-        print("Header accepted. Uploading firmware...")
-
-        # Send firmware in 1KB chunks
-        chunk_size = 1024
-        sent = 0
-        start_time = time.time()
-
-        while sent < fw_size:
-            end = min(sent + chunk_size, fw_size)
-            chunk = firmware[sent:end]
-            sock.sendall(chunk)
-            sent = end
-
-            # Progress bar
-            pct = sent * 100 // fw_size
-            bar_len = 40
-            filled = bar_len * sent // fw_size
-            bar = "█" * filled + "░" * (bar_len - filled)
-            elapsed = time.time() - start_time
-            speed = sent / elapsed if elapsed > 0 else 0
-            sys.stdout.write(f"\r  [{bar}] {pct:3d}% {sent:,}/{fw_size:,} ({speed/1024:.1f} KB/s)")
-            sys.stdout.flush()
-
-        elapsed = time.time() - start_time
-        print(f"\n  Transfer complete in {elapsed:.1f}s")
-
-        # Wait for final result (1 byte)
-        print("Waiting for verification...")
-        result = sock.recv(1)
-        if not result:
-            print("ERROR: No response from device")
-            return False
-
-        result_codes = {
-            0x00: "OK — Update staged, device rebooting",
-            0x01: "CRC mismatch",
-            0x02: "Size error",
-            0x03: "Write error",
-            0x04: "Magic mismatch",
-            0x05: "Updater.begin() failed",
-            0x07: "Auth failed",
-            0x08: "Timeout",
-        }
-        code = result[0]
-        msg = result_codes.get(code, f"Unknown result 0x{code:02X}")
-
-        if code == 0x00:
-            print(f"SUCCESS: {msg}")
-            return True
-        else:
-            print(f"ERROR: {msg}")
-            return False
-
-    except socket.timeout:
-        print("ERROR: Connection timed out")
-        return False
-    except ConnectionRefusedError:
-        print(f"ERROR: Connection refused by {host}:{port}")
-        return False
-    except OSError as e:
-        print(f"ERROR: {e}")
-        return False
-    finally:
-        sock.close()
-
-
-def main():
-    parser = argparse.ArgumentParser(
-        description="Upload firmware to Meshtastic RP2350 devices via Ethernet OTA"
-    )
-    parser.add_argument("firmware", help="Path to firmware .bin or .bin.gz file")
-    parser.add_argument("--host", required=True, help="Device IP address")
-    parser.add_argument(
-        "--port", type=int, default=4243, help="OTA port (default: 4243)"
-    )
-    parser.add_argument(
-        "--timeout",
-        type=float,
-        default=60.0,
-        help="Socket timeout in seconds (default: 60)",
-    )
-    psk_group = parser.add_mutually_exclusive_group()
-    psk_group.add_argument(
-        "--psk",
-        type=str,
-        help="Pre-shared key as UTF-8 string (default: meshtastic_ota_default_psk_v1!!!)",
-    )
-    psk_group.add_argument(
-        "--psk-hex",
-        type=str,
-        help="Pre-shared key as hex string (e.g., 6d65736874...)",
-    )
-    args = parser.parse_args()
-
-    # Resolve PSK
-    if args.psk:
-        psk = args.psk.encode("utf-8")
-    elif args.psk_hex:
-        try:
-            psk = bytes.fromhex(args.psk_hex)
-        except ValueError:
-            print("ERROR: Invalid hex string for --psk-hex")
-            sys.exit(1)
-    else:
-        psk = DEFAULT_PSK
-
-    print("Meshtastic Ethernet OTA Upload")
-    print("=" * 40)
-
-    firmware = load_firmware(args.firmware)
-
-    if upload_firmware(args.host, args.port, firmware, psk, args.timeout):
-        print("\nDevice is rebooting with new firmware.")
-        sys.exit(0)
-    else:
-        print("\nUpload failed.")
-        sys.exit(1)
-
-
-if __name__ == "__main__":
-    main()

bin/platformio-custom.py

@@ -219,37 +219,41 @@ with open(jsonLoc) as f:
     jsonStr = re.sub("//.*","", f.read(), flags=re.MULTILINE)
     userPrefs = json.loads(jsonStr)
 
+pref_flags = []
+# Pre-process the userPrefs
+for pref in userPrefs:
+    if userPrefs[pref].startswith("{"):
+        pref_flags.append("-D" + pref + "=" + userPrefs[pref])
+    elif userPrefs[pref].lstrip("-").replace(".", "").isdigit():
+        pref_flags.append("-D" + pref + "=" + userPrefs[pref])
+    elif userPrefs[pref] == "true" or userPrefs[pref] == "false":
+        pref_flags.append("-D" + pref + "=" + userPrefs[pref])
+    elif userPrefs[pref].startswith("meshtastic_"):
+        pref_flags.append("-D" + pref + "=" + userPrefs[pref])
+    # If the value is a string, we need to wrap it in quotes
+    else:
+        pref_flags.append("-D" + pref + "=" + env.StringifyMacro(userPrefs[pref]) + "")
+
+# General options that are passed to the C and C++ compilers
 # Calculate unix epoch for current day (midnight)
 current_date = datetime.now().replace(hour=0, minute=0, second=0, microsecond=0)
 build_epoch = int(current_date.timestamp())
 
-cpp_defines = [
-    ("APP_VERSION", verObj["long"]),
-    ("APP_VERSION_SHORT", verObj["short"]),
-    ("APP_ENV", env.get("PIOENV")),
-    ("APP_REPO", repo_owner),
-    ("BUILD_EPOCH", str(build_epoch)),
-]
+flags = [
+        "-DAPP_VERSION=" + verObj["long"],
+        "-DAPP_VERSION_SHORT=" + verObj["short"],
+        "-DAPP_ENV=" + env.get("PIOENV"),
+        "-DAPP_REPO=" + repo_owner,
+        "-DBUILD_EPOCH=" + str(build_epoch),
+    ] + pref_flags
 
-# Process userPrefs into CPPDEFINES
-for pref in userPrefs:
-    val = userPrefs[pref]
-    if val.startswith("{"):
-        cpp_defines.append((pref, val))
-    elif val.lstrip("-").replace(".", "").isdigit():
-        cpp_defines.append((pref, val))
-    elif val == "true" or val == "false":
-        cpp_defines.append((pref, val))
-    elif val.startswith("meshtastic_"):
-        cpp_defines.append((pref, val))
-    else:
-        cpp_defines.append((pref, env.StringifyMacro(val)))
+print("Using flags:")
+for flag in flags:
+    print(flag)
 
-print("Using CPPDEFINES:")
-for d in cpp_defines:
-    print(f"  -D{d[0]}={d[1]}")
-
-projenv.Append(CPPDEFINES=cpp_defines)
+projenv.Append(
+    CCFLAGS=flags,
+)
 
 for lb in env.GetLibBuilders():
     if lb.name == "meshtastic-device-ui":

bin/run-tests.sh

@@ -1,249 +0,0 @@
-#!/usr/bin/env bash
-# Run native PlatformIO unit tests and emit a single, unambiguous RED/AMBER/GREEN verdict.
-#
-# Why this exists: PlatformIO reports failures three different ways ([FAILED], :FAIL:,
-# [ERRORED]) and an all-pass run prints "N succeeded" with NO "0 failed" clause — so naive
-# greps produce false greens (see .notes/test-passfail-filter.md). This script encodes the
-# correct logic once, and cross-checks the number of suites that actually ran against the
-# canonical set in test/ so a suite silently going missing shows up as AMBER, not green.
-#
-# Usage:
-#   ./bin/run-tests.sh                      # run all suites, full RAG + count cross-check
-#   ./bin/run-tests.sh -f test_utf8         # run one suite (no count cross-check)
-#   ./bin/run-tests.sh -e native            # override env (default: coverage)
-#   ./bin/run-tests.sh --quiet              # only print the final RESULT line
-#
-# Exit codes: 0 = GREEN, 1 = RED, 2 = AMBER.
-#
-# The final line is machine-readable, e.g.:
-#   RESULT: GREEN 19/19 suites passed
-#   RESULT: AMBER 17/19 suites ran (missing: test_radio test_serial) — all that ran passed
-#   RESULT: RED test_traffic_management: 1 failed  (or: build/crash error)
-#   RESULT: RED sanitizer fault — SUMMARY: AddressSanitizer: 1272 byte(s) leaked  (tests may have
-#           all passed; the coverage build aborts at exit on an ASan/LSan fault — often shown only
-#           as [ERRORED]/SIGHUP. The script names it and points at running the binary bare.)
-
-set -uo pipefail
-
-SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
-ROOT_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
-cd "$ROOT_DIR"
-
-ENV="coverage"
-FILTER=""
-QUIET=false
-PASSTHRU=()
-
-while [[ $# -gt 0 ]]; do
-	case "$1" in
-	-f)
-		FILTER="$2"
-		PASSTHRU+=("-f" "$2")
-		shift 2
-		;;
-	-e)
-		ENV="$2"
-		shift 2
-		;;
-	--quiet)
-		QUIET=true
-		shift
-		;;
-	*)
-		PASSTHRU+=("$1")
-		shift
-		;;
-	esac
-done
-
-# Locate pio (PATH, then the standard PlatformIO venv).
-PIO="$(command -v pio || command -v platformio || echo "$HOME/.platformio/penv/bin/pio")"
-if [[ ! -x $PIO ]] && ! command -v "$PIO" >/dev/null 2>&1; then
-	echo "RESULT: RED pio not found (looked in PATH and ~/.platformio/penv/bin)"
-	exit 1
-fi
-
-LOG="$(mktemp -t meshtest.XXXXXX.log)"
-MARKER=""
-PROGRESS_PID=""
-trap 'rm -f "$LOG" "${MARKER:-}"; [[ -n ${PROGRESS_PID:-} ]] && kill "$PROGRESS_PID" 2>/dev/null' EXIT
-
-# Canonical suite set = the directories in test/. This is the source of truth for
-# "what should run"; a filtered run only expects its filtered suite.
-mapfile -t ALL_SUITES < <(find test -maxdepth 1 -type d -name 'test_*' -printf '%f\n' | sort)
-EXPECTED_COUNT=${#ALL_SUITES[@]}
-
-# Cached object-count for this env, written after each completed build (in the gitignored build
-# dir). Used as the progress denominator: accurate for a full rebuild (every object recompiles),
-# only a rough upper bound for an incremental run.
-BASELINE_FILE=".pio/build/${ENV}/.runtests-objcount"
-
-# Progress trail file (gitignored build dir). ALWAYS written so a backgrounded/piped run can be
-# checked mid-build with `tail -f` — that's the whole point: don't fly blind on a 20-min rebuild.
-PROGRESS_FILE=".pio/build/${ENV}/.runtests-progress"
-
-# --- Progress heartbeat ------------------------------------------------------
-# Emit ONE status line every few seconds: build = objects (re)compiled this run / cached total +
-# best-effort ETA; test = suites finished / expected. Appends to $PROGRESS_FILE always (tail it to
-# check on a backgrounded run); also live-updates the tty when $5=1 (interactive --quiet). Never
-# touches $LOG, which is parsed for the verdict, so piped/CI captures stay clean.
-progress_monitor() {
-	local marker="$1" objtotal="$2" testtotal="$3" pfile="$4" totty="$5" start now el done ran eta line
-	start=$(date +%s)
-	while :; do
-		now=$(date +%s)
-		el=$((now - start))
-		if grep -q 'Testing\.\.\.' "$LOG" 2>/dev/null; then
-			ran=$(grep -cE "${ENV}:test_[a-z0-9_]+ \[(PASSED|FAILED|ERRORED)\]" "$LOG" 2>/dev/null)
-			line=$(printf '[test] %s/%s suites done — %dm%02ds' "$ran" "$testtotal" $((el / 60)) $((el % 60)))
-		else
-			done=$(find ".pio/build/${ENV}" -name '*.o' -newer "$marker" 2>/dev/null | wc -l)
-			if ((objtotal > 0 && done > 0)); then
-				eta=$((objtotal > done ? (objtotal - done) * el / done : 0))
-				line=$(printf '[build] %d/%d objs — %dm%02ds — ETA ~%dm%02ds' \
-					"$done" "$objtotal" $((el / 60)) $((el % 60)) $((eta / 60)) $((eta % 60)))
-			else
-				# done==0 (incremental: nothing to rebuild yet) or no cached baseline — no ETA yet.
-				line=$(printf '[build] %d objs compiled — %dm%02ds' "$done" $((el / 60)) $((el % 60)))
-			fi
-		fi
-		printf '%s\n' "$line" >>"$pfile" 2>/dev/null                           # file trail (always)
-		[[ $totty == 1 ]] && printf '\r\033[K%s' "$line" >/dev/tty 2>/dev/null # live line (human)
-		sleep 4
-	done
-}
-
-# Launch the heartbeat for every run. It writes the progress file unconditionally; the live tty
-# line only when interactive AND --quiet (where pio's own output is hidden — otherwise pio's
-# streamed compile lines already show progress and a \r line would just fight them).
-mkdir -p ".pio/build/${ENV}" 2>/dev/null || true
-: >"$PROGRESS_FILE" 2>/dev/null || true
-MARKER="$(mktemp -t meshtest-mark.XXXXXX)"
-TOTTY=0
-{ $QUIET && [[ -t 1 ]]; } && TOTTY=1
-progress_monitor "$MARKER" "$(cat "$BASELINE_FILE" 2>/dev/null || echo 0)" \
-	"$([[ -n $FILTER ]] && echo 1 || echo "$EXPECTED_COUNT")" "$PROGRESS_FILE" "$TOTTY" &
-PROGRESS_PID=$!
-
-if ! $QUIET; then
-	echo "Running: $PIO test -e $ENV ${PASSTHRU[*]-} (expecting $EXPECTED_COUNT suites)"
-fi
-echo "progress: tail -f $PROGRESS_FILE" >&2
-
-# Run pio, tee to log. PIPESTATUS[0] is pio's real exit (NOT tee's).
-if $QUIET; then
-	"$PIO" test -e "$ENV" "${PASSTHRU[@]}" >"$LOG" 2>&1
-else
-	"$PIO" test -e "$ENV" "${PASSTHRU[@]}" 2>&1 | tee "$LOG"
-fi
-PIO_RC=${PIPESTATUS[0]}
-
-# Stop the heartbeat, clear its line, and cache this build's object total for next time.
-if [[ -n $PROGRESS_PID ]]; then
-	kill "$PROGRESS_PID" 2>/dev/null
-	wait "$PROGRESS_PID" 2>/dev/null
-	PROGRESS_PID=""
-	# Clear the live line only if we were writing one — opening /dev/tty when there is none is
-	# itself a redirect-open error the trailing 2>/dev/null cannot suppress.
-	[[ $TOTTY == 1 ]] && printf '\r\033[K' >/dev/tty 2>/dev/null
-fi
-[[ -d ".pio/build/${ENV}" ]] && find ".pio/build/${ENV}" -name '*.o' 2>/dev/null | wc -l >"$BASELINE_FILE" 2>/dev/null || true
-
-# --- Outcome detection -------------------------------------------------------
-# The SAME outcome is spelled differently depending on which layer emitted the line — this is
-# the trap that produces false greens (grepping ":PASS" misses pio's "[PASSED]", grepping
-# "[FAILED]" misses Unity's ":FAIL:"). So every regex below matches BOTH spellings:
-#   pass:  Unity per-assertion ":PASS"   | pio per-suite "[PASSED]"      | summary "N succeeded"
-#   fail:  Unity per-assertion ":FAIL:"  | pio per-suite "[FAILED]"      | summary "M failed"
-#   error: pio build/crash "[ERRORED]"   | Unity "M Failures"            | compiler "error:"
-# Match \b after :PASS/:FAIL so ":PASSED"/":FAILED" forms are also caught either way.
-FAIL_RE=':FAIL\b|\[FAILED\]|\[ERRORED\]|[1-9][0-9]* failed|[0-9]+ Tests [1-9][0-9]* Failures|error:|undefined reference|Segmentation fault|terminate called|SIGHUP|SIGSEGV|SIGABRT'
-# Positive proof tests actually ran & passed (absence != success). Accept any pass spelling:
-# the per-test/per-suite tokens OR a success summary line.
-PASS_RE=':PASS\b|\[PASSED\]|test cases: *[0-9]+ succeeded|[0-9]+ Tests 0 Failures'
-# Sanitizer (ASan/LSan/UBSan/TSan) fault signatures. The coverage build is sanitizer-instrumented
-# and aborts NON-ZERO at exit on a fault — most often a LeakSanitizer leak — AFTER every test has
-# already printed [PASSED]. pio then reports [ERRORED]/SIGHUP with no :FAIL: anywhere, so it
-# masquerades as a phantom "N-1 of N succeeded". See .notes/test-passfail-filter.md.
-# Match only real FAULT lines, never the benign "AddressSanitizer: failed to intercept '...'"
-# startup noise that prints on every sanitizer run (it'd mislabel a normal [FAILED] as a leak).
-# Formats per LLVM/Google sanitizer docs: ASan/LSan emit "==PID==ERROR: <San>: ...", UBSan emits
-# "file:line:col: runtime error: ...", TSan emits "WARNING: ThreadSanitizer: ..."; all close with
-# a "SUMMARY: <San>: ..." line (LSan-under-ASan reports its SUMMARY as "AddressSanitizer").
-SAN_RE='(ERROR|WARNING): (Address|Leak|Thread|UndefinedBehavior)Sanitizer:|SUMMARY: (Address|Leak|Thread|UndefinedBehavior)Sanitizer:|Direct leak of|Indirect leak of|detected memory leaks|heap-use-after-free|heap-buffer-overflow|stack-buffer-overflow|attempting double-free|LeakSanitizer has encountered a fatal error|runtime error:'
-
-# Suites that produced a per-suite verdict. pio emits "coverage:test_x [PASSED|FAILED|ERRORED]";
-# a SKIPPED suite (hardware-only on native) is "accounted for" too, so it doesn't read as missing.
-mapfile -t RAN_SUITES < <(grep -oE "${ENV}:test_[a-z0-9_]+ \[(PASSED|FAILED|ERRORED)\]" "$LOG" |
-	sed -E "s/^${ENV}:(test_[a-z0-9_]+) .*/\1/" | sort -u)
-RAN_COUNT=${#RAN_SUITES[@]}
-# Suites pio explicitly skipped (don't count these as "missing" in the canonical cross-check).
-mapfile -t SKIPPED_SUITES < <(grep -oE "${ENV}:test_[a-z0-9_]+.*\bSKIPPED\b" "$LOG" |
-	grep -oE "test_[a-z0-9_]+" | sort -u)
-
-verdict_red() {
-	local detail bin
-	detail="$(grep -nE '\[FAILED\]|:FAIL:|\[ERRORED\]' "$LOG" | head -3 | sed 's/^/    /')"
-	echo ""
-	echo "RED — failures detected:"
-	[[ -n $detail ]] && echo "$detail"
-	grep -E 'test cases:' "$LOG" | tail -1 | sed 's/^/    /'
-
-	# Path to the test binary for the "run it bare" hint. For native/coverage the test program is
-	# the env executable (e.g. .pio/build/coverage/meshtasticd), NOT a file named 'program'.
-	bin="$(find ".pio/build/${ENV}" -maxdepth 1 -type f -executable ! -name '*.so' 2>/dev/null | head -1)"
-	[[ -z $bin ]] && bin=".pio/build/${ENV}/<program>  (build it first: $PIO test -e ${ENV} ${FILTER:+-f $FILTER} --without-testing)"
-
-	# Sanitizer fault (ASan/LSan/UBSan/TSan): name the real cause instead of "build/crash error".
-	if grep -qE "$SAN_RE" "$LOG"; then
-		grep -nE "$SAN_RE" "$LOG" | head -4 | sed 's/^/    /'
-		echo "    -> sanitizer fault: if every test above is PASS, this is an exit-time abort, not a failed assertion."
-		echo "    -> read the full report by running the binary BARE (gdb hides it via ptrace): ./$bin 2>&1 | tail -40"
-		echo "RESULT: RED sanitizer fault — $(grep -ohE 'SUMMARY: [A-Za-z]+Sanitizer:.*' "$LOG" | tail -1 || echo 'see report above')"
-		exit 1
-	fi
-
-	# All tests passed but the process still aborted at EXIT (ERRORED/SIGHUP/SIGABRT) and the
-	# sanitizer report was swallowed by the runner (often surfaced only as SIGHUP). Almost always a
-	# sanitizer fault — point at how to surface it rather than calling it a generic crash.
-	if grep -qE "$PASS_RE" "$LOG" && grep -qE '\[ERRORED\]|SIGHUP|SIGABRT' "$LOG" && ! grep -qE ':FAIL\b|\[FAILED\]' "$LOG"; then
-		echo "    -> all tests passed but the process aborted at EXIT — likely an ASan/LSan fault whose report"
-		echo "       the runner swallowed (commonly shown as SIGHUP). Run the binary BARE to see it: ./$bin 2>&1 | tail -40"
-		echo "RESULT: RED exit-time abort (tests passed; likely sanitizer — see hint above)"
-		exit 1
-	fi
-
-	echo "RESULT: RED $(grep -oE '[0-9]+ failed' "$LOG" | tail -1 || echo 'build/crash error')"
-	exit 1
-}
-
-# RED: pio non-zero, any failure marker, or no positive summary at all (build died early).
-if [[ $PIO_RC -ne 0 ]] || grep -qE "$FAIL_RE" "$LOG"; then
-	verdict_red
-fi
-if ! grep -qE "$PASS_RE" "$LOG"; then
-	echo ""
-	echo "RESULT: RED no success summary found (build error / no tests ran?) — see log"
-	exit 1
-fi
-
-# AMBER: everything that ran passed, but (full run only) a canonical suite neither ran NOR was
-# explicitly skipped — i.e. it silently went missing. SKIPPED suites are accounted for.
-ACCOUNTED_COUNT=$((RAN_COUNT + ${#SKIPPED_SUITES[@]}))
-if [[ -z $FILTER && $ACCOUNTED_COUNT -lt $EXPECTED_COUNT ]]; then
-	missing=()
-	for s in "${ALL_SUITES[@]}"; do
-		printf '%s\n' "${RAN_SUITES[@]}" "${SKIPPED_SUITES[@]}" | grep -qx "$s" || missing+=("$s")
-	done
-	echo ""
-	echo "RESULT: AMBER ${RAN_COUNT}/${EXPECTED_COUNT} suites ran (missing: ${missing[*]}) — all that ran passed"
-	exit 2
-fi
-
-# GREEN.
-if [[ -n $FILTER ]]; then
-	echo "RESULT: GREEN ${RAN_COUNT} suite(s) passed (filtered: $FILTER)"
-else
-	echo "RESULT: GREEN ${RAN_COUNT}/${EXPECTED_COUNT} suites passed"
-fi
-exit 0

boards/heltec_mesh_tower_v2.json

@@ -1,54 +0,0 @@
-{
-  "build": {
-    "arduino": {
-      "ldscript": "nrf52840_s140_v6.ld"
-    },
-    "core": "nRF5",
-    "cpu": "cortex-m4",
-    "extra_flags": "-DNRF52840_XXAA",
-    "f_cpu": "64000000L",
-    "hwids": [
-      ["0x239A", "0x4405"],
-      ["0x239A", "0x0029"],
-      ["0x239A", "0x002A"],
-      ["0x239A", "0x0071"]
-    ],
-    "usb_product": "HT-n5262",
-    "mcu": "nrf52840",
-    "variant": "heltec_mesh_tower_v2",
-    "variants_dir": "variants",
-    "bsp": {
-      "name": "adafruit"
-    },
-    "softdevice": {
-      "sd_flags": "-DS140",
-      "sd_name": "s140",
-      "sd_version": "6.1.1",
-      "sd_fwid": "0x00B6"
-    },
-    "bootloader": {
-      "settings_addr": "0xFF000"
-    }
-  },
-  "connectivity": ["bluetooth"],
-  "debug": {
-    "jlink_device": "nRF52840_xxAA",
-    "onboard_tools": ["jlink"],
-    "svd_path": "nrf52840.svd",
-    "openocd_target": "nrf52840-mdk-rs"
-  },
-  "frameworks": ["arduino"],
-  "name": "Heltec MeshTower V2 (Adafruit BSP)",
-  "upload": {
-    "maximum_ram_size": 248832,
-    "maximum_size": 815104,
-    "speed": 115200,
-    "protocol": "nrfutil",
-    "protocols": ["jlink", "nrfjprog", "nrfutil", "stlink"],
-    "use_1200bps_touch": true,
-    "require_upload_port": true,
-    "wait_for_upload_port": true
-  },
-  "url": "https://heltec.org",
-  "vendor": "Heltec"
-}

boards/t-impulse-plus.json

@@ -1,53 +0,0 @@
-{
-  "build": {
-    "arduino": {
-      "ldscript": "nrf52840_s140_v6.ld"
-    },
-    "core": "nRF5",
-    "cpu": "cortex-m4",
-    "extra_flags": "-DARDUINO_NRF52840_T_IMPULSE_PLUS -DNRF52840_XXAA",
-    "f_cpu": "64000000L",
-    "hwids": [["0x239A", "0x8029"]],
-    "usb_product": "T-Impulse-Plus-nRF52840",
-    "mcu": "nrf52840",
-    "variant": "t-impulse-plus",
-    "variants_dir": "variants",
-    "bsp": {
-      "name": "adafruit"
-    },
-    "softdevice": {
-      "sd_flags": "-DS140",
-      "sd_name": "s140",
-      "sd_version": "6.1.1",
-      "sd_fwid": "0x00B6"
-    },
-    "bootloader": {
-      "settings_addr": "0xFF000"
-    }
-  },
-  "connectivity": ["bluetooth"],
-  "debug": {
-    "jlink_device": "nRF52840_xxAA",
-    "onboard_tools": ["jlink"],
-    "svd_path": "nrf52840.svd"
-  },
-  "frameworks": ["arduino"],
-  "name": "Lilygo T-Impulse-Plus-nRF52840",
-  "upload": {
-    "maximum_ram_size": 248832,
-    "maximum_size": 815104,
-    "require_upload_port": true,
-    "speed": 115200,
-    "protocol": "nrfutil",
-    "protocols": [
-      "jlink",
-      "nrfjprog",
-      "nrfutil",
-      "stlink",
-      "cmsis-dap",
-      "blackmagic"
-    ]
-  },
-  "url": "https://www.lilygo.cc/",
-  "vendor": "Lilygo"
-}

boards/wiscore_rak4600.json

@@ -0,0 +1,50 @@
+{
+  "build": {
+    "arduino": {
+      "ldscript": "nrf52832_s132_v6.ld"
+    },
+    "core": "nRF5",
+    "cpu": "cortex-m4",
+    "extra_flags": "-DNRF52832_XXAA -DNRF52",
+    "f_cpu": "64000000L",
+    "hwids": [
+      ["0x239A", "0x8029"],
+      ["0x239A", "0x0029"],
+      ["0x239A", "0x002A"],
+      ["0x239A", "0x802A"]
+    ],
+    "usb_product": "Feather nRF52832 Express",
+    "mcu": "nrf52832",
+    "variant": "WisCore_RAK4600_Board",
+    "bsp": {
+      "name": "adafruit"
+    },
+    "softdevice": {
+      "sd_flags": "-DS132",
+      "sd_name": "s132",
+      "sd_version": "6.1.1",
+      "sd_fwid": "0x00B7"
+    },
+    "zephyr": {
+      "variant": "nrf52_adafruit_feather"
+    }
+  },
+  "connectivity": ["bluetooth"],
+  "debug": {
+    "jlink_device": "nRF52832_xxAA",
+    "svd_path": "nrf52.svd",
+    "openocd_target": "nrf52840-mdk-rs"
+  },
+  "frameworks": ["arduino", "zephyr"],
+  "name": "Adafruit Bluefruit nRF52832 Feather",
+  "upload": {
+    "maximum_ram_size": 65536,
+    "maximum_size": 524288,
+    "require_upload_port": true,
+    "speed": 115200,
+    "protocol": "nrfutil",
+    "protocols": ["jlink", "nrfjprog", "nrfutil", "stlink"]
+  },
+  "url": "https://www.adafruit.com/product/3406",
+  "vendor": "Adafruit"
+}

debian/ci_pack_sdeb.sh

@@ -33,5 +33,5 @@ if [[ -n $GPG_KEY_ID ]]; then
 	debuild -S -nc -k"$GPG_KEY_ID"
 else
 	# Build the source deb without signing (forks)
-	debuild -S -nc -us -uc
+	debuild -S -nc
 fi

docs/lora_region_preset_compatibility_client_spec.md

@@ -1,277 +0,0 @@
-# LoRa Region → Preset Compatibility — Client Implementation Spec
-
-**Status:** Draft for 2.8 · **Audience:** Meshtastic client app developers (Android first,
-Apple second, then web/python) · **Firmware side:** implemented in `firmware`
-(`FromRadio.region_presets`, see below).
-
-> This document lives in the firmware repo while the feature is developed. It is meant to
-> graduate to `meshtastic/protobufs` (and/or the docs site) alongside the upstream protobuf
-> PR that reserves `FromRadio` field **19**.
-
----
-
-## 1. Why this exists
-
-For 2.8 the LoRa regions and modem presets were reworked. **Not every modem preset is legal
-in every region** — narrow EU SRD bands, the EU 868 "narrow" band, amateur/ham bands, and
-the 2.4 GHz band each accept only a specific subset of presets. The firmware already
-enforces this internally (it clamps or rejects illegal combinations), but until now a client
-had no way to _know_ the rules, so a user could pick an illegal region+preset pair in the UI
-and only discover the problem after the device silently corrected it.
-
-This feature has the firmware **declare the legal region→preset combinations** to the client
-during the `want_config` handshake, so the client UI can constrain the preset picker to the
-valid set for the currently selected region (and warn about licensed-only bands). It is
-purely advisory metadata — the firmware remains the source of truth and still
-validates/clamps on its own.
-
----
-
-## 2. Protocol additions
-
-Three new messages in `meshtastic/mesh.proto`, plus one new `FromRadio` oneof variant.
-
-### 2.1 `FromRadio.region_presets` (field 19)
-
-```proto
-message FromRadio {
-  uint32 id = 1;
-  oneof payload_variant {
-    // ... fields 2..18 unchanged ...
-    LoRaRegionPresetMap region_presets = 19;
-  }
-}
-```
-
-### 2.2 Messages
-
-```proto
-// A distinct set of legal modem presets shared by one or more LoRa regions.
-message LoRaPresetGroup {
-  repeated Config.LoRaConfig.ModemPreset presets = 1;       // legal presets for this group
-  Config.LoRaConfig.ModemPreset         default_preset = 2; // always one of `presets`
-  bool                                  licensed_only = 3;  // ham/amateur band → warn/gate
-}
-
-// Associates a single LoRa region with its preset group (by index).
-message LoRaRegionPresets {
-  Config.LoRaConfig.RegionCode region = 1;
-  uint32                       group_index = 2; // index into LoRaRegionPresetMap.groups
-}
-
-// The full map, delivered grouped to fit one FromRadio packet.
-message LoRaRegionPresetMap {
-  repeated LoRaPresetGroup    groups = 1;        // each distinct preset list
-  repeated LoRaRegionPresets  region_groups = 2; // every known region → a group index
-}
-```
-
-### 2.3 Why grouped (and the size envelope clients should respect)
-
-A `FromRadio` packet is capped at **512 bytes** (`MAX_TO_FROM_RADIO_SIZE`). Most regions
-share one identical preset list (the "standard" 9-preset list), so the map is delivered
-**grouped**: `groups` holds each _distinct_ preset list once, and `region_groups` maps every
-known region to one of those groups by index. This keeps the encoded size additive
-(`groups` + `region_groups`) rather than multiplicative, well under the cap.
-
-nanopb (firmware) array bounds — clients do **not** need to enforce these, but they bound
-what you can receive:
-
-| field                               | max_count                            |
-| ----------------------------------- | ------------------------------------ |
-| `LoRaRegionPresetMap.groups`        | 8                                    |
-| `LoRaRegionPresetMap.region_groups` | 38 (= number of `RegionCode` values) |
-| `LoRaPresetGroup.presets`           | 11                                   |
-
----
-
-## 3. When it is delivered
-
-`region_presets` is sent **once** during the `want_config` handshake, as a single
-`FromRadio` message, in this position:
-
-```text
-my_info → (deviceuiConfig) → node_info(self) → metadata → region_presets → channel… → config… → moduleConfig… → node_info(others)… → fileInfo… → config_complete_id → (live packets)
-```
-
-i.e. **immediately after `metadata` and before the first `channel`**.
-
-- It is included for a normal full `want_config` and for the **config-only** nonce.
-- It is **omitted** for the **nodes-only** nonce (that path skips metadata/config entirely).
-- A client must **not** assume it always arrives (see §5).
-
----
-
-## 4. Decoding into a usable lookup
-
-Flatten the grouped wire form into `Map<RegionCode, RegionPresetInfo>`:
-
-```text
-struct RegionPresetInfo { Set<ModemPreset> presets; ModemPreset default; bool licensedOnly }
-
-fun decode(map: LoRaRegionPresetMap): Map<RegionCode, RegionPresetInfo> {
-  result = {}
-  for (rg in map.region_groups) {
-    if (rg.group_index >= map.groups.size) continue   // defensive: malformed/forward data
-    g = map.groups[rg.group_index]
-    result[rg.region] = RegionPresetInfo(
-      presets = g.presets.toSet(),
-      default = g.default_preset,
-      licensedOnly = g.licensed_only)
-  }
-  return result
-}
-```
-
-Persist this map alongside the rest of the downloaded config so the LoRa config screen can
-read it synchronously.
-
----
-
-## 5. Semantics & rules (the load-bearing part)
-
-These rules are what keep the UX correct across firmware versions. Implement all of them.
-
-1. **Absent region ⇒ no constraint.** If a `RegionCode` does not appear in `region_groups`,
-   the client has _no_ compatibility info for it and **must not restrict** its preset
-   choices (fall back to allowing the full `ModemPreset` list). This happens for a handful
-   of `RegionCode` enum values that have no firmware band table entry (today: `EU_874`,
-   `EU_917`, `ITU1_70CM`, `ITU2_70CM`, `ITU3_70CM`).
-
-2. **Absent message ⇒ no constraint.** Firmware older than 2.8 never sends `region_presets`.
-   New clients **must** tolerate the message being absent entirely and keep their existing
-   (unconstrained) behavior. Do not block the config screen waiting for it.
-
-3. **`default_preset`** is always a member of that group's `presets`. Use it to pre-select a
-   preset when the user switches to a region whose valid set does not include the currently
-   selected preset (instead of leaving an illegal selection or guessing).
-
-4. **`licensed_only`** marks ham/amateur bands. Surface a warning or gate (the firmware also
-   requires the operator's `is_licensed` flag for these regions; coordinate the two so the
-   user isn't allowed to pick a licensed band without acknowledging licensing).
-
-5. **EU region auto-swap caveat.** The firmware treats the EU sibling regions
-   (`EU_868` / `EU_866` / `EU_N_868`) specially: if the user is in one of them and selects a
-   preset that belongs to a sibling's list, the firmware **swaps the region** rather than
-   rejecting the preset. Consequence for clients: **do not assume the region is immutable
-   across a preset change** — after an admin config write, re-read the resulting
-   `LoRaConfig` and reflect the (possibly changed) region back into the UI.
-
-6. **Use it as a UI guard, not a validator of truth.** The firmware still validates/clamps
-   on its own. The map exists to prevent the user from _selecting_ an illegal combo; it is
-   not a security or correctness boundary.
-
----
-
-## 6. UI/UX recommendations
-
-- In the LoRa config screen, when a region is selected, **filter/enable the modem-preset
-  picker to that region's `presets`** (when `use_preset`/`use_modem_preset` is on).
-- If the current preset is not in the newly selected region's set, switch the selection to
-  that region's `default_preset`.
-- Show a **licensed badge / confirmation** for regions where `licensed_only == true`.
-- If a region is absent from the map (rule §5.1) or the whole message is absent (§5.2),
-  render the full preset list as before — never show an empty picker.
-
----
-
-## 7. Forward / backward compatibility
-
-- **Old clients, new firmware:** an unknown `FromRadio` oneof variant (field 19) is ignored
-  by protobuf/nanopb decoders; the relative ordering of the known messages is unchanged, so
-  existing apps are unaffected.
-- **New clients, old firmware:** message simply never arrives → treat as "no constraints"
-  (§5.2).
-- **Enum growth:** new `RegionCode`/`ModemPreset` values may appear over time. Decoders
-  should pass through unknown enum values rather than crashing; an unknown region in
-  `region_groups` is harmless (the client just won't have a localized name for it).
-
----
-
-## 8. Platform notes
-
-> Verified against the `main` branch of each repo. Both have been refactored away from
-> older layouts; re-pin file paths against a specific commit if you need them durable.
-
-### 8.1 Android — `meshtastic/Meshtastic-Android` (Kotlin / Compose, KMP)
-
-- **Protobufs are a published Maven artifact, _not_ a submodule.** Declared in
-  `gradle/libs.versions.toml` (`org.meshtastic:protobufs`, currently `2.7.25`); generated
-  package is **`org.meshtastic.proto`**. **A `region_presets`-aware build requires a new
-  published `org.meshtastic:protobufs` release**, then bumping that one version string.
-- **The protobufs are Wire-generated**, so the `FromRadio` oneof is **not** a
-  `payloadVariantCase` enum — each arm is a **nullable field**. Handle the new variant in
-  `FromRadioPacketHandlerImpl.handleFromRadio(...)`
-  (`core/data/.../manager/FromRadioPacketHandlerImpl.kt`) by adding a
-  `regionPresets != null -> …` arm to the existing `when { … }`, delegating to a handler
-  (mirror `handleLocalMetadata` / `handleConfigComplete`).
-- **State holder:** expose the decoded map from `RadioConfigRepository` /
-  `RadioConfigRepositoryImpl` as a `Flow` (mirroring `localConfigFlow`/`channelSetFlow`),
-  consumed by `feature/settings/.../radio/RadioConfigViewModel.kt`.
-- **UI:** the region & preset dropdowns are `DropDownPreference`s in
-  `feature/settings/.../radio/component/LoRaConfigItemList.kt` (public composable
-  `LoRaConfigScreen`). Gate/filter the `ChannelOption` (preset) dropdown by the selected
-  `RegionInfo`'s entry in the map.
-
-### 8.2 Apple — `meshtastic/Meshtastic-Apple` (Swift / SwiftUI)
-
-- **Protobufs are vendored** into a local Swift package `MeshtasticProtobufs`
-  (`MeshtasticProtobufs/Sources/meshtastic/*.pb.swift`), generated from the `protobufs` git
-  submodule via `scripts/gen_protos.sh`. **To get field 19:** advance the `protobufs`
-  submodule, run `scripts/gen_protos.sh`, commit the regenerated `.pb.swift` + submodule
-  pointer. (No published-artifact dependency — Apple can regenerate from any commit.)
-- **Dispatch:** `AccessoryManager.processFromRadio(_:)`
-  (`Meshtastic/Accessory/Accessory Manager/AccessoryManager.swift`) is a real
-  `switch decodedInfo.payloadVariant { … }` — add a `.regionPresets` case, with the handler
-  in `AccessoryManager+FromRadio.swift` (mirror `handleConfig` / `handleMetadata`).
-- **Persistence:** config is **SwiftData** (`@Model` entities), upserted via
-  `MeshPackets`/`UpdateSwiftData.swift`. Store the decoded map (e.g. on a settings/connection
-  model) so the LoRa view can read it.
-- **UI:** `Meshtastic/Views/Settings/Config/LoRaConfig.swift` (`struct LoRaConfig: View`)
-  has the `Picker("Region", …)` (`RegionCodes.userSelectable`) and `Picker("Presets", …)`
-  (`ModemPresets.userSelectable`, gated on `usePreset`). Filter the presets picker by the
-  selected region's entry. Enums live in `Meshtastic/Enums/LoraConfigEnums.swift`.
-
-### 8.3 Other clients
-
-- **python (`meshtastic` / Meshtastic-python)** and **web** consume the published protobufs;
-  they will see `region_presets` once their protobuf dependency includes field 19, and can
-  ignore it until then (it decodes as an unknown field).
-
----
-
-## 9. Reference payload (current firmware table)
-
-For decoder unit tests. With the 2.8 region table, the firmware emits **6 groups**. Group
-indices are assigned in region-table order (first region to use a profile creates its group),
-so they are stable as listed here:
-
-| group_index             | default_preset | licensed_only | presets                                                                                                        |
-| ----------------------- | -------------- | ------------- | -------------------------------------------------------------------------------------------------------------- |
-| 0 (standard)            | `LONG_FAST`    | false         | LONG_FAST, LONG_SLOW, MEDIUM_SLOW, MEDIUM_FAST, SHORT_SLOW, SHORT_FAST, LONG_MODERATE, SHORT_TURBO, LONG_TURBO |
-| 1 (EU 868)              | `LONG_FAST`    | false         | LONG_FAST, LONG_SLOW, MEDIUM_SLOW, MEDIUM_FAST, SHORT_SLOW, SHORT_FAST, LONG_MODERATE                          |
-| 2 (EU 866 SRD / "lite") | `LITE_FAST`    | false         | LITE_FAST, LITE_SLOW                                                                                           |
-| 3 (EU 868 narrow)       | `NARROW_SLOW`  | false         | NARROW_FAST, NARROW_SLOW                                                                                       |
-| 4 (ham 20 kHz)          | `TINY_FAST`    | **true**      | TINY_FAST, TINY_SLOW                                                                                           |
-| 5 (ham 100 kHz)         | `NARROW_SLOW`  | **true**      | NARROW_FAST, NARROW_SLOW                                                                                       |
-
-`region_groups` (region → group_index):
-
-| group | regions                                                                                                                                                               |
-| ----- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| 0     | US, EU_433, CN, JP, ANZ, ANZ_433, RU, KR, TW, IN, NZ_865, TH, UA_433, UA_868, MY_433, MY_919, SG_923, PH_433, PH_868, PH_915, KZ_433, KZ_863, NP_865, BR_902, LORA_24 |
-| 1     | EU_868                                                                                                                                                                |
-| 2     | EU_866                                                                                                                                                                |
-| 3     | EU_N_868                                                                                                                                                              |
-| 4     | ITU1_2M, ITU2_2M, ITU3_2M                                                                                                                                             |
-| 5     | ITU2_125CM                                                                                                                                                            |
-
-> Note groups **3** and **5** carry the same preset list (NARROW\_\*) but are distinct groups
-> because they differ in `licensed_only`. Decoders must key on the group, not on the preset
-> list, to preserve the licensing flag.
->
-> Regions **absent** from the table (no constraint info; see §5.1): `EU_874`, `EU_917`,
-> `ITU1_70CM`, `ITU2_70CM`, `ITU3_70CM`.
-
-This table is generated from the firmware's region table at runtime; treat the firmware as
-authoritative and these values as the expected snapshot for the 2.8 table.

docs/nexthop-routing-reliability.md

@@ -1,456 +0,0 @@
-# NextHop direct-message reliability on dense meshes — findings & plan
-
-**Status:** Implemented — mitigations and tests in `PR3-tmm-nexthop`
-**Date:** 2026-06-13
-**Area:** `src/mesh` router stack (`NextHopRouter`, `ReliableRouter`, `FloodingRouter`, `Router`, `NodeDB`, `PacketHistory`)
-**Constraint:** No over-the-air / wire-format changes — `next_hop` and `relay_node` stay 1 byte, no `PacketHeader` changes, no breaking protobuf changes. All new state is RAM-only.
-
-This document captures the analysis and the proposed mitigations so the work can be
-continued on this branch by anyone. It is intentionally code-grounded (file:line
-references throughout) and standalone — you should not need the original investigation
-context to pick it up.
-
----
-
-## TL;DR
-
-NextHop routing for direct messages (DMs) is unreliable on dense meshes. The headline
-cause is the **birthday problem**: `next_hop` and `relay_node` are each a single byte
-(the last byte of a 32-bit node number), so on a mesh of N nodes the probability that
-two share the same byte hits ~50% at **~19 nodes** and is near-certain by 50–100. But
-there are **other, equally important issues**: that single byte is trusted blindly at
-five different code sites, learned routes **never decay**, routes are learned from the
-**reverse (ACK) path** (asymmetric-link hazard), and collision-driven spurious
-rebroadcasts **amplify congestion** exactly when the mesh is busy.
-
-Because we can't widen the on-wire field, the fix is **interpretation-side** ("don't
-trust a byte that doesn't map to a unique reachable neighbor — flood instead") plus
-**recovery-side** ("decay stale/failing routes so they get re-discovered"). Four
-mitigations, M1–M4, all RAM-only. The net behavioral change: on dense/mobile meshes a
-DM that today silently misroutes or black-holes instead falls back to managed flooding
-(which still delivers) and re-learns a fresh route quickly. Sparse-mesh happy paths are
-unchanged.
-
----
-
-## How NextHop routing works today (mechanics)
-
-Inheritance chain: `Router` → `FloodingRouter` → `NextHopRouter` → `ReliableRouter`.
-
-**The single-byte identifiers.** Both routing bytes come from one helper:
-
-```cpp
-// src/mesh/NodeDB.h:255
-uint8_t getLastByteOfNodeNum(NodeNum num) { return (uint8_t)((num & 0xFF) ? (num & 0xFF) : 0xFF); }
-```
-
-It projects a 32-bit node number onto 255 values (`0x00` is remapped to `0xFF` so it
-never collides with the `0`-valued sentinels `NO_NEXT_HOP_PREFERENCE` / `NO_RELAY_NODE`,
-`src/mesh/MeshTypes.h:44-46`). `next_hop` and `relay_node` in the packet header are
-`uint8_t` (`src/mesh/mesh.pb.h`, comments "Last byte of the node number…"). The learned
-route stored per destination, `meshtastic_NodeInfoLite::next_hop`, is also a single byte
-(`src/mesh/generated/meshtastic/deviceonly.pb.h:83`).
-
-**Sending a DM** — `NextHopRouter::send` (`src/mesh/NextHopRouter.cpp:23`):
-
-1. `p->relay_node = getLastByteOfNodeNum(getNodeNum())` (mark ourselves as relayer).
-2. `p->next_hop = getNextHop(p->to, p->relay_node)` (`src/mesh/NextHopRouter.cpp:192`):
-   look up `nodeDB->getMeshNode(to)->next_hop`; return it unless it equals the relayer
-   byte; otherwise `NO_NEXT_HOP_PREFERENCE` (→ flood).
-
-**Relaying** — `NextHopRouter::perhapsRebroadcast` (`src/mesh/NextHopRouter.cpp:133`):
-rebroadcast iff `next_hop == NO_NEXT_HOP_PREFERENCE` (flood) **or**
-`next_hop == getLastByteOfNodeNum(getNodeNum())` (we are the addressed next hop)
-(`:147`). Each node only ever compares against **its own** byte.
-
-**Learning** — `NextHopRouter::sniffReceived` (`src/mesh/NextHopRouter.cpp:89`): on an
-ACK/reply (`request_id`/`reply_id` set), if the relayer of the ACK was also a relayer of
-the original packet (validated via `PacketHistory::checkRelayers`), set
-`origTx->next_hop = p->relay_node` (`:114`). I.e. the **forward** next-hop is learned
-from the **reverse** path's relayer.
-
-**Retransmission / fallback** — `NextHopRouter::doRetransmissions`
-(`src/mesh/NextHopRouter.cpp:284`). Budgets: `NUM_RELIABLE_RETX=3` (originator: initial
-
-- 2 retries), `NUM_INTERMEDIATE_RETX=2` (relayer: 1 retry). On the **last** retry
-  (`numRetransmissions==1`) it resets `next_hop` to `NO_NEXT_HOP_PREFERENCE` on the packet
-  **and** clears `sentTo->next_hop` in NodeDB, then floods (`:313-321`). Retransmit timing
-  comes from `iface->getRetransmissionMsec`, whose contention window **grows with channel
-  utilization** (`src/mesh/RadioInterface.cpp` `getTxDelayMsec`/`getTxDelayMsecWeighted`).
-
-**Dedup / relayer history** — `PacketHistory` (`src/mesh/PacketHistory.cpp`): a bounded
-ring (`PACKETHISTORY_MAX = max(MAX_NUM_NODES*2, 100)`, 20 B/record) keyed by
-`(sender,id)`, tracking up to `NUM_RELAYERS=6` relayer **bytes** per packet in
-`relayed_by[]`. `wasRelayer` (`:490`) and `checkRelayers` (`:517`) match bytes against
-that array.
-
----
-
-## Root-cause analysis
-
-### 1. The single byte is trusted blindly at five sites (the birthday problem)
-
-| #   | Site                             | File:line                   | Failure on collision                                                                                                      |
-| --- | -------------------------------- | --------------------------- | ------------------------------------------------------------------------------------------------------------------------- |
-| 1   | Rebroadcast self-check           | `NextHopRouter.cpp:147`     | A remote "impostor" node sharing the intended next-hop's byte also rebroadcasts → wasted airtime / congestion.            |
-| 2   | Route learning                   | `NextHopRouter.cpp:111-114` | Stores an ambiguous byte as the route; later resolves to the wrong physical node.                                         |
-| 3   | Relayer validation               | `PacketHistory.cpp:490-538` | `wasRelayer(byte)` returns true for the wrong node → mis-validated ACK / mis-learn.                                       |
-| 4   | Favorite-router hop preservation | `Router.cpp:120-145`        | **First** NodeDB node whose last byte matches wins — non-deterministic; can preserve hops for the wrong relay (hop leak). |
-| 5   | Send-path lookup                 | `NextHopRouter.cpp:192-207` | Emits a byte that may address the wrong node; no check it still maps to a reachable neighbor.                             |
-
-Collision math (uniform last byte over 255 buckets): P(collision) ≈ 50% at ~19 nodes,
-
-> 99% by ~75 nodes. Dense meshes are squarely in the "always colliding" regime.
-
-### 2. Stale routes never decay
-
-The learned `next_hop` byte is cleared only on the **current DM's** last retry
-(`NextHopRouter.cpp:313-321`). A route learned hours ago that has since gone dead is
-still trusted on the **next** DM's first attempt — which on a congested mesh is also the
-slowest attempt. Result: silent black-hole at a dead hop until the retransmission budget
-drains, then a late flood. Intermediate nodes hold stale routes indefinitely.
-
-### 3. Reverse-path (asymmetric-link) learning
-
-`origTx->next_hop` is learned from the ACK's relayer (`NextHopRouter.cpp:110-114`) — the
-**reverse** direction. RF links are frequently asymmetric, so the best reverse relay can
-be a poor forward relay. Worse, the next reverse ACK immediately re-learns the same bad
-hop, so the route **flaps** back to the bad value even after a failure reset.
-
-### 4. Congestion amplification
-
-Collision-driven impostor rebroadcasts (issue 1) add airtime; the contention window
-grows with channel utilization, so retransmit intervals **lengthen** exactly when the
-mesh is busy. The 3-try reliable budget can then expire before delivery. On dense
-meshes, efficiency _is_ reliability.
-
-### Note: pubkey-derived node numbers (develop / 2.8) — does not change the plan
-
-develop derives the node number from the public key:
-`my_node_num = crc32Buffer(public_key)` (`src/mesh/NodeDB.cpp:481`), re-derived on key
-change in `createNewIdentity()` (`src/mesh/NodeDB.cpp:3113`). This **reinforces** the
-plan rather than changing it:
-
-- **Birthday problem unchanged and now textbook-exact.** CRC32 mixes well → the last
-  byte is uniformly distributed over 256 values. Derivation adds no wire bits.
-- **Node numbers are now immutable / identity-bound.** Pre-2.8 `pickNewNodeNum()` could
-  renumber a node to dodge a conflict; now the number is fixed by the key, so a last-byte
-  collision **cannot be resolved operationally by renumbering** → M1/M2/M3 become _more_
-  necessary.
-- **Resolver gets cleaner inputs.** Stable node numbers keep a learned byte bound to one
-  identity (good for M3 freshness). `createNewIdentity()` retires the old entry by marking
-  it **ignored** and clearing its pubkey (`src/mesh/NodeDB.cpp:3123-3125`), which M1's
-  candidate gate already skips — so key rotation can't pollute resolution.
-- **No wire-free disambiguation unlocked.** A receiver still gets only 1 byte and cannot
-  recover which full node number a colliding value meant — so "detect ambiguity → flood"
-  remains the correct strategy.
-
----
-
-## Proposed mitigations
-
-Key insight for all of M1/M2: **a 1-byte ID only needs to be unique among a node's
-direct neighbors / plausible relays, not the whole mesh.** That candidate set is small
-(typically 5–15), so a byte usually resolves unambiguously there; when it doesn't, fall
-back to the _safe_ behavior (flood / decrement / don't-learn).
-
-### M1 — Ambiguity-aware last-byte resolution (new NodeDB primitive)
-
-New types + methods in `src/mesh/NodeDB.h` (near line 255) / `src/mesh/NodeDB.cpp`
-(near `getMeshNode`, ~2936):
-
-```cpp
-enum class LastByteResolution : uint8_t { None, Unique, Ambiguous };
-struct ResolvedNode { LastByteResolution status = LastByteResolution::None; NodeNum num = 0; };
-
-// Resolve a single on-wire last-byte to a unique full NodeNum among relevant candidates.
-ResolvedNode resolveLastByte(uint8_t lastByte, bool requireDirectNeighbor);
-// Convenience: true iff exactly one relevant candidate (Ambiguous and None both -> false = SAFE).
-bool resolveUniqueLastByte(uint8_t lastByte, bool requireDirectNeighbor, NodeNum *outNum = nullptr);
-```
-
-- **One linear pass** over `meshNodes`, reusing `getNumMeshNodes()`/`getMeshNodeByIndex()`,
-  the bitfield helpers (`nodeInfoLiteIsFavorite/HasUser/IsIgnored`), `sinceLastSeen()`,
-  and `getLastByteOfNodeNum()`. **Early-exit** on the 2nd match (return `Ambiguous`).
-- **Guard:** `if (lastByte == 0) return {None, 0};` (covers `NO_RELAY_NODE` / MQTT-invalid).
-- **Candidate gate** (skip): `num == getNodeNum()` (never resolve to ourselves), `num == 0`,
-  `num == NODENUM_BROADCAST`, `nodeInfoLiteIsIgnored`. Then match
-  `getLastByteOfNodeNum(node->num) == lastByte` (cheapest test last, mirroring `Router.cpp:119`).
-- **Relevance gate:**
-  - `requireDirectNeighbor == true` (strict, for SEND): `has_hops_away && hops_away == 0`
-    **and** `sinceLastSeen(node) < NEXTHOP_NEIGHBOR_FRESH_SECS`.
-  - `requireDirectNeighbor == false` (lenient, for learn / hop-preserve): accept if direct
-    neighbor **or** `nodeInfoLiteIsFavorite` **or** role ∈ {ROUTER, ROUTER_LATE, CLIENT_BASE}.
-- **No tie-break.** A collision must return `Ambiguous` — picking "best SNR" would
-  resurrect the silent-misroute bug. (Deliberate non-goal; document in code.)
-
-New constant in `src/mesh/MeshTypes.h` (near line 44):
-`#define NEXTHOP_NEIGHBOR_FRESH_SECS (60 * 60 * 2)` (mirrors `NUM_ONLINE_SECS`).
-
-### M2 — Only route on bytes that resolve to a unique, reachable neighbor
-
-In `getNextHop` (`src/mesh/NextHopRouter.cpp:192-207`), after the existing split-horizon
-check (`node->next_hop != relay_node`), require the stored byte to resolve to a **unique,
-currently-fresh direct neighbor**; else flood:
-
-```cpp
-if (node->next_hop != relay_node) {
-    ResolvedNode r = nodeDB->resolveLastByte(node->next_hop, /*requireDirectNeighbor=*/true);
-    if (r.status == LastByteResolution::Unique) return node->next_hop;
-    LOG_WARN("Next hop 0x%x for 0x%x %s -> flood", node->next_hop, to,
-             r.status == LastByteResolution::Ambiguous ? "ambiguous among neighbors" : "no longer a neighbor");
-    return std::nullopt;
-}
-```
-
-This self-heals when a neighbor goes away (unicast-into-a-void becomes a flood). It
-applies to originating, relaying, and retrying, since all route through `getNextHop`.
-
-Apply M1's safe fallback at the other sites:
-
-- **Learning** (`NextHopRouter.cpp:111-114`): gate `origTx->next_hop = p->relay_node` on
-  `resolveUniqueLastByte(p->relay_node, /*direct=*/false)`. Ambiguous/unknown → don't
-  learn (leave route unset → flood).
-- **Favorite-router preservation** (`Router.cpp:120-145`): replace the "first match wins"
-  loop with `resolveUniqueLastByte(p->relay_node, /*direct=*/false)` + a re-check that the
-  resolved node is favorite/has_user/router. Ambiguous/none/not-favorite → **decrement**
-  (safe). Net: removes one full DB scan, adds one resolver scan (wash).
-
-**Left unchanged, by design (document why in code):**
-
-- **Site 1** rebroadcast self-check (`NextHopRouter.cpp:147`) and self-identity checks
-  (`ReliableRouter.cpp:127`): a node matches its **own** byte — no DB resolution helps. A
-  remote impostor sharing the intended next-hop's byte will still rebroadcast. M1/M2
-  shrink the blast radius by reducing how often an ambiguous byte is ever stored or
-  originated; a true fix needs a wider field (out of scope). **This is the one residual
-  the plan cannot fully close.**
-- **Site 3** `wasRelayer`/`checkRelayers` (`PacketHistory.cpp:490-538`): intentionally
-  byte-domain (both sides are on-wire bytes); the consumer (learning) is now hardened.
-  Add a one-line comment; do not change.
-
-### M3 — Route freshness / failure memory (RAM table on NextHopRouter)
-
-A bounded, LRU-evicted table keyed by destination, mirroring `PacketHistory`'s
-reuse-oldest discipline (not an unbounded map) to cap RAM.
-
-`src/mesh/NextHopRouter.h` (near `pending`, line 99):
-
-```cpp
-struct RouteHealth {
-    NodeNum dest = 0;                  // 0 == empty slot
-    uint32_t learnedAtMsec = 0;        // millis() at last (re)learn; rollover-aware
-    uint8_t consecutiveFailures = 0;
-    uint8_t lastNextHop = NO_NEXT_HOP_PREFERENCE; // byte this health refers to
-};
-static constexpr uint8_t ROUTE_HEALTH_MAX = 32;   // ~384B; drop to 16 if RAM-tight
-RouteHealth routeHealth[ROUTE_HEALTH_MAX] = {};
-// Helpers take `now` (pure/testable): findRouteHealth, getOrAllocRouteHealth,
-// noteRouteLearned, noteRouteSuccess, noteRouteFailure, isRouteStale, clearRouteHealth
-```
-
-Policy:
-
-| Constant                  | Value  | Rationale                                                                                                                                              |
-| ------------------------- | ------ | ------------------------------------------------------------------------------------------------------------------------------------------------------ |
-| `ROUTE_TTL_MSEC`          | 30 min | Survives a normal conversation; re-discovers a moved node within a telemetry interval.                                                                 |
-| `ROUTE_FAILURE_THRESHOLD` | 3      | 1–2 consecutive failures are transient LoRa collisions; 3 to the same hop = dead. Accumulates **across** DMs (independent of the per-DM 3-try budget). |
-
-`isRouteStale(h, now)` = `(now - h.learnedAtMsec) >= ROUTE_TTL_MSEC || h.consecutiveFailures >= ROUTE_FAILURE_THRESHOLD`.
-All age math uses **unsigned subtraction** (rollover-safe, matching
-`PacketHistory.cpp:364`); treat `learnedAtMsec == 0` as "set now".
-
-Wiring (as built — `src/mesh/NextHopRouter.cpp`, `src/mesh/ReliableRouter.cpp`):
-
-- `getNextHop`: if a health record matches the stored byte and `isRouteStale`, clear
-  `node->next_hop` (NodeDB) **and** `clearRouteHealth`, return `nullopt` (flood). No
-  record yet (cold path, first DM after boot) → trust NodeDB, but the M2 strict-neighbor
-  gate still applies.
-- `sniffReceived` learn: gate the write through `resolveUniqueLastByte` (M2), then
-  `noteRouteLearned(p->from, p->relay_node, millis())` — resets `consecutiveFailures`
-  **only if the hop changed** (anti-flap for asymmetric re-learn); otherwise just refreshes
-  `learnedAtMsec`. (No success signal is taken on the intermediate reverse-pass: an ACK
-  merely passing through us is not proof that _we_ delivered, and resetting failures there
-  would reintroduce the asymmetric flap.)
-- `doRetransmissions`: on the last-retransmission branch (`numRetransmissions == 1`, the
-  point a directed delivery has gone un-ACKed for both originator and intermediate) →
-  `noteRouteFailure(to)`, then the existing NodeDB `next_hop` reset + flood. We deliberately
-  do **not** `clearRouteHealth` here: keeping the record is what lets the failure count
-  accumulate across DMs so a flapping reverse-path-relearned dead hop eventually ages out.
-- `ReliableRouter::sniffReceived` ACK path → `noteRouteSuccess(getFrom(p), millis())`
-  (an end-to-end ACK addressed to us is genuine forward-delivery proof; clears failures and
-  refreshes freshness). `noteRouteSuccess`/`noteRouteFailure` are no-ops when no record
-  exists, so flood-only destinations never pollute the table.
-
-**Reconciliation (no double-handling):** `doRetransmissions` owns _in-flight_ failure of
-the current DM (reset NodeDB `next_hop` + flood, and bump the cross-DM failure counter);
-`getNextHop` owns _between-DM_ staleness (TTL or failure-threshold → flood + clear). The
-only place that erases a health record is the `getNextHop` decay path; the retransmission
-path leaves it intact so the counter survives a reverse-path re-learn.
-
-### M4 — Earlier flood for unverified routes (gated, off by default)
-
-Compile-gated so healthy sparse meshes are untouched. **Default is off** — the define
-lives in `NextHopRouter.h` and must be flipped to measure:
-`#define NEXTHOP_EARLY_FLOOD_ON_UNVERIFIED 1`.
-
-In `doRetransmissions`, the directed-retry `else` branch: if the route is **not verified**
-(`!findRouteHealth(to) || consecutiveFailures > 0 || isRouteStale`), reset `next_hop` and
-flood on this attempt instead of spending another directed try. A **verified** route
-(record present, `consecutiveFailures == 0`, within TTL — i.e. recently ACKed) takes the
-unchanged directed-retry path, so the sparse-mesh happy path is untouched. Trade-off:
-airtime ↔ latency; the gate ensures we never pay the flood cost on a proven route, only on
-one we already distrust. Off by default precisely so it can be A/B-measured on the
-simulator before broad enable.
-
----
-
-## Files to modify
-
-| File                                        | Change                                                                                                                                               |
-| ------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------- |
-| `src/mesh/MeshTypes.h`                      | `NEXTHOP_NEIGHBOR_FRESH_SECS`, `ROUTE_TTL_MSEC`, `ROUTE_FAILURE_THRESHOLD`, `NEXTHOP_EARLY_FLOOD_ON_UNVERIFIED`                                      |
-| `src/mesh/NodeDB.h` / `src/mesh/NodeDB.cpp` | `LastByteResolution`, `ResolvedNode`, `resolveLastByte`, `resolveUniqueLastByte`                                                                     |
-| `src/mesh/NextHopRouter.h`                  | `RouteHealth` + array + helpers; `#ifdef PIO_UNIT_TESTING public:` for helpers and `getNextHop`                                                      |
-| `src/mesh/NextHopRouter.cpp`                | `getNextHop` (M2 gate + M3 decay); `sniffReceived` (learn gate + health seed + success); `doRetransmissions` (failure counting + M4); comment site 1 |
-| `src/mesh/Router.cpp`                       | `shouldDecrementHopLimit` → resolver + favorite/router re-check                                                                                      |
-| `src/mesh/ReliableRouter.cpp`               | ACK path → `noteRouteSuccess`                                                                                                                        |
-| `test/test_nexthop_routing/test_main.cpp`   | **new** unit suite (auto-built under `[env:native]`)                                                                                                 |
-
-**Reuse, don't reinvent:** `getLastByteOfNodeNum`, `sinceLastSeen`, the bitfield helpers,
-`getMeshNodeByIndex`/`getNumMeshNodes`, PacketHistory's reuse-oldest eviction shape, and
-`MockNodeDB::addTestNode` (from `test/test_hop_scaling/test_main.cpp`).
-
----
-
-## Edge cases
-
-- **`0x00`↔`0xFF` projection:** the resolver compares via `getLastByteOfNodeNum` on both
-  sides, so a `…00` node and a `…FF` node correctly collide on `0xFF` → `Ambiguous`. Test
-  explicitly.
-- **MQTT packets:** `relay_node`/`next_hop` are forced invalid when `hop_start == 0`
-  (`src/mesh/RadioLibInterface.cpp:603-605`) → byte 0 → resolver `None` → don't learn
-  (correct).
-- **`has_hops_away == false`** nodes are excluded from the strict gate (never fabricate a
-  Unique neighbor for M2); admitted to the lenient gate only via favorite/router role.
-  Safe; self-corrects once `hops_away` is learned.
-- **Self / broadcast:** the resolver skips `getNodeNum()` and `NODENUM_BROADCAST`;
-  `getNextHop` already early-returns for broadcast.
-- **Perf:** M2 adds one O(N) resolver scan per directed send/relay (early-exit on the 2nd
-  match), cheaper than the crypto already on that path; site-4 is a wash. If ever hot, a
-  future 256-entry last-byte index is the optimization (not now — RAM).
-
----
-
-## Verification (all tiers)
-
-### 1. Native unit tests — new `test/test_nexthop_routing/test_main.cpp`
-
-`pio test -e native -f test_nexthop_routing`; on macOS `./bin/test-native-docker.sh -f test_nexthop_routing`.
-Design the RouteHealth helpers to take `now` as a parameter so the 30-min TTL logic is
-testable without a clock mock.
-
-- **Resolver:** None / Unique / **Ambiguous (birthday collision)** / strict-excludes-stale /
-  strict-excludes-far / lenient-includes-favorite-router / lenient-collision / skips-self /
-  skips-ignored / **`0x00`↔`0xFF` collision** / early-exit.
-- **`getNextHop`:** unique→byte, **ambiguous→nullopt**, stale-neighbor→nullopt,
-  split-horizon (relay==next_hop)→nullopt, broadcast→nullopt.
-- **RouteHealth:** TTL boundary, **rollover** (learn near `0xFFFFFFFF`, check after wrap),
-  failure threshold, success-resets, **re-learn-same-hop keeps fails (anti-flap)**,
-  re-learn-new-hop resets, LRU eviction bound, clear.
-- **Site-4:** preserve on unique favorite router; **decrement on two colliding favorites**;
-  decrement when the resolved node is not a favorite.
-- **Sparse-mesh regression:** all-distinct last bytes → every resolve Unique, `getNextHop`
-  returns the stored byte unchanged (proves no happy-path change).
-- Re-run `test_packet_history` and `test_hop_scaling` for no regression.
-
-### 2. portduino SimRadio simulator
-
-`pio run -e native && ./bin/test-simulator.sh`. Best vehicle for the **intermediate-node**
-path the 2-device bench can't reach. Line topology A — B — C: establish A→C (B learns a
-directed route), stop B relaying that dest, confirm A re-discovers via flood within
-`ROUTE_FAILURE_THRESHOLD` and that B's `noteRouteFailure`/`clearRouteHealth` fires (visible
-via the `LOG_INFO "Route to … stale"` / "Resetting next hop" lines). Use this to A/B M4
-(attempts-to-delivery, total airtime).
-
-### 3. Hardware via meshtastic MCP (auto-detect; 3+ devices for a real hop)
-
-- `mcp-server/tests/mesh/test_nexthop_multihop_recovery.py` — **the multi-hop validator
-  for this work** (added on this branch). Self-discovers an A — relay — C line, asserts a
-  directed DM is delivered across the relay (next_hop + M1/M2/M3 engaged), and asserts
-  delivery recovers after the relay is power-cycled (M3). Skips unless the bench is a true
-  multi-hop line (≥3 roles via `--hub-profile`, endpoints out of direct RF range).
-- `mcp-server/tests/mesh/test_direct_with_ack.py` — happy-path regression: a fresh/unique
-  route still delivers a want_ack DM on the first/second try (M4's gate must keep this
-  green).
-- `mcp-server/tests/mesh/test_peer_offline_recovery.py` — 2-device recovery validator: peer
-  off mid-conversation then back. Must stay green and ideally recover in fewer attempts.
-
-### 4. Build / format sanity
-
-native-macos **and** Docker both ways; trunk clang-format@16.0.3; a release `pio run` to
-confirm the `#ifdef PIO_UNIT_TESTING` visibility widening does **not** leak into
-production; sanity-check RAM headroom on the smallest nRF52 build for the ~384 B table.
-
----
-
-## Verification status (as built on `nexthop-redux`)
-
-| Tier                             | What ran                                                                            | Result              |
-| -------------------------------- | ----------------------------------------------------------------------------------- | ------------------- |
-| Unit (native-macos)              | `test_nexthop_routing` (31 cases)                                                   | ✅ 31/31            |
-| Unit (Docker / Linux, CI parity) | `test_nexthop_routing`                                                              | ✅ 31/31            |
-| Regression                       | `test_packet_history`, `test_hop_scaling`, `test_mqtt`, `test_traffic_management`   | ✅ 105/105          |
-| Build                            | `pio run -e native-macos` (M4 off) and with `-DNEXTHOP_EARLY_FLOOD_ON_UNVERIFIED=1` | ✅ both link        |
-| Format                           | trunk `clang-format@16.0.3`                                                         | ✅ no issues        |
-| Simulator (CI `simulator-tests`) | `meshtasticd -s` + `meshtastic.test.testSimulator()` on native-macos                | ✅ exit 0, no crash |
-
-**Pending (environment-blocked, not yet run):**
-
-- **Multi-hop A–B–C recovery sim** — the `simulator/` broker hub is **not git-tracked**
-  (only stale local `.pyc`), and two `meshtasticd -s` instances can't hear each other
-  without it. The intermediate-node failure-count path and the M4 A/B therefore have unit
-  coverage of their logic but no end-to-end multi-node run yet.
-- **Hardware / multi-hop tier** — a committable bench test now exists:
-  `mcp-server/tests/mesh/test_nexthop_multihop_recovery.py`. It self-discovers a real
-  multi-hop pair (A — relay — C), asserts a directed DM is delivered across the relay, and
-  asserts delivery recovers after the relay is power-cycled (the M3 path). It
-  `pytest.skip`s cleanly unless the bench is a true line with endpoints out of direct RF
-  range (≥3 roles via `--hub-profile`), so it's safe to commit and only asserts when the
-  NextHop path is genuinely exercised. Collected + verified to skip without hardware;
-  not yet run on a bench. `test_direct_with_ack.py` / `test_peer_offline_recovery.py`
-  remain the 2-device happy-path/recovery regressions.
-
----
-
-## Risks & limitations
-
-- **Site-1 impostor rebroadcast** is unfixable without a wider field — documented; M1/M2
-  only shrink its frequency.
-- **Dense meshes flood DMs more often** — intended (a flooded DM arrives; a mis-unicast one
-  black-holes). Call out in the PR so reviewers expect a slightly higher DM flood rate on
-  very dense meshes.
-- **M4 airtime** if the gate is too loose → default conservative + compile-gated +
-  simulator A/B before broad enable.
-- **RAM** ~384 B (32 slots); 16 slots (~192 B) with graceful LRU degradation if tight.
-- **Asymmetric flap** not fully closed (a _new_ bad hop resets the counter); the TTL
-  backstop bounds it. Per-hop failure history is future work (more RAM).
-
----
-
-## How to continue this work (commit sequencing)
-
-Each step is independently testable; land them as separate commits.
-
-1. **M1 resolver + unit tests** — `NodeDB` only; no behavior change until wired. Lands the
-   `resolveLastByte`/`resolveUniqueLastByte` primitive and its full unit-test matrix.
-2. **M2 + wiring + tests** — `getNextHop` strict gate, learning gate, favorite-router
-   preservation rewrite. Adds the `getNextHop` and site-4 tests.
-3. **M3 health table + decay + tests** — RAM `RouteHealth` table, decay-on-read, failure/
-   success accounting, reconciliation with the existing last-retry reset. Adds the
-   route-health unit tests and the simulator recovery check.
-4. **M4 gated tuning** — early-flood-on-unverified behind the compile flag; simulator A/B
-   and hardware regression.
-
-Reference plan (with the same content) was developed at
-`~/.claude/plans/nexthop-routing-for-direct-lexical-shell.md` on the author's machine; this
-in-repo doc is the canonical handoff copy.

extra_scripts/nrf52_lto.py

@@ -80,19 +80,14 @@ env.AddBuildMiddleware(_no_lto)
 # the weak `b .` Default_Handler stub -- i.e. LTO (or a deps bump, or a new ISR-owning library
 # that nobody added to LIB_ISR) silently dropped it. A dropped handler hangs the chip the
 # instant that IRQ fires; this turns a field hang into a red build. CI builds every nrf52840
-# target, so this runs on every PR automatically. If a board deliberately stops using one of
-# these, edit the tuples on purpose.
+# target, so this runs on every PR automatically. All five are used by every nrf52840
+# Meshtastic build; if a board deliberately stops using one, edit this tuple on purpose.
 _REQUIRED_STRONG = (
     "SWI2_EGU2_IRQHandler",  # SoftDevice BLE event (SD_EVT) -- advertising & connections
     "GPIOTE_IRQHandler",  # GPIO interrupts: radio DIO + buttons
     "RTC1_IRQHandler",  # FreeRTOS scheduler tick
-)
-# Owned by the TinyUSB stack, so only required when the board builds with USB at all.
-# Boards without native USB wiring (e.g. wio-sdk-wm1110's CH340 UART) strip TinyUSB via
-# disable_adafruit_usb.py / unflagging USE_TINYUSB, leaving these legitimately weak.
-_REQUIRED_STRONG_USB = (
     "USBD_IRQHandler",  # USB CDC (serial console + 1200bps DFU trigger)
-    "POWER_CLOCK_IRQHandler",  # USB power events (VBUS detect/ready) via TinyUSB hal
+    "POWER_CLOCK_IRQHandler",  # HF/LF clock + power (HFCLK start for radio & SoftDevice)
 )
 
 _tc = env.PioPlatform().get_package_dir("toolchain-gccarmnoneeabi") or ""
@@ -118,13 +113,7 @@ def _assert_isr_handlers_survived(source, target, env):
         f = line.split()
         if len(f) >= 3 and f[-1].endswith("_IRQHandler"):
             kind[f[-1]] = f[-2]
-    required = list(_REQUIRED_STRONG)
-    defines = [
-        str(d[0] if isinstance(d, tuple) else d) for d in env.get("CPPDEFINES", [])
-    ]
-    if "USE_TINYUSB" in defines:
-        required += _REQUIRED_STRONG_USB
-    dropped = [h for h in required if kind.get(h, "W").upper() != "T"]
+    dropped = [h for h in _REQUIRED_STRONG if kind.get(h, "W").upper() != "T"]
     if dropped:
         sys.stderr.write(
             "\n*** nrf52 LTO guard: interrupt handler(s) DROPPED: %s ***\n"
@@ -138,7 +127,8 @@ def _assert_isr_handlers_survived(source, target, env):
 
         Exit(1)  # canonical SCons build-abort -> red build
     print(
-        "nrf52_lto: ISR-handler guard OK -- %d critical handlers strong" % len(required)
+        "nrf52_lto: ISR-handler guard OK -- %d critical handlers strong"
+        % len(_REQUIRED_STRONG)
     )
 
 

extra_scripts/nrf52_warm_region.py

@@ -1,70 +0,0 @@
-#!/usr/bin/env python3
-# trunk-ignore-all(ruff/F821)
-# trunk-ignore-all(flake8/F821): For SConstruct imports
-#
-# Post-link guard for the warm-node-store raw-flash region on nRF52840.
-#
-# The 3 app-region pages below LittleFS (0xEA000-0xED000, reclaimed by whole-image
-# LTO) are reserved for the WarmNodeStore record-ring (see WarmNodeStore.h). Our
-# linker scripts (nrf52840_s140_v6.ld and nrf52840_s140_v7.ld) cap the image at
-# 0xEA000, but boards on the framework-default script (FLASH ending at 0xED000) could
-# silently place code in those pages — the first warm-store save would then brick the
-# device. This turns that into a build failure.
-#
-# Image flash end = __etext + sizeof(.data) (loaded at LMA __etext); symbols from
-# the framework's nrf52_common.ld.
-import os
-
-Import("env")
-
-WARM_REGION_BASE = 0xEA000  # keep in sync with WARM_FLASH_REGION_BASE in WarmNodeStore.h (3 x 4 KB record-ring)
-
-_tc = env.PioPlatform().get_package_dir("toolchain-gccarmnoneeabi") or ""
-_NM = os.path.join(_tc, "bin", "arm-none-eabi-nm")
-if not os.path.isfile(_NM):
-    _NM = "arm-none-eabi-nm"  # fall back to PATH
-
-
-def _assert_warm_region_clear(source, target, env):
-    import subprocess
-    import sys
-
-    try:
-        elf = env.subst("$BUILD_DIR/${PROGNAME}.elf")
-        out = subprocess.check_output([_NM, elf], universal_newlines=True)
-    except Exception as exc:  # tooling hiccup: warn loudly, don't wedge the build
-        print("nrf52_warm_region: WARNING - guard skipped (nm failed: %s)" % exc)
-        return
-
-    syms = {}
-    for line in out.split("\n"):
-        f = line.split()
-        if len(f) >= 3 and f[-1] in ("__etext", "__data_start__", "__data_end__"):
-            syms[f[-1]] = int(f[0], 16)
-    if len(syms) != 3:
-        print("nrf52_warm_region: WARNING - guard skipped (linker symbols not found)")
-        return
-
-    flash_end = syms["__etext"] + (syms["__data_end__"] - syms["__data_start__"])
-    if flash_end > WARM_REGION_BASE:
-        sys.stderr.write(
-            "\n*** nrf52 warm-region guard: image ends at 0x%X, past the reserved "
-            "warm-store region at 0x%X ***\n"
-            "The 12 KB region at 0xEA000 holds the WarmNodeStore record-ring; a warm-store\n"
-            "save would overwrite this firmware's tail. Shrink the image, or shrink/move\n"
-            "the region (WARM_FLASH_REGION_BASE in src/mesh/WarmNodeStore.h, the FLASH\n"
-            "LENGTH in src/platform/nrf52/nrf52840_s140_v6.ld and _v7.ld, and this guard).\n\n"
-            % (flash_end, WARM_REGION_BASE)
-        )
-        from SCons.Script import Exit
-
-        Exit(1)
-    print(
-        "nrf52_warm_region: guard OK -- image ends at 0x%X, %d KB clear of the warm region"
-        % (flash_end, (WARM_REGION_BASE - flash_end) // 1024)
-    )
-
-
-# Attach to the phony "buildprog" alias (not the .elf node) so the guard runs
-# on incremental relinks too -- same reasoning as nrf52_lto.py's guard.
-env.AddPostAction("buildprog", _assert_warm_region_clear)

mcp-server/tests/mesh/test_nexthop_multihop_recovery.py

@@ -1,347 +0,0 @@
-"""Multi-hop NextHop directed-message delivery + relay-recovery (bench test).
-
-This is the hardware/tier-3 validator for the NextHop DM reliability work
-(see `docs/nexthop-routing-reliability.md`). The unit suite
-`test/test_nexthop_routing` covers the routing *logic* exhaustively; this test
-covers the *end-to-end* multi-hop behavior that only a real (or RF-separated)
-mesh exercises:
-
-  * a directed DM that must traverse a relay is delivered (next_hop routing +
-    the M1/M2 ambiguity gate + M3 route learning all engage), and
-  * when the established relay drops and returns, delivery recovers rather than
-    black-holing (the M3 stale-route decay / re-learn path).
-
-TOPOLOGY REQUIREMENT — why this usually SKIPS:
-  A NextHop relay only happens when the two endpoints are NOT direct neighbors.
-  Three co-located radios all hear each other, so A→C is a single direct hop and
-  next_hop never engages. To run this test the bench must be a *line* — A — B — C
-  — with the endpoints out of each other's direct RF range (physical distance or
-  attenuators). The `multihop_topology` fixture detects this automatically: it
-  warms the mesh, looks for a pair that is ≥1 hop apart, confirms the relay via
-  traceroute, and `pytest.skip`s cleanly when the bench is all-direct. So this
-  file is safe to commit and run anywhere — it only *asserts* when the topology
-  genuinely requires a relay.
-
-REQUIREMENTS:
-  * ≥3 baked devices. The default hub profile is 2 roles (nrf52, esp32s3); add a
-    third via `--hub-profile=path/to/hub.yaml` (see conftest `hub_profile`).
-  * The relay-recovery test additionally needs uhubctl + a power-controllable
-    relay port (same gate the other power tests use).
-"""
-
-from __future__ import annotations
-
-import time
-from typing import Any
-
-import pytest
-from meshtastic_mcp.connection import connect
-from tests import _power
-from tests._port_discovery import resolve_port_by_role
-
-from ._receive import ReceiveCollector, nudge_nodeinfo, nudge_nodeinfo_port
-
-
-def _hops_away(rec: dict[str, Any]) -> int | None:
-    """Read a node's hop distance from a `nodesByNum` entry, tolerating either
-    the camelCase (`hopsAway`) or snake_case (`hops_away`) spelling depending on
-    the meshtastic-python version."""
-    for key in ("hopsAway", "hops_away"):
-        val = rec.get(key)
-        if isinstance(val, int):
-            return val
-    return None
-
-
-def _warm_mesh(ports: list[str], rounds: int = 2, settle: float = 6.0) -> None:
-    """Flood a fresh NodeInfo from every node so the whole mesh (including
-    multi-hop pairs, reached via relayed broadcasts) populates pubkeys and hop
-    distances. Best-effort — a single node failing to nudge shouldn't abort."""
-    for _ in range(rounds):
-        for port in ports:
-            try:
-                nudge_nodeinfo_port(port)
-            except Exception:  # noqa: BLE001 — warmup is best-effort
-                pass
-            time.sleep(0.5)
-        time.sleep(settle)
-
-
-def _wait_for_pubkey(
-    tx_iface: Any, rx_num: int, rx_port: str, deadline_s: float = 90.0
-) -> bool:
-    """Block until `tx_iface` holds `rx_num`'s public key (directed PKI sends
-    NAK without it). Re-nudges both sides periodically; multi-hop warmup is
-    slower than the 2-device case because NodeInfo must be relayed, hence the
-    longer default deadline."""
-    deadline = time.monotonic() + deadline_s
-    last_nudge = time.monotonic()
-    while time.monotonic() < deadline:
-        rec = (tx_iface.nodesByNum or {}).get(rx_num, {})
-        if rec.get("user", {}).get("publicKey"):
-            return True
-        if time.monotonic() - last_nudge > 20.0:
-            nudge_nodeinfo_port(rx_port)
-            nudge_nodeinfo(tx_iface)
-            last_nudge = time.monotonic()
-        time.sleep(1.0)
-    return False
-
-
-def _traceroute_route(tx_port: str, rx_num: int, rx_port: str) -> list[int] | None:
-    """Run a traceroute TX→RX and return the forward `route` (list of relay node
-    numbers), or None if it couldn't be obtained. Mirrors test_traceroute's
-    request/PKI/retry pattern."""
-    from meshtastic.mesh_interface import MeshInterface
-
-    with ReceiveCollector(tx_port, topic="meshtastic.receive.traceroute") as tx:
-        nudge_nodeinfo_port(rx_port)
-        tx.broadcast_nodeinfo_ping()
-        if not _wait_for_pubkey(tx._iface, rx_num, rx_port, 60.0):
-            return None
-        for _attempt in range(2):
-            try:
-                tx._iface.sendTraceRoute(dest=rx_num, hopLimit=5)
-                break
-            except MeshInterface.MeshInterfaceError:
-                time.sleep(5.0)
-        else:
-            return None
-        pkt = tx.wait_for(lambda p: p.get("from") == rx_num, timeout=8.0)
-        if pkt is None:
-            return None
-        tr = (pkt.get("decoded", {}) or {}).get("traceroute") or {}
-        return [int(n) for n in (tr.get("route") or [])]
-
-
-@pytest.fixture(scope="session")
-def multihop_topology(baked_mesh: dict[str, Any]) -> dict[str, Any]:
-    """Discover a real multi-hop pier (tx → relay → rx) on the bench, or skip.
-
-    Returns {tx_role, tx_port, rx_role, rx_port, rx_num, relay_role, relay_num}.
-    """
-    roles = sorted(baked_mesh)
-    if len(roles) < 3:
-        pytest.skip(
-            "multi-hop NextHop test needs ≥3 baked devices arranged as a line "
-            "(endpoints out of direct RF range). Add a third role via "
-            f"--hub-profile. Detected roles: {roles}"
-        )
-
-    by_role = {r: (baked_mesh[r]["port"], baked_mesh[r]["my_node_num"]) for r in roles}
-    if any(num is None for _, num in by_role.values()):
-        pytest.skip("a baked device is missing my_node_num; can't map the topology")
-
-    _warm_mesh([port for port, _ in by_role.values()])
-
-    # Find an ordered pair that is ≥1 hop apart, using each node's own nodeDB
-    # (cheap — no traceroute yet). On an all-direct bench nothing qualifies.
-    multihop_pair: tuple[str, str] | None = None
-    for a_role in roles:
-        a_port, _ = by_role[a_role]
-        try:
-            with connect(port=a_port) as a_iface:
-                nodes = a_iface.nodesByNum or {}
-        except Exception:  # noqa: BLE001
-            continue
-        for c_role in roles:
-            if c_role == a_role:
-                continue
-            _, c_num = by_role[c_role]
-            hops = _hops_away(nodes.get(c_num, {}))
-            if hops is not None and hops >= 1:
-                multihop_pair = (a_role, c_role)
-                break
-        if multihop_pair:
-            break
-
-    if not multihop_pair:
-        pytest.skip(
-            "no multi-hop pair found — every device appears to be a direct "
-            "neighbor. Arrange the bench as a line (A — B — C) with the "
-            "endpoints out of direct RF range (distance or attenuators) so a "
-            "relay is actually required, then re-run."
-        )
-
-    a_role, c_role = multihop_pair
-    a_port, _ = by_role[a_role]
-    c_port, c_num = by_role[c_role]
-
-    route = _traceroute_route(a_port, c_num, c_port)
-    if not route:
-        pytest.skip(
-            f"{a_role}→{c_role} looked multi-hop but traceroute returned no "
-            "intermediate relay; can't identify the relay node to drive the "
-            "recovery test"
-        )
-
-    relay_num = route[0]
-    relay_role = next((r for r in roles if by_role[r][1] == relay_num), None)
-    return {
-        "tx_role": a_role,
-        "tx_port": a_port,
-        "rx_role": c_role,
-        "rx_port": c_port,
-        "rx_num": c_num,
-        "relay_role": relay_role,
-        "relay_num": relay_num,
-    }
-
-
-@pytest.mark.timeout(300)
-def test_multihop_dm_delivers(multihop_topology: dict[str, Any]) -> None:
-    """A directed wantAck DM that must traverse the relay is delivered.
-
-    Exercises the NextHop routing path end-to-end: TX picks a next hop toward
-    RX (M2 gate), the relay resolves the next_hop byte and forwards (M1), and
-    the route is learned from the returning ACK (M3). Retries absorb transient
-    LoRa loss; the assertion is on eventual delivery.
-    """
-    tx_port = multihop_topology["tx_port"]
-    rx_port = multihop_topology["rx_port"]
-    rx_num = multihop_topology["rx_num"]
-    tx_role = multihop_topology["tx_role"]
-    rx_role = multihop_topology["rx_role"]
-    relay_role = multihop_topology["relay_role"]
-
-    unique = f"nexthop-mh-{tx_role}-to-{rx_role}-{int(time.time())}"
-
-    with ReceiveCollector(rx_port, topic="meshtastic.receive.text") as rx:
-        rx.broadcast_nodeinfo_ping()
-        with connect(port=tx_port) as tx_iface:
-            nudge_nodeinfo(tx_iface)
-            if not _wait_for_pubkey(tx_iface, rx_num, rx_port, 90.0):
-                pytest.skip(
-                    f"{tx_role} never learned {rx_role}'s pubkey over the relay; "
-                    "multi-hop PKI warmup didn't complete"
-                )
-            got = None
-            for _attempt in range(3):
-                pkt = tx_iface.sendText(unique, destinationId=rx_num, wantAck=True)
-                assert pkt is not None
-                got = rx.wait_for(
-                    lambda p: p.get("decoded", {}).get("text") == unique,
-                    timeout=45,
-                )
-                if got is not None:
-                    break
-                rx.broadcast_nodeinfo_ping()
-                nudge_nodeinfo(tx_iface)
-                time.sleep(5.0)
-
-    assert got is not None, (
-        f"multi-hop directed DM {tx_role}→{rx_role} via relay "
-        f"{relay_role!r} never landed — NextHop multi-hop delivery is broken"
-    )
-
-
-@pytest.mark.timeout(600)
-def test_multihop_relay_recovery(
-    multihop_topology: dict[str, Any],
-    power_cycle,  # noqa: ARG001 — forces the uhubctl-availability skip
-) -> None:
-    """Delivery recovers after the established relay drops and returns.
-
-    Establishes a baseline DM (route via relay learned), powers the relay OFF
-    (confirming TX survives sending across a downed relay), then powers it back
-    ON and asserts directed delivery resumes — the M3 stale-route decay /
-    re-learn path. With a strict A — B — C line there is no path while B is down,
-    so we only assert TX doesn't crash during the outage; the delivery assertion
-    is after B returns.
-    """
-    relay_role = multihop_topology["relay_role"]
-    if not relay_role:
-        pytest.skip(
-            "relay node isn't one of the baked hub roles, so it can't be "
-            "power-cycled; recovery test needs a controllable relay"
-        )
-
-    tx_port = multihop_topology["tx_port"]
-    rx_port = multihop_topology["rx_port"]
-    rx_num = multihop_topology["rx_num"]
-    tx_role = multihop_topology["tx_role"]
-    rx_role = multihop_topology["rx_role"]
-
-    base = f"mh-recover-base-{int(time.time())}"
-    post = f"mh-recover-post-{int(time.time())}"
-
-    # Baseline: confirm delivery works (so the route via the relay is learned)
-    # before we perturb anything — otherwise a later failure is ambiguous.
-    with ReceiveCollector(rx_port, topic="meshtastic.receive.text") as rx:
-        rx.broadcast_nodeinfo_ping()
-        with connect(port=tx_port) as tx_iface:
-            nudge_nodeinfo(tx_iface)
-            if not _wait_for_pubkey(tx_iface, rx_num, rx_port, 90.0):
-                pytest.skip("multi-hop PKI warmup failed; can't run recovery test")
-            tx_iface.sendText(base, destinationId=rx_num, wantAck=True)
-            assert (
-                rx.wait_for(
-                    lambda p: p.get("decoded", {}).get("text") == base, timeout=45
-                )
-                is not None
-            ), "baseline multi-hop delivery failed — skipping recovery to avoid a false result"
-
-    # Power the relay OFF.
-    try:
-        _power.power_off(relay_role)
-        _power.wait_for_absence(relay_role, timeout_s=15.0)
-    except Exception as exc:  # noqa: BLE001
-        try:
-            _power.power_on(relay_role)
-            resolve_port_by_role(relay_role, timeout_s=30.0)
-        except Exception:  # noqa: BLE001
-            pass
-        pytest.skip(f"can't power-control relay {relay_role!r}: {exc}")
-
-    # With the only relay down there's no path; we just confirm TX accepts the
-    # send and survives its internal retries (it must not crash / wedge).
-    try:
-        with connect(port=tx_port) as tx_iface:
-            pkt = tx_iface.sendText(
-                f"mh-while-down-{int(time.time())}",
-                destinationId=rx_num,
-                wantAck=True,
-            )
-            assert pkt is not None
-            time.sleep(8.0)  # let retransmissions + route decay run
-    except Exception as exc:  # noqa: BLE001 — restore bench state before failing
-        _power.power_on(relay_role)
-        resolve_port_by_role(relay_role, timeout_s=30.0)
-        raise AssertionError(
-            f"TX crashed sending across a downed relay: {exc}"
-        ) from exc
-
-    # Power the relay back ON and let it re-enumerate + boot.
-    _power.power_on(relay_role)
-    time.sleep(0.5)
-    try:
-        resolve_port_by_role(relay_role, timeout_s=30.0)
-    except Exception:  # noqa: BLE001 — relay port isn't one we connect to directly
-        pass
-    time.sleep(8.0)
-    _warm_mesh([tx_port, rx_port], rounds=1)  # re-flood so the relay re-learns
-
-    # Delivery should resume once the relay is back (M3 re-learn / decay path).
-    got = None
-    with ReceiveCollector(rx_port, topic="meshtastic.receive.text") as rx:
-        rx.broadcast_nodeinfo_ping()
-        with connect(port=tx_port) as tx_iface:
-            nudge_nodeinfo(tx_iface)
-            _wait_for_pubkey(tx_iface, rx_num, rx_port, 90.0)
-            for _attempt in range(4):
-                pkt = tx_iface.sendText(post, destinationId=rx_num, wantAck=True)
-                assert pkt is not None
-                got = rx.wait_for(
-                    lambda p: p.get("decoded", {}).get("text") == post,
-                    timeout=45,
-                )
-                if got is not None:
-                    break
-                rx.broadcast_nodeinfo_ping()
-                nudge_nodeinfo(tx_iface)
-                time.sleep(6.0)
-
-    assert got is not None, (
-        f"after relay {relay_role!r} returned, multi-hop DM {tx_role}→{rx_role} "
-        "never resumed — stale-route recovery (M3) may be broken"
-    )

mcp-server/tests/test_00_bake.py

@@ -44,7 +44,7 @@ _ESP32_ARCHES = {
     "esp32-c6",
     "esp32c6",
 }
-_NRF52_ARCHES = {"nrf52", "nrf52840"}
+_NRF52_ARCHES = {"nrf52", "nrf52840", "nrf52832"}
 
 
 def _wait_port_free(port: str, *, timeout_s: float = 15.0, role: str = "") -> None:

platformio.ini

@@ -13,7 +13,7 @@ extra_configs =
 description = Meshtastic
 
 [env]
-; test_build_src = true  ; disabled for faster incremental builds
+test_build_src = true
 extra_scripts =
 	pre:bin/platformio-pre.py
 	bin/platformio-custom.py
@@ -62,7 +62,6 @@ build_flags = -Wno-missing-field-initializers
 	-D MAX_THREADS=40 ; As we've split modules, we have more threads to manage
 	#-DBUILD_EPOCH=$UNIX_TIME ; set in platformio-custom.py now
 	#-D OLED_PL=1
-	#-D OLED_ZH=1 ; uncomment for compile-time Chinese font (runtime switching works without this on TFT)
 	#-D DEBUG_HEAP=1 ; uncomment to add free heap space / memory leak debugging logs
 	#-D DEBUG_LOOP_TIMING=1 ; uncomment to add main loop timing logs
 
@@ -104,7 +103,7 @@ build_unflags =
 	-std=gnu++11
 build_flags = ${env.build_flags} -Os
 	-std=gnu++17
-build_src_filter = ${env.build_src_filter} -<platform/> +<platform/extra_variants/> -<graphics/niche/>
+build_src_filter = ${env.build_src_filter} -<platform/portduino/> -<graphics/niche/>
 
 ; Common libs for communicating over TCP/IP networks such as MQTT
 [networking_base]
@@ -201,16 +200,6 @@ lib_deps =
 	https://github.com/adafruit/Adafruit_TSL2561/archive/refs/tags/1.1.3.zip
 	# renovate: datasource=github-tags depName=BH1750_WE packageName=wollewald/BH1750_WE
 	https://github.com/wollewald/BH1750_WE/archive/refs/tags/1.1.10.zip
-	# renovate: datasource=github-tags depName=Sensirion Core packageName=sensirion/arduino-core
-	https://github.com/Sensirion/arduino-core/archive/refs/tags/0.7.3.zip
-	# renovate: datasource=github-tags depName=Sensirion I2C SCD4x packageName=sensirion/arduino-i2c-scd4x
-	https://github.com/Sensirion/arduino-i2c-scd4x/archive/refs/tags/1.1.0.zip
-	# renovate: datasource=github-tags depName=Sensirion I2C SFA3x packageName=sensirion/arduino-i2c-sfa3x
-	https://github.com/Sensirion/arduino-i2c-sfa3x/archive/refs/tags/1.0.0.zip
-	# renovate: datasource=github-tags depName=Sensirion I2C SCD30 packageName=sensirion/arduino-i2c-scd30
-	https://github.com/Sensirion/arduino-i2c-scd30/archive/refs/tags/1.0.0.zip
-	# renovate: datasource=github-tags depName=arduino-sht packageName=sensirion/arduino-sht
-	https://github.com/Sensirion/arduino-sht/archive/refs/tags/v1.2.6.zip
 
 ; Common environmental sensor libraries (not included in native / portduino)
 [environmental_extra_common]
@@ -229,6 +218,16 @@ lib_deps =
 	closedcube/ClosedCube OPT3001@1.1.2
 	# renovate: datasource=git-refs depName=meshtastic-DFRobot_LarkWeatherStation packageName=https://github.com/meshtastic/DFRobot_LarkWeatherStation gitBranch=master
 	https://github.com/meshtastic/DFRobot_LarkWeatherStation/archive/4de3a9cadef0f6a5220a8a906cf9775b02b0040d.zip
+	# renovate: datasource=github-tags depName=Sensirion Core packageName=sensirion/arduino-core
+	https://github.com/Sensirion/arduino-core/archive/refs/tags/0.7.3.zip
+	# renovate: datasource=github-tags depName=Sensirion I2C SCD4x packageName=sensirion/arduino-i2c-scd4x
+	https://github.com/Sensirion/arduino-i2c-scd4x/archive/refs/tags/1.1.0.zip
+	# renovate: datasource=github-tags depName=Sensirion I2C SFA3x packageName=sensirion/arduino-i2c-sfa3x
+	https://github.com/Sensirion/arduino-i2c-sfa3x/archive/refs/tags/1.0.0.zip
+	# renovate: datasource=github-tags depName=Sensirion I2C SCD30 packageName=sensirion/arduino-i2c-scd30
+	https://github.com/Sensirion/arduino-i2c-scd30/archive/refs/tags/1.0.0.zip
+	# renovate: datasource=github-tags depName=arduino-sht packageName=sensirion/arduino-sht
+	https://github.com/Sensirion/arduino-sht/archive/refs/tags/v1.2.6.zip
 
 ; Environmental sensors with BSEC2 (Bosch proprietary IAQ)
 [environmental_extra]

src/FSCommon.cpp

@@ -88,9 +88,6 @@ bool renameFile(const char *pathFrom, const char *pathTo)
 #endif
 }
 
-#include <cstring>
-#include <new>
-#include <stdexcept>
 #include <vector>
 
 /**
@@ -122,93 +119,6 @@ bool fsFormat()
 #endif
 }
 
-#ifdef FSCom
-namespace
-{
-bool pathEndsWithDot(const char *path)
-{
-    if (!path)
-        return false;
-
-    size_t length = strlen(path);
-    return length > 0 && path[length - 1] == '.';
-}
-
-bool copyFilePath(char *dest, size_t destSize, const char *path, bool *wasLimited)
-{
-    if (!path || destSize == 0) {
-        if (wasLimited)
-            *wasLimited = true;
-        return false;
-    }
-
-    if (strlcpy(dest, path, destSize) >= destSize) {
-        if (wasLimited)
-            *wasLimited = true;
-        return false;
-    }
-
-    return true;
-}
-
-void collectFiles(const char *dirname, uint8_t levels, size_t maxCount, std::vector<meshtastic_FileInfo> &filenames,
-                  bool *wasLimited)
-{
-    if (!dirname)
-        return;
-
-    File root = FSCom.open(dirname, FILE_O_READ);
-    if (!root)
-        return;
-    if (!root.isDirectory()) {
-        root.close();
-        return;
-    }
-
-    File file = root.openNextFile();
-    // file.name()[0] check is a workaround for a bug in the Adafruit LittleFS nrf52 glue (see issue 4395)
-    while (file && file.name()[0]) {
-        if (filenames.size() >= maxCount) {
-            if (wasLimited)
-                *wasLimited = true;
-            file.close();
-            break;
-        }
-        const char *fileName = file.name();
-        if (file.isDirectory() && !pathEndsWithDot(fileName)) {
-            char pathBuffer[sizeof(((meshtastic_FileInfo *)nullptr)->file_name)] = {};
-#ifdef ARCH_ESP32
-            const char *subDirPath = file.path();
-#else
-            const char *subDirPath = fileName;
-#endif
-            bool hasSubDirPath = copyFilePath(pathBuffer, sizeof(pathBuffer), subDirPath, wasLimited);
-            file.close();
-
-            if (levels && hasSubDirPath) {
-                collectFiles(pathBuffer, levels - 1, maxCount, filenames, wasLimited);
-            } else if (wasLimited) {
-                *wasLimited = true;
-            }
-        } else {
-            meshtastic_FileInfo fileInfo = {"", static_cast<uint32_t>(file.size())};
-#ifdef ARCH_ESP32
-            bool hasFilePath = copyFilePath(fileInfo.file_name, sizeof(fileInfo.file_name), file.path(), wasLimited);
-#else
-            bool hasFilePath = copyFilePath(fileInfo.file_name, sizeof(fileInfo.file_name), file.name(), wasLimited);
-#endif
-            if (hasFilePath && !pathEndsWithDot(fileInfo.file_name)) {
-                filenames.push_back(fileInfo);
-            }
-            file.close();
-        }
-        file = root.openNextFile();
-    }
-    root.close();
-}
-} // namespace
-#endif
-
 /**
  * @brief Get the list of files in a directory.
  *
@@ -217,40 +127,43 @@ void collectFiles(const char *dirname, uint8_t levels, size_t maxCount, std::vec
  *
  * @param dirname The name of the directory.
  * @param levels The number of levels of subdirectories to list.
- * @param maxCount The maximum number of files to collect before truncating the walk.
- * @param wasLimited Optional out-param, set to true if the listing was truncated (by maxCount or low memory).
- * @return A vector of meshtastic_FileInfo for each file in the directory.
+ * @return A vector of strings containing the full path of each file in the directory.
  */
-std::vector<meshtastic_FileInfo> getFiles(const char *dirname, uint8_t levels, size_t maxCount, bool *wasLimited)
+std::vector<meshtastic_FileInfo> getFiles(const char *dirname, uint8_t levels)
 {
     std::vector<meshtastic_FileInfo> filenames = {};
-    if (wasLimited)
-        *wasLimited = false;
 #ifdef FSCom
-#if defined(__cpp_exceptions) || defined(__EXCEPTIONS)
-    size_t reservedCount = maxCount;
-    while (reservedCount > 0) {
-        try {
-            filenames.reserve(reservedCount);
-            break;
-        } catch (const std::bad_alloc &) {
-            reservedCount /= 2;
-        } catch (const std::length_error &) {
-            reservedCount /= 2;
-        }
-    }
-    if (reservedCount == 0) {
-        if (wasLimited)
-            *wasLimited = true;
+    File root = FSCom.open(dirname, FILE_O_READ);
+    if (!root)
         return filenames;
-    }
-    if (reservedCount < maxCount) {
-        if (wasLimited)
-            *wasLimited = true;
-        maxCount = reservedCount;
-    }
+    if (!root.isDirectory())
+        return filenames;
+
+    File file = root.openNextFile();
+    while (file) {
+#ifdef ARCH_ESP32
+        const char *filepath = file.path();
+#else
+        const char *filepath = file.name();
 #endif
-    collectFiles(dirname, levels, maxCount, filenames, wasLimited);
+        if (file.isDirectory() && !String(file.name()).endsWith(".")) {
+            if (levels) {
+                std::vector<meshtastic_FileInfo> subDirFilenames = getFiles(filepath, levels - 1);
+                filenames.insert(filenames.end(), subDirFilenames.begin(), subDirFilenames.end());
+                file.close();
+            }
+        } else {
+            meshtastic_FileInfo fileInfo = {"", static_cast<uint32_t>(file.size())};
+            strncpy(fileInfo.file_name, filepath, sizeof(fileInfo.file_name) - 1);
+            fileInfo.file_name[sizeof(fileInfo.file_name) - 1] = '\0';
+            if (!String(fileInfo.file_name).endsWith(".")) {
+                filenames.push_back(fileInfo);
+            }
+            file.close();
+        }
+        file = root.openNextFile();
+    }
+    root.close();
 #endif
     return filenames;
 }

src/FSCommon.h

@@ -14,8 +14,8 @@
 #define FILE_O_READ "r"
 #endif
 
-#if defined(ARCH_STM32)
-// STM32
+#if defined(ARCH_STM32WL)
+// STM32WL
 #include "LittleFS.h"
 #define FSCom InternalFS
 #define FSBegin() FSCom.begin()
@@ -61,7 +61,7 @@ void fsListFiles();
 bool copyFile(const char *from, const char *to);
 bool renameFile(const char *pathFrom, const char *pathTo);
 bool fsFormat();
-std::vector<meshtastic_FileInfo> getFiles(const char *dirname, uint8_t levels, size_t maxCount = 64, bool *wasLimited = nullptr);
+std::vector<meshtastic_FileInfo> getFiles(const char *dirname, uint8_t levels);
 void listDir(const char *dirname, uint8_t levels, bool del = false);
 void rmDir(const char *dirname);
 void setupSDCard();

src/MessageStore.cpp

@@ -354,7 +354,6 @@ void MessageStore::clearAllMessages()
     resetMessagePool();
 
 #ifdef FSCom
-    concurrency::LockGuard guard(spiLock);
     SafeFile f(filename.c_str(), false);
     uint8_t count = 0;
     f.write(&count, 1); // write "0 messages"

src/Power.cpp

@@ -14,7 +14,6 @@
  * For more information, see: https://meshtastic.org/
  */
 #include "power.h"
-#include "BluetoothCommon.h"
 #include "MessageStore.h"
 #include "NodeDB.h"
 #include "PowerFSM.h"
@@ -24,7 +23,6 @@
 #include "main.h"
 #include "meshUtils.h"
 #include "power/PowerHAL.h"
-#include "power/SGM41562.h"
 #include "sleep.h"
 #ifdef ARCH_ESP32
 // #include <driver/adc.h>
@@ -49,7 +47,7 @@
 #include "concurrency/LockGuard.h"
 #endif
 
-#if defined(ARCH_STM32) && defined(BATTERY_PIN)
+#if defined(ARCH_STM32WL) && defined(BATTERY_PIN)
 #include "stm32yyxx_ll_adc.h"
 
 /* Analog read resolution */
@@ -432,7 +430,7 @@ class AnalogBatteryLevel : public HasBatteryLevel
             float scaled = 0;
 
             battery_adcEnable();
-#ifdef ARCH_STM32
+#ifdef ARCH_STM32WL
             // STM32 ADC with VREFINT runtime calibration
             Vref = __LL_ADC_CALC_VREFANALOG_VOLTAGE(analogRead(AVREF), LL_ADC_RESOLUTION);
             raw = analogRead(BATTERY_PIN);
@@ -546,10 +544,6 @@ class AnalogBatteryLevel : public HasBatteryLevel
     // lastly provide a fallback to indicate external power when fully charged.
     virtual bool isVbusIn() override
     {
-#ifdef HAS_SGM41562
-        if (sgm41562 && sgm41562->refresh())
-            return sgm41562->isInputPowerGood();
-#endif
 #ifdef EXT_PWR_DETECT
         return digitalRead(EXT_PWR_DETECT) == EXT_PWR_DETECT_VALUE;
 
@@ -566,10 +560,6 @@ class AnalogBatteryLevel : public HasBatteryLevel
     /// we can't be smart enough to say 'full'?
     virtual bool isCharging() override
     {
-#ifdef HAS_SGM41562
-        if (sgm41562 && sgm41562->refresh())
-            return sgm41562->isCharging();
-#endif
 #if HAS_TELEMETRY && !MESHTASTIC_EXCLUDE_ENVIRONMENTAL_SENSOR && defined(HAS_RAKPROT) && !defined(HAS_PMU)
         if (hasRAK()) {
             return (rak9154Sensor.isCharging()) ? OptTrue : OptFalse;
@@ -617,7 +607,7 @@ class AnalogBatteryLevel : public HasBatteryLevel
     bool initial_read_done = false;
     float last_read_value = (OCV[NUM_OCV_POINTS - 1] * NUM_CELLS);
     uint32_t last_read_time_ms = 0;
-#ifdef ARCH_STM32
+#ifdef ARCH_STM32WL
     // 3300mV placeholder for STM32 errata where VREFINT factory calibration may be missing
     // (e.g. STM32U0, see DS14756 Rev 3 §2.4.1 "VREFINT offset")
     uint32_t Vref = 3300;
@@ -727,7 +717,7 @@ bool Power::analogInit()
 #define BATTERY_SENSE_RESOLUTION_BITS 10
 #endif
 
-#ifdef ARCH_STM32
+#ifdef ARCH_STM32WL
     analogReadResolution(BATTERY_SENSE_RESOLUTION_BITS);
 #elif defined(ARCH_ESP32) // ESP32 needs special analog stuff
     adc_oneshot_unit_init_cfg_t init_config = {
@@ -758,7 +748,7 @@ bool Power::analogInit()
 
     // NRF52 ADC init moved to powerHAL_init in nrf52 platform
 
-#if !defined(ARCH_ESP32) && !defined(ARCH_STM32)
+#if !defined(ARCH_ESP32) && !defined(ARCH_STM32WL)
     analogReadResolution(BATTERY_SENSE_RESOLUTION_BITS);
 #endif
 
@@ -776,12 +766,6 @@ bool Power::analogInit()
  */
 bool Power::setup()
 {
-#ifdef HAS_SGM41562
-    // Initialize the charger early so AnalogBatteryLevel can read charging
-    // state from it. The charger does not provide battery voltage / percent —
-    // those still come from the platform ADC via analogInit() below.
-    initSGM41562(SGM41562_WIRE);
-#endif
     bool found = false;
     if (axpChipInit()) {
         found = true;
@@ -853,7 +837,7 @@ void Power::reboot()
     }
     LOG_DEBUG("final reboot!");
     ::reboot();
-#elif defined(ARCH_STM32)
+#elif defined(ARCH_STM32WL)
     HAL_NVIC_SystemReset();
 #else
     rebootAtMsec = -1;
@@ -978,10 +962,6 @@ void Power::readPowerStatus()
         lastLogTime = millis();
     }
     newStatus.notifyObservers(&powerStatus2);
-
-    // Mirror battery level to the BLE Battery Service (0x2A19); the platform layer clamps and dedupes.
-    if (hasBattery == OptTrue)
-        updateBatteryLevel(powerStatus2.getBatteryChargePercent());
 #ifdef DEBUG_HEAP
     if (lastheap != memGet.getFreeHeap()) {
         // Use stack-allocated buffer to avoid heap allocations in monitoring code

src/PowerFSM.cpp

@@ -219,11 +219,7 @@ static void darkEnter()
 static void serialEnter()
 {
     LOG_POWERFSM("State: serialEnter");
-#ifndef ARCH_NRF52
-    // nRF52 runs BLE on SoftDevice independently of USB serial — no need to disable it.
-    // (Same rationale as nbEnter() which already guards this with #ifdef ARCH_ESP32)
     setBluetoothEnable(false);
-#endif
     if (screen) {
         screen->setOn(true);
     }

src/configuration.h

@@ -179,13 +179,6 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #endif
 #endif
 
-#ifdef USE_KCT8103L_PA_ONLY
-#if defined(HELTEC_MESH_TOWER_V2)
-#define NUM_PA_POINTS 22
-#define TX_GAIN_LORA 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 10, 10, 10, 10, 10, 10, 10, 10, 10, 9, 8, 7
-#endif
-#endif
-
 #ifdef RAK13302
 #define NUM_PA_POINTS 22
 #define TX_GAIN_LORA 7, 8, 8, 8, 8, 8, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 8
@@ -580,94 +573,5 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #define USE_ETHERNET_DEFAULT 0
 #endif
 
-// -----------------------------------------------------------------------------
-// MESHTASTIC_LOCKDOWN — runtime, client-toggleable hardening (nRF52 only)
-//
-// Lockdown/protect support is opt-in at build time. Builds that need it pass
-// -DMESHTASTIC_ENABLE_LOCKDOWN=1. When enabled on nRF52 (CC310 hardware
-// crypto), whether it is ACTIVE is decided entirely at runtime by
-// EncryptedStorage::isLockdownActive()
-// (== a passphrase has been provisioned, i.e. /prefs/.dek exists). A device
-// that has never been provisioned — or that the operator disabled from the
-// client app — behaves exactly like stock firmware: plaintext storage, no
-// redaction, normal logging, normal display.
-//
-// The operator toggles lockdown from the client app:
-//   off -> on : provision a passphrase (AdminMessage.lockdown_auth). The
-//               firmware generates a DEK, encrypts the stored config, and
-//               authorizes the connection.
-//   on -> off : AdminMessage.lockdown_auth { disable=true } with the
-//               passphrase — decrypts storage back to plaintext and removes
-//               the DEK / token / monotonic-counter / backoff files, then
-//               reboots into normal mode. APPROTECT is the one thing that
-//               does NOT revert (see below).
-//
-// MESHTASTIC_LOCKDOWN here is an INTERNAL capability marker. It gates the UI
-// bits (lock screen, pairing-PIN handling). Flash-constrained nRF52 variants
-// that genuinely cannot afford the ~tens-of-KB of crypto + access-control code
-// may also opt out with -DMESHTASTIC_EXCLUDE_LOCKDOWN=1.
-//
-//   MESHTASTIC_PHONEAPI_ACCESS_CONTROL — per-connection auth + redaction,
-//                                        gated at runtime on isLockdownActive()
-//   MESHTASTIC_ENCRYPTED_STORAGE       — AES-128-CTR + HMAC-SHA256 at-rest
-//   MESHTASTIC_ENABLE_APPROTECT        — UICR APPROTECT capability. The actual
-//                                        one-way burn happens at runtime, only
-//                                        once provisioned, only on non-vulnerable
-//                                        silicon, and is STICKY: disabling
-//                                        lockdown does NOT (cannot) reverse it.
-//
-// DEBUG_MUTE is intentionally NOT coupled to lockdown — a capable-but-off
-// device must log normally. Define DEBUG_MUTE separately for a silent build.
-//
-// -DMESHTASTIC_LOCKDOWN_DEBUG=1 keeps the irreversible APPROTECT burn disabled
-// even when provisioned — for development so dev boards never lose SWD.
-// -----------------------------------------------------------------------------
-#if defined(ARCH_NRF52)
-#ifndef MESHTASTIC_ENABLE_LOCKDOWN
-#define MESHTASTIC_ENABLE_LOCKDOWN 0
-#endif
-
-#if !MESHTASTIC_ENABLE_LOCKDOWN
-#undef MESHTASTIC_LOCKDOWN
-#undef MESHTASTIC_PHONEAPI_ACCESS_CONTROL
-#undef MESHTASTIC_ENCRYPTED_STORAGE
-#undef MESHTASTIC_ENABLE_APPROTECT
-#ifndef MESHTASTIC_EXCLUDE_LOCKDOWN
-#define MESHTASTIC_EXCLUDE_LOCKDOWN 1
-#endif
-#endif
-
-#if MESHTASTIC_ENABLE_LOCKDOWN && !defined(MESHTASTIC_EXCLUDE_LOCKDOWN)
-#define MESHTASTIC_LOCKDOWN 1
-#define MESHTASTIC_PHONEAPI_ACCESS_CONTROL 1
-#define MESHTASTIC_ENCRYPTED_STORAGE 1
-#ifndef MESHTASTIC_LOCKDOWN_DEBUG
-#define MESHTASTIC_ENABLE_APPROTECT 1
-#endif
-#endif
-#endif
-
-#ifdef MESHTASTIC_LOCKDOWN
-
-// Per-boot uptime cap on unlocked sessions. 0 = unlimited (token-only
-// enforcement, the existing behavior). When non-zero, every passphrase
-// unlock (and every token-auto-unlock that inherits the value) arms a
-// timer; on expiry the device lockNow()s and reboots into locked state.
-// Bounds the total exposure window to bootsRemaining * this value if an
-// attacker has physical possession but not the passphrase.
-//
-// Override at build time. Suggested:
-//   carry device:        3600  (1h sessions, periodic re-auth from phone)
-//   tower / infra node:  0     (default — relies on token TTLs only)
-//
-// A future LockdownAuth.max_session_seconds proto field will let the
-// client set this per-token; until that lands the build-time value is
-// the only source.
-#ifndef MESHTASTIC_LOCKDOWN_SESSION_DEFAULT_SECONDS
-#define MESHTASTIC_LOCKDOWN_SESSION_DEFAULT_SECONDS 0
-#endif
-
-#endif // MESHTASTIC_LOCKDOWN
-
 #include "DebugConfiguration.h"
 #include "RF95Configuration.h"

src/detect/ScanI2C.cpp

@@ -37,15 +37,15 @@ ScanI2C::FoundDevice ScanI2C::firstKeyboard() const
 
 ScanI2C::FoundDevice ScanI2C::firstAccelerometer() const
 {
-    ScanI2C::DeviceType types[] = {MPU6050,  LIS3DH,   BMA423, LSM6DS3, BMX160,    STK8BAXX,
-                                   ICM20948, QMA6100P, BMM150, BMI270,  ICM42607P, ISM330DHCX};
-    return firstOfOrNONE(12, types);
+    ScanI2C::DeviceType types[] = {MPU6050, LIS3DH, BMA423, LSM6DS3, BMX160, STK8BAXX,
+                                   ICM20948, QMA6100P, BMM150,  BMI270,  ICM42607P};
+    return firstOfOrNONE(11, types);
 }
 
 ScanI2C::FoundDevice ScanI2C::firstMagnetometer() const
 {
-    ScanI2C::DeviceType types[] = {MMC5983MA, IIS2MDCTR};
-    return firstOfOrNONE(2, types);
+    ScanI2C::DeviceType types[] = {MMC5983MA};
+    return firstOfOrNONE(1, types);
 }
 
 ScanI2C::FoundDevice ScanI2C::firstAQI() const

src/detect/ScanI2C.h

@@ -99,8 +99,6 @@ class ScanI2C
         CW2015,
         SCD30,
         ADS1115,
-        IIS2MDCTR,
-        ISM330DHCX,
     } DeviceType;
 
     // typedef uint8_t DeviceAddress;

src/detect/ScanI2CTwoWire.cpp

@@ -8,7 +8,7 @@
 #if defined(ARCH_PORTDUINO)
 #include "linux/LinuxHardwareI2C.h"
 #endif
-#if !defined(ARCH_PORTDUINO) && !defined(ARCH_STM32)
+#if !defined(ARCH_PORTDUINO) && !defined(ARCH_STM32WL)
 #include "meshUtils.h" // vformat
 
 #endif
@@ -584,9 +584,6 @@ void ScanI2CTwoWire::scanPort(I2CPort port, uint8_t *address, uint8_t asize)
                 if (registerValue == 0x6A) {
                     type = LSM6DS3;
                     logFoundDevice("LSM6DS3", (uint8_t)addr.address);
-                } else if (registerValue == 0x6B) {
-                    type = ISM330DHCX;
-                    logFoundDevice("ISM330DHCX", (uint8_t)addr.address);
                 } else {
                     type = QMI8658;
                     logFoundDevice("QMI8658", (uint8_t)addr.address);
@@ -594,17 +591,7 @@ void ScanI2CTwoWire::scanPort(I2CPort port, uint8_t *address, uint8_t asize)
                 break;
 
                 SCAN_SIMPLE_CASE(QMC5883L_ADDR, QMC5883L, "QMC5883L", (uint8_t)addr.address)
-            case HMC5883L_ADDR:
-                registerValue = getRegisterValue(ScanI2CTwoWire::RegisterLocation(addr, 0x4FU), 1); // get ID
-                if (registerValue == 0x40) {
-                    type = IIS2MDCTR;
-                    logFoundDevice("IIS2MDCTR", (uint8_t)addr.address);
-                    break;
-                } else {
-                    type = HMC5883L;
-                    logFoundDevice("HMC5883L", (uint8_t)addr.address);
-                    break;
-                }
+                SCAN_SIMPLE_CASE(HMC5883L_ADDR, HMC5883L, "HMC5883L", (uint8_t)addr.address)
 #ifdef HAS_QMA6100P
                 SCAN_SIMPLE_CASE(QMA6100P_ADDR, QMA6100P, "QMA6100P", (uint8_t)addr.address)
 #else

src/gps/GPS.cpp

@@ -47,7 +47,7 @@ template <typename T, std::size_t N> std::size_t array_count(const T (&)[N])
 
 #if defined(ARCH_NRF52)
 Uart *GPS::_serial_gps = &GPS_SERIAL_PORT;
-#elif defined(ARCH_ESP32) || defined(ARCH_PORTDUINO) || defined(ARCH_STM32)
+#elif defined(ARCH_ESP32) || defined(ARCH_PORTDUINO) || defined(ARCH_STM32WL)
 HardwareSerial *GPS::_serial_gps = &GPS_SERIAL_PORT;
 #elif defined(ARCH_RP2040)
 SerialUART *GPS::_serial_gps = &GPS_SERIAL_PORT;
@@ -80,12 +80,6 @@ namespace
 constexpr uint32_t GPS_PROBE_CACHE_MAGIC = 0x47504348UL; // "GPCH"
 constexpr uint16_t GPS_PROBE_CACHE_VERSION = 1;
 constexpr const char *GPS_PROBE_CACHE_FILE = "/prefs/gps_probe_cache.dat";
-constexpr int MIN_PLAUSIBLE_GPS_YEAR = 2020;
-constexpr int MAX_PLAUSIBLE_GPS_YEAR = 2100;
-#ifdef TRACKER_T1000_E
-constexpr uint32_t T1000_E_AIROHA_WAKE_MS = 1000;
-constexpr uint32_t T1000_E_AIROHA_WAKE_INTERVAL_MS = 40;
-#endif
 
 struct GPSProbeCacheRecord {
     uint32_t magic;
@@ -107,45 +101,6 @@ bool isValidProbeBaud(uint32_t baud)
     return baud >= 1200 && baud <= 921600;
 }
 
-template <typename T> void wakeAirohaForActiveProbe(T *serialGps)
-{
-#ifdef TRACKER_T1000_E
-    digitalWrite(PIN_GPS_EN, GPS_EN_ACTIVE);
-    digitalWrite(GPS_RTC_INT, HIGH);
-    delay(3);
-    digitalWrite(GPS_RTC_INT, LOW);
-    delay(50);
-
-    const uint32_t start = millis();
-    do {
-        serialGps->write("$PAIR382,1*2E\r\n");
-        delay(T1000_E_AIROHA_WAKE_INTERVAL_MS);
-    } while (Throttle::isWithinTimespanMs(start, T1000_E_AIROHA_WAKE_MS));
-#elif defined(GNSS_AIROHA)
-    serialGps->write("$PAIR382,1*2E\r\n");
-    delay(20);
-#else
-    (void)serialGps;
-#endif
-}
-
-bool isPlausibleNmeaTime(const struct tm &t)
-{
-    const int year = t.tm_year + 1900;
-    if (year < MIN_PLAUSIBLE_GPS_YEAR || year > MAX_PLAUSIBLE_GPS_YEAR) {
-        return false;
-    }
-
-#ifdef BUILD_EPOCH
-    const int64_t candidate = static_cast<int64_t>(gm_mktime(&t));
-    const int64_t minEpoch = static_cast<int64_t>(BUILD_EPOCH);
-    const int64_t maxEpoch = minEpoch + static_cast<int64_t>(FORTY_YEARS);
-    return candidate >= minEpoch && candidate <= maxEpoch;
-#else
-    return true;
-#endif
-}
-
 template <typename T> bool sawNmeaSentenceAtBaud(T *serialGps, uint32_t timeoutMs)
 {
     // Lightweight passive check: look for at least one complete
@@ -687,7 +642,7 @@ bool GPS::verifyCachedProbePresence()
         return false;
     }
 
-#if defined(ARCH_NRF52) || defined(ARCH_PORTDUINO) || defined(ARCH_STM32)
+#if defined(ARCH_NRF52) || defined(ARCH_PORTDUINO) || defined(ARCH_STM32WL)
     _serial_gps->end();
     _serial_gps->begin(cachedProbeBaud);
 #elif defined(ARCH_RP2040)
@@ -734,7 +689,6 @@ bool GPS::verifyCachedProbePresence()
     case GNSS_MODEL_AG3352:
         if (cachedProbeModel == GNSS_MODEL_AG3352)
             cachedProbeModelName = "AG3352";
-        wakeAirohaForActiveProbe(_serial_gps);
         _serial_gps->write("$PAIR021*39\r\n");
         present = (getACK("$PAIR021,", 900) == GNSS_RESPONSE_OK);
         break;
@@ -787,6 +741,7 @@ bool GPS::verifyCachedProbePresence()
     if (!present) {
         LOG_WARN("Cached GPS probe is stale (%s @ %d), clearing cache", cachedProbeModelName, cachedProbeBaud);
         clearProbeCache();
+        cachedProbeFailedThisBoot = true;
         return false;
     }
 
@@ -807,6 +762,13 @@ bool GPS::setup()
 {
     if (!didSerialInit) {
         int msglen = 0;
+        if (cachedProbeFailedThisBoot) {
+            // If cached verification failed, suppress further probing until
+            // reboot.
+            didSerialInit = true;
+            return true;
+        }
+
         if (tx_gpio && gnssModel == GNSS_MODEL_UNKNOWN) {
             if (!hasProbeCache && !triedProbeCache) {
                 (void)loadProbeCache();
@@ -815,13 +777,12 @@ bool GPS::setup()
             if (hasProbeCache && !triedProbeCache) {
                 triedProbeCache = true;
                 if (!verifyCachedProbePresence()) {
-                    currentStep = 0;
-                    speedSelect = 0;
-                    probeTries = 0;
+                    // Cache was stale and got wiped; skip scanning this boot
+                    // and let next boot do a full probe.
+                    didSerialInit = true;
+                    return true;
                 }
-            }
-
-            if (gnssModel == GNSS_MODEL_UNKNOWN && probeTries < GPS_PROBETRIES) {
+            } else if (probeTries < GPS_PROBETRIES) {
                 // No usable cache: walk common baud rates first.
                 gnssModel = probe(serialSpeeds[speedSelect]);
                 if (gnssModel != GNSS_MODEL_UNKNOWN) {
@@ -833,7 +794,7 @@ bool GPS::setup()
             }
             // Rare Serial Speeds
 #ifndef CONFIG_IDF_TARGET_ESP32C6
-            else if (gnssModel == GNSS_MODEL_UNKNOWN && probeTries == GPS_PROBETRIES) {
+            else if (probeTries == GPS_PROBETRIES) {
                 // Then try less common baud rates before giving up.
                 gnssModel = probe(rareSerialSpeeds[speedSelect]);
                 if (gnssModel != GNSS_MODEL_UNKNOWN) {
@@ -1160,22 +1121,10 @@ void GPS::setPowerState(GPSPowerState newState, uint32_t sleepTime)
     switch (newState) {
     case GPS_ACTIVE:
     case GPS_IDLE:
-        if (oldState == GPS_ACTIVE)
-            break;
-        gotTime = false;
-        if (oldState == GPS_IDLE) // If hardware already awake, no changes needed
+        if (oldState == GPS_ACTIVE || oldState == GPS_IDLE) // If hardware already awake, no changes needed
             break;
         if (oldState != GPS_ACTIVE && oldState != GPS_IDLE) // If hardware just waking now, clear buffer
             clearBuffer();
-#ifdef TRACKER_T1000_E
-        pinMode(GPS_VRTC_EN, OUTPUT);
-        digitalWrite(GPS_VRTC_EN, HIGH);
-        pinMode(GPS_SLEEP_INT, OUTPUT);
-        digitalWrite(GPS_SLEEP_INT, HIGH);
-        pinMode(GPS_RTC_INT, OUTPUT);
-        digitalWrite(GPS_RTC_INT, LOW);
-        pinMode(GPS_RESETB_OUT, INPUT_PULLUP);
-#endif
         powerMon->setState(meshtastic_PowerMon_State_GPS_Active); // Report change for power monitoring (during testing)
         writePinEN(true);                                         // Power (EN pin): on
         setPowerPMU(true);                                        // Power (PMU): on
@@ -1434,8 +1383,9 @@ int32_t GPS::runOnce()
         if (!setup())
             return currentDelay; // Setup failed, re-run in two seconds
 
-        if (gnssModel == GNSS_MODEL_UNKNOWN) {
-            LOG_WARN("GPS not detected; marked not present for this boot");
+        if (cachedProbeFailedThisBoot || gnssModel == GNSS_MODEL_UNKNOWN) {
+            LOG_WARN("GPS not detected at cached settings; marked not present "
+                     "for this boot");
             return disable();
         }
 
@@ -1487,7 +1437,8 @@ int32_t GPS::runOnce()
         // if gps_update_interval is <=10s, GPS never goes off, so we treat that differently
         uint32_t updateInterval = Default::getConfiguredOrDefaultMs(config.position.gps_update_interval);
 
-        // 1. Got a time for the first time this cycle
+        // 1. Got a time for the first time
+        bool gotTime = (getRTCQuality() >= RTCQualityGPS);
         if (!gotTime && lookForTime()) { // Note: we count on this && short-circuiting and not resetting the RTC time
             gotTime = true;
         }
@@ -1613,7 +1564,7 @@ GnssModel_t GPS::probe(int serialSpeed)
 
     switch (currentStep) {
     case 0: {
-#if defined(ARCH_NRF52) || defined(ARCH_PORTDUINO) || defined(ARCH_STM32)
+#if defined(ARCH_NRF52) || defined(ARCH_PORTDUINO) || defined(ARCH_STM32WL)
         _serial_gps->end();
         _serial_gps->begin(serialSpeed);
 #elif defined(ARCH_RP2040)
@@ -1634,9 +1585,6 @@ GnssModel_t GPS::probe(int serialSpeed)
         digitalWrite(PIN_GPS_RESET, GPS_RESET_MODE); // assert for 10ms
         delay(10);
         digitalWrite(PIN_GPS_RESET, !GPS_RESET_MODE);
-#ifdef TRACKER_T1000_E
-        delay(100);
-#endif
 
         // attempt to detect the chip based on boot messages
         std::vector<ChipInfo> passive_detect = {
@@ -1689,7 +1637,6 @@ GnssModel_t GPS::probe(int serialSpeed)
     }
     case 3: {
         /* Airoha (Mediatek) AG3335A/M/S, A3352Q, Quectel L89 2.0, SimCom SIM65M */
-        wakeAirohaForActiveProbe(_serial_gps);
         _serial_gps->write("$PAIR062,2,0*3C\r\n"); // GSA OFF to reduce volume
         _serial_gps->write("$PAIR062,3,0*3D\r\n"); // GSV OFF to reduce volume
         _serial_gps->write("$PAIR513*3D\r\n");     // save configuration
@@ -1974,7 +1921,7 @@ std::unique_ptr<GPS> GPS::createGps()
 #elif defined(ARCH_NRF52)
         _serial_gps->setPins(new_gps->rx_gpio, new_gps->tx_gpio);
         _serial_gps->begin(GPS_BAUDRATE);
-#elif defined(ARCH_STM32)
+#elif defined(ARCH_STM32WL)
         _serial_gps->setTx(new_gps->tx_gpio);
         _serial_gps->setRx(new_gps->rx_gpio);
         _serial_gps->begin(GPS_BAUDRATE);
@@ -2021,9 +1968,6 @@ The Unix epoch (or Unix time or POSIX time or Unix timestamp) is the number of s
         t.tm_year = d.year() - 1900;
         t.tm_isdst = false;
         if (t.tm_mon > -1) {
-            if (!isPlausibleNmeaTime(t)) {
-                return false;
-            }
             if (perhapsSetRTC(RTCQualityGPS, t) == RTCSetResultSuccess) {
                 LOG_DEBUG("NMEA GPS time set %02d-%02d-%02d %02d:%02d:%02d age %d", d.year(), d.month(), t.tm_mday, t.tm_hour,
                           t.tm_min, t.tm_sec, ti.age());

src/gps/GPS.h

@@ -174,7 +174,6 @@ class GPS : private concurrency::OSThread
     uint32_t lastChecksumFailCount = 0;
     uint8_t currentStep = 0;
     int32_t currentDelay = 2000;
-    bool gotTime = false;
 
 #ifndef TINYGPS_OPTION_NO_CUSTOM_FIELDS
     // (20210908) TinyGps++ can only read the GPGSA "FIX TYPE" field
@@ -194,6 +193,8 @@ class GPS : private concurrency::OSThread
     bool hasProbeCache = false;
     // Ensures cached probe is attempted once per boot.
     bool triedProbeCache = false;
+    // Latched when cached presence check fails
+    bool cachedProbeFailedThisBoot = false;
 
     /**
      * hasValidLocation - indicates that the position variables contain a complete

src/gps/RTC.cpp

@@ -31,63 +31,13 @@ static uint32_t
     timeStartMsec; // Once we have a GPS lock, this is where we hold the initial msec clock that corresponds to that time
 static uint64_t zeroOffsetSecs; // GPS based time in secs since 1970 - only updated once on initial lock
 
-#ifdef PIO_UNIT_TESTING
-// Test seam: unit tests can inject a fake system clock (e.g. the uptime seconds that
-// gettimeofday() returns on boards without a real RTC, like RP2040) and force readFromRTC()
-// down the no-hardware-RTC fallback even when a hardware-RTC branch is compiled in.
-static bool hasMockSystemTime = false;
-static bool forceSystemTimeFallback = false;
-static struct timeval mockSystemTime = {};
-#endif
-
-// Reads the platform system clock (or the injected mock during unit tests). Used only by the
-// no-hardware-RTC fallback below, so it may be unused on builds with a hardware RTC.
-[[maybe_unused]] static bool readSystemTime(struct timeval *tv)
-{
-#ifdef PIO_UNIT_TESTING
-    if (hasMockSystemTime) {
-        *tv = mockSystemTime;
-        return true;
-    }
-#endif
-    return gettimeofday(tv, NULL) == 0;
-}
-
-// Seeds the clock from the system time on boards without a hardware RTC. gettimeofday() can
-// return uptime rather than wall-clock time there (e.g. RP2040), so only adopt it when we have
-// nothing better yet -- never clobber a higher-quality GPS/NTP/phone source (issue #9828).
-[[maybe_unused]] static RTCSetResult readFromSystemTimeFallback()
-{
-    struct timeval tv;
-    if (readSystemTime(&tv)) {
-        uint32_t now = millis();
-        uint32_t printableEpoch = tv.tv_sec; // Print lib only supports 32 bit but time_t can be 64 bit on some platforms
-        if (currentQuality == RTCQualityNone) {
-            LOG_DEBUG("Seed time from system clock: %lu", (unsigned long)printableEpoch);
-            timeStartMsec = now;
-            zeroOffsetSecs = tv.tv_sec;
-        } else {
-            LOG_DEBUG("Ignore system clock fallback (%lu); current RTC quality is %s", (unsigned long)printableEpoch,
-                      RtcName(currentQuality));
-        }
-        return RTCSetResultSuccess;
-    }
-    return RTCSetResultNotSet;
-}
-
 /**
- * Reads date/time from the RTC module (or system-time fallback) and seeds internal timekeeping.
- * @return RTCSetResultSuccess if a time source was read successfully (even if an existing higher-quality time is retained).
+ * Reads the current date and time from the RTC module and updates the system time.
+ * @return True if the RTC was successfully read and the system time was updated, false otherwise.
  */
 RTCSetResult readFromRTC()
 {
-#ifdef PIO_UNIT_TESTING
-    if (forceSystemTimeFallback) {
-        return readFromSystemTimeFallback();
-    }
-#endif
-
-    [[maybe_unused]] struct timeval tv; /* btw settimeofday() is helpful here too*/
+    struct timeval tv; /* btw settimeofday() is helpful here too*/
 #ifdef RV3028_RTC
     if (rtc_found.address == RV3028_RTC) {
         uint32_t now = millis();
@@ -212,7 +162,14 @@ RTCSetResult readFromRTC()
         }
     }
 #else
-    return readFromSystemTimeFallback();
+    if (!gettimeofday(&tv, NULL)) {
+        uint32_t now = millis();
+        uint32_t printableEpoch = tv.tv_sec; // Print lib only supports 32 bit but time_t can be 64 bit on some platforms
+        LOG_DEBUG("Read RTC time as %ld", printableEpoch);
+        timeStartMsec = now;
+        zeroOffsetSecs = tv.tv_sec;
+        return RTCSetResultSuccess;
+    }
 #endif
     return RTCSetResultNotSet;
 }
@@ -262,8 +219,8 @@ RTCSetResult perhapsSetRTC(RTCQuality q, const struct timeval *tv, bool forceUpd
     } else if (q == RTCQualityGPS) {
         shouldSet = true;
         LOG_DEBUG("Reapply GPS time: %ld secs", printableEpoch);
-    } else if (q == RTCQualityNTP && !Throttle::isWithinTimespanMs(lastSetMsec, (30 * 60 * 1000UL))) {
-        // Every 30 minutes we will slam in a new NTP or Phone GPS / NTP time, to correct for local RTC clock drift
+    } else if (q == RTCQualityNTP && !Throttle::isWithinTimespanMs(lastSetMsec, (12 * 60 * 60 * 1000UL))) {
+        // Every 12 hrs we will slam in a new NTP or Phone GPS / NTP time, to correct for local RTC clock drift
         shouldSet = true;
         LOG_DEBUG("Reapply external time to correct clock drift %ld secs", printableEpoch);
     } else {
@@ -335,7 +292,7 @@ RTCSetResult perhapsSetRTC(RTCQuality q, const struct timeval *tv, bool forceUpd
                 LOG_WARN("Failed to set time for RX8130CE");
             }
         }
-#elif defined(ARCH_ESP32) || defined(ARCH_RP2040)
+#elif defined(ARCH_ESP32)
         settimeofday(tv, NULL);
 #endif
 
@@ -466,38 +423,6 @@ void setBootRelativeTimeForUnitTest(uint32_t secondsSinceBoot)
     lastSetFromPhoneNtpOrGps = 0;
     lastTimeValidationWarning = 0;
 }
-
-void clearRTCSystemTimeForTests()
-{
-    hasMockSystemTime = false;
-    mockSystemTime = {};
-}
-
-void setRTCSystemTimeForTests(const struct timeval *tv)
-{
-    if (tv == NULL) {
-        clearRTCSystemTimeForTests();
-        return;
-    }
-    mockSystemTime = *tv;
-    hasMockSystemTime = true;
-}
-
-void setReadFromRTCUseSystemTimeForTests(bool enabled)
-{
-    forceSystemTimeFallback = enabled;
-}
-
-void resetRTCStateForTests()
-{
-    currentQuality = RTCQualityNone;
-    timeStartMsec = 0;
-    zeroOffsetSecs = 0;
-    lastSetFromPhoneNtpOrGps = 0;
-    lastTimeValidationWarning = 0;
-    setReadFromRTCUseSystemTimeForTests(false);
-    clearRTCSystemTimeForTests();
-}
 #endif
 
 time_t gm_mktime(const struct tm *tm)

src/gps/RTC.h

@@ -56,10 +56,6 @@ RTCSetResult readFromRTC();
 
 #ifdef PIO_UNIT_TESTING
 void setBootRelativeTimeForUnitTest(uint32_t secondsSinceBoot);
-void resetRTCStateForTests();
-void setRTCSystemTimeForTests(const struct timeval *tv);
-void clearRTCSystemTimeForTests();
-void setReadFromRTCUseSystemTimeForTests(bool enabled);
 #endif
 
 time_t gm_mktime(const struct tm *tm);

src/graphics/Screen.cpp

@@ -39,10 +39,8 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #include "draw/NodeListRenderer.h"
 #include "draw/NotificationRenderer.h"
 #include "draw/UIRenderer.h"
-#include "graphics/fonts/OLEDDisplayFontsZH.h"
 #include "graphics/TFTColorRegions.h"
 #include "modules/CannedMessageModule.h"
-#include "security/LockdownDisplay.h"
 
 #if !MESHTASTIC_EXCLUDE_GPS
 #include "GPS.h"
@@ -61,7 +59,6 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #include "graphics/TFTPalette.h"
 #include "graphics/emotes.h"
 #include "graphics/images.h"
-#include "graphics/l10n/Strings.h"
 #include "input/TouchScreenImpl1.h"
 #include "main.h"
 #include "mesh-pb-constants.h"
@@ -122,77 +119,8 @@ static inline void prepareFrameColorRegions()
 }
 #endif
 
-#ifdef MESHTASTIC_LOCKDOWN
-// Static lock screen drawn in place of normal frames when
-// meshtastic_security::shouldRedactDisplay() returns true. Renders centered
-// "LOCKED" plus battery so the operator can see the device is alive and
-// charged without leaking any node/channel/message/position content.
-// Draw the LOCKED frame into the host-side framebuffer. Does NOT commit
-// to the panel — the caller is responsible for calling display->display()
-// once it has composited any overlays on top. Committing here would cause
-// visible flicker between "just LOCKED" and "LOCKED + banner overlay" when
-// the pairing-PIN special-case in updateUiFrame paints the overlay after
-// this returns.
-static void drawLockdownLockScreenIntoBuffer(OLEDDisplay *display)
-{
-    display->clear();
-
-    const int w = display->getWidth();
-    const int h = display->getHeight();
-
-    display->setTextAlignment(TEXT_ALIGN_CENTER);
-    display->setFont(FONT_LARGE);
-    display->drawString(w / 2, h / 2 - FONT_HEIGHT_LARGE, meshtastic::l10n::getString(meshtastic::l10n::StringKey::LOCKED));
-
-    display->setFont(FONT_SMALL);
-    char status[32];
-    strncpy(status, meshtastic::l10n::getString(meshtastic::l10n::StringKey::ConnectToUnlock), 31);
-    if (powerStatus && powerStatus->getHasBattery()) {
-        int pct = powerStatus->getBatteryChargePercent();
-        snprintf(status, sizeof(status), "Battery %d%%", pct);
-    }
-    display->drawString(w / 2, h / 2 + 2, status);
-}
-
-// Convenience wrapper for callers that want the LOCKED frame committed
-// to the panel immediately and have no overlay to compose on top.
-static void drawLockdownLockScreen(OLEDDisplay *display)
-{
-    drawLockdownLockScreenIntoBuffer(display);
-    display->display();
-}
-#endif
-
 static inline void updateUiFrame(OLEDDisplayUi *ui)
 {
-#ifdef MESHTASTIC_LOCKDOWN
-    if (meshtastic_security::shouldRedactDisplay() && screen != nullptr) {
-        OLEDDisplay *display = screen->getDisplayDevice();
-        // Paint LOCKED into the framebuffer WITHOUT committing. We commit
-        // exactly once at the bottom — after any overlay has been composed
-        // on top — so the panel never visibly transitions from "just LOCKED"
-        // to "LOCKED + overlay" mid-frame. Committing twice per cycle was
-        // the source of the H13 flicker.
-        drawLockdownLockScreenIntoBuffer(display);
-        // Special-case the BLE pairing PIN banner. The PIN is needed to
-        // complete first-pair against a locked device, but the lockdown
-        // short-circuit would otherwise hide the PIN entirely. The PIN is
-        // a per-attempt ephemeral pair-handshake artifact, not operator
-        // content, so compositing it over the LOCKED frame is safe.
-        //
-        // Calling ui->update() here would be wrong: it redraws the current
-        // carousel frame (the dashboard) into the framebuffer before the
-        // overlay paints, leaving operator content visible underneath the
-        // banner. Instead we invoke the banner overlay callback directly,
-        // which paints only the banner box on top of the LOCKED pixels we
-        // already have in the framebuffer.
-        if (NotificationRenderer::current_notification_type == notificationTypeEnum::pairing_pin) {
-            NotificationRenderer::drawBannercallback(display, ui->getUiState());
-        }
-        display->display();
-        return;
-    }
-#endif
 #if GRAPHICS_TFT_COLORING_ENABLED
     prepareFrameColorRegions();
 #endif
@@ -236,16 +164,6 @@ static inline float wrapHeading360(float heading)
     return heading;
 }
 
-static inline float wrapDelta180(float delta)
-{
-    if (delta > 180.0f) {
-        delta -= 360.0f;
-    } else if (delta < -180.0f) {
-        delta += 360.0f;
-    }
-    return delta;
-}
-
 void Screen::setHeading(float heading)
 {
     const float wrappedHeading = wrapHeading360(heading);
@@ -257,30 +175,37 @@ void Screen::setHeading(float heading)
     }
 
     // Interpolate using shortest-path angular delta to avoid jumps around 0/360.
-    float delta = wrapDelta180(wrappedHeading - compassHeading);
+    float delta = wrappedHeading - compassHeading;
+    if (delta > 180.0f) {
+        delta -= 360.0f;
+    } else if (delta < -180.0f) {
+        delta += 360.0f;
+    }
 
     // Adaptive filtering:
     // - Strong damping for tiny deltas (jitter)
     // - Faster response for larger turns
     const float absDelta = (delta >= 0.0f) ? delta : -delta;
-    if (absDelta >= 1.0f) {
-        float alpha = 0.35f;
-        if (absDelta > 25.0f) {
-            alpha = 0.85f;
-        } else if (absDelta > 10.0f) {
-            alpha = 0.65f;
-        }
-
-        float step = delta * alpha;
-        const float maxStep = 12.0f;
-        if (step > maxStep) {
-            step = maxStep;
-        } else if (step < -maxStep) {
-            step = -maxStep;
-        }
-
-        compassHeading = wrapHeading360(compassHeading + step);
+    if (absDelta < 1.0f) {
+        return;
     }
+
+    float alpha = 0.35f;
+    if (absDelta > 25.0f) {
+        alpha = 0.85f;
+    } else if (absDelta > 10.0f) {
+        alpha = 0.65f;
+    }
+
+    float step = delta * alpha;
+    const float maxStep = 12.0f;
+    if (step > maxStep) {
+        step = maxStep;
+    } else if (step < -maxStep) {
+        step = -maxStep;
+    }
+
+    compassHeading = wrapHeading360(compassHeading + step);
 }
 
 // ==============================
@@ -658,21 +583,6 @@ void Screen::handleSetOn(bool on, FrameCallback einkScreensaver)
             setScreensaverFrames(einkScreensaver);
 #endif
 
-#ifdef MESHTASTIC_LOCKDOWN
-            // M19: before turning the panel off, paint a safe frame into the
-            // OLED's GDDRAM. The panel retains whatever was last written even
-            // while powered down, so when displayOn() is called later the
-            // screen would otherwise flash the previous frame's content for
-            // 16-50 ms before the next ui->update() lands. Painting the
-            // LOCKED frame now ensures the only thing the operator (or
-            // someone over their shoulder) can see on wake is the redacted
-            // view. Gated on lockdown — non-lockdown builds keep the
-            // previous frame as a UX cue that the display is just dimmed.
-            // dispdev is dereferenced unguarded throughout this file (incl.
-            // displayOff() just below), so no null check here.
-            drawLockdownLockScreen(dispdev);
-#endif
-
 #ifdef PIN_EINK_EN
             digitalWrite(PIN_EINK_EN, LOW);
 #elif defined(PCA_PIN_EINK_EN)
@@ -734,10 +644,7 @@ void Screen::setup()
     // Enable display rendering
     useDisplay = true;
 
-    // Set the runtime display language from persisted config
-    meshtastic::l10n::currentDisplayLanguage = uiconfig.language;
-
-    // Load brightness from UI config
+    // Load saved brightness from UI config
     // For OLED displays (SSD1306), default brightness is 255 if not set
     if (uiconfig.screen_brightness == 0) {
 #if defined(USE_OLED) || defined(USE_SSD1306) || defined(USE_SH1106) || defined(USE_SH1107)
@@ -795,27 +702,6 @@ void Screen::setup()
 #endif
     LOG_INFO("Applied screen brightness: %d", brightness);
 
-#if defined(MESHTASTIC_LOCKDOWN) && defined(USE_EINK)
-    // M20: e-ink panels physically retain the last-rendered image without
-    // power, so a power-cycled lockdown handheld would keep showing
-    // operator-identifying content (position, messages, node info) until
-    // the firmware's first natural refresh — which on e-ink can be seconds
-    // into boot. Force a full refresh to the LOCKED frame here, immediately
-    // after the display is initialised and before any other rendering, so
-    // the persistent pixels are wiped to the redacted view before an
-    // observer can see them.
-    if (meshtastic_security::shouldRedactDisplay()) {
-        drawLockdownLockScreen(dispdev);
-#if defined(USE_EINK_PARALLELDISPLAY)
-        // Parallel-display variants drive refresh through a different path;
-        // a bare drawLockdownLockScreen above lands the frame into the
-        // panel buffer and the next ui->update() commits it as normal.
-#else
-        static_cast<EInkDisplay *>(dispdev)->forceDisplay();
-#endif
-    }
-#endif
-
     // Set custom overlay callbacks
     static OverlayCallback overlays[] = {
         graphics::UIRenderer::drawNavigationBar // Custom indicator icons for each frame
@@ -825,9 +711,6 @@ void Screen::setup()
     // Enable UTF-8 to display mapping
     dispdev->setFontTableLookupFunction(customFontTableLookup);
 
-    // Load CJK (Chinese) font if language requires it
-    loadCJKFontIfNeeded();
-
 #ifdef USERPREFS_OEM_TEXT
     logo_timeout *= 2; // Give more time for branded boot logos
 #endif
@@ -837,7 +720,7 @@ void Screen::setup()
     alertFrames[0] = [this](OLEDDisplay *display, OLEDDisplayUiState *state, int16_t x, int16_t y) {
 #ifdef ARCH_ESP32
         if (wakeCause == ESP_SLEEP_WAKEUP_TIMER || wakeCause == ESP_SLEEP_WAKEUP_EXT1)
-            graphics::UIRenderer::drawFrameText(display, state, x, y, meshtastic::l10n::getString(meshtastic::l10n::StringKey::Resuming));
+            graphics::UIRenderer::drawFrameText(display, state, x, y, "Resuming...");
         else
 #endif
         {
@@ -926,16 +809,10 @@ void Screen::setOn(bool on, FrameCallback einkScreensaver)
     if (cardKbI2cImpl)
         cardKbI2cImpl->toggleBacklight(on);
 #endif
-    if (!on) {
-#ifdef MESHTASTIC_LOCKDOWN
-        // Screen powering off (idle timeout, shutdown, deep sleep) latches
-        // the screen-lock. Next time the display wakes it shows the LOCKED
-        // frame until a client authenticates with the passphrase.
-        meshtastic_security::lockScreen();
-#endif
+    if (!on)
         // We handle off commands immediately, because they might be called because the CPU is shutting down
         handleSetOn(false, einkScreensaver);
-    } else
+    else
         enqueueCmd(ScreenCmd{.cmd = Cmd::SET_ON});
 }
 
@@ -994,13 +871,6 @@ int32_t Screen::runOnce()
         return RUN_SAME;
     }
 
-    // Detect language changes from remote config (phone app)
-    if (uiconfig.language != meshtastic::l10n::currentDisplayLanguage) {
-        meshtastic::l10n::currentDisplayLanguage = uiconfig.language;
-        loadCJKFontIfNeeded();
-        setFrames(FOCUS_PRESERVE);
-    }
-
     if (displayHeight == 0) {
         displayHeight = dispdev->getHeight();
     }
@@ -1049,17 +919,7 @@ int32_t Screen::runOnce()
 #endif
 
 #ifndef DISABLE_WELCOME_UNSET
-    bool suppressRegionOnboard = false;
-#ifdef MESHTASTIC_LOCKDOWN
-    // While lockdown is active and storage is still locked, config.lora.region
-    // is a deliberate UNSET placeholder — the real region lives in encrypted
-    // storage and is restored on unlock (see NodeDB's locked-boot path). Don't
-    // pop the region picker over the lock screen: it would trap input, and the
-    // operator can't set a region until they unlock anyway.
-    suppressRegionOnboard = meshtastic_security::shouldRedactDisplay();
-#endif
-    if (!suppressRegionOnboard && !NotificationRenderer::isOverlayBannerShowing() &&
-        config.lora.region == meshtastic_Config_LoRaConfig_RegionCode_UNSET) {
+    if (!NotificationRenderer::isOverlayBannerShowing() && config.lora.region == meshtastic_Config_LoRaConfig_RegionCode_UNSET) {
 #if defined(OLED_TINY)
         menuHandler::LoraRegionPicker();
 #else
@@ -1068,7 +928,7 @@ int32_t Screen::runOnce()
     }
 #endif
     if (!NotificationRenderer::isOverlayBannerShowing() && rebootAtMsec != 0 && !suppressRebootBanner) {
-        showSimpleBanner(meshtastic::l10n::getString(meshtastic::l10n::StringKey::Rebooting), 0);
+        showSimpleBanner("Rebooting...", 0);
     }
 
     // Process incoming commands.
@@ -1775,15 +1635,6 @@ void Screen::handleStartFirmwareUpdateScreen()
 
 void Screen::blink()
 {
-#ifdef MESHTASTIC_LOCKDOWN
-    // L4: defensive guard. blink() paints arbitrary geometry, not node
-    // data, so it doesn't actually leak today. But it bypasses the normal
-    // ui->update() path that the lockdown short-circuit gates, so any
-    // future change that puts content into blink would silently leak past
-    // redaction. Refuse to draw when the redaction latch is set.
-    if (meshtastic_security::shouldRedactDisplay())
-        return;
-#endif
     setFastFramerate();
     uint8_t count = 10;
     dispdev->setBrightness(254);
@@ -2226,271 +2077,6 @@ bool Screen::isOverlayBannerShowing()
     return NotificationRenderer::isOverlayBannerShowing();
 }
 
-char Screen::customFontTableLookup(const uint8_t ch)
-{
-    static uint8_t LASTCHAR;
-    static bool SKIPREST;
-    static int8_t cjkRemaining = 0;
-
-    if (cjkRemaining > 0) {
-        cjkRemaining--;
-        LASTCHAR = ch;
-        return (uint8_t)0;
-    }
-
-    if (ch < 128) {
-        LASTCHAR = 0;
-        SKIPREST = false;
-        cjkRemaining = 0;
-        return ch;
-    }
-
-    uint8_t last = LASTCHAR;
-    LASTCHAR = ch;
-
-    switch (last) {
-    case 0xC2: {
-        SKIPREST = false;
-        return (uint8_t)ch;
-    }
-    case 0xC3: {
-        SKIPREST = false;
-        return (uint8_t)(ch | 0xC0);
-    }
-    }
-
-    if (ch == 0xC2 || ch == 0xC3)
-        return (uint8_t)0;
-
-#if defined(OLED_PL)
-    switch (last) {
-    case 0xC3: {
-        if (ch == 147)
-            return (uint8_t)(ch);
-        else if (ch == 179)
-            return (uint8_t)(148);
-        else
-            return (uint8_t)(ch | 0xC0);
-        break;
-    }
-    case 0xC4: {
-        SKIPREST = false;
-        return (uint8_t)(ch);
-    }
-    case 0xC5: {
-        SKIPREST = false;
-        if (ch == 132)
-            return (uint8_t)(136);
-        else if (ch == 186)
-            return (uint8_t)(137);
-        else
-            return (uint8_t)(ch);
-        break;
-    }
-    }
-    if (ch == 0xC2 || ch == 0xC3 || ch == 0xC4 || ch == 0xC5)
-        return (uint8_t)0;
-#endif
-
-#if defined(OLED_UA) || defined(OLED_RU)
-    switch (last) {
-    case 0xC3: {
-        SKIPREST = false;
-        return (uint8_t)(ch | 0xC0);
-    }
-    case 0xD0: {
-        SKIPREST = false;
-        if (ch == 132)
-            return (uint8_t)(170);
-        if (ch == 134)
-            return (uint8_t)(178);
-        if (ch == 135)
-            return (uint8_t)(175);
-        if (ch == 129)
-            return (uint8_t)(168);
-        if (ch > 143 && ch < 192)
-            return (uint8_t)(ch + 48);
-        break;
-    }
-    case 0xD1: {
-        SKIPREST = false;
-        if (ch == 148)
-            return (uint8_t)(186);
-        if (ch == 150)
-            return (uint8_t)(179);
-        if (ch == 151)
-            return (uint8_t)(191);
-        if (ch == 145)
-            return (uint8_t)(184);
-        if (ch > 127 && ch < 144)
-            return (uint8_t)(ch + 112);
-        break;
-    }
-    case 0xD2: {
-        SKIPREST = false;
-        if (ch == 144)
-            return (uint8_t)(165);
-        if (ch == 145)
-            return (uint8_t)(180);
-        break;
-    }
-    }
-    if (ch == 0xC2 || ch == 0xC3 || ch == 0x82 || ch == 0xD0 || ch == 0xD1)
-        return (uint8_t)0;
-#endif
-
-#if defined(OLED_CS)
-    switch (last) {
-    case 0xC2: {
-        SKIPREST = false;
-        return (uint8_t)ch;
-    }
-    case 0xC3: {
-        SKIPREST = false;
-        return (uint8_t)(ch | 0xC0);
-    }
-    case 0xC4: {
-        SKIPREST = false;
-        if (ch == 140)
-            return (uint8_t)(129);
-        if (ch == 141)
-            return (uint8_t)(138);
-        if (ch == 142)
-            return (uint8_t)(130);
-        if (ch == 143)
-            return (uint8_t)(139);
-        if (ch == 154)
-            return (uint8_t)(131);
-        if (ch == 155)
-            return (uint8_t)(140);
-        if (ch == 185)
-            return (uint8_t)(147);
-        if (ch == 186)
-            return (uint8_t)(148);
-        if (ch == 189)
-            return (uint8_t)(149);
-        if (ch == 190)
-            return (uint8_t)(150);
-        break;
-    }
-    case 0xC5: {
-        SKIPREST = false;
-        if (ch == 135)
-            return (uint8_t)(132);
-        if (ch == 136)
-            return (uint8_t)(141);
-        if (ch == 152)
-            return (uint8_t)(133);
-        if (ch == 153)
-            return (uint8_t)(142);
-        if (ch == 160)
-            return (uint8_t)(134);
-        if (ch == 161)
-            return (uint8_t)(143);
-        if (ch == 164)
-            return (uint8_t)(135);
-        if (ch == 165)
-            return (uint8_t)(144);
-        if (ch == 174)
-            return (uint8_t)(136);
-        if (ch == 175)
-            return (uint8_t)(145);
-        if (ch == 189)
-            return (uint8_t)(137);
-        if (ch == 190)
-            return (uint8_t)(146);
-        if (ch == 148)
-            return (uint8_t)(151);
-        if (ch == 149)
-            return (uint8_t)(152);
-        break;
-    }
-    }
-    if (ch == 0xC2 || ch == 0xC3 || ch == 0xC4 || ch == 0xC5)
-        return (uint8_t)0;
-#endif
-
-#if defined(OLED_GR)
-    switch (last) {
-    case 0xC3: {
-        SKIPREST = false;
-        return (uint8_t)(ch | 0xC0);
-    }
-    case 0xCE: {
-        SKIPREST = false;
-        if (ch >= 145 && ch <= 161)
-            return (uint8_t)(ch + 48);
-        else if (ch >= 163 && ch <= 169)
-            return (uint8_t)(ch + 48);
-        else if (ch >= 177 && ch <= 193)
-            return (uint8_t)(ch + 48);
-        break;
-    }
-    case 0xCF: {
-        SKIPREST = false;
-        if (ch >= 130 && ch <= 137)
-            return (uint8_t)(ch + 112);
-        break;
-    }
-    }
-    if (ch == 0xC2 || ch == 0xC3 || ch == 0xCE || ch == 0xCF)
-        return (uint8_t)0;
-#endif
-
-    if (ch >= 0xE2 && ch <= 0xEF) {
-        cjkRemaining = 2;
-        return (uint8_t)0;
-    }
-
-    if (SKIPREST)
-        return (uint8_t)0;
-    SKIPREST = true;
-
-    return (uint8_t)191;
-}
-
-void Screen::drawTextL10n(int16_t x, int16_t y, const char *text, OLEDDISPLAY_TEXT_ALIGNMENT alignment)
-{
-    if (!dispdev || !text)
-        return;
-
-#if defined(ST7735_CS) || defined(ST7789_CS) || defined(ILI9341_DRIVER) || defined(ILI9342_DRIVER) || defined(ST7701_CS) ||      \
-    defined(HX8357_CS) || defined(ILI9488_CS) || defined(ST7796_CS) || defined(RAK14014)
-    if (meshtastic::l10n::currentDisplayLanguage == meshtastic_Language_SIMPLIFIED_CHINESE ||
-        meshtastic::l10n::currentDisplayLanguage == meshtastic_Language_TRADITIONAL_CHINESE) {
-        TFTDisplay *tftDisp = static_cast<TFTDisplay *>(dispdev);
-        if (tftDisp->hasCJKFont()) {
-            tftDisp->drawStringCJK(x, y, text);
-            return;
-        }
-    }
-#endif
-
-    dispdev->setTextAlignment(alignment);
-    dispdev->drawString(x, y, text);
-}
-
-void Screen::setFontL10n(const uint8_t *fontData)
-{
-    if (!dispdev)
-        return;
-    dispdev->setFont(fontData);
-}
-
-void Screen::loadCJKFontIfNeeded()
-{
-#if defined(ST7735_CS) || defined(ST7789_CS) || defined(ILI9341_DRIVER) || defined(ILI9342_DRIVER) || defined(ST7701_CS) ||      \
-    defined(HX8357_CS) || defined(ILI9488_CS) || defined(ST7796_CS) || defined(RAK14014)
-    if (meshtastic::l10n::currentDisplayLanguage == meshtastic_Language_SIMPLIFIED_CHINESE ||
-        meshtastic::l10n::currentDisplayLanguage == meshtastic_Language_TRADITIONAL_CHINESE) {
-        TFTDisplay *tftDisp = static_cast<TFTDisplay *>(dispdev);
-        if (!tftDisp->hasCJKFont()) {
-            tftDisp->loadCJKFont(FontZH_CN_16, FontZH_CN_16_size);
-        }
-    }
-#endif
-}
-
 } // namespace graphics
 
 #else

src/graphics/Screen.h

@@ -12,21 +12,7 @@
 #define getStringCenteredX(s) ((SCREEN_WIDTH - display->getStringWidth(s)) / 2)
 namespace graphics
 {
-enum notificationTypeEnum {
-    none,
-    text_banner,
-    selection_picker,
-    node_picker,
-    number_picker,
-    hex_picker,
-    text_input,
-    // BLE pairing PIN banner. Treated specially by the lockdown short-circuit
-    // in Screen.cpp: the PIN is ephemeral (regenerated per pair attempt) and
-    // not a real secret, so we allow ui->update() to composite it over the
-    // LOCKED frame. Without this, a first-pair on a locked device cannot
-    // complete because the PIN never renders.
-    pairing_pin,
-};
+enum notificationTypeEnum { none, text_banner, selection_picker, node_picker, number_picker, hex_picker, text_input };
 
 struct BannerOverlayOptions {
     const char *message;
@@ -366,13 +352,255 @@ class Screen : public concurrency::OSThread
         enqueueCmd(ScreenCmd{.cmd = Cmd::NOOP});
     }
 
-    static char customFontTableLookup(const uint8_t ch);
+    /// Overrides the default utf8 character conversion, to replace empty space with question marks
+    static char customFontTableLookup(const uint8_t ch)
+    {
+        // UTF-8 to font table index converter
+        // Code from http://playground.arduino.cc/Main/Utf8ascii
+        static uint8_t LASTCHAR;
+        static bool SKIPREST; // Only display a single unconvertable-character symbol per sequence of unconvertable characters
 
-    void drawTextL10n(int16_t x, int16_t y, const char *text, OLEDDISPLAY_TEXT_ALIGNMENT alignment = TEXT_ALIGN_LEFT);
-    void setFontL10n(const uint8_t *fontData);
+        if (ch < 128) { // Standard ASCII-set 0..0x7F handling
+            LASTCHAR = 0;
+            SKIPREST = false;
+            return ch;
+        }
 
-    // Load CJK font if language requires it (called from setup & on language change)
-    void loadCJKFontIfNeeded();
+        uint8_t last = LASTCHAR; // get last char
+        LASTCHAR = ch;
+
+        switch (last) {
+        case 0xC2: {
+            SKIPREST = false;
+            return (uint8_t)ch;
+        }
+
+        case 0xC3: {
+            SKIPREST = false;
+            return (uint8_t)(ch | 0xC0);
+        }
+        }
+
+        // We want to strip out prefix chars for two-byte char formats
+        if (ch == 0xC2 || ch == 0xC3)
+            return (uint8_t)0;
+
+#if defined(OLED_PL)
+
+        switch (last) {
+        case 0xC3: {
+
+            if (ch == 147)
+                return (uint8_t)(ch); // Ó
+            else if (ch == 179)
+                return (uint8_t)(148); // ó
+            else
+                return (uint8_t)(ch | 0xC0);
+            break;
+        }
+
+        case 0xC4: {
+            SKIPREST = false;
+            return (uint8_t)(ch);
+        }
+
+        case 0xC5: {
+            SKIPREST = false;
+            if (ch == 132)
+                return (uint8_t)(136); // ń
+            else if (ch == 186)
+                return (uint8_t)(137); // ź
+            else
+                return (uint8_t)(ch);
+            break;
+        }
+        }
+
+        // We want to strip out prefix chars for two-byte char formats
+        if (ch == 0xC2 || ch == 0xC3 || ch == 0xC4 || ch == 0xC5)
+            return (uint8_t)0;
+
+#endif
+
+#if defined(OLED_UA) || defined(OLED_RU)
+
+        switch (last) {
+        case 0xC3: {
+            SKIPREST = false;
+            return (uint8_t)(ch | 0xC0);
+        }
+        // map UTF-8 cyrillic chars to it Windows-1251 (CP-1251) ASCII codes
+        // note: in this case we must use compatible font - provided ArialMT_Plain_10/16/24 by 'ThingPulse/esp8266-oled-ssd1306'
+        // library have empty chars for non-latin ASCII symbols
+        case 0xD0: {
+            SKIPREST = false;
+            if (ch == 132)
+                return (uint8_t)(170); // Є
+            if (ch == 134)
+                return (uint8_t)(178); // І
+            if (ch == 135)
+                return (uint8_t)(175); // Ї
+            if (ch == 129)
+                return (uint8_t)(168); // Ё
+            if (ch > 143 && ch < 192)
+                return (uint8_t)(ch + 48);
+            break;
+        }
+        case 0xD1: {
+            SKIPREST = false;
+            if (ch == 148)
+                return (uint8_t)(186); // є
+            if (ch == 150)
+                return (uint8_t)(179); // і
+            if (ch == 151)
+                return (uint8_t)(191); // ї
+            if (ch == 145)
+                return (uint8_t)(184); // ё
+            if (ch > 127 && ch < 144)
+                return (uint8_t)(ch + 112);
+            break;
+        }
+        case 0xD2: {
+            SKIPREST = false;
+            if (ch == 144)
+                return (uint8_t)(165); // Ґ
+            if (ch == 145)
+                return (uint8_t)(180); // ґ
+            break;
+        }
+        }
+
+        // We want to strip out prefix chars for two-byte char formats
+        if (ch == 0xC2 || ch == 0xC3 || ch == 0x82 || ch == 0xD0 || ch == 0xD1)
+            return (uint8_t)0;
+
+#endif
+
+#if defined(OLED_CS)
+
+        switch (last) {
+        case 0xC2: {
+            SKIPREST = false;
+            return (uint8_t)ch;
+        }
+
+        case 0xC3: {
+            SKIPREST = false;
+            return (uint8_t)(ch | 0xC0);
+        }
+
+        case 0xC4: {
+            SKIPREST = false;
+            if (ch == 140)
+                return (uint8_t)(129); // Č
+            if (ch == 141)
+                return (uint8_t)(138); // č
+            if (ch == 142)
+                return (uint8_t)(130); // Ď
+            if (ch == 143)
+                return (uint8_t)(139); // ď
+            if (ch == 154)
+                return (uint8_t)(131); // Ě
+            if (ch == 155)
+                return (uint8_t)(140); // ě
+            // Slovak specific glyphs
+            if (ch == 185)
+                return (uint8_t)(147); // Ĺ
+            if (ch == 186)
+                return (uint8_t)(148); // ĺ
+            if (ch == 189)
+                return (uint8_t)(149); // Ľ
+            if (ch == 190)
+                return (uint8_t)(150); // ľ
+            break;
+        }
+
+        case 0xC5: {
+            SKIPREST = false;
+            if (ch == 135)
+                return (uint8_t)(132); // Ň
+            if (ch == 136)
+                return (uint8_t)(141); // ň
+            if (ch == 152)
+                return (uint8_t)(133); // Ř
+            if (ch == 153)
+                return (uint8_t)(142); // ř
+            if (ch == 160)
+                return (uint8_t)(134); // Š
+            if (ch == 161)
+                return (uint8_t)(143); // š
+            if (ch == 164)
+                return (uint8_t)(135); // Ť
+            if (ch == 165)
+                return (uint8_t)(144); // ť
+            if (ch == 174)
+                return (uint8_t)(136); // Ů
+            if (ch == 175)
+                return (uint8_t)(145); // ů
+            if (ch == 189)
+                return (uint8_t)(137); // Ž
+            if (ch == 190)
+                return (uint8_t)(146); // ž
+            // Slovak specific glyphs
+            if (ch == 148)
+                return (uint8_t)(151); // Ŕ
+            if (ch == 149)
+                return (uint8_t)(152); // ŕ
+            break;
+        }
+        }
+
+        // We want to strip out prefix chars for two-byte char formats
+        if (ch == 0xC2 || ch == 0xC3 || ch == 0xC4 || ch == 0xC5)
+            return (uint8_t)0;
+
+#endif
+
+#if defined(OLED_GR)
+
+        switch (last) {
+        case 0xC3: {
+            SKIPREST = false;
+            return (uint8_t)(ch | 0xC0);
+        }
+        // Map UTF-8 Greek chars to Windows-1253 (CP-1253) ASCII codes
+        case 0xCE: {
+            SKIPREST = false;
+            // Uppercase Greek: Α-Ρ (U+0391-U+03A1) -> CP-1253 193-209
+            if (ch >= 145 && ch <= 161)
+                return (uint8_t)(ch + 48);
+            // Uppercase Greek: Σ-Ω (U+03A3-U+03A9) -> CP-1253 211-217
+            else if (ch >= 163 && ch <= 169)
+                return (uint8_t)(ch + 48);
+            // Lowercase Greek: α-ρ (U+03B1-U+03C1) -> CP-1253 225-241
+            else if (ch >= 177 && ch <= 193)
+                return (uint8_t)(ch + 48);
+            break;
+        }
+        case 0xCF: {
+            SKIPREST = false;
+            // Lowercase Greek: ς-ω (U+03C2-U+03C9) -> CP-1253 242-249
+            if (ch >= 130 && ch <= 137)
+                return (uint8_t)(ch + 112);
+            break;
+        }
+        }
+
+        // We want to strip out prefix chars for two-byte Greek char formats
+        if (ch == 0xC2 || ch == 0xC3 || ch == 0xCE || ch == 0xCF)
+            return (uint8_t)0;
+
+#endif
+
+        // If we already returned an unconvertable-character symbol for this unconvertable-character sequence, return NULs for the
+        // rest of it
+        if (SKIPREST)
+            return (uint8_t)0;
+        SKIPREST = true;
+
+        return (uint8_t)191; // otherwise: return ¿ if character can't be converted (note that the font map we're using doesn't
+                             // stick to standard EASCII codes)
+    }
 
     /// Returns a handle to the DebugInfo screen.
     //

src/graphics/ScreenFonts.h

@@ -20,10 +20,6 @@
 #include "graphics/fonts/OLEDDisplayFontsGR.h"
 #endif
 
-#ifdef OLED_ZH
-#include "graphics/fonts/OLEDDisplayFontsZH.h"
-#endif
-
 #if (defined(CROWPANEL_ESP32S3_5_EPAPER) || defined(T5_S3_EPAPER_PRO)) && defined(USE_EINK)
 #include "graphics/fonts/EinkDisplayFonts.h"
 #endif

src/graphics/TFTDisplay.cpp

@@ -1533,7 +1533,8 @@ bool TFTDisplay::hasTouch(void)
 {
 #ifdef RAK14014
     return true;
-#elif !defined(M5STACK) && !defined(HACKADAY_COMMUNICATOR) && !defined(HELTEC_MESH_NODE_T096) && !defined(HELTEC_MESH_NODE_T1)
+#elif !defined(M5STACK) && !defined(HACKADAY_COMMUNICATOR) && !defined(HELTEC_MESH_NODE_T096) &&                                 \
+    !defined(HELTEC_MESH_NODE_T1)
     return tft->touch() != nullptr;
 #else
     return false;
@@ -1552,7 +1553,8 @@ bool TFTDisplay::getTouch(int16_t *x, int16_t *y)
     } else {
         return false;
     }
-#elif !defined(M5STACK) && !defined(HACKADAY_COMMUNICATOR) && !defined(HELTEC_MESH_NODE_T096) && !defined(HELTEC_MESH_NODE_T1)
+#elif !defined(M5STACK) && !defined(HACKADAY_COMMUNICATOR) && !defined(HELTEC_MESH_NODE_T096) &&                                 \
+    !defined(HELTEC_MESH_NODE_T1)
     return tft->getTouch(x, y);
 #else
     return false;
@@ -1636,35 +1638,4 @@ bool TFTDisplay::connect()
     return true;
 }
 
-bool TFTDisplay::loadCJKFont(const uint8_t *vlwData, uint32_t vlwDataLen)
-{
-    if (!tft || !vlwData || vlwDataLen == 0)
-        return false;
-    cjkFontLoaded = tft->loadFont(vlwData);
-    if (cjkFontLoaded) {
-        LOG_INFO("CJK font loaded (%u bytes)", vlwDataLen);
-    } else {
-        LOG_WARN("Failed to load CJK font");
-    }
-    return cjkFontLoaded;
-}
-
-void TFTDisplay::drawStringCJK(int16_t x, int16_t y, const char *text)
-{
-    if (!tft || !text || !cjkFontLoaded)
-        return;
-    concurrency::LockGuard g(spiLock);
-    uint16_t fgColor = getThemeDefaultOnColor();
-    tft->setTextColor(fgColor, getThemeDefaultOffColor());
-    tft->setCursor(x, y);
-    tft->print(text);
-}
-
-int16_t TFTDisplay::getStringWidthCJK(const char *text)
-{
-    if (!tft || !text || !cjkFontLoaded)
-        return 0;
-    return tft->textWidth(text);
-}
-
 #endif // USE_TFTDISPLAY

src/graphics/TFTDisplay.h

@@ -38,12 +38,6 @@ class TFTDisplay : public OLEDDisplay
     // Functions for changing display brightness
     void setDisplayBrightness(uint8_t);
 
-    // CJK (Chinese/Japanese/Korean) text rendering via LovyanGFX
-    bool loadCJKFont(const uint8_t *vlwData, uint32_t vlwDataLen);
-    void drawStringCJK(int16_t x, int16_t y, const char *text);
-    int16_t getStringWidthCJK(const char *text);
-    bool hasCJKFont() const { return cjkFontLoaded; }
-
     /**
      * shim to make the abstraction happy
      *
@@ -70,5 +64,4 @@ class TFTDisplay : public OLEDDisplay
 
     uint16_t *linePixelBuffer = nullptr;
     uint16_t *repaintChunkBuffer = nullptr;
-    bool cjkFontLoaded = false;
 };

src/graphics/draw/MenuHandler.h

@@ -56,7 +56,6 @@ class menuHandler
         DisplayUnits,
         MessageBubblesMenu,
         ThemeMenu,
-        LanguagePicker,
         HamModeConfirm,
         LicensedToNormalConfirm
     };
@@ -108,7 +107,6 @@ class menuHandler
     static void wifiBaseMenu();
     static void wifiToggleMenu();
     static void screenOptionsMenu();
-    static void languagePickerMenu();
     static void powerMenu();
     static void nodeNameLengthMenu();
     static void frameTogglesMenu();

src/graphics/draw/MessageRenderer.cpp

@@ -13,7 +13,6 @@
 #include "graphics/SharedUIDisplay.h"
 #include "graphics/TFTColorRegions.h"
 #include "graphics/TFTPalette.h"
-#include "graphics/l10n/Strings.h"
 #include "graphics/TimeFormatters.h"
 #include "graphics/emotes.h"
 #include "main.h"
@@ -76,15 +75,6 @@ void scrollDown()
 
 void drawStringWithEmotes(OLEDDisplay *display, int x, int y, const std::string &line, const Emote *emotes, int emoteCount)
 {
-#if defined(ST7735_CS) || defined(ST7789_CS) || defined(ILI9341_DRIVER) || defined(ILI9342_DRIVER) || defined(ST7701_CS) ||        \
-    defined(HX8357_CS) || defined(ILI9488_CS) || defined(ST7796_CS) || defined(RAK14014) || defined(USE_ST7789) ||                   \
-    defined(USE_ST7796)
-    if (meshtastic::l10n::currentDisplayLanguage == meshtastic_Language_SIMPLIFIED_CHINESE ||
-        meshtastic::l10n::currentDisplayLanguage == meshtastic_Language_TRADITIONAL_CHINESE) {
-        screen->drawTextL10n(x, y, line.c_str());
-        return;
-    }
-#endif
     graphics::EmoteRenderer::drawStringWithEmotes(display, x, y, line, FONT_HEIGHT_SMALL, emotes, emoteCount);
 }
 
@@ -492,7 +482,7 @@ void drawTextMessageFrame(OLEDDisplay *display, OLEDDisplayUiState *state, int16
         // Still in ALL mode and no messages at all → show placeholder
         graphics::drawCommonHeader(display, x, y, titleStr);
         didReset = false;
-        const char *messageString = meshtastic::l10n::getString(meshtastic::l10n::StringKey::NoMessages);
+        const char *messageString = "No messages";
         int center_text = (SCREEN_WIDTH / 2) - (display->getStringWidth(messageString) / 2);
         display->drawString(center_text, getTextPositions(display)[2], messageString);
         graphics::drawCommonFooter(display, x, y);

src/graphics/draw/NotificationRenderer.cpp

@@ -10,8 +10,6 @@
 #include "graphics/TFTColorRegions.h"
 #include "graphics/TFTPalette.h"
 #include "graphics/images.h"
-#include "graphics/l10n/Strings.h"
-#include "graphics/Screen.h"
 #include "input/RotaryEncoderInterruptImpl1.h"
 #include "input/UpDownInterruptImpl1.h"
 #if HAS_BUTTON
@@ -41,27 +39,6 @@ extern std::vector<std::string> functionSymbol;
 extern std::string functionSymbolString;
 extern bool hasUnreadMessage;
 
-namespace
-{
-inline bool isCJKLanguage()
-{
-    return meshtastic::l10n::currentDisplayLanguage == meshtastic_Language_SIMPLIFIED_CHINESE ||
-           meshtastic::l10n::currentDisplayLanguage == meshtastic_Language_TRADITIONAL_CHINESE;
-}
-
-inline void drawBannerText(OLEDDisplay *display, int16_t x, int16_t y, const char *text)
-{
-#if defined(ST7735_CS) || defined(ST7789_CS) || defined(ILI9341_DRIVER) || defined(ILI9342_DRIVER) || defined(ST7701_CS) ||      \
-    defined(HX8357_CS) || defined(ILI9488_CS) || defined(ST7796_CS) || defined(RAK14014)
-    if (isCJKLanguage() && ::screen) {
-        ::screen->drawTextL10n(x, y, text);
-        return;
-    }
-#endif
-    display->drawString(x, y, text);
-}
-} // namespace
-
 namespace graphics
 {
 int bannerSignalBars = -1;
@@ -207,7 +184,7 @@ void NotificationRenderer::drawSSLScreen(OLEDDisplay *display, OLEDDisplayUiStat
 {
     display->setTextAlignment(TEXT_ALIGN_CENTER);
     display->setFont(FONT_SMALL);
-    display->drawString(64 + x, y, meshtastic::l10n::getString(meshtastic::l10n::StringKey::CreatingSSLCert));
+    display->drawString(64 + x, y, "Creating SSL certificate");
 
 #ifdef ARCH_ESP32
     yield();
@@ -216,9 +193,9 @@ void NotificationRenderer::drawSSLScreen(OLEDDisplay *display, OLEDDisplayUiStat
 
     display->setFont(FONT_SMALL);
     if ((millis() / 1000) % 2) {
-        display->drawString(64 + x, FONT_HEIGHT_SMALL + y + 2, meshtastic::l10n::getString(meshtastic::l10n::StringKey::PleaseWait));
+        display->drawString(64 + x, FONT_HEIGHT_SMALL + y + 2, "Please wait . . .");
     } else {
-        display->drawString(64 + x, FONT_HEIGHT_SMALL + y + 2, meshtastic::l10n::getString(meshtastic::l10n::StringKey::PleaseWait));
+        display->drawString(64 + x, FONT_HEIGHT_SMALL + y + 2, "Please wait . .  ");
     }
 }
 
@@ -283,12 +260,6 @@ void NotificationRenderer::drawBannercallback(OLEDDisplay *display, OLEDDisplayU
         break;
     case notificationTypeEnum::text_banner:
     case notificationTypeEnum::selection_picker:
-    case notificationTypeEnum::pairing_pin:
-        // pairing_pin is rendered the same as text_banner — it's just a
-        // text banner. The split type exists only so the lockdown UI
-        // short-circuit in Screen.cpp can recognise the BLE pair-PIN
-        // banner as the one safe banner to composite over the LOCKED
-        // frame.
         drawAlertBannerOverlay(display, state);
         break;
     case notificationTypeEnum::node_picker:
@@ -942,12 +913,9 @@ void NotificationRenderer::drawNotificationBox(OLEDDisplay *display, OLEDDisplay
             display->setColor(BLACK);
             int yOffset = 3;
             if (current_notification_type == notificationTypeEnum::node_picker) {
-                if (isCJKLanguage())
-                    drawBannerText(display, textX, lineY - yOffset, lineBuffer);
-                else
-                    UIRenderer::drawStringWithEmotes(display, textX, lineY - yOffset, lineBuffer, FONT_HEIGHT_SMALL, 1, false);
+                UIRenderer::drawStringWithEmotes(display, textX, lineY - yOffset, lineBuffer, FONT_HEIGHT_SMALL, 1, false);
             } else {
-                drawBannerText(display, textX, lineY - yOffset, lineBuffer);
+                display->drawString(textX, lineY - yOffset, lineBuffer);
             }
             display->setColor(WHITE);
             lineY += (thisLineHeight - 2 - background_yOffset);
@@ -969,12 +937,9 @@ void NotificationRenderer::drawNotificationBox(OLEDDisplay *display, OLEDDisplay
                 int groupStartX = boxLeft + (boxWidth - totalWidth) / 2;
 
                 if (current_notification_type == notificationTypeEnum::node_picker) {
-                    if (isCJKLanguage())
-                        drawBannerText(display, groupStartX, lineY, lineBuffer);
-                    else
-                        UIRenderer::drawStringWithEmotes(display, groupStartX, lineY, lineBuffer, FONT_HEIGHT_SMALL, 1, false);
+                    UIRenderer::drawStringWithEmotes(display, groupStartX, lineY, lineBuffer, FONT_HEIGHT_SMALL, 1, false);
                 } else {
-                    drawBannerText(display, groupStartX, lineY, lineBuffer);
+                    display->drawString(groupStartX, lineY, lineBuffer);
                 }
 
                 int baseX = groupStartX + textWidth + gap;
@@ -1006,12 +971,9 @@ void NotificationRenderer::drawNotificationBox(OLEDDisplay *display, OLEDDisplay
                 }
             } else {
                 if (current_notification_type == notificationTypeEnum::node_picker) {
-                    if (isCJKLanguage())
-                        drawBannerText(display, textX, lineY, lineBuffer);
-                    else
-                        UIRenderer::drawStringWithEmotes(display, textX, lineY, lineBuffer, FONT_HEIGHT_SMALL, 1, false);
+                    UIRenderer::drawStringWithEmotes(display, textX, lineY, lineBuffer, FONT_HEIGHT_SMALL, 1, false);
                 } else {
-                    drawBannerText(display, textX, lineY, lineBuffer);
+                    display->drawString(textX, lineY, lineBuffer);
                 }
             }
             lineY += thisLineHeight;
@@ -1041,24 +1003,24 @@ void NotificationRenderer::drawCriticalFaultFrame(OLEDDisplay *display, OLEDDisp
     display->setTextAlignment(TEXT_ALIGN_LEFT);
     display->setFont(FONT_MEDIUM);
 
-    char tempBuf[40];
-    snprintf(tempBuf, sizeof(tempBuf), "%s #%d", meshtastic::l10n::getString(meshtastic::l10n::StringKey::CriticalFault), error_code);
+    char tempBuf[24];
+    snprintf(tempBuf, sizeof(tempBuf), "Critical fault #%d", error_code);
     display->drawString(0 + x, 0 + y, tempBuf);
     display->setTextAlignment(TEXT_ALIGN_LEFT);
     display->setFont(FONT_SMALL);
-    display->drawString(0 + x, FONT_HEIGHT_MEDIUM + y, meshtastic::l10n::getString(meshtastic::l10n::StringKey::ForHelpVisit));
+    display->drawString(0 + x, FONT_HEIGHT_MEDIUM + y, "For help, please visit \nmeshtastic.org");
 }
 
 void NotificationRenderer::drawFrameFirmware(OLEDDisplay *display, OLEDDisplayUiState *state, int16_t x, int16_t y)
 {
     display->setTextAlignment(TEXT_ALIGN_CENTER);
     display->setFont(FONT_MEDIUM);
-    display->drawString(64 + x, y, meshtastic::l10n::getString(meshtastic::l10n::StringKey::Updating));
+    display->drawString(64 + x, y, "Updating");
 
     display->setFont(FONT_SMALL);
     display->setTextAlignment(TEXT_ALIGN_LEFT);
     display->drawStringMaxWidth(0 + x, 2 + y + FONT_HEIGHT_SMALL * 2, x + display->getWidth(),
-                                meshtastic::l10n::getString(meshtastic::l10n::StringKey::PleaseBePatient));
+                                "Please be patient and do not power off.");
 }
 
 void NotificationRenderer::drawTextInput(OLEDDisplay *display, OLEDDisplayUiState *state)

src/graphics/fonts/OLEDDisplayFontsZH.cpp

@@ -1,46 +0,0 @@
-// Chinese font data (VLW format) for OLEDDisplay-based TFT rendering via LovyanGFX.
-//
-// HOW TO GENERATE FONT DATA:
-//
-// Option 1: Adafruit GFX fontconvert (simpler, fewer glyphs)
-//   brew install adafruitnrf52-gfx-fontconvert  # macOS
-//   fontconvert NotoSansSC-Regular.ttf 16 > zh_cn_16.h
-//   The output is a GFXfont struct. LovyanGFX can use this via ft_gfx type.
-//
-// Option 2: LovyanGFX VLW format (recommended, more features)
-//   Use the LovyanGFX font converter script to generate a .vlw file from TTF
-//   Then embed the .vlw binary as a byte array using xxd:
-//   xxd -i zh_font_16.vlw > zh_font_16_data.h
-//
-// Option 3: Use BDF fonts (free, text-based)
-//   WenQuanYi bitmap fonts: http://wenq.org/
-//   Convert BDF to VLW using LovyanGFX tools
-//
-// FONT SIZE GUIDELINES:
-//   - 16px: Minimum readable Chinese on 320x240 TFT (~20 chars per line)
-//   - 20px: Better readability, ~16 chars per line
-//   - 24px: Title/header text, ~13 chars per line
-//
-// CHARACTER SET RECOMMENDATIONS:
-//   - GB2312 Level 1: 3755 commonly used simplified Chinese characters
-//   - Plus ASCII 0x20-0x7E for punctuation and Latin characters
-//
-// PLACEHOLDER DATA - Replace with generated font binary:
-
-#include "OLEDDisplayFontsZH.h"
-
-// Placeholder font data.
-// Replace with actual generated VLW/Gfx font binary from a Chinese TTF file.
-// The array below is intentionally minimal - it won't render any characters
-// until real font data is provided.
-const uint8_t FontZH_CN_16[] = {
-    // VLW font file magic header would go here
-    // Format: 0x00 0x00 ...
-    // Replace with output from: xxd -i your_chinese_font.vlw
-};
-const uint32_t FontZH_CN_16_size = sizeof(FontZH_CN_16);
-
-const uint8_t FontZH_TW_16[] = {
-    // Traditional Chinese VLW font data placeholder
-};
-const uint32_t FontZH_TW_16_size = sizeof(FontZH_TW_16);

src/graphics/fonts/OLEDDisplayFontsZH.h

@@ -1,22 +0,0 @@
-#pragma once
-
-#include <cstdint>
-
-// Chinese Simplified font - VLW format (to be generated from TTF)
-//
-// HOW TO GENERATE:
-// 1. Download NotoSansSC-Regular.ttf (or any open-source Chinese font)
-// 2. Use Adafruit fontconvert tool:
-//    ./fontconvert NotoSansSC-Regular.ttf 16 > zh_cn_16_pt.h
-// 3. Copy the resulting binary data (GFXfont struct bytes) into the array below
-//
-// For LovyanGFX VLW font format, use:
-//    - The binary VLW file can be embedded as a const uint8_t[] array
-//    - Loaded with tft->loadFont(zh_font_data_array)
-
-extern const uint8_t FontZH_CN_16[];
-extern const uint32_t FontZH_CN_16_size;
-
-// Chinese Traditional font (VLW format)
-extern const uint8_t FontZH_TW_16[];
-extern const uint32_t FontZH_TW_16_size;

src/graphics/l10n/Strings.cpp

@@ -1,20 +0,0 @@
-#include "Strings.h"
-#include "Strings_EN.h"
-#include "Strings_ZH.h"
-
-namespace meshtastic
-{
-namespace l10n
-{
-
-meshtastic_Language currentDisplayLanguage = meshtastic_Language_ENGLISH;
-
-const char *getString(StringKey key, meshtastic_Language lang)
-{
-    if (lang == meshtastic_Language_SIMPLIFIED_CHINESE || lang == meshtastic_Language_TRADITIONAL_CHINESE)
-        return getStringZH(key);
-    return getStringEN(key);
-}
-
-} // namespace l10n
-} // namespace meshtastic

src/graphics/l10n/Strings.h

@@ -1,170 +0,0 @@
-#pragma once
-
-#include "mesh/generated/meshtastic/device_ui.pb.h"
-
-namespace meshtastic
-{
-namespace l10n
-{
-
-enum class StringKey : uint8_t {
-    Back,
-    OK,
-    GotIt,
-    WelcomeToMeshtastic,
-    SwipeToNavigate,
-    ClickToNavigate,
-    UseSelectButton,
-    DeviceRole,
-    RadioPreset,
-    FrequencySlot,
-    LoRaRegion,
-    Client,
-    ClientMute,
-    LostAndFound,
-    Tracker,
-    Hour12,
-    Hour24,
-    ClockAction,
-    ClockFace,
-    TimeFormat,
-    Timezone,
-    MessageAction,
-    Reply,
-    ViewChats,
-    UnmuteChannel,
-    MuteChannel,
-    Delete,
-    ReadAloud,
-    Brightness,
-    FrameVisibility,
-    DisplayUnits,
-    MessageBubbles,
-    Theme,
-    Reboot,
-    Shutdown,
-    SwitchToMUI,
-    DisplayOptions,
-    Language,
-    Chinese,
-    English,
-    NoGPS,
-    GPSoff,
-    GPSnotPresent,
-    GPSisDisabled,
-    Node,
-    Hop,
-    USB,
-    BT_off,
-    WiFi,
-    WiFiNotConnected,
-    WiFiConnected,
-    SSID,
-    LoRaInfo,
-    LoRa,
-    Role,
-    Freq,
-    ChUtil,
-    System,
-    Heap,
-    PSRAM,
-    Flash,
-    SD,
-    Ver,
-    Up,
-    ClientApp,
-    NoConnected,
-    LOCKED,
-    ConnectToUnlock,
-    Battery,
-    Resuming,
-    LastHeard,
-    HopsSig,
-    HopsSignal,
-    Nodes,
-    Distance,
-    Bearings,
-    CreatingSSLCert,
-    PleaseWait,
-    CriticalFault,
-    ForHelpVisit,
-    Updating,
-    PleaseBePatient,
-    RebootInProgress,
-    PowerMenu,
-    SystemMenu,
-    ScreenOptions,
-    WifiToggle,
-    BluetoothToggle,
-    NodeDbReset,
-    ManageNode,
-    RemoveFavorite,
-    AddFavorite,
-    TestMenu,
-    TraceRoute,
-    ThrottleMessage,
-    MessageViewMode,
-    DeleteMessages,
-    NodeNameLength,
-    GPSMenu,
-    GPSToggle,
-    GPSFormat,
-    GPSSmartPosition,
-    GPSUpdateInterval,
-    GPSPositionBroadcast,
-    CompassNorth,
-    BuzzerMode,
-    HamModeConfirm,
-    LicensedToNormal,
-    KeyVerification,
-    FinalPrompt,
-    RegionUnset,
-    SelectRegionMessage,
-    Rebooting,
-    LoRaActions,
-    Slot0,
-    WithPreset,
-    WithFreetext,
-    DeleteOldest,
-    DeleteThisChat,
-    DeleteAll,
-    DeleteAllChats,
-    TemporarilyMute,
-    Unmute,
-    ToggleBacklight,
-    SleepScreen,
-    SendPosition,
-    SendNodeInfo,
-    NewPresetMsg,
-    NewFreetextMsg,
-    Notifications,
-    Power,
-    RebootShutdown,
-    GoToChat,
-    NewPreset,
-    Favorite,
-    UnmuteNotifications,
-    MuteNotifications,
-    UnignoreNode,
-    IgnoreNode,
-    NumberPicker,
-    TestAnnounce,
-    NodeActionsSettings,
-    ShowNameLength,
-    Bluetooth,
-    NoMessages,
-    COUNT
-};
-
-extern meshtastic_Language currentDisplayLanguage;
-
-const char *getString(StringKey key, meshtastic_Language lang);
-
-inline const char *getString(StringKey key)
-{
-    extern meshtastic_Language currentDisplayLanguage;
-    return getString(key, currentDisplayLanguage);
-}
-
-} // namespace l10n
-} // namespace meshtastic

src/graphics/l10n/Strings_EN.h

@@ -1,456 +0,0 @@
-#pragma once
-
-#include "Strings.h"
-
-namespace meshtastic
-{
-namespace l10n
-{
-
-// English string table
-// The strings are stored as const arrays to save RAM on constrained devices.
-// Each locale file defines the same set of strings in its own language.
-
-static const char STR_BACK_EN[] = "Back";
-static const char STR_OK_EN[] = "OK";
-static const char STR_GOT_IT_EN[] = "Got it!";
-static const char STR_WELCOME_TO_MESHTASTIC_EN[] = "Welcome to Meshtastic!";
-static const char STR_SWIPE_TO_NAVIGATE_EN[] = "Swipe to navigate.";
-static const char STR_CLICK_TO_NAVIGATE_EN[] = "Click to navigate.";
-static const char STR_USE_SELECT_BUTTON_EN[] = "Use the Select button.";
-static const char STR_DEVICE_ROLE_EN[] = "Device Role";
-static const char STR_RADIO_PRESET_EN[] = "Radio Preset";
-static const char STR_FREQUENCY_SLOT_EN[] = "Frequency Slot";
-static const char STR_LORA_REGION_EN[] = "LoRa Region";
-static const char STR_CLIENT_EN[] = "Client";
-static const char STR_CLIENT_MUTE_EN[] = "Client Mute";
-static const char STR_LOST_AND_FOUND_EN[] = "Lost and Found";
-static const char STR_TRACKER_EN[] = "Tracker";
-static const char STR_12HOUR_EN[] = "12-hour";
-static const char STR_24HOUR_EN[] = "24-hour";
-static const char STR_CLOCK_ACTION_EN[] = "Clock Action";
-static const char STR_CLOCK_FACE_EN[] = "Clock Face";
-static const char STR_TIME_FORMAT_EN[] = "Time Format";
-static const char STR_TIMEZONE_EN[] = "Timezone";
-static const char STR_MESSAGE_ACTION_EN[] = "Message Action";
-static const char STR_REPLY_EN[] = "Reply";
-static const char STR_VIEW_CHATS_EN[] = "View Chats";
-static const char STR_UNMUTE_CHANNEL_EN[] = "Unmute Channel";
-static const char STR_MUTE_CHANNEL_EN[] = "Mute Channel";
-static const char STR_DELETE_EN[] = "Delete";
-static const char STR_READ_ALOUD_EN[] = "Read Aloud";
-static const char STR_BRIGHTNESS_EN[] = "Brightness";
-static const char STR_FRAME_VISIBILITY_EN[] = "Frame Visibility";
-static const char STR_DISPLAY_UNITS_EN[] = "Display Units";
-static const char STR_MESSAGE_BUBBLES_EN[] = "Message Bubbles";
-static const char STR_THEME_EN[] = "Theme";
-static const char STR_REBOOT_EN[] = "Reboot";
-static const char STR_SHUTDOWN_EN[] = "Shutdown";
-static const char STR_SWITCH_TO_MUI_EN[] = "Switch to MUI";
-static const char STR_DISPLAY_OPTIONS_EN[] = "Display Options";
-static const char STR_LANGUAGE_EN[] = "Language";
-static const char STR_CHINESE_EN[] = "Chinese";
-static const char STR_ENGLISH_EN[] = "English";
-static const char STR_NO_GPS_EN[] = "No GPS";
-static const char STR_GPS_OFF_EN[] = "GPS off";
-static const char STR_GPS_NOT_PRESENT_EN[] = "GPS not present";
-static const char STR_GPS_IS_DISABLED_EN[] = "GPS is disabled";
-static const char STR_NODE_EN[] = "Node";
-static const char STR_HOP_EN[] = "Hop:";
-static const char STR_USB_EN[] = "USB";
-static const char STR_BT_OFF_EN[] = "BT off";
-static const char STR_WIFI_EN[] = "WiFi";
-static const char STR_WIFI_NOT_CONNECTED_EN[] = "WiFi: Not Connected";
-static const char STR_WIFI_CONNECTED_EN[] = "WiFi: Connected";
-static const char STR_SSID_EN[] = "SSID:";
-static const char STR_LORA_INFO_EN[] = "LoRa Info";
-static const char STR_LORA_EN[] = "LoRa";
-static const char STR_ROLE_EN[] = "Role:";
-static const char STR_FREQ_EN[] = "Freq:";
-static const char STR_CHUTIL_EN[] = "ChUtil";
-static const char STR_SYSTEM_EN[] = "System";
-static const char STR_HEAP_EN[] = "Heap:";
-static const char STR_PSRAM_EN[] = "PSRAM:";
-static const char STR_FLASH_EN[] = "Flash:";
-static const char STR_SD_EN[] = "SD:";
-static const char STR_VER_EN[] = "Ver:";
-static const char STR_UP_EN[] = "Up:";
-static const char STR_CLIENT_APP_EN[] = "Client";
-static const char STR_NO_CONNECTED_EN[] = "No Connected";
-static const char STR_LOCKED_EN[] = "LOCKED";
-static const char STR_CONNECT_TO_UNLOCK_EN[] = "Connect to unlock";
-static const char STR_BATTERY_EN[] = "Battery";
-static const char STR_RESUMING_EN[] = "Resuming...";
-static const char STR_LAST_HEARD_EN[] = "Last Heard";
-static const char STR_HOPS_SIG_EN[] = "Hops/Sig";
-static const char STR_HOPS_SIGNAL_EN[] = "Hops/Signal";
-static const char STR_NODES_EN[] = "Nodes";
-static const char STR_DISTANCE_EN[] = "Distance";
-static const char STR_BEARINGS_EN[] = "Bearings";
-static const char STR_CREATING_SSL_EN[] = "Creating SSL certificate";
-static const char STR_PLEASE_WAIT_EN[] = "Please wait . . .";
-static const char STR_CRITICAL_FAULT_EN[] = "Critical fault";
-static const char STR_FOR_HELP_VISIT_EN[] = "For help, please visit";
-static const char STR_UPDATING_EN[] = "Updating";
-static const char STR_PLEASE_BE_PATIENT_EN[] = "Please be patient and do not power off.";
-static const char STR_REBOOT_IN_PROGRESS_EN[] = "Reboot in progress...";
-static const char STR_POWER_MENU_EN[] = "Power";
-static const char STR_SYSTEM_MENU_EN[] = "System";
-static const char STR_SCREEN_OPTIONS_EN[] = "Screen";
-static const char STR_WIFI_TOGGLE_EN[] = "WiFi";
-static const char STR_BLUETOOTH_TOGGLE_EN[] = "Bluetooth";
-static const char STR_NODE_DB_RESET_EN[] = "Reset NodeDB";
-static const char STR_MANAGE_NODE_EN[] = "Manage Node";
-static const char STR_REMOVE_FAVORITE_EN[] = "Remove Favorite";
-static const char STR_ADD_FAVORITE_EN[] = "Add Favorite";
-static const char STR_TEST_MENU_EN[] = "Test";
-static const char STR_TRACE_ROUTE_EN[] = "Trace Route";
-static const char STR_THROTTLE_MSG_EN[] = "Message Throttled";
-static const char STR_MSG_VIEW_MODE_EN[] = "View Mode";
-static const char STR_DELETE_MESSAGES_EN[] = "Delete Messages";
-static const char STR_NODE_NAME_LENGTH_EN[] = "Name Length";
-static const char STR_GPS_MENU_EN[] = "GPS";
-static const char STR_GPS_TOGGLE_EN[] = "GPS Toggle";
-static const char STR_GPS_FORMAT_EN[] = "GPS Format";
-static const char STR_GPS_SMART_POS_EN[] = "Smart Position";
-static const char STR_GPS_UPDATE_INTERVAL_EN[] = "Update Interval";
-static const char STR_GPS_POS_BCAST_EN[] = "Position Broadcast";
-static const char STR_COMPASS_NORTH_EN[] = "Compass North";
-static const char STR_BUZZER_MODE_EN[] = "Buzzer";
-static const char STR_HAM_MODE_EN[] = "Ham Mode";
-static const char STR_LICENSED_NORMAL_EN[] = "Normal Mode";
-static const char STR_KEY_VERIFY_EN[] = "Verify Key";
-static const char STR_REGION_UNSET_EN[] = "Select a Region";
-static const char STR_SELECT_REGION_EN[] = "Please select your LoRa region:";
-static const char STR_REBOOTING_EN[] = "Rebooting...";
-static const char STR_LORA_ACTIONS_EN[] = "LoRa Actions";
-static const char STR_SLOT0_EN[] = "Slot 0 (Auto)";
-static const char STR_WITH_PRESET_EN[] = "With Preset";
-static const char STR_WITH_FREETEXT_EN[] = "With Freetext";
-static const char STR_DELETE_OLDEST_EN[] = "Delete Oldest";
-static const char STR_DELETE_THIS_CHAT_EN[] = "Delete This Chat";
-static const char STR_DELETE_ALL_EN[] = "Delete All";
-static const char STR_DELETE_ALL_CHATS_EN[] = "Delete All Chats";
-static const char STR_TEMPORARILY_MUTE_EN[] = "Temporarily Mute";
-static const char STR_UNMUTE_EN[] = "Unmute";
-static const char STR_TOGGLE_BACKLIGHT_EN[] = "Toggle Backlight";
-static const char STR_SLEEP_SCREEN_EN[] = "Sleep Screen";
-static const char STR_SEND_POSITION_EN[] = "Send Position";
-static const char STR_SEND_NODE_INFO_EN[] = "Send Node Info";
-static const char STR_NEW_PRESET_MSG_EN[] = "New Preset Msg";
-static const char STR_NEW_FREETEXT_MSG_EN[] = "New Freetext Msg";
-static const char STR_NOTIFICATIONS_EN[] = "Notifications";
-static const char STR_POWER_EN[] = "Power";
-static const char STR_REBOOT_SHUTDOWN_EN[] = "Reboot/Shutdown";
-static const char STR_GO_TO_CHAT_EN[] = "Go To Chat";
-static const char STR_NEW_PRESET_EN[] = "New Preset";
-static const char STR_FAVORITE_EN[] = "Favorite";
-static const char STR_UNMUTE_NOTIFICATIONS_EN[] = "Unmute Notifications";
-static const char STR_MUTE_NOTIFICATIONS_EN[] = "Mute Notifications";
-static const char STR_UNIGNORE_NODE_EN[] = "Unignore Node";
-static const char STR_IGNORE_NODE_EN[] = "Ignore Node";
-static const char STR_NUMBER_PICKER_EN[] = "Number Picker";
-static const char STR_TEST_ANNOUNCE_EN[] = "Test Announce";
-static const char STR_NODE_ACTIONS_EN[] = "Node Actions / Settings";
-static const char STR_SHOW_NAME_LENGTH_EN[] = "Show Long/Short Name";
-static const char STR_BLUETOOTH_EN[] = "Bluetooth";
-static const char STR_NO_MESSAGES_EN[] = "No messages";
-
-inline const char *getStringEN(StringKey key)
-{
-    switch (key) {
-    case StringKey::Back:
-        return STR_BACK_EN;
-    case StringKey::OK:
-        return STR_OK_EN;
-    case StringKey::GotIt:
-        return STR_GOT_IT_EN;
-    case StringKey::WelcomeToMeshtastic:
-        return STR_WELCOME_TO_MESHTASTIC_EN;
-    case StringKey::SwipeToNavigate:
-        return STR_SWIPE_TO_NAVIGATE_EN;
-    case StringKey::ClickToNavigate:
-        return STR_CLICK_TO_NAVIGATE_EN;
-    case StringKey::UseSelectButton:
-        return STR_USE_SELECT_BUTTON_EN;
-    case StringKey::DeviceRole:
-        return STR_DEVICE_ROLE_EN;
-    case StringKey::RadioPreset:
-        return STR_RADIO_PRESET_EN;
-    case StringKey::FrequencySlot:
-        return STR_FREQUENCY_SLOT_EN;
-    case StringKey::LoRaRegion:
-        return STR_LORA_REGION_EN;
-    case StringKey::Client:
-        return STR_CLIENT_EN;
-    case StringKey::ClientMute:
-        return STR_CLIENT_MUTE_EN;
-    case StringKey::LostAndFound:
-        return STR_LOST_AND_FOUND_EN;
-    case StringKey::Tracker:
-        return STR_TRACKER_EN;
-    case StringKey::Hour12:
-        return STR_12HOUR_EN;
-    case StringKey::Hour24:
-        return STR_24HOUR_EN;
-    case StringKey::ClockAction:
-        return STR_CLOCK_ACTION_EN;
-    case StringKey::ClockFace:
-        return STR_CLOCK_FACE_EN;
-    case StringKey::TimeFormat:
-        return STR_TIME_FORMAT_EN;
-    case StringKey::Timezone:
-        return STR_TIMEZONE_EN;
-    case StringKey::MessageAction:
-        return STR_MESSAGE_ACTION_EN;
-    case StringKey::Reply:
-        return STR_REPLY_EN;
-    case StringKey::ViewChats:
-        return STR_VIEW_CHATS_EN;
-    case StringKey::UnmuteChannel:
-        return STR_UNMUTE_CHANNEL_EN;
-    case StringKey::MuteChannel:
-        return STR_MUTE_CHANNEL_EN;
-    case StringKey::Delete:
-        return STR_DELETE_EN;
-    case StringKey::ReadAloud:
-        return STR_READ_ALOUD_EN;
-    case StringKey::Brightness:
-        return STR_BRIGHTNESS_EN;
-    case StringKey::FrameVisibility:
-        return STR_FRAME_VISIBILITY_EN;
-    case StringKey::DisplayUnits:
-        return STR_DISPLAY_UNITS_EN;
-    case StringKey::MessageBubbles:
-        return STR_MESSAGE_BUBBLES_EN;
-    case StringKey::Theme:
-        return STR_THEME_EN;
-    case StringKey::Reboot:
-        return STR_REBOOT_EN;
-    case StringKey::Shutdown:
-        return STR_SHUTDOWN_EN;
-    case StringKey::SwitchToMUI:
-        return STR_SWITCH_TO_MUI_EN;
-    case StringKey::DisplayOptions:
-        return STR_DISPLAY_OPTIONS_EN;
-    case StringKey::Language:
-        return STR_LANGUAGE_EN;
-    case StringKey::Chinese:
-        return STR_CHINESE_EN;
-    case StringKey::English:
-        return STR_ENGLISH_EN;
-    case StringKey::NoGPS:
-        return STR_NO_GPS_EN;
-    case StringKey::GPSoff:
-        return STR_GPS_OFF_EN;
-    case StringKey::GPSnotPresent:
-        return STR_GPS_NOT_PRESENT_EN;
-    case StringKey::GPSisDisabled:
-        return STR_GPS_IS_DISABLED_EN;
-    case StringKey::Node:
-        return STR_NODE_EN;
-    case StringKey::Hop:
-        return STR_HOP_EN;
-    case StringKey::USB:
-        return STR_USB_EN;
-    case StringKey::BT_off:
-        return STR_BT_OFF_EN;
-    case StringKey::WiFi:
-        return STR_WIFI_EN;
-    case StringKey::WiFiNotConnected:
-        return STR_WIFI_NOT_CONNECTED_EN;
-    case StringKey::WiFiConnected:
-        return STR_WIFI_CONNECTED_EN;
-    case StringKey::SSID:
-        return STR_SSID_EN;
-    case StringKey::LoRaInfo:
-        return STR_LORA_INFO_EN;
-    case StringKey::LoRa:
-        return STR_LORA_EN;
-    case StringKey::Role:
-        return STR_ROLE_EN;
-    case StringKey::Freq:
-        return STR_FREQ_EN;
-    case StringKey::ChUtil:
-        return STR_CHUTIL_EN;
-    case StringKey::System:
-        return STR_SYSTEM_EN;
-    case StringKey::Heap:
-        return STR_HEAP_EN;
-    case StringKey::PSRAM:
-        return STR_PSRAM_EN;
-    case StringKey::Flash:
-        return STR_FLASH_EN;
-    case StringKey::SD:
-        return STR_SD_EN;
-    case StringKey::Ver:
-        return STR_VER_EN;
-    case StringKey::Up:
-        return STR_UP_EN;
-    case StringKey::ClientApp:
-        return STR_CLIENT_APP_EN;
-    case StringKey::NoConnected:
-        return STR_NO_CONNECTED_EN;
-    case StringKey::LOCKED:
-        return STR_LOCKED_EN;
-    case StringKey::ConnectToUnlock:
-        return STR_CONNECT_TO_UNLOCK_EN;
-    case StringKey::Battery:
-        return STR_BATTERY_EN;
-    case StringKey::Resuming:
-        return STR_RESUMING_EN;
-    case StringKey::LastHeard:
-        return STR_LAST_HEARD_EN;
-    case StringKey::HopsSig:
-        return STR_HOPS_SIG_EN;
-    case StringKey::HopsSignal:
-        return STR_HOPS_SIGNAL_EN;
-    case StringKey::Nodes:
-        return STR_NODES_EN;
-    case StringKey::Distance:
-        return STR_DISTANCE_EN;
-    case StringKey::Bearings:
-        return STR_BEARINGS_EN;
-    case StringKey::CreatingSSLCert:
-        return STR_CREATING_SSL_EN;
-    case StringKey::PleaseWait:
-        return STR_PLEASE_WAIT_EN;
-    case StringKey::CriticalFault:
-        return STR_CRITICAL_FAULT_EN;
-    case StringKey::ForHelpVisit:
-        return STR_FOR_HELP_VISIT_EN;
-    case StringKey::Updating:
-        return STR_UPDATING_EN;
-    case StringKey::PleaseBePatient:
-        return STR_PLEASE_BE_PATIENT_EN;
-    case StringKey::RebootInProgress:
-        return STR_REBOOT_IN_PROGRESS_EN;
-    case StringKey::PowerMenu:
-        return STR_POWER_MENU_EN;
-    case StringKey::SystemMenu:
-        return STR_SYSTEM_MENU_EN;
-    case StringKey::ScreenOptions:
-        return STR_SCREEN_OPTIONS_EN;
-    case StringKey::WifiToggle:
-        return STR_WIFI_TOGGLE_EN;
-    case StringKey::BluetoothToggle:
-        return STR_BLUETOOTH_TOGGLE_EN;
-    case StringKey::NodeDbReset:
-        return STR_NODE_DB_RESET_EN;
-    case StringKey::ManageNode:
-        return STR_MANAGE_NODE_EN;
-    case StringKey::RemoveFavorite:
-        return STR_REMOVE_FAVORITE_EN;
-    case StringKey::AddFavorite:
-        return STR_ADD_FAVORITE_EN;
-    case StringKey::TestMenu:
-        return STR_TEST_MENU_EN;
-    case StringKey::TraceRoute:
-        return STR_TRACE_ROUTE_EN;
-    case StringKey::ThrottleMessage:
-        return STR_THROTTLE_MSG_EN;
-    case StringKey::MessageViewMode:
-        return STR_MSG_VIEW_MODE_EN;
-    case StringKey::DeleteMessages:
-        return STR_DELETE_MESSAGES_EN;
-    case StringKey::NodeNameLength:
-        return STR_NODE_NAME_LENGTH_EN;
-    case StringKey::GPSMenu:
-        return STR_GPS_MENU_EN;
-    case StringKey::GPSToggle:
-        return STR_GPS_TOGGLE_EN;
-    case StringKey::GPSFormat:
-        return STR_GPS_FORMAT_EN;
-    case StringKey::GPSSmartPosition:
-        return STR_GPS_SMART_POS_EN;
-    case StringKey::GPSUpdateInterval:
-        return STR_GPS_UPDATE_INTERVAL_EN;
-    case StringKey::GPSPositionBroadcast:
-        return STR_GPS_POS_BCAST_EN;
-    case StringKey::CompassNorth:
-        return STR_COMPASS_NORTH_EN;
-    case StringKey::BuzzerMode:
-        return STR_BUZZER_MODE_EN;
-    case StringKey::HamModeConfirm:
-        return STR_HAM_MODE_EN;
-    case StringKey::LicensedToNormal:
-        return STR_LICENSED_NORMAL_EN;
-    case StringKey::KeyVerification:
-        return STR_KEY_VERIFY_EN;
-    case StringKey::RegionUnset:
-        return STR_REGION_UNSET_EN;
-    case StringKey::SelectRegionMessage:
-        return STR_SELECT_REGION_EN;
-    case StringKey::Rebooting:
-        return STR_REBOOTING_EN;
-    case StringKey::LoRaActions:
-        return STR_LORA_ACTIONS_EN;
-    case StringKey::Slot0:
-        return STR_SLOT0_EN;
-    case StringKey::WithPreset:
-        return STR_WITH_PRESET_EN;
-    case StringKey::WithFreetext:
-        return STR_WITH_FREETEXT_EN;
-    case StringKey::DeleteOldest:
-        return STR_DELETE_OLDEST_EN;
-    case StringKey::DeleteThisChat:
-        return STR_DELETE_THIS_CHAT_EN;
-    case StringKey::DeleteAll:
-        return STR_DELETE_ALL_EN;
-    case StringKey::DeleteAllChats:
-        return STR_DELETE_ALL_CHATS_EN;
-    case StringKey::TemporarilyMute:
-        return STR_TEMPORARILY_MUTE_EN;
-    case StringKey::Unmute:
-        return STR_UNMUTE_EN;
-    case StringKey::ToggleBacklight:
-        return STR_TOGGLE_BACKLIGHT_EN;
-    case StringKey::SleepScreen:
-        return STR_SLEEP_SCREEN_EN;
-    case StringKey::SendPosition:
-        return STR_SEND_POSITION_EN;
-    case StringKey::SendNodeInfo:
-        return STR_SEND_NODE_INFO_EN;
-    case StringKey::NewPresetMsg:
-        return STR_NEW_PRESET_MSG_EN;
-    case StringKey::NewFreetextMsg:
-        return STR_NEW_FREETEXT_MSG_EN;
-    case StringKey::Notifications:
-        return STR_NOTIFICATIONS_EN;
-    case StringKey::Power:
-        return STR_POWER_EN;
-    case StringKey::RebootShutdown:
-        return STR_REBOOT_SHUTDOWN_EN;
-    case StringKey::GoToChat:
-        return STR_GO_TO_CHAT_EN;
-    case StringKey::NewPreset:
-        return STR_NEW_PRESET_EN;
-    case StringKey::Favorite:
-        return STR_FAVORITE_EN;
-    case StringKey::UnmuteNotifications:
-        return STR_UNMUTE_NOTIFICATIONS_EN;
-    case StringKey::MuteNotifications:
-        return STR_MUTE_NOTIFICATIONS_EN;
-    case StringKey::UnignoreNode:
-        return STR_UNIGNORE_NODE_EN;
-    case StringKey::IgnoreNode:
-        return STR_IGNORE_NODE_EN;
-    case StringKey::NumberPicker:
-        return STR_NUMBER_PICKER_EN;
-    case StringKey::TestAnnounce:
-        return STR_TEST_ANNOUNCE_EN;
-    case StringKey::NodeActionsSettings:
-        return STR_NODE_ACTIONS_EN;
-    case StringKey::ShowNameLength:
-        return STR_SHOW_NAME_LENGTH_EN;
-    case StringKey::Bluetooth:
-        return STR_BLUETOOTH_EN;
-    case StringKey::NoMessages:
-        return STR_NO_MESSAGES_EN;
-    default:
-        return "?";
-    }
-}
-
-} // namespace l10n
-} // namespace meshtastic

src/graphics/l10n/Strings_ZH.h

@@ -1,452 +0,0 @@
-#pragma once
-
-#include "Strings.h"
-
-namespace meshtastic
-{
-namespace l10n
-{
-
-static const char STR_BACK_ZH[] = "\xe8\xbf\x94\xe5\x9b\x9e";
-static const char STR_OK_ZH[] = "\xe7\xa1\xae\xe5\xae\x9a";
-static const char STR_GOT_IT_ZH[] = "\xe7\x9f\xa5\xe9\x81\x93\xe4\xba\x86";
-static const char STR_WELCOME_TO_MESHTASTIC_ZH[] = "\xe6\xac\xa2\xe8\xbf\x8e\xe4\xbd\xbf\xe7\x94\xa8 Meshtastic\xef\xbc\x81";
-static const char STR_SWIPE_TO_NAVIGATE_ZH[] = "\xe6\xbb\x91\xe5\x8a\xa8\xe4\xbb\xa5\xe5\xaf\xbc\xe8\x88\xaa\xe3\x80\x82";
-static const char STR_CLICK_TO_NAVIGATE_ZH[] = "\xe7\x82\xb9\xe5\x87\xbb\xe4\xbb\xa5\xe5\xaf\xbc\xe8\x88\xaa\xe3\x80\x82";
-static const char STR_USE_SELECT_BUTTON_ZH[] = "\xe4\xbd\xbf\xe7\x94\xa8\xe9\x80\x89\xe6\x8b\xa9\xe6\x8c\x89\xe9\x92\xae\xe3\x80\x82";
-static const char STR_DEVICE_ROLE_ZH[] = "\xe8\xae\xbe\xe5\xa4\x87\xe8\xa7\x92\xe8\x89\xb2";
-static const char STR_RADIO_PRESET_ZH[] = "\xe6\x97\xa0\xe7\xba\xbf\xe9\xa2\x84\xe8\xae\xbe";
-static const char STR_FREQUENCY_SLOT_ZH[] = "\xe9\xa2\x91\xe7\x8e\x87\xe6\xa7\xbd\xe4\xbd\x8d";
-static const char STR_LORA_REGION_ZH[] = "LoRa \xe5\x9c\xb0\xe5\x8c\xba";
-static const char STR_CLIENT_ZH[] = "\xe5\xae\xa2\xe6\x88\xb7\xe7\xab\xaf";
-static const char STR_CLIENT_MUTE_ZH[] = "\xe9\x9d\x99\xe9\x9f\xb3\xe5\xae\xa2\xe6\x88\xb7\xe7\xab\xaf";
-static const char STR_LOST_AND_FOUND_ZH[] = "\xe5\xa4\xb1\xe7\x89\xa9\xe6\x8b\x9b\xe9\xa2\x86";
-static const char STR_TRACKER_ZH[] = "\xe8\xbf\xbd\xe8\xb8\xaa\xe5\x99\xa8";
-static const char STR_12HOUR_ZH[] = "12 \xe5\xb0\x8f\xe6\x97\xb6\xe5\x88\xb6";
-static const char STR_24HOUR_ZH[] = "24 \xe5\xb0\x8f\xe6\x97\xb6\xe5\x88\xb6";
-static const char STR_CLOCK_ACTION_ZH[] = "\xe6\x97\xb6\xe9\x92\x9f\xe6\x93\x8d\xe4\xbd\x9c";
-static const char STR_CLOCK_FACE_ZH[] = "\xe6\x97\xb6\xe9\x92\x9f\xe6\xa0\xb7\xe5\xbc\x8f";
-static const char STR_TIME_FORMAT_ZH[] = "\xe6\x97\xb6\xe9\x97\xb4\xe6\xa0\xbc\xe5\xbc\x8f";
-static const char STR_TIMEZONE_ZH[] = "\xe6\x97\xb6\xe5\x8c\xba";
-static const char STR_MESSAGE_ACTION_ZH[] = "\xe6\xb6\x88\xe6\x81\xaf\xe6\x93\x8d\xe4\xbd\x9c";
-static const char STR_REPLY_ZH[] = "\xe5\x9b\x9e\xe5\xa4\x8d";
-static const char STR_VIEW_CHATS_ZH[] = "\xe6\x9f\xa5\xe7\x9c\x8b\xe8\x81\x8a\xe5\xa4\xa9";
-static const char STR_UNMUTE_CHANNEL_ZH[] = "\xe5\x8f\x96\xe6\xb6\x88\xe9\x9d\x99\xe9\x9f\xb3";
-static const char STR_MUTE_CHANNEL_ZH[] = "\xe9\x9d\x99\xe9\x9f\xb3\xe9\xa2\x91\xe9\x81\x93";
-static const char STR_DELETE_ZH[] = "\xe5\x88\xa0\xe9\x99\xa4";
-static const char STR_READ_ALOUD_ZH[] = "\xe5\xa4\xa7\xe5\xa3\xb0\xe6\x9c\x97\xe8\xaf\xbb";
-static const char STR_BRIGHTNESS_ZH[] = "\xe4\xba\xae\xe5\xba\xa6";
-static const char STR_FRAME_VISIBILITY_ZH[] = "\xe9\xa1\xb5\xe9\x9d\xa2\xe5\x8f\xaf\xe8\xa7\x81\xe6\x80\xa7";
-static const char STR_DISPLAY_UNITS_ZH[] = "\xe6\x98\xbe\xe7\xa4\xba\xe5\x8d\x95\xe4\xbd\x8d";
-static const char STR_MESSAGE_BUBBLES_ZH[] = "\xe6\xb6\x88\xe6\x81\xaf\xe6\xb0\x94\xe6\xb3\xa1";
-static const char STR_THEME_ZH[] = "\xe4\xb8\xbb\xe9\xa2\x98";
-static const char STR_REBOOT_ZH[] = "\xe9\x87\x8d\xe5\x90\xaf";
-static const char STR_SHUTDOWN_ZH[] = "\xe5\x85\xb3\xe6\x9c\xba";
-static const char STR_SWITCH_TO_MUI_ZH[] = "\xe5\x88\x87\xe6\x8d\xa2\xe5\x88\xb0 MUI";
-static const char STR_DISPLAY_OPTIONS_ZH[] = "\xe6\x98\xbe\xe7\xa4\xba\xe9\x80\x89\xe9\xa1\xb9";
-static const char STR_LANGUAGE_ZH[] = "\xe8\xaf\xad\xe8\xa8\x80";
-static const char STR_CHINESE_ZH[] = "\xe4\xb8\xad\xe6\x96\x87";
-static const char STR_ENGLISH_ZH[] = "\xe8\x8b\xb1\xe6\x96\x87";
-static const char STR_NO_GPS_ZH[] = "\xe6\x97\xa0 GPS";
-static const char STR_GPS_OFF_ZH[] = "GPS \xe5\xb7\xb2\xe5\x85\xb3\xe9\x97\xad";
-static const char STR_GPS_NOT_PRESENT_ZH[] = "GPS \xe4\xb8\x8d\xe5\xad\x98\xe5\x9c\xa8";
-static const char STR_GPS_IS_DISABLED_ZH[] = "GPS \xe5\xb7\xb2\xe7\xa6\x81\xe7\x94\xa8";
-static const char STR_NODE_ZH[] = "\xe8\x8a\x82\xe7\x82\xb9";
-static const char STR_HOP_ZH[] = "\xe8\xb7\xb3\xe6\x95\xb0:";
-static const char STR_USB_ZH[] = "USB";
-static const char STR_BT_OFF_ZH[] = "\xe8\x93\x9d\xe7\x89\x99\xe5\xb7\xb2\xe5\x85\xb3";
-static const char STR_WIFI_ZH[] = "WiFi";
-static const char STR_WIFI_NOT_CONNECTED_ZH[] = "WiFi: \xe6\x9c\xaa\xe8\xbf\x9e\xe6\x8e\xa5";
-static const char STR_WIFI_CONNECTED_ZH[] = "WiFi: \xe5\xb7\xb2\xe8\xbf\x9e\xe6\x8e\xa5";
-static const char STR_SSID_ZH[] = "SSID:";
-static const char STR_LORA_INFO_ZH[] = "LoRa \xe4\xbf\xa1\xe6\x81\xaf";
-static const char STR_LORA_ZH[] = "LoRa";
-static const char STR_ROLE_ZH[] = "\xe8\xa7\x92\xe8\x89\xb2:";
-static const char STR_FREQ_ZH[] = "\xe9\xa2\x91\xe7\x8e\x87:";
-static const char STR_CHUTIL_ZH[] = "\xe4\xbf\xa1\xe9\x81\x93\xe5\x88\xa9\xe7\x94\xa8";
-static const char STR_SYSTEM_ZH[] = "\xe7\xb3\xbb\xe7\xbb\x9f";
-static const char STR_HEAP_ZH[] = "\xe5\xa0\x86:";
-static const char STR_PSRAM_ZH[] = "PSRAM:";
-static const char STR_FLASH_ZH[] = "Flash:";
-static const char STR_SD_ZH[] = "SD:";
-static const char STR_VER_ZH[] = "\xe7\x89\x88\xe6\x9c\xac:";
-static const char STR_UP_ZH[] = "\xe8\xbf\x90\xe8\xa1\x8c:";
-static const char STR_CLIENT_APP_ZH[] = "\xe5\xae\xa2\xe6\x88\xb7\xe7\xab\xaf";
-static const char STR_NO_CONNECTED_ZH[] = "\xe6\x9c\xaa\xe8\xbf\x9e\xe6\x8e\xa5";
-static const char STR_LOCKED_ZH[] = "\xe5\xb7\xb2\xe9\x94\x81\xe5\xae\x9a";
-static const char STR_CONNECT_TO_UNLOCK_ZH[] = "\xe8\xbf\x9e\xe6\x8e\xa5\xe4\xbb\xa5\xe8\xa7\xa3\xe9\x94\x81";
-static const char STR_BATTERY_ZH[] = "\xe7\x94\xb5\xe6\xb1\xa0";
-static const char STR_RESUMING_ZH[] = "\xe6\xad\xa3\xe5\x9c\xa8\xe6\x81\xa2\xe5\xa4\x8d...";
-static const char STR_LAST_HEARD_ZH[] = "\xe6\x9c\x80\xe5\x90\x8e\xe5\x90\xac\xe5\x88\xb0";
-static const char STR_HOPS_SIG_ZH[] = "\xe8\xb7\xb3\xe6\x95\xb0/\xe4\xbf\xa1\xe5\x8f\xb7";
-static const char STR_HOPS_SIGNAL_ZH[] = "\xe8\xb7\xb3\xe6\x95\xb0/\xe4\xbf\xa1\xe5\x8f\xb7";
-static const char STR_NODES_ZH[] = "\xe8\x8a\x82\xe7\x82\xb9";
-static const char STR_DISTANCE_ZH[] = "\xe8\xb7\x9d\xe7\xa6\xbb";
-static const char STR_BEARINGS_ZH[] = "\xe6\x96\xb9\xe4\xbd\x8d";
-static const char STR_CREATING_SSL_ZH[] = "\xe6\xad\xa3\xe5\x9c\xa8\xe5\x88\x9b\xe5\xbb\xba SSL \xe8\xaf\x81\xe4\xb9\xa6";
-static const char STR_PLEASE_WAIT_ZH[] = "\xe8\xaf\xb7\xe7\xa8\x8d\xe5\x80\x99 . . .";
-static const char STR_CRITICAL_FAULT_ZH[] = "\xe4\xb8\xa5\xe9\x87\x8d\xe6\x95\x85\xe9\x9a\x9c";
-static const char STR_FOR_HELP_VISIT_ZH[] = "\xe8\xaf\xb7\xe8\xae\xbf\xe9\x97\xae\x4e\xe5\xb8\xae\xe5\x8a\xa9";
-static const char STR_UPDATING_ZH[] = "\xe6\xad\xa3\xe5\x9c\xa8\xe6\x9b\xb4\xe6\x96\xb0";
-static const char STR_PLEASE_BE_PATIENT_ZH[] = "\xe8\xaf\xb7\xe8\x80\x90\xe5\xbf\x83\xe7\xad\x89\xe5\xbe\x85\xef\xbc\x8c\xe4\xb8\x8d\xe8\xa6\x81\xe5\x85\xb3\xe9\x97\xad\xe7\x94\xb5\xe6\xba\x90\xe3\x80\x82";
-static const char STR_REBOOT_IN_PROGRESS_ZH[] = "\xe6\xad\xa3\xe5\x9c\xa8\xe9\x87\x8d\xe5\x90\xaf...";
-static const char STR_POWER_MENU_ZH[] = "\xe7\x94\xb5\xe6\xba\x90";
-static const char STR_SYSTEM_MENU_ZH[] = "\xe7\xb3\xbb\xe7\xbb\x9f";
-static const char STR_SCREEN_OPTIONS_ZH[] = "\xe5\xb1\x8f\xe5\xb9\x95";
-static const char STR_WIFI_TOGGLE_ZH[] = "WiFi";
-static const char STR_BLUETOOTH_TOGGLE_ZH[] = "\xe8\x93\x9d\xe7\x89\x99";
-static const char STR_NODE_DB_RESET_ZH[] = "\xe9\x87\x8d\xe7\xbd\xae\xe8\x8a\x82\xe7\x82\xb9\xe5\xba\x93";
-static const char STR_MANAGE_NODE_ZH[] = "\xe7\xae\xa1\xe7\x90\x86\xe8\x8a\x82\xe7\x82\xb9";
-static const char STR_REMOVE_FAVORITE_ZH[] = "\xe5\x8f\x96\xe6\xb6\x88\xe6\x94\xb6\xe8\x97\x8f";
-static const char STR_ADD_FAVORITE_ZH[] = "\xe6\xb7\xbb\xe5\x8a\xa0\xe6\x94\xb6\xe8\x97\x8f";
-static const char STR_TEST_MENU_ZH[] = "\xe6\xb5\x8b\xe8\xaf\x95";
-static const char STR_TRACE_ROUTE_ZH[] = "\xe8\xb7\xaf\xe7\x94\xb1\xe8\xbf\xbd\xe8\xb8\xaa";
-static const char STR_THROTTLE_MSG_ZH[] = "\xe6\xb6\x88\xe6\x81\xaf\xe5\xb7\xb2\xe9\x99\x90\xe6\xb5\x81";
-static const char STR_MSG_VIEW_MODE_ZH[] = "\xe6\x9f\xa5\xe7\x9c\x8b\xe6\xa8\xa1\xe5\xbc\x8f";
-static const char STR_DELETE_MESSAGES_ZH[] = "\xe5\x88\xa0\xe9\x99\xa4\xe6\xb6\x88\xe6\x81\xaf";
-static const char STR_NODE_NAME_LENGTH_ZH[] = "\xe5\x90\x8d\xe7\xa7\xb0\xe9\x95\xbf\xe5\xba\xa6";
-static const char STR_GPS_MENU_ZH[] = "GPS";
-static const char STR_GPS_TOGGLE_ZH[] = "GPS \xe5\xbc\x80\xe5\x85\xb3";
-static const char STR_GPS_FORMAT_ZH[] = "GPS \xe6\xa0\xbc\xe5\xbc\x8f";
-static const char STR_GPS_SMART_POS_ZH[] = "\xe6\x99\xba\xe8\x83\xbd\xe5\xae\x9a\xe4\xbd\x8d";
-static const char STR_GPS_UPDATE_INTERVAL_ZH[] = "\xe6\x9b\xb4\xe6\x96\xb0\xe9\x97\xb4\xe9\x9a\x94";
-static const char STR_GPS_POS_BCAST_ZH[] = "\xe4\xbd\x8d\xe7\xbd\xae\xe5\xb9\xbf\xe6\x92\xad";
-static const char STR_COMPASS_NORTH_ZH[] = "\xe6\x8c\x87\xe5\x8d\x97\xe9\x92\x88";
-static const char STR_BUZZER_MODE_ZH[] = "\xe8\x9c\x82\xe9\xb8\xa3\xe5\x99\xa8";
-static const char STR_HAM_MODE_ZH[] = "Ham \xe6\xa8\xa1\xe5\xbc\x8f";
-static const char STR_LICENSED_NORMAL_ZH[] = "\xe6\x99\xae\xe9\x80\x9a\xe6\xa8\xa1\xe5\xbc\x8f";
-static const char STR_KEY_VERIFY_ZH[] = "\xe9\xaa\x8c\xe8\xaf\x81\xe5\xaf\x86\xe9\x92\xa5";
-static const char STR_REGION_UNSET_ZH[] = "\xe8\xaf\xb7\xe9\x80\x89\xe6\x8b\xa9\xe5\x9c\xb0\xe5\x8c\xba";
-static const char STR_SELECT_REGION_ZH[] = "\xe8\xaf\xb7\xe9\x80\x89\xe6\x8b\xa9\xe6\x82\xa8\xe7\x9a\x84 LoRa \xe5\x8c\xba\xe5\x9f\x9f:";
-static const char STR_REBOOTING_ZH[] = "\xe6\xad\xa3\xe5\x9c\xa8\xe9\x87\x8d\xe5\x90\xaf...";
-static const char STR_LORA_ACTIONS_ZH[] = "LoRa \xe6\x93\x8d\xe4\xbd\x9c";
-static const char STR_SLOT0_ZH[] = "\xe6\xa7\xbd\xe4\xbd\x8d 0 (\xe8\x87\xaa\xe5\x8a\xa8)";
-static const char STR_WITH_PRESET_ZH[] = "\xe9\xa2\x84\xe8\xae\xbe\xe6\xb6\x88\xe6\x81\xaf";
-static const char STR_WITH_FREETEXT_ZH[] = "\xe8\x87\xaa\xe5\xae\x9a\xe4\xb9\x89";
-static const char STR_DELETE_OLDEST_ZH[] = "\xe5\x88\xa0\xe9\x99\xa4\xe6\x9c\x80\xe6\x97\xa7";
-static const char STR_DELETE_THIS_CHAT_ZH[] = "\xe5\x88\xa0\xe9\x99\xa4\xe6\xad\xa4\xe8\x81\x8a\xe5\xa4\xa9";
-static const char STR_DELETE_ALL_ZH[] = "\xe5\x88\xa0\xe9\x99\xa4\xe5\x85\xa8\xe9\x83\xa8";
-static const char STR_DELETE_ALL_CHATS_ZH[] = "\xe5\x88\xa0\xe9\x99\xa4\xe6\x89\x80\xe6\x9c\x89\xe8\x81\x8a\xe5\xa4\xa9";
-static const char STR_TEMPORARILY_MUTE_ZH[] = "\xe4\xb8\xb4\xe6\x97\xb6\xe9\x9d\x99\xe9\x9f\xb3";
-static const char STR_UNMUTE_ZH[] = "\xe5\x8f\x96\xe6\xb6\x88\xe9\x9d\x99\xe9\x9f\xb3";
-static const char STR_TOGGLE_BACKLIGHT_ZH[] = "\xe8\x83\x8c\xe5\x85\x89\xe5\xbc\x80\xe5\x85\xb3";
-static const char STR_SLEEP_SCREEN_ZH[] = "\xe4\xbc\x91\xe7\x9c\xa0\xe5\xb1\x8f\xe5\xb9\x95";
-static const char STR_SEND_POSITION_ZH[] = "\xe5\x8f\x91\xe9\x80\x81\xe4\xbd\x8d\xe7\xbd\xae";
-static const char STR_SEND_NODE_INFO_ZH[] = "\xe5\x8f\x91\xe9\x80\x81\xe8\x8a\x82\xe7\x82\xb9\xe4\xbf\xa1\xe6\x81\xaf";
-static const char STR_NEW_PRESET_MSG_ZH[] = "\xe6\x96\xb0\xe9\xa2\x84\xe8\xae\xbe\xe6\xb6\x88\xe6\x81\xaf";
-static const char STR_NEW_FREETEXT_MSG_ZH[] = "\xe6\x96\xb0\xe8\x87\xaa\xe5\xae\x9a\xe4\xb9\x89\xe6\xb6\x88\xe6\x81\xaf";
-static const char STR_NOTIFICATIONS_ZH[] = "\xe9\x80\x9a\xe7\x9f\xa5";
-static const char STR_POWER_ZH[] = "\xe7\x94\xb5\xe6\xba\x90";
-static const char STR_REBOOT_SHUTDOWN_ZH[] = "\xe9\x87\x8d\xe5\x90\xaf/\xe5\x85\xb3\xe6\x9c\xba";
-static const char STR_GO_TO_CHAT_ZH[] = "\xe8\xbf\x9b\xe5\x85\xa5\xe8\x81\x8a\xe5\xa4\xa9";
-static const char STR_NEW_PRESET_ZH[] = "\xe6\x96\xb0\xe9\xa2\x84\xe8\xae\xbe";
-static const char STR_FAVORITE_ZH[] = "\xe6\x94\xb6\xe8\x97\x8f";
-static const char STR_UNMUTE_NOTIFICATIONS_ZH[] = "\xe5\x8f\x96\xe6\xb6\x88\xe9\x80\x9a\xe7\x9f\xa5\xe9\x9d\x99\xe9\x9f\xb3";
-static const char STR_MUTE_NOTIFICATIONS_ZH[] = "\xe9\x80\x9a\xe7\x9f\xa5\xe9\x9d\x99\xe9\x9f\xb3";
-static const char STR_UNIGNORE_NODE_ZH[] = "\xe5\x8f\x96\xe6\xb6\x88\xe5\xbf\xbd\xe7\x95\xa5";
-static const char STR_IGNORE_NODE_ZH[] = "\xe5\xbf\xbd\xe7\x95\xa5\xe8\x8a\x82\xe7\x82\xb9";
-static const char STR_NUMBER_PICKER_ZH[] = "\xe6\x95\xb0\xe5\xad\x97\xe9\x80\x89\xe6\x8b\xa9";
-static const char STR_TEST_ANNOUNCE_ZH[] = "\xe6\xb5\x8b\xe8\xaf\x95\xe5\x85\xac\xe5\x91\x8a";
-static const char STR_NODE_ACTIONS_ZH[] = "\xe8\x8a\x82\xe7\x82\xb9\xe6\x93\x8d\xe4\xbd\x9c/\xe8\xae\xbe\xe7\xbd\xae";
-static const char STR_SHOW_NAME_LENGTH_ZH[] = "\xe6\x98\xbe\xe7\xa4\xba\xe9\x95\xbf/\xe7\x9f\xad\xe5\x90\x8d";
-static const char STR_BLUETOOTH_ZH[] = "\xe8\x93\x9d\xe7\x89\x99";
-static const char STR_NO_MESSAGES_ZH[] = "\xe6\x97\xa0\xe6\xb6\x88\xe6\x81\xaf";
-
-inline const char *getStringZH(StringKey key)
-{
-    switch (key) {
-    case StringKey::Back:
-        return STR_BACK_ZH;
-    case StringKey::OK:
-        return STR_OK_ZH;
-    case StringKey::GotIt:
-        return STR_GOT_IT_ZH;
-    case StringKey::WelcomeToMeshtastic:
-        return STR_WELCOME_TO_MESHTASTIC_ZH;
-    case StringKey::SwipeToNavigate:
-        return STR_SWIPE_TO_NAVIGATE_ZH;
-    case StringKey::ClickToNavigate:
-        return STR_CLICK_TO_NAVIGATE_ZH;
-    case StringKey::UseSelectButton:
-        return STR_USE_SELECT_BUTTON_ZH;
-    case StringKey::DeviceRole:
-        return STR_DEVICE_ROLE_ZH;
-    case StringKey::RadioPreset:
-        return STR_RADIO_PRESET_ZH;
-    case StringKey::FrequencySlot:
-        return STR_FREQUENCY_SLOT_ZH;
-    case StringKey::LoRaRegion:
-        return STR_LORA_REGION_ZH;
-    case StringKey::Client:
-        return STR_CLIENT_ZH;
-    case StringKey::ClientMute:
-        return STR_CLIENT_MUTE_ZH;
-    case StringKey::LostAndFound:
-        return STR_LOST_AND_FOUND_ZH;
-    case StringKey::Tracker:
-        return STR_TRACKER_ZH;
-    case StringKey::Hour12:
-        return STR_12HOUR_ZH;
-    case StringKey::Hour24:
-        return STR_24HOUR_ZH;
-    case StringKey::ClockAction:
-        return STR_CLOCK_ACTION_ZH;
-    case StringKey::ClockFace:
-        return STR_CLOCK_FACE_ZH;
-    case StringKey::TimeFormat:
-        return STR_TIME_FORMAT_ZH;
-    case StringKey::Timezone:
-        return STR_TIMEZONE_ZH;
-    case StringKey::MessageAction:
-        return STR_MESSAGE_ACTION_ZH;
-    case StringKey::Reply:
-        return STR_REPLY_ZH;
-    case StringKey::ViewChats:
-        return STR_VIEW_CHATS_ZH;
-    case StringKey::UnmuteChannel:
-        return STR_UNMUTE_CHANNEL_ZH;
-    case StringKey::MuteChannel:
-        return STR_MUTE_CHANNEL_ZH;
-    case StringKey::Delete:
-        return STR_DELETE_ZH;
-    case StringKey::ReadAloud:
-        return STR_READ_ALOUD_ZH;
-    case StringKey::Brightness:
-        return STR_BRIGHTNESS_ZH;
-    case StringKey::FrameVisibility:
-        return STR_FRAME_VISIBILITY_ZH;
-    case StringKey::DisplayUnits:
-        return STR_DISPLAY_UNITS_ZH;
-    case StringKey::MessageBubbles:
-        return STR_MESSAGE_BUBBLES_ZH;
-    case StringKey::Theme:
-        return STR_THEME_ZH;
-    case StringKey::Reboot:
-        return STR_REBOOT_ZH;
-    case StringKey::Shutdown:
-        return STR_SHUTDOWN_ZH;
-    case StringKey::SwitchToMUI:
-        return STR_SWITCH_TO_MUI_ZH;
-    case StringKey::DisplayOptions:
-        return STR_DISPLAY_OPTIONS_ZH;
-    case StringKey::Language:
-        return STR_LANGUAGE_ZH;
-    case StringKey::Chinese:
-        return STR_CHINESE_ZH;
-    case StringKey::English:
-        return STR_ENGLISH_ZH;
-    case StringKey::NoGPS:
-        return STR_NO_GPS_ZH;
-    case StringKey::GPSoff:
-        return STR_GPS_OFF_ZH;
-    case StringKey::GPSnotPresent:
-        return STR_GPS_NOT_PRESENT_ZH;
-    case StringKey::GPSisDisabled:
-        return STR_GPS_IS_DISABLED_ZH;
-    case StringKey::Node:
-        return STR_NODE_ZH;
-    case StringKey::Hop:
-        return STR_HOP_ZH;
-    case StringKey::USB:
-        return STR_USB_ZH;
-    case StringKey::BT_off:
-        return STR_BT_OFF_ZH;
-    case StringKey::WiFi:
-        return STR_WIFI_ZH;
-    case StringKey::WiFiNotConnected:
-        return STR_WIFI_NOT_CONNECTED_ZH;
-    case StringKey::WiFiConnected:
-        return STR_WIFI_CONNECTED_ZH;
-    case StringKey::SSID:
-        return STR_SSID_ZH;
-    case StringKey::LoRaInfo:
-        return STR_LORA_INFO_ZH;
-    case StringKey::LoRa:
-        return STR_LORA_ZH;
-    case StringKey::Role:
-        return STR_ROLE_ZH;
-    case StringKey::Freq:
-        return STR_FREQ_ZH;
-    case StringKey::ChUtil:
-        return STR_CHUTIL_ZH;
-    case StringKey::System:
-        return STR_SYSTEM_ZH;
-    case StringKey::Heap:
-        return STR_HEAP_ZH;
-    case StringKey::PSRAM:
-        return STR_PSRAM_ZH;
-    case StringKey::Flash:
-        return STR_FLASH_ZH;
-    case StringKey::SD:
-        return STR_SD_ZH;
-    case StringKey::Ver:
-        return STR_VER_ZH;
-    case StringKey::Up:
-        return STR_UP_ZH;
-    case StringKey::ClientApp:
-        return STR_CLIENT_APP_ZH;
-    case StringKey::NoConnected:
-        return STR_NO_CONNECTED_ZH;
-    case StringKey::LOCKED:
-        return STR_LOCKED_ZH;
-    case StringKey::ConnectToUnlock:
-        return STR_CONNECT_TO_UNLOCK_ZH;
-    case StringKey::Battery:
-        return STR_BATTERY_ZH;
-    case StringKey::Resuming:
-        return STR_RESUMING_ZH;
-    case StringKey::LastHeard:
-        return STR_LAST_HEARD_ZH;
-    case StringKey::HopsSig:
-        return STR_HOPS_SIG_ZH;
-    case StringKey::HopsSignal:
-        return STR_HOPS_SIGNAL_ZH;
-    case StringKey::Nodes:
-        return STR_NODES_ZH;
-    case StringKey::Distance:
-        return STR_DISTANCE_ZH;
-    case StringKey::Bearings:
-        return STR_BEARINGS_ZH;
-    case StringKey::CreatingSSLCert:
-        return STR_CREATING_SSL_ZH;
-    case StringKey::PleaseWait:
-        return STR_PLEASE_WAIT_ZH;
-    case StringKey::CriticalFault:
-        return STR_CRITICAL_FAULT_ZH;
-    case StringKey::ForHelpVisit:
-        return STR_FOR_HELP_VISIT_ZH;
-    case StringKey::Updating:
-        return STR_UPDATING_ZH;
-    case StringKey::PleaseBePatient:
-        return STR_PLEASE_BE_PATIENT_ZH;
-    case StringKey::RebootInProgress:
-        return STR_REBOOT_IN_PROGRESS_ZH;
-    case StringKey::PowerMenu:
-        return STR_POWER_MENU_ZH;
-    case StringKey::SystemMenu:
-        return STR_SYSTEM_MENU_ZH;
-    case StringKey::ScreenOptions:
-        return STR_SCREEN_OPTIONS_ZH;
-    case StringKey::WifiToggle:
-        return STR_WIFI_TOGGLE_ZH;
-    case StringKey::BluetoothToggle:
-        return STR_BLUETOOTH_TOGGLE_ZH;
-    case StringKey::NodeDbReset:
-        return STR_NODE_DB_RESET_ZH;
-    case StringKey::ManageNode:
-        return STR_MANAGE_NODE_ZH;
-    case StringKey::RemoveFavorite:
-        return STR_REMOVE_FAVORITE_ZH;
-    case StringKey::AddFavorite:
-        return STR_ADD_FAVORITE_ZH;
-    case StringKey::TestMenu:
-        return STR_TEST_MENU_ZH;
-    case StringKey::TraceRoute:
-        return STR_TRACE_ROUTE_ZH;
-    case StringKey::ThrottleMessage:
-        return STR_THROTTLE_MSG_ZH;
-    case StringKey::MessageViewMode:
-        return STR_MSG_VIEW_MODE_ZH;
-    case StringKey::DeleteMessages:
-        return STR_DELETE_MESSAGES_ZH;
-    case StringKey::NodeNameLength:
-        return STR_NODE_NAME_LENGTH_ZH;
-    case StringKey::GPSMenu:
-        return STR_GPS_MENU_ZH;
-    case StringKey::GPSToggle:
-        return STR_GPS_TOGGLE_ZH;
-    case StringKey::GPSFormat:
-        return STR_GPS_FORMAT_ZH;
-    case StringKey::GPSSmartPosition:
-        return STR_GPS_SMART_POS_ZH;
-    case StringKey::GPSUpdateInterval:
-        return STR_GPS_UPDATE_INTERVAL_ZH;
-    case StringKey::GPSPositionBroadcast:
-        return STR_GPS_POS_BCAST_ZH;
-    case StringKey::CompassNorth:
-        return STR_COMPASS_NORTH_ZH;
-    case StringKey::BuzzerMode:
-        return STR_BUZZER_MODE_ZH;
-    case StringKey::HamModeConfirm:
-        return STR_HAM_MODE_ZH;
-    case StringKey::LicensedToNormal:
-        return STR_LICENSED_NORMAL_ZH;
-    case StringKey::KeyVerification:
-        return STR_KEY_VERIFY_ZH;
-    case StringKey::RegionUnset:
-        return STR_REGION_UNSET_ZH;
-    case StringKey::SelectRegionMessage:
-        return STR_SELECT_REGION_ZH;
-    case StringKey::Rebooting:
-        return STR_REBOOTING_ZH;
-    case StringKey::LoRaActions:
-        return STR_LORA_ACTIONS_ZH;
-    case StringKey::Slot0:
-        return STR_SLOT0_ZH;
-    case StringKey::WithPreset:
-        return STR_WITH_PRESET_ZH;
-    case StringKey::WithFreetext:
-        return STR_WITH_FREETEXT_ZH;
-    case StringKey::DeleteOldest:
-        return STR_DELETE_OLDEST_ZH;
-    case StringKey::DeleteThisChat:
-        return STR_DELETE_THIS_CHAT_ZH;
-    case StringKey::DeleteAll:
-        return STR_DELETE_ALL_ZH;
-    case StringKey::DeleteAllChats:
-        return STR_DELETE_ALL_CHATS_ZH;
-    case StringKey::TemporarilyMute:
-        return STR_TEMPORARILY_MUTE_ZH;
-    case StringKey::Unmute:
-        return STR_UNMUTE_ZH;
-    case StringKey::ToggleBacklight:
-        return STR_TOGGLE_BACKLIGHT_ZH;
-    case StringKey::SleepScreen:
-        return STR_SLEEP_SCREEN_ZH;
-    case StringKey::SendPosition:
-        return STR_SEND_POSITION_ZH;
-    case StringKey::SendNodeInfo:
-        return STR_SEND_NODE_INFO_ZH;
-    case StringKey::NewPresetMsg:
-        return STR_NEW_PRESET_MSG_ZH;
-    case StringKey::NewFreetextMsg:
-        return STR_NEW_FREETEXT_MSG_ZH;
-    case StringKey::Notifications:
-        return STR_NOTIFICATIONS_ZH;
-    case StringKey::Power:
-        return STR_POWER_ZH;
-    case StringKey::RebootShutdown:
-        return STR_REBOOT_SHUTDOWN_ZH;
-    case StringKey::GoToChat:
-        return STR_GO_TO_CHAT_ZH;
-    case StringKey::NewPreset:
-        return STR_NEW_PRESET_ZH;
-    case StringKey::Favorite:
-        return STR_FAVORITE_ZH;
-    case StringKey::UnmuteNotifications:
-        return STR_UNMUTE_NOTIFICATIONS_ZH;
-    case StringKey::MuteNotifications:
-        return STR_MUTE_NOTIFICATIONS_ZH;
-    case StringKey::UnignoreNode:
-        return STR_UNIGNORE_NODE_ZH;
-    case StringKey::IgnoreNode:
-        return STR_IGNORE_NODE_ZH;
-    case StringKey::NumberPicker:
-        return STR_NUMBER_PICKER_ZH;
-    case StringKey::TestAnnounce:
-        return STR_TEST_ANNOUNCE_ZH;
-    case StringKey::NodeActionsSettings:
-        return STR_NODE_ACTIONS_ZH;
-    case StringKey::ShowNameLength:
-        return STR_SHOW_NAME_LENGTH_ZH;
-    case StringKey::Bluetooth:
-        return STR_BLUETOOTH_ZH;
-    case StringKey::NoMessages:
-        return STR_NO_MESSAGES_ZH;
-    default:
-        return "?";
-    }
-}
-
-} // namespace l10n
-} // namespace meshtastic

src/graphics/niche/InkHUD/Applets/System/Menu/MenuAction.h

@@ -129,7 +129,6 @@ enum MenuAction {
     // Administration
     RESET_NODEDB_ALL,
     RESET_NODEDB_KEEP_FAVORITES,
-    WIPE_MESSAGES_ALL,
 };
 
 } // namespace NicheGraphics::InkHUD

src/graphics/niche/InkHUD/Applets/System/Menu/MenuApplet.cpp

@@ -6,7 +6,6 @@
 #include "GPS.h"
 #include "MeshRadio.h"
 #include "MeshService.h"
-#include "MessageStore.h"
 #include "RTC.h"
 #include "Router.h"
 #include "airtime.h"
@@ -288,7 +287,7 @@ static void applyLoRaRegion(meshtastic_Config_LoRaConfig_RegionCode region)
     }
 
     if (strncmp(moduleConfig.mqtt.root, default_mqtt_root, strlen(default_mqtt_root)) == 0) {
-        snprintf(moduleConfig.mqtt.root, sizeof(moduleConfig.mqtt.root), "%s/%s", default_mqtt_root, myRegion->name);
+        sprintf(moduleConfig.mqtt.root, "%s/%s", default_mqtt_root, myRegion->name);
         changes |= SEGMENT_MODULECONFIG;
     }
     // Notify UI that changes are being applied
@@ -1014,13 +1013,6 @@ void InkHUD::MenuApplet::execute(MenuItem item)
         rebootAtMsec = millis() + DEFAULT_REBOOT_SECONDS * 1000;
         break;
 
-    case WIPE_MESSAGES_ALL:
-        LOG_INFO("Wiping all messages from menu");
-        messageStore.clearAllMessages();
-        inkhud->persistence->loadLatestMessage();
-        inkhud->forceUpdate(Drivers::EInk::UpdateTypes::FULL, true);
-        break;
-
     default:
         LOG_WARN("Action not implemented");
     }
@@ -1138,7 +1130,6 @@ void InkHUD::MenuApplet::showPage(MenuPage page)
         // Administration Section
         items.push_back(MenuItem::Header("Administration"));
         items.push_back(MenuItem("Reset NodeDB", MenuPage::NODE_CONFIG_ADMIN_RESET));
-        items.push_back(MenuItem("Wipe Messages", MenuPage::NODE_CONFIG_ADMIN_MESSAGES));
 
         // Exit
         items.push_back(MenuItem("Exit", MenuPage::EXIT));
@@ -1543,13 +1534,6 @@ void InkHUD::MenuApplet::showPage(MenuPage page)
         items.push_back(MenuItem("Exit", MenuPage::EXIT));
         break;
 
-    case NODE_CONFIG_ADMIN_MESSAGES:
-        previousPage = MenuPage::NODE_CONFIG;
-        items.push_back(MenuItem("Back", previousPage));
-        items.push_back(MenuItem("Wipe All Messages", MenuAction::WIPE_MESSAGES_ALL, MenuPage::EXIT));
-        items.push_back(MenuItem("Exit", MenuPage::EXIT));
-        break;
-
     // Exit
     case EXIT:
         sendToBackground(); // Menu applet dismissed, allow normal behavior to resume

src/graphics/niche/InkHUD/Applets/System/Menu/MenuPage.h

@@ -36,7 +36,6 @@ enum MenuPage : uint8_t {
     NODE_CONFIG_BLUETOOTH,
     NODE_CONFIG_POSITION,
     NODE_CONFIG_ADMIN_RESET,
-    NODE_CONFIG_ADMIN_MESSAGES,
     TIMEZONE,
     APPLETS,
     AUTOSHOW,

src/graphics/niche/InkHUD/Persistence.cpp

@@ -22,8 +22,6 @@ void InkHUD::Persistence::loadSettings()
 // are immediately available to applets (DMApplet, AllMessageApplet, NotificationApplet).
 void InkHUD::Persistence::loadLatestMessage()
 {
-    latestMessage = LatestMessage();
-
     int lastBroadcastPos = -1, lastDMPos = -1, pos = 0;
     for (const StoredMessage &m : messageStore.getLiveMessages()) {
         if (m.type == MessageType::BROADCAST) {
@@ -77,4 +75,4 @@ void InkHUD::Persistence::printSettings(Settings *settings)
 }
 */
 
-#endif
+#endif

src/input/HapticFeedback.cpp

@@ -1,97 +0,0 @@
-#include "HapticFeedback.h"
-
-#ifdef HAPTIC_FEEDBACK_PIN
-
-#include <Arduino.h>
-
-#ifdef HAPTIC_FEEDBACK_ACTIVE_LOW
-#define HAPTIC_FEEDBACK_ON_STATE LOW
-#define HAPTIC_FEEDBACK_OFF_STATE HIGH
-#else
-#define HAPTIC_FEEDBACK_ON_STATE HIGH
-#define HAPTIC_FEEDBACK_OFF_STATE LOW
-#endif
-
-HapticFeedback *hapticFeedback = nullptr;
-
-void initHapticFeedback()
-{
-    if (!hapticFeedback)
-        hapticFeedback = new HapticFeedback();
-}
-
-HapticFeedback::HapticFeedback() : concurrency::OSThread("Haptic")
-{
-    pinMode(HAPTIC_FEEDBACK_PIN, OUTPUT);
-    digitalWrite(HAPTIC_FEEDBACK_PIN, HAPTIC_FEEDBACK_OFF_STATE);
-}
-
-void HapticFeedback::motorWrite(bool on)
-{
-    digitalWrite(HAPTIC_FEEDBACK_PIN, on ? HAPTIC_FEEDBACK_ON_STATE : HAPTIC_FEEDBACK_OFF_STATE);
-}
-
-void HapticFeedback::pulse(uint16_t durationMs)
-{
-    motorWrite(true);
-    pulseOffAt = millis() + durationMs;
-    if (pulseOffAt == 0) // 0 is the "no pulse" sentinel
-        pulseOffAt = 1;
-    scheduleNext();
-}
-
-void HapticFeedback::armDelayedPulse(uint16_t delayMs, uint16_t durationMs)
-{
-    delayedPulseAt = millis() + delayMs;
-    if (delayedPulseAt == 0)
-        delayedPulseAt = 1;
-    delayedPulseDuration = durationMs;
-    scheduleNext();
-}
-
-void HapticFeedback::cancelDelayedPulse()
-{
-    delayedPulseAt = 0;
-}
-
-void HapticFeedback::scheduleNext()
-{
-    uint32_t now = millis();
-    uint32_t next = 0;
-    if (pulseOffAt != 0)
-        next = pulseOffAt;
-    if (delayedPulseAt != 0 && (next == 0 || (int32_t)(delayedPulseAt - next) < 0))
-        next = delayedPulseAt;
-    if (next == 0)
-        return;
-    int32_t delay = (int32_t)(next - now);
-    setIntervalFromNow(delay > 0 ? (unsigned long)delay : 0);
-}
-
-int32_t HapticFeedback::runOnce()
-{
-    uint32_t now = millis();
-
-    if (pulseOffAt != 0 && (int32_t)(now - pulseOffAt) >= 0) {
-        motorWrite(false);
-        pulseOffAt = 0;
-    }
-
-    if (delayedPulseAt != 0 && (int32_t)(now - delayedPulseAt) >= 0) {
-        uint16_t dur = delayedPulseDuration;
-        delayedPulseAt = 0;
-        pulse(dur);
-    }
-
-    uint32_t next = 0;
-    if (pulseOffAt != 0)
-        next = pulseOffAt;
-    if (delayedPulseAt != 0 && (next == 0 || (int32_t)(delayedPulseAt - next) < 0))
-        next = delayedPulseAt;
-    if (next == 0)
-        return 60 * 1000;
-    int32_t delay = (int32_t)(next - now);
-    return delay > 0 ? delay : 0;
-}
-
-#endif // HAPTIC_FEEDBACK_PIN

src/input/HapticFeedback.h

@@ -1,35 +0,0 @@
-#pragma once
-
-#include "configuration.h"
-
-#ifdef HAPTIC_FEEDBACK_PIN
-
-#include "concurrency/OSThread.h"
-#include <stdint.h>
-
-// Non-blocking pulses on a GPIO vibration motor. HAPTIC_FEEDBACK_ACTIVE_LOW inverts polarity.
-class HapticFeedback : public concurrency::OSThread
-{
-  public:
-    HapticFeedback();
-    void pulse(uint16_t durationMs = 30);
-    void armDelayedPulse(uint16_t delayMs, uint16_t durationMs = 30);
-    void cancelDelayedPulse();
-
-  protected:
-    int32_t runOnce() override;
-
-  private:
-    uint32_t pulseOffAt = 0;
-    uint32_t delayedPulseAt = 0;
-    uint16_t delayedPulseDuration = 0;
-
-    void motorWrite(bool on);
-    // Reschedule to the soonest pending event so later arms don't clobber earlier wakes.
-    void scheduleNext();
-};
-
-extern HapticFeedback *hapticFeedback;
-void initHapticFeedback();
-
-#endif // HAPTIC_FEEDBACK_PIN

src/input/InputBroker.cpp

@@ -2,11 +2,7 @@
 #include "PowerFSM.h" // needed for event trigger
 #include "configuration.h"
 #include "graphics/Screen.h"
-#include "input/HapticFeedback.h"
 #include "modules/ExternalNotificationModule.h"
-#ifdef MESHTASTIC_LOCKDOWN
-#include "security/LockdownDisplay.h"
-#endif
 
 #if ARCH_PORTDUINO
 #include "input/LinuxInputImpl.h"
@@ -126,22 +122,6 @@ int InputBroker::handleInputEvent(const InputEvent *event)
     }
 #endif
 
-#ifdef MESHTASTIC_LOCKDOWN
-    // Lockdown: when the display is redacted (storage locked, or screen-lock
-    // latch set after idle) the screen content is hidden, but local input
-    // would otherwise still flow into UI handlers — letting an operator
-    // drive menus, fire canned messages, change settings etc. blind. Eat
-    // the event here so input is no-op until the redaction clears.
-    // The latch is cleared only by unlockScreen() on a successful
-    // passphrase auth (see PhoneAPI::handleLockdownAuthInline) — local
-    // input does not clear it, even if storage happens to be unlocked.
-    // PowerFSM was already triggered above, so the backlight still wakes
-    // to show the LOCKED frame — the input just doesn't act on anything.
-    if (meshtastic_security::shouldRedactDisplay()) {
-        return 0;
-    }
-#endif
-
     this->notifyObservers(event);
     return 0;
 }
@@ -257,16 +237,6 @@ void InputBroker::Init()
         }
         touchBacklightActive = false;
     };
-#endif
-#if defined(HAPTIC_FEEDBACK_PIN)
-    // Blip on touch, second blip when long-press fires (500 ms = touchConfig.longPressTime default).
-    touchConfig.suppressLeadUpSound = true;
-    initHapticFeedback();
-    touchConfig.onPress = []() {
-        hapticFeedback->pulse(80);
-        hapticFeedback->armDelayedPulse(500, 80);
-    };
-    touchConfig.onRelease = []() { hapticFeedback->cancelDelayedPulse(); };
 #endif
     TouchButtonThread->initButton(touchConfig);
 #endif

src/main.cpp

@@ -68,19 +68,6 @@ void nrf54l15Loop();
 NRF54L15Bluetooth *nrf54l15Bluetooth = nullptr;
 #endif
 
-#ifdef MESHTASTIC_ENABLE_APPROTECT
-#include "security/APProtect.h"
-#endif
-#ifdef MESHTASTIC_ENCRYPTED_STORAGE
-#include "security/EncryptedStorage.h"
-#endif
-#ifdef MESHTASTIC_PHONEAPI_ACCESS_CONTROL
-#include "mesh/PhoneAPI.h"
-#endif
-#ifdef MESHTASTIC_LOCKDOWN
-#include "security/LockdownDisplay.h"
-#endif
-
 #if HAS_WIFI || defined(USE_WS5500) || defined(USE_CH390D)
 #include "mesh/api/WiFiServerAPI.h"
 #include "mesh/wifi/WiFiAPClient.h"
@@ -392,14 +379,6 @@ void setup()
     consoleInit(); // Set serial baud rate and init our mesh console
 #endif
 
-    // M23 (audit): APPROTECT engagement moved below fsInit() so we can gate
-    // on EncryptedStorage::isProvisioned(). Engaging on an unprovisioned dev
-    // board permanently locks SWD before the operator has even set a
-    // passphrase — a misconfigured CI build flashed to a developer device
-    // would brick its debug port on first boot. Now we only engage when the
-    // device has a DEK file on flash, i.e. the operator has explicitly
-    // committed to lockdown via passphrase provisioning.
-
 #ifdef UNPHONE
     unphone.printStore();
 #endif
@@ -430,12 +409,7 @@ void setup()
 #endif
 #endif
 
-    // The DEBUG_MUTE "we are muted, FYI" banner spills APP_VERSION / APP_ENV /
-    // APP_REPO out the USB CDC even with logging otherwise suppressed — a free
-    // firmware-fingerprinting primitive for an attacker holding the cable.
-    // Under MESHTASTIC_LOCKDOWN we want the device to look uniformly silent
-    // until the operator authenticates, so skip the banner entirely there.
-#if defined(DEBUG_MUTE) && defined(DEBUG_PORT) && !defined(MESHTASTIC_LOCKDOWN)
+#if defined(DEBUG_MUTE) && defined(DEBUG_PORT)
     DEBUG_PORT.printf("\r\n\r\n//\\ E S H T /\\ S T / C\r\n");
     DEBUG_PORT.printf("Version %s for %s from %s\r\n", optstr(APP_VERSION), optstr(APP_ENV), optstr(APP_REPO));
     DEBUG_PORT.printf("Debug mute is enabled, there will be no serial output.\r\n");
@@ -507,38 +481,6 @@ void setup()
 
     fsInit();
 
-#ifdef MESHTASTIC_ENCRYPTED_STORAGE
-    EncryptedStorage::initLocked();
-    if (!EncryptedStorage::isUnlocked()) {
-        if (!EncryptedStorage::isProvisioned()) {
-            LOG_WARN("Lockdown: Device not provisioned — connect and set a passphrase to unlock storage");
-        } else {
-            LOG_WARN("Lockdown: Device locked — connect and provide passphrase to unlock storage");
-        }
-    }
-#endif
-
-#if defined(MESHTASTIC_ENABLE_APPROTECT) && defined(MESHTASTIC_ENCRYPTED_STORAGE)
-    // M23 (audit): only engage the irreversible UICR APPROTECT lockout once
-    // the device has been provisioned with a passphrase. A misconfigured
-    // CI build of a lockdown variant flashed to a developer board would
-    // otherwise burn SWD on first boot before the operator has even set a
-    // passphrase, taking the board out of the dev/recovery workflow with
-    // no real security benefit (there's no DEK to protect yet). Once a
-    // DEK file exists, the operator has committed to lockdown — engaging
-    // APPROTECT then is the protection they asked for.
-    if (EncryptedStorage::isProvisioned()) {
-        enableAPProtect();
-    } else {
-        LOG_INFO("APPROTECT deferred: device not yet provisioned");
-    }
-#elif defined(MESHTASTIC_ENABLE_APPROTECT)
-    // Lockdown without encrypted storage shouldn't be reachable per
-    // configuration.h, but if it ever is, fall back to the unconditional
-    // engagement.
-    enableAPProtect();
-#endif
-
 #if !MESHTASTIC_EXCLUDE_I2C
 #if defined(I2C_SDA1) && defined(ARCH_RP2040)
     Wire1.setSDA(I2C_SDA1);
@@ -1071,6 +1013,19 @@ void setup()
         digitalWrite(RF95_FAN_EN, LOW ^ 0);
 #endif
 
+#ifndef ARCH_PORTDUINO
+
+        // Initialize Wifi
+#if HAS_WIFI
+    initWifi();
+#endif
+
+#if HAS_ETHERNET
+    // Initialize Ethernet
+    initEthernet();
+#endif
+#endif
+
 #if defined(ARCH_ESP32) && !MESHTASTIC_EXCLUDE_WEBSERVER
     // Start web server thread.
     webServerThread = new WebServerThread();
@@ -1108,22 +1063,6 @@ void setup()
     setCPUFast(false); // 80MHz is fine for our slow peripherals
 #endif
 
-#ifndef ARCH_PORTDUINO
-    // Force BT init before WiFi so NimBLE gets clean heap
-#if defined(ARCH_ESP32) && !MESHTASTIC_EXCLUDE_BLUETOOTH
-    setBluetoothEnable(true);
-#endif
-    // Initialize Wifi after PowerFSM so BT gets clean heap during init
-#if HAS_WIFI
-    initWifi();
-#endif
-
-#if HAS_ETHERNET
-    // Initialize Ethernet
-    initEthernet();
-#endif
-#endif
-
 #ifdef ARDUINO_ARCH_ESP32
     LOG_DEBUG("Free heap  : %7d bytes", ESP.getFreeHeap());
     LOG_DEBUG("Free PSRAM : %7d bytes", ESP.getFreePsram());
@@ -1138,11 +1077,6 @@ uint32_t rebootAtMsec;     // If not zero we will reboot at this time (used to r
 uint32_t shutdownAtMsec;   // If not zero we will shutdown at this time (used to shutdown from python or mobile client)
 bool suppressRebootBanner; // If true, suppress "Rebooting..." overlay (used for OTA handoff)
 
-#if defined(MESHTASTIC_ENCRYPTED_STORAGE) && defined(MESHTASTIC_PHONEAPI_ACCESS_CONTROL)
-volatile bool lockdownReloadPending;  // see main.h — deferred NodeDB reload after lockdown unlock
-volatile bool lockdownDisablePending; // see main.h — deferred decrypt-revert after lockdown disable
-#endif
-
 // If a thread does something that might need for it to be rescheduled ASAP it can set this flag
 // This will suppress the current delay and instead try to run ASAP.
 bool runASAP;
@@ -1194,7 +1128,7 @@ extern meshtastic_DeviceMetadata getDeviceMetadata()
 // No bluetooth on these targets (yet):
 // Pico W / 2W may get it at some point
 // Portduino and ESP32-C6 are excluded because we don't have a working bluetooth stacks integrated yet.
-#if defined(ARCH_RP2040) || defined(ARCH_PORTDUINO) || defined(ARCH_STM32) || defined(CONFIG_IDF_TARGET_ESP32C6)
+#if defined(ARCH_RP2040) || defined(ARCH_PORTDUINO) || defined(ARCH_STM32WL) || defined(CONFIG_IDF_TARGET_ESP32C6)
     deviceMetadata.excluded_modules |= meshtastic_ExcludedModules_BLUETOOTH_CONFIG;
 #endif
 
@@ -1227,85 +1161,6 @@ void loop()
 {
     runASAP = false;
 
-#if defined(MESHTASTIC_ENCRYPTED_STORAGE) && defined(MESHTASTIC_PHONEAPI_ACCESS_CONTROL)
-    if (lockdownDisablePending) {
-        lockdownDisablePending = false;
-        LOG_INFO("Lockdown: disabling — reverting encrypted storage to plaintext");
-        if (nodeDB->disableLockdownToPlaintext()) {
-            LOG_INFO("Lockdown: disabled, rebooting into normal mode");
-            PhoneAPI::broadcastLockdownStatus(meshtastic_LockdownStatus_State_DISABLED, "", 0, 0, 0);
-            rebootAtMsec = millis() + DEFAULT_REBOOT_SECONDS * 1000;
-        } else {
-            // Revert failed mid-way (a file couldn't be decrypted/rewritten).
-            // The DEK file is still present (it's deleted last), so the device
-            // stays in lockdown and the operator can retry disable. Surface
-            // the failure rather than leaving the client hanging.
-            LOG_ERROR("Lockdown: disable revert failed — device remains in lockdown");
-            PhoneAPI::broadcastLockdownStatus(meshtastic_LockdownStatus_State_LOCKED, "disable_failed", 0, 0, 0);
-        }
-    }
-
-    if (lockdownReloadPending) {
-        lockdownReloadPending = false;
-        LOG_INFO("Lockdown: reloading config from disk after unlock");
-        bool reloadOk = nodeDB->reloadFromDisk();
-        if (!reloadOk) {
-            // Storage decrypt/decode failed during reload. Treat as
-            // unrecoverable for this boot: lock storage, revoke any
-            // auth that managed to slip through (defense in depth — the
-            // cold-unlock path doesn't authorize until completion, but
-            // a concurrent re-verify-path call from another connection
-            // might have), and notify clients. Storage will be locked
-            // on next boot anyway; deferring to the user-visible
-            // notification path is sufficient for now.
-            LOG_ERROR("Lockdown: reload failed — locking and notifying clients");
-            EncryptedStorage::lockNow();
-            PhoneAPI::revokeAllAuth();
-        }
-        PhoneAPI::completePendingUnlocks(reloadOk);
-    }
-
-    // Periodic session-expiry check. Cheap — millis() comparison. Don't
-    // hammer it every loop tick; once a second is plenty.
-    static uint32_t lastSessionCheckMs = 0;
-    if (millis() - lastSessionCheckMs > 1000) {
-        lastSessionCheckMs = millis();
-        if (rebootAtMsec == 0 && EncryptedStorage::isUnlocked() && EncryptedStorage::isSessionExpired()) {
-            // The session expired. Two paths:
-            //   1. Budget remains (bootsRemaining > 0): decrement the
-            //      on-flash boot count in place, revoke per-connection
-            //      auth, re-engage screen redaction, re-arm the uptime
-            //      timer — all WITHOUT rebooting. Storage stays unlocked
-            //      so the mesh keeps routing. Clients must re-authenticate
-            //      to see content again. The decrement is what enforces
-            //      the rollback ceiling — bootsRemaining ticks down
-            //      monotonically whether the device reboots or not.
-            //   2. Budget exhausted (bootsRemaining == 0): no more
-            //      sessions to grant. Hard lock (token deleted, DEK
-            //      zeroed) and reboot. Operator must re-enter passphrase.
-            if (EncryptedStorage::getBootsRemaining() == 0) {
-                LOG_WARN("Lockdown: session limit reached and boot budget exhausted, locking and rebooting");
-                EncryptedStorage::lockNow();
-                PhoneAPI::revokeAllAuth();
-                PhoneAPI::broadcastLockdownStatus(meshtastic_LockdownStatus_State_LOCKED, "session_budget_exhausted", 0, 0, 0);
-                rebootAtMsec = millis() + DEFAULT_REBOOT_SECONDS * 1000;
-            } else {
-                uint8_t newBoots = EncryptedStorage::consumeSessionBoot();
-                LOG_WARN("Lockdown: session expired, rolled to next budget slot (boots=%u remaining)", newBoots);
-                PhoneAPI::revokeAllAuth();
-                meshtastic_security::lockScreen();
-                // Signal clients that they need to re-auth on this
-                // connection. Storage is still unlocked (DEK in RAM,
-                // mesh keeps routing) but per-connection auth is gone.
-                // Reusing the LOCKED(needs_auth) post-config emission
-                // pattern so existing clients don't need a new state.
-                PhoneAPI::broadcastLockdownStatus(meshtastic_LockdownStatus_State_LOCKED, "needs_auth", newBoots,
-                                                  EncryptedStorage::getValidUntilEpoch(), 0);
-            }
-        }
-    }
-#endif
-
 #ifdef ARCH_ESP32
     esp32Loop();
 #endif

src/main.h

@@ -92,19 +92,6 @@ extern uint32_t rebootAtMsec;
 extern uint32_t shutdownAtMsec;
 extern bool suppressRebootBanner;
 
-#if defined(MESHTASTIC_ENCRYPTED_STORAGE) && defined(MESHTASTIC_PHONEAPI_ACCESS_CONTROL)
-// Set by PhoneAPI::handleLockdownAuthInline after a successful unlock.
-// Serviced on the main loop thread because NodeDB::reloadFromDisk() is
-// too heavy for the BLE/serial transport callback stack.
-extern volatile bool lockdownReloadPending;
-
-// Set by PhoneAPI::handleLockdownAuthInline on a disable request (after the
-// passphrase is verified). Serviced on the main loop thread: decrypt every
-// pref back to plaintext, remove the lockdown artifacts, reboot. Heavy file
-// IO, same reason as lockdownReloadPending.
-extern volatile bool lockdownDisablePending;
-#endif
-
 extern uint32_t serialSinceMsec;
 
 // If a thread does something that might need for it to be rescheduled ASAP it can set this flag

src/memGet.cpp

@@ -14,7 +14,7 @@
 #include <malloc.h>
 #include <unistd.h> // sbrk
 
-#if defined(ARCH_STM32)
+#ifdef ARCH_STM32WL
 // Returns the uncommitted sbrk headroom: addressable space between the current heap
 // break and the stack pointer that has not yet been committed to the arena.
 static uint32_t sbrkHeadroom()

src/mesh/Channels.cpp

@@ -404,60 +404,6 @@ bool Channels::isDefaultChannel(ChannelIndex chIndex)
     return false;
 }
 
-bool cryptoKeyIsPublic(const CryptoKey &key)
-{
-    if (key.length == 0)
-        return true; // encryption disabled
-    // Match the defaultpsk family ignoring its last byte (getKey() bumps only that byte per 1-byte index).
-    if (key.length == (int)sizeof(defaultpsk) && memcmp(key.bytes, defaultpsk, sizeof(defaultpsk) - 1) == 0)
-        return true;
-    return false;
-}
-
-bool Channels::usesPublicKey(ChannelIndex chIndex)
-{
-    const meshtastic_Channel &ch = getByIndex(chIndex);
-    if (!ch.has_settings || ch.role == meshtastic_Channel_Role_DISABLED)
-        return false;
-
-    const auto &psk = ch.settings.psk;
-    if (psk.size == 0) {
-        // Secondary channels inherit the primary key when unset; primary size==0 means encryption disabled.
-        if (ch.role == meshtastic_Channel_Role_SECONDARY) {
-            // Guard against malformed configs with no PRIMARY channel (primaryIndex could point back to us).
-            if (primaryIndex == chIndex)
-                return true; // fail closed: treat as public
-            return usesPublicKey(primaryIndex);
-        }
-        return true;
-    }
-
-    if (psk.size == 1) {
-        // Short PSK aliases: 0 disables encryption; 1..255 are the public defaultpsk family.
-        return true;
-    }
-
-    return (psk.size == sizeof(defaultpsk) && memcmp(psk.bytes, defaultpsk, sizeof(defaultpsk) - 1) == 0);
-}
-
-bool Channels::isWellKnownChannel(ChannelIndex chIndex)
-{
-    const auto &ch = getByIndex(chIndex);
-    // Absent (unencrypted) or single-byte PSK — all the well-known key indexes
-    if (ch.settings.psk.size > 1)
-        return false;
-
-    const char *name = getName(chIndex);
-    for (int p = _meshtastic_Config_LoRaConfig_ModemPreset_MIN; p <= _meshtastic_Config_LoRaConfig_ModemPreset_MAX; p++) {
-        const char *presetName =
-            DisplayFormatters::getModemPresetDisplayName(static_cast<meshtastic_Config_LoRaConfig_ModemPreset>(p), false, true);
-        // Presets without a display name fall through to "Invalid" — never a match
-        if (strcmp(presetName, "Invalid") != 0 && strcmp(name, presetName) == 0)
-            return true;
-    }
-    return false;
-}
-
 bool Channels::hasDefaultChannel()
 {
     // If we don't use a preset or the default frequency slot, or we override the frequency, we don't have a default channel

src/mesh/Channels.h

@@ -86,15 +86,6 @@ class Channels
     // Returns true if the channel has the default name and PSK
     bool isDefaultChannel(ChannelIndex chIndex);
 
-    // Returns true if this channel's effective key is publicly decryptable (open or well-known/default PSK).
-    bool usesPublicKey(ChannelIndex chIndex);
-    // Returns true if the channel is "well known": its PSK is absent or a
-    // single-byte well-known key index, AND its name is any modem-preset
-    // display name (e.g. a channel named "LongFast" counts even while the
-    // radio runs MediumFast). Broader than isDefaultChannel, which only
-    // matches the current preset's name and PSK byte 1.
-    bool isWellKnownChannel(ChannelIndex chIndex);
-
     // Returns true if we can be reached via a channel with the default settings given a region and modem preset
     bool hasDefaultChannel();
 
@@ -153,9 +144,6 @@ extern Channels channels;
 static const uint8_t defaultpsk[] = {0xd4, 0xf1, 0xbb, 0x3a, 0x20, 0x29, 0x07, 0x59,
                                      0xf0, 0xbc, 0xff, 0xab, 0xcf, 0x4e, 0x69, 0x01};
 
-/// True if a getKey()-resolved key offers no privacy: length 0 (off) or the public defaultpsk family. Pure; for tests.
-bool cryptoKeyIsPublic(const CryptoKey &key);
-
 static const uint8_t eventpsk[] = {0x38, 0x4b, 0xbc, 0xc0, 0x1d, 0xc0, 0x22, 0xd1, 0x81, 0xbf, 0x36,
                                    0xb8, 0x61, 0x21, 0xe1, 0xfb, 0x96, 0xb7, 0x2e, 0x55, 0xbf, 0x74,
                                    0x22, 0x7e, 0x9d, 0x6a, 0xfb, 0x48, 0xd6, 0x4c, 0xb1, 0xa1};

src/mesh/CryptoEngine.cpp

@@ -12,18 +12,10 @@
 #include <Curve25519.h>
 #include <RNG.h>
 #include <SHA256.h>
-
-#if !(MESHTASTIC_EXCLUDE_XEDDSA)
-#include "XEdDSA.h"
-#include <Ed25519.h>
-
-#ifndef NUM_LIMBS_256BIT
-#define NUM_LIMBS_BITS(n) (((n) + sizeof(limb_t) * 8 - 1) / (8 * sizeof(limb_t)))
-#define NUM_LIMBS_256BIT NUM_LIMBS_BITS(256)
-#endif
-#endif
-
 #if !(MESHTASTIC_EXCLUDE_PKI_KEYGEN)
+#if !defined(ARCH_STM32WL)
+#define CryptRNG RNG
+#endif
 
 /**
  * Create a public/private key pair with Curve25519.
@@ -54,9 +46,6 @@ void CryptoEngine::generateKeyPair(uint8_t *pubKey, uint8_t *privKey)
     Curve25519::dh1(public_key, private_key);
     memcpy(pubKey, public_key, sizeof(public_key));
     memcpy(privKey, private_key, sizeof(private_key));
-#if !(MESHTASTIC_EXCLUDE_XEDDSA)
-    XEdDSA::priv_curve_to_ed_keys(private_key, xeddsa_private_key, xeddsa_public_key);
-#endif
 }
 
 /**
@@ -76,9 +65,6 @@ bool CryptoEngine::regeneratePublicKey(uint8_t *pubKey, uint8_t *privKey)
         }
         memcpy(private_key, privKey, sizeof(private_key));
         memcpy(public_key, pubKey, sizeof(public_key));
-#if !(MESHTASTIC_EXCLUDE_XEDDSA)
-        XEdDSA::priv_curve_to_ed_keys(private_key, xeddsa_private_key, xeddsa_public_key);
-#endif
     } else {
         LOG_WARN("X25519 key generation failed due to blank private key");
         return false;
@@ -86,97 +72,6 @@ bool CryptoEngine::regeneratePublicKey(uint8_t *pubKey, uint8_t *privKey)
     return true;
 }
 
-#if !(MESHTASTIC_EXCLUDE_XEDDSA)
-/**
- * Build a signing buffer that covers packet metadata and payload:
- *   [fromNode(4) | packetId(4) | portnum(4) | payload(N)]
- * This prevents replay, reattribution, and portnum redirection attacks.
- */
-static size_t buildSigningBuffer(uint8_t *buf, size_t bufSize, uint32_t fromNode, uint32_t packetId, uint32_t portnum,
-                                 const uint8_t *payload, size_t payloadLen)
-{
-    const size_t headerLen = sizeof(uint32_t) * 3;
-    size_t totalLen = headerLen + payloadLen;
-    if (totalLen > bufSize)
-        return 0;
-    // May need endian conversion for oddball platforms.
-    memcpy(buf, &fromNode, sizeof(uint32_t));
-    memcpy(buf + sizeof(uint32_t), &packetId, sizeof(uint32_t));
-    memcpy(buf + sizeof(uint32_t) * 2, &portnum, sizeof(uint32_t));
-    memcpy(buf + headerLen, payload, payloadLen);
-    return totalLen;
-}
-
-bool CryptoEngine::xeddsa_sign(uint32_t fromNode, uint32_t packetId, uint32_t portnum, const uint8_t *payload, size_t payloadLen,
-                               uint8_t *signature)
-{
-    if (memfll(xeddsa_private_key, 0, sizeof(xeddsa_private_key)))
-        return false;
-    uint8_t sigBuf[MAX_BLOCKSIZE];
-    size_t sigLen = buildSigningBuffer(sigBuf, sizeof(sigBuf), fromNode, packetId, portnum, payload, payloadLen);
-    if (sigLen == 0)
-        return false;
-    // the XEdDSA::sign function requires at least the first 32 bytes of signature to be pre-filled with randomness
-    HardwareRNG::fill(signature, 32);
-    XEdDSA::sign(signature, xeddsa_private_key, xeddsa_public_key, sigBuf, sigLen);
-    return true;
-}
-
-bool CryptoEngine::xeddsa_verify(const uint8_t *pubKey, uint32_t fromNode, uint32_t packetId, uint32_t portnum,
-                                 const uint8_t *payload, size_t payloadLen, const uint8_t *signature)
-{
-    // Use cached Ed25519 key if the Curve25519 key matches, avoiding expensive field inversion
-    if (memcmp(pubKey, cached_curve_pubkey, 32) != 0) {
-        curve_to_ed_pub(pubKey, cached_ed_pubkey);
-        memcpy(cached_curve_pubkey, pubKey, 32);
-    }
-    uint8_t sigBuf[MAX_BLOCKSIZE];
-    size_t sigLen = buildSigningBuffer(sigBuf, sizeof(sigBuf), fromNode, packetId, portnum, payload, payloadLen);
-    if (sigLen == 0)
-        return false;
-    return XEdDSA::verify(signature, cached_ed_pubkey, sigBuf, sigLen);
-}
-
-void CryptoEngine::curve_to_ed_pub(const uint8_t *curve_pubkey, uint8_t *ed_pubkey)
-{
-
-    // Apply the birational map defined in RFC 7748, section 4.1 "Curve25519" to calculate an Ed25519 public
-    // key from a Curve25519 public key. Because the serialization format of Curve25519 public keys only
-    // contains the u coordinate, the x coordinate of the corresponding Ed25519 public key can't be uniquely
-    // calculated as defined by the birational map. The x coordinate is represented in the serialization
-    // format of Ed25519 public keys only in a single sign bit. XEdDSA always normalizes the Ed25519 public
-    // key to a sign bit of zero (the signer negates its key pair when needed), so this function clears the
-    // sign bit unconditionally below instead of taking it as an input.
-    fe u, y;
-    fe one;
-    fe u_minus_one, u_plus_one, u_plus_one_inv;
-
-    // Parse the Curve25519 public key input as a field element containing the u coordinate. RFC 7748,
-    // section 5 "The X25519 and X448 Functions", mandates that the most significant bit of the Curve25519
-    // public key has to be zeroized. This is handled by fe_frombytes internally.
-    fe_frombytes(u, curve_pubkey);
-
-    // Calculate the parameters (u - 1) and (u + 1)
-    fe_1(one);
-    fe_sub(u_minus_one, u, one);
-    fe_add(u_plus_one, u, one);
-
-    // Invert u + 1
-    fe_invert(u_plus_one_inv, u_plus_one);
-
-    // Calculate y = (u - 1) * inv(u + 1) (mod p)
-    fe_mul(y, u_minus_one, u_plus_one_inv);
-
-    // Serialize the field element containing the y coordinate to the Ed25519 public key output
-    fe_tobytes(ed_pubkey, y);
-
-    // Set the sign bit to zero
-    ed_pubkey[31] &= 0x7f;
-
-    // need to convert the pubkey y = ( u - 1) * inv( u + 1) (mod p).
-}
-#endif
-
 bool CryptoEngine::ensurePkiKeys(meshtastic_Config_SecurityConfig &security, meshtastic_User &user)
 {
     if (user.is_licensed) {

src/mesh/CryptoEngine.h

@@ -23,7 +23,6 @@ struct CryptoKey {
 
 #define MAX_BLOCKSIZE 256
 #define TEST_CURVE25519_FIELD_OPS // Exposes Curve25519::isWeakPoint() for testing keys
-#define XEDDSA_SIGNATURE_SIZE 64
 
 class CryptoEngine
 {
@@ -38,12 +37,7 @@ class CryptoEngine
     virtual void generateKeyPair(uint8_t *pubKey, uint8_t *privKey);
     virtual bool regeneratePublicKey(uint8_t *pubKey, uint8_t *privKey);
     virtual bool ensurePkiKeys(meshtastic_Config_SecurityConfig &security, meshtastic_User &user);
-#endif
-#if !(MESHTASTIC_EXCLUDE_XEDDSA)
-    bool xeddsa_sign(uint32_t fromNode, uint32_t packetId, uint32_t portnum, const uint8_t *payload, size_t payloadLen,
-                     uint8_t *signature);
-    bool xeddsa_verify(const uint8_t *pubKey, uint32_t fromNode, uint32_t packetId, uint32_t portnum, const uint8_t *payload,
-                       size_t payloadLen, const uint8_t *signature);
+
 #endif
     void setDHPrivateKey(uint8_t *_private_key);
     // The remotePublic key parameter takes the public_key bytes container from
@@ -91,14 +85,6 @@ class CryptoEngine
 #if !(MESHTASTIC_EXCLUDE_PKI)
     uint8_t shared_key[32] = {0};
     uint8_t private_key[32] = {0};
-#if !(MESHTASTIC_EXCLUDE_XEDDSA)
-    uint8_t xeddsa_public_key[32] = {0};
-    uint8_t xeddsa_private_key[32] = {0};
-    void curve_to_ed_pub(const uint8_t *curve_pubkey, uint8_t *ed_pubkey);
-    // Single-entry cache for curve_to_ed_pub conversion (avoids expensive field inversion per packet)
-    uint8_t cached_curve_pubkey[32] = {0};
-    uint8_t cached_ed_pubkey[32] = {0};
-#endif
 #endif
     /**
      * Init our 128 bit nonce for a new packet

src/mesh/Default.h

@@ -18,9 +18,6 @@
 #define default_telemetry_broadcast_interval_secs IF_ROUTER(ONE_DAY / 2, 60 * 60)
 #define default_broadcast_interval_secs IF_ROUTER(ONE_DAY / 2, 60 * 60)
 #define default_broadcast_smart_minimum_interval_secs 5 * 60
-// Floor for our own position broadcasts when stationary (unchanged beyond the broadcast
-// precision) or fixed_position: identical positions get deduped by traffic management anyway.
-#define default_position_stationary_broadcast_secs (12 * 60 * 60)
 #define min_default_broadcast_interval_secs IF_ROUTER(ONE_DAY / 2, 60 * 60)
 #define min_default_broadcast_smart_minimum_interval_secs 5 * 60
 #define default_wait_bluetooth_secs IF_ROUTER(1, 60)
@@ -37,14 +34,8 @@
 enum class TrafficType { POSITION, TELEMETRY };
 
 // Traffic management defaults
-#define default_traffic_mgmt_position_precision_bits 19                // ~90m grid cells (±45m)
-#define default_traffic_mgmt_position_min_interval_secs (11 * 60 * 60) // 11 hours between identical positions
-// Role cap: tracker-role origins may refresh a duplicate position this often (vs the 11h default).
-#define default_traffic_mgmt_tracker_position_min_interval_secs (60 * 60) // 1 hour
-// Role cap: lost-and-found origins may refresh a duplicate position this often, so a lost
-// device updates frequently without flooding. (Quantised to the dedup tick: ~2 ticks.)
-// Unlike before, lost-and-found is NOT exempt from the relayed precision clamp.
-#define default_traffic_mgmt_lost_and_found_position_min_interval_secs (15 * 60) // 15 minutes
+#define default_traffic_mgmt_position_precision_bits 24               // ~10m grid cells
+#define default_traffic_mgmt_position_min_interval_secs (ONE_DAY / 2) // 12 hours between identical positions
 
 // Hop scaling defaults
 #define default_hop_scaling_min_target_nodes 40          // walk threshold: first hop reaching this cumulative count

src/mesh/LoRaFEMInterface.cpp

@@ -57,11 +57,6 @@ static void releaseSleepHolds()
 void LoRaFEMInterface::init(void)
 {
     setLnaCanControl(false); // Default is uncontrollable
-#if defined(RF_PA_DETECT_PIN)
-    pinMode(RF_PA_DETECT_PIN, INPUT);
-    high_power_pa = (digitalRead(RF_PA_DETECT_PIN) == RF_PA_HIGH_POWER_VALUE);
-    LOG_INFO("Detected %s LoRa PA profile", high_power_pa ? "high-power" : "low-power");
-#endif
 #ifdef HELTEC_V4
     pinMode(LORA_PA_POWER, OUTPUT);
     digitalWrite(LORA_PA_POWER, HIGH);
@@ -124,13 +119,6 @@ void LoRaFEMInterface::init(void)
     pinMode(LORA_KCT8103L_PA_CTX, OUTPUT);
     digitalWrite(LORA_KCT8103L_PA_CTX, LOW); // LNA enabled by default
     setLnaCanControl(true);
-#elif defined(USE_KCT8103L_PA_ONLY)
-    fem_type = KCT8103L_PA;
-    pinMode(LORA_KCT8103L_EN, OUTPUT);
-    digitalWrite(LORA_KCT8103L_EN, HIGH);
-    delay(1);
-    pinMode(LORA_KCT8103L_TX_RX, OUTPUT);
-    digitalWrite(LORA_KCT8103L_TX_RX, LOW);
 #endif
 }
 
@@ -160,9 +148,6 @@ void LoRaFEMInterface::setSleepModeEnable(void)
     // shutdown the PA
     digitalWrite(LORA_KCT8103L_PA_CSD, LOW);
     digitalWrite(LORA_PA_POWER, LOW);
-#elif defined(USE_KCT8103L_PA_ONLY)
-    // shutdown the PA
-    digitalWrite(LORA_KCT8103L_EN, LOW);
 #endif
 }
 
@@ -188,9 +173,6 @@ void LoRaFEMInterface::setTxModeEnable(void)
     enableFEMPower();
     digitalWrite(LORA_KCT8103L_PA_CSD, HIGH);
     digitalWrite(LORA_KCT8103L_PA_CTX, HIGH);
-#elif defined(USE_KCT8103L_PA_ONLY)
-    enableFEMPower();
-    digitalWrite(LORA_KCT8103L_TX_RX, HIGH);
 #endif
 }
 
@@ -224,9 +206,6 @@ void LoRaFEMInterface::setRxModeEnable(void)
     } else {
         digitalWrite(LORA_KCT8103L_PA_CTX, HIGH);
     }
-#elif defined(USE_KCT8103L_PA_ONLY)
-    enableFEMPower();
-    digitalWrite(LORA_KCT8103L_TX_RX, LOW);
 #endif
 }
 
@@ -268,9 +247,6 @@ void LoRaFEMInterface::setRxModeEnableWhenMCUSleep(void)
     rtc_gpio_hold_en((gpio_num_t)LORA_KCT8103L_PA_CSD);
     rtc_gpio_hold_en((gpio_num_t)LORA_KCT8103L_PA_CTX);
 #endif
-#elif defined(USE_KCT8103L_PA_ONLY)
-    enableFEMPower();
-    digitalWrite(LORA_KCT8103L_TX_RX, LOW);
 #endif
 }
 
@@ -281,11 +257,6 @@ void LoRaFEMInterface::setLNAEnable(bool enabled)
 
 int8_t LoRaFEMInterface::powerConversion(int8_t loraOutputPower)
 {
-#if defined(RF_PA_DETECT_PIN)
-    if (!high_power_pa) {
-        return loraOutputPower;
-    }
-#endif
 #ifdef HELTEC_V4
     const uint16_t gc1109_tx_gain[] = {11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 10, 10, 9, 9, 8, 7};
     const uint16_t kct8103l_tx_gain[] = {13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 13, 12, 12, 11, 11, 10, 9, 8, 7};

src/mesh/LoRaFEMInterface.h

@@ -24,8 +24,7 @@ class LoRaFEMInterface
     LoRaFEMType fem_type;
     bool lna_enabled = true;
     bool lna_can_control = false;
-    bool high_power_pa = true;
 };
 extern LoRaFEMInterface loraFEMInterface;
 
-#endif
+#endif

src/mesh/MeshRadio.h

@@ -65,14 +65,6 @@ struct RegionInfo {
     // Preset accessors (delegate through profile)
     meshtastic_Config_LoRaConfig_ModemPreset getDefaultPreset() const { return defaultPreset; }
     const meshtastic_Config_LoRaConfig_ModemPreset *getAvailablePresets() const { return profile->presets; }
-    bool supportsPreset(meshtastic_Config_LoRaConfig_ModemPreset preset) const
-    {
-        for (size_t i = 0; profile->presets[i] != MODEM_PRESET_END; i++) {
-            if (profile->presets[i] == preset)
-                return true;
-        }
-        return false;
-    }
     size_t getNumPresets() const
     {
         size_t n = 0;
@@ -88,11 +80,6 @@ extern const RegionInfo *myRegion;
 extern void initRegion();
 extern const RegionInfo *getRegion(meshtastic_Config_LoRaConfig_RegionCode code);
 
-// Fill `map` with the region->valid-preset table, grouped so regions sharing a
-// preset list reference the same group. Sent to clients during want_config so
-// their UI can block illegal region+preset combinations.
-extern void getRegionPresetMap(meshtastic_LoRaRegionPresetMap &map);
-
 // Valid LoRa spread factor range and defaults
 constexpr uint8_t LORA_SF_MIN = 5;
 constexpr uint8_t LORA_SF_MAX = 12;

src/mesh/MeshService.h

@@ -141,12 +141,6 @@ class MeshService
     /// Release the next ClientNotification packet to pool.
     void releaseClientNotificationToPool(meshtastic_ClientNotification *p) { clientNotificationPool.release(p); }
 
-    /// Bump fromNum to signal connected clients to poll for new FromRadio data.
-    /// Used by code paths (e.g. lockdown status queueing) that surface a new
-    /// FromRadio variant without going through one of the existing pool-backed
-    /// senders.
-    void nudgeFromNum() { fromNum++; }
-
     /**
      *  Given a ToRadio buffer parse it and properly handle it (setup radio, owner or send packet into the mesh)
      * Called by PhoneAPI.handleToRadio.  Note: p is a scratch buffer, this function is allowed to write to it but it can not keep

src/mesh/MeshTypes.h

@@ -45,11 +45,6 @@ enum RxSource {
 // For old firmware there is no relay node set
 #define NO_RELAY_NODE 0
 
-// How recently we must have heard a direct neighbor for its single-byte relay id to be trusted as a
-// unique next hop. Mirrors NUM_ONLINE_SECS (NodeDB.cpp). Used by NodeDB::resolveLastByte() to scope
-// last-byte collision resolution to currently-reachable neighbors.
-#define NEXTHOP_NEIGHBOR_FRESH_SECS (60 * 60 * 2) // 2 hrs
-
 typedef int ErrorCode;
 
 /// Alloc and free packets to our global, ISR safe pool

src/mesh/NextHopRouter.cpp

@@ -98,38 +98,21 @@ void NextHopRouter::sniffReceived(const meshtastic_MeshPacket *p, const meshtast
         // destination
         if (p->from != 0) {
             meshtastic_NodeInfoLite *origTx = nodeDB->getMeshNode(p->from);
-            // Either relayer of ACK was also a relayer of the packet, or we were the *only* relayer and the ACK came
-            // directly from the destination. checkRelayers is read-only on PacketHistory and O(1), so we run it even
-            // when origTx is absent — that lets us still capture the confirmed hop into the TMM overflow cache below.
-            // Single lookup for both relayer checks on the same (request_id, to) pair
-            bool wasAlreadyRelayer = false;
-            bool weWereSoleRelayer = false;
-            bool weWereRelayer = false;
-            checkRelayers(p->relay_node, ourRelayID, p->decoded.request_id, p->to, &wasAlreadyRelayer, &weWereRelayer,
-                          &weWereSoleRelayer);
-            if ((weWereRelayer && wasAlreadyRelayer) || (getHopsAway(*p) == 0 && weWereSoleRelayer)) {
-                // M1/M2: only learn a next hop whose last byte maps to a single plausible relay. On a dense
-                // mesh the byte may be ambiguous; storing it would aim future DMs at the wrong node. This gate
-                // now protects BOTH the hot-store route (NodeInfoLite.next_hop) AND the TMM overflow cache —
-                // the overflow cache deliberately holds many more next-hop bytes (long-tail nodes), so it is
-                // even more collision-prone and must never store an ambiguous byte either. Ambiguous/unknown
-                // -> store nothing and keep flooding (safe).
-                if (nodeDB->resolveUniqueLastByte(p->relay_node, /*requireDirectNeighbor=*/false)) {
-                    if (origTx && origTx->next_hop != p->relay_node) { // Not already set
+            if (origTx) {
+                // Either relayer of ACK was also a relayer of the packet, or we were the *only* relayer and the ACK came
+                // directly from the destination
+                // Single lookup for both relayer checks on the same (request_id, to) pair
+                bool wasAlreadyRelayer = false;
+                bool weWereSoleRelayer = false;
+                bool weWereRelayer = false;
+                checkRelayers(p->relay_node, ourRelayID, p->decoded.request_id, p->to, &wasAlreadyRelayer, &weWereRelayer,
+                              &weWereSoleRelayer);
+                if ((weWereRelayer && wasAlreadyRelayer) || (getHopsAway(*p) == 0 && weWereSoleRelayer)) {
+                    if (origTx->next_hop != p->relay_node) { // Not already set
                         LOG_INFO("Update next hop of 0x%x to 0x%x based on ACK/reply (was relayer %d we were sole %d)", p->from,
                                  p->relay_node, wasAlreadyRelayer, weWereSoleRelayer);
                         origTx->next_hop = p->relay_node;
                     }
-                    noteRouteLearned(p->from, p->relay_node, millis()); // M3: anchor freshness (hot or overflow route)
-#if HAS_TRAFFIC_MANAGEMENT
-                    // Mirror the confirmed (and now unique-resolved) hop into the TMM overflow cache so it
-                    // survives even when the source isn't (or is no longer) in the hot NodeDB.
-                    if (trafficManagementModule)
-                        trafficManagementModule->setNextHop(p->from, p->relay_node);
-#endif
-                } else {
-                    LOG_DEBUG("Not learning next hop for 0x%x: relay byte 0x%x ambiguous/unknown; keep flooding", p->from,
-                              p->relay_node);
                 }
             }
         }
@@ -161,11 +144,6 @@ bool NextHopRouter::perhapsRebroadcast(const meshtastic_MeshPacket *p)
     if (!isToUs(p) && !isFromUs(p) && (p->hop_limit > 0 || exhaustHops)) {
         if (p->id != 0) {
             if (isRebroadcaster()) {
-                // NOTE: this is a self-identity match (is the addressed next_hop OUR last byte?), so it
-                // cannot be hardened with resolveLastByte() — a remote node that legitimately shares our
-                // last byte will also match here and rebroadcast. That residual collision needs a wider
-                // on-wire field to fix. M1/M2 instead shrink the blast radius by reducing how often an
-                // ambiguous next_hop byte is ever learned (sniffReceived) or originated (getNextHop).
                 if (p->next_hop == NO_NEXT_HOP_PREFERENCE || p->next_hop == nodeDB->getLastByteOfNodeNum(getNodeNum())) {
                     meshtastic_MeshPacket *tosend = packetPool.allocCopy(*p); // keep a copy because we will be sending it
                     LOG_INFO("Rebroadcast received message coming from %x", p->relay_node);
@@ -216,63 +194,15 @@ std::optional<uint8_t> NextHopRouter::getNextHop(NodeNum to, uint8_t relay_node)
     if (isBroadcast(to))
         return std::nullopt;
 
-    // Hot store first: a direct array hit on the live NodeDB entry.
     meshtastic_NodeInfoLite *node = nodeDB->getMeshNode(to);
     if (node && node->next_hop) {
-        // M3: proactively decay a stale or repeatedly-failing route back to flooding, so a dead hop
-        // isn't trusted on the next DM's first (and on dense meshes, slowest) attempt. We only act on
-        // a health record that still matches the stored byte; a next_hop set by another path (e.g.
-        // TraceRouteModule) with no matching record is left authoritative.
-        const RouteHealth *h = findRouteHealth(to);
-        if (h && h->lastNextHop == node->next_hop && isRouteStale(*h, millis())) {
-            LOG_INFO("Next hop 0x%x for 0x%x is stale (age/fails); flood and clear", node->next_hop, to);
-            node->next_hop = NO_NEXT_HOP_PREFERENCE; // clear persisted route
-            clearRouteHealth(to);                    // clear RAM health
-            return std::nullopt;
-        }
-
         // We are careful not to return the relay node as the next hop
         if (node->next_hop != relay_node) {
-            // M1/M2: only emit a stored next_hop if its last byte still maps to a UNIQUE, currently
-            // reachable direct neighbor. On a dense mesh the last byte collides, so an ambiguous byte
-            // would unicast a hint toward the wrong physical node; if the neighbor has gone away we'd
-            // unicast into a void. In both cases flood instead (managed flooding still delivers).
-            ResolvedNode r = nodeDB->resolveLastByte(node->next_hop, /*requireDirectNeighbor=*/true);
-            if (r.status == LastByteResolution::Unique)
-                return node->next_hop;
-            LOG_WARN("Next hop 0x%x for 0x%x %s; set no pref", node->next_hop, to,
-                     r.status == LastByteResolution::Ambiguous ? "ambiguous among neighbors" : "not a known neighbor");
+            // LOG_DEBUG("Next hop for 0x%x is 0x%x", to, node->next_hop);
+            return node->next_hop;
         } else
             LOG_WARN("Next hop for 0x%x is 0x%x, same as relayer; set no pref", to, node->next_hop);
     }
-
-#if HAS_TRAFFIC_MANAGEMENT
-    // Fallback: TMM overflow cache holds confirmed hops for nodes that have aged out of the hot store.
-    // It is the same byte source/confidence as NodeInfoLite.next_hop, so it gets the same M1/M2/M3
-    // protection: decay a stale/failing route, then only emit a byte that still resolves to a unique
-    // reachable neighbor. Without this the overflow cache (which holds MORE bytes for MORE nodes) would
-    // reintroduce exactly the silent-misroute that M1/M2 closes on the hot path.
-    if (trafficManagementModule) {
-        uint8_t hint = trafficManagementModule->getNextHopHint(to);
-        if (hint && hint != relay_node) {
-            const RouteHealth *h = findRouteHealth(to);
-            if (h && h->lastNextHop == hint && isRouteStale(*h, millis())) {
-                LOG_INFO("TMM next hop 0x%x for 0x%x is stale (age/fails); flood and clear", hint, to);
-                trafficManagementModule->clearNextHop(to); // clear overflow route (setNextHop won't store 0)
-                clearRouteHealth(to);                      // clear RAM health
-                return std::nullopt;
-            }
-            ResolvedNode r = nodeDB->resolveLastByte(hint, /*requireDirectNeighbor=*/true);
-            if (r.status == LastByteResolution::Unique) {
-                LOG_DEBUG("Next hop for 0x%x is 0x%x (TMM cache)", to, hint);
-                return hint;
-            }
-            LOG_WARN("TMM next hop 0x%x for 0x%x %s; set no pref", hint, to,
-                     r.status == LastByteResolution::Ambiguous ? "ambiguous among neighbors" : "not a known neighbor");
-        }
-    }
-#endif
-
     return std::nullopt;
 }
 
@@ -381,10 +311,7 @@ int32_t NextHopRouter::doRetransmissions()
 
                 if (!isBroadcast(p.packet->to)) {
                     if (p.numRetransmissions == 1) {
-                        // Last retransmission: this directed delivery went un-ACKed. Record the failure
-                        // (M3 — accumulates across DMs to age out a flapping/dead route) and reset
-                        // next_hop so the final try falls back to FloodingRouter.
-                        noteRouteFailure(p.packet->to);
+                        // Last retransmission, reset next_hop (fallback to FloodingRouter)
                         p.packet->next_hop = NO_NEXT_HOP_PREFERENCE;
                         // Also reset it in the nodeDB
                         meshtastic_NodeInfoLite *sentTo = nodeDB->getMeshNode(p.packet->to);
@@ -392,32 +319,9 @@ int32_t NextHopRouter::doRetransmissions()
                             LOG_INFO("Resetting next hop for packet with dest 0x%x\n", p.packet->to);
                             sentTo->next_hop = NO_NEXT_HOP_PREFERENCE;
                         }
-#if HAS_TRAFFIC_MANAGEMENT
-                        if (trafficManagementModule) {
-                            trafficManagementModule->clearNextHop(p.packet->to);
-                        }
-#endif
                         FloodingRouter::send(packetPool.allocCopy(*p.packet));
                     } else {
-#if NEXTHOP_EARLY_FLOOD_ON_UNVERIFIED
-                        // M4 (gated): if the route isn't proven healthy, don't spend a second directed
-                        // attempt — start flooding one retry sooner to cut recovery latency. A verified
-                        // route (fresh, zero recent failures) keeps the unchanged directed-retry path so
-                        // the sparse-mesh happy path is untouched.
-                        RouteHealth *h = findRouteHealth(p.packet->to);
-                        bool verified = h && h->consecutiveFailures == 0 && !isRouteStale(*h, now);
-                        if (!verified) {
-                            p.packet->next_hop = NO_NEXT_HOP_PREFERENCE;
-                            meshtastic_NodeInfoLite *sentTo = nodeDB->getMeshNode(p.packet->to);
-                            if (sentTo)
-                                sentTo->next_hop = NO_NEXT_HOP_PREFERENCE;
-                            FloodingRouter::send(packetPool.allocCopy(*p.packet));
-                        } else {
-                            NextHopRouter::send(packetPool.allocCopy(*p.packet));
-                        }
-#else
                         NextHopRouter::send(packetPool.allocCopy(*p.packet));
-#endif
                     }
                 } else {
                     // Note: we call the superclass version because we don't want to have our version of send() add a new
@@ -451,96 +355,3 @@ void NextHopRouter::setNextTx(PendingPacket *pending)
     printPacket("", pending->packet);
     setReceivedMessage(); // Run ASAP, so we can figure out our correct sleep time
 }
-
-// ---------------------------------------------------------------------------
-// M3: RAM route-health table. Bounded array with reuse-oldest eviction (same discipline as
-// PacketHistory). All age comparisons use unsigned subtraction so they survive the 49.7-day millis()
-// rollover. dest == 0 marks an empty slot; learnedAtMsec is normalized to 1 on write so an occupied
-// slot is never read as infinitely old.
-// ---------------------------------------------------------------------------
-
-RouteHealth *NextHopRouter::findRouteHealth(NodeNum dest)
-{
-    if (dest == 0)
-        return nullptr;
-    for (auto &h : routeHealth)
-        if (h.dest == dest)
-            return &h;
-    return nullptr;
-}
-
-RouteHealth *NextHopRouter::getOrAllocRouteHealth(NodeNum dest, uint32_t now)
-{
-    if (dest == 0)
-        return nullptr;
-
-    RouteHealth *oldest = &routeHealth[0];
-    RouteHealth *freeSlot = nullptr;
-    for (auto &h : routeHealth) {
-        if (h.dest == dest)
-            return &h; // existing record
-        if (h.dest == 0) {
-            if (!freeSlot)
-                freeSlot = &h; // remember the first free slot; prefer it over evicting
-            continue;
-        }
-        // Track the oldest occupied slot in case the table is full (rollover-safe).
-        if ((uint32_t)(now - h.learnedAtMsec) > (uint32_t)(now - oldest->learnedAtMsec))
-            oldest = &h;
-    }
-    // Claim the free slot if there is one, else reuse the oldest. Reset before use and stamp the dest
-    // so the record is findable.
-    RouteHealth *slot = freeSlot ? freeSlot : oldest;
-    *slot = RouteHealth{};
-    slot->dest = dest;
-    return slot;
-}
-
-void NextHopRouter::noteRouteLearned(NodeNum dest, uint8_t nextHop, uint32_t now)
-{
-    if (dest == 0 || nextHop == NO_NEXT_HOP_PREFERENCE)
-        return;
-    RouteHealth *h = getOrAllocRouteHealth(dest, now);
-    if (!h)
-        return;
-    // A genuinely new next hop earns a clean slate; re-learning the SAME hop keeps the accumulated
-    // failure count so an asymmetric reverse path that keeps re-teaching a dead forward hop still ages
-    // out instead of resetting the counter every time.
-    if (h->lastNextHop != nextHop) {
-        h->lastNextHop = nextHop;
-        h->consecutiveFailures = 0;
-    }
-    h->learnedAtMsec = now ? now : 1;
-}
-
-void NextHopRouter::noteRouteSuccess(NodeNum dest, uint32_t now)
-{
-    RouteHealth *h = findRouteHealth(dest);
-    if (!h)
-        return; // only routes we actually learned have health to refresh
-    h->consecutiveFailures = 0;
-    h->learnedAtMsec = now ? now : 1;
-}
-
-void NextHopRouter::noteRouteFailure(NodeNum dest)
-{
-    RouteHealth *h = findRouteHealth(dest);
-    if (!h)
-        return; // nothing to penalize (we were flooding, or never learned a route here)
-    if (h->consecutiveFailures < 255)
-        h->consecutiveFailures++;
-}
-
-bool NextHopRouter::isRouteStale(const RouteHealth &h, uint32_t now) const
-{
-    if (h.consecutiveFailures >= ROUTE_FAILURE_THRESHOLD)
-        return true;
-    return (uint32_t)(now - h.learnedAtMsec) >= ROUTE_TTL_MSEC;
-}
-
-void NextHopRouter::clearRouteHealth(NodeNum dest)
-{
-    RouteHealth *h = findRouteHealth(dest);
-    if (h)
-        *h = RouteHealth{};
-}

src/mesh/NextHopRouter.h

@@ -43,28 +43,6 @@ struct PendingPacket {
     explicit PendingPacket(meshtastic_MeshPacket *p, uint8_t numRetransmissions);
 };
 
-/**
- * RAM-only per-destination route health. Tracks how fresh a learned next_hop is and how many
- * consecutive directed deliveries to it have failed, so getNextHop() can proactively decay a stale or
- * repeatedly-failing route back to flooding instead of trusting a dead hop on the next (and on dense
- * meshes, slowest) attempt. Not persisted: the learned next_hop itself lives in NodeInfoLite; this is
- * just freshness/failure metadata.
- */
-struct RouteHealth {
-    NodeNum dest = 0;                             ///< destination this record describes; 0 == empty slot
-    uint32_t learnedAtMsec = 0;                   ///< millis() when next_hop was last (re)learned (rollover-aware)
-    uint8_t consecutiveFailures = 0;              ///< directed deliveries to `dest` that went un-ACKed
-    uint8_t lastNextHop = NO_NEXT_HOP_PREFERENCE; ///< the relay byte this health refers to
-};
-
-// M4 (optional, off by default): when a route is not proven healthy, fall back to flooding one retry
-// earlier instead of spending a second directed attempt. Trades airtime for recovery latency on dense
-// meshes; leaves the sparse-mesh happy path (fresh, verified routes) unchanged. Measure on the
-// simulator before enabling broadly.
-#ifndef NEXTHOP_EARLY_FLOOD_ON_UNVERIFIED
-#define NEXTHOP_EARLY_FLOOD_ON_UNVERIFIED 0
-#endif
-
 class GlobalPacketIdHashFunction
 {
   public:
@@ -114,22 +92,12 @@ class NextHopRouter : public FloodingRouter
     // The number of retransmissions the original sender will do
     constexpr static uint8_t NUM_RELIABLE_RETX = 3;
 
-    // M3: bounded RAM route-health table (reuse-oldest eviction, like PacketHistory)
-    constexpr static uint8_t ROUTE_HEALTH_MAX = 32;              // ~12B/slot -> ~384B
-    constexpr static uint32_t ROUTE_TTL_MSEC = 30UL * 60 * 1000; // re-discover a route unconfirmed for 30 min
-    constexpr static uint8_t ROUTE_FAILURE_THRESHOLD = 3;        // consecutive un-ACKed directed deliveries -> dead
-
   protected:
     /**
      * Pending retransmissions
      */
     std::unordered_map<GlobalPacketId, PendingPacket, GlobalPacketIdHashFunction> pending;
 
-    /**
-     * Per-destination route health (M3). Bounded array, reuse-oldest eviction. RAM-only.
-     */
-    RouteHealth routeHealth[ROUTE_HEALTH_MAX] = {};
-
     /**
      * Should this incoming filter be dropped?
      *
@@ -174,38 +142,13 @@ class NextHopRouter : public FloodingRouter
 
     void setNextTx(PendingPacket *pending);
 
-    // --- M3 route-health helpers (RAM-only). Protected so ReliableRouter (a subclass) can record
-    // delivery success, and so the unit-test shim can reach them via `using`. All take `now` where
-    // time matters so the decay logic is pure and testable without a clock mock. ---
-
-    /// @return the health record for `dest`, or nullptr if we hold none.
-    RouteHealth *findRouteHealth(NodeNum dest);
-    /// @return an existing record for `dest`, else a freshly claimed slot (reuse-oldest on overflow).
-    RouteHealth *getOrAllocRouteHealth(NodeNum dest, uint32_t now);
-    /// Record that we (re)learned `nextHop` for `dest`. Resets the failure count only when the hop
-    /// changed (so a flapping reverse-path re-learn of the same dead hop still ages out).
-    void noteRouteLearned(NodeNum dest, uint8_t nextHop, uint32_t now);
-    /// Record an end-to-end delivery success to `dest` (clears failures, refreshes freshness).
-    void noteRouteSuccess(NodeNum dest, uint32_t now);
-    /// Record that a directed delivery to `dest` went un-ACKed (no-op if we hold no record).
-    void noteRouteFailure(NodeNum dest);
-    /// @return true if the route is too old (TTL) or has failed too many times in a row.
-    bool isRouteStale(const RouteHealth &h, uint32_t now) const;
-    /// Forget any health record for `dest`.
-    void clearRouteHealth(NodeNum dest);
-
-#ifdef PIO_UNIT_TESTING
-  public: // expose getNextHop to the test shim without widening production visibility
-#else
   private:
-#endif
     /**
      * Get the next hop for a destination, given the relay node
      * @return the node number of the next hop, 0 if no preference (fallback to FloodingRouter)
      */
     std::optional<uint8_t> getNextHop(NodeNum to, uint8_t relay_node);
 
-  private:
     /** Check if we should be rebroadcasting this packet if so, do so.
      *  @return true if we did rebroadcast */
     bool perhapsRebroadcast(const meshtastic_MeshPacket *p) override;

src/mesh/NodeDB.h

@@ -11,7 +11,6 @@
 
 #include "MeshTypes.h"
 #include "NodeStatus.h"
-#include "WarmNodeStore.h"
 #include "concurrency/Lock.h"
 #include "configuration.h"
 #include "mesh-pb-constants.h"
@@ -115,20 +114,6 @@ uint32_t sinceLastSeen(const meshtastic_NodeInfoLite *n);
 /// Given a packet, return how many seconds in the past (vs now) it was received
 uint32_t sinceReceived(const meshtastic_MeshPacket *p);
 
-/// Outcome of mapping a single on-wire last-byte (next_hop / relay_node) back to a full NodeNum.
-/// Because the wire only carries the last byte of a 32-bit node number, the mapping is ambiguous on
-/// dense meshes (the "birthday problem"). Callers must treat Ambiguous and None as "don't trust it".
-enum class LastByteResolution : uint8_t {
-    None,      ///< no relevant candidate node has this last byte
-    Unique,    ///< exactly one relevant candidate -> `num` is valid
-    Ambiguous, ///< two or more relevant candidates collide on this byte
-};
-
-struct ResolvedNode {
-    LastByteResolution status = LastByteResolution::None;
-    NodeNum num = 0; ///< valid only when status == Unique
-};
-
 /// Given a packet, return the number of hops used to reach this node.
 /// Returns defaultIfUnknown if the number of hops couldn't be determined.
 int8_t getHopsAway(const meshtastic_MeshPacket &p, int8_t defaultIfUnknown = -1);
@@ -241,25 +226,9 @@ class NodeDB
     bool updateUser(uint32_t nodeId, meshtastic_User &p, uint8_t channelIndex = 0);
 
     /*
-     * Sets a node either favorite or unfavorite. Returns true if the node ends
-     * up in the requested state; false if the node is unknown or favouriting
-     * was refused by the protected-node cap (MAX_NUM_NODES - 2).
+     * Sets a node either favorite or unfavorite
      */
-    bool set_favorite(bool is_favorite, uint32_t nodeId);
-
-    /// Count of eviction-protected (favourite/ignored/manually-verified) nodes.
-    int numProtectedNodes() const;
-
-    /// printf-style warning emitted when setProtectedFlag() refuses a node at
-    /// the cap. %s = verb (favorite/ignore), 0x%08x = node, %d = cap. Shared by
-    /// LOG_WARN here and AdminModule::sendWarning so the wording stays in sync.
-    static constexpr const char *PROTECTED_CAP_WARN_FMT = "Can't %s 0x%08x: protected-node limit (%d) reached";
-
-    /// Turn an eviction-protection flag (favourite/ignored/verified) on/off. Off
-    /// always succeeds; on returns false (no change) once the protected set hits
-    /// the cap (MAX_NUM_NODES-2), keeping >=2 always-evictable slots. Callers
-    /// surface the refusal to the user.
-    bool setProtectedFlag(meshtastic_NodeInfoLite *node, uint32_t mask, bool on);
+    void set_favorite(bool is_favorite, uint32_t nodeId);
 
     /*
      * Returns true if the node is in the NodeDB and marked as favorite
@@ -326,46 +295,6 @@ class NodeDB
 
     virtual meshtastic_NodeInfoLite *getMeshNode(NodeNum n);
     size_t getNumMeshNodes() { return numMeshNodes; }
-    /// Find a node in our DB, create an empty NodeInfoLite if missing (evicting
-    /// the oldest non-protected node when full). Public so admin handlers can
-    /// register a node we have not heard from yet (e.g. to block it by ID).
-    meshtastic_NodeInfoLite *getOrCreateMeshNode(NodeNum n);
-
-#if WARM_NODE_COUNT > 0
-    // Warm ("long-tail") tier: minimal {num, last_heard, public_key} records
-    // for nodes evicted from the hot store. See WarmNodeStore.h.
-    WarmNodeStore warmStore;
-#endif
-
-    /// Copy the 32-byte public key for node n — hot store first, then the warm
-    /// tier. Returns false if we don't know a key for n.
-    bool copyPublicKey(NodeNum n, meshtastic_NodeInfoLite_public_key_t &out);
-
-    /// Resolve a node's device role — hot store (with user) first, then the role
-    /// cached in the warm tier, else CLIENT. Lets role-aware policy keep firing for
-    /// nodes that have aged out of the hot store.
-    meshtastic_Config_DeviceConfig_Role getNodeRole(NodeNum n);
-
-    /// last_heard of a hot-store node, or 0 if absent. Plain scan of meshNodes
-    /// with no allocation side effects (unlike getOrCreateMeshNode).
-    uint32_t hotNodeLastHeard(NodeNum n) const;
-
-    /**
-     * Resolve a single on-wire last-byte (e.g. next_hop / relay_node) back to a unique full NodeNum,
-     * detecting last-byte collisions instead of silently picking the first match. A 1-byte id only
-     * needs to be unique among a node's plausible relays, not the whole mesh, so we scope the search:
-     *  - requireDirectNeighbor == true  : candidates are direct neighbors (hops_away==0) heard within
-     *                                     NEXTHOP_NEIGHBOR_FRESH_SECS. Use on the SEND path.
-     *  - requireDirectNeighbor == false : also accept favorites and router-role nodes (unknown hop
-     *                                     distance allowed). Use when learning / preserving hops.
-     * Ignored nodes, our own node, and the broadcast/0 sentinels are never candidates. On a tie the
-     * result is Ambiguous (no tie-break) so callers fall back to flooding rather than misroute.
-     */
-    ResolvedNode resolveLastByte(uint8_t lastByte, bool requireDirectNeighbor);
-
-    /// Convenience wrapper around resolveLastByte(): true iff exactly one relevant candidate matches.
-    /// Ambiguous and None both return false (the safe answer for learning / hop preservation).
-    bool resolveUniqueLastByte(uint8_t lastByte, bool requireDirectNeighbor, NodeNum *outNum = nullptr);
 
     // Thread-safe satellite-map accessors. Return false if absent or the
     // corresponding DB is compiled out.
@@ -412,15 +341,11 @@ class NodeDB
         emptyNodeDatabase.version = DEVICESTATE_CUR_VER;
         size_t nodeDatabaseSize;
         pb_get_encoded_size(&nodeDatabaseSize, meshtastic_NodeDatabase_fields, &emptyNodeDatabase);
-        // Decode-stream size ceiling only — no buffer this big is allocated (load
-        // streams from the file). Sized for the largest file any prior firmware
-        // could write (250-node ESP32-S3, satellites uncapped) so capacity
-        // downgrades / peer backups still decode; excess is trimmed after load.
-        // (not constexpr: portduino resolves MAX_NUM_NODES from runtime config)
-        const size_t loadCeiling = ((size_t)MAX_NUM_NODES > 250) ? (size_t)MAX_NUM_NODES : 250;
-        return nodeDatabaseSize + (loadCeiling * meshtastic_NodeInfoLite_size) +
-               (loadCeiling * meshtastic_NodePositionEntry_size) + (loadCeiling * meshtastic_NodeTelemetryEntry_size) +
-               (loadCeiling * meshtastic_NodeEnvironmentEntry_size) + (loadCeiling * meshtastic_NodeStatusEntry_size);
+        // Always include satellite slots so backups from higher-cap peers
+        // decode without truncation, even when our build excludes the DBs.
+        return nodeDatabaseSize + (MAX_NUM_NODES * meshtastic_NodeInfoLite_size) +
+               (MAX_NUM_NODES * meshtastic_NodePositionEntry_size) + (MAX_NUM_NODES * meshtastic_NodeTelemetryEntry_size) +
+               (MAX_NUM_NODES * meshtastic_NodeEnvironmentEntry_size) + (MAX_NUM_NODES * meshtastic_NodeStatusEntry_size);
     }
 
     // returns true if the maximum number of nodes is reached or we are running low on memory
@@ -451,12 +376,6 @@ class NodeDB
     bool checkLowEntropyPublicKey(const meshtastic_Config_SecurityConfig_public_key_t &keyToTest);
 #endif
 
-    /// Consolidate crypto key generation logic used across multiple modules
-    /// @param privateKey Optional 32-byte private key to use. If nullptr, generates new random keys.
-    bool generateCryptoKeyPair(const uint8_t *privateKey = nullptr);
-
-    bool createNewIdentity();
-
     bool backupPreferences(meshtastic_AdminMessage_BackupLocation location);
     bool restorePreferences(meshtastic_AdminMessage_BackupLocation location,
                             int restoreWhat = SEGMENT_CONFIG | SEGMENT_MODULECONFIG | SEGMENT_DEVICESTATE | SEGMENT_CHANNELS);
@@ -469,46 +388,15 @@ class NodeDB
         newStatus.notifyObservers(&status);
     }
 
-#ifdef MESHTASTIC_ENCRYPTED_STORAGE
-    /// Re-run loadFromDisk() after the encrypted storage is unlocked at runtime.
-    /// Trigger: PhoneAPI::handleLockdownAuthInline sets lockdownReloadPending
-    /// on a successful provisionPassphrase / unlockWithPassphrase; the main
-    /// loop in main.cpp services the flag and calls this method on the main
-    /// thread. The transport callback stack (BLE/USB) is too small for the
-    /// file IO + MAX_NUM_NODES vector reserve + proto decode this triggers.
-    ///
-    /// Returns true iff every encrypted file decrypted and decoded cleanly.
-    /// On false the caller MUST treat the storage as corrupt: leave the
-    /// connection unauthenticated, emit a LOCKED(storage_corrupt) status,
-    /// and refuse to call setAdminAuthorized — otherwise a subsequent
-    /// set_config would re-encrypt a wrong baseline (the locked-default
-    /// values still resident in `config` / `channelFile` / `nodeDatabase`)
-    /// and overwrite the operator's persisted state.
-    bool reloadFromDisk();
-
-    /// Disable lockdown: decrypt every encrypted pref file back to plaintext,
-    /// then remove the DEK / token / counter / backoff artifacts. Requires
-    /// EncryptedStorage to be unlocked (DEK in RAM). Returns false if any
-    /// file failed to revert — in which case the DEK is still present and the
-    /// device remains in lockdown so the operator can retry. APPROTECT is not
-    /// reversed. Called from the main loop via lockdownDisablePending.
-    bool disableLockdownToPlaintext();
-
-    /// Set by loadProto when any encrypted file fails to decrypt or decode.
-    /// Tracked across an entire loadFromDisk pass so reloadFromDisk can
-    /// surface the condition without callers re-walking each loadProto
-    /// result. Cleared at the top of every loadFromDisk run.
-    bool storageCorruptThisLoad = false;
-#endif
-
   private:
     mutable concurrency::Lock satelliteMutex;
     bool duplicateWarned = false;
     bool localPositionUpdatedSinceBoot = false;
-    bool migrationSavePending = false;
     uint32_t lastNodeDbSave = 0;    // when we last saved our db to flash
     uint32_t lastBackupAttempt = 0; // when we last tried a backup automatically or manually
     uint32_t lastSort = 0;          // When last sorted the nodeDB
+    /// Find a node in our DB, create an empty NodeInfoLite if missing
+    meshtastic_NodeInfoLite *getOrCreateMeshNode(NodeNum n);
 
     /*
      * Internal boolean to track sorting paused
@@ -521,33 +409,9 @@ class NodeDB
     /// read our db from flash
     void loadFromDisk();
 
-#ifdef PIO_UNIT_TESTING
-    // Grant the unit-test shim access to the private maintenance paths below
-    // (migration / cleanup / eviction) without relaxing production access.
-    friend class NodeDBTestShim;
-#endif
-
     /// purge db entries without user info
     void cleanupMeshDB();
 
-    /// Trim each satellite map down to MAX_SATELLITE_NODES, dropping the
-    /// stalest entries (used after loading files written before the cap, or by
-    /// a build with a larger cap). Returns true iff anything was trimmed.
-    bool enforceSatelliteCaps();
-
-    /// Node-DB self-care; call only once identity is established (getNodeNum()
-    /// valid). Confirms self is present, trims/demotes only NON-self overflow, and
-    /// rewrites the store once when something changed (never while storage locked).
-    void nodeDBSelfCare();
-
-#if WARM_NODE_COUNT > 0
-    /// A database from a larger-cap build (e.g. the pre-fork 150-node nRF52 store)
-    /// can exceed MAX_NUM_NODES on load. Rank the hot store, demote the oldest
-    /// overflow into the warm tier preserving {num, last_heard, public_key} so PKI
-    /// DMs survive instead of dropping on truncation.
-    void demoteOldestHotNodesToWarm();
-#endif
-
     /// Reinit device state from scratch (not loading from disk)
     void installDefaultDeviceState(), installDefaultNodeDatabase(), installDefaultChannels(),
         installDefaultConfig(bool preserveKey), installDefaultModuleConfig();
@@ -623,9 +487,7 @@ extern uint32_t error_address;
 #define NODEINFO_BITFIELD_IS_UNMESSAGABLE_MASK (1u << NODEINFO_BITFIELD_IS_UNMESSAGABLE_SHIFT)
 #define NODEINFO_BITFIELD_HAS_IS_UNMESSAGABLE_SHIFT 8
 #define NODEINFO_BITFIELD_HAS_IS_UNMESSAGABLE_MASK (1u << NODEINFO_BITFIELD_HAS_IS_UNMESSAGABLE_SHIFT)
-#define NODEINFO_BITFIELD_HAS_XEDDSA_SIGNED_SHIFT 9
-#define NODEINFO_BITFIELD_HAS_XEDDSA_SIGNED_MASK (1u << NODEINFO_BITFIELD_HAS_XEDDSA_SIGNED_SHIFT)
-// Bits 10..31 reserved for future single-bit flags.
+// Bits 9..31 reserved for future single-bit flags.
 
 // Convenience accessors so call sites read like the old struct fields.
 inline bool nodeInfoLiteHasUser(const meshtastic_NodeInfoLite *n)
@@ -664,16 +526,6 @@ inline bool nodeInfoLiteIsKeyManuallyVerified(const meshtastic_NodeInfoLite *n)
 {
     return n && (n->bitfield & NODEINFO_BITFIELD_IS_KEY_MANUALLY_VERIFIED_MASK);
 }
-inline bool nodeInfoLiteHasXeddsaSigned(const meshtastic_NodeInfoLite *n)
-{
-    return n && (n->bitfield & NODEINFO_BITFIELD_HAS_XEDDSA_SIGNED_MASK);
-}
-/// A node that the eviction/migration paths must not drop: a favourite, an
-/// ignored (blocked) node, or a manually-verified key.
-inline bool nodeInfoLiteIsProtected(const meshtastic_NodeInfoLite *n)
-{
-    return nodeInfoLiteIsFavorite(n) || nodeInfoLiteIsIgnored(n) || nodeInfoLiteIsKeyManuallyVerified(n);
-}
 
 inline void nodeInfoLiteSetBit(meshtastic_NodeInfoLite *n, uint32_t mask, bool value)
 {

src/mesh/NodeDBLegacyMigration.cpp

@@ -14,7 +14,6 @@
 #include "configuration.h"
 #include "mesh-pb-constants.h"
 #include "mesh/generated/meshtastic/deviceonly_legacy.pb.h"
-#include "meshUtils.h"
 
 #include <algorithm>
 #include <cstring>
@@ -89,10 +88,8 @@ bool NodeDB::migrateLegacyNodeDatabase()
                 slim.bitfield |= NODEINFO_BITFIELD_HAS_USER_MASK;
                 strncpy(slim.long_name, legacy.user.long_name, sizeof(slim.long_name));
                 slim.long_name[sizeof(slim.long_name) - 1] = '\0';
-                sanitizeUtf8(slim.long_name, sizeof(slim.long_name)); // replace bad bytes so nanopb encode never fails
                 strncpy(slim.short_name, legacy.user.short_name, sizeof(slim.short_name));
                 slim.short_name[sizeof(slim.short_name) - 1] = '\0';
-                sanitizeUtf8(slim.short_name, sizeof(slim.short_name)); // same — v24 names may contain non-UTF-8 bytes
                 slim.hw_model = legacy.user.hw_model;
                 slim.role = legacy.user.role;
                 if (legacy.user.is_licensed)

src/mesh/PacketHistory.cpp

@@ -486,11 +486,7 @@ bool PacketHistory::wasRelayer(const uint8_t relayer, const uint32_t id, const N
 }
 
 /* Check if a certain node was a relayer of a packet in the history given iterator
- * @return true if node was indeed a relayer, false if not
- * NOTE: intentionally byte-domain. Both `relayer` and relayed_by[] are on-wire last bytes, so this
- * answers "did a relayer with this byte touch the packet" — correct without resolving to a NodeNum.
- * The collision risk is neutralized where the result is consumed (route learning in
- * NextHopRouter::sniffReceived now gates the write through NodeDB::resolveUniqueLastByte). */
+ * @return true if node was indeed a relayer, false if not */
 bool PacketHistory::wasRelayer(const uint8_t relayer, const PacketRecord &r, bool *wasSole)
 {
     bool found = false;

src/mesh/PhoneAPI.h

@@ -4,7 +4,6 @@
 #include "concurrency/Lock.h"
 #include "mesh-pb-constants.h"
 #include "meshtastic/portnums.pb.h"
-#include <atomic>
 #include <cstdint>
 #include <deque>
 #include <iterator>
@@ -46,7 +45,6 @@ class PhoneAPI
         STATE_SEND_MY_INFO, // send our my info record
         STATE_SEND_OWN_NODEINFO,
         STATE_SEND_METADATA,
-        STATE_SEND_REGION_PRESETS,  // Send the region->valid-preset map (one message)
         STATE_SEND_CHANNELS,        // Send all channels
         STATE_SEND_CONFIG,          // Replacement for the old Radioconfig
         STATE_SEND_MODULECONFIG,    // Send Module specific config
@@ -172,49 +170,6 @@ class PhoneAPI
     bool isConnected() { return state != STATE_SEND_NOTHING; }
     bool isSendingPackets() { return state == STATE_SEND_PACKETS; }
 
-#ifdef MESHTASTIC_PHONEAPI_ACCESS_CONTROL
-    /// Per-connection auth: tracked in a small file-scope slot table keyed
-    /// by PhoneAPI*. Adding state members directly to PhoneAPI broke
-    /// USB-CDC enumeration on current nRF52 framework — even one extra
-    /// per-instance uint32_t was enough. Keeping all state out-of-line
-    /// avoids the issue.
-    void setAdminAuthorized(bool authorized);
-    bool getAdminAuthorized() const;
-
-    /// Lock Now: O(1) invalidation of every connection's auth by advancing
-    /// the global epoch. Subsequent gate checks see slot.myEpoch != epoch
-    /// and treat the connection as unauthenticated.
-    static void revokeAllAuth();
-
-    /// Called from the main loop after NodeDB::reloadFromDisk() finishes.
-    /// On reloadOk=true: any connection marked pending-unlock-after-reload
-    /// is promoted to authorized and receives an UNLOCKED status; the
-    /// screen-lock latch clears. On reloadOk=false: those connections
-    /// receive a LOCKED(storage_corrupt) status and remain unauthorized
-    /// so they cannot drive set_config against the corrupt baseline.
-    static void completePendingUnlocks(bool reloadOk);
-
-    /// Queue a LockdownStatus FromRadio for THIS connection only. Each
-    /// PhoneAPI owns its own pending-status slot in a file-scope table
-    /// (file-scope because adding fields directly to PhoneAPI broke
-    /// USB-CDC enumeration on nRF52); a status produced here will not
-    /// be delivered to any other connection. `lock_reason` may be
-    /// nullptr / empty for non-LOCKED states.
-    void queueLockdownStatus(meshtastic_LockdownStatus_State state, const char *lock_reason, uint8_t boots_remaining,
-                             uint32_t valid_until_epoch, uint32_t backoff_seconds);
-
-    /// Queue the same LockdownStatus on every active connection's slot.
-    /// Use for events with no specific originating connection (session
-    /// expiry tick in main.cpp, broadcast revocations, etc.). Per-
-    /// connection callers should prefer the instance method above to
-    /// avoid leaking one client's auth state to another.
-    static void broadcastLockdownStatus(meshtastic_LockdownStatus_State state, const char *lock_reason, uint8_t boots_remaining,
-                                        uint32_t valid_until_epoch, uint32_t backoff_seconds);
-
-    /// True iff this connection has a pending lockdown_status drain.
-    bool hasPendingLockdownStatus() const;
-#endif
-
   protected:
     /// Our fromradio packet while it is being assembled
     meshtastic_FromRadio fromRadioScratch = {};
@@ -256,20 +211,6 @@ class PhoneAPI
 
     APIType api_type = TYPE_NONE;
 
-#ifdef MESHTASTIC_PHONEAPI_ACCESS_CONTROL
-    // No per-instance auth members — see method-level note. All state lives
-    // in a file-scope slot table in PhoneAPI.cpp keyed by `this` pointer.
-
-    // Pending LockdownStatus storage is NOT a class member — having a
-    // meshtastic_LockdownStatus (~50 bytes with the char[33] lock_reason)
-    // as a PhoneAPI member broke USB-CDC enumeration on the nRF52 Adafruit
-    // framework. The exact mechanism wasn't pinned down, but moving the
-    // storage to a file-scope static in PhoneAPI.cpp side-steps it cleanly.
-    // Trade-off: all PhoneAPI instances share one pending slot. Acceptable
-    // because only one transport delivers a lockdown command at a time in
-    // any realistic scenario.
-#endif
-
   private:
     void releasePhonePacket();
 
@@ -307,16 +248,6 @@ class PhoneAPI
      */
     bool handleToRadioPacket(meshtastic_MeshPacket &p);
 
-#if defined(MESHTASTIC_ENCRYPTED_STORAGE) && defined(MESHTASTIC_PHONEAPI_ACCESS_CONTROL)
-    /// Synchronously handle a lockdown_auth AdminMessage from the local
-    /// client. Runs inside handleToRadioPacket so the originating
-    /// connection is reachable via `this` — avoids the async context
-    /// loss that broke the previous AdminModule path. Always consumes the
-    /// packet (returns true): lockdown_auth is local-only and must not be
-    /// forwarded to the mesh router.
-    bool handleLockdownAuthInline(const meshtastic_LockdownAuth &la);
-#endif
-
     /// If the mesh service tells us fromNum has changed, tell the phone
     virtual int onNotify(uint32_t newValue) override;
 };

src/mesh/PositionPrecision.cpp

@@ -16,23 +16,11 @@ uint32_t getPositionPrecisionForChannel(const meshtastic_Channel &channel)
 
 uint32_t getPositionPrecisionForChannel(uint8_t channelIndex)
 {
-    const meshtastic_Channel &ch = channels.getByIndex(channelIndex);
-    if (ch.role == meshtastic_Channel_Role_DISABLED)
-        return 0;
-    uint32_t precision = getPositionPrecisionForChannel(ch);
-
-    // Never send a precise position on a publicly-decryptable channel (key check is gated on > ceiling).
-    if (precision > MAX_POSITION_PRECISION_PUBLIC_KEY && channels.usesPublicKey(channelIndex)) {
-        precision = MAX_POSITION_PRECISION_PUBLIC_KEY;
-    }
-    return precision;
+    return getPositionPrecisionForChannel(channels.getByIndex(channelIndex));
 }
 
-int32_t truncateCoordinate(int32_t coordinate, uint32_t precision)
+static int32_t truncateCoordinate(int32_t coordinate, uint32_t precision)
 {
-    if (precision == 0 || precision >= 32)
-        return coordinate;
-
     uint32_t coordinateBits = static_cast<uint32_t>(coordinate);
     uint32_t truncated = coordinateBits & (UINT32_MAX << (32 - precision));
 
@@ -42,11 +30,6 @@ int32_t truncateCoordinate(int32_t coordinate, uint32_t precision)
     return static_cast<int32_t>(truncated);
 }
 
-int32_t truncateCoordinate(int32_t coordinate, uint8_t precision)
-{
-    return truncateCoordinate(coordinate, static_cast<uint32_t>(precision));
-}
-
 void applyPositionPrecision(meshtastic_Position &position, uint32_t precision)
 {
     if (precision == 0) {

src/mesh/PositionPrecision.h

@@ -4,23 +4,8 @@
 #include "meshtastic/mesh.pb.h"
 #include <stdint.h>
 
-// Max precision on a publicly-decryptable channel. CCPA "precise geolocation" = within a ~564m (1,850ft) radius.
-// Precision is bit-truncation of latitude_i/longitude_i: the latitude cell stays ~constant in meters worldwide
-// (~700m at 15 bits), while only the longitude cell varies — widest at the equator, narrowing toward the poles.
-// 15 also matches the MQTT map-report public precision ceiling.
-#define MAX_POSITION_PRECISION_PUBLIC_KEY 15
-
-// Configured precision as-is; does NOT apply the public-key clamp -- use the channelIndex overload for the on-wire value.
 uint32_t getPositionPrecisionForChannel(const meshtastic_Channel &channel);
-
-// Configured precision, clamped to MAX_POSITION_PRECISION_PUBLIC_KEY when the channel's effective key is publicly decryptable.
 uint32_t getPositionPrecisionForChannel(uint8_t channelIndex);
-
-// Truncate a single latitude_i/longitude_i to `precision` significant bits, centered in the
-// resulting grid cell (stable under GPS jitter). precision 0 or >=32 returns the value unchanged.
-// The return is the coordinate (int32_t); the uint8_t overload only narrows the precision arg.
-int32_t truncateCoordinate(int32_t coordinate, uint32_t precision);
-int32_t truncateCoordinate(int32_t coordinate, uint8_t precision);
 void applyPositionPrecision(meshtastic_Position &position, uint32_t precision);
 bool applyPositionPrecision(meshtastic_MeshPacket &packet, uint32_t precision);
 bool applyPositionPrecisionForChannel(meshtastic_MeshPacket &packet, uint8_t channelIndex);

src/mesh/RadioInterface.cpp

@@ -63,8 +63,6 @@ const RegionProfile PROFILE_HAM_20KHZ = {PRESETS_TINY, 0, 0.0022f, false, true,
 // Ham '100kHz' profile. 62.5kHz bandwidth coerced to 100kHz via padding.
 const RegionProfile PROFILE_HAM_100KHZ = {PRESETS_NARROW, 0, 0.01875f, false, true, 0, 1, 1};
 
-Observable<uint32_t> RadioInterface::loraRxPacketObservable;
-
 #define RDEF(name, freq_start, freq_end, duty_cycle, power_limit, frequency_switching, wide_lora, profile_ptr, default_preset,   \
              override_slot)                                                                                                      \
     {                                                                                                                            \
@@ -87,30 +85,20 @@ const RegionInfo regions[] = {
      */
     RDEF(EU_433, 433.0f, 434.0f, 10, 10, false, false, PROFILE_STD, PRESET(LONG_FAST), 0),
     /*
-        https://www.thethingsnetwork.org/docs/lorawan/duty-cycle/
-        https://www.thethingsnetwork.org/docs/lorawan/regional-parameters/
-        https://www.legislation.gov.uk/uksi/1999/930/schedule/6/part/III/made/data.xht?view=snippet&wrap=true
+       https://www.thethingsnetwork.org/docs/lorawan/duty-cycle/
+       https://www.thethingsnetwork.org/docs/lorawan/regional-parameters/
+       https://www.legislation.gov.uk/uksi/1999/930/schedule/6/part/III/made/data.xht?view=snippet&wrap=true
 
-        audio_permitted = false per regulation
+       audio_permitted = false per regulation
 
-        Special Note:
-        The link above describes LoRaWAN's band plan, stating a power limit of 16 dBm. This is their own suggested specification,
-        we do not need to follow it. The European Union regulations clearly state that the power limit for this frequency range is
-        500 mW, or 27 dBm. It also states that we can use interference avoidance and spectrum access techniques (such as LBT +
-        AFA) to avoid a duty cycle. (Please refer to line P page 22 of this document.)
-        https://www.etsi.org/deliver/etsi_en/300200_300299/30022002/03.01.01_60/en_30022002v030101p.pdf
-
-        EU 866MHz band (Band no. 46b of 2006/771/EC and subsequent amendments) for Non-specific short-range devices (SRD)
-        Gives 4 channels at 865.7/866.3/866.9/867.5 MHz, 400 kHz gap plus 37.5 kHz padding between channels, 27 dBm,
-        duty cycle 2.5% (mobile) or 10% (fixed) https://eur-lex.europa.eu/legal-content/EN/TXT/?uri=CELEX:02006D0771(01)-20250123
-
-        EU 868MHz band: 3 channels at 869.410/869.4625/869.577 MHz
-        Channel centres at 869.442/869.525/869.608 MHz,
-        10.4 kHz padding on channels, 27 dBm, duty cycle 10%
-    */
+       Special Note:
+       The link above describes LoRaWAN's band plan, stating a power limit of 16 dBm. This is their own suggested specification,
+       we do not need to follow it. The European Union regulations clearly state that the power limit for this frequency range is
+       500 mW, or 27 dBm. It also states that we can use interference avoidance and spectrum access techniques (such as LBT +
+       AFA) to avoid a duty cycle. (Please refer to line P page 22 of this document.)
+       https://www.etsi.org/deliver/etsi_en/300200_300299/30022002/03.01.01_60/en_30022002v030101p.pdf
+     */
     RDEF(EU_868, 869.4f, 869.65f, 10, 27, false, false, PROFILE_EU868, PRESET(LONG_FAST), 0),
-    RDEF(EU_866, 865.6f, 867.6f, 2.5, 27, false, false, PROFILE_LITE, PRESET(LITE_FAST), 0),
-    RDEF(EU_N_868, 869.4f, 869.65f, 10, 27, false, false, PROFILE_NARROW, PRESET(NARROW_SLOW), 1),
 
     /*
         https://lora-alliance.org/wp-content/uploads/2020/11/lorawan_regional_parameters_v1.0.3reva_0.pdf
@@ -288,6 +276,20 @@ const RegionInfo regions[] = {
     */
     RDEF(LORA_24, 2400.0f, 2483.5f, 100, 10, false, true, PROFILE_STD, PRESET(LONG_FAST), 0),
 
+    /*
+        EU 866MHz band (Band no. 46b of 2006/771/EC and subsequent amendments) for Non-specific short-range devices (SRD)
+        Gives 4 channels at 865.7/866.3/866.9/867.5 MHz, 400 kHz gap plus 37.5 kHz padding between channels, 27 dBm,
+        duty cycle 2.5% (mobile) or 10% (fixed) https://eur-lex.europa.eu/legal-content/EN/TXT/?uri=CELEX:02006D0771(01)-20250123
+    */
+    RDEF(EU_866, 865.6f, 867.6f, 2.5, 27, false, false, PROFILE_LITE, PRESET(LITE_FAST), 0),
+
+    /*
+        EU 868MHz band: 3 channels at 869.410/869.4625/869.577 MHz
+        Channel centres at 869.442/869.525/869.608 MHz,
+        10.4 kHz padding on channels, 27 dBm, duty cycle 10%
+    */
+    RDEF(EU_N_868, 869.4f, 869.65f, 10, 27, false, false, PROFILE_NARROW, PRESET(NARROW_SLOW), 1),
+
     /*
         This needs to be last. Same as US.
     */
@@ -605,62 +607,6 @@ const RegionInfo *getRegion(meshtastic_Config_LoRaConfig_RegionCode code)
     return r;
 }
 
-void getRegionPresetMap(meshtastic_LoRaRegionPresetMap &map)
-{
-    map = meshtastic_LoRaRegionPresetMap_init_zero;
-
-    const size_t maxGroups = sizeof(map.groups) / sizeof(map.groups[0]);
-    const size_t maxRegions = sizeof(map.region_groups) / sizeof(map.region_groups[0]);
-    const size_t maxPresets = sizeof(map.groups[0].presets) / sizeof(map.groups[0].presets[0]);
-
-    // Coalesce regions that share an identical preset list into one group. Two
-    // regions belong to the same group when they share the same RegionProfile
-    // (which owns the preset list + licensing) AND the same default preset.
-    // Keyed by profile pointer, not the preset-array pointer: PROFILE_NARROW and
-    // PROFILE_HAM_100KHZ share PRESETS_NARROW but differ in licensedOnly.
-    const RegionProfile *groupProfile[sizeof(map.groups) / sizeof(map.groups[0])] = {};
-
-    for (const RegionInfo *r = regions; r->code != meshtastic_Config_LoRaConfig_RegionCode_UNSET; r++) {
-        // No room left to map any further region; once full we can't add more, so
-        // log once and stop. An incomplete map means clients won't constrain the
-        // omitted regions, so this must be discoverable rather than silent.
-        if (map.region_groups_count >= maxRegions) {
-            LOG_ERROR("Region preset map full at %u regions; remaining regions omitted", (unsigned)maxRegions);
-            break;
-        }
-
-        // Find the group this region belongs to, or create it.
-        int gi = -1;
-        for (pb_size_t g = 0; g < map.groups_count; g++) {
-            if (groupProfile[g] == r->profile && map.groups[g].default_preset == r->getDefaultPreset()) {
-                gi = g;
-                break;
-            }
-        }
-        if (gi < 0) {
-            if (map.groups_count >= maxGroups) {
-                // Out of group slots (should not happen for the current table). The
-                // region can't be advertised; skip it but make the gap visible.
-                LOG_ERROR("Region preset map out of group slots (%u); region %d omitted", (unsigned)maxGroups, r->code);
-                continue;
-            }
-            gi = map.groups_count++;
-            groupProfile[gi] = r->profile;
-            meshtastic_LoRaPresetGroup &grp = map.groups[gi];
-            grp.default_preset = r->getDefaultPreset();
-            grp.licensed_only = r->profile->licensedOnly;
-            grp.presets_count = 0;
-            for (size_t i = 0; r->profile->presets[i] != MODEM_PRESET_END && grp.presets_count < maxPresets; i++)
-                grp.presets[grp.presets_count++] = r->profile->presets[i];
-        }
-
-        // Map this region to its group (capacity checked at the top of the loop).
-        meshtastic_LoRaRegionPresets &rg = map.region_groups[map.region_groups_count++];
-        rg.region = r->code;
-        rg.group_index = (uint8_t)gi;
-    }
-}
-
 /**
  * Get duty cycle for current region. EU_866: 10% for routers, 2.5% for mobile.
  */
@@ -911,116 +857,53 @@ uint32_t RadioInterface::getChannelNum()
 }
 
 /**
- * Send a client notification (error level unless specified). Safe to call when service is null (e.g. in tests).
+ * Send an error-level client notification. Safe to call when service is null (e.g. in tests).
  */
-static void sendErrorNotification(const char *msg, meshtastic_LogRecord_Level level = meshtastic_LogRecord_Level_ERROR)
+static void sendErrorNotification(const char *msg)
 {
     if (!service)
         return;
     meshtastic_ClientNotification *cn = clientNotificationPool.allocZeroed();
     if (!cn)
         return;
-    cn->level = level;
+    cn->level = meshtastic_LogRecord_Level_ERROR;
     snprintf(cn->message, sizeof(cn->message), "%s", msg);
     service->sendClientNotification(cn);
 }
 
-// The EU_868/EU_866/EU_N_868 trio own mutually exclusive preset lists. Selecting a preset
-// locked to a sibling means the user wants that sibling region, not the default preset.
-static const meshtastic_Config_LoRaConfig_RegionCode SWAPPABLE_EU_REGIONS[] = {
-    meshtastic_Config_LoRaConfig_RegionCode_EU_868,
-    meshtastic_Config_LoRaConfig_RegionCode_EU_866,
-    meshtastic_Config_LoRaConfig_RegionCode_EU_N_868,
-};
-
 /**
- * If currentRegion is one of the swappable EU regions and preset belongs to a sibling in
- * that trio, return the sibling region that owns the preset. Returns nullptr otherwise.
- */
-const RegionInfo *RadioInterface::regionSwapForPreset(meshtastic_Config_LoRaConfig_RegionCode currentRegion,
-                                                      meshtastic_Config_LoRaConfig_ModemPreset preset)
-{
-    bool currentIsSwappable = false;
-    for (auto code : SWAPPABLE_EU_REGIONS) {
-        if (code == currentRegion)
-            currentIsSwappable = true;
-    }
-    if (!currentIsSwappable)
-        return nullptr;
-
-    for (auto code : SWAPPABLE_EU_REGIONS) {
-        if (code == currentRegion)
-            continue;
-        const RegionInfo *sibling = getRegion(code);
-        if (sibling->supportsPreset(preset))
-            return sibling;
-    }
-    return nullptr;
-}
-
-/**
- * Checks if a region is valid for the current settings, with no side effects.
- * Safe to call speculatively (e.g. from UI pickers). When errBuf is given, it
- * receives the human-readable failure reason.
+ * Checks if a region is valid for the current settings.
  * Returns false if not compatible.
  */
-bool RadioInterface::checkConfigRegion(const meshtastic_Config_LoRaConfig &loraConfig, char *errBuf, size_t errLen)
+bool RadioInterface::validateConfigRegion(const meshtastic_Config_LoRaConfig &loraConfig)
 {
     const RegionInfo *newRegion = getRegion(loraConfig.region);
 
     // Reject unrecognized region codes (getRegion returns UNSET sentinel for unknown codes)
     if (newRegion->code != loraConfig.region) {
-        if (errBuf)
-            snprintf(errBuf, errLen, "Region code %d is not recognized", loraConfig.region);
+        char err_string[160];
+        snprintf(err_string, sizeof(err_string), "Region code %d is not recognized", loraConfig.region);
+        LOG_ERROR("%s", err_string);
+        RECORD_CRITICALERROR(meshtastic_CriticalErrorCode_INVALID_RADIO_SETTING);
+        sendErrorNotification(err_string);
         return false;
     }
 
     // If you are not licensed, you can't use ham regions.
     if (newRegion->profile->licensedOnly && !devicestate.owner.is_licensed) {
-        if (errBuf)
-            snprintf(errBuf, errLen, "Region %s requires licensed mode", newRegion->name);
+        char err_string[160];
+        snprintf(err_string, sizeof(err_string), "Region %s requires licensed mode", newRegion->name);
+        LOG_ERROR("%s", err_string);
+        RECORD_CRITICALERROR(meshtastic_CriticalErrorCode_INVALID_RADIO_SETTING);
+        sendErrorNotification(err_string);
         return false;
     }
 
-    // Hardware compatibility: wide-LoRa (2.4 GHz) regions need a wide-capable radio, and
-    // sub-GHz regions need a radio that can tune below 2.4 GHz (SX128x cannot). UNSET is
-    // always allowed since it is the "no region" state.
-    if (newRegion->code != meshtastic_Config_LoRaConfig_RegionCode_UNSET && RadioLibInterface::instance) {
-        const char *unsupported = nullptr;
-        if (newRegion->wideLora && !RadioLibInterface::instance->wideLora()) {
-            unsupported = "2.4 GHz";
-        } else if (!newRegion->wideLora && !RadioLibInterface::instance->supportsSubGhz()) {
-            unsupported = "sub-GHz";
-        }
-        if (unsupported) {
-            if (errBuf)
-                snprintf(errBuf, errLen, "Region %s needs %s, which this radio does not support", newRegion->name, unsupported);
-            return false;
-        }
-    }
-
     return true;
 }
 
 /**
- * Checks if a region is valid for the current settings. On failure, logs at ERROR,
- * records a critical error, and sends a client notification.
- * Returns false if not compatible.
- */
-bool RadioInterface::validateConfigRegion(const meshtastic_Config_LoRaConfig &loraConfig)
-{
-    char err_string[160];
-    if (checkConfigRegion(loraConfig, err_string, sizeof(err_string)))
-        return true;
-
-    LOG_ERROR("%s", err_string);
-    RECORD_CRITICALERROR(meshtastic_CriticalErrorCode_INVALID_RADIO_SETTING);
-    sendErrorNotification(err_string);
-    return false;
-}
-
-/**
- * Internal helper: check or clamp a LoRa config against its region.
+ * Internal helper: validate or clamp a LoRa config against its region.
  * When clamp==false, returns false on first error (pure validation).
  * When clamp==true, fixes invalid settings in-place and returns true.
  */
@@ -1037,29 +920,11 @@ bool RadioInterface::checkOrClampConfigLora(meshtastic_Config_LoRaConfig &loraCo
     if (loraConfig.use_preset) {
         check_bw = modemPresetToBwKHz(loraConfig.modem_preset, newRegion->wideLora);
 
-        bool preset_valid = newRegion->supportsPreset(loraConfig.modem_preset);
-        if (!preset_valid) {
-            // A preset locked to a sibling of the swappable EU regions swaps the region instead
-            // of clamping the preset, as long as the previous region was itself one of the trio.
-            const RegionInfo *swapRegion = regionSwapForPreset(loraConfig.region, loraConfig.modem_preset);
-            if (swapRegion) {
-                if (!clamp) {
-                    // Validation must still fail so callers route into the clamp, but quietly:
-                    // the clamp will accept this config by swapping regions, so don't record a
-                    // critical error or alarm the user over a change that is about to succeed.
-                    LOG_INFO("Preset %s implies region swap %s to %s, deferring to clamp", presetName, newRegion->name,
-                             swapRegion->name);
-                    return false;
-                }
-                snprintf(err_string, sizeof(err_string), "Preset %s swaps region %s to %s", presetName, newRegion->name,
-                         swapRegion->name);
-                LOG_INFO("%s", err_string);
-                sendErrorNotification(err_string, meshtastic_LogRecord_Level_INFO);
-
-                loraConfig.region = swapRegion->code;
-                newRegion = swapRegion;
-                check_bw = modemPresetToBwKHz(loraConfig.modem_preset, newRegion->wideLora);
+        bool preset_valid = false;
+        for (size_t i = 0; i < newRegion->getNumPresets(); i++) {
+            if (loraConfig.modem_preset == newRegion->getAvailablePresets()[i]) {
                 preset_valid = true;
+                break;
             }
         }
         if (!preset_valid) {
@@ -1423,4 +1288,4 @@ size_t RadioInterface::beginSending(meshtastic_MeshPacket *p)
 
     sendingPacket = p;
     return p->encrypted.size + sizeof(PacketHeader);
-}
+}

src/mesh/RadioInterface.h

@@ -128,9 +128,6 @@ class RadioInterface
 
     virtual ~RadioInterface() {}
 
-    /// Fires once per valid received LoRa packet (arg = sender NodeNum). Used e.g. to flash LED_LORA.
-    static Observable<uint32_t> loraRxPacketObservable;
-
     /**
      * Coerce LoRa config fields (bandwidth/spread_factor) derived from presets.
      * This is used during early bootstrapping so UIs that display these fields directly remain consistent.
@@ -146,10 +143,6 @@ class RadioInterface
 
     virtual bool wideLora() { return false; }
 
-    /// Whether the radio can tune sub-GHz bands. False for 2.4 GHz-only chips (SX128x);
-    /// multiband chips like the LR1121 keep the default.
-    virtual bool supportsSubGhz() { return true; }
-
     /// Prepare hardware for sleep.  Call this _only_ for deep sleep, not needed for light sleep.
     virtual bool sleep() { return true; }
 
@@ -251,12 +244,7 @@ class RadioInterface
 
     static bool checkOrClampConfigLora(meshtastic_Config_LoRaConfig &loraConfig, bool clamp);
 
-    // Check if a candidate region is compatible and valid, with no side effects (safe for
-    // speculative UI checks). errBuf, if given, receives the failure reason.
-    static bool checkConfigRegion(const meshtastic_Config_LoRaConfig &loraConfig, char *errBuf = nullptr, size_t errLen = 0);
-
-    // Check if a candidate region is compatible and valid. On failure, logs at ERROR,
-    // records a critical error, and sends a client notification.
+    // Check if a candidate region is compatible and valid.
     static bool validateConfigRegion(const meshtastic_Config_LoRaConfig &loraConfig);
 
     // Check if a candidate radio configuration is valid.
@@ -265,11 +253,6 @@ class RadioInterface
     // Make a candidate radio configuration valid, even if it isn't.
     static void clampConfigLora(meshtastic_Config_LoRaConfig &loraConfig);
 
-    // If preset is locked to a sibling of currentRegion among the swappable EU regions
-    // (EU_868/EU_866/EU_N_868), return the sibling region owning the preset, else nullptr.
-    static const RegionInfo *regionSwapForPreset(meshtastic_Config_LoRaConfig_RegionCode currentRegion,
-                                                 meshtastic_Config_LoRaConfig_ModemPreset preset);
-
   protected:
     int8_t power = 17; // Set by applyModemConfig()
 

src/mesh/RadioLibInterface.cpp

@@ -614,10 +614,6 @@ void RadioLibInterface::handleReceiveInterrupt()
 
             printPacket("Lora RX", mp);
 
-#ifdef LED_LORA
-            loraRxPacketObservable.notifyObservers(mp->from);
-#endif
-
             airTime->logAirtime(RX_LOG, rxMsec);
 
             deliverToReceiver(mp);