GPS 115200 baud

.claude/settings.json

@@ -1,17 +0,0 @@
-{
-  "hooks": {
-    "PostToolUse": [
-      {
-        "matcher": "Write|Edit",
-        "hooks": [
-          {
-            "type": "command",
-            "command": "f=$(tr -d '\\n' | grep -o '\"file_path\"[[:space:]]*:[[:space:]]*\"[^\"]*\"' | head -1 | sed 's/.*:[[:space:]]*\"//; s/\"$//'); [ -n \"$f\" ] && [ -f \"$f\" ] || exit 0; t=$(command -v trunk || echo \"$HOME/.cache/trunk/launcher/trunk\"); [ -x \"$t\" ] || { echo \"trunk-fmt hook: trunk not found; its launcher needs curl or wget to bootstrap the CLI (see 'Formatting & the trunk toolchain' in .github/copilot-instructions.md)\" >&2; exit 1; }; out=$(\"$t\" fmt --force \"$f\" 2>&1) || { echo \"trunk-fmt hook: trunk fmt failed on $f: $out\" >&2; exit 1; }",
-            "timeout": 120,
-            "statusMessage": "Formatting (trunk)..."
-          }
-        ]
-      }
-    ]
-  }
-}

.clusterfuzzlite/Dockerfile

@@ -18,7 +18,7 @@ ENV PIP_ROOT_USER_ACTION=ignore
 # trunk-ignore(hadolint/DL3008): apt packages are not pinned.
 # trunk-ignore(terrascan/AC_DOCKER_0002): apt packages are not pinned.
 RUN apt-get update && apt-get install --no-install-recommends -y \
-        cmake git zip libgpiod-dev libjsoncpp-dev libbluetooth-dev libi2c-dev \
+        cmake git zip libgpiod-dev libbluetooth-dev libi2c-dev \
         libunistring-dev libmicrohttpd-dev libgnutls28-dev libgcrypt20-dev \
         libusb-1.0-0-dev libssl-dev pkg-config libsqlite3-dev libsdl2-dev && \
     apt-get clean && rm -rf /var/lib/apt/lists/* && \

.clusterfuzzlite/build.sh

@@ -31,7 +31,7 @@ cmake --install "$WORK/ulfius/$SANITIZER" --prefix /usr
 cd "$SRC/firmware"
 
 PLATFORMIO_EXTRA_SCRIPTS=$(echo -e "pre:.clusterfuzzlite/platformio-clusterfuzzlite-pre.py\npost:.clusterfuzzlite/platformio-clusterfuzzlite-post.py")
-STATIC_LIBS=$(pkg-config --libs --static libulfius openssl libgpiod yaml-cpp jsoncpp bluez --silence-errors)
+STATIC_LIBS=$(pkg-config --libs --static libulfius openssl libgpiod yaml-cpp bluez --silence-errors)
 export PLATFORMIO_EXTRA_SCRIPTS
 export STATIC_LIBS
 export PLATFORMIO_WORKSPACE_DIR="$WORK/pio/$SANITIZER"

.devcontainer/Dockerfile

@@ -16,7 +16,6 @@ RUN apt-get update && export DEBIAN_FRONTEND=noninteractive \
     libssl-dev \
     libulfius-dev \
     libyaml-cpp-dev \
-    libjsoncpp-dev \
     pipx \
     pkg-config \
     python3 \

.github/actions/setup-base/action.yml

@@ -13,7 +13,7 @@ runs:
       shell: bash
       run: |
         sudo apt-get -y update --fix-missing
-        sudo apt-get install -y cppcheck libbluetooth-dev libgpiod-dev libyaml-cpp-dev libjsoncpp-dev lsb-release
+        sudo apt-get install -y cppcheck libbluetooth-dev libgpiod-dev libyaml-cpp-dev lsb-release
 
     - name: Setup Python
       uses: actions/setup-python@v6

.github/actions/setup-native/action.yml

@@ -11,4 +11,4 @@ runs:
     - name: Install libs needed for native build
       shell: bash
       run: |
-        sudo apt-get install -y libbluetooth-dev libgpiod-dev libyaml-cpp-dev libjsoncpp-dev openssl libssl-dev libulfius-dev liborcania-dev libusb-1.0-0-dev libi2c-dev libuv1-dev
+        sudo apt-get install -y libbluetooth-dev libgpiod-dev libyaml-cpp-dev openssl libssl-dev libulfius-dev liborcania-dev libusb-1.0-0-dev libi2c-dev libuv1-dev

.github/copilot-instructions.md

@@ -191,24 +191,7 @@ Writers go through `setNodeStatus`, `updatePosition`, `updateTelemetry` (which d
 
 ### Eviction
 
-Every code path that drops a node from the header table must also evict the satellites. The single chokepoint is `eraseNodeSatellites(NodeNum)`; it's already called from `getOrCreateMeshNode`'s oldest-boring eviction, `demoteOldestHotNodesToWarm` (the over-cap warm-tier migration), `removeNodeByNum`, both branches of `resetNodes`, `cleanupMeshDB`, `addFromContact`'s ignored-branch, and `AdminModule`'s `set_ignored_node`. Add new eviction sites here, not by calling `.erase()` directly. (Note: `enforceSatelliteCaps`/`evictSatelliteOverCap` call `.erase()` directly on purpose — that's a satellite-only cap trim where the node _stays_ in the header, a different operation from this chokepoint.)
-
-### Warm tier (long-tail identity)
-
-On every arch except STM32WL and bare nRF52832 (`WARM_NODE_COUNT > 0`), a node evicted from the header table is not forgotten outright: `WarmNodeStore` (`src/mesh/WarmNodeStore.{h,cpp}`) keeps a 40 B `{num, last_heard, public_key}` record per evicted node — primarily so PKI DMs to/from a long-tail node keep decrypting without re-running a NodeInfo exchange (the rest of `NodeInfoLite` rebuilds from traffic in seconds).
-
-- **Write:** `getOrCreateMeshNode`'s eviction and `demoteOldestHotNodesToWarm` (the over-cap boot migration) call `warmStore.absorb(num, last_heard, key)` _before_ the node leaves the header.
-- **Read-back:** `getOrCreateMeshNode` calls `warmStore.take()` to rehydrate `last_heard` + key when a warm node is re-admitted; `copyPublicKey()` falls back to the warm tier so the PKI send path finds keys for evicted peers.
-- **Persistence:** nRF52840 uses a 12 KB raw-flash record-ring at `0xEA000` (below LittleFS; append + replay + compact-on-rotate, link-guarded by `nrf52840_s140_v7.ld` and `extra_scripts/nrf52_warm_region.py`). Everywhere else: a `/prefs/warm.dat` snapshot flushed by `saveIfDirty()` on the node-DB save cadence.
-- **Tunables** (`mesh-pb-constants.h`): `WARM_NODE_COUNT` (per-arch; `0` disables the tier) and `MAX_NUM_NODES` (hot cap — 120 on nRF52840/generic ESP32 to fit the 28 KB LittleFS; ESP32-S3 keeps its flash-scaled 100/200/250, portduino 250). Verbose migration/self-care tracing routes through `LOG_MIGRATION`, gated by `MESHTASTIC_NODEDB_MIGRATION_VERBOSE`.
-
-### Satellite caps
-
-Only the freshest `MAX_SATELLITE_NODES` nodes keep satellite payloads; the rest of the header table carries just the `NodeInfoLite`. The cap is **per-platform**: 40 on RAM-constrained parts (nRF52840, generic ESP32) since the four maps live in internal SRAM (not PSRAM, ~408 B/node across the four), and 250 on flash-rich hosts (ESP32-S3, portduino) so every hot node can carry rich data as before the cap existed. `enforceSatelliteCaps()` trims each map to the cap on load (returns whether it trimmed); `evictSatelliteOverCap()` trims before each insert. Eviction is by the owning node's hot `last_heard` (stalest first, demoted/absent nodes rank as `last_heard==0`); self is never trimmed.
-
-### On-boot self-care
-
-`NodeDB::nodeDBSelfCare()` runs once identity is established (the constructor after key (re)gen, and `reloadFromDisk()` — _not_ inside `loadFromDisk`, where `getNodeNum()` is still 0). It confirms self is present (warns if a non-empty DB is missing us — a foreign/over-cap file), pins self to index 0, demotes/trims only **non-self** overflow into the warm tier, then rewrites `nodes.proto` **once** and only if it healed something — and never while encrypted storage is locked (it would persist placeholder defaults). `loadFromDisk` deliberately leaves the loaded store untrimmed for this pass.
+Every code path that drops a node from the header table must also evict the satellites. The single chokepoint is `eraseNodeSatellites(NodeNum)`; it's already called from `getOrCreateMeshNode`'s oldest-boring eviction, `removeNodeByNum`, both branches of `resetNodes`, `cleanupMeshDB`, `addFromContact`'s ignored-branch, and `AdminModule`'s `set_ignored_node`. Add new eviction sites here, not by calling `.erase()` directly.
 
 ### Sync flow: thin NodeInfo + post-COMPLETE_ID replay (no opt-in)
 
@@ -300,15 +283,6 @@ firmware/
 
 ## Coding Conventions
 
-### Formatting & the trunk toolchain
-
-`trunk fmt` is the project formatter (`trunk_check` CI rejects unformatted code). For Claude Code users, `.claude/settings.json` ships a PostToolUse hook that runs `trunk fmt --force` on every file the agent writes or edits. The hook is pure sh/grep/sed — no python or jq required — but trunk itself must be able to run:
-
-- Trunk's launcher (`~/.cache/trunk/launcher/trunk`, or `trunk` on PATH) downloads the CLI version pinned in `.trunk/trunk.yaml` on first use and again whenever that pin is bumped. **The launcher needs `curl` or `wget`**; without one it fails with "Cannot download… please install curl or wget", and the hook surfaces that as a warning on every write.
-- No curl/wget available (e.g. a minimal WSL image)? Bootstrap by hand with any Python (PlatformIO bundles one at `~/.platformio/penv/bin/python`): download `https://trunk.io/releases/<ver>/trunk-<ver>-linux-x86_64.tar.gz` and place the `trunk` binary at `~/.cache/trunk/cli/<ver>-linux-x86_64/trunk` (chmod +x), where `<ver>` is the `cli.version` from `.trunk/trunk.yaml`.
-- The hook fails loudly by design (visible warning, non-blocking). Silent no-op formatting hooks hide real breakage — don't re-add `2>/dev/null || true` around the whole thing.
-- More generally: don't assume a stock Linux userland in hooks or helper scripts — minimal WSL/container images may lack `python3`, `curl`, `wget`, and `jq`. Prefer plain sh + coreutils, or PlatformIO's bundled Python for anything heavier.
-
 ### General Style
 
 - Follow existing code style - run `trunk fmt` before commits
@@ -635,35 +609,20 @@ Most workflows can be triggered manually via `workflow_dispatch` for testing.
 
 ### Native unit tests (C++)
 
-Unit tests in `test/` directory with 17 test suites:
+Unit tests in `test/` directory with 12 test suites:
 
-- `test_admin_radio/` - LoRa region/config validation and AdminModule dispatch
-- `test_atak/` - ATAK integration
 - `test_crypto/` - Cryptography
-- `test_default/` - Default configuration
-- `test_http_content_handler/` - HTTP handling
-- `test_mac_from_string/` - MAC address parsing
+- `test_mqtt/` - MQTT integration
+- `test_radio/` - Radio interface
 - `test_mesh_module/` - Module framework
 - `test_meshpacket_serializer/` - Packet serialization
-- `test_mqtt/` - MQTT integration
-- `test_packet_history/` - Packet history tracking
-- `test_position_precision/` - Position precision helpers
-- `test_radio/` - Radio interface
-- `test_serial/` - Serial communication
-- `test_traffic_management/` - Traffic management
 - `test_transmit_history/` - Retransmission tracking
-- `test_type_conversions/` - NodeDB v25 type conversion (bitfield round-trips, NodeInfoLite)
-- `test_utf8/` - UTF-8 utilities
+- `test_atak/` - ATAK integration
+- `test_default/` - Default configuration
+- `test_http_content_handler/` - HTTP handling
+- `test_serial/` - Serial communication
 
-Run command (preferred — avoids pipe-buffering and the Ubuntu externally-managed-environment error):
-
-```bash
-~/.platformio/penv/bin/python -m platformio test -e native -f test_your_suite > /tmp/test_out.txt 2>&1
-grep -E 'error:|PASS|FAIL|succeeded|failed' /tmp/test_out.txt
-tail -15 /tmp/test_out.txt
-```
-
-Do **not** use `pio test … | tail -N` — it discards build errors and shows stale cached results. Do **not** use `pio test … | grep` — line-buffering makes the terminal appear hung until the process exits. Redirect to a file first, then grep.
+Run with: `pio test -e native`
 
 Simulation testing: `bin/test-simulator.sh`
 

.github/workflows/firmware-size-comment.yml

@@ -1,62 +0,0 @@
-name: Post Firmware Size Comment
-
-on:
-  workflow_run:
-    workflows: [CI]
-    types: [completed]
-
-permissions:
-  pull-requests: write
-  actions: read
-
-jobs:
-  post-size-comment:
-    if: >
-      github.event.workflow_run.event == 'pull_request' &&
-      github.event.workflow_run.conclusion != 'cancelled' &&
-      github.repository == 'meshtastic/firmware'
-    continue-on-error: true
-    runs-on: ubuntu-latest
-    steps:
-      - name: Download size report
-        id: download
-        uses: actions/download-artifact@v8
-        continue-on-error: true
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          run-id: ${{ github.event.workflow_run.id }}
-          name: size-report
-          path: ./
-
-      - name: Post or update PR comment
-        if: steps.download.outcome == 'success'
-        uses: actions/github-script@v8
-        with:
-          script: |
-            const fs = require('fs');
-            const marker = '<!-- firmware-size-report -->';
-            const body = fs.readFileSync('./size-report.md', 'utf8');
-            const prNumber = parseInt(fs.readFileSync('./pr-number.txt', 'utf8').trim(), 10);
-
-            const { data: comments } = await github.rest.issues.listComments({
-              owner: context.repo.owner,
-              repo: context.repo.repo,
-              issue_number: prNumber,
-            });
-
-            const existing = comments.find(c => c.body.includes(marker));
-            if (existing) {
-              await github.rest.issues.updateComment({
-                owner: context.repo.owner,
-                repo: context.repo.repo,
-                comment_id: existing.id,
-                body,
-              });
-            } else {
-              await github.rest.issues.createComment({
-                owner: context.repo.owner,
-                repo: context.repo.repo,
-                issue_number: prNumber,
-                body,
-              });
-            }

.github/workflows/flasher-link-comment.yml

@@ -1,187 +0,0 @@
-name: Post Web Flasher Link Comment
-
-on:
-  workflow_run:
-    workflows: [CI]
-    types: [completed]
-
-permissions:
-  pull-requests: write
-  actions: read
-
-jobs:
-  post-flasher-link:
-    if: >
-      github.event.workflow_run.event == 'pull_request' &&
-      github.event.workflow_run.conclusion != 'cancelled' &&
-      github.repository == 'meshtastic/firmware'
-    continue-on-error: true
-    runs-on: ubuntu-latest
-    steps:
-      # Per-board manifests carry the firmware's own metadata (activelySupported,
-      # displayName, ...) generated from each target's custom_meshtastic_* config.
-      - name: Download board manifests
-        uses: actions/download-artifact@v8
-        continue-on-error: true
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          run-id: ${{ github.event.workflow_run.id }}
-          pattern: manifest-*
-          path: ./manifests
-          merge-multiple: true
-
-      - name: Post or update web flasher link comment
-        uses: actions/github-script@v8
-        with:
-          script: |
-            const marker = '<!-- web-flasher-link -->';
-            const run = context.payload.workflow_run;
-            const { owner, repo } = context.repo;
-
-            // Resolve the PR by matching the run's head SHA against the repo's open
-            // PRs. workflow_run.pull_requests is empty for fork PRs, and
-            // listPullRequestsAssociatedWithCommit won't return an open fork PR by
-            // its head commit — but pulls.list includes fork PRs. Matching on head
-            // SHA also enforces that the run is for the PR's current commit, so stale
-            // re-runs of an outdated commit won't match.
-            const openPrs = await github.paginate(github.rest.pulls.list, {
-              owner, repo, state: 'open', per_page: 100,
-            });
-            const pr = openPrs.find((p) => p.head.sha === run.head_sha);
-            if (!pr) {
-              core.info(`No open pull request matches commit ${run.head_sha}; skipping.`);
-              return;
-            }
-            const prNumber = pr.number;
-
-            // Restrict to trusted authors. NOTE: author_association is computed for
-            // the GITHUB_TOKEN, which cannot see *private/concealed* org memberships —
-            // those members come back as CONTRIBUTOR, not MEMBER. So gating on MEMBER
-            // alone silently excludes most maintainers. We allow the trusted set the
-            // token can actually identify (members, collaborators, and anyone with a
-            // previously merged PR). For strict members-only you'd need an org-read
-            // App/PAT token to call orgs.checkMembershipForUser.
-            const allowedAssociations = ['OWNER', 'MEMBER', 'COLLABORATOR', 'CONTRIBUTOR'];
-            if (!allowedAssociations.includes(pr.author_association)) {
-              core.info(`Author association ${pr.author_association} is not trusted; skipping.`);
-              return;
-            }
-
-            // Require at least one per-arch firmware artifact from gather-artifacts
-            const artifacts = await github.paginate(github.rest.actions.listWorkflowRunArtifacts, {
-              owner, repo, run_id: run.id, per_page: 100,
-            });
-            const archRe = /^firmware-(esp32|esp32s3|esp32c3|esp32c6|nrf52840|rp2040|rp2350|stm32)-(\d+\.\d+\.\d+\.[0-9a-f]+)$/;
-            const archArtifacts = artifacts.filter((a) => archRe.test(a.name) && !a.expired);
-            if (archArtifacts.length === 0) {
-              core.info('No per-arch firmware artifacts found; skipping.');
-              return;
-            }
-
-            const version = archRe.exec(archArtifacts[0].name)[2];
-            const expiresAt = archArtifacts[0].expires_at
-              ? new Date(archArtifacts[0].expires_at).toISOString().slice(0, 10)
-              : null;
-
-            // Read each built board's manifest (.mt.json). activelySupported,
-            // displayName and architecture come straight from the board's
-            // custom_meshtastic_* platformio config, so the list is in sync with
-            // the firmware itself — no external device database needed.
-            const fs = require('fs');
-            let boards = [];
-            try {
-              boards = fs.readdirSync('./manifests')
-                .filter((f) => f.endsWith('.mt.json'))
-                .map((f) => {
-                  try { return JSON.parse(fs.readFileSync(`./manifests/${f}`, 'utf8')); }
-                  catch { return null; }
-                })
-                .filter((m) => m && m.activelySupported === true && m.platformioTarget)
-                .map((m) => ({
-                  board: m.platformioTarget,
-                  platform: m.architecture || '',
-                  // displayName is maintainer-authored text; escape table-breaking pipes
-                  displayName: String(m.displayName || m.platformioTarget).replace(/\|/g, '\\|'),
-                  image: Array.isArray(m.images) && m.images[0] ? String(m.images[0]) : '',
-                }))
-                .sort((a, b) => a.board.localeCompare(b.board));
-            } catch (e) {
-              core.warning(`Could not read board manifests: ${e.message}`);
-            }
-
-            const flasherUrl = `https://flasher.meshtastic.org/?pr=${prNumber}`;
-            // Device illustrations are served by the flasher from the same image
-            // names the manifest declares (custom_meshtastic_images). The flasher
-            // serves its SPA shell (HTML, 200) for unknown paths, so confirm each
-            // image really resolves to an image before linking it.
-            const imageBase = 'https://flasher.meshtastic.org/img/devices/';
-            await Promise.all(boards.map(async (b) => {
-              if (!b.image) return;
-              try {
-                const res = await fetch(`${imageBase}${encodeURIComponent(b.image)}`);
-                const type = res.headers.get('content-type') || '';
-                if (!res.ok || !type.startsWith('image/')) b.image = '';
-              } catch { b.image = ''; }
-            }));
-
-            const boardLines = boards
-              .map((b) => {
-                const img = b.image ? `<img src="${imageBase}${encodeURIComponent(b.image)}" alt="" height="34">` : '';
-                return `| ${img} | ${b.displayName} | [\`${b.board}\`](${flasherUrl}&device=${encodeURIComponent(b.board)}) | ${b.platform} |`;
-              })
-              .join('\n');
-
-            // Shields.io badges. Only non-user-controlled, charset-constrained values
-            // (version, commit sha, counts, dates) go into badge URLs — never board
-            // names or the PR title — so the rendered comment cannot be spoofed.
-            const shieldText = (s) =>
-              encodeURIComponent(String(s).replace(/-/g, '--').replace(/_/g, '__').replace(/ /g, '_'));
-            const shield = (label, message, color) =>
-              `https://img.shields.io/badge/${shieldText(label)}-${shieldText(message)}-${color}`;
-            const buttonUrl =
-              `https://img.shields.io/badge/${shieldText('Flash this PR in the Web Flasher')}-2C2D3C?style=for-the-badge`;
-            const badges = [
-              `![firmware](${shield('firmware', version, '67EA94')})`,
-              `![commit](${shield('commit', run.head_sha.slice(0, 7), '2C2D3C')})`,
-              `![boards](${shield('boards', boards.length, '5C6BC0')})`,
-            ];
-            if (expiresAt) badges.push(`![expires](${shield('expires', expiresAt, '9A4E00')})`);
-
-            // Only render the board table when there are supported boards to list
-            const boardTable = boards.length > 0 ? [
-              `<details><summary>Supported boards built by this PR (${boards.length})</summary>`,
-              '',
-              '| | Device | Board | Platform |',
-              '| --- | --- | --- | --- |',
-              boardLines,
-              '',
-              '</details>',
-              '',
-            ] : [];
-
-            const body = [
-              marker,
-              '## ⚡ Try this PR in the Web Flasher',
-              '',
-              `[![Flash this PR in the Web Flasher](${buttonUrl})](${flasherUrl})`,
-              '',
-              badges.join(' '),
-              '',
-              '> [!WARNING]',
-              '> This is an automated, unreviewed CI test build. Back up your device configuration',
-              '> before flashing, and only flash devices you are able to recover.',
-              '',
-              ...boardTable,
-              `*Build artifacts expire${expiresAt ? ` on ${expiresAt}` : ' after 30 days'}. Updated for \`${run.head_sha.slice(0, 7)}\`.*`,
-            ].join('\n');
-
-            // Sticky comment: update in place when the marker is found
-            const comments = await github.paginate(github.rest.issues.listComments, {
-              owner, repo, issue_number: prNumber, per_page: 100,
-            });
-            const existing = comments.find((c) => c.body?.includes(marker));
-            if (existing) {
-              await github.rest.issues.updateComment({ owner, repo, comment_id: existing.id, body });
-            } else {
-              await github.rest.issues.createComment({ owner, repo, issue_number: prNumber, body });
-            }

.github/workflows/flasher-link-placeholder.yml

@@ -1,62 +0,0 @@
-name: Post Web Flasher Build Placeholder
-
-# Drops an immediate "build in progress" comment when a PR opens, so the web
-# flasher entry shows up right away. The real CI-driven workflow
-# (flasher-link-comment.yml) later replaces it in place via the shared marker.
-#
-# SECURITY: this uses pull_request_target (write token, runs for fork PRs) but is
-# safe because it never checks out or runs PR code and posts a fully static body
-# — no PR title, branch name, or other untrusted input is used anywhere.
-
-on:
-  pull_request_target:
-    types: [opened, reopened]
-
-permissions:
-  pull-requests: write
-
-jobs:
-  post-placeholder:
-    if: github.repository == 'meshtastic/firmware'
-    continue-on-error: true
-    runs-on: ubuntu-latest
-    steps:
-      - name: Post web flasher build-in-progress placeholder
-        uses: actions/github-script@v8
-        with:
-          script: |
-            const marker = '<!-- web-flasher-link -->';
-            const { owner, repo } = context.repo;
-            const pr = context.payload.pull_request;
-
-            // Trusted authors only (matches the real workflow). author_association
-            // can't reflect private org membership for the token, so concealed
-            // members appear as CONTRIBUTOR — include it, or maintainers are excluded.
-            const allowedAssociations = ['OWNER', 'MEMBER', 'COLLABORATOR', 'CONTRIBUTOR'];
-            if (!allowedAssociations.includes(pr.author_association)) {
-              core.info(`Author association ${pr.author_association} is not trusted; skipping.`);
-              return;
-            }
-
-            // Only seed a placeholder when no flasher comment exists yet — never
-            // overwrite a real (or existing placeholder) comment.
-            const comments = await github.paginate(github.rest.issues.listComments, {
-              owner, repo, issue_number: pr.number, per_page: 100,
-            });
-            if (comments.some((c) => c.body?.includes(marker))) {
-              core.info('Flasher comment already exists; nothing to do.');
-              return;
-            }
-
-            const body = [
-              marker,
-              '## ⚡ Try this PR in the Web Flasher',
-              '',
-              '> [!NOTE]',
-              '> Building this pull request… the flash button, badges and supported-board',
-              '> list will appear here automatically once CI finishes.',
-            ].join('\n');
-
-            await github.rest.issues.createComment({
-              owner, repo, issue_number: pr.number, body,
-            });

.github/workflows/main_matrix.yml

@@ -82,9 +82,8 @@ jobs:
       fail-fast: false
       matrix:
         check: ${{ fromJson(needs.setup.outputs.check) }}
-    # Runs on GitHub-hosted runners so checks don't compete with builds for the
-    # self-hosted 'arctastic' pool (which builds use).
-    runs-on: ubuntu-latest
+    # Use 'arctastic' self-hosted runner pool when checking in the main repo
+    runs-on: ${{ github.repository_owner == 'meshtastic' && 'arctastic' || 'ubuntu-latest' }}
     if: ${{ github.event_name != 'workflow_dispatch' && github.repository == 'meshtastic/firmware' }}
     steps:
       - uses: actions/checkout@v6
@@ -246,126 +245,47 @@ jobs:
           path: ./*.elf
           retention-days: 30
 
-  firmware-size-report:
+  shame:
     if: github.repository == 'meshtastic/firmware'
     continue-on-error: true
-    permissions:
-      contents: read
-      actions: read
     runs-on: ubuntu-latest
     needs: [build]
     steps:
       - uses: actions/checkout@v6
-
-      - name: Download current manifests
+        if: github.event_name == 'pull_request'
+        with:
+          filter: blob:none # means we download all the git history but none of the commit (except ones with checkout like the head)
+          fetch-depth: 0
+      - name: Download the current manifests
         uses: actions/download-artifact@v8
         with:
-          path: ./manifests/
+          path: ./manifests-new/
           pattern: manifest-*
           merge-multiple: true
-
-      - name: Collect current firmware sizes
-        run: python3 bin/collect_sizes.py ./manifests/ ./current-sizes.json
-
-      - name: Upload size report artifact
+      - name: Upload combined manifests for later commit and global stats crunching.
         uses: actions/upload-artifact@v7
+        id: upload-manifest
         with:
-          name: firmware-sizes-${{ github.sha }}
+          name: manifests-${{ github.sha }}
           overwrite: true
-          path: ./current-sizes.json
-          retention-days: 90
-
-      - name: Download baseline sizes from develop
+          path: manifests-new/*.mt.json
+      - name: Find the merge base
         if: github.event_name == 'pull_request'
-        continue-on-error: true
-        id: baseline-develop
+        run: echo "MERGE_BASE=$(git merge-base "origin/$base" "$head")" >> $GITHUB_ENV
         env:
-          GH_TOKEN: ${{ github.token }}
-        run: |
-          RUN_ID=$(gh run list -R "${{ github.repository }}" \
-            --workflow CI --branch develop --status success \
-            --limit 1 --json databaseId --jq '.[0].databaseId // empty')
-          if [ -n "$RUN_ID" ]; then
-            ARTIFACT_NAME=$(gh api "repos/${{ github.repository }}/actions/runs/${RUN_ID}/artifacts" \
-              --jq '.artifacts[] | select(.name | startswith("firmware-sizes-")) | select(.expired == false) | .name' | head -1)
-            if [ -n "$ARTIFACT_NAME" ]; then
-              gh run download "$RUN_ID" -R "${{ github.repository }}" \
-                --name "$ARTIFACT_NAME" --dir ./baseline-develop/
-              cp "./baseline-develop/current-sizes.json" ./develop-sizes.json
-              echo "found=true" >> "$GITHUB_OUTPUT"
-            else
-              echo "found=false" >> "$GITHUB_OUTPUT"
-            fi
-          else
-            echo "found=false" >> "$GITHUB_OUTPUT"
-          fi
-
-      - name: Download baseline sizes from master
-        if: github.event_name == 'pull_request'
-        continue-on-error: true
-        id: baseline-master
-        env:
-          GH_TOKEN: ${{ github.token }}
-        run: |
-          RUN_ID=$(gh run list -R "${{ github.repository }}" \
-            --workflow CI --branch master --status success \
-            --limit 1 --json databaseId --jq '.[0].databaseId // empty')
-          if [ -n "$RUN_ID" ]; then
-            ARTIFACT_NAME=$(gh api "repos/${{ github.repository }}/actions/runs/${RUN_ID}/artifacts" \
-              --jq '.artifacts[] | select(.name | startswith("firmware-sizes-")) | select(.expired == false) | .name' | head -1)
-            if [ -n "$ARTIFACT_NAME" ]; then
-              gh run download "$RUN_ID" -R "${{ github.repository }}" \
-                --name "$ARTIFACT_NAME" --dir ./baseline-master/
-              cp "./baseline-master/current-sizes.json" ./master-sizes.json
-              echo "found=true" >> "$GITHUB_OUTPUT"
-            else
-              echo "found=false" >> "$GITHUB_OUTPUT"
-            fi
-          else
-            echo "found=false" >> "$GITHUB_OUTPUT"
-          fi
-
-      - name: Generate size comparison report
-        if: github.event_name == 'pull_request'
-        id: report
-        run: |
-          ARGS="./current-sizes.json"
-          if [ -f ./develop-sizes.json ]; then
-            ARGS="$ARGS --baseline develop:./develop-sizes.json"
-          fi
-          if [ -f ./master-sizes.json ]; then
-            ARGS="$ARGS --baseline master:./master-sizes.json"
-          fi
-          REPORT=$(python3 bin/size_report.py $ARGS)
-          if [ -z "$REPORT" ]; then
-            echo "has_report=false" >> "$GITHUB_OUTPUT"
-          else
-            echo "has_report=true" >> "$GITHUB_OUTPUT"
-            {
-              echo '<!-- firmware-size-report -->'
-              echo '# Firmware Size Report'
-              echo ''
-              echo "$REPORT"
-              echo ''
-              echo '---'
-              echo "*Updated for ${{ github.sha }}*"
-            } > ./size-report.md
-            cat ./size-report.md >> "$GITHUB_STEP_SUMMARY"
-          fi
-
-      - name: Save PR number
-        if: github.event_name == 'pull_request' && steps.report.outputs.has_report == 'true'
-        run: echo "${{ github.event.pull_request.number }}" > ./pr-number.txt
-
-      - name: Upload size report
-        if: github.event_name == 'pull_request' && steps.report.outputs.has_report == 'true'
-        uses: actions/upload-artifact@v7
-        with:
-          name: size-report
-          path: |
-            ./size-report.md
-            ./pr-number.txt
-          retention-days: 5
+          base: ${{ github.base_ref }}
+          head: ${{ github.sha }}
+      # Currently broken (for-loop through EVERY artifact -- rate limiting)
+      # - name: Download the old manifests
+      #   if: github.event_name == 'pull_request'
+      #   run: gh run download -R "$repo" --name "manifests-$merge_base" --dir manifest-old/
+      #   env:
+      #     GH_TOKEN: ${{ github.token }}
+      #     merge_base: ${{ env.MERGE_BASE }}
+      #     repo: ${{ github.repository }}
+      # - name: Do scan and post comment
+      #   if: github.event_name == 'pull_request'
+      #   run: python3 bin/shame.py ${{ github.event.pull_request.number }} manifests-old/ manifests-new/
 
   release-artifacts:
     permissions: # Needed for 'gh release upload'.
@@ -413,7 +333,6 @@ jobs:
           prerelease: true
           name: Meshtastic Firmware ${{ needs.version.outputs.long }} Alpha
           tag_name: v${{ needs.version.outputs.long }}
-          target_commitish: ${{ github.sha }}
           body: ${{ steps.release_notes.outputs.notes }}
 
       - name: Download source deb

.github/workflows/test_native.yml

@@ -37,33 +37,13 @@ jobs:
           sed -i -e "s#${PWD}#.#" coverage_base.info # Make paths relative.
 
       - name: Integration test
-        # Cap the whole step: if the simulator ever fails to exit (e.g. the
-        # exit_simulator admin path regresses again) the job must fail fast,
-        # not run to GitHub's 6-hour limit.
-        timeout-minutes: 5
         run: |
           .pio/build/coverage/meshtasticd -s &
           PID=$!
-          trap 'kill "$PID" 2>/dev/null || true' EXIT
           timeout 20 bash -c "until ls -al /proc/$PID/fd | grep socket; do sleep 1; done"
           echo "Simulator started, launching python test..."
           python3 -c 'from meshtastic.test import testSimulator; testSimulator()'
-          # The Python harness sends exit_simulator and exits; the simulator is
-          # expected to terminate on its own. Give it a moment, then verify.
-          # If it is still alive the exit handshake is broken — fail loudly and
-          # do NOT fall through to `wait`, which would otherwise block until the
-          # job's hard timeout.
-          for i in $(seq 1 10); do
-            kill -0 "$PID" 2>/dev/null || break
-            sleep 1
-          done
-          if kill -0 "$PID" 2>/dev/null; then
-            echo "::error title=Simulator did not exit::meshtasticd ignored exit_simulator and is still running after the integration test. The exit_simulator admin path is broken (see AdminModule::handleReceivedProtobuf, ARCH_PORTDUINO bypass). Killing it to avoid a 6-hour CI overrun."
-            kill -9 "$PID" 2>/dev/null || true
-            wait "$PID" 2>/dev/null || true
-            exit 1
-          fi
-          wait "$PID" 2>/dev/null || true
+          wait
 
       - name: Capture coverage information
         if: always() # run this step even if previous step failed
@@ -161,14 +141,6 @@ jobs:
           name: platformio-test-report-${{ steps.version.outputs.long }}
           merge-multiple: true
 
-      - name: Drop no-status testsuites from the report
-        # PlatformIO emits a self-closing <testsuite tests="0"/> row for every test_* dir
-        # crossed with every hardware variant it cannot run on the native host (~4900 rows).
-        # They carry no pass/fail/skip status and bury the suites that actually ran. Strip
-        # them so the Test Report lists only suites with a real status. Only the copy the
-        # reporter renders is trimmed; the uploaded artifact keeps the full XML.
-        run: sed -i -E 's#<testsuite [^>]*tests="0"[^>]*/>##g' testreport.xml
-
       - name: Test Report
         uses: dorny/test-reporter@v3.0.0
         with:

.github/workflows/update_protobufs.yml

@@ -16,18 +16,13 @@ jobs:
           submodules: true
 
       - name: Update submodule
-        if: ${{ github.ref_name == 'master' || github.ref_name == 'develop' }}
-        working-directory: protobufs
-        env:
-          # Use the branch that triggered the workflow as the protobuf branch.
-          GIT_BRANCH: ${{ github.ref_name }}
+        if: ${{ github.ref == 'refs/heads/master' || github.ref == 'refs/heads/develop' }}
         run: |
-          git fetch --prune origin $GIT_BRANCH
-          git checkout origin/$GIT_BRANCH
+          git submodule update --remote protobufs
 
       - name: Download nanopb
         run: |
-          wget https://github.com/nanopb/nanopb/releases/download/nanopb-0.4.9.1/nanopb-0.4.9.1-linux-x86.tar.gz
+          wget https://jpa.kapsi.fi/nanopb/download/nanopb-0.4.9.1-linux-x86.tar.gz
           tar xvzf nanopb-0.4.9.1-linux-x86.tar.gz
           mv nanopb-0.4.9.1-linux-x86 nanopb-0.4.9
 
@@ -38,7 +33,7 @@ jobs:
       - name: Create pull request
         uses: peter-evans/create-pull-request@v8
         with:
-          branch: create-pull-request/update-protobufs-${{ github.ref_name }}
+          branch: create-pull-request/update-protobufs
           labels: submodules
           title: Update protobufs and classes
           commit-message: Update protobufs

AGENTS.md

@@ -10,18 +10,18 @@ This file (`AGENTS.md`) is a short pointer + quick reference for agents that don
 
 ## Quick command reference
 
-| Action                           | Command                                                                                                                                                                                                        |
-| -------------------------------- | -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| Build a firmware variant         | `pio run -e <env>` (e.g. `pio run -e rak4631`, `pio run -e heltec-v3`)                                                                                                                                         |
-| Build native macOS host binary   | `pio run -e native-macos` (Homebrew prereqs + CH341 LoRa setup in `variants/native/portduino/platformio.ini`)                                                                                                  |
-| Clean + rebuild                  | `pio run -e <env> -t clean && pio run -e <env>`                                                                                                                                                                |
-| Flash a device                   | `pio run -e <env> -t upload --upload-port <port>` (or use the `pio_flash` MCP tool)                                                                                                                            |
-| Run firmware unit tests (native) | `~/.platformio/penv/bin/python -m platformio test -e native > /tmp/test_out.txt 2>&1` then `grep -E 'error:\|PASS\|FAIL\|succeeded\|failed' /tmp/test_out.txt` (redirect first — piping causes line-buffering) |
-| Run MCP hardware tests           | `./mcp-server/run-tests.sh`                                                                                                                                                                                    |
-| Live TUI test runner             | `mcp-server/.venv/bin/meshtastic-mcp-test-tui`                                                                                                                                                                 |
-| Format before commit             | `trunk fmt`                                                                                                                                                                                                    |
-| Regenerate protobuf bindings     | `bin/regen-protos.sh`                                                                                                                                                                                          |
-| Generate CI matrix               | `./bin/generate_ci_matrix.py all [--level pr]`                                                                                                                                                                 |
+| Action                           | Command                                                                                                       |
+| -------------------------------- | ------------------------------------------------------------------------------------------------------------- |
+| Build a firmware variant         | `pio run -e <env>` (e.g. `pio run -e rak4631`, `pio run -e heltec-v3`)                                        |
+| Build native macOS host binary   | `pio run -e native-macos` (Homebrew prereqs + CH341 LoRa setup in `variants/native/portduino/platformio.ini`) |
+| Clean + rebuild                  | `pio run -e <env> -t clean && pio run -e <env>`                                                               |
+| Flash a device                   | `pio run -e <env> -t upload --upload-port <port>` (or use the `pio_flash` MCP tool)                           |
+| Run firmware unit tests (native) | `pio test -e native`                                                                                          |
+| Run MCP hardware tests           | `./mcp-server/run-tests.sh`                                                                                   |
+| Live TUI test runner             | `mcp-server/.venv/bin/meshtastic-mcp-test-tui`                                                                |
+| Format before commit             | `trunk fmt`                                                                                                   |
+| Regenerate protobuf bindings     | `bin/regen-protos.sh`                                                                                         |
+| Generate CI matrix               | `./bin/generate_ci_matrix.py all [--level pr]`                                                                |
 
 ## MCP server (device + test automation)
 
@@ -64,7 +64,7 @@ Key rotation to never trigger casually: only the **full** factory reset (`factor
 - **One MCP call per serial port at a time.** The port lock is exclusive; concurrent calls deadlock. Sequence: open → read/mutate → close, then next device.
 - **`userPrefs.jsonc` is session state during tests.** The `_session_userprefs` fixture snapshots + restores it; never edit it from inside a test.
 - **Don't speculate about firmware root causes.** When evidence doesn't support a classification, say "unknown" and list what would disambiguate.
-- **Run `trunk fmt` before proposing a commit.** The `trunk_check` CI gate will reject unformatted code. Claude Code runs it automatically via the PostToolUse hook in `.claude/settings.json`; trunk's launcher needs `curl` or `wget` to bootstrap its pinned CLI — see **Formatting & the trunk toolchain** in `.github/copilot-instructions.md` for the no-curl bootstrap procedure.
+- **Run `trunk fmt` before proposing a commit.** The `trunk_check` CI gate will reject unformatted code.
 - **`confirm=True` on destructive MCP tools is a real gate, not a formality.** Don't bypass it via auto-approve settings.
 - **Keep code comments minimal — one or two lines, max.** Comment only when the _why_ isn't obvious from the code; never restate what the next line does. No multi-paragraph block comments explaining straightforward changes. The diff and commit message carry the rationale; the code carries the behavior.
 - **Use `Throttle` for time-based rate limiting, not raw `millis()` math.** `src/mesh/Throttle.h` provides `Throttle::isWithinTimespanMs(lastMs, intervalMs)` (returns true while inside the cooldown) and `Throttle::execute(&lastMs, intervalMs, func)` (function-pointer form that updates the timestamp on fire). Use these for any "did N ms pass since X" check — raw `millis() > lastMs + N` is rollover-unsafe (breaks after ~49.7 days) and inconsistent with the rest of the codebase. The helpers compute `now - lastMs` with unsigned subtraction, which wraps correctly.
@@ -108,7 +108,7 @@ Sequence these; don't parallelize on the same port.
 | `src/modules/`                    | Feature modules; `Telemetry/Sensor/` has 50+ I2C sensor drivers                                                          |
 | `variants/`                       | 200+ hardware variant definitions (`variant.h` + `platformio.ini` per board)                                             |
 | `protobufs/`                      | `.proto` definitions; regenerate with `bin/regen-protos.sh`                                                              |
-| `test/`                           | Firmware unit tests (17 suites; `pio test -e native`)                                                                    |
+| `test/`                           | Firmware unit tests (12 suites; `pio test -e native`)                                                                    |
 | `mcp-server/`                     | Python MCP server + pytest hardware integration tests                                                                    |
 | `mcp-server/tests/`               | Tiered pytest suite: `unit/`, `mesh/`, `telemetry/`, `monitor/`, `recovery/`, `ui/`, `fleet/`, `admin/`, `provisioning/` |
 | `.claude/commands/`               | Claude Code slash command bodies                                                                                         |

Dockerfile

@@ -14,7 +14,7 @@ ENV PIP_BREAK_SYSTEM_PACKAGES=1
 RUN apt-get update && apt-get install --no-install-recommends -y \
         curl wget g++ zip git ca-certificates pkg-config \
         python3-pip python3-grpc-tools \
-        libgpiod-dev libyaml-cpp-dev libjsoncpp-dev libbluetooth-dev libi2c-dev libuv1-dev \
+        libgpiod-dev libyaml-cpp-dev libbluetooth-dev libi2c-dev libuv1-dev \
         libusb-1.0-0-dev libulfius-dev liborcania-dev libssl-dev \
         libx11-dev libinput-dev libxkbcommon-x11-dev libsqlite3-dev libsdl2-dev \
     && apt-get clean && rm -rf /var/lib/apt/lists/* \
@@ -53,7 +53,7 @@ ENV TZ=Etc/UTC
 USER root
 
 RUN apt-get update && apt-get --no-install-recommends -y install \
-        libc-bin libc6 libgpiod3 libyaml-cpp0.8 libjsoncpp26 libi2c0 libuv1t64 libusb-1.0-0-dev \
+        libc-bin libc6 libgpiod3 libyaml-cpp0.8 libi2c0 libuv1t64 libusb-1.0-0-dev \
         liborcania2.3 libulfius2.7t64 libssl3t64 \
         libx11-6 libinput10 libxkbcommon-x11-0 libsdl2-2.0-0 \
     && apt-get clean && rm -rf /var/lib/apt/lists/* \

Dockerfile.test

@@ -7,7 +7,7 @@ ENV PIP_ROOT_USER_ACTION=ignore
 # hadolint ignore=DL3008
 RUN apt-get update && apt-get install --no-install-recommends -y \
         g++ git ca-certificates pkg-config \
-        libgpiod-dev libyaml-cpp-dev libjsoncpp-dev libbluetooth-dev libi2c-dev libuv1-dev \
+        libgpiod-dev libyaml-cpp-dev libbluetooth-dev libi2c-dev libuv1-dev \
         libusb-1.0-0-dev libulfius-dev liborcania-dev libssl-dev \
         libx11-dev libinput-dev libxkbcommon-x11-dev libsqlite3-dev libsdl2-dev \
     && apt-get clean && rm -rf /var/lib/apt/lists/* \

SECURITY.md

@@ -10,35 +10,3 @@
 ## Reporting a Vulnerability
 
 We support the private reporting of potential security vulnerabilities. Please go to the Security tab to file a report with a description of the potential vulnerability and reproduction scripts (preferred) or steps, and our developers will review.
-
-Before filing, please read the Security Model below. Behavior whose only precondition is local API access to a node, or possession of a channel's pre-shared key, is intended by design and is not considered a vulnerability.
-
-## Security Model
-
-Meshtastic is an off-grid mesh protocol that runs on constrained microcontrollers within a 256 byte LoRa packet limit. These constraints shape its security design and rule out the heavier schemes used by IP-based protocols. This section summarizes what the firmware protects, the assumptions it rests on, and its known limits. Fuller write-ups are in the documentation:
-
-- Encryption overview: https://meshtastic.org/docs/overview/encryption/
-- Technical reference: https://meshtastic.org/docs/development/reference/encryption-technical/
-- Known limitations and future work: https://meshtastic.org/docs/about/overview/encryption/limitations/
-
-### Cryptographic mechanisms
-
-- Channels are encrypted with a pre-shared key (PSK) using AES256-CTR. Channel traffic is encrypted but not authenticated, so anyone holding the PSK can read channel messages and can send messages as any node on that channel.
-- Direct messages and admin messages use public key cryptography (x25519 key exchange with AES-CCM), providing confidentiality, authentication, and integrity between nodes on 2.5.0 or newer that have exchanged keys.
-- Admin sessions use short-lived session IDs to limit replay of control messages.
-
-### Local trust boundary
-
-A client connected to a node over Bluetooth, USB serial, WiFi, or Ethernet has full local API access. From that connection it can read decrypted traffic, send messages as the node, change configuration (subject to managed mode), and read the node's private key for backup. This is intended behavior. The firmware trusts the local link the same way a phone or laptop trusts a directly attached device, and anything within reach of that connection (a shared LAN, a USB cable to an untrusted host, a paired phone) should be treated as part of the node itself.
-
-### Node identity (Trust On First Use)
-
-There is no central authority to sign node keys. The first public key a node hears for a given node number is the one it binds to that node number, a Trust On First Use (TOFU) model that is a hard requirement of a decentralized mesh. Clients and firmware reduce the impact of this by keeping favorited nodes from rolling out of the node database and by flagging public-key changes in the client UI.
-
-Firmware 2.8.X adds XEdDSA packet signing to further secure node identity claims and the authenticity of subsequent messages. It reuses each node's existing x25519 key pair to produce signatures, so a receiver can verify that a packet came from the holder of the bound key. Once a node has been seen signing, unsigned packets claiming that identity can be rejected.
-
-### Known limitations
-
-- No perfect forward secrecy. Traffic captured today can be decrypted later if a key is compromised, for example through a lost node or a mishandled channel key.
-- Channel messages are not authenticated, as noted above. Although as of 2.8, channel messages will be xedDSA signed as a means of verification that is non-breaking.
-- Setting WiFi credentials, or performing any other local administration, on an ESP32 over an untrusted network exposes that traffic, including the credentials, to the network. Provision and administer nodes over a trusted channel instead: Bluetooth, USB serial, or remote admin over the mesh. There is no current roadmap item to secure local administration over untrusted WiFi, though it may be addressed in a future release.

alpine.Dockerfile

@@ -16,7 +16,7 @@ ENV PIP_BREAK_SYSTEM_PACKAGES=1
 RUN apk --no-cache add \
         bash g++ libstdc++-dev linux-headers zip git ca-certificates libbsd-dev \
         py3-pip py3-grpcio-tools \
-        libgpiod-dev yaml-cpp-dev jsoncpp-dev bluez-dev \
+        libgpiod-dev yaml-cpp-dev bluez-dev \
         libusb-dev i2c-tools-dev libuv-dev openssl-dev pkgconf argp-standalone \
         libx11-dev libinput-dev libxkbcommon-dev sqlite-dev sdl2-dev \
     && rm -rf /var/cache/apk/* \
@@ -48,7 +48,7 @@ LABEL org.opencontainers.image.title="Meshtastic" \
 USER root
 
 RUN apk --no-cache add \
-        shadow libstdc++ libbsd libgpiod yaml-cpp jsoncpp libusb \
+        shadow libstdc++ libbsd libgpiod yaml-cpp libusb \
         i2c-tools libuv libx11 libinput libxkbcommon sdl2 \
     && rm -rf /var/cache/apk/* \
     && mkdir -p /var/lib/meshtasticd \

bin/collect_sizes.py

@@ -1,53 +0,0 @@
-#!/usr/bin/env python3
-
-"""Collect firmware binary sizes from manifest (.mt.json) files into a single report."""
-
-import json
-import os
-import sys
-
-
-def collect_sizes(manifest_dir):
-    """Scan manifest_dir for .mt.json files and return {board: size_bytes} dict."""
-    sizes = {}
-    for fname in sorted(os.listdir(manifest_dir)):
-        if not fname.endswith(".mt.json"):
-            continue
-        path = os.path.join(manifest_dir, fname)
-        with open(path) as f:
-            data = json.load(f)
-        board = data.get("platformioTarget", fname.replace(".mt.json", ""))
-        # Find the main firmware .bin size (largest .bin, excluding OTA/littlefs/bleota)
-        bin_size = None
-        for entry in data.get("files", []):
-            name = entry.get("name", "")
-            if name.startswith("firmware-") and name.endswith(".bin"):
-                bin_size = entry["bytes"]
-                break
-        # Fallback: any .bin that isn't ota/littlefs/bleota
-        if bin_size is None:
-            for entry in data.get("files", []):
-                name = entry.get("name", "")
-                if name.endswith(".bin") and not any(
-                    x in name for x in ["littlefs", "bleota", "ota"]
-                ):
-                    bin_size = entry["bytes"]
-                    break
-        if bin_size is not None:
-            sizes[board] = bin_size
-    return sizes
-
-
-if __name__ == "__main__":
-    if len(sys.argv) != 3:
-        print(f"Usage: {sys.argv[0]} <manifest_dir> <output.json>", file=sys.stderr)
-        sys.exit(1)
-
-    manifest_dir = sys.argv[1]
-    output_path = sys.argv[2]
-
-    sizes = collect_sizes(manifest_dir)
-    with open(output_path, "w") as f:
-        json.dump(sizes, f, indent=2, sort_keys=True)
-
-    print(f"Collected sizes for {len(sizes)} targets -> {output_path}")

bin/config.d/lora-RAK6421-13300-slot2.yaml

@@ -5,9 +5,7 @@ Meta:
     - raspberry-pi
 
 Lora:
-  
-  ### RAK13300 in Slot 2
-  Module: sx1262
+  ### RAK13300 in Slot 2 pins
   IRQ: 18 #IO6
   Reset: 24 # IO4
   Busy: 19 # IO5
@@ -15,7 +13,5 @@ Lora:
   Enable_Pins:
     - 26
     - 23
-  DIO3_TCXO_VOLTAGE: true
-  DIO2_AS_RF_SWITCH: true
   spidev: spidev0.1
   # CS: 7

bin/config.d/lora-RAK6421-13302-slot2.yaml

@@ -5,18 +5,14 @@ Meta:
     - raspberry-pi
 
 Lora:
-
-  ### RAK13302 in Slot 2
-  Module: sx1262
+  ### RAK13302 in Slot 2 pins
   IRQ: 18 #IO6
   Reset: 24 # IO4
   Busy: 19 # IO5
-  # Ant_sw: 23 # IO3
+  # Ant_sw: 23 # IO3 
   Enable_Pins:
     - 26
     - 23
-  DIO3_TCXO_VOLTAGE: true
-  DIO2_AS_RF_SWITCH: true
   spidev: spidev0.1
   # CS: 7
   TX_GAIN_LORA: [9, 9, 10, 11, 9, 8, 9, 10, 10, 10, 11, 12, 12, 12, 12, 12, 12, 12, 12, 10, 9, 8]

bin/eth-ota-upload.py

@@ -1,252 +0,0 @@
-#!/usr/bin/env python3
-"""
-Meshtastic Ethernet OTA Upload Tool
-
-Uploads firmware to RP2350-based Meshtastic devices via Ethernet (W5500).
-Compresses firmware with GZIP and sends it over TCP using the MOTA protocol.
-Authenticates using SHA256 challenge-response with a pre-shared key (PSK).
-
-Usage:
-    python bin/eth-ota-upload.py --host 192.168.1.100 firmware.bin
-    python bin/eth-ota-upload.py --host 192.168.1.100 --psk mySecretKey firmware.bin
-    python bin/eth-ota-upload.py --host 192.168.1.100 --psk-hex 6d65736874... firmware.bin
-"""
-
-import argparse
-import gzip
-import hashlib
-import socket
-import struct
-import sys
-import time
-
-# Default PSK matching the firmware default: "meshtastic_ota_default_psk_v1!!!"
-DEFAULT_PSK = b"meshtastic_ota_default_psk_v1!!!"
-
-
-def crc32(data: bytes) -> int:
-    """Compute CRC32 matching ErriezCRC32 (standard CRC32 with final XOR)."""
-    import binascii
-
-    return binascii.crc32(data) & 0xFFFFFFFF
-
-
-def load_firmware(path: str) -> bytes:
-    """Load firmware file, compressing with GZIP if not already compressed."""
-    # Reject UF2 files — OTA requires raw .bin firmware
-    if path.lower().endswith(".uf2"):
-        bin_path = path.rsplit(".", 1)[0] + ".bin"
-        print(f"ERROR: UF2 files cannot be used for OTA updates.")
-        print(f"       The Updater/picoOTA expects raw .bin firmware.")
-        print(f"       Try: {bin_path}")
-        sys.exit(1)
-
-    with open(path, "rb") as f:
-        data = f.read()
-
-    # Check if already GZIP compressed (magic bytes 1f 8b)
-    if data[:2] == b"\x1f\x8b":
-        print(f"Firmware already GZIP compressed: {len(data):,} bytes")
-        return data
-
-    print(f"Firmware raw size: {len(data):,} bytes")
-    compressed = gzip.compress(data, compresslevel=9)
-    ratio = len(compressed) / len(data) * 100
-    print(f"GZIP compressed: {len(compressed):,} bytes ({ratio:.1f}%)")
-    return compressed
-
-
-def authenticate(sock: socket.socket, psk: bytes) -> bool:
-    """Perform SHA256 challenge-response authentication with the device."""
-    # Receive 32-byte nonce from server
-    nonce = b""
-    while len(nonce) < 32:
-        chunk = sock.recv(32 - len(nonce))
-        if not chunk:
-            print("ERROR: Connection closed during authentication")
-            return False
-        nonce += chunk
-
-    # Compute SHA256(nonce || PSK)
-    h = hashlib.sha256()
-    h.update(nonce)
-    h.update(psk)
-    response = h.digest()
-
-    # Send 32-byte response
-    sock.sendall(response)
-
-    # Wait for auth result (1 byte)
-    result = sock.recv(1)
-    if not result:
-        print("ERROR: No authentication response")
-        return False
-
-    if result[0] == 0x06:  # ACK
-        print("Authentication successful.")
-        return True
-    elif result[0] == 0x07:  # OTA_ERR_AUTH
-        print("ERROR: Authentication failed — wrong PSK")
-        return False
-    else:
-        print(f"ERROR: Unexpected auth response 0x{result[0]:02X}")
-        return False
-
-
-def upload_firmware(host: str, port: int, firmware: bytes, psk: bytes, timeout: float) -> bool:
-    """Upload firmware over TCP using the MOTA protocol with PSK authentication."""
-    fw_crc = crc32(firmware)
-    fw_size = len(firmware)
-
-    print(f"Connecting to {host}:{port}...")
-    sock = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
-    sock.settimeout(timeout)
-
-    try:
-        sock.connect((host, port))
-        print("Connected.")
-
-        # Step 1: Authenticate
-        print("Authenticating...")
-        if not authenticate(sock, psk):
-            return False
-
-        # Step 2: Send 12-byte MOTA header: magic(4) + size(4) + crc32(4)
-        header = struct.pack("<4sII", b"MOTA", fw_size, fw_crc)
-        sock.sendall(header)
-        print(f"Header sent: size={fw_size:,}, CRC32=0x{fw_crc:08X}")
-
-        # Wait for ACK (1 byte)
-        ack = sock.recv(1)
-        if not ack or ack[0] != 0x06:
-            error_codes = {
-                0x02: "Size error",
-                0x04: "Invalid magic",
-                0x05: "Update.begin() failed",
-            }
-            code = ack[0] if ack else 0xFF
-            msg = error_codes.get(code, f"Unknown error 0x{code:02X}")
-            print(f"ERROR: Server rejected header: {msg}")
-            return False
-
-        print("Header accepted. Uploading firmware...")
-
-        # Send firmware in 1KB chunks
-        chunk_size = 1024
-        sent = 0
-        start_time = time.time()
-
-        while sent < fw_size:
-            end = min(sent + chunk_size, fw_size)
-            chunk = firmware[sent:end]
-            sock.sendall(chunk)
-            sent = end
-
-            # Progress bar
-            pct = sent * 100 // fw_size
-            bar_len = 40
-            filled = bar_len * sent // fw_size
-            bar = "█" * filled + "░" * (bar_len - filled)
-            elapsed = time.time() - start_time
-            speed = sent / elapsed if elapsed > 0 else 0
-            sys.stdout.write(f"\r  [{bar}] {pct:3d}% {sent:,}/{fw_size:,} ({speed/1024:.1f} KB/s)")
-            sys.stdout.flush()
-
-        elapsed = time.time() - start_time
-        print(f"\n  Transfer complete in {elapsed:.1f}s")
-
-        # Wait for final result (1 byte)
-        print("Waiting for verification...")
-        result = sock.recv(1)
-        if not result:
-            print("ERROR: No response from device")
-            return False
-
-        result_codes = {
-            0x00: "OK — Update staged, device rebooting",
-            0x01: "CRC mismatch",
-            0x02: "Size error",
-            0x03: "Write error",
-            0x04: "Magic mismatch",
-            0x05: "Updater.begin() failed",
-            0x07: "Auth failed",
-            0x08: "Timeout",
-        }
-        code = result[0]
-        msg = result_codes.get(code, f"Unknown result 0x{code:02X}")
-
-        if code == 0x00:
-            print(f"SUCCESS: {msg}")
-            return True
-        else:
-            print(f"ERROR: {msg}")
-            return False
-
-    except socket.timeout:
-        print("ERROR: Connection timed out")
-        return False
-    except ConnectionRefusedError:
-        print(f"ERROR: Connection refused by {host}:{port}")
-        return False
-    except OSError as e:
-        print(f"ERROR: {e}")
-        return False
-    finally:
-        sock.close()
-
-
-def main():
-    parser = argparse.ArgumentParser(
-        description="Upload firmware to Meshtastic RP2350 devices via Ethernet OTA"
-    )
-    parser.add_argument("firmware", help="Path to firmware .bin or .bin.gz file")
-    parser.add_argument("--host", required=True, help="Device IP address")
-    parser.add_argument(
-        "--port", type=int, default=4243, help="OTA port (default: 4243)"
-    )
-    parser.add_argument(
-        "--timeout",
-        type=float,
-        default=60.0,
-        help="Socket timeout in seconds (default: 60)",
-    )
-    psk_group = parser.add_mutually_exclusive_group()
-    psk_group.add_argument(
-        "--psk",
-        type=str,
-        help="Pre-shared key as UTF-8 string (default: meshtastic_ota_default_psk_v1!!!)",
-    )
-    psk_group.add_argument(
-        "--psk-hex",
-        type=str,
-        help="Pre-shared key as hex string (e.g., 6d65736874...)",
-    )
-    args = parser.parse_args()
-
-    # Resolve PSK
-    if args.psk:
-        psk = args.psk.encode("utf-8")
-    elif args.psk_hex:
-        try:
-            psk = bytes.fromhex(args.psk_hex)
-        except ValueError:
-            print("ERROR: Invalid hex string for --psk-hex")
-            sys.exit(1)
-    else:
-        psk = DEFAULT_PSK
-
-    print("Meshtastic Ethernet OTA Upload")
-    print("=" * 40)
-
-    firmware = load_firmware(args.firmware)
-
-    if upload_firmware(args.host, args.port, firmware, psk, args.timeout):
-        print("\nDevice is rebooting with new firmware.")
-        sys.exit(0)
-    else:
-        print("\nUpload failed.")
-        sys.exit(1)
-
-
-if __name__ == "__main__":
-    main()

bin/run-tests.sh

@@ -1,249 +0,0 @@
-#!/usr/bin/env bash
-# Run native PlatformIO unit tests and emit a single, unambiguous RED/AMBER/GREEN verdict.
-#
-# Why this exists: PlatformIO reports failures three different ways ([FAILED], :FAIL:,
-# [ERRORED]) and an all-pass run prints "N succeeded" with NO "0 failed" clause — so naive
-# greps produce false greens (see .notes/test-passfail-filter.md). This script encodes the
-# correct logic once, and cross-checks the number of suites that actually ran against the
-# canonical set in test/ so a suite silently going missing shows up as AMBER, not green.
-#
-# Usage:
-#   ./bin/run-tests.sh                      # run all suites, full RAG + count cross-check
-#   ./bin/run-tests.sh -f test_utf8         # run one suite (no count cross-check)
-#   ./bin/run-tests.sh -e native            # override env (default: coverage)
-#   ./bin/run-tests.sh --quiet              # only print the final RESULT line
-#
-# Exit codes: 0 = GREEN, 1 = RED, 2 = AMBER.
-#
-# The final line is machine-readable, e.g.:
-#   RESULT: GREEN 19/19 suites passed
-#   RESULT: AMBER 17/19 suites ran (missing: test_radio test_serial) — all that ran passed
-#   RESULT: RED test_traffic_management: 1 failed  (or: build/crash error)
-#   RESULT: RED sanitizer fault — SUMMARY: AddressSanitizer: 1272 byte(s) leaked  (tests may have
-#           all passed; the coverage build aborts at exit on an ASan/LSan fault — often shown only
-#           as [ERRORED]/SIGHUP. The script names it and points at running the binary bare.)
-
-set -uo pipefail
-
-SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
-ROOT_DIR="$(cd "$SCRIPT_DIR/.." && pwd)"
-cd "$ROOT_DIR"
-
-ENV="coverage"
-FILTER=""
-QUIET=false
-PASSTHRU=()
-
-while [[ $# -gt 0 ]]; do
-	case "$1" in
-	-f)
-		FILTER="$2"
-		PASSTHRU+=("-f" "$2")
-		shift 2
-		;;
-	-e)
-		ENV="$2"
-		shift 2
-		;;
-	--quiet)
-		QUIET=true
-		shift
-		;;
-	*)
-		PASSTHRU+=("$1")
-		shift
-		;;
-	esac
-done
-
-# Locate pio (PATH, then the standard PlatformIO venv).
-PIO="$(command -v pio || command -v platformio || echo "$HOME/.platformio/penv/bin/pio")"
-if [[ ! -x $PIO ]] && ! command -v "$PIO" >/dev/null 2>&1; then
-	echo "RESULT: RED pio not found (looked in PATH and ~/.platformio/penv/bin)"
-	exit 1
-fi
-
-LOG="$(mktemp -t meshtest.XXXXXX.log)"
-MARKER=""
-PROGRESS_PID=""
-trap 'rm -f "$LOG" "${MARKER:-}"; [[ -n ${PROGRESS_PID:-} ]] && kill "$PROGRESS_PID" 2>/dev/null' EXIT
-
-# Canonical suite set = the directories in test/. This is the source of truth for
-# "what should run"; a filtered run only expects its filtered suite.
-mapfile -t ALL_SUITES < <(find test -maxdepth 1 -type d -name 'test_*' -printf '%f\n' | sort)
-EXPECTED_COUNT=${#ALL_SUITES[@]}
-
-# Cached object-count for this env, written after each completed build (in the gitignored build
-# dir). Used as the progress denominator: accurate for a full rebuild (every object recompiles),
-# only a rough upper bound for an incremental run.
-BASELINE_FILE=".pio/build/${ENV}/.runtests-objcount"
-
-# Progress trail file (gitignored build dir). ALWAYS written so a backgrounded/piped run can be
-# checked mid-build with `tail -f` — that's the whole point: don't fly blind on a 20-min rebuild.
-PROGRESS_FILE=".pio/build/${ENV}/.runtests-progress"
-
-# --- Progress heartbeat ------------------------------------------------------
-# Emit ONE status line every few seconds: build = objects (re)compiled this run / cached total +
-# best-effort ETA; test = suites finished / expected. Appends to $PROGRESS_FILE always (tail it to
-# check on a backgrounded run); also live-updates the tty when $5=1 (interactive --quiet). Never
-# touches $LOG, which is parsed for the verdict, so piped/CI captures stay clean.
-progress_monitor() {
-	local marker="$1" objtotal="$2" testtotal="$3" pfile="$4" totty="$5" start now el done ran eta line
-	start=$(date +%s)
-	while :; do
-		now=$(date +%s)
-		el=$((now - start))
-		if grep -q 'Testing\.\.\.' "$LOG" 2>/dev/null; then
-			ran=$(grep -cE "${ENV}:test_[a-z0-9_]+ \[(PASSED|FAILED|ERRORED)\]" "$LOG" 2>/dev/null)
-			line=$(printf '[test] %s/%s suites done — %dm%02ds' "$ran" "$testtotal" $((el / 60)) $((el % 60)))
-		else
-			done=$(find ".pio/build/${ENV}" -name '*.o' -newer "$marker" 2>/dev/null | wc -l)
-			if ((objtotal > 0 && done > 0)); then
-				eta=$((objtotal > done ? (objtotal - done) * el / done : 0))
-				line=$(printf '[build] %d/%d objs — %dm%02ds — ETA ~%dm%02ds' \
-					"$done" "$objtotal" $((el / 60)) $((el % 60)) $((eta / 60)) $((eta % 60)))
-			else
-				# done==0 (incremental: nothing to rebuild yet) or no cached baseline — no ETA yet.
-				line=$(printf '[build] %d objs compiled — %dm%02ds' "$done" $((el / 60)) $((el % 60)))
-			fi
-		fi
-		printf '%s\n' "$line" >>"$pfile" 2>/dev/null                           # file trail (always)
-		[[ $totty == 1 ]] && printf '\r\033[K%s' "$line" >/dev/tty 2>/dev/null # live line (human)
-		sleep 4
-	done
-}
-
-# Launch the heartbeat for every run. It writes the progress file unconditionally; the live tty
-# line only when interactive AND --quiet (where pio's own output is hidden — otherwise pio's
-# streamed compile lines already show progress and a \r line would just fight them).
-mkdir -p ".pio/build/${ENV}" 2>/dev/null || true
-: >"$PROGRESS_FILE" 2>/dev/null || true
-MARKER="$(mktemp -t meshtest-mark.XXXXXX)"
-TOTTY=0
-{ $QUIET && [[ -t 1 ]]; } && TOTTY=1
-progress_monitor "$MARKER" "$(cat "$BASELINE_FILE" 2>/dev/null || echo 0)" \
-	"$([[ -n $FILTER ]] && echo 1 || echo "$EXPECTED_COUNT")" "$PROGRESS_FILE" "$TOTTY" &
-PROGRESS_PID=$!
-
-if ! $QUIET; then
-	echo "Running: $PIO test -e $ENV ${PASSTHRU[*]-} (expecting $EXPECTED_COUNT suites)"
-fi
-echo "progress: tail -f $PROGRESS_FILE" >&2
-
-# Run pio, tee to log. PIPESTATUS[0] is pio's real exit (NOT tee's).
-if $QUIET; then
-	"$PIO" test -e "$ENV" "${PASSTHRU[@]}" >"$LOG" 2>&1
-else
-	"$PIO" test -e "$ENV" "${PASSTHRU[@]}" 2>&1 | tee "$LOG"
-fi
-PIO_RC=${PIPESTATUS[0]}
-
-# Stop the heartbeat, clear its line, and cache this build's object total for next time.
-if [[ -n $PROGRESS_PID ]]; then
-	kill "$PROGRESS_PID" 2>/dev/null
-	wait "$PROGRESS_PID" 2>/dev/null
-	PROGRESS_PID=""
-	# Clear the live line only if we were writing one — opening /dev/tty when there is none is
-	# itself a redirect-open error the trailing 2>/dev/null cannot suppress.
-	[[ $TOTTY == 1 ]] && printf '\r\033[K' >/dev/tty 2>/dev/null
-fi
-[[ -d ".pio/build/${ENV}" ]] && find ".pio/build/${ENV}" -name '*.o' 2>/dev/null | wc -l >"$BASELINE_FILE" 2>/dev/null || true
-
-# --- Outcome detection -------------------------------------------------------
-# The SAME outcome is spelled differently depending on which layer emitted the line — this is
-# the trap that produces false greens (grepping ":PASS" misses pio's "[PASSED]", grepping
-# "[FAILED]" misses Unity's ":FAIL:"). So every regex below matches BOTH spellings:
-#   pass:  Unity per-assertion ":PASS"   | pio per-suite "[PASSED]"      | summary "N succeeded"
-#   fail:  Unity per-assertion ":FAIL:"  | pio per-suite "[FAILED]"      | summary "M failed"
-#   error: pio build/crash "[ERRORED]"   | Unity "M Failures"            | compiler "error:"
-# Match \b after :PASS/:FAIL so ":PASSED"/":FAILED" forms are also caught either way.
-FAIL_RE=':FAIL\b|\[FAILED\]|\[ERRORED\]|[1-9][0-9]* failed|[0-9]+ Tests [1-9][0-9]* Failures|error:|undefined reference|Segmentation fault|terminate called|SIGHUP|SIGSEGV|SIGABRT'
-# Positive proof tests actually ran & passed (absence != success). Accept any pass spelling:
-# the per-test/per-suite tokens OR a success summary line.
-PASS_RE=':PASS\b|\[PASSED\]|test cases: *[0-9]+ succeeded|[0-9]+ Tests 0 Failures'
-# Sanitizer (ASan/LSan/UBSan/TSan) fault signatures. The coverage build is sanitizer-instrumented
-# and aborts NON-ZERO at exit on a fault — most often a LeakSanitizer leak — AFTER every test has
-# already printed [PASSED]. pio then reports [ERRORED]/SIGHUP with no :FAIL: anywhere, so it
-# masquerades as a phantom "N-1 of N succeeded". See .notes/test-passfail-filter.md.
-# Match only real FAULT lines, never the benign "AddressSanitizer: failed to intercept '...'"
-# startup noise that prints on every sanitizer run (it'd mislabel a normal [FAILED] as a leak).
-# Formats per LLVM/Google sanitizer docs: ASan/LSan emit "==PID==ERROR: <San>: ...", UBSan emits
-# "file:line:col: runtime error: ...", TSan emits "WARNING: ThreadSanitizer: ..."; all close with
-# a "SUMMARY: <San>: ..." line (LSan-under-ASan reports its SUMMARY as "AddressSanitizer").
-SAN_RE='(ERROR|WARNING): (Address|Leak|Thread|UndefinedBehavior)Sanitizer:|SUMMARY: (Address|Leak|Thread|UndefinedBehavior)Sanitizer:|Direct leak of|Indirect leak of|detected memory leaks|heap-use-after-free|heap-buffer-overflow|stack-buffer-overflow|attempting double-free|LeakSanitizer has encountered a fatal error|runtime error:'
-
-# Suites that produced a per-suite verdict. pio emits "coverage:test_x [PASSED|FAILED|ERRORED]";
-# a SKIPPED suite (hardware-only on native) is "accounted for" too, so it doesn't read as missing.
-mapfile -t RAN_SUITES < <(grep -oE "${ENV}:test_[a-z0-9_]+ \[(PASSED|FAILED|ERRORED)\]" "$LOG" |
-	sed -E "s/^${ENV}:(test_[a-z0-9_]+) .*/\1/" | sort -u)
-RAN_COUNT=${#RAN_SUITES[@]}
-# Suites pio explicitly skipped (don't count these as "missing" in the canonical cross-check).
-mapfile -t SKIPPED_SUITES < <(grep -oE "${ENV}:test_[a-z0-9_]+.*\bSKIPPED\b" "$LOG" |
-	grep -oE "test_[a-z0-9_]+" | sort -u)
-
-verdict_red() {
-	local detail bin
-	detail="$(grep -nE '\[FAILED\]|:FAIL:|\[ERRORED\]' "$LOG" | head -3 | sed 's/^/    /')"
-	echo ""
-	echo "RED — failures detected:"
-	[[ -n $detail ]] && echo "$detail"
-	grep -E 'test cases:' "$LOG" | tail -1 | sed 's/^/    /'
-
-	# Path to the test binary for the "run it bare" hint. For native/coverage the test program is
-	# the env executable (e.g. .pio/build/coverage/meshtasticd), NOT a file named 'program'.
-	bin="$(find ".pio/build/${ENV}" -maxdepth 1 -type f -executable ! -name '*.so' 2>/dev/null | head -1)"
-	[[ -z $bin ]] && bin=".pio/build/${ENV}/<program>  (build it first: $PIO test -e ${ENV} ${FILTER:+-f $FILTER} --without-testing)"
-
-	# Sanitizer fault (ASan/LSan/UBSan/TSan): name the real cause instead of "build/crash error".
-	if grep -qE "$SAN_RE" "$LOG"; then
-		grep -nE "$SAN_RE" "$LOG" | head -4 | sed 's/^/    /'
-		echo "    -> sanitizer fault: if every test above is PASS, this is an exit-time abort, not a failed assertion."
-		echo "    -> read the full report by running the binary BARE (gdb hides it via ptrace): ./$bin 2>&1 | tail -40"
-		echo "RESULT: RED sanitizer fault — $(grep -ohE 'SUMMARY: [A-Za-z]+Sanitizer:.*' "$LOG" | tail -1 || echo 'see report above')"
-		exit 1
-	fi
-
-	# All tests passed but the process still aborted at EXIT (ERRORED/SIGHUP/SIGABRT) and the
-	# sanitizer report was swallowed by the runner (often surfaced only as SIGHUP). Almost always a
-	# sanitizer fault — point at how to surface it rather than calling it a generic crash.
-	if grep -qE "$PASS_RE" "$LOG" && grep -qE '\[ERRORED\]|SIGHUP|SIGABRT' "$LOG" && ! grep -qE ':FAIL\b|\[FAILED\]' "$LOG"; then
-		echo "    -> all tests passed but the process aborted at EXIT — likely an ASan/LSan fault whose report"
-		echo "       the runner swallowed (commonly shown as SIGHUP). Run the binary BARE to see it: ./$bin 2>&1 | tail -40"
-		echo "RESULT: RED exit-time abort (tests passed; likely sanitizer — see hint above)"
-		exit 1
-	fi
-
-	echo "RESULT: RED $(grep -oE '[0-9]+ failed' "$LOG" | tail -1 || echo 'build/crash error')"
-	exit 1
-}
-
-# RED: pio non-zero, any failure marker, or no positive summary at all (build died early).
-if [[ $PIO_RC -ne 0 ]] || grep -qE "$FAIL_RE" "$LOG"; then
-	verdict_red
-fi
-if ! grep -qE "$PASS_RE" "$LOG"; then
-	echo ""
-	echo "RESULT: RED no success summary found (build error / no tests ran?) — see log"
-	exit 1
-fi
-
-# AMBER: everything that ran passed, but (full run only) a canonical suite neither ran NOR was
-# explicitly skipped — i.e. it silently went missing. SKIPPED suites are accounted for.
-ACCOUNTED_COUNT=$((RAN_COUNT + ${#SKIPPED_SUITES[@]}))
-if [[ -z $FILTER && $ACCOUNTED_COUNT -lt $EXPECTED_COUNT ]]; then
-	missing=()
-	for s in "${ALL_SUITES[@]}"; do
-		printf '%s\n' "${RAN_SUITES[@]}" "${SKIPPED_SUITES[@]}" | grep -qx "$s" || missing+=("$s")
-	done
-	echo ""
-	echo "RESULT: AMBER ${RAN_COUNT}/${EXPECTED_COUNT} suites ran (missing: ${missing[*]}) — all that ran passed"
-	exit 2
-fi
-
-# GREEN.
-if [[ -n $FILTER ]]; then
-	echo "RESULT: GREEN ${RAN_COUNT} suite(s) passed (filtered: $FILTER)"
-else
-	echo "RESULT: GREEN ${RAN_COUNT}/${EXPECTED_COUNT} suites passed"
-fi
-exit 0

bin/shame.py

@@ -0,0 +1,95 @@
+import sys
+import os
+import json
+from github import Github
+
+def parseFile(path):
+    with open(path, "r") as f:
+        data = json.loads(f)
+    for file in data["files"]:
+        if file["name"].endswith(".bin"):
+            return file["name"], file["bytes"]
+
+if len(sys.argv) != 4:
+    print(f"expected usage: {sys.argv[0]} <PR number> <path to old-manifests> <path to new-manifests>")
+    sys.exit(1)
+
+pr_number = int(sys.argv[1])
+
+token = os.getenv("GITHUB_TOKEN")
+if not token:
+    raise EnvironmentError("GITHUB_TOKEN not found in environment.")
+
+repo_name = os.getenv("GITHUB_REPOSITORY")  # "owner/repo"
+if not repo_name:
+    raise EnvironmentError("GITHUB_REPOSITORY not found in environment.")
+
+oldFiles = sys.argv[2]
+old = set(os.path.join(oldFiles, f) for f in os.listdir(oldFiles) if os.path.isfile(f))
+newFiles = sys.argv[3]
+new = set(os.path.join(newFiles, f) for f in os.listdir(newFiles) if os.path.isfile(f))
+
+startMarkdown = "# Target Size Changes\n\n"
+markdown = ""
+
+newlyIntroduced = new - old
+if len(newlyIntroduced) > 0:
+    markdown += "## Newly Introduced Targets\n\n"
+    # create a table
+    markdown += "| File | Size |\n"
+    markdown += "| ---- | ---- |\n"
+    for f in newlyIntroduced:
+        name, size = parseFile(f)
+        markdown += f"| `{name}` | {size}b |\n"
+
+# do not log removed targets
+# PRs only run a small subset of builds, so removed targets are not meaningful
+# since they are very likely to just be not ran in PR CI
+
+both = old & new
+degradations = []
+improvements = []
+for f in both:
+    oldName, oldSize = parseFile(f)
+    _, newSize = parseFile(f)
+    if oldSize != newSize:
+        if newSize < oldSize:
+            improvements.append((oldName, oldSize, newSize))
+        else:
+            degradations.append((oldName, oldSize, newSize))
+
+if len(degradations) > 0:
+    markdown += "\n## Degradation\n\n"
+    # create a table
+    markdown += "| File | Difference | Old Size | New Size |\n"
+    markdown += "| ---- | ---------- | -------- | -------- |\n"
+    for oldName, oldSize, newSize in degradations:
+        markdown += f"| `{oldName}` | **{oldSize - newSize}b** | {oldSize}b | {newSize}b |\n"
+
+if len(improvements) > 0:
+    markdown += "\n## Improvement\n\n"
+    # create a table
+    markdown += "| File | Difference | Old Size | New Size |\n"
+    markdown += "| ---- | ---------- | -------- | -------- |\n"
+    for oldName, oldSize, newSize in improvements:
+        markdown += f"| `{oldName}` | **{oldSize - newSize}b** | {oldSize}b | {newSize}b |\n"
+
+if len(markdown) == 0:
+    markdown = "No changes in target sizes detected."
+
+g = Github(token)
+repo = g.get_repo(repo_name)
+pr = repo.get_pull(pr_number)
+
+existing_comment = None
+for comment in pr.get_issue_comments():
+    if comment.body.startswith(startMarkdown):
+        existing_comment = comment
+        break
+
+final_markdown = startMarkdown + markdown
+
+if existing_comment:
+    existing_comment.edit(body=final_markdown)
+else:
+    pr.create_issue_comment(body=final_markdown)

bin/size_report.py

@@ -1,171 +0,0 @@
-#!/usr/bin/env python3
-
-"""Compare firmware size reports and generate a markdown summary.
-
-Usage:
-    size_report.py <new_sizes.json> [--baseline <label>:<old_sizes.json>]...
-
-Examples:
-    # Compare PR against develop and master baselines
-    size_report.py pr.json --baseline develop:develop.json --baseline master:master.json
-
-    # Single baseline comparison
-    size_report.py pr.json --baseline develop:develop.json
-
-    # No baselines — shows sizes with blank delta columns
-    size_report.py pr.json
-"""
-
-import argparse
-import json
-import sys
-
-
-def load_sizes(path):
-    with open(path) as f:
-        return json.load(f)
-
-
-def format_delta(n):
-    """Format byte delta with sign and human-friendly suffix."""
-    sign = "+" if n > 0 else ""
-    if abs(n) >= 1024:
-        return f"{sign}{n:,} ({sign}{n / 1024:.1f} KB)"
-    return f"{sign}{n:,}"
-
-
-def generate_markdown(new_sizes, baselines, top_n=5):
-    """Generate a single table with current size and delta columns per baseline.
-
-    baselines: list of (label, old_sizes_dict), may be empty
-    """
-    labels = [label for label, _ in baselines]
-
-    # Build rows: (board, current_size, [(delta, abs_delta) per baseline])
-    rows = []
-    for board in sorted(new_sizes):
-        current = new_sizes[board]
-        deltas = []
-        for _, old_sizes in baselines:
-            old = old_sizes.get(board)
-            if old is not None:
-                d = current - old
-                deltas.append((d, abs(d)))
-            else:
-                deltas.append((None, 0))
-        # Sort key: max abs delta across baselines (biggest changes first)
-        max_abs = max((ad for _, ad in deltas), default=0)
-        rows.append((board, current, deltas, max_abs))
-
-    rows.sort(key=lambda r: r[3], reverse=True)
-
-    # Summary line
-    sections = []
-    summary_parts = [f"{len(new_sizes)} targets"]
-    for i, (label, old_sizes) in enumerate(baselines):
-        increases = sum(
-            1 for _, _, deltas, _ in rows if deltas[i][0] is not None and deltas[i][0] > 0
-        )
-        decreases = sum(
-            1 for _, _, deltas, _ in rows if deltas[i][0] is not None and deltas[i][0] < 0
-        )
-        net = sum(
-            deltas[i][0] for _, _, deltas, _ in rows if deltas[i][0] is not None
-        )
-        parts = []
-        if increases:
-            parts.append(f"{increases} increased")
-        if decreases:
-            parts.append(f"{decreases} decreased")
-        if parts:
-            parts.append(f"net {format_delta(net)}")
-            summary_parts.append(f"vs `{label}`: {', '.join(parts)}")
-        else:
-            summary_parts.append(f"vs `{label}`: no changes")
-
-    if not baselines:
-        summary_parts.append("no baseline available yet")
-
-    sections.append(f"**{' | '.join(summary_parts)}**\n")
-
-    # Table header
-    header = "| Target | Size |"
-    separator = "|--------|-----:|"
-    for label in labels:
-        header += f" vs `{label}` |"
-        separator += "----------:|"
-    sections.append(header)
-    sections.append(separator)
-
-    def format_row(board, current, deltas):
-        row = f"| `{board}` | {current:,} |"
-        for d, _ in deltas:
-            if d is None:
-                row += " |"
-            elif d == 0:
-                row += " 0 |"
-            else:
-                icon = "📈" if d > 0 else "📉"
-                row += f" {icon} {format_delta(d)} |"
-        return row
-
-    # Top N rows always visible
-    top = rows[:top_n]
-    for board, current, deltas, _ in top:
-        sections.append(format_row(board, current, deltas))
-
-    # Remaining rows in expandable section
-    rest = rows[top_n:]
-    if rest:
-        sections.append("")
-        sections.append(
-            f"<details><summary>Show {len(rest)} more target(s)</summary>\n"
-        )
-        sections.append(header)
-        sections.append(separator)
-        for board, current, deltas, _ in rest:
-            sections.append(format_row(board, current, deltas))
-        sections.append("\n</details>")
-
-    sections.append("")
-    return "\n".join(sections)
-
-
-def main():
-    parser = argparse.ArgumentParser(description="Compare firmware size reports")
-    parser.add_argument("new_sizes", help="Path to new sizes JSON")
-    parser.add_argument(
-        "--baseline",
-        action="append",
-        default=[],
-        metavar="LABEL:PATH",
-        help="Baseline to compare against (e.g. develop:develop.json)",
-    )
-    parser.add_argument(
-        "--top",
-        type=int,
-        default=5,
-        help="Number of top changes to show before collapsing (default: 5)",
-    )
-    args = parser.parse_args()
-
-    new_sizes = load_sizes(args.new_sizes)
-
-    # Silence output when no targets were built — repo maintainer choice
-    if not new_sizes:
-        return
-
-    baselines = []
-    for b in args.baseline:
-        if ":" not in b:
-            print(f"Error: baseline must be LABEL:PATH, got '{b}'", file=sys.stderr)
-            sys.exit(1)
-        label, path = b.split(":", 1)
-        baselines.append((label, load_sizes(path)))
-
-    md = generate_markdown(new_sizes, baselines, top_n=args.top)
-    print(md)
-
-
-if __name__ == "__main__":
-    main()

bin/test_size_scripts.py

@@ -1,262 +0,0 @@
-#!/usr/bin/env python3
-
-"""Tests for bin/collect_sizes.py and bin/size_report.py."""
-
-import json
-import os
-import subprocess
-import sys
-import tempfile
-
-SCRIPTS_DIR = os.path.join(os.path.dirname(__file__), "..", "bin")
-
-
-def make_manifest(target, firmware_bytes, extra_files=None):
-    """Create a minimal .mt.json manifest dict."""
-    files = [{"name": f"firmware-{target}-2.6.0.bin", "bytes": firmware_bytes}]
-    if extra_files:
-        files.extend(extra_files)
-    return {
-        "platformioTarget": target,
-        "version": "2.6.0.test",
-        "files": files,
-    }
-
-
-def write_manifests(tmpdir, manifests):
-    """Write manifest dicts as .mt.json files into tmpdir."""
-    for target, data in manifests.items():
-        path = os.path.join(tmpdir, f"firmware-{target}.mt.json")
-        with open(path, "w") as f:
-            json.dump(data, f)
-
-
-def run_script(script, args):
-    """Run a Python script and return (returncode, stdout, stderr)."""
-    result = subprocess.run(
-        [sys.executable, os.path.join(SCRIPTS_DIR, script)] + args,
-        capture_output=True,
-        text=True,
-    )
-    return result.returncode, result.stdout, result.stderr
-
-
-def test_collect_sizes_basic():
-    """collect_sizes picks up firmware-*.bin entries from manifests."""
-    with tempfile.TemporaryDirectory() as tmpdir:
-        outfile = os.path.join(tmpdir, "sizes.json")
-        manifests = {
-            "heltec-v3": make_manifest("heltec-v3", 1048576),
-            "rak4631": make_manifest("rak4631", 524288),
-            "tbeam": make_manifest("tbeam", 786432),
-        }
-        write_manifests(tmpdir, manifests)
-
-        rc, stdout, stderr = run_script("collect_sizes.py", [tmpdir, outfile])
-        assert rc == 0, f"collect_sizes failed: {stderr}"
-        assert "3 targets" in stdout
-
-        with open(outfile) as f:
-            sizes = json.load(f)
-        assert sizes == {"heltec-v3": 1048576, "rak4631": 524288, "tbeam": 786432}
-
-
-def test_collect_sizes_fallback_bin():
-    """collect_sizes falls back to non-firmware-prefixed .bin if no firmware-*.bin."""
-    with tempfile.TemporaryDirectory() as tmpdir:
-        outfile = os.path.join(tmpdir, "sizes.json")
-        # Manifest with only a generic .bin (no firmware- prefix)
-        data = {
-            "platformioTarget": "custom-board",
-            "files": [
-                {"name": "littlefs-custom-board.bin", "bytes": 100000},
-                {"name": "custom-board.bin", "bytes": 500000},
-            ],
-        }
-        path = os.path.join(tmpdir, "firmware-custom-board.mt.json")
-        with open(path, "w") as f:
-            json.dump(data, f)
-
-        rc, stdout, stderr = run_script("collect_sizes.py", [tmpdir, outfile])
-        assert rc == 0, f"collect_sizes failed: {stderr}"
-
-        with open(outfile) as f:
-            sizes = json.load(f)
-        assert sizes == {"custom-board": 500000}
-
-
-def test_collect_sizes_skips_ota_littlefs():
-    """collect_sizes ignores ota/littlefs/bleota .bin files in fallback."""
-    with tempfile.TemporaryDirectory() as tmpdir:
-        outfile = os.path.join(tmpdir, "sizes.json")
-        data = {
-            "platformioTarget": "board-x",
-            "files": [
-                {"name": "littlefs-board-x.bin", "bytes": 100000},
-                {"name": "bleota-board-x.bin", "bytes": 50000},
-                {"name": "mt-board-x-ota.bin", "bytes": 60000},
-            ],
-        }
-        path = os.path.join(tmpdir, "firmware-board-x.mt.json")
-        with open(path, "w") as f:
-            json.dump(data, f)
-
-        rc, stdout, stderr = run_script("collect_sizes.py", [tmpdir, outfile])
-        assert rc == 0
-        with open(outfile) as f:
-            sizes = json.load(f)
-        # No valid firmware .bin found, board should be absent
-        assert sizes == {}
-
-
-def test_collect_sizes_ignores_non_mt_json():
-    """collect_sizes skips non .mt.json files."""
-    with tempfile.TemporaryDirectory() as tmpdir:
-        outfile = os.path.join(tmpdir, "sizes.json")
-        # Write a valid manifest
-        manifests = {"rak4631": make_manifest("rak4631", 500000)}
-        write_manifests(tmpdir, manifests)
-        # Write a decoy file
-        with open(os.path.join(tmpdir, "readme.txt"), "w") as f:
-            f.write("not a manifest")
-
-        rc, stdout, stderr = run_script("collect_sizes.py", [tmpdir, outfile])
-        assert rc == 0
-        with open(outfile) as f:
-            sizes = json.load(f)
-        assert list(sizes.keys()) == ["rak4631"]
-
-
-def test_size_report_no_baseline():
-    """size_report with no baselines shows sizes only."""
-    with tempfile.TemporaryDirectory() as tmpdir:
-        sizes_file = os.path.join(tmpdir, "new.json")
-        with open(sizes_file, "w") as f:
-            json.dump({"heltec-v3": 1000000, "rak4631": 500000}, f)
-
-        rc, stdout, stderr = run_script("size_report.py", [sizes_file])
-        assert rc == 0, f"size_report failed: {stderr}"
-        assert "2 targets" in stdout
-        assert "no baseline available yet" in stdout
-        assert "`heltec-v3`" in stdout
-        assert "`rak4631`" in stdout
-
-
-def test_size_report_with_baseline():
-    """size_report shows deltas against a baseline."""
-    with tempfile.TemporaryDirectory() as tmpdir:
-        new_file = os.path.join(tmpdir, "new.json")
-        old_file = os.path.join(tmpdir, "old.json")
-        with open(new_file, "w") as f:
-            json.dump({"heltec-v3": 1050000, "rak4631": 500000, "tbeam": 800000}, f)
-        with open(old_file, "w") as f:
-            json.dump({"heltec-v3": 1000000, "rak4631": 500000, "tbeam": 810000}, f)
-
-        rc, stdout, stderr = run_script(
-            "size_report.py", [new_file, "--baseline", f"develop:{old_file}"]
-        )
-        assert rc == 0, f"size_report failed: {stderr}"
-        assert "3 targets" in stdout
-        assert "1 increased" in stdout
-        assert "1 decreased" in stdout
-        # heltec-v3 grew by 50000
-        assert "📈" in stdout
-        # tbeam shrank by 10000
-        assert "📉" in stdout
-        # rak4631 unchanged
-        assert "vs `develop`" in stdout
-
-
-def test_size_report_multiple_baselines():
-    """size_report handles multiple baselines."""
-    with tempfile.TemporaryDirectory() as tmpdir:
-        new_file = os.path.join(tmpdir, "new.json")
-        dev_file = os.path.join(tmpdir, "develop.json")
-        master_file = os.path.join(tmpdir, "master.json")
-        with open(new_file, "w") as f:
-            json.dump({"board-a": 100000}, f)
-        with open(dev_file, "w") as f:
-            json.dump({"board-a": 95000}, f)
-        with open(master_file, "w") as f:
-            json.dump({"board-a": 90000}, f)
-
-        rc, stdout, stderr = run_script(
-            "size_report.py",
-            [new_file, "--baseline", f"develop:{dev_file}", "--baseline", f"master:{master_file}"],
-        )
-        assert rc == 0, f"size_report failed: {stderr}"
-        assert "vs `develop`" in stdout
-        assert "vs `master`" in stdout
-
-
-def test_size_report_new_target_no_baseline_entry():
-    """size_report handles targets not present in baseline (new boards)."""
-    with tempfile.TemporaryDirectory() as tmpdir:
-        new_file = os.path.join(tmpdir, "new.json")
-        old_file = os.path.join(tmpdir, "old.json")
-        with open(new_file, "w") as f:
-            json.dump({"new-board": 300000, "existing": 500000}, f)
-        with open(old_file, "w") as f:
-            json.dump({"existing": 500000}, f)
-
-        rc, stdout, stderr = run_script(
-            "size_report.py", [new_file, "--baseline", f"develop:{old_file}"]
-        )
-        assert rc == 0, f"size_report failed: {stderr}"
-        assert "`new-board`" in stdout
-        assert "no changes" in stdout  # only existing is compared, delta=0
-
-
-def test_size_report_all_unchanged():
-    """size_report shows 'no changes' when all sizes match."""
-    with tempfile.TemporaryDirectory() as tmpdir:
-        sizes_file = os.path.join(tmpdir, "sizes.json")
-        with open(sizes_file, "w") as f:
-            json.dump({"board-a": 100000, "board-b": 200000}, f)
-
-        rc, stdout, stderr = run_script(
-            "size_report.py", [sizes_file, "--baseline", f"develop:{sizes_file}"]
-        )
-        assert rc == 0, f"size_report failed: {stderr}"
-        assert "no changes" in stdout
-
-
-def test_collect_sizes_bad_args():
-    """collect_sizes exits with error on wrong arg count."""
-    rc, stdout, stderr = run_script("collect_sizes.py", [])
-    assert rc == 1
-    assert "Usage" in stderr
-
-
-def test_size_report_bad_baseline_format():
-    """size_report exits with error on malformed --baseline."""
-    with tempfile.TemporaryDirectory() as tmpdir:
-        sizes_file = os.path.join(tmpdir, "sizes.json")
-        with open(sizes_file, "w") as f:
-            json.dump({"x": 1}, f)
-
-        rc, stdout, stderr = run_script(
-            "size_report.py", [sizes_file, "--baseline", "no-colon-here"]
-        )
-        assert rc == 1
-        assert "LABEL:PATH" in stderr
-
-
-if __name__ == "__main__":
-    tests = [v for k, v in globals().items() if k.startswith("test_")]
-    passed = 0
-    failed = 0
-    for test in tests:
-        try:
-            test()
-            print(f"  PASS: {test.__name__}")
-            passed += 1
-        except AssertionError as e:
-            print(f"  FAIL: {test.__name__}: {e}")
-            failed += 1
-        except Exception as e:
-            print(f"  ERROR: {test.__name__}: {type(e).__name__}: {e}")
-            failed += 1
-
-    print(f"\n{passed} passed, {failed} failed out of {passed + failed}")
-    sys.exit(1 if failed else 0)

boards/heltec_mesh_node_t1.json

@@ -1,54 +0,0 @@
-{
-  "build": {
-    "arduino": {
-      "ldscript": "nrf52840_s140_v6.ld"
-    },
-    "core": "nRF5",
-    "cpu": "cortex-m4",
-    "extra_flags": "-DNRF52840_XXAA",
-    "f_cpu": "64000000L",
-    "hwids": [
-      ["0x239A", "0x4405"],
-      ["0x239A", "0x0029"],
-      ["0x239A", "0x002A"],
-      ["0x2886", "0x1667"]
-    ],
-    "usb_product": "HT-n5262",
-    "mcu": "nrf52840",
-    "variant": "heltec_mesh_node_t1",
-    "variants_dir": "variants",
-    "bsp": {
-      "name": "adafruit"
-    },
-    "softdevice": {
-      "sd_flags": "-DS140",
-      "sd_name": "s140",
-      "sd_version": "6.1.1",
-      "sd_fwid": "0x00B6"
-    },
-    "bootloader": {
-      "settings_addr": "0xFF000"
-    }
-  },
-  "connectivity": ["bluetooth"],
-  "debug": {
-    "jlink_device": "nRF52840_xxAA",
-    "onboard_tools": ["jlink"],
-    "svd_path": "nrf52840.svd",
-    "openocd_target": "nrf52840-mdk-rs"
-  },
-  "frameworks": ["arduino"],
-  "name": "Heltec Mesh Node T1",
-  "upload": {
-    "maximum_ram_size": 248832,
-    "maximum_size": 815104,
-    "speed": 115200,
-    "protocol": "nrfutil",
-    "protocols": ["jlink", "nrfjprog", "nrfutil", "stlink"],
-    "use_1200bps_touch": true,
-    "require_upload_port": true,
-    "wait_for_upload_port": true
-  },
-  "url": "https://heltec.org",
-  "vendor": "Heltec"
-}

boards/heltec_mesh_tower_v2.json

@@ -1,54 +0,0 @@
-{
-  "build": {
-    "arduino": {
-      "ldscript": "nrf52840_s140_v6.ld"
-    },
-    "core": "nRF5",
-    "cpu": "cortex-m4",
-    "extra_flags": "-DNRF52840_XXAA",
-    "f_cpu": "64000000L",
-    "hwids": [
-      ["0x239A", "0x4405"],
-      ["0x239A", "0x0029"],
-      ["0x239A", "0x002A"],
-      ["0x239A", "0x0071"]
-    ],
-    "usb_product": "HT-n5262",
-    "mcu": "nrf52840",
-    "variant": "heltec_mesh_tower_v2",
-    "variants_dir": "variants",
-    "bsp": {
-      "name": "adafruit"
-    },
-    "softdevice": {
-      "sd_flags": "-DS140",
-      "sd_name": "s140",
-      "sd_version": "6.1.1",
-      "sd_fwid": "0x00B6"
-    },
-    "bootloader": {
-      "settings_addr": "0xFF000"
-    }
-  },
-  "connectivity": ["bluetooth"],
-  "debug": {
-    "jlink_device": "nRF52840_xxAA",
-    "onboard_tools": ["jlink"],
-    "svd_path": "nrf52840.svd",
-    "openocd_target": "nrf52840-mdk-rs"
-  },
-  "frameworks": ["arduino"],
-  "name": "Heltec MeshTower V2 (Adafruit BSP)",
-  "upload": {
-    "maximum_ram_size": 248832,
-    "maximum_size": 815104,
-    "speed": 115200,
-    "protocol": "nrfutil",
-    "protocols": ["jlink", "nrfjprog", "nrfutil", "stlink"],
-    "use_1200bps_touch": true,
-    "require_upload_port": true,
-    "wait_for_upload_port": true
-  },
-  "url": "https://heltec.org",
-  "vendor": "Heltec"
-}

boards/wiscore_rak4600.json

@@ -0,0 +1,50 @@
+{
+  "build": {
+    "arduino": {
+      "ldscript": "nrf52832_s132_v6.ld"
+    },
+    "core": "nRF5",
+    "cpu": "cortex-m4",
+    "extra_flags": "-DNRF52832_XXAA -DNRF52",
+    "f_cpu": "64000000L",
+    "hwids": [
+      ["0x239A", "0x8029"],
+      ["0x239A", "0x0029"],
+      ["0x239A", "0x002A"],
+      ["0x239A", "0x802A"]
+    ],
+    "usb_product": "Feather nRF52832 Express",
+    "mcu": "nrf52832",
+    "variant": "WisCore_RAK4600_Board",
+    "bsp": {
+      "name": "adafruit"
+    },
+    "softdevice": {
+      "sd_flags": "-DS132",
+      "sd_name": "s132",
+      "sd_version": "6.1.1",
+      "sd_fwid": "0x00B7"
+    },
+    "zephyr": {
+      "variant": "nrf52_adafruit_feather"
+    }
+  },
+  "connectivity": ["bluetooth"],
+  "debug": {
+    "jlink_device": "nRF52832_xxAA",
+    "svd_path": "nrf52.svd",
+    "openocd_target": "nrf52840-mdk-rs"
+  },
+  "frameworks": ["arduino", "zephyr"],
+  "name": "Adafruit Bluefruit nRF52832 Feather",
+  "upload": {
+    "maximum_ram_size": 65536,
+    "maximum_size": 524288,
+    "require_upload_port": true,
+    "speed": 115200,
+    "protocol": "nrfutil",
+    "protocols": ["jlink", "nrfjprog", "nrfutil", "stlink"]
+  },
+  "url": "https://www.adafruit.com/product/3406",
+  "vendor": "Adafruit"
+}

debian/control

@@ -14,7 +14,6 @@ Build-Depends: debhelper-compat (= 13),
                g++,
                pkg-config,
                libyaml-cpp-dev,
-               libjsoncpp-dev,
                libgpiod-dev,
                libbluetooth-dev,
                libusb-1.0-0-dev,

docs/lora_region_preset_compatibility_client_spec.md

@@ -1,277 +0,0 @@
-# LoRa Region → Preset Compatibility — Client Implementation Spec
-
-**Status:** Draft for 2.8 · **Audience:** Meshtastic client app developers (Android first,
-Apple second, then web/python) · **Firmware side:** implemented in `firmware`
-(`FromRadio.region_presets`, see below).
-
-> This document lives in the firmware repo while the feature is developed. It is meant to
-> graduate to `meshtastic/protobufs` (and/or the docs site) alongside the upstream protobuf
-> PR that reserves `FromRadio` field **19**.
-
----
-
-## 1. Why this exists
-
-For 2.8 the LoRa regions and modem presets were reworked. **Not every modem preset is legal
-in every region** — narrow EU SRD bands, the EU 868 "narrow" band, amateur/ham bands, and
-the 2.4 GHz band each accept only a specific subset of presets. The firmware already
-enforces this internally (it clamps or rejects illegal combinations), but until now a client
-had no way to _know_ the rules, so a user could pick an illegal region+preset pair in the UI
-and only discover the problem after the device silently corrected it.
-
-This feature has the firmware **declare the legal region→preset combinations** to the client
-during the `want_config` handshake, so the client UI can constrain the preset picker to the
-valid set for the currently selected region (and warn about licensed-only bands). It is
-purely advisory metadata — the firmware remains the source of truth and still
-validates/clamps on its own.
-
----
-
-## 2. Protocol additions
-
-Three new messages in `meshtastic/mesh.proto`, plus one new `FromRadio` oneof variant.
-
-### 2.1 `FromRadio.region_presets` (field 19)
-
-```proto
-message FromRadio {
-  uint32 id = 1;
-  oneof payload_variant {
-    // ... fields 2..18 unchanged ...
-    LoRaRegionPresetMap region_presets = 19;
-  }
-}
-```
-
-### 2.2 Messages
-
-```proto
-// A distinct set of legal modem presets shared by one or more LoRa regions.
-message LoRaPresetGroup {
-  repeated Config.LoRaConfig.ModemPreset presets = 1;       // legal presets for this group
-  Config.LoRaConfig.ModemPreset         default_preset = 2; // always one of `presets`
-  bool                                  licensed_only = 3;  // ham/amateur band → warn/gate
-}
-
-// Associates a single LoRa region with its preset group (by index).
-message LoRaRegionPresets {
-  Config.LoRaConfig.RegionCode region = 1;
-  uint32                       group_index = 2; // index into LoRaRegionPresetMap.groups
-}
-
-// The full map, delivered grouped to fit one FromRadio packet.
-message LoRaRegionPresetMap {
-  repeated LoRaPresetGroup    groups = 1;        // each distinct preset list
-  repeated LoRaRegionPresets  region_groups = 2; // every known region → a group index
-}
-```
-
-### 2.3 Why grouped (and the size envelope clients should respect)
-
-A `FromRadio` packet is capped at **512 bytes** (`MAX_TO_FROM_RADIO_SIZE`). Most regions
-share one identical preset list (the "standard" 9-preset list), so the map is delivered
-**grouped**: `groups` holds each _distinct_ preset list once, and `region_groups` maps every
-known region to one of those groups by index. This keeps the encoded size additive
-(`groups` + `region_groups`) rather than multiplicative, well under the cap.
-
-nanopb (firmware) array bounds — clients do **not** need to enforce these, but they bound
-what you can receive:
-
-| field                               | max_count                            |
-| ----------------------------------- | ------------------------------------ |
-| `LoRaRegionPresetMap.groups`        | 8                                    |
-| `LoRaRegionPresetMap.region_groups` | 38 (= number of `RegionCode` values) |
-| `LoRaPresetGroup.presets`           | 11                                   |
-
----
-
-## 3. When it is delivered
-
-`region_presets` is sent **once** during the `want_config` handshake, as a single
-`FromRadio` message, in this position:
-
-```text
-my_info → (deviceuiConfig) → node_info(self) → metadata → region_presets → channel… → config… → moduleConfig… → node_info(others)… → fileInfo… → config_complete_id → (live packets)
-```
-
-i.e. **immediately after `metadata` and before the first `channel`**.
-
-- It is included for a normal full `want_config` and for the **config-only** nonce.
-- It is **omitted** for the **nodes-only** nonce (that path skips metadata/config entirely).
-- A client must **not** assume it always arrives (see §5).
-
----
-
-## 4. Decoding into a usable lookup
-
-Flatten the grouped wire form into `Map<RegionCode, RegionPresetInfo>`:
-
-```text
-struct RegionPresetInfo { Set<ModemPreset> presets; ModemPreset default; bool licensedOnly }
-
-fun decode(map: LoRaRegionPresetMap): Map<RegionCode, RegionPresetInfo> {
-  result = {}
-  for (rg in map.region_groups) {
-    if (rg.group_index >= map.groups.size) continue   // defensive: malformed/forward data
-    g = map.groups[rg.group_index]
-    result[rg.region] = RegionPresetInfo(
-      presets = g.presets.toSet(),
-      default = g.default_preset,
-      licensedOnly = g.licensed_only)
-  }
-  return result
-}
-```
-
-Persist this map alongside the rest of the downloaded config so the LoRa config screen can
-read it synchronously.
-
----
-
-## 5. Semantics & rules (the load-bearing part)
-
-These rules are what keep the UX correct across firmware versions. Implement all of them.
-
-1. **Absent region ⇒ no constraint.** If a `RegionCode` does not appear in `region_groups`,
-   the client has _no_ compatibility info for it and **must not restrict** its preset
-   choices (fall back to allowing the full `ModemPreset` list). This happens for a handful
-   of `RegionCode` enum values that have no firmware band table entry (today: `EU_874`,
-   `EU_917`, `ITU1_70CM`, `ITU2_70CM`, `ITU3_70CM`).
-
-2. **Absent message ⇒ no constraint.** Firmware older than 2.8 never sends `region_presets`.
-   New clients **must** tolerate the message being absent entirely and keep their existing
-   (unconstrained) behavior. Do not block the config screen waiting for it.
-
-3. **`default_preset`** is always a member of that group's `presets`. Use it to pre-select a
-   preset when the user switches to a region whose valid set does not include the currently
-   selected preset (instead of leaving an illegal selection or guessing).
-
-4. **`licensed_only`** marks ham/amateur bands. Surface a warning or gate (the firmware also
-   requires the operator's `is_licensed` flag for these regions; coordinate the two so the
-   user isn't allowed to pick a licensed band without acknowledging licensing).
-
-5. **EU region auto-swap caveat.** The firmware treats the EU sibling regions
-   (`EU_868` / `EU_866` / `EU_N_868`) specially: if the user is in one of them and selects a
-   preset that belongs to a sibling's list, the firmware **swaps the region** rather than
-   rejecting the preset. Consequence for clients: **do not assume the region is immutable
-   across a preset change** — after an admin config write, re-read the resulting
-   `LoRaConfig` and reflect the (possibly changed) region back into the UI.
-
-6. **Use it as a UI guard, not a validator of truth.** The firmware still validates/clamps
-   on its own. The map exists to prevent the user from _selecting_ an illegal combo; it is
-   not a security or correctness boundary.
-
----
-
-## 6. UI/UX recommendations
-
-- In the LoRa config screen, when a region is selected, **filter/enable the modem-preset
-  picker to that region's `presets`** (when `use_preset`/`use_modem_preset` is on).
-- If the current preset is not in the newly selected region's set, switch the selection to
-  that region's `default_preset`.
-- Show a **licensed badge / confirmation** for regions where `licensed_only == true`.
-- If a region is absent from the map (rule §5.1) or the whole message is absent (§5.2),
-  render the full preset list as before — never show an empty picker.
-
----
-
-## 7. Forward / backward compatibility
-
-- **Old clients, new firmware:** an unknown `FromRadio` oneof variant (field 19) is ignored
-  by protobuf/nanopb decoders; the relative ordering of the known messages is unchanged, so
-  existing apps are unaffected.
-- **New clients, old firmware:** message simply never arrives → treat as "no constraints"
-  (§5.2).
-- **Enum growth:** new `RegionCode`/`ModemPreset` values may appear over time. Decoders
-  should pass through unknown enum values rather than crashing; an unknown region in
-  `region_groups` is harmless (the client just won't have a localized name for it).
-
----
-
-## 8. Platform notes
-
-> Verified against the `main` branch of each repo. Both have been refactored away from
-> older layouts; re-pin file paths against a specific commit if you need them durable.
-
-### 8.1 Android — `meshtastic/Meshtastic-Android` (Kotlin / Compose, KMP)
-
-- **Protobufs are a published Maven artifact, _not_ a submodule.** Declared in
-  `gradle/libs.versions.toml` (`org.meshtastic:protobufs`, currently `2.7.25`); generated
-  package is **`org.meshtastic.proto`**. **A `region_presets`-aware build requires a new
-  published `org.meshtastic:protobufs` release**, then bumping that one version string.
-- **The protobufs are Wire-generated**, so the `FromRadio` oneof is **not** a
-  `payloadVariantCase` enum — each arm is a **nullable field**. Handle the new variant in
-  `FromRadioPacketHandlerImpl.handleFromRadio(...)`
-  (`core/data/.../manager/FromRadioPacketHandlerImpl.kt`) by adding a
-  `regionPresets != null -> …` arm to the existing `when { … }`, delegating to a handler
-  (mirror `handleLocalMetadata` / `handleConfigComplete`).
-- **State holder:** expose the decoded map from `RadioConfigRepository` /
-  `RadioConfigRepositoryImpl` as a `Flow` (mirroring `localConfigFlow`/`channelSetFlow`),
-  consumed by `feature/settings/.../radio/RadioConfigViewModel.kt`.
-- **UI:** the region & preset dropdowns are `DropDownPreference`s in
-  `feature/settings/.../radio/component/LoRaConfigItemList.kt` (public composable
-  `LoRaConfigScreen`). Gate/filter the `ChannelOption` (preset) dropdown by the selected
-  `RegionInfo`'s entry in the map.
-
-### 8.2 Apple — `meshtastic/Meshtastic-Apple` (Swift / SwiftUI)
-
-- **Protobufs are vendored** into a local Swift package `MeshtasticProtobufs`
-  (`MeshtasticProtobufs/Sources/meshtastic/*.pb.swift`), generated from the `protobufs` git
-  submodule via `scripts/gen_protos.sh`. **To get field 19:** advance the `protobufs`
-  submodule, run `scripts/gen_protos.sh`, commit the regenerated `.pb.swift` + submodule
-  pointer. (No published-artifact dependency — Apple can regenerate from any commit.)
-- **Dispatch:** `AccessoryManager.processFromRadio(_:)`
-  (`Meshtastic/Accessory/Accessory Manager/AccessoryManager.swift`) is a real
-  `switch decodedInfo.payloadVariant { … }` — add a `.regionPresets` case, with the handler
-  in `AccessoryManager+FromRadio.swift` (mirror `handleConfig` / `handleMetadata`).
-- **Persistence:** config is **SwiftData** (`@Model` entities), upserted via
-  `MeshPackets`/`UpdateSwiftData.swift`. Store the decoded map (e.g. on a settings/connection
-  model) so the LoRa view can read it.
-- **UI:** `Meshtastic/Views/Settings/Config/LoRaConfig.swift` (`struct LoRaConfig: View`)
-  has the `Picker("Region", …)` (`RegionCodes.userSelectable`) and `Picker("Presets", …)`
-  (`ModemPresets.userSelectable`, gated on `usePreset`). Filter the presets picker by the
-  selected region's entry. Enums live in `Meshtastic/Enums/LoraConfigEnums.swift`.
-
-### 8.3 Other clients
-
-- **python (`meshtastic` / Meshtastic-python)** and **web** consume the published protobufs;
-  they will see `region_presets` once their protobuf dependency includes field 19, and can
-  ignore it until then (it decodes as an unknown field).
-
----
-
-## 9. Reference payload (current firmware table)
-
-For decoder unit tests. With the 2.8 region table, the firmware emits **6 groups**. Group
-indices are assigned in region-table order (first region to use a profile creates its group),
-so they are stable as listed here:
-
-| group_index             | default_preset | licensed_only | presets                                                                                                        |
-| ----------------------- | -------------- | ------------- | -------------------------------------------------------------------------------------------------------------- |
-| 0 (standard)            | `LONG_FAST`    | false         | LONG_FAST, LONG_SLOW, MEDIUM_SLOW, MEDIUM_FAST, SHORT_SLOW, SHORT_FAST, LONG_MODERATE, SHORT_TURBO, LONG_TURBO |
-| 1 (EU 868)              | `LONG_FAST`    | false         | LONG_FAST, LONG_SLOW, MEDIUM_SLOW, MEDIUM_FAST, SHORT_SLOW, SHORT_FAST, LONG_MODERATE                          |
-| 2 (EU 866 SRD / "lite") | `LITE_FAST`    | false         | LITE_FAST, LITE_SLOW                                                                                           |
-| 3 (EU 868 narrow)       | `NARROW_SLOW`  | false         | NARROW_FAST, NARROW_SLOW                                                                                       |
-| 4 (ham 20 kHz)          | `TINY_FAST`    | **true**      | TINY_FAST, TINY_SLOW                                                                                           |
-| 5 (ham 100 kHz)         | `NARROW_SLOW`  | **true**      | NARROW_FAST, NARROW_SLOW                                                                                       |
-
-`region_groups` (region → group_index):
-
-| group | regions                                                                                                                                                               |
-| ----- | --------------------------------------------------------------------------------------------------------------------------------------------------------------------- |
-| 0     | US, EU_433, CN, JP, ANZ, ANZ_433, RU, KR, TW, IN, NZ_865, TH, UA_433, UA_868, MY_433, MY_919, SG_923, PH_433, PH_868, PH_915, KZ_433, KZ_863, NP_865, BR_902, LORA_24 |
-| 1     | EU_868                                                                                                                                                                |
-| 2     | EU_866                                                                                                                                                                |
-| 3     | EU_N_868                                                                                                                                                              |
-| 4     | ITU1_2M, ITU2_2M, ITU3_2M                                                                                                                                             |
-| 5     | ITU2_125CM                                                                                                                                                            |
-
-> Note groups **3** and **5** carry the same preset list (NARROW\_\*) but are distinct groups
-> because they differ in `licensed_only`. Decoders must key on the group, not on the preset
-> list, to preserve the licensing flag.
->
-> Regions **absent** from the table (no constraint info; see §5.1): `EU_874`, `EU_917`,
-> `ITU1_70CM`, `ITU2_70CM`, `ITU3_70CM`.
-
-This table is generated from the firmware's region table at runtime; treat the firmware as
-authoritative and these values as the expected snapshot for the 2.8 table.

docs/nexthop-routing-reliability.md

@@ -1,456 +0,0 @@
-# NextHop direct-message reliability on dense meshes — findings & plan
-
-**Status:** Implemented — mitigations and tests in `PR3-tmm-nexthop`
-**Date:** 2026-06-13
-**Area:** `src/mesh` router stack (`NextHopRouter`, `ReliableRouter`, `FloodingRouter`, `Router`, `NodeDB`, `PacketHistory`)
-**Constraint:** No over-the-air / wire-format changes — `next_hop` and `relay_node` stay 1 byte, no `PacketHeader` changes, no breaking protobuf changes. All new state is RAM-only.
-
-This document captures the analysis and the proposed mitigations so the work can be
-continued on this branch by anyone. It is intentionally code-grounded (file:line
-references throughout) and standalone — you should not need the original investigation
-context to pick it up.
-
----
-
-## TL;DR
-
-NextHop routing for direct messages (DMs) is unreliable on dense meshes. The headline
-cause is the **birthday problem**: `next_hop` and `relay_node` are each a single byte
-(the last byte of a 32-bit node number), so on a mesh of N nodes the probability that
-two share the same byte hits ~50% at **~19 nodes** and is near-certain by 50–100. But
-there are **other, equally important issues**: that single byte is trusted blindly at
-five different code sites, learned routes **never decay**, routes are learned from the
-**reverse (ACK) path** (asymmetric-link hazard), and collision-driven spurious
-rebroadcasts **amplify congestion** exactly when the mesh is busy.
-
-Because we can't widen the on-wire field, the fix is **interpretation-side** ("don't
-trust a byte that doesn't map to a unique reachable neighbor — flood instead") plus
-**recovery-side** ("decay stale/failing routes so they get re-discovered"). Four
-mitigations, M1–M4, all RAM-only. The net behavioral change: on dense/mobile meshes a
-DM that today silently misroutes or black-holes instead falls back to managed flooding
-(which still delivers) and re-learns a fresh route quickly. Sparse-mesh happy paths are
-unchanged.
-
----
-
-## How NextHop routing works today (mechanics)
-
-Inheritance chain: `Router` → `FloodingRouter` → `NextHopRouter` → `ReliableRouter`.
-
-**The single-byte identifiers.** Both routing bytes come from one helper:
-
-```cpp
-// src/mesh/NodeDB.h:255
-uint8_t getLastByteOfNodeNum(NodeNum num) { return (uint8_t)((num & 0xFF) ? (num & 0xFF) : 0xFF); }
-```
-
-It projects a 32-bit node number onto 255 values (`0x00` is remapped to `0xFF` so it
-never collides with the `0`-valued sentinels `NO_NEXT_HOP_PREFERENCE` / `NO_RELAY_NODE`,
-`src/mesh/MeshTypes.h:44-46`). `next_hop` and `relay_node` in the packet header are
-`uint8_t` (`src/mesh/mesh.pb.h`, comments "Last byte of the node number…"). The learned
-route stored per destination, `meshtastic_NodeInfoLite::next_hop`, is also a single byte
-(`src/mesh/generated/meshtastic/deviceonly.pb.h:83`).
-
-**Sending a DM** — `NextHopRouter::send` (`src/mesh/NextHopRouter.cpp:23`):
-
-1. `p->relay_node = getLastByteOfNodeNum(getNodeNum())` (mark ourselves as relayer).
-2. `p->next_hop = getNextHop(p->to, p->relay_node)` (`src/mesh/NextHopRouter.cpp:192`):
-   look up `nodeDB->getMeshNode(to)->next_hop`; return it unless it equals the relayer
-   byte; otherwise `NO_NEXT_HOP_PREFERENCE` (→ flood).
-
-**Relaying** — `NextHopRouter::perhapsRebroadcast` (`src/mesh/NextHopRouter.cpp:133`):
-rebroadcast iff `next_hop == NO_NEXT_HOP_PREFERENCE` (flood) **or**
-`next_hop == getLastByteOfNodeNum(getNodeNum())` (we are the addressed next hop)
-(`:147`). Each node only ever compares against **its own** byte.
-
-**Learning** — `NextHopRouter::sniffReceived` (`src/mesh/NextHopRouter.cpp:89`): on an
-ACK/reply (`request_id`/`reply_id` set), if the relayer of the ACK was also a relayer of
-the original packet (validated via `PacketHistory::checkRelayers`), set
-`origTx->next_hop = p->relay_node` (`:114`). I.e. the **forward** next-hop is learned
-from the **reverse** path's relayer.
-
-**Retransmission / fallback** — `NextHopRouter::doRetransmissions`
-(`src/mesh/NextHopRouter.cpp:284`). Budgets: `NUM_RELIABLE_RETX=3` (originator: initial
-
-- 2 retries), `NUM_INTERMEDIATE_RETX=2` (relayer: 1 retry). On the **last** retry
-  (`numRetransmissions==1`) it resets `next_hop` to `NO_NEXT_HOP_PREFERENCE` on the packet
-  **and** clears `sentTo->next_hop` in NodeDB, then floods (`:313-321`). Retransmit timing
-  comes from `iface->getRetransmissionMsec`, whose contention window **grows with channel
-  utilization** (`src/mesh/RadioInterface.cpp` `getTxDelayMsec`/`getTxDelayMsecWeighted`).
-
-**Dedup / relayer history** — `PacketHistory` (`src/mesh/PacketHistory.cpp`): a bounded
-ring (`PACKETHISTORY_MAX = max(MAX_NUM_NODES*2, 100)`, 20 B/record) keyed by
-`(sender,id)`, tracking up to `NUM_RELAYERS=6` relayer **bytes** per packet in
-`relayed_by[]`. `wasRelayer` (`:490`) and `checkRelayers` (`:517`) match bytes against
-that array.
-
----
-
-## Root-cause analysis
-
-### 1. The single byte is trusted blindly at five sites (the birthday problem)
-
-| #   | Site                             | File:line                   | Failure on collision                                                                                                      |
-| --- | -------------------------------- | --------------------------- | ------------------------------------------------------------------------------------------------------------------------- |
-| 1   | Rebroadcast self-check           | `NextHopRouter.cpp:147`     | A remote "impostor" node sharing the intended next-hop's byte also rebroadcasts → wasted airtime / congestion.            |
-| 2   | Route learning                   | `NextHopRouter.cpp:111-114` | Stores an ambiguous byte as the route; later resolves to the wrong physical node.                                         |
-| 3   | Relayer validation               | `PacketHistory.cpp:490-538` | `wasRelayer(byte)` returns true for the wrong node → mis-validated ACK / mis-learn.                                       |
-| 4   | Favorite-router hop preservation | `Router.cpp:120-145`        | **First** NodeDB node whose last byte matches wins — non-deterministic; can preserve hops for the wrong relay (hop leak). |
-| 5   | Send-path lookup                 | `NextHopRouter.cpp:192-207` | Emits a byte that may address the wrong node; no check it still maps to a reachable neighbor.                             |
-
-Collision math (uniform last byte over 255 buckets): P(collision) ≈ 50% at ~19 nodes,
-
-> 99% by ~75 nodes. Dense meshes are squarely in the "always colliding" regime.
-
-### 2. Stale routes never decay
-
-The learned `next_hop` byte is cleared only on the **current DM's** last retry
-(`NextHopRouter.cpp:313-321`). A route learned hours ago that has since gone dead is
-still trusted on the **next** DM's first attempt — which on a congested mesh is also the
-slowest attempt. Result: silent black-hole at a dead hop until the retransmission budget
-drains, then a late flood. Intermediate nodes hold stale routes indefinitely.
-
-### 3. Reverse-path (asymmetric-link) learning
-
-`origTx->next_hop` is learned from the ACK's relayer (`NextHopRouter.cpp:110-114`) — the
-**reverse** direction. RF links are frequently asymmetric, so the best reverse relay can
-be a poor forward relay. Worse, the next reverse ACK immediately re-learns the same bad
-hop, so the route **flaps** back to the bad value even after a failure reset.
-
-### 4. Congestion amplification
-
-Collision-driven impostor rebroadcasts (issue 1) add airtime; the contention window
-grows with channel utilization, so retransmit intervals **lengthen** exactly when the
-mesh is busy. The 3-try reliable budget can then expire before delivery. On dense
-meshes, efficiency _is_ reliability.
-
-### Note: pubkey-derived node numbers (develop / 2.8) — does not change the plan
-
-develop derives the node number from the public key:
-`my_node_num = crc32Buffer(public_key)` (`src/mesh/NodeDB.cpp:481`), re-derived on key
-change in `createNewIdentity()` (`src/mesh/NodeDB.cpp:3113`). This **reinforces** the
-plan rather than changing it:
-
-- **Birthday problem unchanged and now textbook-exact.** CRC32 mixes well → the last
-  byte is uniformly distributed over 256 values. Derivation adds no wire bits.
-- **Node numbers are now immutable / identity-bound.** Pre-2.8 `pickNewNodeNum()` could
-  renumber a node to dodge a conflict; now the number is fixed by the key, so a last-byte
-  collision **cannot be resolved operationally by renumbering** → M1/M2/M3 become _more_
-  necessary.
-- **Resolver gets cleaner inputs.** Stable node numbers keep a learned byte bound to one
-  identity (good for M3 freshness). `createNewIdentity()` retires the old entry by marking
-  it **ignored** and clearing its pubkey (`src/mesh/NodeDB.cpp:3123-3125`), which M1's
-  candidate gate already skips — so key rotation can't pollute resolution.
-- **No wire-free disambiguation unlocked.** A receiver still gets only 1 byte and cannot
-  recover which full node number a colliding value meant — so "detect ambiguity → flood"
-  remains the correct strategy.
-
----
-
-## Proposed mitigations
-
-Key insight for all of M1/M2: **a 1-byte ID only needs to be unique among a node's
-direct neighbors / plausible relays, not the whole mesh.** That candidate set is small
-(typically 5–15), so a byte usually resolves unambiguously there; when it doesn't, fall
-back to the _safe_ behavior (flood / decrement / don't-learn).
-
-### M1 — Ambiguity-aware last-byte resolution (new NodeDB primitive)
-
-New types + methods in `src/mesh/NodeDB.h` (near line 255) / `src/mesh/NodeDB.cpp`
-(near `getMeshNode`, ~2936):
-
-```cpp
-enum class LastByteResolution : uint8_t { None, Unique, Ambiguous };
-struct ResolvedNode { LastByteResolution status = LastByteResolution::None; NodeNum num = 0; };
-
-// Resolve a single on-wire last-byte to a unique full NodeNum among relevant candidates.
-ResolvedNode resolveLastByte(uint8_t lastByte, bool requireDirectNeighbor);
-// Convenience: true iff exactly one relevant candidate (Ambiguous and None both -> false = SAFE).
-bool resolveUniqueLastByte(uint8_t lastByte, bool requireDirectNeighbor, NodeNum *outNum = nullptr);
-```
-
-- **One linear pass** over `meshNodes`, reusing `getNumMeshNodes()`/`getMeshNodeByIndex()`,
-  the bitfield helpers (`nodeInfoLiteIsFavorite/HasUser/IsIgnored`), `sinceLastSeen()`,
-  and `getLastByteOfNodeNum()`. **Early-exit** on the 2nd match (return `Ambiguous`).
-- **Guard:** `if (lastByte == 0) return {None, 0};` (covers `NO_RELAY_NODE` / MQTT-invalid).
-- **Candidate gate** (skip): `num == getNodeNum()` (never resolve to ourselves), `num == 0`,
-  `num == NODENUM_BROADCAST`, `nodeInfoLiteIsIgnored`. Then match
-  `getLastByteOfNodeNum(node->num) == lastByte` (cheapest test last, mirroring `Router.cpp:119`).
-- **Relevance gate:**
-  - `requireDirectNeighbor == true` (strict, for SEND): `has_hops_away && hops_away == 0`
-    **and** `sinceLastSeen(node) < NEXTHOP_NEIGHBOR_FRESH_SECS`.
-  - `requireDirectNeighbor == false` (lenient, for learn / hop-preserve): accept if direct
-    neighbor **or** `nodeInfoLiteIsFavorite` **or** role ∈ {ROUTER, ROUTER_LATE, CLIENT_BASE}.
-- **No tie-break.** A collision must return `Ambiguous` — picking "best SNR" would
-  resurrect the silent-misroute bug. (Deliberate non-goal; document in code.)
-
-New constant in `src/mesh/MeshTypes.h` (near line 44):
-`#define NEXTHOP_NEIGHBOR_FRESH_SECS (60 * 60 * 2)` (mirrors `NUM_ONLINE_SECS`).
-
-### M2 — Only route on bytes that resolve to a unique, reachable neighbor
-
-In `getNextHop` (`src/mesh/NextHopRouter.cpp:192-207`), after the existing split-horizon
-check (`node->next_hop != relay_node`), require the stored byte to resolve to a **unique,
-currently-fresh direct neighbor**; else flood:
-
-```cpp
-if (node->next_hop != relay_node) {
-    ResolvedNode r = nodeDB->resolveLastByte(node->next_hop, /*requireDirectNeighbor=*/true);
-    if (r.status == LastByteResolution::Unique) return node->next_hop;
-    LOG_WARN("Next hop 0x%x for 0x%x %s -> flood", node->next_hop, to,
-             r.status == LastByteResolution::Ambiguous ? "ambiguous among neighbors" : "no longer a neighbor");
-    return std::nullopt;
-}
-```
-
-This self-heals when a neighbor goes away (unicast-into-a-void becomes a flood). It
-applies to originating, relaying, and retrying, since all route through `getNextHop`.
-
-Apply M1's safe fallback at the other sites:
-
-- **Learning** (`NextHopRouter.cpp:111-114`): gate `origTx->next_hop = p->relay_node` on
-  `resolveUniqueLastByte(p->relay_node, /*direct=*/false)`. Ambiguous/unknown → don't
-  learn (leave route unset → flood).
-- **Favorite-router preservation** (`Router.cpp:120-145`): replace the "first match wins"
-  loop with `resolveUniqueLastByte(p->relay_node, /*direct=*/false)` + a re-check that the
-  resolved node is favorite/has_user/router. Ambiguous/none/not-favorite → **decrement**
-  (safe). Net: removes one full DB scan, adds one resolver scan (wash).
-
-**Left unchanged, by design (document why in code):**
-
-- **Site 1** rebroadcast self-check (`NextHopRouter.cpp:147`) and self-identity checks
-  (`ReliableRouter.cpp:127`): a node matches its **own** byte — no DB resolution helps. A
-  remote impostor sharing the intended next-hop's byte will still rebroadcast. M1/M2
-  shrink the blast radius by reducing how often an ambiguous byte is ever stored or
-  originated; a true fix needs a wider field (out of scope). **This is the one residual
-  the plan cannot fully close.**
-- **Site 3** `wasRelayer`/`checkRelayers` (`PacketHistory.cpp:490-538`): intentionally
-  byte-domain (both sides are on-wire bytes); the consumer (learning) is now hardened.
-  Add a one-line comment; do not change.
-
-### M3 — Route freshness / failure memory (RAM table on NextHopRouter)
-
-A bounded, LRU-evicted table keyed by destination, mirroring `PacketHistory`'s
-reuse-oldest discipline (not an unbounded map) to cap RAM.
-
-`src/mesh/NextHopRouter.h` (near `pending`, line 99):
-
-```cpp
-struct RouteHealth {
-    NodeNum dest = 0;                  // 0 == empty slot
-    uint32_t learnedAtMsec = 0;        // millis() at last (re)learn; rollover-aware
-    uint8_t consecutiveFailures = 0;
-    uint8_t lastNextHop = NO_NEXT_HOP_PREFERENCE; // byte this health refers to
-};
-static constexpr uint8_t ROUTE_HEALTH_MAX = 32;   // ~384B; drop to 16 if RAM-tight
-RouteHealth routeHealth[ROUTE_HEALTH_MAX] = {};
-// Helpers take `now` (pure/testable): findRouteHealth, getOrAllocRouteHealth,
-// noteRouteLearned, noteRouteSuccess, noteRouteFailure, isRouteStale, clearRouteHealth
-```
-
-Policy:
-
-| Constant                  | Value  | Rationale                                                                                                                                              |
-| ------------------------- | ------ | ------------------------------------------------------------------------------------------------------------------------------------------------------ |
-| `ROUTE_TTL_MSEC`          | 30 min | Survives a normal conversation; re-discovers a moved node within a telemetry interval.                                                                 |
-| `ROUTE_FAILURE_THRESHOLD` | 3      | 1–2 consecutive failures are transient LoRa collisions; 3 to the same hop = dead. Accumulates **across** DMs (independent of the per-DM 3-try budget). |
-
-`isRouteStale(h, now)` = `(now - h.learnedAtMsec) >= ROUTE_TTL_MSEC || h.consecutiveFailures >= ROUTE_FAILURE_THRESHOLD`.
-All age math uses **unsigned subtraction** (rollover-safe, matching
-`PacketHistory.cpp:364`); treat `learnedAtMsec == 0` as "set now".
-
-Wiring (as built — `src/mesh/NextHopRouter.cpp`, `src/mesh/ReliableRouter.cpp`):
-
-- `getNextHop`: if a health record matches the stored byte and `isRouteStale`, clear
-  `node->next_hop` (NodeDB) **and** `clearRouteHealth`, return `nullopt` (flood). No
-  record yet (cold path, first DM after boot) → trust NodeDB, but the M2 strict-neighbor
-  gate still applies.
-- `sniffReceived` learn: gate the write through `resolveUniqueLastByte` (M2), then
-  `noteRouteLearned(p->from, p->relay_node, millis())` — resets `consecutiveFailures`
-  **only if the hop changed** (anti-flap for asymmetric re-learn); otherwise just refreshes
-  `learnedAtMsec`. (No success signal is taken on the intermediate reverse-pass: an ACK
-  merely passing through us is not proof that _we_ delivered, and resetting failures there
-  would reintroduce the asymmetric flap.)
-- `doRetransmissions`: on the last-retransmission branch (`numRetransmissions == 1`, the
-  point a directed delivery has gone un-ACKed for both originator and intermediate) →
-  `noteRouteFailure(to)`, then the existing NodeDB `next_hop` reset + flood. We deliberately
-  do **not** `clearRouteHealth` here: keeping the record is what lets the failure count
-  accumulate across DMs so a flapping reverse-path-relearned dead hop eventually ages out.
-- `ReliableRouter::sniffReceived` ACK path → `noteRouteSuccess(getFrom(p), millis())`
-  (an end-to-end ACK addressed to us is genuine forward-delivery proof; clears failures and
-  refreshes freshness). `noteRouteSuccess`/`noteRouteFailure` are no-ops when no record
-  exists, so flood-only destinations never pollute the table.
-
-**Reconciliation (no double-handling):** `doRetransmissions` owns _in-flight_ failure of
-the current DM (reset NodeDB `next_hop` + flood, and bump the cross-DM failure counter);
-`getNextHop` owns _between-DM_ staleness (TTL or failure-threshold → flood + clear). The
-only place that erases a health record is the `getNextHop` decay path; the retransmission
-path leaves it intact so the counter survives a reverse-path re-learn.
-
-### M4 — Earlier flood for unverified routes (gated, off by default)
-
-Compile-gated so healthy sparse meshes are untouched. **Default is off** — the define
-lives in `NextHopRouter.h` and must be flipped to measure:
-`#define NEXTHOP_EARLY_FLOOD_ON_UNVERIFIED 1`.
-
-In `doRetransmissions`, the directed-retry `else` branch: if the route is **not verified**
-(`!findRouteHealth(to) || consecutiveFailures > 0 || isRouteStale`), reset `next_hop` and
-flood on this attempt instead of spending another directed try. A **verified** route
-(record present, `consecutiveFailures == 0`, within TTL — i.e. recently ACKed) takes the
-unchanged directed-retry path, so the sparse-mesh happy path is untouched. Trade-off:
-airtime ↔ latency; the gate ensures we never pay the flood cost on a proven route, only on
-one we already distrust. Off by default precisely so it can be A/B-measured on the
-simulator before broad enable.
-
----
-
-## Files to modify
-
-| File                                        | Change                                                                                                                                               |
-| ------------------------------------------- | ---------------------------------------------------------------------------------------------------------------------------------------------------- |
-| `src/mesh/MeshTypes.h`                      | `NEXTHOP_NEIGHBOR_FRESH_SECS`, `ROUTE_TTL_MSEC`, `ROUTE_FAILURE_THRESHOLD`, `NEXTHOP_EARLY_FLOOD_ON_UNVERIFIED`                                      |
-| `src/mesh/NodeDB.h` / `src/mesh/NodeDB.cpp` | `LastByteResolution`, `ResolvedNode`, `resolveLastByte`, `resolveUniqueLastByte`                                                                     |
-| `src/mesh/NextHopRouter.h`                  | `RouteHealth` + array + helpers; `#ifdef PIO_UNIT_TESTING public:` for helpers and `getNextHop`                                                      |
-| `src/mesh/NextHopRouter.cpp`                | `getNextHop` (M2 gate + M3 decay); `sniffReceived` (learn gate + health seed + success); `doRetransmissions` (failure counting + M4); comment site 1 |
-| `src/mesh/Router.cpp`                       | `shouldDecrementHopLimit` → resolver + favorite/router re-check                                                                                      |
-| `src/mesh/ReliableRouter.cpp`               | ACK path → `noteRouteSuccess`                                                                                                                        |
-| `test/test_nexthop_routing/test_main.cpp`   | **new** unit suite (auto-built under `[env:native]`)                                                                                                 |
-
-**Reuse, don't reinvent:** `getLastByteOfNodeNum`, `sinceLastSeen`, the bitfield helpers,
-`getMeshNodeByIndex`/`getNumMeshNodes`, PacketHistory's reuse-oldest eviction shape, and
-`MockNodeDB::addTestNode` (from `test/test_hop_scaling/test_main.cpp`).
-
----
-
-## Edge cases
-
-- **`0x00`↔`0xFF` projection:** the resolver compares via `getLastByteOfNodeNum` on both
-  sides, so a `…00` node and a `…FF` node correctly collide on `0xFF` → `Ambiguous`. Test
-  explicitly.
-- **MQTT packets:** `relay_node`/`next_hop` are forced invalid when `hop_start == 0`
-  (`src/mesh/RadioLibInterface.cpp:603-605`) → byte 0 → resolver `None` → don't learn
-  (correct).
-- **`has_hops_away == false`** nodes are excluded from the strict gate (never fabricate a
-  Unique neighbor for M2); admitted to the lenient gate only via favorite/router role.
-  Safe; self-corrects once `hops_away` is learned.
-- **Self / broadcast:** the resolver skips `getNodeNum()` and `NODENUM_BROADCAST`;
-  `getNextHop` already early-returns for broadcast.
-- **Perf:** M2 adds one O(N) resolver scan per directed send/relay (early-exit on the 2nd
-  match), cheaper than the crypto already on that path; site-4 is a wash. If ever hot, a
-  future 256-entry last-byte index is the optimization (not now — RAM).
-
----
-
-## Verification (all tiers)
-
-### 1. Native unit tests — new `test/test_nexthop_routing/test_main.cpp`
-
-`pio test -e native -f test_nexthop_routing`; on macOS `./bin/test-native-docker.sh -f test_nexthop_routing`.
-Design the RouteHealth helpers to take `now` as a parameter so the 30-min TTL logic is
-testable without a clock mock.
-
-- **Resolver:** None / Unique / **Ambiguous (birthday collision)** / strict-excludes-stale /
-  strict-excludes-far / lenient-includes-favorite-router / lenient-collision / skips-self /
-  skips-ignored / **`0x00`↔`0xFF` collision** / early-exit.
-- **`getNextHop`:** unique→byte, **ambiguous→nullopt**, stale-neighbor→nullopt,
-  split-horizon (relay==next_hop)→nullopt, broadcast→nullopt.
-- **RouteHealth:** TTL boundary, **rollover** (learn near `0xFFFFFFFF`, check after wrap),
-  failure threshold, success-resets, **re-learn-same-hop keeps fails (anti-flap)**,
-  re-learn-new-hop resets, LRU eviction bound, clear.
-- **Site-4:** preserve on unique favorite router; **decrement on two colliding favorites**;
-  decrement when the resolved node is not a favorite.
-- **Sparse-mesh regression:** all-distinct last bytes → every resolve Unique, `getNextHop`
-  returns the stored byte unchanged (proves no happy-path change).
-- Re-run `test_packet_history` and `test_hop_scaling` for no regression.
-
-### 2. portduino SimRadio simulator
-
-`pio run -e native && ./bin/test-simulator.sh`. Best vehicle for the **intermediate-node**
-path the 2-device bench can't reach. Line topology A — B — C: establish A→C (B learns a
-directed route), stop B relaying that dest, confirm A re-discovers via flood within
-`ROUTE_FAILURE_THRESHOLD` and that B's `noteRouteFailure`/`clearRouteHealth` fires (visible
-via the `LOG_INFO "Route to … stale"` / "Resetting next hop" lines). Use this to A/B M4
-(attempts-to-delivery, total airtime).
-
-### 3. Hardware via meshtastic MCP (auto-detect; 3+ devices for a real hop)
-
-- `mcp-server/tests/mesh/test_nexthop_multihop_recovery.py` — **the multi-hop validator
-  for this work** (added on this branch). Self-discovers an A — relay — C line, asserts a
-  directed DM is delivered across the relay (next_hop + M1/M2/M3 engaged), and asserts
-  delivery recovers after the relay is power-cycled (M3). Skips unless the bench is a true
-  multi-hop line (≥3 roles via `--hub-profile`, endpoints out of direct RF range).
-- `mcp-server/tests/mesh/test_direct_with_ack.py` — happy-path regression: a fresh/unique
-  route still delivers a want_ack DM on the first/second try (M4's gate must keep this
-  green).
-- `mcp-server/tests/mesh/test_peer_offline_recovery.py` — 2-device recovery validator: peer
-  off mid-conversation then back. Must stay green and ideally recover in fewer attempts.
-
-### 4. Build / format sanity
-
-native-macos **and** Docker both ways; trunk clang-format@16.0.3; a release `pio run` to
-confirm the `#ifdef PIO_UNIT_TESTING` visibility widening does **not** leak into
-production; sanity-check RAM headroom on the smallest nRF52 build for the ~384 B table.
-
----
-
-## Verification status (as built on `nexthop-redux`)
-
-| Tier                             | What ran                                                                            | Result              |
-| -------------------------------- | ----------------------------------------------------------------------------------- | ------------------- |
-| Unit (native-macos)              | `test_nexthop_routing` (31 cases)                                                   | ✅ 31/31            |
-| Unit (Docker / Linux, CI parity) | `test_nexthop_routing`                                                              | ✅ 31/31            |
-| Regression                       | `test_packet_history`, `test_hop_scaling`, `test_mqtt`, `test_traffic_management`   | ✅ 105/105          |
-| Build                            | `pio run -e native-macos` (M4 off) and with `-DNEXTHOP_EARLY_FLOOD_ON_UNVERIFIED=1` | ✅ both link        |
-| Format                           | trunk `clang-format@16.0.3`                                                         | ✅ no issues        |
-| Simulator (CI `simulator-tests`) | `meshtasticd -s` + `meshtastic.test.testSimulator()` on native-macos                | ✅ exit 0, no crash |
-
-**Pending (environment-blocked, not yet run):**
-
-- **Multi-hop A–B–C recovery sim** — the `simulator/` broker hub is **not git-tracked**
-  (only stale local `.pyc`), and two `meshtasticd -s` instances can't hear each other
-  without it. The intermediate-node failure-count path and the M4 A/B therefore have unit
-  coverage of their logic but no end-to-end multi-node run yet.
-- **Hardware / multi-hop tier** — a committable bench test now exists:
-  `mcp-server/tests/mesh/test_nexthop_multihop_recovery.py`. It self-discovers a real
-  multi-hop pair (A — relay — C), asserts a directed DM is delivered across the relay, and
-  asserts delivery recovers after the relay is power-cycled (the M3 path). It
-  `pytest.skip`s cleanly unless the bench is a true line with endpoints out of direct RF
-  range (≥3 roles via `--hub-profile`), so it's safe to commit and only asserts when the
-  NextHop path is genuinely exercised. Collected + verified to skip without hardware;
-  not yet run on a bench. `test_direct_with_ack.py` / `test_peer_offline_recovery.py`
-  remain the 2-device happy-path/recovery regressions.
-
----
-
-## Risks & limitations
-
-- **Site-1 impostor rebroadcast** is unfixable without a wider field — documented; M1/M2
-  only shrink its frequency.
-- **Dense meshes flood DMs more often** — intended (a flooded DM arrives; a mis-unicast one
-  black-holes). Call out in the PR so reviewers expect a slightly higher DM flood rate on
-  very dense meshes.
-- **M4 airtime** if the gate is too loose → default conservative + compile-gated +
-  simulator A/B before broad enable.
-- **RAM** ~384 B (32 slots); 16 slots (~192 B) with graceful LRU degradation if tight.
-- **Asymmetric flap** not fully closed (a _new_ bad hop resets the counter); the TTL
-  backstop bounds it. Per-hop failure history is future work (more RAM).
-
----
-
-## How to continue this work (commit sequencing)
-
-Each step is independently testable; land them as separate commits.
-
-1. **M1 resolver + unit tests** — `NodeDB` only; no behavior change until wired. Lands the
-   `resolveLastByte`/`resolveUniqueLastByte` primitive and its full unit-test matrix.
-2. **M2 + wiring + tests** — `getNextHop` strict gate, learning gate, favorite-router
-   preservation rewrite. Adds the `getNextHop` and site-4 tests.
-3. **M3 health table + decay + tests** — RAM `RouteHealth` table, decay-on-read, failure/
-   success accounting, reconciliation with the existing last-retry reset. Adds the
-   route-health unit tests and the simulator recovery check.
-4. **M4 gated tuning** — early-flood-on-unverified behind the compile flag; simulator A/B
-   and hardware regression.
-
-Reference plan (with the same content) was developed at
-`~/.claude/plans/nexthop-routing-for-direct-lexical-shell.md` on the author's machine; this
-in-repo doc is the canonical handoff copy.

extra_scripts/nrf52_lto.py

@@ -1,148 +0,0 @@
-#!/usr/bin/env python3
-# trunk-ignore-all(ruff/F821)
-# trunk-ignore-all(flake8/F821)
-#
-# Whole-image LTO for nrf52840 (~-60KB; ~-23KB beyond src-only LTO), EXCEPT the objects
-# that own interrupt/exception handlers.
-#
-# Every ISR is referenced only from the assembly vector table (gcc_startup_nrf52840.S),
-# which LTO cannot see -> whole-program LTO judges the handlers dead, removes them, and
-# the weak `b .` Default_Handler stubs prevail -> the IRQ lands in an infinite loop and the
-# chip hangs (or the peripheral silently stalls). Compiling the handler-bearing objects
-# WITHOUT LTO lets ordinary linking keep the strong handlers; everything else stays LTO'd:
-#   - framework core (/FrameworkArduino/, /cores/nRF5/): every nrfx ISR + the FreeRTOS
-#     SVC/PendSV port.
-#   - TinyUSB nrf port (Adafruit_TinyUSB_nrf.cpp): USBD_IRQHandler (USB data path).
-#   - library .cpp files that own a vector ISR (would otherwise be silently dropped):
-#       bluefruit.cpp     -> SD_EVT/SWI2_EGU2  (SoftDevice BLE-event delivery -- advertising
-#                            hangs without it)
-#       Wire_nRF52.cpp    -> SPIM0/TWIM0 + SPIM1/TWIM1 (interrupt-driven I2C/SPI)
-#       PDM.cpp           -> PDM_IRQHandler   (PDM microphone)
-#       RotaryEncoder.cpp -> QDEC_IRQHandler  (hardware quadrature/rotary encoder)
-#
-# A post-link guard (bottom of this file) fails the build if a critical handler was dropped
-# anyway -- so a future deps bump or a new ISR-owning library becomes a red build, not a field
-# hang. To hunt a dropped ISR by hand: nm the .elf for `_IRQHandler$` symbols marked `W`, then
-# grep the libs/framework for who defines them.
-#
-# HW-validated: RAK4631 (SX1262) + muzi-base (LR1121).
-import glob
-import os
-
-Import("env")
-
-env.Append(LINKFLAGS=["-flto", "-flto-partition=1to1"])
-
-# The -fno-lto re-compiles below run with the global env, which lacks the framework's
-# bundled-library include dirs -- and those libs cross-include each other (Wire pulls in
-# Adafruit_TinyUSB.h, which pulls in SPI.h, ...). Add every bundled-lib dir (+ its src/) so
-# the re-compiles resolve without chasing headers one at a time.
-_fw = env.PioPlatform().get_package_dir("framework-arduinoadafruitnrf52") or ""
-_extra_inc = []
-for _d in sorted(glob.glob(os.path.join(_fw, "libraries", "*"))):
-    if os.path.isdir(_d):
-        _extra_inc.append(_d)
-        if os.path.isdir(os.path.join(_d, "src")):
-            _extra_inc.append(os.path.join(_d, "src"))
-
-FRAMEWORK = ("/FrameworkArduino/", "/cores/nRF5/")
-USB_ISR = "Adafruit_TinyUSB_nrf"  # USBD_IRQHandler
-# Library .cpp files that define vector-table ISRs (the rest of their lib stays LTO'd):
-LIB_ISR = ("/bluefruit.cpp", "/Wire_nRF52.cpp", "/PDM.cpp", "/RotaryEncoder.cpp")
-
-
-def _no_lto(node):
-    try:
-        path = node.get_abspath()
-    except Exception:
-        path = str(node)
-    path = path.replace(
-        "\\", "/"
-    )  # normalize Windows backslashes so matches work cross-platform
-    if (
-        USB_ISR in path
-        or any(s in path for s in FRAMEWORK)
-        or any(s in path for s in LIB_ISR)
-    ):
-        return env.Object(
-            node,
-            CCFLAGS=env["CCFLAGS"] + ["-fno-lto"],
-            CPPPATH=env["CPPPATH"] + _extra_inc,
-        )
-    return node
-
-
-env.AddBuildMiddleware(_no_lto)
-
-
-# --- post-link guard: catch a dropped ISR handler at build time (CI footgun protection) ----
-# After every link, fail the build if one of these critical vector-table handlers resolved to
-# the weak `b .` Default_Handler stub -- i.e. LTO (or a deps bump, or a new ISR-owning library
-# that nobody added to LIB_ISR) silently dropped it. A dropped handler hangs the chip the
-# instant that IRQ fires; this turns a field hang into a red build. CI builds every nrf52840
-# target, so this runs on every PR automatically. If a board deliberately stops using one of
-# these, edit the tuples on purpose.
-_REQUIRED_STRONG = (
-    "SWI2_EGU2_IRQHandler",  # SoftDevice BLE event (SD_EVT) -- advertising & connections
-    "GPIOTE_IRQHandler",  # GPIO interrupts: radio DIO + buttons
-    "RTC1_IRQHandler",  # FreeRTOS scheduler tick
-)
-# Owned by the TinyUSB stack, so only required when the board builds with USB at all.
-# Boards without native USB wiring (e.g. wio-sdk-wm1110's CH340 UART) strip TinyUSB via
-# disable_adafruit_usb.py / unflagging USE_TINYUSB, leaving these legitimately weak.
-_REQUIRED_STRONG_USB = (
-    "USBD_IRQHandler",  # USB CDC (serial console + 1200bps DFU trigger)
-    "POWER_CLOCK_IRQHandler",  # USB power events (VBUS detect/ready) via TinyUSB hal
-)
-
-_tc = env.PioPlatform().get_package_dir("toolchain-gccarmnoneeabi") or ""
-_NM = os.path.join(_tc, "bin", "arm-none-eabi-nm")
-if not os.path.isfile(_NM):
-    _NM = "arm-none-eabi-nm"  # fall back to PATH
-
-
-def _assert_isr_handlers_survived(source, target, env):
-    import subprocess
-    import sys
-
-    try:
-        # Resolve the ELF at build time; target[0] is the buildprog alias, not the file.
-        elf = env.subst("$BUILD_DIR/${PROGNAME}.elf")
-        out = subprocess.check_output([_NM, elf], universal_newlines=True)
-    except Exception as exc:  # tooling hiccup: warn loudly, don't wedge the build
-        print("nrf52_lto: WARNING - ISR-handler guard skipped (nm failed: %s)" % exc)
-        return
-    # nm line: "<addr> <type> <symbol>". type 'T'/'t' = strong (good); 'W'/'w' = weak stub.
-    kind = {}
-    for line in out.split("\n"):
-        f = line.split()
-        if len(f) >= 3 and f[-1].endswith("_IRQHandler"):
-            kind[f[-1]] = f[-2]
-    required = list(_REQUIRED_STRONG)
-    defines = [
-        str(d[0] if isinstance(d, tuple) else d) for d in env.get("CPPDEFINES", [])
-    ]
-    if "USE_TINYUSB" in defines:
-        required += _REQUIRED_STRONG_USB
-    dropped = [h for h in required if kind.get(h, "W").upper() != "T"]
-    if dropped:
-        sys.stderr.write(
-            "\n*** nrf52 LTO guard: interrupt handler(s) DROPPED: %s ***\n"
-            "Each resolved to the weak Default_Handler stub, so the chip hangs when that IRQ\n"
-            "fires. Compile the .cpp that defines the handler with -fno-lto by adding it to\n"
-            "LIB_ISR in extra_scripts/nrf52_lto.py. Find the owner of FOO_IRQHandler with:\n"
-            "  grep -rl FOO_IRQHandler <framework-arduinoadafruitnrf52>/{libraries,cores}\n\n"
-            % ", ".join(dropped)
-        )
-        from SCons.Script import Exit
-
-        Exit(1)  # canonical SCons build-abort -> red build
-    print(
-        "nrf52_lto: ISR-handler guard OK -- %d critical handlers strong" % len(required)
-    )
-
-
-# Attach to the phony "buildprog" alias, NOT the .elf file node: SCons can skip a post-action
-# on a file target during an incremental relink (observed), but the buildprog alias runs every
-# build -- so the guard fires on local incremental rebuilds and clean CI builds alike.
-env.AddPostAction("buildprog", _assert_isr_handlers_survived)

extra_scripts/nrf52_warm_region.py

@@ -1,70 +0,0 @@
-#!/usr/bin/env python3
-# trunk-ignore-all(ruff/F821)
-# trunk-ignore-all(flake8/F821): For SConstruct imports
-#
-# Post-link guard for the warm-node-store raw-flash region on nRF52840.
-#
-# The 3 app-region pages below LittleFS (0xEA000-0xED000, reclaimed by whole-image
-# LTO) are reserved for the WarmNodeStore record-ring (see WarmNodeStore.h). Our
-# linker scripts (nrf52840_s140_v6.ld and nrf52840_s140_v7.ld) cap the image at
-# 0xEA000, but boards on the framework-default script (FLASH ending at 0xED000) could
-# silently place code in those pages — the first warm-store save would then brick the
-# device. This turns that into a build failure.
-#
-# Image flash end = __etext + sizeof(.data) (loaded at LMA __etext); symbols from
-# the framework's nrf52_common.ld.
-import os
-
-Import("env")
-
-WARM_REGION_BASE = 0xEA000  # keep in sync with WARM_FLASH_REGION_BASE in WarmNodeStore.h (3 x 4 KB record-ring)
-
-_tc = env.PioPlatform().get_package_dir("toolchain-gccarmnoneeabi") or ""
-_NM = os.path.join(_tc, "bin", "arm-none-eabi-nm")
-if not os.path.isfile(_NM):
-    _NM = "arm-none-eabi-nm"  # fall back to PATH
-
-
-def _assert_warm_region_clear(source, target, env):
-    import subprocess
-    import sys
-
-    try:
-        elf = env.subst("$BUILD_DIR/${PROGNAME}.elf")
-        out = subprocess.check_output([_NM, elf], universal_newlines=True)
-    except Exception as exc:  # tooling hiccup: warn loudly, don't wedge the build
-        print("nrf52_warm_region: WARNING - guard skipped (nm failed: %s)" % exc)
-        return
-
-    syms = {}
-    for line in out.split("\n"):
-        f = line.split()
-        if len(f) >= 3 and f[-1] in ("__etext", "__data_start__", "__data_end__"):
-            syms[f[-1]] = int(f[0], 16)
-    if len(syms) != 3:
-        print("nrf52_warm_region: WARNING - guard skipped (linker symbols not found)")
-        return
-
-    flash_end = syms["__etext"] + (syms["__data_end__"] - syms["__data_start__"])
-    if flash_end > WARM_REGION_BASE:
-        sys.stderr.write(
-            "\n*** nrf52 warm-region guard: image ends at 0x%X, past the reserved "
-            "warm-store region at 0x%X ***\n"
-            "The 12 KB region at 0xEA000 holds the WarmNodeStore record-ring; a warm-store\n"
-            "save would overwrite this firmware's tail. Shrink the image, or shrink/move\n"
-            "the region (WARM_FLASH_REGION_BASE in src/mesh/WarmNodeStore.h, the FLASH\n"
-            "LENGTH in src/platform/nrf52/nrf52840_s140_v6.ld and _v7.ld, and this guard).\n\n"
-            % (flash_end, WARM_REGION_BASE)
-        )
-        from SCons.Script import Exit
-
-        Exit(1)
-    print(
-        "nrf52_warm_region: guard OK -- image ends at 0x%X, %d KB clear of the warm region"
-        % (flash_end, (WARM_REGION_BASE - flash_end) // 1024)
-    )
-
-
-# Attach to the phony "buildprog" alias (not the .elf node) so the guard runs
-# on incremental relinks too -- same reasoning as nrf52_lto.py's guard.
-env.AddPostAction("buildprog", _assert_warm_region_clear)

mcp-server/run-tests.sh

@@ -191,12 +191,10 @@ echo
 # PASS/FAIL — every hardware test would SKIP with "role not present". We
 # narrow to tests/unit explicitly so the summary reads as "no hardware,
 # unit suite only" instead of "big skip count looks suspicious".
-# Keep terminal output condensed (`-q -r fE`) so skip-heavy runs do not print
-# each skipped test in full; skip counts still appear in pytest's summary.
 if [[ -z $DETECTED && $# -eq 0 ]]; then
 	echo "[pre-flight] no supported devices detected; running unit tier only."
 	echo
-	exec "$VENV_PY" -m pytest tests/unit -q -r fE --report-log=tests/reportlog.jsonl
+	exec "$VENV_PY" -m pytest tests/unit -v --report-log=tests/reportlog.jsonl
 fi
 
 # Default pytest args when the user passed none. Power users can invoke
@@ -212,13 +210,11 @@ fi
 # skipping half the hardware tests with "not baked with session profile"
 # errors. Power users who know their hardware is current and want to shave
 # those seconds can pass `--assume-baked` explicitly.
-# Defaults also use condensed reporting (`-q -r fE`) to avoid listing every
-# skipped test verbatim while still surfacing failures/errors and summary data.
 if [[ $# -eq 0 ]]; then
 	set -- tests/ \
 		--html=tests/report.html --self-contained-html \
 		--junitxml=tests/junit.xml \
-		-q -r fE --tb=short
+		-v --tb=short
 fi
 
 # UI tier requires opencv-python-headless (and ideally easyocr). If it's

mcp-server/tests/mesh/test_nexthop_multihop_recovery.py

@@ -1,347 +0,0 @@
-"""Multi-hop NextHop directed-message delivery + relay-recovery (bench test).
-
-This is the hardware/tier-3 validator for the NextHop DM reliability work
-(see `docs/nexthop-routing-reliability.md`). The unit suite
-`test/test_nexthop_routing` covers the routing *logic* exhaustively; this test
-covers the *end-to-end* multi-hop behavior that only a real (or RF-separated)
-mesh exercises:
-
-  * a directed DM that must traverse a relay is delivered (next_hop routing +
-    the M1/M2 ambiguity gate + M3 route learning all engage), and
-  * when the established relay drops and returns, delivery recovers rather than
-    black-holing (the M3 stale-route decay / re-learn path).
-
-TOPOLOGY REQUIREMENT — why this usually SKIPS:
-  A NextHop relay only happens when the two endpoints are NOT direct neighbors.
-  Three co-located radios all hear each other, so A→C is a single direct hop and
-  next_hop never engages. To run this test the bench must be a *line* — A — B — C
-  — with the endpoints out of each other's direct RF range (physical distance or
-  attenuators). The `multihop_topology` fixture detects this automatically: it
-  warms the mesh, looks for a pair that is ≥1 hop apart, confirms the relay via
-  traceroute, and `pytest.skip`s cleanly when the bench is all-direct. So this
-  file is safe to commit and run anywhere — it only *asserts* when the topology
-  genuinely requires a relay.
-
-REQUIREMENTS:
-  * ≥3 baked devices. The default hub profile is 2 roles (nrf52, esp32s3); add a
-    third via `--hub-profile=path/to/hub.yaml` (see conftest `hub_profile`).
-  * The relay-recovery test additionally needs uhubctl + a power-controllable
-    relay port (same gate the other power tests use).
-"""
-
-from __future__ import annotations
-
-import time
-from typing import Any
-
-import pytest
-from meshtastic_mcp.connection import connect
-from tests import _power
-from tests._port_discovery import resolve_port_by_role
-
-from ._receive import ReceiveCollector, nudge_nodeinfo, nudge_nodeinfo_port
-
-
-def _hops_away(rec: dict[str, Any]) -> int | None:
-    """Read a node's hop distance from a `nodesByNum` entry, tolerating either
-    the camelCase (`hopsAway`) or snake_case (`hops_away`) spelling depending on
-    the meshtastic-python version."""
-    for key in ("hopsAway", "hops_away"):
-        val = rec.get(key)
-        if isinstance(val, int):
-            return val
-    return None
-
-
-def _warm_mesh(ports: list[str], rounds: int = 2, settle: float = 6.0) -> None:
-    """Flood a fresh NodeInfo from every node so the whole mesh (including
-    multi-hop pairs, reached via relayed broadcasts) populates pubkeys and hop
-    distances. Best-effort — a single node failing to nudge shouldn't abort."""
-    for _ in range(rounds):
-        for port in ports:
-            try:
-                nudge_nodeinfo_port(port)
-            except Exception:  # noqa: BLE001 — warmup is best-effort
-                pass
-            time.sleep(0.5)
-        time.sleep(settle)
-
-
-def _wait_for_pubkey(
-    tx_iface: Any, rx_num: int, rx_port: str, deadline_s: float = 90.0
-) -> bool:
-    """Block until `tx_iface` holds `rx_num`'s public key (directed PKI sends
-    NAK without it). Re-nudges both sides periodically; multi-hop warmup is
-    slower than the 2-device case because NodeInfo must be relayed, hence the
-    longer default deadline."""
-    deadline = time.monotonic() + deadline_s
-    last_nudge = time.monotonic()
-    while time.monotonic() < deadline:
-        rec = (tx_iface.nodesByNum or {}).get(rx_num, {})
-        if rec.get("user", {}).get("publicKey"):
-            return True
-        if time.monotonic() - last_nudge > 20.0:
-            nudge_nodeinfo_port(rx_port)
-            nudge_nodeinfo(tx_iface)
-            last_nudge = time.monotonic()
-        time.sleep(1.0)
-    return False
-
-
-def _traceroute_route(tx_port: str, rx_num: int, rx_port: str) -> list[int] | None:
-    """Run a traceroute TX→RX and return the forward `route` (list of relay node
-    numbers), or None if it couldn't be obtained. Mirrors test_traceroute's
-    request/PKI/retry pattern."""
-    from meshtastic.mesh_interface import MeshInterface
-
-    with ReceiveCollector(tx_port, topic="meshtastic.receive.traceroute") as tx:
-        nudge_nodeinfo_port(rx_port)
-        tx.broadcast_nodeinfo_ping()
-        if not _wait_for_pubkey(tx._iface, rx_num, rx_port, 60.0):
-            return None
-        for _attempt in range(2):
-            try:
-                tx._iface.sendTraceRoute(dest=rx_num, hopLimit=5)
-                break
-            except MeshInterface.MeshInterfaceError:
-                time.sleep(5.0)
-        else:
-            return None
-        pkt = tx.wait_for(lambda p: p.get("from") == rx_num, timeout=8.0)
-        if pkt is None:
-            return None
-        tr = (pkt.get("decoded", {}) or {}).get("traceroute") or {}
-        return [int(n) for n in (tr.get("route") or [])]
-
-
-@pytest.fixture(scope="session")
-def multihop_topology(baked_mesh: dict[str, Any]) -> dict[str, Any]:
-    """Discover a real multi-hop pier (tx → relay → rx) on the bench, or skip.
-
-    Returns {tx_role, tx_port, rx_role, rx_port, rx_num, relay_role, relay_num}.
-    """
-    roles = sorted(baked_mesh)
-    if len(roles) < 3:
-        pytest.skip(
-            "multi-hop NextHop test needs ≥3 baked devices arranged as a line "
-            "(endpoints out of direct RF range). Add a third role via "
-            f"--hub-profile. Detected roles: {roles}"
-        )
-
-    by_role = {r: (baked_mesh[r]["port"], baked_mesh[r]["my_node_num"]) for r in roles}
-    if any(num is None for _, num in by_role.values()):
-        pytest.skip("a baked device is missing my_node_num; can't map the topology")
-
-    _warm_mesh([port for port, _ in by_role.values()])
-
-    # Find an ordered pair that is ≥1 hop apart, using each node's own nodeDB
-    # (cheap — no traceroute yet). On an all-direct bench nothing qualifies.
-    multihop_pair: tuple[str, str] | None = None
-    for a_role in roles:
-        a_port, _ = by_role[a_role]
-        try:
-            with connect(port=a_port) as a_iface:
-                nodes = a_iface.nodesByNum or {}
-        except Exception:  # noqa: BLE001
-            continue
-        for c_role in roles:
-            if c_role == a_role:
-                continue
-            _, c_num = by_role[c_role]
-            hops = _hops_away(nodes.get(c_num, {}))
-            if hops is not None and hops >= 1:
-                multihop_pair = (a_role, c_role)
-                break
-        if multihop_pair:
-            break
-
-    if not multihop_pair:
-        pytest.skip(
-            "no multi-hop pair found — every device appears to be a direct "
-            "neighbor. Arrange the bench as a line (A — B — C) with the "
-            "endpoints out of direct RF range (distance or attenuators) so a "
-            "relay is actually required, then re-run."
-        )
-
-    a_role, c_role = multihop_pair
-    a_port, _ = by_role[a_role]
-    c_port, c_num = by_role[c_role]
-
-    route = _traceroute_route(a_port, c_num, c_port)
-    if not route:
-        pytest.skip(
-            f"{a_role}→{c_role} looked multi-hop but traceroute returned no "
-            "intermediate relay; can't identify the relay node to drive the "
-            "recovery test"
-        )
-
-    relay_num = route[0]
-    relay_role = next((r for r in roles if by_role[r][1] == relay_num), None)
-    return {
-        "tx_role": a_role,
-        "tx_port": a_port,
-        "rx_role": c_role,
-        "rx_port": c_port,
-        "rx_num": c_num,
-        "relay_role": relay_role,
-        "relay_num": relay_num,
-    }
-
-
-@pytest.mark.timeout(300)
-def test_multihop_dm_delivers(multihop_topology: dict[str, Any]) -> None:
-    """A directed wantAck DM that must traverse the relay is delivered.
-
-    Exercises the NextHop routing path end-to-end: TX picks a next hop toward
-    RX (M2 gate), the relay resolves the next_hop byte and forwards (M1), and
-    the route is learned from the returning ACK (M3). Retries absorb transient
-    LoRa loss; the assertion is on eventual delivery.
-    """
-    tx_port = multihop_topology["tx_port"]
-    rx_port = multihop_topology["rx_port"]
-    rx_num = multihop_topology["rx_num"]
-    tx_role = multihop_topology["tx_role"]
-    rx_role = multihop_topology["rx_role"]
-    relay_role = multihop_topology["relay_role"]
-
-    unique = f"nexthop-mh-{tx_role}-to-{rx_role}-{int(time.time())}"
-
-    with ReceiveCollector(rx_port, topic="meshtastic.receive.text") as rx:
-        rx.broadcast_nodeinfo_ping()
-        with connect(port=tx_port) as tx_iface:
-            nudge_nodeinfo(tx_iface)
-            if not _wait_for_pubkey(tx_iface, rx_num, rx_port, 90.0):
-                pytest.skip(
-                    f"{tx_role} never learned {rx_role}'s pubkey over the relay; "
-                    "multi-hop PKI warmup didn't complete"
-                )
-            got = None
-            for _attempt in range(3):
-                pkt = tx_iface.sendText(unique, destinationId=rx_num, wantAck=True)
-                assert pkt is not None
-                got = rx.wait_for(
-                    lambda p: p.get("decoded", {}).get("text") == unique,
-                    timeout=45,
-                )
-                if got is not None:
-                    break
-                rx.broadcast_nodeinfo_ping()
-                nudge_nodeinfo(tx_iface)
-                time.sleep(5.0)
-
-    assert got is not None, (
-        f"multi-hop directed DM {tx_role}→{rx_role} via relay "
-        f"{relay_role!r} never landed — NextHop multi-hop delivery is broken"
-    )
-
-
-@pytest.mark.timeout(600)
-def test_multihop_relay_recovery(
-    multihop_topology: dict[str, Any],
-    power_cycle,  # noqa: ARG001 — forces the uhubctl-availability skip
-) -> None:
-    """Delivery recovers after the established relay drops and returns.
-
-    Establishes a baseline DM (route via relay learned), powers the relay OFF
-    (confirming TX survives sending across a downed relay), then powers it back
-    ON and asserts directed delivery resumes — the M3 stale-route decay /
-    re-learn path. With a strict A — B — C line there is no path while B is down,
-    so we only assert TX doesn't crash during the outage; the delivery assertion
-    is after B returns.
-    """
-    relay_role = multihop_topology["relay_role"]
-    if not relay_role:
-        pytest.skip(
-            "relay node isn't one of the baked hub roles, so it can't be "
-            "power-cycled; recovery test needs a controllable relay"
-        )
-
-    tx_port = multihop_topology["tx_port"]
-    rx_port = multihop_topology["rx_port"]
-    rx_num = multihop_topology["rx_num"]
-    tx_role = multihop_topology["tx_role"]
-    rx_role = multihop_topology["rx_role"]
-
-    base = f"mh-recover-base-{int(time.time())}"
-    post = f"mh-recover-post-{int(time.time())}"
-
-    # Baseline: confirm delivery works (so the route via the relay is learned)
-    # before we perturb anything — otherwise a later failure is ambiguous.
-    with ReceiveCollector(rx_port, topic="meshtastic.receive.text") as rx:
-        rx.broadcast_nodeinfo_ping()
-        with connect(port=tx_port) as tx_iface:
-            nudge_nodeinfo(tx_iface)
-            if not _wait_for_pubkey(tx_iface, rx_num, rx_port, 90.0):
-                pytest.skip("multi-hop PKI warmup failed; can't run recovery test")
-            tx_iface.sendText(base, destinationId=rx_num, wantAck=True)
-            assert (
-                rx.wait_for(
-                    lambda p: p.get("decoded", {}).get("text") == base, timeout=45
-                )
-                is not None
-            ), "baseline multi-hop delivery failed — skipping recovery to avoid a false result"
-
-    # Power the relay OFF.
-    try:
-        _power.power_off(relay_role)
-        _power.wait_for_absence(relay_role, timeout_s=15.0)
-    except Exception as exc:  # noqa: BLE001
-        try:
-            _power.power_on(relay_role)
-            resolve_port_by_role(relay_role, timeout_s=30.0)
-        except Exception:  # noqa: BLE001
-            pass
-        pytest.skip(f"can't power-control relay {relay_role!r}: {exc}")
-
-    # With the only relay down there's no path; we just confirm TX accepts the
-    # send and survives its internal retries (it must not crash / wedge).
-    try:
-        with connect(port=tx_port) as tx_iface:
-            pkt = tx_iface.sendText(
-                f"mh-while-down-{int(time.time())}",
-                destinationId=rx_num,
-                wantAck=True,
-            )
-            assert pkt is not None
-            time.sleep(8.0)  # let retransmissions + route decay run
-    except Exception as exc:  # noqa: BLE001 — restore bench state before failing
-        _power.power_on(relay_role)
-        resolve_port_by_role(relay_role, timeout_s=30.0)
-        raise AssertionError(
-            f"TX crashed sending across a downed relay: {exc}"
-        ) from exc
-
-    # Power the relay back ON and let it re-enumerate + boot.
-    _power.power_on(relay_role)
-    time.sleep(0.5)
-    try:
-        resolve_port_by_role(relay_role, timeout_s=30.0)
-    except Exception:  # noqa: BLE001 — relay port isn't one we connect to directly
-        pass
-    time.sleep(8.0)
-    _warm_mesh([tx_port, rx_port], rounds=1)  # re-flood so the relay re-learns
-
-    # Delivery should resume once the relay is back (M3 re-learn / decay path).
-    got = None
-    with ReceiveCollector(rx_port, topic="meshtastic.receive.text") as rx:
-        rx.broadcast_nodeinfo_ping()
-        with connect(port=tx_port) as tx_iface:
-            nudge_nodeinfo(tx_iface)
-            _wait_for_pubkey(tx_iface, rx_num, rx_port, 90.0)
-            for _attempt in range(4):
-                pkt = tx_iface.sendText(post, destinationId=rx_num, wantAck=True)
-                assert pkt is not None
-                got = rx.wait_for(
-                    lambda p: p.get("decoded", {}).get("text") == post,
-                    timeout=45,
-                )
-                if got is not None:
-                    break
-                rx.broadcast_nodeinfo_ping()
-                nudge_nodeinfo(tx_iface)
-                time.sleep(6.0)
-
-    assert got is not None, (
-        f"after relay {relay_role!r} returned, multi-hop DM {tx_role}→{rx_role} "
-        "never resumed — stale-route recovery (M3) may be broken"
-    )

mcp-server/tests/test_00_bake.py

@@ -44,7 +44,7 @@ _ESP32_ARCHES = {
     "esp32-c6",
     "esp32c6",
 }
-_NRF52_ARCHES = {"nrf52", "nrf52840"}
+_NRF52_ARCHES = {"nrf52", "nrf52840", "nrf52832"}
 
 
 def _wait_port_free(port: str, *, timeout_s: float = 15.0, role: str = "") -> None:

meshtasticd.spec.rpkg

@@ -34,7 +34,6 @@ BuildRequires: python3dist(grpcio-tools)
 BuildRequires: git-core
 BuildRequires: gcc-c++
 BuildRequires: pkgconfig(yaml-cpp)
-BuildRequires: pkgconfig(jsoncpp)
 BuildRequires: pkgconfig(libgpiod)
 BuildRequires: pkgconfig(bluez)
 BuildRequires: pkgconfig(libusb-1.0)

platformio.ini

@@ -103,7 +103,7 @@ build_unflags =
 	-std=gnu++11
 build_flags = ${env.build_flags} -Os
 	-std=gnu++17
-build_src_filter = ${env.build_src_filter} -<platform/> +<platform/extra_variants/> -<graphics/niche/>
+build_src_filter = ${env.build_src_filter} -<platform/portduino/> -<graphics/niche/>
 
 ; Common libs for communicating over TCP/IP networks such as MQTT
 [networking_base]
@@ -186,20 +186,40 @@ lib_deps =
 	https://github.com/sparkfun/SparkFun_MAX3010x_Sensor_Library/archive/refs/tags/v1.1.2.zip
 	# renovate: datasource=github-tags depName=SparkFun 9DoF IMU Breakout ICM 20948 packageName=sparkfun/SparkFun_ICM-20948_ArduinoLibrary
 	https://github.com/sparkfun/SparkFun_ICM-20948_ArduinoLibrary/archive/refs/tags/v1.3.2.zip
-	# renovate: datasource=github-tags depName=TDK InvenSense ICM42670P packageName=tdk-invn-oss/motion.arduino.ICM42670P
-	https://github.com/tdk-invn-oss/motion.arduino.ICM42670P/archive/refs/tags/1.0.8.zip
 	# renovate: datasource=github-tags depName=Adafruit LTR390 Library packageName=adafruit/Adafruit_LTR390
 	https://github.com/adafruit/Adafruit_LTR390/archive/refs/tags/1.1.2.zip
 	# renovate: datasource=github-tags depName=Adafruit PCT2075 packageName=adafruit/Adafruit_PCT2075
 	https://github.com/adafruit/Adafruit_PCT2075/archive/refs/tags/1.0.6.zip
 	# renovate: datasource=github-tags depName=DFRobot_BMM150 packageName=dfrobot/DFRobot_BMM150
 	https://github.com/DFRobot/DFRobot_BMM150/archive/refs/tags/V1.0.0.zip
-	# renovate: datasource=github-tags depName=SparkFun MMC5983MA Magnetometer packageName=sparkfun/SparkFun_MMC5983MA_Magnetometer_Arduino_Library
-	https://github.com/sparkfun/SparkFun_MMC5983MA_Magnetometer_Arduino_Library/archive/refs/tags/v1.1.4.zip
 	# renovate: datasource=github-tags depName=Adafruit_TSL2561 packageName=adafruit/Adafruit_TSL2561
 	https://github.com/adafruit/Adafruit_TSL2561/archive/refs/tags/1.1.3.zip
 	# renovate: datasource=github-tags depName=BH1750_WE packageName=wollewald/BH1750_WE
 	https://github.com/wollewald/BH1750_WE/archive/refs/tags/1.1.10.zip
+
+; Common environmental sensor libraries (not included in native / portduino)
+[environmental_extra_common]
+lib_deps =
+	# renovate: datasource=github-tags depName=Adafruit BMP3XX packageName=adafruit/Adafruit_BMP3XX
+	https://github.com/adafruit/Adafruit_BMP3XX/archive/refs/tags/2.1.6.zip
+	# renovate: datasource=github-tags depName=Adafruit MAX1704X packageName=adafruit/Adafruit_MAX1704X
+	https://github.com/adafruit/Adafruit_MAX1704X/archive/refs/tags/1.0.3.zip
+	# renovate: datasource=github-tags depName=Adafruit SHTC3 packageName=adafruit/Adafruit_SHTC3
+	https://github.com/adafruit/Adafruit_SHTC3/archive/refs/tags/1.0.2.zip
+	# renovate: datasource=github-tags depName=Adafruit LPS2X packageName=adafruit/Adafruit_LPS2X
+	https://github.com/adafruit/Adafruit_LPS2X/archive/refs/tags/2.0.6.zip
+	# renovate: datasource=github-tags depName=Adafruit SHT31 packageName=adafruit/Adafruit_SHT31
+	https://github.com/adafruit/Adafruit_SHT31/archive/refs/tags/2.2.2.zip
+	# renovate: datasource=github-tags depName=Adafruit VEML7700 packageName=adafruit/Adafruit_VEML7700
+	https://github.com/adafruit/Adafruit_VEML7700/archive/refs/tags/2.1.6.zip
+	# renovate: datasource=github-tags depName=Adafruit SHT4x packageName=adafruit/Adafruit_SHT4X
+	https://github.com/adafruit/Adafruit_SHT4X/archive/refs/tags/1.0.5.zip
+	# renovate: datasource=github-tags depName=SparkFun Qwiic Scale NAU7802 packageName=sparkfun/SparkFun_Qwiic_Scale_NAU7802_Arduino_Library
+	https://github.com/sparkfun/SparkFun_Qwiic_Scale_NAU7802_Arduino_Library/archive/refs/tags/v1.0.6.zip
+	# renovate: datasource=custom.pio depName=ClosedCube OPT3001 packageName=closedcube/library/ClosedCube OPT3001
+	closedcube/ClosedCube OPT3001@1.1.2
+	# renovate: datasource=git-refs depName=meshtastic-DFRobot_LarkWeatherStation packageName=https://github.com/meshtastic/DFRobot_LarkWeatherStation gitBranch=master
+	https://github.com/meshtastic/DFRobot_LarkWeatherStation/archive/4de3a9cadef0f6a5220a8a906cf9775b02b0040d.zip
 	# renovate: datasource=github-tags depName=Sensirion Core packageName=sensirion/arduino-core
 	https://github.com/Sensirion/arduino-core/archive/refs/tags/0.7.3.zip
 	# renovate: datasource=github-tags depName=Sensirion I2C SCD4x packageName=sensirion/arduino-i2c-scd4x
@@ -211,24 +231,6 @@ lib_deps =
 	# renovate: datasource=github-tags depName=arduino-sht packageName=sensirion/arduino-sht
 	https://github.com/Sensirion/arduino-sht/archive/refs/tags/v1.2.6.zip
 
-; Common environmental sensor libraries (not included in native / portduino)
-[environmental_extra_common]
-lib_deps =
-	# renovate: datasource=github-tags depName=Adafruit BMP3XX packageName=adafruit/Adafruit_BMP3XX
-	https://github.com/adafruit/Adafruit_BMP3XX/archive/refs/tags/2.1.6.zip
-	# renovate: datasource=github-tags depName=Adafruit MAX1704X packageName=adafruit/Adafruit_MAX1704X
-	https://github.com/adafruit/Adafruit_MAX1704X/archive/refs/tags/1.0.3.zip
-	# renovate: datasource=github-tags depName=Adafruit LPS2X packageName=adafruit/Adafruit_LPS2X
-	https://github.com/adafruit/Adafruit_LPS2X/archive/refs/tags/2.0.6.zip
-	# renovate: datasource=github-tags depName=Adafruit VEML7700 packageName=adafruit/Adafruit_VEML7700
-	https://github.com/adafruit/Adafruit_VEML7700/archive/refs/tags/2.1.6.zip
-	# renovate: datasource=github-tags depName=SparkFun Qwiic Scale NAU7802 packageName=sparkfun/SparkFun_Qwiic_Scale_NAU7802_Arduino_Library
-	https://github.com/sparkfun/SparkFun_Qwiic_Scale_NAU7802_Arduino_Library/archive/refs/tags/v1.0.6.zip
-	# renovate: datasource=custom.pio depName=ClosedCube OPT3001 packageName=closedcube/library/ClosedCube OPT3001
-	closedcube/ClosedCube OPT3001@1.1.2
-	# renovate: datasource=git-refs depName=meshtastic-DFRobot_LarkWeatherStation packageName=https://github.com/meshtastic/DFRobot_LarkWeatherStation gitBranch=master
-	https://github.com/meshtastic/DFRobot_LarkWeatherStation/archive/4de3a9cadef0f6a5220a8a906cf9775b02b0040d.zip
-
 ; Environmental sensors with BSEC2 (Bosch proprietary IAQ)
 [environmental_extra]
 lib_deps =

src/DebugConfiguration.h

@@ -152,9 +152,7 @@ extern "C" void logLegacy(const char *level, const char *fmt, ...);
 // Default Bluetooth PIN
 #define defaultBLEPin 123456
 
-#if HAS_ETHERNET && defined(USE_ARDUINO_ETHERNET)
-#include <Ethernet.h> // arduino-libraries/Ethernet — supports W5500 auto-detect
-#elif HAS_ETHERNET && defined(USE_CH390D)
+#if HAS_ETHERNET && defined(USE_CH390D)
 #include <ESP32_CH390.h>
 #elif HAS_ETHERNET && !defined(USE_WS5500)
 #include <RAK13800_W5100S.h>

src/DisplayFormatters.cpp

@@ -1,5 +1,4 @@
 #include "DisplayFormatters.h"
-#include "MeshRadio.h"
 
 const char *DisplayFormatters::getModemPresetDisplayName(meshtastic_Config_LoRaConfig_ModemPreset preset, bool useShortName,
                                                          bool usePreset)
@@ -12,51 +11,33 @@ const char *DisplayFormatters::getModemPresetDisplayName(meshtastic_Config_LoRaC
     }
 
     switch (preset) {
-    case PRESET(SHORT_TURBO):
+    case meshtastic_Config_LoRaConfig_ModemPreset_SHORT_TURBO:
         return useShortName ? "ShortT" : "ShortTurbo";
         break;
-    case PRESET(SHORT_SLOW):
+    case meshtastic_Config_LoRaConfig_ModemPreset_SHORT_SLOW:
         return useShortName ? "ShortS" : "ShortSlow";
         break;
-    case PRESET(SHORT_FAST):
+    case meshtastic_Config_LoRaConfig_ModemPreset_SHORT_FAST:
         return useShortName ? "ShortF" : "ShortFast";
         break;
-    case PRESET(MEDIUM_SLOW):
+    case meshtastic_Config_LoRaConfig_ModemPreset_MEDIUM_SLOW:
         return useShortName ? "MedS" : "MediumSlow";
         break;
-    case PRESET(MEDIUM_FAST):
+    case meshtastic_Config_LoRaConfig_ModemPreset_MEDIUM_FAST:
         return useShortName ? "MedF" : "MediumFast";
         break;
-    case PRESET(LONG_SLOW):
+    case meshtastic_Config_LoRaConfig_ModemPreset_LONG_SLOW:
         return useShortName ? "LongS" : "LongSlow";
         break;
-    case PRESET(LONG_FAST):
+    case meshtastic_Config_LoRaConfig_ModemPreset_LONG_FAST:
         return useShortName ? "LongF" : "LongFast";
         break;
-    case PRESET(LONG_TURBO):
+    case meshtastic_Config_LoRaConfig_ModemPreset_LONG_TURBO:
         return useShortName ? "LongT" : "LongTurbo";
         break;
-    case PRESET(LONG_MODERATE):
+    case meshtastic_Config_LoRaConfig_ModemPreset_LONG_MODERATE:
         return useShortName ? "LongM" : "LongMod";
         break;
-    case PRESET(LITE_FAST):
-        return useShortName ? "LiteF" : "LiteFast";
-        break;
-    case PRESET(LITE_SLOW):
-        return useShortName ? "LiteS" : "LiteSlow";
-        break;
-    case PRESET(NARROW_FAST):
-        return useShortName ? "NarF" : "NarrowFast";
-        break;
-    case PRESET(NARROW_SLOW):
-        return useShortName ? "NarS" : "NarrowSlow";
-        break;
-    case PRESET(TINY_FAST):
-        return useShortName ? "TinyF" : "TinyFast";
-        break;
-    case PRESET(TINY_SLOW):
-        return useShortName ? "TinyS" : "TinySlow";
-        break;
     default:
         return useShortName ? "Custom" : "Invalid";
         break;

src/FSCommon.h

@@ -14,8 +14,8 @@
 #define FILE_O_READ "r"
 #endif
 
-#if defined(ARCH_STM32)
-// STM32
+#if defined(ARCH_STM32WL)
+// STM32WL
 #include "LittleFS.h"
 #define FSCom InternalFS
 #define FSBegin() FSCom.begin()

src/MessageStore.cpp

@@ -1,5 +1,5 @@
 #include "configuration.h"
-#if HAS_SCREEN || defined(MESHTASTIC_INCLUDE_NICHE_GRAPHICS)
+#if HAS_SCREEN
 #include "FSCommon.h"
 #include "MessageStore.h"
 #include "NodeDB.h"
@@ -354,7 +354,6 @@ void MessageStore::clearAllMessages()
     resetMessagePool();
 
 #ifdef FSCom
-    concurrency::LockGuard guard(spiLock);
     SafeFile f(filename.c_str(), false);
     uint8_t count = 0;
     f.write(&count, 1); // write "0 messages"

src/MessageStore.h

@@ -1,6 +1,6 @@
 #pragma once
 
-#if HAS_SCREEN || defined(MESHTASTIC_INCLUDE_NICHE_GRAPHICS)
+#if HAS_SCREEN
 
 // Disable debug logging entirely on release builds of HELTEC_MESH_SOLAR for space constraints
 #if defined(HELTEC_MESH_SOLAR)

src/Power.cpp

@@ -14,7 +14,6 @@
  * For more information, see: https://meshtastic.org/
  */
 #include "power.h"
-#include "BluetoothCommon.h"
 #include "MessageStore.h"
 #include "NodeDB.h"
 #include "PowerFSM.h"
@@ -48,7 +47,7 @@
 #include "concurrency/LockGuard.h"
 #endif
 
-#if defined(ARCH_STM32) && defined(BATTERY_PIN)
+#if defined(ARCH_STM32WL) && defined(BATTERY_PIN)
 #include "stm32yyxx_ll_adc.h"
 
 /* Analog read resolution */
@@ -431,7 +430,7 @@ class AnalogBatteryLevel : public HasBatteryLevel
             float scaled = 0;
 
             battery_adcEnable();
-#ifdef ARCH_STM32
+#ifdef ARCH_STM32WL
             // STM32 ADC with VREFINT runtime calibration
             Vref = __LL_ADC_CALC_VREFANALOG_VOLTAGE(analogRead(AVREF), LL_ADC_RESOLUTION);
             raw = analogRead(BATTERY_PIN);
@@ -608,7 +607,7 @@ class AnalogBatteryLevel : public HasBatteryLevel
     bool initial_read_done = false;
     float last_read_value = (OCV[NUM_OCV_POINTS - 1] * NUM_CELLS);
     uint32_t last_read_time_ms = 0;
-#ifdef ARCH_STM32
+#ifdef ARCH_STM32WL
     // 3300mV placeholder for STM32 errata where VREFINT factory calibration may be missing
     // (e.g. STM32U0, see DS14756 Rev 3 §2.4.1 "VREFINT offset")
     uint32_t Vref = 3300;
@@ -718,7 +717,7 @@ bool Power::analogInit()
 #define BATTERY_SENSE_RESOLUTION_BITS 10
 #endif
 
-#ifdef ARCH_STM32
+#ifdef ARCH_STM32WL
     analogReadResolution(BATTERY_SENSE_RESOLUTION_BITS);
 #elif defined(ARCH_ESP32) // ESP32 needs special analog stuff
     adc_oneshot_unit_init_cfg_t init_config = {
@@ -749,7 +748,7 @@ bool Power::analogInit()
 
     // NRF52 ADC init moved to powerHAL_init in nrf52 platform
 
-#if !defined(ARCH_ESP32) && !defined(ARCH_STM32)
+#if !defined(ARCH_ESP32) && !defined(ARCH_STM32WL)
     analogReadResolution(BATTERY_SENSE_RESOLUTION_BITS);
 #endif
 
@@ -838,7 +837,7 @@ void Power::reboot()
     }
     LOG_DEBUG("final reboot!");
     ::reboot();
-#elif defined(ARCH_STM32)
+#elif defined(ARCH_STM32WL)
     HAL_NVIC_SystemReset();
 #else
     rebootAtMsec = -1;
@@ -963,10 +962,6 @@ void Power::readPowerStatus()
         lastLogTime = millis();
     }
     newStatus.notifyObservers(&powerStatus2);
-
-    // Mirror battery level to the BLE Battery Service (0x2A19); the platform layer clamps and dedupes.
-    if (hasBattery == OptTrue)
-        updateBatteryLevel(powerStatus2.getBatteryChargePercent());
 #ifdef DEBUG_HEAP
     if (lastheap != memGet.getFreeHeap()) {
         // Use stack-allocated buffer to avoid heap allocations in monitoring code

src/PowerFSM.cpp

@@ -219,11 +219,7 @@ static void darkEnter()
 static void serialEnter()
 {
     LOG_POWERFSM("State: serialEnter");
-#ifndef ARCH_NRF52
-    // nRF52 runs BLE on SoftDevice independently of USB serial — no need to disable it.
-    // (Same rationale as nbEnter() which already guards this with #ifdef ARCH_ESP32)
     setBluetoothEnable(false);
-#endif
     if (screen) {
         screen->setOn(true);
     }

src/RF95Configuration.h

@@ -1,16 +1,6 @@
 // TODO refactor this out with better radio configuration system
 #ifdef USE_RF95
-
-#ifndef RF95_RESET
 #define RF95_RESET LORA_RESET
-#endif
-
-#ifndef RF95_IRQ
-#define RF95_IRQ LORA_DIO0 // on SX1262 version this is a no connect DIO0
-#endif
-
-#ifndef RF95_DIO1
+#define RF95_IRQ LORA_DIO0  // on SX1262 version this is a no connect DIO0
 #define RF95_DIO1 LORA_DIO1 // Note: not really used for RF95, but used for pure SX127x
 #endif
-
-#endif

src/RedirectablePrint.cpp

@@ -7,7 +7,6 @@
 #include "memGet.h"
 #include "mesh/generated/meshtastic/mesh.pb.h"
 #include <assert.h>
-#include <atomic>
 #include <cstring>
 #include <memory>
 #include <stdexcept>
@@ -21,22 +20,6 @@
 #if HAS_NETWORKING
 extern meshtastic::Syslog syslog;
 #endif
-
-namespace
-{
-std::atomic<bool> serialHalLogSuppressed{false};
-}
-
-void RedirectablePrint::setSerialHalLogSuppressed(bool suppressed)
-{
-    serialHalLogSuppressed.store(suppressed);
-}
-
-bool RedirectablePrint::isSerialHalLogSuppressed()
-{
-    return serialHalLogSuppressed.load();
-}
-
 void RedirectablePrint::rpInit()
 {
 #ifdef HAS_FREE_RTOS
@@ -68,7 +51,7 @@ size_t RedirectablePrint::write(uint8_t c)
 size_t RedirectablePrint::vprintf(const char *logLevel, const char *format, va_list arg)
 {
     va_list copy;
-#if ARCH_PORTDUINO
+#if ENABLE_JSON_LOGGING || ARCH_PORTDUINO
     static char printBuf[512];
 #else
     static char printBuf[160];
@@ -298,10 +281,6 @@ meshtastic_LogRecord_Level RedirectablePrint::getLogLevel(const char *logLevel)
 void RedirectablePrint::log(const char *logLevel, const char *format, ...)
 {
 
-    if (isSerialHalLogSuppressed()) {
-        return;
-    }
-
     // append \n to format
     size_t len = strlen(format);
     auto newFormat = std::unique_ptr<char[]>(new char[len + 2]);

src/RedirectablePrint.h

@@ -24,11 +24,6 @@ class RedirectablePrint : public Print
   public:
     explicit RedirectablePrint(Print *_dest) : dest(_dest) {}
 
-    /// Suppress all log output while a SerialHal transaction is in progress.
-    // Unclear if this is necessary, but it seems to help with response speeds.
-    static void setSerialHalLogSuppressed(bool suppressed);
-    static bool isSerialHalLogSuppressed();
-
     /**
      * Set a new destination
      */

src/airtime.cpp

@@ -133,12 +133,11 @@ bool AirTime::isTxAllowedChannelUtil(bool polite)
 
 bool AirTime::isTxAllowedAirUtil()
 {
-    float effectiveDutyCycle = getEffectiveDutyCycle();
-    if (!config.lora.override_duty_cycle && effectiveDutyCycle < 100) {
-        if (utilizationTXPercent() < effectiveDutyCycle * polite_duty_cycle_percent / 100) {
+    if (!config.lora.override_duty_cycle && myRegion->dutyCycle < 100) {
+        if (utilizationTXPercent() < myRegion->dutyCycle * polite_duty_cycle_percent / 100) {
             return true;
         } else {
-            LOG_WARN("TX air util. >%f%%. Skip send", effectiveDutyCycle * polite_duty_cycle_percent / 100);
+            LOG_WARN("TX air util. >%f%%. Skip send", myRegion->dutyCycle * polite_duty_cycle_percent / 100);
             return false;
         }
     }

src/configuration.h

@@ -31,11 +31,6 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #endif
 #if __has_include("SensorRtcHelper.hpp")
 #include "SensorRtcHelper.hpp"
-// SensorLib defines isBitSet as a macro; undefine it here to avoid conflicts
-// with the SparkFun MMC5983MA library, which has a class method of the same name.
-#ifdef isBitSet
-#undef isBitSet
-#endif
 #endif
 
 /* Offer chance for variant-specific defines */
@@ -179,13 +174,6 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #endif
 #endif
 
-#ifdef USE_KCT8103L_PA_ONLY
-#if defined(HELTEC_MESH_TOWER_V2)
-#define NUM_PA_POINTS 22
-#define TX_GAIN_LORA 11, 11, 11, 11, 11, 11, 11, 11, 11, 11, 10, 10, 10, 10, 10, 10, 10, 10, 10, 9, 8, 7
-#endif
-#endif
-
 #ifdef RAK13302
 #define NUM_PA_POINTS 22
 #define TX_GAIN_LORA 7, 8, 8, 8, 8, 8, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 9, 8
@@ -255,7 +243,6 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #define QMI8658_ADDR 0x6B
 #define QMC5883L_ADDR 0x0D
 #define HMC5883L_ADDR 0x1E
-#define MMC5983MA_ADDR 0x30
 #define SHTC3_ADDR 0x70
 #define LPS22HB_ADDR 0x5C
 #define LPS22HB_ADDR_ALT 0x5D
@@ -305,8 +292,6 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #define DA217_ADDR 0x26
 #define BMI270_ADDR 0x68
 #define BMI270_ADDR_ALT 0x69
-#define ICM42607P_ADDR 0x68
-#define ICM42607P_ADDR_ALT 0x69
 
 // -----------------------------------------------------------------------------
 // LED
@@ -580,94 +565,5 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #define USE_ETHERNET_DEFAULT 0
 #endif
 
-// -----------------------------------------------------------------------------
-// MESHTASTIC_LOCKDOWN — runtime, client-toggleable hardening (nRF52 only)
-//
-// Lockdown/protect support is opt-in at build time. Builds that need it pass
-// -DMESHTASTIC_ENABLE_LOCKDOWN=1. When enabled on nRF52 (CC310 hardware
-// crypto), whether it is ACTIVE is decided entirely at runtime by
-// EncryptedStorage::isLockdownActive()
-// (== a passphrase has been provisioned, i.e. /prefs/.dek exists). A device
-// that has never been provisioned — or that the operator disabled from the
-// client app — behaves exactly like stock firmware: plaintext storage, no
-// redaction, normal logging, normal display.
-//
-// The operator toggles lockdown from the client app:
-//   off -> on : provision a passphrase (AdminMessage.lockdown_auth). The
-//               firmware generates a DEK, encrypts the stored config, and
-//               authorizes the connection.
-//   on -> off : AdminMessage.lockdown_auth { disable=true } with the
-//               passphrase — decrypts storage back to plaintext and removes
-//               the DEK / token / monotonic-counter / backoff files, then
-//               reboots into normal mode. APPROTECT is the one thing that
-//               does NOT revert (see below).
-//
-// MESHTASTIC_LOCKDOWN here is an INTERNAL capability marker. It gates the UI
-// bits (lock screen, pairing-PIN handling). Flash-constrained nRF52 variants
-// that genuinely cannot afford the ~tens-of-KB of crypto + access-control code
-// may also opt out with -DMESHTASTIC_EXCLUDE_LOCKDOWN=1.
-//
-//   MESHTASTIC_PHONEAPI_ACCESS_CONTROL — per-connection auth + redaction,
-//                                        gated at runtime on isLockdownActive()
-//   MESHTASTIC_ENCRYPTED_STORAGE       — AES-128-CTR + HMAC-SHA256 at-rest
-//   MESHTASTIC_ENABLE_APPROTECT        — UICR APPROTECT capability. The actual
-//                                        one-way burn happens at runtime, only
-//                                        once provisioned, only on non-vulnerable
-//                                        silicon, and is STICKY: disabling
-//                                        lockdown does NOT (cannot) reverse it.
-//
-// DEBUG_MUTE is intentionally NOT coupled to lockdown — a capable-but-off
-// device must log normally. Define DEBUG_MUTE separately for a silent build.
-//
-// -DMESHTASTIC_LOCKDOWN_DEBUG=1 keeps the irreversible APPROTECT burn disabled
-// even when provisioned — for development so dev boards never lose SWD.
-// -----------------------------------------------------------------------------
-#if defined(ARCH_NRF52)
-#ifndef MESHTASTIC_ENABLE_LOCKDOWN
-#define MESHTASTIC_ENABLE_LOCKDOWN 0
-#endif
-
-#if !MESHTASTIC_ENABLE_LOCKDOWN
-#undef MESHTASTIC_LOCKDOWN
-#undef MESHTASTIC_PHONEAPI_ACCESS_CONTROL
-#undef MESHTASTIC_ENCRYPTED_STORAGE
-#undef MESHTASTIC_ENABLE_APPROTECT
-#ifndef MESHTASTIC_EXCLUDE_LOCKDOWN
-#define MESHTASTIC_EXCLUDE_LOCKDOWN 1
-#endif
-#endif
-
-#if MESHTASTIC_ENABLE_LOCKDOWN && !defined(MESHTASTIC_EXCLUDE_LOCKDOWN)
-#define MESHTASTIC_LOCKDOWN 1
-#define MESHTASTIC_PHONEAPI_ACCESS_CONTROL 1
-#define MESHTASTIC_ENCRYPTED_STORAGE 1
-#ifndef MESHTASTIC_LOCKDOWN_DEBUG
-#define MESHTASTIC_ENABLE_APPROTECT 1
-#endif
-#endif
-#endif
-
-#ifdef MESHTASTIC_LOCKDOWN
-
-// Per-boot uptime cap on unlocked sessions. 0 = unlimited (token-only
-// enforcement, the existing behavior). When non-zero, every passphrase
-// unlock (and every token-auto-unlock that inherits the value) arms a
-// timer; on expiry the device lockNow()s and reboots into locked state.
-// Bounds the total exposure window to bootsRemaining * this value if an
-// attacker has physical possession but not the passphrase.
-//
-// Override at build time. Suggested:
-//   carry device:        3600  (1h sessions, periodic re-auth from phone)
-//   tower / infra node:  0     (default — relies on token TTLs only)
-//
-// A future LockdownAuth.max_session_seconds proto field will let the
-// client set this per-token; until that lands the build-time value is
-// the only source.
-#ifndef MESHTASTIC_LOCKDOWN_SESSION_DEFAULT_SECONDS
-#define MESHTASTIC_LOCKDOWN_SESSION_DEFAULT_SECONDS 0
-#endif
-
-#endif // MESHTASTIC_LOCKDOWN
-
 #include "DebugConfiguration.h"
 #include "RF95Configuration.h"

src/detect/ScanI2C.cpp

@@ -37,15 +37,8 @@ ScanI2C::FoundDevice ScanI2C::firstKeyboard() const
 
 ScanI2C::FoundDevice ScanI2C::firstAccelerometer() const
 {
-    ScanI2C::DeviceType types[] = {MPU6050,  LIS3DH,   BMA423, LSM6DS3, BMX160,    STK8BAXX,
-                                   ICM20948, QMA6100P, BMM150, BMI270,  ICM42607P, ISM330DHCX};
-    return firstOfOrNONE(12, types);
-}
-
-ScanI2C::FoundDevice ScanI2C::firstMagnetometer() const
-{
-    ScanI2C::DeviceType types[] = {MMC5983MA, IIS2MDCTR};
-    return firstOfOrNONE(2, types);
+    ScanI2C::DeviceType types[] = {MPU6050, LIS3DH, BMA423, LSM6DS3, BMX160, STK8BAXX, ICM20948, QMA6100P, BMM150, BMI270};
+    return firstOfOrNONE(10, types);
 }
 
 ScanI2C::FoundDevice ScanI2C::firstAQI() const

src/detect/ScanI2C.h

@@ -41,7 +41,6 @@ class ScanI2C
         QMI8658,
         QMC5883L,
         HMC5883L,
-        MMC5983MA,
         PMSA003I,
         QMA6100P,
         MPU6050,
@@ -66,7 +65,6 @@ class ScanI2C
         FT6336U,
         STK8BAXX,
         ICM20948,
-        ICM42607P,
         SCD4X,
         MAX30102,
         TPS65233,
@@ -99,8 +97,6 @@ class ScanI2C
         CW2015,
         SCD30,
         ADS1115,
-        IIS2MDCTR,
-        ISM330DHCX,
     } DeviceType;
 
     // typedef uint8_t DeviceAddress;
@@ -153,8 +149,6 @@ class ScanI2C
 
     FoundDevice firstAccelerometer() const;
 
-    FoundDevice firstMagnetometer() const;
-
     FoundDevice firstAQI() const;
 
     FoundDevice firstRGBLED() const;

src/detect/ScanI2CTwoWire.cpp

@@ -8,7 +8,7 @@
 #if defined(ARCH_PORTDUINO)
 #include "linux/LinuxHardwareI2C.h"
 #endif
-#if !defined(ARCH_PORTDUINO) && !defined(ARCH_STM32)
+#if !defined(ARCH_PORTDUINO) && !defined(ARCH_STM32WL)
 #include "meshUtils.h" // vformat
 
 #endif
@@ -179,22 +179,8 @@ String readSEN5xProductName(TwoWire *i2cBus, uint8_t address)
 #endif
 
 #if HAS_TELEMETRY && !MESHTASTIC_EXCLUDE_ENVIRONMENTAL_SENSOR
-static uint8_t crcSHT2X(const uint8_t *data, uint8_t len)
-{
-    uint8_t crc = 0;
-    for (uint8_t i = 0; i < len; i++) {
-        crc ^= data[i];
-        for (uint8_t bit = 0; bit < 8; bit++) {
-            crc = (crc & 0x80) ? (crc << 1) ^ 0x31 : crc << 1;
-        }
-    }
-    return crc;
-}
-
 bool detectSHT21SerialNumber(TwoWire *i2cBus, uint8_t address)
 {
-    uint8_t serialA[8] = {0};
-    uint8_t serialB[6] = {0};
 
     i2cBus->beginTransmission(address);
     i2cBus->write(0xFA);
@@ -203,13 +189,12 @@ bool detectSHT21SerialNumber(TwoWire *i2cBus, uint8_t address)
     if (i2cBus->endTransmission() != 0)
         return false;
 
-    if (i2cBus->requestFrom(address, (uint8_t)sizeof(serialA)) != sizeof(serialA))
+    if (i2cBus->requestFrom(address, (uint8_t)8) != 8)
         return false;
 
-    for (uint8_t i = 0; i < sizeof(serialA); i++) {
-        if (!i2cBus->available())
-            return false;
-        serialA[i] = i2cBus->read();
+    // Just flush the data
+    while (i2cBus->available() < 8) {
+        i2cBus->read();
     }
 
     i2cBus->beginTransmission(address);
@@ -219,18 +204,16 @@ bool detectSHT21SerialNumber(TwoWire *i2cBus, uint8_t address)
     if (i2cBus->endTransmission() != 0)
         return false;
 
-    if (i2cBus->requestFrom(address, (uint8_t)sizeof(serialB)) != sizeof(serialB))
+    if (i2cBus->requestFrom(address, (uint8_t)6) != 6)
         return false;
 
-    for (uint8_t i = 0; i < sizeof(serialB); i++) {
-        if (!i2cBus->available())
-            return false;
-        serialB[i] = i2cBus->read();
+    // Just flush the data
+    while (i2cBus->available() < 6) {
+        i2cBus->read();
     }
 
-    return crcSHT2X(&serialA[0], 1) == serialA[1] && crcSHT2X(&serialA[2], 1) == serialA[3] &&
-           crcSHT2X(&serialA[4], 1) == serialA[5] && crcSHT2X(&serialA[6], 1) == serialA[7] &&
-           crcSHT2X(&serialB[0], 2) == serialB[2] && crcSHT2X(&serialB[3], 2) == serialB[5];
+    // Assume we detect the SHT21 if something came back from the request
+    return true;
 }
 #endif
 
@@ -360,6 +343,9 @@ void ScanI2CTwoWire::scanPort(I2CPort port, uint8_t *address, uint8_t asize)
                 SCAN_SIMPLE_CASE(ST7567_ADDRESS, SCREEN_ST7567, "ST7567", (uint8_t)addr.address);
 #ifdef HAS_NCP5623
                 SCAN_SIMPLE_CASE(NCP5623_ADDR, NCP5623, "NCP5623", (uint8_t)addr.address);
+#endif
+#ifdef HAS_LP5562
+                SCAN_SIMPLE_CASE(LP5562_ADDR, LP5562, "LP5562", (uint8_t)addr.address);
 #endif
             case XPOWERS_AXP192_AXP2101_ADDRESS:
                 // Do we have the axp2101/192 or the TCA8418
@@ -584,9 +570,6 @@ void ScanI2CTwoWire::scanPort(I2CPort port, uint8_t *address, uint8_t asize)
                 if (registerValue == 0x6A) {
                     type = LSM6DS3;
                     logFoundDevice("LSM6DS3", (uint8_t)addr.address);
-                } else if (registerValue == 0x6B) {
-                    type = ISM330DHCX;
-                    logFoundDevice("ISM330DHCX", (uint8_t)addr.address);
                 } else {
                     type = QMI8658;
                     logFoundDevice("QMI8658", (uint8_t)addr.address);
@@ -594,34 +577,12 @@ void ScanI2CTwoWire::scanPort(I2CPort port, uint8_t *address, uint8_t asize)
                 break;
 
                 SCAN_SIMPLE_CASE(QMC5883L_ADDR, QMC5883L, "QMC5883L", (uint8_t)addr.address)
-            case HMC5883L_ADDR:
-                registerValue = getRegisterValue(ScanI2CTwoWire::RegisterLocation(addr, 0x4FU), 1); // get ID
-                if (registerValue == 0x40) {
-                    type = IIS2MDCTR;
-                    logFoundDevice("IIS2MDCTR", (uint8_t)addr.address);
-                    break;
-                } else {
-                    type = HMC5883L;
-                    logFoundDevice("HMC5883L", (uint8_t)addr.address);
-                    break;
-                }
+                SCAN_SIMPLE_CASE(HMC5883L_ADDR, HMC5883L, "HMC5883L", (uint8_t)addr.address)
 #ifdef HAS_QMA6100P
                 SCAN_SIMPLE_CASE(QMA6100P_ADDR, QMA6100P, "QMA6100P", (uint8_t)addr.address)
 #else
                 SCAN_SIMPLE_CASE(PMSA003I_ADDR, PMSA003I, "PMSA003I", (uint8_t)addr.address)
 #endif
-            case MMC5983MA_ADDR:
-                registerValue = getRegisterValue(ScanI2CTwoWire::RegisterLocation(addr, 0x2F), 1);
-                if (registerValue == 0x30) {
-                    type = MMC5983MA;
-                    logFoundDevice("MMC5983MA", (uint8_t)addr.address);
-#ifdef HAS_LP5562
-                } else {
-                    type = LP5562;
-                    logFoundDevice("LP5562", (uint8_t)addr.address);
-#endif
-                }
-                break;
             case BMA423_ADDR: // this can also be LIS3DH_ADDR_ALT
                 registerValue = getRegisterValue(ScanI2CTwoWire::RegisterLocation(addr, 0x0F), 2);
                 if (registerValue == 0x3300 || registerValue == 0x3333) { // RAK4631 WisBlock has LIS3DH register at 0x3333
@@ -776,8 +737,8 @@ void ScanI2CTwoWire::scanPort(I2CPort port, uint8_t *address, uint8_t asize)
                 }
                 break;
 
-            case ICM20948_ADDR:     // same as BMX160_ADDR, BMI270_ADDR_ALT, ICM42607P_ADDR_ALT, and SEN5X_ADDR
-            case ICM20948_ADDR_ALT: // same as MPU6050_ADDR, BMI270_ADDR, and ICM42607P_ADDR
+            case ICM20948_ADDR:     // same as BMX160_ADDR, BMI270_ADDR_ALT, and SEN5X_ADDR
+            case ICM20948_ADDR_ALT: // same as MPU6050_ADDR, BMI270_ADDR
                 registerValue = getRegisterValue(ScanI2CTwoWire::RegisterLocation(addr, 0x00), 1);
 #ifdef HAS_ICM20948
                 type = ICM20948;
@@ -797,12 +758,6 @@ void ScanI2CTwoWire::scanPort(I2CPort port, uint8_t *address, uint8_t asize)
                     logFoundDevice("BMX160", (uint8_t)addr.address);
                     break;
                 } else {
-                    registerValue = getRegisterValue(ScanI2CTwoWire::RegisterLocation(addr, 0x75), 1); // WHO_AM_I
-                    if (registerValue == 0x60) {
-                        type = ICM42607P;
-                        logFoundDevice("ICM-42607-P", (uint8_t)addr.address);
-                        break;
-                    }
 #if HAS_TELEMETRY && !MESHTASTIC_EXCLUDE_AIR_QUALITY_SENSOR
                     String prod = "";
                     prod = readSEN5xProductName(i2cBus, addr.address);

src/gps/GPS.cpp

@@ -17,10 +17,7 @@
 #include "main.h" // pmu_found
 #include "sleep.h"
 
-#include "FSCommon.h"
 #include "GPSUpdateScheduling.h"
-#include "SPILock.h"
-#include "SafeFile.h"
 #include "cas.h"
 #include "ubx.h"
 
@@ -47,7 +44,7 @@ template <typename T, std::size_t N> std::size_t array_count(const T (&)[N])
 
 #if defined(ARCH_NRF52)
 Uart *GPS::_serial_gps = &GPS_SERIAL_PORT;
-#elif defined(ARCH_ESP32) || defined(ARCH_PORTDUINO) || defined(ARCH_STM32)
+#elif defined(ARCH_ESP32) || defined(ARCH_PORTDUINO) || defined(ARCH_STM32WL)
 HardwareSerial *GPS::_serial_gps = &GPS_SERIAL_PORT;
 #elif defined(ARCH_RP2040)
 SerialUART *GPS::_serial_gps = &GPS_SERIAL_PORT;
@@ -74,112 +71,6 @@ static struct uBloxGnssModelInfo {
 #define GPS_SOL_EXPIRY_MS 5000 // in millis. give 1 second time to combine different sentences. NMEA Frequency isn't higher anyway
 #define NMEA_MSG_GXGSA "GNGSA" // GSA message (GPGSA, GNGSA etc)
 
-namespace
-{
-// Versioned on-disk record for persisted GPS probe results.
-constexpr uint32_t GPS_PROBE_CACHE_MAGIC = 0x47504348UL; // "GPCH"
-constexpr uint16_t GPS_PROBE_CACHE_VERSION = 1;
-constexpr const char *GPS_PROBE_CACHE_FILE = "/prefs/gps_probe_cache.dat";
-constexpr int MIN_PLAUSIBLE_GPS_YEAR = 2020;
-constexpr int MAX_PLAUSIBLE_GPS_YEAR = 2100;
-#ifdef TRACKER_T1000_E
-constexpr uint32_t T1000_E_AIROHA_WAKE_MS = 1000;
-constexpr uint32_t T1000_E_AIROHA_WAKE_INTERVAL_MS = 40;
-#endif
-
-struct GPSProbeCacheRecord {
-    uint32_t magic;
-    uint16_t version;
-    uint16_t reserved;
-    uint32_t baud;
-    uint8_t model;
-};
-
-bool isValidGnssModel(uint8_t model)
-{
-    // Keep persisted values bounded to known enum range.
-    return model <= static_cast<uint8_t>(GNSS_MODEL_CM121);
-}
-
-bool isValidProbeBaud(uint32_t baud)
-{
-    // Conservative sanity range for UART baud values.
-    return baud >= 1200 && baud <= 921600;
-}
-
-template <typename T> void wakeAirohaForActiveProbe(T *serialGps)
-{
-#ifdef TRACKER_T1000_E
-    digitalWrite(PIN_GPS_EN, GPS_EN_ACTIVE);
-    digitalWrite(GPS_RTC_INT, HIGH);
-    delay(3);
-    digitalWrite(GPS_RTC_INT, LOW);
-    delay(50);
-
-    const uint32_t start = millis();
-    do {
-        serialGps->write("$PAIR382,1*2E\r\n");
-        delay(T1000_E_AIROHA_WAKE_INTERVAL_MS);
-    } while (Throttle::isWithinTimespanMs(start, T1000_E_AIROHA_WAKE_MS));
-#elif defined(GNSS_AIROHA)
-    serialGps->write("$PAIR382,1*2E\r\n");
-    delay(20);
-#else
-    (void)serialGps;
-#endif
-}
-
-bool isPlausibleNmeaTime(const struct tm &t)
-{
-    const int year = t.tm_year + 1900;
-    if (year < MIN_PLAUSIBLE_GPS_YEAR || year > MAX_PLAUSIBLE_GPS_YEAR) {
-        return false;
-    }
-
-#ifdef BUILD_EPOCH
-    const int64_t candidate = static_cast<int64_t>(gm_mktime(&t));
-    const int64_t minEpoch = static_cast<int64_t>(BUILD_EPOCH);
-    const int64_t maxEpoch = minEpoch + static_cast<int64_t>(FORTY_YEARS);
-    return candidate >= minEpoch && candidate <= maxEpoch;
-#else
-    return true;
-#endif
-}
-
-template <typename T> bool sawNmeaSentenceAtBaud(T *serialGps, uint32_t timeoutMs)
-{
-    // Lightweight passive check: look for at least one complete
-    // "$...,<field>\n" style NMEA sentence.
-    const uint32_t deadline = millis() + timeoutMs;
-    bool sawDollar = false;
-    bool sawComma = false;
-
-    while ((int32_t)(millis() - deadline) < 0) {
-        while (serialGps->available()) {
-            char c = static_cast<char>(serialGps->read());
-            if (c == '$') {
-                sawDollar = true;
-                sawComma = false;
-                continue;
-            }
-            if (c == ',') {
-                sawComma = true;
-            }
-            if (c == '\n' || c == '\r') {
-                if (sawDollar && sawComma) {
-                    return true;
-                }
-                sawDollar = false;
-                sawComma = false;
-            }
-        }
-        delay(10);
-    }
-
-    return false;
-}
-} // namespace
-
 // For logging
 static const char *getGPSPowerStateString(GPSPowerState state)
 {
@@ -601,201 +492,6 @@ static const int rareSerialSpeeds[3] = {4800, 57600, GPS_BAUDRATE};
 #define GPS_PROBETRIES 2
 #endif
 
-bool GPS::loadProbeCache()
-{
-#ifdef FSCom
-    // Load the last known-good GPS model/baud pair so we can avoid a full probe
-    // sweep on every boot.
-    triedProbeCache = true; // Latch this boot's load attempt, even if no cache.
-    GPSProbeCacheRecord record = {};
-    size_t bytesRead = 0;
-
-    spiLock->lock();
-    auto file = FSCom.open(GPS_PROBE_CACHE_FILE, FILE_O_READ);
-    if (!file) {
-        spiLock->unlock();
-        return false;
-    }
-    bytesRead = file.read(reinterpret_cast<uint8_t *>(&record), sizeof(record));
-    file.close();
-    spiLock->unlock();
-
-    const bool headerValid = (bytesRead == sizeof(record)) && (record.magic == GPS_PROBE_CACHE_MAGIC) &&
-                             (record.version == GPS_PROBE_CACHE_VERSION) && (record.reserved == 0U);
-    if (!headerValid || !isValidGnssModel(record.model) || !isValidProbeBaud(record.baud)) {
-        clearProbeCache(); // Drop corrupt/invalid cache so next boot can
-                           // recover.
-        return false;
-    }
-
-    cachedProbeBaud = static_cast<int32_t>(record.baud);
-    cachedProbeModel = static_cast<GnssModel_t>(record.model);
-    hasProbeCache = true;
-    triedProbeCache = false;
-    LOG_INFO("Loaded cached GPS probe: baud=%u", record.baud);
-    return true;
-#else
-    return false;
-#endif
-}
-
-void GPS::clearProbeCache()
-{
-    // Invalidate in-memory and on-disk cache so next boot is forced to do a
-    // full probe.
-    hasProbeCache = false;
-    triedProbeCache = true;
-    cachedProbeBaud = 0;
-    cachedProbeModel = GNSS_MODEL_UNKNOWN;
-#ifdef FSCom
-    spiLock->lock();
-    if (FSCom.exists(GPS_PROBE_CACHE_FILE)) {
-        FSCom.remove(GPS_PROBE_CACHE_FILE);
-    }
-    spiLock->unlock();
-#endif
-}
-
-bool GPS::saveProbeCache() const
-{
-#ifdef FSCom
-    if (gnssModel == GNSS_MODEL_UNKNOWN || !isValidGnssModel(static_cast<uint8_t>(gnssModel)) ||
-        !isValidProbeBaud(detectedBaud)) {
-        return false;
-    }
-
-    spiLock->lock();
-    FSCom.mkdir("/prefs");
-    spiLock->unlock();
-    GPSProbeCacheRecord record = {
-        GPS_PROBE_CACHE_MAGIC, GPS_PROBE_CACHE_VERSION, 0, static_cast<uint32_t>(detectedBaud), static_cast<uint8_t>(gnssModel),
-    };
-
-    auto file = SafeFile(GPS_PROBE_CACHE_FILE, true);
-    spiLock->lock();
-    const size_t written = file.write(reinterpret_cast<const uint8_t *>(&record), sizeof(record));
-    spiLock->unlock();
-    return (written == sizeof(record)) && file.close();
-#else
-    return false;
-#endif
-}
-
-bool GPS::verifyCachedProbePresence()
-{
-    if (!hasProbeCache || cachedProbeModel == GNSS_MODEL_UNKNOWN || !isValidProbeBaud(cachedProbeBaud)) {
-        return false;
-    }
-
-#if defined(ARCH_NRF52) || defined(ARCH_PORTDUINO) || defined(ARCH_STM32)
-    _serial_gps->end();
-    _serial_gps->begin(cachedProbeBaud);
-#elif defined(ARCH_RP2040)
-    _serial_gps->end();
-    _serial_gps->setFIFOSize(256);
-    _serial_gps->begin(cachedProbeBaud);
-#else
-    if (_serial_gps->baudRate() != cachedProbeBaud) {
-        LOG_DEBUG("Set GPS Baud to %i (cached verify)", cachedProbeBaud);
-        _serial_gps->updateBaudRate(cachedProbeBaud);
-    }
-#endif
-
-    // Before trusting cached model/baud, require either active model-specific
-    // response or passive NMEA flow.
-    clearBuffer();
-    bool present = false;
-
-    // Model-specific "active ping" checks to avoid false stale decisions on
-    // modules that start streaming late.
-    const char *cachedProbeModelName = "UNKNOWN";
-    switch (cachedProbeModel) {
-    case GNSS_MODEL_MTK:
-        cachedProbeModelName = "L76K/MTK";
-        _serial_gps->write("$PCAS06,0*1B\r\n");
-        present = (getACK("$GPTXT,01,01,02,SW=", 700) == GNSS_RESPONSE_OK);
-        break;
-    case GNSS_MODEL_MTK_L76B:
-        cachedProbeModelName = "L76B";
-    case GNSS_MODEL_MTK_PA1010D:
-        if (cachedProbeModel == GNSS_MODEL_MTK_PA1010D)
-            cachedProbeModelName = "PA1010D";
-    case GNSS_MODEL_MTK_PA1616S:
-        if (cachedProbeModel == GNSS_MODEL_MTK_PA1616S)
-            cachedProbeModelName = "PA1616S";
-    case GNSS_MODEL_LS20031:
-        if (cachedProbeModel == GNSS_MODEL_LS20031)
-            cachedProbeModelName = "LS20031";
-        _serial_gps->write("$PMTK605*31\r\n");
-        present = (getACK("$PMTK705", 900) == GNSS_RESPONSE_OK);
-        break;
-    case GNSS_MODEL_AG3335:
-        cachedProbeModelName = "AG3335";
-    case GNSS_MODEL_AG3352:
-        if (cachedProbeModel == GNSS_MODEL_AG3352)
-            cachedProbeModelName = "AG3352";
-        wakeAirohaForActiveProbe(_serial_gps);
-        _serial_gps->write("$PAIR021*39\r\n");
-        present = (getACK("$PAIR021,", 900) == GNSS_RESPONSE_OK);
-        break;
-    case GNSS_MODEL_ATGM336H:
-        cachedProbeModelName = "ATGM336H";
-        _serial_gps->write("$PCAS06,1*1A\r\n");
-        present = (getACK("$GPTXT,01,01,02,HW=ATGM", 900) == GNSS_RESPONSE_OK);
-        break;
-    case GNSS_MODEL_UC6580:
-        cachedProbeModelName = "UC6580/UM600";
-        _serial_gps->write("$PDTINFO\r\n");
-        present = (getACK("UC6580", 900) == GNSS_RESPONSE_OK) || (getACK("UM600", 900) == GNSS_RESPONSE_OK);
-        break;
-    case GNSS_MODEL_CM121:
-        cachedProbeModelName = "CM121";
-        _serial_gps->write("$PDTINFO\r\n");
-        present = (getACK("CM121", 900) == GNSS_RESPONSE_OK);
-        break;
-    case GNSS_MODEL_UBLOX6:
-    case GNSS_MODEL_UBLOX7:
-    case GNSS_MODEL_UBLOX8:
-    case GNSS_MODEL_UBLOX9:
-    case GNSS_MODEL_UBLOX10: {
-        if (cachedProbeModel == GNSS_MODEL_UBLOX6)
-            cachedProbeModelName = "U-blox 6";
-        else if (cachedProbeModel == GNSS_MODEL_UBLOX7)
-            cachedProbeModelName = "U-blox 7";
-        else if (cachedProbeModel == GNSS_MODEL_UBLOX8)
-            cachedProbeModelName = "U-blox 8";
-        else if (cachedProbeModel == GNSS_MODEL_UBLOX9)
-            cachedProbeModelName = "U-blox 9";
-        else if (cachedProbeModel == GNSS_MODEL_UBLOX10)
-            cachedProbeModelName = "U-blox 10";
-
-        uint8_t cfg_rate[] = {0xB5, 0x62, 0x06, 0x08, 0x00, 0x00, 0x00, 0x00};
-        UBXChecksum(cfg_rate, sizeof(cfg_rate));
-        _serial_gps->write(cfg_rate, sizeof(cfg_rate));
-        present = (getACK(0x06, 0x08, 900) != GNSS_RESPONSE_NONE);
-        break;
-    }
-    default:
-        break;
-    }
-
-    if (!present) {
-        // Some modules may not respond to probes while still streaming NMEA, so
-        // allow a passive fallback check.
-        present = sawNmeaSentenceAtBaud(_serial_gps, 3000);
-    }
-    if (!present) {
-        LOG_WARN("Cached GPS probe is stale (%s @ %d), clearing cache", cachedProbeModelName, cachedProbeBaud);
-        clearProbeCache();
-        return false;
-    }
-
-    detectedBaud = cachedProbeBaud;
-    gnssModel = cachedProbeModel;
-    LOG_INFO("Using cached GPS probe: %s @ %d", cachedProbeModelName, detectedBaud);
-    return true;
-}
-
 /**
  * @brief  Setup the GPS based on the model detected.
  *  We detect the GPS by cycling through a set of baud rates, first common then rare.
@@ -808,39 +504,24 @@ bool GPS::setup()
     if (!didSerialInit) {
         int msglen = 0;
         if (tx_gpio && gnssModel == GNSS_MODEL_UNKNOWN) {
-            if (!hasProbeCache && !triedProbeCache) {
-                (void)loadProbeCache();
-            }
-
-            if (hasProbeCache && !triedProbeCache) {
-                triedProbeCache = true;
-                if (!verifyCachedProbePresence()) {
-                    currentStep = 0;
-                    speedSelect = 0;
-                    probeTries = 0;
-                }
-            }
-
-            if (gnssModel == GNSS_MODEL_UNKNOWN && probeTries < GPS_PROBETRIES) {
-                // No usable cache: walk common baud rates first.
+            if (probeTries < GPS_PROBETRIES) {
                 gnssModel = probe(serialSpeeds[speedSelect]);
-                if (gnssModel != GNSS_MODEL_UNKNOWN) {
-                    detectedBaud = serialSpeeds[speedSelect];
-                } else if (currentStep == 0 && ++speedSelect == array_count(serialSpeeds)) {
-                    speedSelect = 0;
-                    ++probeTries;
+                if (gnssModel == GNSS_MODEL_UNKNOWN) {
+                    if (currentStep == 0 && ++speedSelect == array_count(serialSpeeds)) {
+                        speedSelect = 0;
+                        ++probeTries;
+                    }
                 }
             }
             // Rare Serial Speeds
 #ifndef CONFIG_IDF_TARGET_ESP32C6
-            else if (gnssModel == GNSS_MODEL_UNKNOWN && probeTries == GPS_PROBETRIES) {
-                // Then try less common baud rates before giving up.
+            if (probeTries == GPS_PROBETRIES) {
                 gnssModel = probe(rareSerialSpeeds[speedSelect]);
-                if (gnssModel != GNSS_MODEL_UNKNOWN) {
-                    detectedBaud = rareSerialSpeeds[speedSelect];
-                } else if (currentStep == 0 && ++speedSelect == array_count(rareSerialSpeeds)) {
-                    LOG_WARN("Give up on GPS probe and set to %d", GPS_BAUDRATE);
-                    return true;
+                if (gnssModel == GNSS_MODEL_UNKNOWN) {
+                    if (currentStep == 0 && ++speedSelect == array_count(rareSerialSpeeds)) {
+                        LOG_WARN("Give up on GPS probe and set to %d", GPS_BAUDRATE);
+                        return true;
+                    }
                 }
             }
 #endif
@@ -848,7 +529,6 @@ bool GPS::setup()
 
         if (gnssModel != GNSS_MODEL_UNKNOWN) {
             setConnected();
-            (void)saveProbeCache();
         } else {
             return false;
         }
@@ -1160,22 +840,10 @@ void GPS::setPowerState(GPSPowerState newState, uint32_t sleepTime)
     switch (newState) {
     case GPS_ACTIVE:
     case GPS_IDLE:
-        if (oldState == GPS_ACTIVE)
-            break;
-        gotTime = false;
-        if (oldState == GPS_IDLE) // If hardware already awake, no changes needed
+        if (oldState == GPS_ACTIVE || oldState == GPS_IDLE) // If hardware already awake, no changes needed
             break;
         if (oldState != GPS_ACTIVE && oldState != GPS_IDLE) // If hardware just waking now, clear buffer
             clearBuffer();
-#ifdef TRACKER_T1000_E
-        pinMode(GPS_VRTC_EN, OUTPUT);
-        digitalWrite(GPS_VRTC_EN, HIGH);
-        pinMode(GPS_SLEEP_INT, OUTPUT);
-        digitalWrite(GPS_SLEEP_INT, HIGH);
-        pinMode(GPS_RTC_INT, OUTPUT);
-        digitalWrite(GPS_RTC_INT, LOW);
-        pinMode(GPS_RESETB_OUT, INPUT_PULLUP);
-#endif
         powerMon->setState(meshtastic_PowerMon_State_GPS_Active); // Report change for power monitoring (during testing)
         writePinEN(true);                                         // Power (EN pin): on
         setPowerPMU(true);                                        // Power (PMU): on
@@ -1434,11 +1102,6 @@ int32_t GPS::runOnce()
         if (!setup())
             return currentDelay; // Setup failed, re-run in two seconds
 
-        if (gnssModel == GNSS_MODEL_UNKNOWN) {
-            LOG_WARN("GPS not detected; marked not present for this boot");
-            return disable();
-        }
-
         // We have now loaded our saved preferences from flash
         if (config.position.gps_mode != meshtastic_Config_PositionConfig_GpsMode_ENABLED) {
             return disable();
@@ -1487,7 +1150,8 @@ int32_t GPS::runOnce()
         // if gps_update_interval is <=10s, GPS never goes off, so we treat that differently
         uint32_t updateInterval = Default::getConfiguredOrDefaultMs(config.position.gps_update_interval);
 
-        // 1. Got a time for the first time this cycle
+        // 1. Got a time for the first time
+        bool gotTime = (getRTCQuality() >= RTCQualityGPS);
         if (!gotTime && lookForTime()) { // Note: we count on this && short-circuiting and not resetting the RTC time
             gotTime = true;
         }
@@ -1613,7 +1277,7 @@ GnssModel_t GPS::probe(int serialSpeed)
 
     switch (currentStep) {
     case 0: {
-#if defined(ARCH_NRF52) || defined(ARCH_PORTDUINO) || defined(ARCH_STM32)
+#if defined(ARCH_NRF52) || defined(ARCH_PORTDUINO) || defined(ARCH_STM32WL)
         _serial_gps->end();
         _serial_gps->begin(serialSpeed);
 #elif defined(ARCH_RP2040)
@@ -1634,16 +1298,13 @@ GnssModel_t GPS::probe(int serialSpeed)
         digitalWrite(PIN_GPS_RESET, GPS_RESET_MODE); // assert for 10ms
         delay(10);
         digitalWrite(PIN_GPS_RESET, !GPS_RESET_MODE);
-#ifdef TRACKER_T1000_E
-        delay(100);
-#endif
 
         // attempt to detect the chip based on boot messages
         std::vector<ChipInfo> passive_detect = {
             {"AG3335", "$PAIR021,AG3335", GNSS_MODEL_AG3335},
             {"AG3352", "$PAIR021,AG3352", GNSS_MODEL_AG3352},
             {"RYS3520", "$PAIR021,REYAX_RYS3520_V2", GNSS_MODEL_AG3352},
-            {"UC6580", "UC6580", GNSS_MODEL_UC6580},
+            {"UC6580", "UC6580", GNSS_MODEL_UC6580}
             // as L76K is sort of a last ditch effort, we won't attempt to detect it by startup messages for now.
             /*{"L76K", "SW=URANUS", GNSS_MODEL_MTK}*/};
         GnssModel_t detectedDriver = getProbeResponse(500, passive_detect, serialSpeed);
@@ -1670,8 +1331,10 @@ GnssModel_t GPS::probe(int serialSpeed)
     case 1: {
 
         // Unicore UFirebirdII Series: UC6580, UM620, UM621, UM670A, UM680A, or UM681A,or CM121
-        std::vector<ChipInfo> unicore = {
-            {"UC6580", "UC6580", GNSS_MODEL_UC6580}, {"UM600", "UM600", GNSS_MODEL_UC6580}, {"CM121", "CM121", GNSS_MODEL_CM121}};
+        std::vector<ChipInfo> unicore = {{"UC6580", "UC6580", GNSS_MODEL_UC6580},
+                                         {"UM600", "UM600", GNSS_MODEL_UC6580},
+                                         {"CM121", "CM121", GNSS_MODEL_CM121},
+                                         {"CC1167Q", "CC1167Q", GNSS_MODEL_CM121}};
         PROBE_FAMILY("Unicore Family", "$PDTINFO", unicore, 500);
         currentDelay = 20;
         currentStep = 2;
@@ -1689,7 +1352,6 @@ GnssModel_t GPS::probe(int serialSpeed)
     }
     case 3: {
         /* Airoha (Mediatek) AG3335A/M/S, A3352Q, Quectel L89 2.0, SimCom SIM65M */
-        wakeAirohaForActiveProbe(_serial_gps);
         _serial_gps->write("$PAIR062,2,0*3C\r\n"); // GSA OFF to reduce volume
         _serial_gps->write("$PAIR062,3,0*3D\r\n"); // GSV OFF to reduce volume
         _serial_gps->write("$PAIR513*3D\r\n");     // save configuration
@@ -1974,7 +1636,7 @@ std::unique_ptr<GPS> GPS::createGps()
 #elif defined(ARCH_NRF52)
         _serial_gps->setPins(new_gps->rx_gpio, new_gps->tx_gpio);
         _serial_gps->begin(GPS_BAUDRATE);
-#elif defined(ARCH_STM32)
+#elif defined(ARCH_STM32WL)
         _serial_gps->setTx(new_gps->tx_gpio);
         _serial_gps->setRx(new_gps->rx_gpio);
         _serial_gps->begin(GPS_BAUDRATE);
@@ -2021,9 +1683,6 @@ The Unix epoch (or Unix time or POSIX time or Unix timestamp) is the number of s
         t.tm_year = d.year() - 1900;
         t.tm_isdst = false;
         if (t.tm_mon > -1) {
-            if (!isPlausibleNmeaTime(t)) {
-                return false;
-            }
             if (perhapsSetRTC(RTCQualityGPS, t) == RTCSetResultSuccess) {
                 LOG_DEBUG("NMEA GPS time set %02d-%02d-%02d %02d:%02d:%02d age %d", d.year(), d.month(), t.tm_mday, t.tm_hour,
                           t.tm_min, t.tm_sec, ti.age());

src/gps/GPS.h

@@ -155,26 +155,14 @@ class GPS : private concurrency::OSThread
      * @return true if we've acquired a new location
      */
     virtual bool lookForLocation();
-    // Load persisted GPS model+baud from /prefs.
-    bool loadProbeCache();
-    // Clear persisted GPS model+baud cache.
-    void clearProbeCache();
-    // Persist the currently detected GPS model+baud.
-    bool saveProbeCache() const;
-    // Verify the cached model+baud still maps to a live GPS device.
-    bool verifyCachedProbePresence();
 
     GnssModel_t gnssModel = GNSS_MODEL_UNKNOWN;
-    int32_t detectedBaud = GPS_BAUDRATE;
-    int32_t cachedProbeBaud = 0;
-    GnssModel_t cachedProbeModel = GNSS_MODEL_UNKNOWN;
 
     TinyGPSPlus reader;
     uint8_t fixQual = 0; // fix quality from GPGGA
     uint32_t lastChecksumFailCount = 0;
     uint8_t currentStep = 0;
     int32_t currentDelay = 2000;
-    bool gotTime = false;
 
 #ifndef TINYGPS_OPTION_NO_CUSTOM_FIELDS
     // (20210908) TinyGps++ can only read the GPGSA "FIX TYPE" field
@@ -190,10 +178,6 @@ class GPS : private concurrency::OSThread
 
     uint8_t speedSelect = 0;
     uint8_t probeTries = 0;
-    // Cache file is successfully loaded.
-    bool hasProbeCache = false;
-    // Ensures cached probe is attempted once per boot.
-    bool triedProbeCache = false;
 
     /**
      * hasValidLocation - indicates that the position variables contain a complete

src/gps/RTC.cpp

@@ -219,8 +219,8 @@ RTCSetResult perhapsSetRTC(RTCQuality q, const struct timeval *tv, bool forceUpd
     } else if (q == RTCQualityGPS) {
         shouldSet = true;
         LOG_DEBUG("Reapply GPS time: %ld secs", printableEpoch);
-    } else if (q == RTCQualityNTP && !Throttle::isWithinTimespanMs(lastSetMsec, (30 * 60 * 1000UL))) {
-        // Every 30 minutes we will slam in a new NTP or Phone GPS / NTP time, to correct for local RTC clock drift
+    } else if (q == RTCQualityNTP && !Throttle::isWithinTimespanMs(lastSetMsec, (12 * 60 * 60 * 1000UL))) {
+        // Every 12 hrs we will slam in a new NTP or Phone GPS / NTP time, to correct for local RTC clock drift
         shouldSet = true;
         LOG_DEBUG("Reapply external time to correct clock drift %ld secs", printableEpoch);
     } else {

src/graphics/Screen.cpp

@@ -41,7 +41,6 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #include "draw/UIRenderer.h"
 #include "graphics/TFTColorRegions.h"
 #include "modules/CannedMessageModule.h"
-#include "security/LockdownDisplay.h"
 
 #if !MESHTASTIC_EXCLUDE_GPS
 #include "GPS.h"
@@ -51,7 +50,6 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 #include "MeshService.h"
 #include "MessageStore.h"
 #include "RadioLibInterface.h"
-#include "SPILock.h"
 #include "error.h"
 #include "gps/GeoCoord.h"
 #include "gps/RTC.h"
@@ -120,76 +118,8 @@ static inline void prepareFrameColorRegions()
 }
 #endif
 
-#ifdef MESHTASTIC_LOCKDOWN
-// Static lock screen drawn in place of normal frames when
-// meshtastic_security::shouldRedactDisplay() returns true. Renders centered
-// "LOCKED" plus battery so the operator can see the device is alive and
-// charged without leaking any node/channel/message/position content.
-// Draw the LOCKED frame into the host-side framebuffer. Does NOT commit
-// to the panel — the caller is responsible for calling display->display()
-// once it has composited any overlays on top. Committing here would cause
-// visible flicker between "just LOCKED" and "LOCKED + banner overlay" when
-// the pairing-PIN special-case in updateUiFrame paints the overlay after
-// this returns.
-static void drawLockdownLockScreenIntoBuffer(OLEDDisplay *display)
-{
-    display->clear();
-
-    const int w = display->getWidth();
-    const int h = display->getHeight();
-
-    display->setTextAlignment(TEXT_ALIGN_CENTER);
-    display->setFont(FONT_LARGE);
-    display->drawString(w / 2, h / 2 - FONT_HEIGHT_LARGE, "LOCKED");
-
-    display->setFont(FONT_SMALL);
-    char status[32] = "Connect to unlock";
-    if (powerStatus && powerStatus->getHasBattery()) {
-        int pct = powerStatus->getBatteryChargePercent();
-        snprintf(status, sizeof(status), "Battery %d%%", pct);
-    }
-    display->drawString(w / 2, h / 2 + 2, status);
-}
-
-// Convenience wrapper for callers that want the LOCKED frame committed
-// to the panel immediately and have no overlay to compose on top.
-static void drawLockdownLockScreen(OLEDDisplay *display)
-{
-    drawLockdownLockScreenIntoBuffer(display);
-    display->display();
-}
-#endif
-
 static inline void updateUiFrame(OLEDDisplayUi *ui)
 {
-#ifdef MESHTASTIC_LOCKDOWN
-    if (meshtastic_security::shouldRedactDisplay() && screen != nullptr) {
-        OLEDDisplay *display = screen->getDisplayDevice();
-        // Paint LOCKED into the framebuffer WITHOUT committing. We commit
-        // exactly once at the bottom — after any overlay has been composed
-        // on top — so the panel never visibly transitions from "just LOCKED"
-        // to "LOCKED + overlay" mid-frame. Committing twice per cycle was
-        // the source of the H13 flicker.
-        drawLockdownLockScreenIntoBuffer(display);
-        // Special-case the BLE pairing PIN banner. The PIN is needed to
-        // complete first-pair against a locked device, but the lockdown
-        // short-circuit would otherwise hide the PIN entirely. The PIN is
-        // a per-attempt ephemeral pair-handshake artifact, not operator
-        // content, so compositing it over the LOCKED frame is safe.
-        //
-        // Calling ui->update() here would be wrong: it redraws the current
-        // carousel frame (the dashboard) into the framebuffer before the
-        // overlay paints, leaving operator content visible underneath the
-        // banner. Instead we invoke the banner overlay callback directly,
-        // which paints only the banner box on top of the LOCKED pixels we
-        // already have in the framebuffer.
-        if (NotificationRenderer::current_notification_type == notificationTypeEnum::pairing_pin) {
-            NotificationRenderer::drawBannercallback(display, ui->getUiState());
-        }
-        display->display();
-        return;
-    }
-#endif
 #if GRAPHICS_TFT_COLORING_ENABLED
     prepareFrameColorRegions();
 #endif
@@ -233,16 +163,6 @@ static inline float wrapHeading360(float heading)
     return heading;
 }
 
-static inline float wrapDelta180(float delta)
-{
-    if (delta > 180.0f) {
-        delta -= 360.0f;
-    } else if (delta < -180.0f) {
-        delta += 360.0f;
-    }
-    return delta;
-}
-
 void Screen::setHeading(float heading)
 {
     const float wrappedHeading = wrapHeading360(heading);
@@ -254,30 +174,37 @@ void Screen::setHeading(float heading)
     }
 
     // Interpolate using shortest-path angular delta to avoid jumps around 0/360.
-    float delta = wrapDelta180(wrappedHeading - compassHeading);
+    float delta = wrappedHeading - compassHeading;
+    if (delta > 180.0f) {
+        delta -= 360.0f;
+    } else if (delta < -180.0f) {
+        delta += 360.0f;
+    }
 
     // Adaptive filtering:
     // - Strong damping for tiny deltas (jitter)
     // - Faster response for larger turns
     const float absDelta = (delta >= 0.0f) ? delta : -delta;
-    if (absDelta >= 1.0f) {
-        float alpha = 0.35f;
-        if (absDelta > 25.0f) {
-            alpha = 0.85f;
-        } else if (absDelta > 10.0f) {
-            alpha = 0.65f;
-        }
-
-        float step = delta * alpha;
-        const float maxStep = 12.0f;
-        if (step > maxStep) {
-            step = maxStep;
-        } else if (step < -maxStep) {
-            step = -maxStep;
-        }
-
-        compassHeading = wrapHeading360(compassHeading + step);
+    if (absDelta < 1.0f) {
+        return;
     }
+
+    float alpha = 0.35f;
+    if (absDelta > 25.0f) {
+        alpha = 0.85f;
+    } else if (absDelta > 10.0f) {
+        alpha = 0.65f;
+    }
+
+    float step = delta * alpha;
+    const float maxStep = 12.0f;
+    if (step > maxStep) {
+        step = maxStep;
+    } else if (step < -maxStep) {
+        step = -maxStep;
+    }
+
+    compassHeading = wrapHeading360(compassHeading + step);
 }
 
 // ==============================
@@ -655,21 +582,6 @@ void Screen::handleSetOn(bool on, FrameCallback einkScreensaver)
             setScreensaverFrames(einkScreensaver);
 #endif
 
-#ifdef MESHTASTIC_LOCKDOWN
-            // M19: before turning the panel off, paint a safe frame into the
-            // OLED's GDDRAM. The panel retains whatever was last written even
-            // while powered down, so when displayOn() is called later the
-            // screen would otherwise flash the previous frame's content for
-            // 16-50 ms before the next ui->update() lands. Painting the
-            // LOCKED frame now ensures the only thing the operator (or
-            // someone over their shoulder) can see on wake is the redacted
-            // view. Gated on lockdown — non-lockdown builds keep the
-            // previous frame as a UX cue that the display is just dimmed.
-            // dispdev is dereferenced unguarded throughout this file (incl.
-            // displayOff() just below), so no null check here.
-            drawLockdownLockScreen(dispdev);
-#endif
-
 #ifdef PIN_EINK_EN
             digitalWrite(PIN_EINK_EN, LOW);
 #elif defined(PCA_PIN_EINK_EN)
@@ -743,10 +655,6 @@ void Screen::setup()
         brightness = uiconfig.screen_brightness;
     }
 
-    // Restore which frames the user has hidden (persisted across reboots).
-    // Must happen before the first setFrames().
-    loadFrameVisibility();
-
     // Detect OLED subtype (if supported by board variant)
 #ifdef AutoOLEDWire_h
     if (isAUTOOled)
@@ -789,27 +697,6 @@ void Screen::setup()
 #endif
     LOG_INFO("Applied screen brightness: %d", brightness);
 
-#if defined(MESHTASTIC_LOCKDOWN) && defined(USE_EINK)
-    // M20: e-ink panels physically retain the last-rendered image without
-    // power, so a power-cycled lockdown handheld would keep showing
-    // operator-identifying content (position, messages, node info) until
-    // the firmware's first natural refresh — which on e-ink can be seconds
-    // into boot. Force a full refresh to the LOCKED frame here, immediately
-    // after the display is initialised and before any other rendering, so
-    // the persistent pixels are wiped to the redacted view before an
-    // observer can see them.
-    if (meshtastic_security::shouldRedactDisplay()) {
-        drawLockdownLockScreen(dispdev);
-#if defined(USE_EINK_PARALLELDISPLAY)
-        // Parallel-display variants drive refresh through a different path;
-        // a bare drawLockdownLockScreen above lands the frame into the
-        // panel buffer and the next ui->update() commits it as normal.
-#else
-        static_cast<EInkDisplay *>(dispdev)->forceDisplay();
-#endif
-    }
-#endif
-
     // Set custom overlay callbacks
     static OverlayCallback overlays[] = {
         graphics::UIRenderer::drawNavigationBar // Custom indicator icons for each frame
@@ -917,16 +804,10 @@ void Screen::setOn(bool on, FrameCallback einkScreensaver)
     if (cardKbI2cImpl)
         cardKbI2cImpl->toggleBacklight(on);
 #endif
-    if (!on) {
-#ifdef MESHTASTIC_LOCKDOWN
-        // Screen powering off (idle timeout, shutdown, deep sleep) latches
-        // the screen-lock. Next time the display wakes it shows the LOCKED
-        // frame until a client authenticates with the passphrase.
-        meshtastic_security::lockScreen();
-#endif
+    if (!on)
         // We handle off commands immediately, because they might be called because the CPU is shutting down
         handleSetOn(false, einkScreensaver);
-    } else
+    else
         enqueueCmd(ScreenCmd{.cmd = Cmd::SET_ON});
 }
 
@@ -1033,17 +914,7 @@ int32_t Screen::runOnce()
 #endif
 
 #ifndef DISABLE_WELCOME_UNSET
-    bool suppressRegionOnboard = false;
-#ifdef MESHTASTIC_LOCKDOWN
-    // While lockdown is active and storage is still locked, config.lora.region
-    // is a deliberate UNSET placeholder — the real region lives in encrypted
-    // storage and is restored on unlock (see NodeDB's locked-boot path). Don't
-    // pop the region picker over the lock screen: it would trap input, and the
-    // operator can't set a region until they unlock anyway.
-    suppressRegionOnboard = meshtastic_security::shouldRedactDisplay();
-#endif
-    if (!suppressRegionOnboard && !NotificationRenderer::isOverlayBannerShowing() &&
-        config.lora.region == meshtastic_Config_LoRaConfig_RegionCode_UNSET) {
+    if (!NotificationRenderer::isOverlayBannerShowing() && config.lora.region == meshtastic_Config_LoRaConfig_RegionCode_UNSET) {
 #if defined(OLED_TINY)
         menuHandler::LoraRegionPicker();
 #else
@@ -1545,9 +1416,6 @@ void Screen::toggleFrameVisibility(const std::string &frameName)
     if (frameName == "chirpy") {
         hiddenFrames.chirpy = !hiddenFrames.chirpy;
     }
-
-    // Save the new visibility state so it survives a reboot.
-    saveFrameVisibility();
 }
 
 bool Screen::isFrameHidden(const std::string &frameName) const
@@ -1586,167 +1454,6 @@ bool Screen::isFrameHidden(const std::string &frameName) const
     return false;
 }
 
-// ---------------------------------------------------------------------------
-// Frame visibility persistence
-//
-// The set of hideable frames varies by build (USE_EINK, HAS_GPS, ...), so we
-// serialize to a fixed bitmask where each frame name owns a permanent bit
-// position. Bits for frames that don't exist in the current build are simply
-// left untouched, which keeps the saved file portable across firmware variants.
-// ---------------------------------------------------------------------------
-namespace
-{
-static const char *frameVisibilityFileName = "/prefs/framevis";
-constexpr uint32_t FRAMEVIS_MAGIC = 0x53495646; // "FVIS" little-endian
-constexpr uint8_t FRAMEVIS_VERSION = 1;
-
-// Permanent bit assignments. Never renumber these; only append new ones.
-enum FrameVisBit : uint8_t {
-    FVBIT_TEXT_MESSAGE = 0,
-    FVBIT_WAYPOINT = 1,
-    FVBIT_WIFI = 2,
-    FVBIT_SYSTEM = 3,
-    FVBIT_HOME = 4,
-    FVBIT_CLOCK = 5,
-    FVBIT_NODELIST_NODES = 6,
-    FVBIT_NODELIST_LOCATION = 7,
-    FVBIT_NODELIST_LASTHEARD = 8,
-    FVBIT_NODELIST_HOPSIGNAL = 9,
-    FVBIT_NODELIST_DISTANCE = 10,
-    FVBIT_NODELIST_BEARINGS = 11,
-    FVBIT_GPS = 12,
-    FVBIT_LORA = 13,
-    FVBIT_SHOW_FAVORITES = 14,
-    FVBIT_CHIRPY = 15,
-};
-
-struct __attribute__((packed)) FrameVisFile {
-    uint32_t magic;
-    uint8_t version;
-    uint32_t mask;
-};
-
-inline void setBit(uint32_t &mask, uint8_t bit, bool value)
-{
-    if (value)
-        mask |= (1UL << bit);
-    else
-        mask &= ~(1UL << bit);
-}
-
-inline bool getBit(uint32_t mask, uint8_t bit)
-{
-    return (mask & (1UL << bit)) != 0;
-}
-} // namespace
-
-uint32_t Screen::packHiddenFrames() const
-{
-    uint32_t mask = 0;
-    setBit(mask, FVBIT_TEXT_MESSAGE, hiddenFrames.textMessage);
-    setBit(mask, FVBIT_WAYPOINT, hiddenFrames.waypoint);
-    setBit(mask, FVBIT_WIFI, hiddenFrames.wifi);
-    setBit(mask, FVBIT_SYSTEM, hiddenFrames.system);
-    setBit(mask, FVBIT_HOME, hiddenFrames.home);
-    setBit(mask, FVBIT_CLOCK, hiddenFrames.clock);
-#ifndef USE_EINK
-    setBit(mask, FVBIT_NODELIST_NODES, hiddenFrames.nodelist_nodes);
-    setBit(mask, FVBIT_NODELIST_LOCATION, hiddenFrames.nodelist_location);
-#endif
-#ifdef USE_EINK
-    setBit(mask, FVBIT_NODELIST_LASTHEARD, hiddenFrames.nodelist_lastheard);
-    setBit(mask, FVBIT_NODELIST_HOPSIGNAL, hiddenFrames.nodelist_hopsignal);
-    setBit(mask, FVBIT_NODELIST_DISTANCE, hiddenFrames.nodelist_distance);
-#endif
-#if HAS_GPS
-#ifdef USE_EINK
-    setBit(mask, FVBIT_NODELIST_BEARINGS, hiddenFrames.nodelist_bearings);
-#endif
-    setBit(mask, FVBIT_GPS, hiddenFrames.gps);
-#endif
-    setBit(mask, FVBIT_LORA, hiddenFrames.lora);
-    setBit(mask, FVBIT_SHOW_FAVORITES, hiddenFrames.show_favorites);
-    setBit(mask, FVBIT_CHIRPY, hiddenFrames.chirpy);
-    return mask;
-}
-
-void Screen::applyHiddenFramesMask(uint32_t mask)
-{
-    hiddenFrames.textMessage = getBit(mask, FVBIT_TEXT_MESSAGE);
-    hiddenFrames.waypoint = getBit(mask, FVBIT_WAYPOINT);
-    hiddenFrames.wifi = getBit(mask, FVBIT_WIFI);
-    hiddenFrames.system = getBit(mask, FVBIT_SYSTEM);
-    hiddenFrames.home = getBit(mask, FVBIT_HOME);
-    hiddenFrames.clock = getBit(mask, FVBIT_CLOCK);
-#ifndef USE_EINK
-    hiddenFrames.nodelist_nodes = getBit(mask, FVBIT_NODELIST_NODES);
-    hiddenFrames.nodelist_location = getBit(mask, FVBIT_NODELIST_LOCATION);
-#endif
-#ifdef USE_EINK
-    hiddenFrames.nodelist_lastheard = getBit(mask, FVBIT_NODELIST_LASTHEARD);
-    hiddenFrames.nodelist_hopsignal = getBit(mask, FVBIT_NODELIST_HOPSIGNAL);
-    hiddenFrames.nodelist_distance = getBit(mask, FVBIT_NODELIST_DISTANCE);
-#endif
-#if HAS_GPS
-#ifdef USE_EINK
-    hiddenFrames.nodelist_bearings = getBit(mask, FVBIT_NODELIST_BEARINGS);
-#endif
-    hiddenFrames.gps = getBit(mask, FVBIT_GPS);
-#endif
-    hiddenFrames.lora = getBit(mask, FVBIT_LORA);
-    hiddenFrames.show_favorites = getBit(mask, FVBIT_SHOW_FAVORITES);
-    hiddenFrames.chirpy = getBit(mask, FVBIT_CHIRPY);
-}
-
-void Screen::loadFrameVisibility()
-{
-#ifdef FSCom
-    spiLock->lock();
-    auto file = FSCom.open(frameVisibilityFileName, FILE_O_READ);
-    if (file) {
-        FrameVisFile data{};
-        bool ok = file.read((uint8_t *)&data, sizeof(data)) == sizeof(data) && data.magic == FRAMEVIS_MAGIC &&
-                  data.version == FRAMEVIS_VERSION;
-        file.close();
-        spiLock->unlock();
-        if (ok) {
-            applyHiddenFramesMask(data.mask);
-            LOG_INFO("Loaded frame visibility (mask 0x%08x)", data.mask);
-        } else {
-            LOG_WARN("Frame visibility file invalid, keeping defaults");
-        }
-        return;
-    }
-    spiLock->unlock();
-    LOG_DEBUG("No saved frame visibility, using defaults");
-#endif
-}
-
-void Screen::saveFrameVisibility()
-{
-#ifdef FSCom
-    spiLock->lock();
-    FSCom.mkdir("/prefs");
-    if (FSCom.exists(frameVisibilityFileName))
-        FSCom.remove(frameVisibilityFileName);
-
-    auto file = FSCom.open(frameVisibilityFileName, FILE_O_WRITE);
-    if (file) {
-        FrameVisFile data{};
-        data.magic = FRAMEVIS_MAGIC;
-        data.version = FRAMEVIS_VERSION;
-        data.mask = packHiddenFrames();
-        file.write((uint8_t *)&data, sizeof(data));
-        file.flush();
-        file.close();
-        LOG_INFO("Saved frame visibility (mask 0x%08x)", data.mask);
-    } else {
-        LOG_WARN("Failed to open %s for writing", frameVisibilityFileName);
-    }
-    spiLock->unlock();
-#endif
-}
-
 void Screen::handleStartFirmwareUpdateScreen()
 {
     LOG_DEBUG("Show firmware screen");
@@ -1759,15 +1466,6 @@ void Screen::handleStartFirmwareUpdateScreen()
 
 void Screen::blink()
 {
-#ifdef MESHTASTIC_LOCKDOWN
-    // L4: defensive guard. blink() paints arbitrary geometry, not node
-    // data, so it doesn't actually leak today. But it bypasses the normal
-    // ui->update() path that the lockdown short-circuit gates, so any
-    // future change that puts content into blink would silently leak past
-    // redaction. Refuse to draw when the redaction latch is set.
-    if (meshtastic_security::shouldRedactDisplay())
-        return;
-#endif
     setFastFramerate();
     uint8_t count = 10;
     dispdev->setBrightness(254);

src/graphics/Screen.h

@@ -12,21 +12,7 @@
 #define getStringCenteredX(s) ((SCREEN_WIDTH - display->getStringWidth(s)) / 2)
 namespace graphics
 {
-enum notificationTypeEnum {
-    none,
-    text_banner,
-    selection_picker,
-    node_picker,
-    number_picker,
-    hex_picker,
-    text_input,
-    // BLE pairing PIN banner. Treated specially by the lockdown short-circuit
-    // in Screen.cpp: the PIN is ephemeral (regenerated per pair attempt) and
-    // not a real secret, so we allow ui->update() to composite it over the
-    // LOCKED frame. Without this, a first-pair on a locked device cannot
-    // complete because the PIN never renders.
-    pairing_pin,
-};
+enum notificationTypeEnum { none, text_banner, selection_picker, node_picker, number_picker, text_input };
 
 struct BannerOverlayOptions {
     const char *message;
@@ -637,11 +623,6 @@ class Screen : public concurrency::OSThread
     void toggleFrameVisibility(const std::string &frameName);
     bool isFrameHidden(const std::string &frameName) const;
 
-    // Persist / restore which frames are hidden, across reboots.
-    // Stored as a single uint32 bitmask in /prefs (see Screen.cpp for the format).
-    void loadFrameVisibility();
-    void saveFrameVisibility();
-
 #ifdef USE_EINK
     /// Draw an image to remain on E-Ink display after screen off
     void setScreensaverFrames(FrameCallback einkScreensaver = NULL);
@@ -757,11 +738,6 @@ class Screen : public concurrency::OSThread
         bool chirpy = true;
     } hiddenFrames;
 
-    // Convert hiddenFrames to a uint32 bitmask. Bit positions are fixed per
-    // frame name (see Screen.cpp).
-    uint32_t packHiddenFrames() const;
-    void applyHiddenFramesMask(uint32_t mask);
-
     /// Try to start drawing ASAP
     void setFastFramerate();
 

src/graphics/SharedUIDisplay.cpp

@@ -578,11 +578,7 @@ void drawCommonFooter(OLEDDisplay *display, int16_t x, int16_t y)
 #endif
 
     display->setColor(BLACK);
-#if GRAPHICS_TFT_COLORING_ENABLED
     display->fillRect(0, footerY, SCREEN_WIDTH, footerH);
-#else
-    display->fillRect(0, footerY, connection_icon_width + 1, footerH);
-#endif
     display->setColor(WHITE);
     if (currentResolution == ScreenResolution::High) {
         const int bytesPerRow = (connection_icon_width + 7) / 8;

src/graphics/TFTDisplay.cpp

@@ -1458,8 +1458,7 @@ void TFTDisplay::sendCommand(uint8_t com)
             digitalWrite(portduino_config.displayBacklight.pin, TFT_BACKLIGHT_ON);
 #elif defined(HACKADAY_COMMUNICATOR)
         tft->displayOn();
-#elif !defined(RAK14014) && !defined(M5STACK) && !defined(UNPHONE) && !defined(HELTEC_MESH_NODE_T096) &&                         \
-    !defined(HELTEC_MESH_NODE_T1)
+#elif !defined(RAK14014) && !defined(M5STACK) && !defined(UNPHONE) && !defined(HELTEC_MESH_NODE_T096)
         tft->wakeup();
         tft->powerSaveOff();
 #endif
@@ -1470,7 +1469,7 @@ void TFTDisplay::sendCommand(uint8_t com)
 #ifdef UNPHONE
         unphone.backlight(true); // using unPhone library
 #endif
-#if defined(RAK14014) || defined(HELTEC_MESH_NODE_T096) || defined(HELTEC_MESH_NODE_T1)
+#if defined(RAK14014) || defined(HELTEC_MESH_NODE_T096)
 #elif !defined(M5STACK) && !defined(ST7789_CS) &&                                                                                \
     !defined(HACKADAY_COMMUNICATOR) // T-Deck gets brightness set in Screen.cpp in the handleSetOn function
         tft->setBrightness(172);
@@ -1486,8 +1485,7 @@ void TFTDisplay::sendCommand(uint8_t com)
             digitalWrite(portduino_config.displayBacklight.pin, !TFT_BACKLIGHT_ON);
 #elif defined(HACKADAY_COMMUNICATOR)
         tft->displayOff();
-#elif !defined(RAK14014) && !defined(M5STACK) && !defined(UNPHONE) && !defined(HELTEC_MESH_NODE_T096) &&                         \
-    !defined(HELTEC_MESH_NODE_T1)
+#elif !defined(RAK14014) && !defined(M5STACK) && !defined(UNPHONE) && !defined(HELTEC_MESH_NODE_T096)
         tft->sleep();
         tft->powerSaveOn();
 #endif
@@ -1498,7 +1496,7 @@ void TFTDisplay::sendCommand(uint8_t com)
 #ifdef UNPHONE
         unphone.backlight(false); // using unPhone library
 #endif
-#if defined(RAK14014) || defined(HELTEC_MESH_NODE_T096) || defined(HELTEC_MESH_NODE_T1)
+#if defined(RAK14014) || defined(HELTEC_MESH_NODE_T096)
 #elif !defined(M5STACK) && !defined(HACKADAY_COMMUNICATOR)
         tft->setBrightness(0);
 #endif
@@ -1513,7 +1511,7 @@ void TFTDisplay::sendCommand(uint8_t com)
 
 void TFTDisplay::setDisplayBrightness(uint8_t _brightness)
 {
-#if defined(RAK14014) || defined(HELTEC_MESH_NODE_T096) || defined(HELTEC_MESH_NODE_T1)
+#if defined(RAK14014) || defined(HELTEC_MESH_NODE_T096)
     // todo
 #elif !defined(HACKADAY_COMMUNICATOR)
     tft->setBrightness(_brightness);
@@ -1533,7 +1531,7 @@ bool TFTDisplay::hasTouch(void)
 {
 #ifdef RAK14014
     return true;
-#elif !defined(M5STACK) && !defined(HACKADAY_COMMUNICATOR) && !defined(HELTEC_MESH_NODE_T096) && !defined(HELTEC_MESH_NODE_T1)
+#elif !defined(M5STACK) && !defined(HACKADAY_COMMUNICATOR) && !defined(HELTEC_MESH_NODE_T096)
     return tft->touch() != nullptr;
 #else
     return false;
@@ -1552,7 +1550,7 @@ bool TFTDisplay::getTouch(int16_t *x, int16_t *y)
     } else {
         return false;
     }
-#elif !defined(M5STACK) && !defined(HACKADAY_COMMUNICATOR) && !defined(HELTEC_MESH_NODE_T096) && !defined(HELTEC_MESH_NODE_T1)
+#elif !defined(M5STACK) && !defined(HACKADAY_COMMUNICATOR) && !defined(HELTEC_MESH_NODE_T096)
     return tft->getTouch(x, y);
 #else
     return false;
@@ -1569,7 +1567,7 @@ bool TFTDisplay::connect()
 {
     concurrency::LockGuard g(spiLock);
     LOG_INFO("Do TFT init");
-#if defined(RAK14014) || defined(HELTEC_MESH_NODE_T096) || defined(HELTEC_MESH_NODE_T1)
+#if defined(RAK14014) || defined(HELTEC_MESH_NODE_T096)
     tft = new TFT_eSPI;
 #elif defined(HACKADAY_COMMUNICATOR)
     bus = new Arduino_ESP32SPI(TFT_DC, TFT_CS, 38 /* SCK */, 21 /* MOSI */, GFX_NOT_DEFINED /* MISO */, HSPI /* spi_num */);

src/graphics/VirtualKeyboard.cpp

@@ -142,9 +142,8 @@ void VirtualKeyboard::draw(OLEDDisplay *display, int16_t offsetX, int16_t offset
         if (keyboardStartY < 0)
             keyboardStartY = 0;
     } else {
-        // Default (non-wide, non-64px) e.g. SH1107 128x128:
-        // cellH = FONT_HEIGHT_SMALL - 2 so rows are tighter while still hosting the font
-        cellH = std::max((int)KEY_HEIGHT, FONT_HEIGHT_SMALL - 2);
+        // Default (non-wide, non-64px) behavior: use key height heuristic and place at bottom
+        cellH = KEY_HEIGHT;
         int keyboardHeight = KEYBOARD_ROWS * cellH;
         keyboardStartY = screenH - keyboardHeight;
         if (keyboardStartY < 0)
@@ -447,8 +446,11 @@ void VirtualKeyboard::drawKey(OLEDDisplay *display, const VirtualKey &key, bool
         if (textX < x)
             textX = x; // guard
     } else {
-        // Use ceil rounding for all screens (consistent with 128x64 behavior for numbers)
-        textX = x + (width - textWidth + 1) / 2;
+        if (display->getHeight() <= 64 && (key.character >= '0' && key.character <= '9')) {
+            textX = x + (width - textWidth + 1) / 2;
+        } else {
+            textX = x + (width - textWidth) / 2;
+        }
     }
     int contentTop = y;
     int contentH = height;
@@ -744,4 +746,4 @@ bool VirtualKeyboard::isTimedOut() const
 }
 
 } // namespace graphics
-#endif
+#endif

src/graphics/draw/ClockRenderer.cpp

@@ -183,13 +183,9 @@ void drawDigitalClockFrame(OLEDDisplay *display, OLEDDisplayUiState *state, int1
     static float segmentHeight = SEGMENT_HEIGHT * 0.75f;
 
     if (!scaleInitialized) {
-#ifdef DISPLAY_FORCE_SMALL_FONTS
-        float screenwidth_target_ratio = 0.70f; // Target 70% of display width (adjustable)
-#else
         float screenwidth_target_ratio = 0.80f; // Target 80% of display width (adjustable)
-#endif
-        float max_scale = 3.5f; // Safety limit to avoid runaway scaling
-        float step = 0.05f;     // Step increment per iteration
+        float max_scale = 3.5f;                 // Safety limit to avoid runaway scaling
+        float step = 0.05f;                     // Step increment per iteration
 
         float target_width = display->getWidth() * screenwidth_target_ratio;
         float target_height =

src/graphics/draw/MenuHandler.cpp

@@ -2,7 +2,6 @@
 #if HAS_SCREEN
 #include "ClockRenderer.h"
 #include "Default.h"
-#include "DisplayFormatters.h"
 #include "GPS.h"
 #include "MenuHandler.h"
 #include "MeshRadio.h"
@@ -126,7 +125,6 @@ void launchReplyForMessage(const StoredMessage &message, bool freetext)
 
 menuHandler::screenMenus menuHandler::menuQueue = MenuNone;
 uint32_t menuHandler::pickedNodeNum = 0;
-meshtastic_Config_LoRaConfig_RegionCode menuHandler::pendingRegion = meshtastic_Config_LoRaConfig_RegionCode_UNSET;
 bool test_enabled = false;
 uint8_t test_count = 0;
 
@@ -175,48 +173,6 @@ void menuHandler::OnboardMessage()
     screen->showOverlayBanner(bannerOptions);
 }
 
-static void applyLoraRegion(meshtastic_Config_LoRaConfig_RegionCode region, bool isHam)
-{
-    config.lora.region = region;
-    config.lora.channel_num = 0; // Reset to default channel
-
-    // Reconcile the preset with the explicitly chosen region: a preset locked to another
-    // region would leave config.lora invalid until applyModemConfig() repairs it with
-    // error/critical-error side effects — or, for the swappable EU trio, the clamp would
-    // flip the region right back. The user picked the region, so the preset follows it.
-    const RegionInfo *newRegion = getRegion(region);
-    if (config.lora.use_preset && !newRegion->supportsPreset(config.lora.modem_preset)) {
-        LOG_INFO("Preset %s not available in %s, using default %s",
-                 DisplayFormatters::getModemPresetDisplayName(config.lora.modem_preset, false, true), newRegion->name,
-                 DisplayFormatters::getModemPresetDisplayName(newRegion->getDefaultPreset(), false, true));
-        config.lora.modem_preset = newRegion->getDefaultPreset();
-    }
-
-    if (isHam && adminModule) {
-        meshtastic_HamParameters hamParams = meshtastic_HamParameters_init_zero;
-        strncpy(hamParams.call_sign, "N0CALL", sizeof(hamParams.call_sign) - 1);
-        strncpy(hamParams.short_name, "N0CL", sizeof(hamParams.short_name));
-        hamParams.tx_power = config.lora.tx_power;
-        hamParams.frequency = config.lora.override_frequency;
-        adminModule->handleSetHamMode(hamParams);
-    }
-    auto changes = SEGMENT_CONFIG;
-#if !(MESHTASTIC_EXCLUDE_PKI_KEYGEN || MESHTASTIC_EXCLUDE_PKI)
-    if (crypto) {
-        crypto->ensurePkiKeys(config.security, owner);
-    }
-#endif
-    initRegion();
-    if (getEffectiveDutyCycle() < 100) {
-        config.lora.ignore_mqtt = true;
-    }
-    if (strncmp(moduleConfig.mqtt.root, default_mqtt_root, strlen(default_mqtt_root)) == 0) {
-        snprintf(moduleConfig.mqtt.root, sizeof(moduleConfig.mqtt.root), "%s/%s", default_mqtt_root, myRegion->name);
-        changes |= SEGMENT_MODULECONFIG;
-    }
-    service->reloadConfig(changes);
-}
-
 void menuHandler::LoraRegionPicker(uint32_t duration)
 {
     static const LoraRegionOption regionOptions[] = {
@@ -224,8 +180,6 @@ void menuHandler::LoraRegionPicker(uint32_t duration)
         {"US", OptionsAction::Select, meshtastic_Config_LoRaConfig_RegionCode_US},
         {"EU_433", OptionsAction::Select, meshtastic_Config_LoRaConfig_RegionCode_EU_433},
         {"EU_868", OptionsAction::Select, meshtastic_Config_LoRaConfig_RegionCode_EU_868},
-        {"EU_866", OptionsAction::Select, meshtastic_Config_LoRaConfig_RegionCode_EU_866},
-        {"EU_868_NARROW", OptionsAction::Select, meshtastic_Config_LoRaConfig_RegionCode_EU_N_868},
         {"CN", OptionsAction::Select, meshtastic_Config_LoRaConfig_RegionCode_CN},
         {"JP", OptionsAction::Select, meshtastic_Config_LoRaConfig_RegionCode_JP},
         {"ANZ", OptionsAction::Select, meshtastic_Config_LoRaConfig_RegionCode_ANZ},
@@ -249,11 +203,6 @@ void menuHandler::LoraRegionPicker(uint32_t duration)
         {"KZ_863", OptionsAction::Select, meshtastic_Config_LoRaConfig_RegionCode_KZ_863},
         {"NP_865", OptionsAction::Select, meshtastic_Config_LoRaConfig_RegionCode_NP_865},
         {"BR_902", OptionsAction::Select, meshtastic_Config_LoRaConfig_RegionCode_BR_902},
-        {"ITU1_2M (144-146)", OptionsAction::Select, meshtastic_Config_LoRaConfig_RegionCode_ITU1_2M},
-        {"ITU2_2M (144-148)", OptionsAction::Select, meshtastic_Config_LoRaConfig_RegionCode_ITU2_2M},
-        {"ITU3_2M (144-148)", OptionsAction::Select, meshtastic_Config_LoRaConfig_RegionCode_ITU3_2M},
-        {"ITU2_125CM (220-225)", OptionsAction::Select, meshtastic_Config_LoRaConfig_RegionCode_ITU2_125CM},
-
     };
 
     constexpr size_t regionCount = sizeof(regionOptions) / sizeof(regionOptions[0]);
@@ -275,34 +224,37 @@ void menuHandler::LoraRegionPicker(uint32_t duration)
                 return;
             }
 
-            // Guard: without a reboot, reconfigure() applies the region directly, so reject
-            // regions this node can't use up front: unrecognized codes, licensed-only regions,
-            // and radio hardware mismatches (2.4 GHz vs sub-GHz) — the same checks the admin
-            // set-config path applies, but side-effect-free: ignoring a menu selection should
-            // not record a critical error or notify clients. getRadio() used to catch hardware
-            // mismatches post-reboot only.
-            auto candidateLora = config.lora;
-            candidateLora.region = selectedRegion;
-            char regionErr[160];
-            if (!RadioInterface::checkConfigRegion(candidateLora, regionErr, sizeof(regionErr))) {
-                LOG_WARN("Ignoring region selection: %s", regionErr);
+            // Guard: without a reboot, reconfigure() applies the region directly.
+            // Reject LORA_24 on sub-GHz-only hardware — getRadio() used to catch this post-reboot.
+            // TODO: change this to either use the validateLoraConfig() logic or at least check the region for wideLora
+            // rather than a hardcoded check for LORA_24.
+            if (selectedRegion == meshtastic_Config_LoRaConfig_RegionCode_LORA_24 &&
+                !(RadioLibInterface::instance && RadioLibInterface::instance->wideLora())) {
+                LOG_WARN("Radio hardware does not support 2.4 GHz; ignoring region selection");
                 return;
             }
 
-            bool hamMode = getRegion(selectedRegion)->profile->licensedOnly;
-            if (hamMode) {
-                LOG_INFO("User chose an amateur radio mode region");
-                pendingRegion = selectedRegion;
-                menuQueue = HamModeConfirm;
-                screen->runNow();
-            } else if (owner.is_licensed) {
-                LOG_INFO("Licensed user chose a non-ham region; prompting to revert licensed mode");
-                pendingRegion = selectedRegion;
-                menuQueue = LicensedToNormalConfirm;
-                screen->runNow();
-            } else {
-                applyLoraRegion(selectedRegion, false);
+            config.lora.region = selectedRegion;
+            auto changes = SEGMENT_CONFIG;
+
+#if !(MESHTASTIC_EXCLUDE_PKI_KEYGEN || MESHTASTIC_EXCLUDE_PKI)
+            if (crypto) {
+                crypto->ensurePkiKeys(config.security, owner);
             }
+#endif
+            config.lora.tx_enabled = true;
+            initRegion();
+            if (myRegion->dutyCycle < 100) {
+                config.lora.ignore_mqtt = true; // Ignore MQTT by default if region has a duty cycle limit
+            }
+
+            if (strncmp(moduleConfig.mqtt.root, default_mqtt_root, strlen(default_mqtt_root)) == 0) {
+                //  Default broker is in use, so subscribe to the appropriate MQTT root topic for this region
+                sprintf(moduleConfig.mqtt.root, "%s/%s", default_mqtt_root, myRegion->name);
+                changes |= SEGMENT_MODULECONFIG;
+            }
+
+            service->reloadConfig(changes);
         });
 
     bannerOptions.durationMs = duration;
@@ -319,38 +271,6 @@ void menuHandler::LoraRegionPicker(uint32_t duration)
     screen->showOverlayBanner(bannerOptions);
 }
 
-void menuHandler::hamModeConfirmMenu()
-{
-    static const char *confirmOptions[] = {"No", "Yes"};
-    BannerOverlayOptions confirmBanner;
-    confirmBanner.message = "I confirm I am a\nlicensed amateur\nradio operator";
-    confirmBanner.optionsArrayPtr = confirmOptions;
-    confirmBanner.optionsCount = 2;
-    confirmBanner.bannerCallback = [](int selected) {
-        if (selected == 1)
-            applyLoraRegion(pendingRegion, true);
-    };
-    screen->showOverlayBanner(confirmBanner);
-}
-
-void menuHandler::licensedToNormalConfirmMenu()
-{
-    static const char *confirmOptions[] = {"Keep licensed", "Revert to Normal"};
-    BannerOverlayOptions confirmBanner;
-    confirmBanner.message = "Revert licensed\nmode? This will\nre-enable encryption.";
-    confirmBanner.optionsArrayPtr = confirmOptions;
-    confirmBanner.optionsCount = 2;
-    confirmBanner.bannerCallback = [](int selected) {
-        if (selected == 1) {
-            owner.is_licensed = false;
-            config.lora.override_duty_cycle = false;
-            service->reloadOwner(false);
-        }
-        applyLoraRegion(pendingRegion, false);
-    };
-    screen->showOverlayBanner(confirmBanner);
-}
-
 void menuHandler::deviceRolePicker()
 {
     static const char *optionsArray[] = {"Back", "Client", "Client Mute", "Lost and Found", "Tracker"};
@@ -458,64 +378,42 @@ void menuHandler::FrequencySlotPicker()
     screen->showOverlayBanner(bannerOptions);
 }
 
-// Maximum presets any region can have + 1 for Back
-static constexpr int MAX_PRESET_OPTIONS = 16;
-
-static BannerOverlayOptions buildRegionPresetBanner()
-{
-    // Static storage reused each call — safe because the banner is shown immediately after.
-    static const char *optionsArray[MAX_PRESET_OPTIONS];
-    static int optionsEnumArray[MAX_PRESET_OPTIONS];
-    static char presetLabelBuf[MAX_PRESET_OPTIONS][12]; // scratch space for name copies
-    int count = 0;
-
-    optionsArray[count] = "Back";
-    optionsEnumArray[count++] = -1;
-
-    if (myRegion && myRegion->profile) {
-        const meshtastic_Config_LoRaConfig_ModemPreset *presets = myRegion->getAvailablePresets();
-        size_t numPresets = myRegion->getNumPresets();
-        for (size_t i = 0; i < numPresets && count < MAX_PRESET_OPTIONS; ++i) {
-            const char *name = DisplayFormatters::getModemPresetDisplayName(presets[i], false, true);
-            strncpy(presetLabelBuf[count], name, sizeof(presetLabelBuf[count]) - 1);
-            presetLabelBuf[count][sizeof(presetLabelBuf[count]) - 1] = '\0';
-            optionsArray[count] = presetLabelBuf[count];
-            optionsEnumArray[count++] = static_cast<int>(presets[i]);
-        }
-    }
-
-    int initialSelection = 0;
-    for (int i = 1; i < count; ++i) {
-        if (optionsEnumArray[i] == static_cast<int>(config.lora.modem_preset)) {
-            initialSelection = i;
-            break;
-        }
-    }
-
-    BannerOverlayOptions bannerOptions;
-    bannerOptions.message = "Radio Preset";
-    bannerOptions.optionsArrayPtr = optionsArray;
-    bannerOptions.optionsEnumPtr = optionsEnumArray;
-    bannerOptions.optionsCount = static_cast<uint8_t>(count);
-    bannerOptions.InitialSelected = initialSelection;
-    bannerOptions.bannerCallback = [](int selected) -> void {
-        if (selected == -1) {
-            menuHandler::menuQueue = menuHandler::LoraMenu;
-            screen->runNow();
-            return;
-        }
-        config.lora.use_preset = true;
-        config.lora.modem_preset = static_cast<meshtastic_Config_LoRaConfig_ModemPreset>(selected);
-        config.lora.channel_num = 0;        // Reset to default channel for the preset
-        config.lora.override_frequency = 0; // Clear any custom frequency
-        service->reloadConfig(SEGMENT_CONFIG);
-    };
-    return bannerOptions;
-}
-
 void menuHandler::radioPresetPicker()
 {
-    screen->showOverlayBanner(buildRegionPresetBanner());
+    static const RadioPresetOption presetOptions[] = {
+        {"Back", OptionsAction::Back},
+        {"LongTurbo", OptionsAction::Select, meshtastic_Config_LoRaConfig_ModemPreset_LONG_TURBO},
+        {"LongModerate", OptionsAction::Select, meshtastic_Config_LoRaConfig_ModemPreset_LONG_MODERATE},
+        {"LongFast", OptionsAction::Select, meshtastic_Config_LoRaConfig_ModemPreset_LONG_FAST},
+        {"MediumSlow", OptionsAction::Select, meshtastic_Config_LoRaConfig_ModemPreset_MEDIUM_SLOW},
+        {"MediumFast", OptionsAction::Select, meshtastic_Config_LoRaConfig_ModemPreset_MEDIUM_FAST},
+        {"ShortSlow", OptionsAction::Select, meshtastic_Config_LoRaConfig_ModemPreset_SHORT_SLOW},
+        {"ShortFast", OptionsAction::Select, meshtastic_Config_LoRaConfig_ModemPreset_SHORT_FAST},
+        {"ShortTurbo", OptionsAction::Select, meshtastic_Config_LoRaConfig_ModemPreset_SHORT_TURBO},
+    };
+
+    constexpr size_t presetCount = sizeof(presetOptions) / sizeof(presetOptions[0]);
+    static std::array<const char *, presetCount> presetLabels{};
+
+    auto bannerOptions =
+        createStaticBannerOptions("Radio Preset", presetOptions, presetLabels, [](const RadioPresetOption &option, int) -> void {
+            if (option.action == OptionsAction::Back) {
+                menuHandler::menuQueue = menuHandler::LoraMenu;
+                screen->runNow();
+                return;
+            }
+
+            if (!option.hasValue) {
+                return;
+            }
+
+            config.lora.modem_preset = option.value;
+            config.lora.channel_num = 0;        // Reset to default channel for the preset
+            config.lora.override_frequency = 0; // Clear any custom frequency
+            service->reloadConfig(SEGMENT_CONFIG);
+        });
+
+    screen->showOverlayBanner(bannerOptions);
 }
 
 void menuHandler::twelveHourPicker()
@@ -1409,11 +1307,6 @@ void menuHandler::positionBaseMenu()
             if (accelerometerThread) {
                 accelerometerThread->calibrate(30);
             }
-#endif
-#if !defined(ARCH_STM32WL) && !MESHTASTIC_EXCLUDE_I2C && !MESHTASTIC_EXCLUDE_MAGNETOMETER
-            if (magnetometerThread) {
-                magnetometerThread->calibrate(30);
-            }
 #endif
             break;
         case PositionAction::GPSSmartPosition:
@@ -1572,7 +1465,6 @@ void menuHandler::manageNodeMenu()
                 nodeDB->set_favorite(false, menuHandler::pickedNodeNum);
             } else {
                 LOG_INFO("Adding node %08X to favorites", menuHandler::pickedNodeNum);
-                // set_favorite() already logs PROTECTED_CAP_WARN_FMT on a cap refusal; don't double-log here.
                 nodeDB->set_favorite(true, menuHandler::pickedNodeNum);
             }
             screen->setFrames(graphics::Screen::FOCUS_PRESERVE);
@@ -1616,23 +1508,15 @@ void menuHandler::manageNodeMenu()
                 return;
             }
 
-            bool changed = false;
             if (nodeInfoLiteIsIgnored(n)) {
                 nodeInfoLiteSetBit(n, NODEINFO_BITFIELD_IS_IGNORED_MASK, false);
                 LOG_INFO("Unignoring node %08X", menuHandler::pickedNodeNum);
-                changed = true;
-            } else if (nodeDB->setProtectedFlag(n, NODEINFO_BITFIELD_IS_IGNORED_MASK, true)) {
-                LOG_INFO("Ignoring node %08X", menuHandler::pickedNodeNum);
-                changed = true;
             } else {
-                LOG_WARN(NodeDB::PROTECTED_CAP_WARN_FMT, "ignore", menuHandler::pickedNodeNum, MAX_NUM_NODES - 2);
-            }
-            // Only persist/notify when the ignore bit actually moved; a cap
-            // refusal changed nothing and shouldn't trigger a prefs save.
-            if (changed) {
-                nodeDB->notifyObservers(true);
-                nodeDB->saveToDisk();
+                nodeInfoLiteSetBit(n, NODEINFO_BITFIELD_IS_IGNORED_MASK, true);
+                LOG_INFO("Ignoring node %08X", menuHandler::pickedNodeNum);
             }
+            nodeDB->notifyObservers(true);
+            nodeDB->saveToDisk();
             screen->setFrames(graphics::Screen::FOCUS_PRESERVE);
             return;
         }
@@ -2903,12 +2787,6 @@ void menuHandler::handleMenuSwitch(OLEDDisplay *display)
     case ThemeMenu:
         themeMenu();
         break;
-    case HamModeConfirm:
-        hamModeConfirmMenu();
-        break;
-    case LicensedToNormalConfirm:
-        licensedToNormalConfirmMenu();
-        break;
     }
     menuQueue = MenuNone;
 }

src/graphics/draw/MenuHandler.h

@@ -55,13 +55,10 @@ class menuHandler
         FrameToggles,
         DisplayUnits,
         MessageBubblesMenu,
-        ThemeMenu,
-        HamModeConfirm,
-        LicensedToNormalConfirm
+        ThemeMenu
     };
     static screenMenus menuQueue;
     static uint32_t pickedNodeNum; // node selected by NodePicker for ManageNodeMenu
-    static meshtastic_Config_LoRaConfig_RegionCode pendingRegion;
 
     static void OnboardMessage();
     static void LoraRegionPicker(uint32_t duration = 30000);
@@ -114,8 +111,6 @@ class menuHandler
     static void messageBubblesMenu();
     static void themeMenu();
     static void textMessageMenu();
-    static void hamModeConfirmMenu();
-    static void licensedToNormalConfirmMenu();
 
   private:
     static void saveUIConfig();

src/graphics/draw/NotificationRenderer.cpp

@@ -66,15 +66,6 @@ uint32_t pow_of_10(uint32_t n)
     return ret;
 }
 
-uint64_t pow_of_16(uint32_t n)
-{
-    uint64_t ret = 1;
-    for (uint32_t i = 0; i < n; i++) {
-        ret *= 16ULL;
-    }
-    return ret;
-}
-
 char graphics::NotificationRenderer::alertBannerLines[MAX_LINES + 1][64] = {};
 uint8_t graphics::NotificationRenderer::alertBannerLineCount = 0;
 graphics::NotificationRenderer::BannerFont graphics::NotificationRenderer::alertBannerLineFonts[MAX_LINES + 1] = {};
@@ -260,12 +251,6 @@ void NotificationRenderer::drawBannercallback(OLEDDisplay *display, OLEDDisplayU
         break;
     case notificationTypeEnum::text_banner:
     case notificationTypeEnum::selection_picker:
-    case notificationTypeEnum::pairing_pin:
-        // pairing_pin is rendered the same as text_banner — it's just a
-        // text banner. The split type exists only so the lockdown UI
-        // short-circuit in Screen.cpp can recognise the BLE pair-PIN
-        // banner as the one safe banner to composite over the LOCKED
-        // frame.
         drawAlertBannerOverlay(display, state);
         break;
     case notificationTypeEnum::node_picker:
@@ -274,9 +259,6 @@ void NotificationRenderer::drawBannercallback(OLEDDisplay *display, OLEDDisplayU
     case notificationTypeEnum::number_picker:
         drawNumberPicker(display, state);
         break;
-    case notificationTypeEnum::hex_picker:
-        drawHexPicker(display, state);
-        break;
     }
 }
 
@@ -363,105 +345,6 @@ void NotificationRenderer::drawNumberPicker(OLEDDisplay *display, OLEDDisplayUiS
     drawNotificationBox(display, state, linePointers, totalLines, 0);
 }
 
-void NotificationRenderer::drawHexPicker(OLEDDisplay *display, OLEDDisplayUiState *state)
-{
-    const char *lineStarts[MAX_LINES + 1] = {0};
-    uint16_t lineCount = 0;
-
-    // Parse lines
-    char *alertEnd = alertBannerMessage + strnlen(alertBannerMessage, sizeof(alertBannerMessage));
-    lineStarts[lineCount] = alertBannerMessage;
-
-    // Find lines
-    while ((lineCount < MAX_LINES) && (lineStarts[lineCount] < alertEnd)) {
-        lineStarts[lineCount + 1] = std::find((char *)lineStarts[lineCount], alertEnd, '\n');
-        if (lineStarts[lineCount + 1][0] == '\n')
-            lineStarts[lineCount + 1] += 1;
-        lineCount++;
-    }
-    // modulo to extract
-    uint8_t this_digit = (currentNumber % (pow_of_16(numDigits - curSelected))) / (pow_of_16(numDigits - curSelected - 1));
-    // Handle input
-    if (inEvent.inputEvent == INPUT_BROKER_UP || inEvent.inputEvent == INPUT_BROKER_ALT_PRESS ||
-        inEvent.inputEvent == INPUT_BROKER_UP_LONG) {
-        if (this_digit == 15) {
-            currentNumber -= 15 * (pow_of_16(numDigits - curSelected - 1));
-        } else {
-            currentNumber += (pow_of_16(numDigits - curSelected - 1));
-        }
-    } else if (inEvent.inputEvent == INPUT_BROKER_DOWN || inEvent.inputEvent == INPUT_BROKER_USER_PRESS ||
-               inEvent.inputEvent == INPUT_BROKER_DOWN_LONG) {
-        if (this_digit == 0) {
-            currentNumber += 15 * (pow_of_16(numDigits - curSelected - 1));
-        } else {
-            currentNumber -= (pow_of_16(numDigits - curSelected - 1));
-        }
-    } else if (inEvent.inputEvent == INPUT_BROKER_ANYKEY) {
-        if (inEvent.kbchar > 47 && inEvent.kbchar < 58) { // have a digit
-            currentNumber -= this_digit * (pow_of_16(numDigits - curSelected - 1));
-            currentNumber += (inEvent.kbchar - 48) * (pow_of_16(numDigits - curSelected - 1));
-            curSelected++;
-        }
-    } else if (inEvent.inputEvent == INPUT_BROKER_SELECT || inEvent.inputEvent == INPUT_BROKER_RIGHT) {
-        curSelected++;
-    } else if (inEvent.inputEvent == INPUT_BROKER_LEFT) {
-        curSelected--;
-    } else if ((inEvent.inputEvent == INPUT_BROKER_CANCEL || inEvent.inputEvent == INPUT_BROKER_ALT_LONG) &&
-               alertBannerUntil != 0) {
-        resetBanner();
-        return;
-    }
-    if (curSelected == static_cast<int8_t>(numDigits)) {
-        alertBannerCallback(currentNumber);
-        resetBanner();
-        return;
-    }
-
-    inEvent.inputEvent = INPUT_BROKER_NONE;
-    if (alertBannerMessage[0] == '\0')
-        return;
-
-    uint16_t totalLines = lineCount + 2;
-    const char *linePointers[totalLines + 1] = {0}; // this is sort of a dynamic allocation
-
-    // copy the linestarts to display to the linePointers holder
-    for (uint16_t i = 0; i < lineCount; i++) {
-        linePointers[i] = lineStarts[i];
-    }
-    std::string digits = " ";
-    std::string arrowPointer = " ";
-    for (uint16_t i = 0; i < numDigits; i++) {
-        // Modulo minus modulo to return just the current number
-        uint8_t digitValue = (currentNumber % (pow_of_16(numDigits - i))) / (pow_of_16(numDigits - i - 1));
-        if (digitValue < 10) {
-            digits += std::to_string(digitValue) + " ";
-        } else if (digitValue == 10) {
-            digits += "A ";
-        } else if (digitValue == 11) {
-            digits += "B ";
-        } else if (digitValue == 12) {
-            digits += "C ";
-        } else if (digitValue == 13) {
-            digits += "D ";
-        } else if (digitValue == 14) {
-            digits += "E ";
-        } else if (digitValue == 15) {
-            digits += "F ";
-        }
-
-        if (curSelected == i) {
-            arrowPointer += "^ ";
-        } else {
-            arrowPointer += "_ ";
-        }
-    }
-
-    linePointers[lineCount++] = digits.c_str();
-    linePointers[lineCount++] = arrowPointer.c_str();
-
-    drawNotificationBox(display, state, linePointers, totalLines, 0);
-}
-
 void NotificationRenderer::drawNodePicker(OLEDDisplay *display, OLEDDisplayUiState *state)
 {
     static uint32_t selectedNodenum = 0;

src/graphics/draw/NotificationRenderer.h

@@ -42,7 +42,6 @@ class NotificationRenderer
     static void drawBannercallback(OLEDDisplay *display, OLEDDisplayUiState *state);
     static void drawAlertBannerOverlay(OLEDDisplay *display, OLEDDisplayUiState *state);
     static void drawNumberPicker(OLEDDisplay *display, OLEDDisplayUiState *state);
-    static void drawHexPicker(OLEDDisplay *display, OLEDDisplayUiState *state);
     static void drawNodePicker(OLEDDisplay *display, OLEDDisplayUiState *state);
     static void drawTextInput(OLEDDisplay *display, OLEDDisplayUiState *state);
     static void drawNotificationBox(OLEDDisplay *display, OLEDDisplayUiState *state, const char *lines[MAX_LINES + 1],

src/graphics/draw/UIRenderer.cpp

@@ -2,7 +2,6 @@
 #if HAS_SCREEN
 #include "CompassRenderer.h"
 #include "GPSStatus.h"
-#include "MeshRadio.h"
 #include "MeshService.h"
 #include "NodeDB.h"
 #include "NodeListRenderer.h"
@@ -79,12 +78,10 @@ static inline void transformNeedlePoint(float localX, float localY, float sinHea
     outY = static_cast<int16_t>(y);
 }
 
-#if GRAPHICS_TFT_COLORING_ENABLED
 static float getCompassRingAngleOffset(float heading)
 {
     return (uiconfig.compass_mode != meshtastic_CompassMode_FIXED_RING) ? -heading : 0.0f;
 }
-#endif
 
 static inline StandardCompassNeedlePoints computeStandardCompassNeedlePoints(int16_t compassX, int16_t compassY,
                                                                              uint16_t compassDiam, float headingRadian,
@@ -819,16 +816,16 @@ void UIRenderer::drawFavoriteNode(OLEDDisplay *display, OLEDDisplayUiState *stat
     // Helper to get SNR limit based on modem preset
     auto getSnrLimit = [](meshtastic_Config_LoRaConfig_ModemPreset preset) -> float {
         switch (preset) {
-        case PRESET(LONG_SLOW):
-        case PRESET(LONG_MODERATE):
-        case PRESET(LONG_FAST):
+        case meshtastic_Config_LoRaConfig_ModemPreset_LONG_SLOW:
+        case meshtastic_Config_LoRaConfig_ModemPreset_LONG_MODERATE:
+        case meshtastic_Config_LoRaConfig_ModemPreset_LONG_FAST:
             return -6.0f;
-        case PRESET(MEDIUM_SLOW):
-        case PRESET(MEDIUM_FAST):
+        case meshtastic_Config_LoRaConfig_ModemPreset_MEDIUM_SLOW:
+        case meshtastic_Config_LoRaConfig_ModemPreset_MEDIUM_FAST:
             return -5.5f;
-        case PRESET(SHORT_SLOW):
-        case PRESET(SHORT_FAST):
-        case PRESET(SHORT_TURBO):
+        case meshtastic_Config_LoRaConfig_ModemPreset_SHORT_SLOW:
+        case meshtastic_Config_LoRaConfig_ModemPreset_SHORT_FAST:
+        case meshtastic_Config_LoRaConfig_ModemPreset_SHORT_TURBO:
             return -4.5f;
         default:
             return -6.0f;
@@ -1144,16 +1141,11 @@ void UIRenderer::drawDeviceFocused(OLEDDisplay *display, OLEDDisplayUiState *sta
     bool origBold = config.display.heading_bold;
     config.display.heading_bold = false;
 
-    if (!config.lora.tx_enabled) {
-        const char *txdisabled = "Transmit Disabled";
-        display->drawString(x, getTextPositions(display)[line], txdisabled);
+    // Display Region and Channel Utilization
+    if (currentResolution == ScreenResolution::UltraLow) {
+        drawNodes(display, x, getTextPositions(display)[line] + 2, nodeStatus, -1, false, "online");
     } else {
-        // Display Region and Channel Utilization
-        if (currentResolution == ScreenResolution::UltraLow) {
-            drawNodes(display, x, getTextPositions(display)[line] + 2, nodeStatus, -1, false, "online");
-        } else {
-            drawNodes(display, x + 1, getTextPositions(display)[line] + 2, nodeStatus, -1, false, "online");
-        }
+        drawNodes(display, x + 1, getTextPositions(display)[line] + 2, nodeStatus, -1, false, "online");
     }
     char uptimeStr[32] = "";
     if (currentResolution != ScreenResolution::UltraLow) {

src/graphics/niche/Drivers/EInk/ED047TC1.cpp

@@ -6,12 +6,15 @@
     FastEPD buffer format: 1bpp, horizontal bytes, MSB = leftmost pixel, 1 = white
 
     Both formats share the same pixel layout and polarity (1 = white, 0 = black).
-    The InkHUD safe-area buffer (928×508) is copied into the centre of the physical
+    The InkHUD safe-area buffer (944×523) is copied into the centre of the physical
     960×540 FastEPD buffer so content clears the panel's inactive edge border.
     See ED047TC1.h for the H_OFFSET_BYTES / V_OFFSET_TOP / V_OFFSET_BOTTOM constants.
 
 */
 
+// Ruler diagnostic — uncomment to draw calibration lines at each physical edge.
+// #define EINK_EDGE_LINES
+
 #ifdef MESHTASTIC_INCLUDE_NICHE_GRAPHICS
 #ifdef T5_S3_EPAPER_PRO
 
@@ -209,6 +212,35 @@ void ED047TC1::update(uint8_t *imageData, UpdateTypes type)
         memcpy(dstRow, srcRow, srcRowBytes);
     }
 
+#ifdef EINK_EDGE_LINES
+    // Draw a 1px black box at the exact boundary of the safe area within the
+    // physical buffer. If the margins are correct, all 4 lines should be
+    // fully visible and right at the edge of the usable display area.
+
+    auto setPixelBlack = [&](uint32_t col, uint32_t row) { cur[row * dstRowBytes + col / 8] &= ~(0x80 >> (col % 8)); };
+
+    const uint32_t safeX = H_OFFSET_BYTES * 8;
+    const uint32_t safeY = V_OFFSET_TOP;
+    const uint32_t safeW = DISPLAY_WIDTH;
+    const uint32_t safeH = DISPLAY_HEIGHT;
+
+    // Top edge: horizontal line at safeY
+    for (uint32_t col = safeX; col < safeX + safeW; col++)
+        setPixelBlack(col, safeY);
+
+    // Bottom edge: horizontal line at safeY + safeH - 1
+    for (uint32_t col = safeX; col < safeX + safeW; col++)
+        setPixelBlack(col, safeY + safeH - 1);
+
+    // Left edge: vertical line at safeX
+    for (uint32_t row = safeY; row < safeY + safeH; row++)
+        setPixelBlack(safeX, row);
+
+    // Right edge: vertical line at safeX + safeW - 1
+    for (uint32_t row = safeY; row < safeY + safeH; row++)
+        setPixelBlack(safeX + safeW - 1, row);
+#endif
+
     if (type == FULL) {
         epaper->fullUpdate(CLEAR_SLOW, false);
         epaper->backupPlane(); // Sync pPrevious so next partialUpdate has a correct baseline

src/graphics/niche/Drivers/EInk/ED047TC1.h

@@ -18,9 +18,9 @@
     V_OFFSET_TOP and V_OFFSET_BOTTOM (vertical, pixel rows) to position it.
 
     Changing these constants shifts content inward from each physical edge:
-        H_OFFSET_BYTES = 2   →  16px left margin, 16px right margin  (960 – 16 – 16 = 928)
-        V_OFFSET_TOP   = 16  →  16px top margin
-        V_OFFSET_BOTTOM = 16 →  16px bottom margin                   (540 – 16 – 16 = 508)
+        H_OFFSET_BYTES = 1  →  8px left margin, 8px right margin   (960 – 8 – 8   = 944)
+        V_OFFSET_TOP   = 9  →  9px top margin  (asymmetric: top ≠ bottom)
+        V_OFFSET_BOTTOM = 8 →  8px bottom margin                    (540 – 9 – 8   = 523)
 
 */
 
@@ -61,13 +61,13 @@ class ED047TC1 : public EInk
     //
     // Calibrated by flashing a 1px border box and adjusting until all 4 sides are visible.
 
-    static constexpr uint16_t DISPLAY_WIDTH = 928;  // 960 − H_OFFSET_BYTES×8 − right_margin (16+16 = 32px)
-    static constexpr uint16_t DISPLAY_HEIGHT = 508; // 540 − V_OFFSET_TOP − V_OFFSET_BOTTOM (16+16 = 32px)
+    static constexpr uint16_t DISPLAY_WIDTH = 944;  // 960 − H_OFFSET_BYTES×8 − right_margin (8+8 = 16px)
+    static constexpr uint16_t DISPLAY_HEIGHT = 523; // 540 − V_OFFSET_TOP − V_OFFSET_BOTTOM (9+8 = 17px)
 
-    static constexpr uint8_t H_OFFSET_BYTES = 2;   // visual TOP  : 16px physical left margin
-                                                   // visual BOTTOM: 960−16−928=16px physical right margin
-    static constexpr uint8_t V_OFFSET_TOP = 16;    // visual RIGHT : 16px physical top margin
-    static constexpr uint8_t V_OFFSET_BOTTOM = 16; // visual LEFT  : 16px physical bottom margin
+    static constexpr uint8_t H_OFFSET_BYTES = 1;  // visual TOP  : 8px physical left margin
+                                                  // visual BOTTOM: 960−8−944=8px physical right margin
+    static constexpr uint8_t V_OFFSET_TOP = 9;    // visual RIGHT : CONFIRMED OK
+    static constexpr uint8_t V_OFFSET_BOTTOM = 8; // visual LEFT  : 8px physical bottom margin
 
     static constexpr UpdateTypes supported = static_cast<UpdateTypes>(FULL | FAST);
 

src/graphics/niche/InkHUD/Applets/System/Menu/MenuAction.h

@@ -64,12 +64,6 @@ enum MenuAction {
     SET_REGION_KZ_863,
     SET_REGION_NP_865,
     SET_REGION_BR_902,
-    SET_REGION_EU_866,
-    SET_REGION_NARROW_868,
-    SET_REGION_ITU1_2M,
-    SET_REGION_ITU2_2M,
-    SET_REGION_ITU3_2M,
-    SET_REGION_ITU2_125CM,
     // Device Roles
     SET_ROLE_CLIENT,
     SET_ROLE_CLIENT_MUTE,
@@ -84,13 +78,6 @@ enum MenuAction {
     SET_PRESET_SHORT_SLOW,
     SET_PRESET_SHORT_FAST,
     SET_PRESET_SHORT_TURBO,
-    SET_PRESET_LITE_SLOW,
-    SET_PRESET_LITE_FAST,
-    SET_PRESET_NARROW_SLOW,
-    SET_PRESET_NARROW_FAST,
-    SET_PRESET_TINY_SLOW,
-    SET_PRESET_TINY_FAST,
-    SET_PRESET_FROM_REGION, // Dynamic: preset chosen from region-available list
     // Timezones
     SET_TZ_US_HAWAII,
     SET_TZ_US_ALASKA,
@@ -129,7 +116,6 @@ enum MenuAction {
     // Administration
     RESET_NODEDB_ALL,
     RESET_NODEDB_KEEP_FAVORITES,
-    WIPE_MESSAGES_ALL,
 };
 
 } // namespace NicheGraphics::InkHUD

src/graphics/niche/InkHUD/Applets/System/Menu/MenuApplet.cpp

@@ -4,9 +4,7 @@
 
 #include "DisplayFormatters.h"
 #include "GPS.h"
-#include "MeshRadio.h"
 #include "MeshService.h"
-#include "MessageStore.h"
 #include "RTC.h"
 #include "Router.h"
 #include "airtime.h"
@@ -259,11 +257,6 @@ int32_t InkHUD::MenuApplet::runOnce()
     return OSThread::disable();
 }
 
-// Storage for the dynamically-built region preset list — populated in showPage(NODE_CONFIG_PRESET)
-static constexpr uint8_t MAX_REGION_PRESETS = 16;
-static meshtastic_Config_LoRaConfig_ModemPreset regionPresets[MAX_REGION_PRESETS];
-static uint8_t regionPresetCount = 0;
-
 static void applyLoRaRegion(meshtastic_Config_LoRaConfig_RegionCode region)
 {
     if (config.lora.region == region)
@@ -283,12 +276,12 @@ static void applyLoRaRegion(meshtastic_Config_LoRaConfig_RegionCode region)
 
     initRegion();
 
-    if (myRegion && getEffectiveDutyCycle() < 100) {
+    if (myRegion && myRegion->dutyCycle < 100) {
         config.lora.ignore_mqtt = true;
     }
 
     if (strncmp(moduleConfig.mqtt.root, default_mqtt_root, strlen(default_mqtt_root)) == 0) {
-        snprintf(moduleConfig.mqtt.root, sizeof(moduleConfig.mqtt.root), "%s/%s", default_mqtt_root, myRegion->name);
+        sprintf(moduleConfig.mqtt.root, "%s/%s", default_mqtt_root, myRegion->name);
         changes |= SEGMENT_MODULECONFIG;
     }
     // Notify UI that changes are being applied
@@ -777,30 +770,6 @@ void InkHUD::MenuApplet::execute(MenuItem item)
         applyLoRaRegion(meshtastic_Config_LoRaConfig_RegionCode_BR_902);
         break;
 
-    case SET_REGION_EU_866:
-        applyLoRaRegion(meshtastic_Config_LoRaConfig_RegionCode_EU_866);
-        break;
-
-    case SET_REGION_NARROW_868:
-        applyLoRaRegion(meshtastic_Config_LoRaConfig_RegionCode_EU_N_868);
-        break;
-
-    case SET_REGION_ITU1_2M:
-        applyLoRaRegion(meshtastic_Config_LoRaConfig_RegionCode_ITU1_2M);
-        break;
-
-    case SET_REGION_ITU2_2M:
-        applyLoRaRegion(meshtastic_Config_LoRaConfig_RegionCode_ITU2_2M);
-        break;
-
-    case SET_REGION_ITU3_2M:
-        applyLoRaRegion(meshtastic_Config_LoRaConfig_RegionCode_ITU3_2M);
-        break;
-
-    case SET_REGION_ITU2_125CM:
-        applyLoRaRegion(meshtastic_Config_LoRaConfig_RegionCode_ITU2_125CM);
-        break;
-
     // Roles
     case SET_ROLE_CLIENT:
         applyDeviceRole(meshtastic_Config_DeviceConfig_Role_CLIENT);
@@ -820,62 +789,37 @@ void InkHUD::MenuApplet::execute(MenuItem item)
 
     // Presets
     case SET_PRESET_LONG_SLOW:
-        applyLoRaPreset(PRESET(LONG_SLOW));
+        applyLoRaPreset(meshtastic_Config_LoRaConfig_ModemPreset_LONG_SLOW);
         break;
 
     case SET_PRESET_LONG_MODERATE:
-        applyLoRaPreset(PRESET(LONG_MODERATE));
+        applyLoRaPreset(meshtastic_Config_LoRaConfig_ModemPreset_LONG_MODERATE);
         break;
 
     case SET_PRESET_LONG_FAST:
-        applyLoRaPreset(PRESET(LONG_FAST));
+        applyLoRaPreset(meshtastic_Config_LoRaConfig_ModemPreset_LONG_FAST);
         break;
 
     case SET_PRESET_MEDIUM_SLOW:
-        applyLoRaPreset(PRESET(MEDIUM_SLOW));
+        applyLoRaPreset(meshtastic_Config_LoRaConfig_ModemPreset_MEDIUM_SLOW);
         break;
 
     case SET_PRESET_MEDIUM_FAST:
-        applyLoRaPreset(PRESET(MEDIUM_FAST));
+        applyLoRaPreset(meshtastic_Config_LoRaConfig_ModemPreset_MEDIUM_FAST);
         break;
 
     case SET_PRESET_SHORT_SLOW:
-        applyLoRaPreset(PRESET(SHORT_SLOW));
+        applyLoRaPreset(meshtastic_Config_LoRaConfig_ModemPreset_SHORT_SLOW);
         break;
 
     case SET_PRESET_SHORT_FAST:
-        applyLoRaPreset(PRESET(SHORT_FAST));
+        applyLoRaPreset(meshtastic_Config_LoRaConfig_ModemPreset_SHORT_FAST);
         break;
 
     case SET_PRESET_SHORT_TURBO:
-        applyLoRaPreset(PRESET(SHORT_TURBO));
+        applyLoRaPreset(meshtastic_Config_LoRaConfig_ModemPreset_SHORT_TURBO);
         break;
 
-    case SET_PRESET_NARROW_SLOW:
-        applyLoRaPreset(PRESET(NARROW_SLOW));
-        break;
-
-    case SET_PRESET_NARROW_FAST:
-        applyLoRaPreset(PRESET(NARROW_FAST));
-        break;
-
-    case SET_PRESET_TINY_SLOW:
-        applyLoRaPreset(PRESET(TINY_SLOW));
-        break;
-
-    case SET_PRESET_TINY_FAST:
-        applyLoRaPreset(PRESET(TINY_FAST));
-        break;
-
-    case SET_PRESET_FROM_REGION: {
-        // cursor - 1 because index 0 is "Back"
-        const uint8_t index = cursor - 1;
-        if (index < regionPresetCount) {
-            applyLoRaPreset(regionPresets[index]);
-        }
-        break;
-    }
-
     // Timezones
     case SET_TZ_US_HAWAII:
         applyTimezone("HST10");
@@ -1014,13 +958,6 @@ void InkHUD::MenuApplet::execute(MenuItem item)
         rebootAtMsec = millis() + DEFAULT_REBOOT_SECONDS * 1000;
         break;
 
-    case WIPE_MESSAGES_ALL:
-        LOG_INFO("Wiping all messages from menu");
-        messageStore.clearAllMessages();
-        inkhud->persistence->loadLatestMessage();
-        inkhud->forceUpdate(Drivers::EInk::UpdateTypes::FULL, true);
-        break;
-
     default:
         LOG_WARN("Action not implemented");
     }
@@ -1138,7 +1075,6 @@ void InkHUD::MenuApplet::showPage(MenuPage page)
         // Administration Section
         items.push_back(MenuItem::Header("Administration"));
         items.push_back(MenuItem("Reset NodeDB", MenuPage::NODE_CONFIG_ADMIN_RESET));
-        items.push_back(MenuItem("Wipe Messages", MenuPage::NODE_CONFIG_ADMIN_MESSAGES));
 
         // Exit
         items.push_back(MenuItem("Exit", MenuPage::EXIT));
@@ -1485,8 +1421,6 @@ void InkHUD::MenuApplet::showPage(MenuPage page)
         items.push_back(MenuItem("US", MenuAction::SET_REGION_US, MenuPage::EXIT));
         items.push_back(MenuItem("EU 868", MenuAction::SET_REGION_EU_868, MenuPage::EXIT));
         items.push_back(MenuItem("EU 433", MenuAction::SET_REGION_EU_433, MenuPage::EXIT));
-        items.push_back(MenuItem("EU 866", MenuAction::SET_REGION_EU_866, MenuPage::EXIT));
-        items.push_back(MenuItem("EU 868 Narrow", MenuAction::SET_REGION_NARROW_868, MenuPage::EXIT));
         items.push_back(MenuItem("CN", MenuAction::SET_REGION_CN, MenuPage::EXIT));
         items.push_back(MenuItem("JP", MenuAction::SET_REGION_JP, MenuPage::EXIT));
         items.push_back(MenuItem("ANZ", MenuAction::SET_REGION_ANZ, MenuPage::EXIT));
@@ -1510,27 +1444,19 @@ void InkHUD::MenuApplet::showPage(MenuPage page)
         items.push_back(MenuItem("KZ 863", MenuAction::SET_REGION_KZ_863, MenuPage::EXIT));
         items.push_back(MenuItem("NP 865", MenuAction::SET_REGION_NP_865, MenuPage::EXIT));
         items.push_back(MenuItem("BR 902", MenuAction::SET_REGION_BR_902, MenuPage::EXIT));
-        items.push_back(MenuItem("ITU1_2M (144-146)", MenuAction::SET_REGION_ITU1_2M, MenuPage::EXIT));
-        items.push_back(MenuItem("ITU2_2M (144-148)", MenuAction::SET_REGION_ITU2_2M, MenuPage::EXIT));
-        items.push_back(MenuItem("ITU3_2M (144-148)", MenuAction::SET_REGION_ITU3_2M, MenuPage::EXIT));
-        items.push_back(MenuItem("ITU2_125CM (220-225)", MenuAction::SET_REGION_ITU2_125CM, MenuPage::EXIT));
         items.push_back(MenuItem("Exit", MenuPage::EXIT));
         break;
 
     case NODE_CONFIG_PRESET: {
         previousPage = MenuPage::NODE_CONFIG_LORA;
         items.push_back(MenuItem("Back", previousPage));
-        regionPresetCount = 0;
-        if (myRegion && myRegion->profile) {
-            const meshtastic_Config_LoRaConfig_ModemPreset *presets = myRegion->getAvailablePresets();
-            size_t numPresets = myRegion->getNumPresets();
-            for (size_t i = 0; i < numPresets && regionPresetCount < MAX_REGION_PRESETS; ++i) {
-                regionPresets[regionPresetCount++] = presets[i];
-                const char *name = DisplayFormatters::getModemPresetDisplayName(presets[i], false, true);
-                nodeConfigLabels.emplace_back(name);
-                items.push_back(MenuItem(nodeConfigLabels.back().c_str(), MenuAction::SET_PRESET_FROM_REGION, MenuPage::EXIT));
-            }
-        }
+        items.push_back(MenuItem("Long Moderate", MenuAction::SET_PRESET_LONG_MODERATE, MenuPage::EXIT));
+        items.push_back(MenuItem("Long Fast", MenuAction::SET_PRESET_LONG_FAST, MenuPage::EXIT));
+        items.push_back(MenuItem("Medium Slow", MenuAction::SET_PRESET_MEDIUM_SLOW, MenuPage::EXIT));
+        items.push_back(MenuItem("Medium Fast", MenuAction::SET_PRESET_MEDIUM_FAST, MenuPage::EXIT));
+        items.push_back(MenuItem("Short Slow", MenuAction::SET_PRESET_SHORT_SLOW, MenuPage::EXIT));
+        items.push_back(MenuItem("Short Fast", MenuAction::SET_PRESET_SHORT_FAST, MenuPage::EXIT));
+        items.push_back(MenuItem("Short Turbo", MenuAction::SET_PRESET_SHORT_TURBO, MenuPage::EXIT));
         items.push_back(MenuItem("Exit", MenuPage::EXIT));
         break;
     }
@@ -1543,13 +1469,6 @@ void InkHUD::MenuApplet::showPage(MenuPage page)
         items.push_back(MenuItem("Exit", MenuPage::EXIT));
         break;
 
-    case NODE_CONFIG_ADMIN_MESSAGES:
-        previousPage = MenuPage::NODE_CONFIG;
-        items.push_back(MenuItem("Back", previousPage));
-        items.push_back(MenuItem("Wipe All Messages", MenuAction::WIPE_MESSAGES_ALL, MenuPage::EXIT));
-        items.push_back(MenuItem("Exit", MenuPage::EXIT));
-        break;
-
     // Exit
     case EXIT:
         sendToBackground(); // Menu applet dismissed, allow normal behavior to resume

src/graphics/niche/InkHUD/Applets/System/Menu/MenuPage.h

@@ -36,7 +36,6 @@ enum MenuPage : uint8_t {
     NODE_CONFIG_BLUETOOTH,
     NODE_CONFIG_POSITION,
     NODE_CONFIG_ADMIN_RESET,
-    NODE_CONFIG_ADMIN_MESSAGES,
     TIMEZONE,
     APPLETS,
     AUTOSHOW,

src/graphics/niche/InkHUD/Applets/System/Notification/NotificationApplet.cpp

@@ -3,7 +3,6 @@
 #include "./NotificationApplet.h"
 
 #include "./Notification.h"
-#include "MessageStore.h"
 #include "graphics/niche/InkHUD/Persistence.h"
 
 #include "meshUtils.h"
@@ -232,7 +231,7 @@ std::string InkHUD::NotificationApplet::getNotificationText(uint16_t widthAvaila
         bool msgIsBroadcast = currentNotification.type == Notification::Type::NOTIFICATION_MESSAGE_BROADCAST;
 
         // Pick source of message
-        const StoredMessage *message =
+        const MessageStore::Message *message =
             msgIsBroadcast ? &inkhud->persistence->latestMessage.broadcast : &inkhud->persistence->latestMessage.dm;
 
         // Find info about the sender
@@ -262,7 +261,7 @@ std::string InkHUD::NotificationApplet::getNotificationText(uint16_t widthAvaila
                 text += hexifyNodeNum(message->sender);
 
             text += ": ";
-            text += MessageStore::getText(*message);
+            text += message->text;
         }
     }
 

src/graphics/niche/InkHUD/Applets/User/AllMessage/AllMessageApplet.cpp

@@ -2,8 +2,6 @@
 
 #include "./AllMessageApplet.h"
 
-#include "MessageStore.h"
-
 using namespace NicheGraphics;
 
 void InkHUD::AllMessageApplet::onActivate()
@@ -39,7 +37,7 @@ int InkHUD::AllMessageApplet::onReceiveTextMessage(const meshtastic_MeshPacket *
 void InkHUD::AllMessageApplet::onRender(bool full)
 {
     // Find newest message, regardless of whether DM or broadcast
-    StoredMessage *message;
+    MessageStore::Message *message;
     if (latestMessage->wasBroadcast)
         message = &latestMessage->broadcast;
     else
@@ -98,7 +96,7 @@ void InkHUD::AllMessageApplet::onRender(bool full)
     // ===================
 
     // Parse any non-ascii chars in the message
-    std::string text = parse(std::string(MessageStore::getText(*message)));
+    std::string text = parse(message->text);
 
     // Extra gap below the header
     int16_t textTop = headerDivY + padDivH;

src/graphics/niche/InkHUD/Applets/User/DM/DMApplet.cpp

@@ -2,8 +2,6 @@
 
 #include "./DMApplet.h"
 
-#include "MessageStore.h"
-
 using namespace NicheGraphics;
 
 void InkHUD::DMApplet::onActivate()
@@ -94,7 +92,7 @@ void InkHUD::DMApplet::onRender(bool full)
     // ===================
 
     // Parse any non-ascii chars in the message
-    std::string text = parse(std::string(MessageStore::getText(latestMessage->dm)));
+    std::string text = parse(latestMessage->dm.text);
 
     // Extra gap below the header
     int16_t textTop = headerDivY + padDivH;

src/graphics/niche/InkHUD/Applets/User/ThreadedMessage/ThreadedMessageApplet.cpp

@@ -7,9 +7,19 @@
 
 using namespace NicheGraphics;
 
+// Hard limits on how much message data to write to flash
+// Avoid filling the storage if something goes wrong
+// Normal usage should be well below this size
+constexpr uint8_t MAX_MESSAGES_SAVED = 10;
+constexpr uint32_t MAX_MESSAGE_SIZE = 250;
+
 InkHUD::ThreadedMessageApplet::ThreadedMessageApplet(uint8_t channelIndex)
     : SinglePortModule("ThreadedMessageApplet", meshtastic_PortNum_TEXT_MESSAGE_APP), channelIndex(channelIndex)
 {
+    // Create the message store
+    // Will shortly attempt to load messages from RAM, if applet is active
+    // Label (filename in flash) is set from channel index
+    store = new MessageStore("ch" + to_string(channelIndex));
 }
 
 void InkHUD::ThreadedMessageApplet::onRender(bool full)
@@ -51,24 +61,17 @@ void InkHUD::ThreadedMessageApplet::onRender(bool full)
     const uint16_t msgW = (msgR - msgL) + 1;
 
     int16_t msgB = height() - 1; // Vertical cursor for drawing. Messages are bottom-aligned to this value.
+    uint8_t i = 0;               // Index of stored message
 
-    // Iterate the global store newest-first, showing only broadcast messages on our channel
-    const auto &allMessages = messageStore.getLiveMessages();
-    int msgIdx = (int)allMessages.size() - 1;
-
-    while (msgB >= (0 - fontSmall.lineHeight()) && msgIdx >= 0) {
-
-        const StoredMessage &m = allMessages.at(msgIdx);
-
-        // Skip messages that don't belong to this channel or are DMs
-        if (m.type != MessageType::BROADCAST || m.channelIndex != channelIndex) {
-            msgIdx--;
-            continue;
-        }
+    // Loop over messages
+    // - until no messages left, or
+    // - until no part of message fits on screen
+    while (msgB >= (0 - fontSmall.lineHeight()) && i < store->messages.size()) {
 
         // Grab data for message
-        bool outgoing = (m.sender == myNodeInfo.my_node_num);
-        std::string bodyText = parse(std::string(MessageStore::getText(m))); // Parse any non-ascii chars
+        const MessageStore::Message &m = store->messages.at(i);
+        bool outgoing = (m.sender == 0) || (m.sender == myNodeInfo.my_node_num); // Own NodeNum if canned message
+        std::string bodyText = parse(m.text);                                    // Parse any non-ascii chars in the message
 
         // Cache bottom Y of message text
         // - Used when drawing vertical line alongside
@@ -149,13 +152,18 @@ void InkHUD::ThreadedMessageApplet::onRender(bool full)
         // Move cursor up: padding before next message
         msgB -= fontSmall.lineHeight() * 0.5;
 
-        msgIdx--;
+        i++;
     } // End of loop: drawing each message
 
     // Fade effect:
     // Area immediately below the divider. Overdraw with sparse white lines.
     // Make text appear to pass behind the header
     hatchRegion(0, dividerY + 1, width(), fontSmall.lineHeight() / 3, 2, WHITE);
+
+    // If we've run out of screen to draw messages, we can drop any leftover data from the queue
+    // Those messages have been pushed off the screen-top by newer ones
+    while (i < store->messages.size())
+        store->messages.pop_back();
 }
 
 // Code which runs when the applet begins running
@@ -190,8 +198,16 @@ ProcessMessage InkHUD::ThreadedMessageApplet::handleReceived(const meshtastic_Me
     if (mp.to != NODENUM_BROADCAST)
         return ProcessMessage::CONTINUE;
 
-    // Store in the global messageStore — this handles sender, timestamp, channel, text, and ack status
-    messageStore.addFromPacket(mp);
+    // Extract info into our slimmed-down "StoredMessage" type
+    MessageStore::Message newMessage;
+    newMessage.timestamp = getValidTime(RTCQuality::RTCQualityDevice, true); // Current RTC time
+    newMessage.sender = mp.from;
+    newMessage.channelIndex = mp.channel;
+    newMessage.text = std::string((const char *)mp.decoded.payload.bytes, mp.decoded.payload.size);
+
+    // Store newest message at front
+    // These records are used when rendering, and also stored in flash at shutdown
+    store->messages.push_front(newMessage);
 
     // If this was an incoming message, suggest that our applet becomes foreground, if permitted
     if (getFrom(&mp) != nodeDB->getNodeNum())
@@ -216,25 +232,37 @@ bool InkHUD::ThreadedMessageApplet::approveNotification(Notification &n)
         return true;
 }
 
-// Save messages to flash via the global messageStore.
-// The global store holds messages for all channels; no per-channel file is needed.
+// Save several recent messages to flash
+// Stores the contents of ThreadedMessageApplet::messages
+// Just enough messages to fill the display
+// Messages are packed "back-to-back", to minimize blocks of flash used
 void InkHUD::ThreadedMessageApplet::saveMessagesToFlash()
 {
-    messageStore.saveToFlash();
+    // Create a label (will become the filename in flash)
+    std::string label = "ch" + to_string(channelIndex);
+
+    store->saveToFlash();
 }
 
-// Messages are loaded once by InkHUD::begin() before applets start.
-// Nothing to do here at per-applet activation time.
+// Load recent messages to flash
+// Fills ThreadedMessageApplet::messages with previous messages
+// Just enough messages have been stored to cover the display
 void InkHUD::ThreadedMessageApplet::loadMessagesFromFlash()
 {
-    // No-op: messageStore.loadFromFlash() is called in InkHUD::begin()
+    // Create a label (will become the filename in flash)
+    std::string label = "ch" + to_string(channelIndex);
+
+    store->loadFromFlash();
 }
 
 // Code to run when device is shutting down
 // This is in addition to any onDeactivate() code, which will also run
+// Todo: implement before a reboot also
 void InkHUD::ThreadedMessageApplet::onShutdown()
 {
-    // messageStore.saveToFlash() is called centrally by Events::beforeDeepSleep / beforeReboot
+    // Save our current set of messages to flash, provided the applet isn't disabled
+    if (isActive())
+        saveMessagesToFlash();
 }
 
-#endif
+#endif

src/graphics/niche/InkHUD/Applets/User/ThreadedMessage/ThreadedMessageApplet.h

@@ -20,8 +20,8 @@ Suggest a max of two channel, to minimize fs usage?
 
 #include "configuration.h"
 
-#include "MessageStore.h"
 #include "graphics/niche/InkHUD/Applet.h"
+#include "graphics/niche/InkHUD/MessageStore.h"
 
 #include "modules/TextMessageModule.h"
 
@@ -49,6 +49,7 @@ class ThreadedMessageApplet : public Applet, public SinglePortModule
     void saveMessagesToFlash();
     void loadMessagesFromFlash();
 
+    MessageStore *store; // Messages, held in RAM for use, ready to save to flash on shutdown
     uint8_t channelIndex = 0;
 };
 

src/graphics/niche/InkHUD/Events.cpp

@@ -2,7 +2,6 @@
 
 #include "./Events.h"
 
-#include "MessageStore.h"
 #include "PowerFSM.h"
 #include "RTC.h"
 #include "buzz.h"
@@ -515,7 +514,6 @@ int InkHUD::Events::beforeReboot(void *unused)
         inkhud->persistence->saveLatestMessage();
     } else {
         NicheGraphics::clearFlashData();
-        messageStore.clearAllMessages(); // also wipe the shared message store
     }
 
     // Note: no forceUpdate call here
@@ -534,27 +532,32 @@ int InkHUD::Events::onReceiveTextMessage(const meshtastic_MeshPacket *packet)
     if (getFrom(packet) == nodeDB->getNodeNum())
         return 0;
 
-    bool isBroadcastMsg = isBroadcast(packet->to);
-    inkhud->persistence->latestMessage.wasBroadcast = isBroadcastMsg;
+    // Determine whether the message is broadcast or a DM
+    // Store this info to prevent confusion after a reboot
+    // Avoids need to compare timestamps, because of situation where "future" messages block newly received, if time not set
+    inkhud->persistence->latestMessage.wasBroadcast = isBroadcast(packet->to);
 
-    if (!isBroadcastMsg) {
-        // DMs never pass through ThreadedMessageApplet, so add them to the global store here
-        // so they survive reboots. Derive the latestMessage cache entry from the stored result.
-        inkhud->persistence->latestMessage.dm = messageStore.addFromPacket(*packet);
-    } else {
-        // Broadcasts are added to the global store by ThreadedMessageApplet::handleReceived().
-        // Here we only update the latestMessage cache used by AllMessageApplet / NotificationApplet.
-        StoredMessage &sm = inkhud->persistence->latestMessage.broadcast;
-        sm.sender = packet->from;
-        sm.timestamp = getValidTime(RTCQuality::RTCQualityDevice, true);
-        sm.channelIndex = packet->channel;
-        const char *payload = reinterpret_cast<const char *>(packet->decoded.payload.bytes);
-        size_t storedLen = packet->decoded.payload.size;
-        if (storedLen >= MAX_MESSAGE_SIZE)
-            storedLen = MAX_MESSAGE_SIZE - 1;
-        sm.textOffset = MessageStore::storeText(payload, storedLen);
-        sm.textLength = static_cast<uint16_t>(storedLen);
-    }
+    // Pick the appropriate variable to store the message in
+    MessageStore::Message *storedMessage = inkhud->persistence->latestMessage.wasBroadcast
+                                               ? &inkhud->persistence->latestMessage.broadcast
+                                               : &inkhud->persistence->latestMessage.dm;
+
+    // Store nodenum of the sender
+    // Applets can use this to fetch user data from nodedb, if they want
+    storedMessage->sender = packet->from;
+
+    // Store the time (epoch seconds) when message received
+    storedMessage->timestamp = getValidTime(RTCQuality::RTCQualityDevice, true); // Current RTC time
+
+    // Store the channel
+    // - (potentially) used to determine whether notification shows
+    // - (potentially) used to determine which applet to focus
+    storedMessage->channelIndex = packet->channel;
+
+    // Store the text
+    // Need to specify manually how many bytes, because source not null-terminated
+    storedMessage->text =
+        std::string(&packet->decoded.payload.bytes[0], &packet->decoded.payload.bytes[packet->decoded.payload.size]);
 
     return 0; // Tell caller to continue notifying other observers. (No reason to abort this event)
 }

src/graphics/niche/InkHUD/InkHUD.cpp

@@ -9,10 +9,6 @@
 #include "./SystemApplet.h"
 #include "./Tile.h"
 #include "./WindowManager.h"
-#include "FSCommon.h"
-#include "MessageStore.h"
-#include "SPILock.h"
-#include "concurrency/LockGuard.h"
 
 using namespace NicheGraphics;
 
@@ -64,102 +60,11 @@ void InkHUD::InkHUD::notifyApplyingChanges()
     }
 }
 
-// One-time migration from the old per-channel InkHUD message files (/NicheGraphics/ch*.msgs)
-// to the firmware-wide MessageStore format (/Messages_default.msgs).
-// Only runs when the new store loaded empty, meaning this is the first boot after the format change.
-// Old files are deleted once migrated.
-static void migrateOldInkHUDMessages()
-{
-#ifdef FSCom
-    bool migrated = false;
-    constexpr uint8_t MAX_CHANNELS = 8;
-    constexpr uint32_t OLD_MAX_MSG_SIZE = 250;
-
-    for (uint8_t ch = 0; ch < MAX_CHANNELS; ch++) {
-        std::string path = "/NicheGraphics/ch";
-        path += std::to_string(ch);
-        path += ".msgs";
-
-        spiLock->lock();
-        bool exists = FSCom.exists(path.c_str());
-        spiLock->unlock();
-        if (!exists)
-            continue;
-
-        concurrency::LockGuard guard(spiLock);
-
-        auto f = FSCom.open(path.c_str(), FILE_O_READ);
-        if (!f || f.size() == 0) {
-            if (f)
-                f.close();
-            FSCom.remove(path.c_str());
-            continue;
-        }
-
-        uint8_t count = 0;
-        f.readBytes(reinterpret_cast<char *>(&count), 1);
-
-        std::vector<StoredMessage> channelMsgs;
-        for (uint8_t i = 0; i < count; i++) {
-            StoredMessage sm;
-            f.readBytes(reinterpret_cast<char *>(&sm.timestamp), sizeof(sm.timestamp));
-            f.readBytes(reinterpret_cast<char *>(&sm.sender), sizeof(sm.sender));
-            f.readBytes(reinterpret_cast<char *>(&sm.channelIndex), sizeof(sm.channelIndex));
-
-            char textBuf[OLD_MAX_MSG_SIZE + 1] = {};
-            uint32_t textLen = 0;
-            char c;
-            while (textLen < OLD_MAX_MSG_SIZE) {
-                if (f.readBytes(&c, 1) != 1)
-                    break;
-                if (c == '\0')
-                    break;
-                textBuf[textLen++] = c;
-            }
-
-            sm.dest = NODENUM_BROADCAST;
-            sm.type = MessageType::BROADCAST;
-            sm.isBootRelative = false;
-            sm.ackStatus = AckStatus::ACKED;
-            size_t storedLen = (textLen >= MAX_MESSAGE_SIZE) ? MAX_MESSAGE_SIZE - 1 : textLen;
-            sm.textOffset = MessageStore::storeText(textBuf, storedLen);
-            sm.textLength = static_cast<uint16_t>(storedLen);
-
-            channelMsgs.push_back(sm);
-        }
-
-        // Old format stored newest-first (push_front); insert oldest-first for correct chronological order
-        for (int i = static_cast<int>(channelMsgs.size()) - 1; i >= 0; i--)
-            messageStore.addLiveMessage(channelMsgs[i]);
-        if (!channelMsgs.empty())
-            migrated = true;
-
-        f.close();
-        FSCom.remove(path.c_str());
-        LOG_INFO("Migrated %u messages from %s", static_cast<uint32_t>(count), path.c_str());
-    }
-
-    // Delete the old latest.msgs; the latestMessage cache will be re-derived from migrated channel messages
-    spiLock->lock();
-    if (FSCom.exists("/NicheGraphics/latest.msgs"))
-        FSCom.remove("/NicheGraphics/latest.msgs");
-    spiLock->unlock();
-
-    if (migrated) {
-        LOG_INFO("InkHUD message migration complete, saving to new format");
-        messageStore.saveToFlash();
-    }
-#endif
-}
-
 // Start InkHUD!
 // Call this only after you have configured InkHUD
 void InkHUD::InkHUD::begin()
 {
     persistence->loadSettings();
-    messageStore.loadFromFlash(); // Load persisted messages before deriving latestMessage cache
-    if (messageStore.getLiveMessages().empty())
-        migrateOldInkHUDMessages(); // First boot after format change: import old per-channel files
     persistence->loadLatestMessage();
 
     windowManager->begin();

src/graphics/niche/InkHUD/MessageStore.cpp

@@ -0,0 +1,156 @@
+#ifdef MESHTASTIC_INCLUDE_INKHUD
+
+#include "./MessageStore.h"
+
+#include "SafeFile.h"
+
+using namespace NicheGraphics;
+
+// Hard limits on how much message data to write to flash
+// Avoid filling the storage if something goes wrong
+// Normal usage should be well below this size
+constexpr uint8_t MAX_MESSAGES_SAVED = 10;
+constexpr uint32_t MAX_MESSAGE_SIZE = 250;
+
+InkHUD::MessageStore::MessageStore(const std::string &label)
+{
+    filename = "";
+    filename += "/NicheGraphics";
+    filename += "/";
+    filename += label;
+    filename += ".msgs";
+}
+
+// Write the contents of the MessageStore::messages object to flash
+// Takes the firmware's SPI lock during FS operations. Implemented for consistency, but only relevant when using SD card.
+// Need to lock and unlock around specific FS methods, as the SafeFile class takes the lock for itself internally
+void InkHUD::MessageStore::saveToFlash()
+{
+    assert(!filename.empty());
+
+#ifdef FSCom
+    // Make the directory, if doesn't already exist
+    // This is the same directory accessed by NicheGraphics::FlashData
+    spiLock->lock();
+    FSCom.mkdir("/NicheGraphics");
+    spiLock->unlock();
+
+    // Open or create the file
+    // No "full atomic": don't save then rename
+    auto f = SafeFile(filename.c_str(), false);
+
+    LOG_INFO("Saving messages in %s", filename.c_str());
+
+    // Take firmware's SPI Lock while writing
+    spiLock->lock();
+
+    // 1st byte: how many messages will be written to store
+    f.write(messages.size());
+
+    // For each message
+    for (uint8_t i = 0; i < messages.size() && i < MAX_MESSAGES_SAVED; i++) {
+        Message &m = messages.at(i);
+        f.write(reinterpret_cast<const uint8_t *>(&m.timestamp), sizeof(m.timestamp));       // Write timestamp. 4 bytes
+        f.write(reinterpret_cast<const uint8_t *>(&m.sender), sizeof(m.sender));             // Write sender NodeId. 4 Bytes
+        f.write(reinterpret_cast<const uint8_t *>(&m.channelIndex), sizeof(m.channelIndex)); // Write channel index. 1 Byte
+        f.write(reinterpret_cast<const uint8_t *>(m.text.c_str()),
+                min((size_t)MAX_MESSAGE_SIZE, m.text.size())); // Write message text
+        f.write('\0');                                         // Append null term
+        LOG_DEBUG("Wrote message %u, length %u, text \"%s\"", static_cast<uint32_t>(i),
+                  min((size_t)MAX_MESSAGE_SIZE, m.text.size()), m.text.c_str());
+    }
+
+    // Release firmware's SPI lock, because SafeFile::close needs it
+    spiLock->unlock();
+
+    bool writeSucceeded = f.close();
+
+    if (!writeSucceeded) {
+        LOG_ERROR("Can't write data!");
+    }
+#else
+    LOG_ERROR("ERROR: Filesystem not implemented\n");
+#endif
+}
+
+// Attempt to load the previous contents of the MessageStore:message deque from flash.
+// Filename is controlled by the "label" parameter
+// Takes the firmware's SPI lock during FS operations. Implemented for consistency, but only relevant when using SD card.
+void InkHUD::MessageStore::loadFromFlash()
+{
+    // Hopefully redundant. Initial intention is to only load / save once per boot.
+    messages.clear();
+
+#ifdef FSCom
+
+    // Take the firmware's SPI Lock, in case filesystem is on SD card
+    concurrency::LockGuard guard(spiLock);
+
+    // Check that the file *does* actually exist
+    if (!FSCom.exists(filename.c_str())) {
+        LOG_WARN("'%s' not found. Using default values", filename.c_str());
+        return;
+    }
+
+    // Check that the file *does* actually exist
+    if (!FSCom.exists(filename.c_str())) {
+        LOG_INFO("'%s' not found.", filename.c_str());
+        return;
+    }
+
+    // Open the file
+    auto f = FSCom.open(filename.c_str(), FILE_O_READ);
+
+    if (f.size() == 0) {
+        LOG_INFO("%s is empty", filename.c_str());
+        f.close();
+        return;
+    }
+
+    // If opened, start reading
+    if (f) {
+        LOG_INFO("Loading threaded messages '%s'", filename.c_str());
+
+        // First byte: how many messages are in the flash store
+        uint8_t flashMessageCount = 0;
+        f.readBytes(reinterpret_cast<char *>(&flashMessageCount), 1);
+        LOG_DEBUG("Messages available: %u", static_cast<uint32_t>(flashMessageCount));
+
+        // For each message
+        for (uint8_t i = 0; i < flashMessageCount && i < MAX_MESSAGES_SAVED; i++) {
+            Message m;
+
+            // Read meta data (fixed width)
+            f.readBytes(reinterpret_cast<char *>(&m.timestamp), sizeof(m.timestamp));
+            f.readBytes(reinterpret_cast<char *>(&m.sender), sizeof(m.sender));
+            f.readBytes(reinterpret_cast<char *>(&m.channelIndex), sizeof(m.channelIndex));
+
+            // Read characters until we find a null term
+            char c;
+            while (m.text.size() < MAX_MESSAGE_SIZE) {
+                f.readBytes(&c, 1);
+                if (c != '\0')
+                    m.text += c;
+                else
+                    break;
+            }
+
+            // Store in RAM
+            messages.push_back(m);
+
+            LOG_DEBUG("#%u, timestamp=%u, sender(num)=%u, text=\"%s\"", static_cast<uint32_t>(i), m.timestamp, m.sender,
+                      m.text.c_str());
+        }
+
+        f.close();
+    } else {
+        LOG_ERROR("Could not open / read %s", filename.c_str());
+    }
+#else
+    LOG_ERROR("Filesystem not implemented");
+    state = LoadFileState::NO_FILESYSTEM;
+#endif
+    return;
+}
+
+#endif

src/graphics/niche/InkHUD/MessageStore.h

@@ -0,0 +1,47 @@
+#ifdef MESHTASTIC_INCLUDE_INKHUD
+
+/*
+
+We hold a few recent messages, for features like the threaded message applet.
+This class contains a struct for storing those messages,
+and methods for serializing them to flash.
+
+*/
+
+#pragma once
+
+#include "configuration.h"
+
+#include <deque>
+
+#include "mesh/MeshTypes.h"
+
+namespace NicheGraphics::InkHUD
+{
+
+class MessageStore
+{
+  public:
+    // A stored message
+    struct Message {
+        uint32_t timestamp; // Epoch seconds
+        NodeNum sender = 0;
+        uint8_t channelIndex;
+        std::string text;
+    };
+
+    MessageStore() = delete;
+    explicit MessageStore(const std::string &label); // Label determines filename in flash
+
+    void saveToFlash();
+    void loadFromFlash();
+
+    std::deque<Message> messages; // Interact with this object!
+
+  private:
+    std::string filename;
+};
+
+} // namespace NicheGraphics::InkHUD
+
+#endif

src/graphics/niche/InkHUD/Persistence.cpp

@@ -17,25 +17,23 @@ void InkHUD::Persistence::loadSettings()
         LOG_WARN("Settings version changed. Using defaults");
 }
 
-// Rebuild the latestMessage cache from the global messageStore.
-// Called after messageStore.loadFromFlash() so that the most recent broadcast and DM
-// are immediately available to applets (DMApplet, AllMessageApplet, NotificationApplet).
+// Load settings and latestMessage data
 void InkHUD::Persistence::loadLatestMessage()
 {
-    latestMessage = LatestMessage();
+    // Load previous "latestMessages" data from flash
+    MessageStore store("latest");
+    store.loadFromFlash();
 
-    int lastBroadcastPos = -1, lastDMPos = -1, pos = 0;
-    for (const StoredMessage &m : messageStore.getLiveMessages()) {
-        if (m.type == MessageType::BROADCAST) {
-            latestMessage.broadcast = m;
-            lastBroadcastPos = pos;
-        } else if (m.type == MessageType::DM_TO_US) {
-            latestMessage.dm = m;
-            lastDMPos = pos;
-        }
-        pos++;
+    // Place into latestMessage struct, for convenient access
+    // Number of strings loaded determines whether last message was broadcast or dm
+    if (store.messages.size() == 1) {
+        latestMessage.dm = store.messages.at(0);
+        latestMessage.wasBroadcast = false;
+    } else if (store.messages.size() == 2) {
+        latestMessage.dm = store.messages.at(0);
+        latestMessage.broadcast = store.messages.at(1);
+        latestMessage.wasBroadcast = true;
     }
-    latestMessage.wasBroadcast = (lastBroadcastPos > lastDMPos);
 }
 
 // Save the InkHUD settings to flash
@@ -44,10 +42,15 @@ void InkHUD::Persistence::saveSettings()
     FlashData<Settings>::save(&settings, "settings");
 }
 
-// Persist all messages via the global messageStore.
+// Save latestMessage data to flash
 void InkHUD::Persistence::saveLatestMessage()
 {
-    messageStore.saveToFlash();
+    // Number of strings saved determines whether last message was broadcast or dm
+    MessageStore store("latest");
+    store.messages.push_back(latestMessage.dm);
+    if (latestMessage.wasBroadcast)
+        store.messages.push_back(latestMessage.broadcast);
+    store.saveToFlash();
 }
 
 /*
@@ -77,4 +80,4 @@ void InkHUD::Persistence::printSettings(Settings *settings)
 }
 */
 
-#endif
+#endif

src/graphics/niche/InkHUD/Persistence.h

@@ -15,7 +15,7 @@ The save / load mechanism is a shared NicheGraphics feature.
 #include "configuration.h"
 
 #include "./InkHUD.h"
-#include "MessageStore.h"
+#include "graphics/niche/InkHUD/MessageStore.h"
 #include "graphics/niche/Utils/FlashData.h"
 
 namespace NicheGraphics::InkHUD
@@ -120,12 +120,12 @@ class Persistence
     };
 
     // Most recently received text message
-    // Value is updated by InkHUD::Events, as a courtesy to applets.
-    // Populated at boot from the global messageStore, then updated live on receive.
+    // Value is updated by InkHUD::WindowManager, as a courtesy to applets
+    // InkHUD keeps its own latest-message cache for applets.
     struct LatestMessage {
-        StoredMessage broadcast; // Most recent broadcast message received
-        StoredMessage dm;        // Most recent DM received
-        bool wasBroadcast;       // True if most recent broadcast is newer than most recent dm
+        MessageStore::Message broadcast; // Most recent message received broadcast
+        MessageStore::Message dm;        // Most recent received DM
+        bool wasBroadcast;               // True if most recent broadcast is newer than most recent dm
     };
 
     void loadSettings();

src/graphics/niche/InkHUD/docs/README.md

@@ -422,11 +422,9 @@ Stores InkHUD data in flash
 - settings
 - most recent text message received (both for broadcast and DM)
 
-Message history (used by `ThreadedMessageApplet`) is stored by the firmware-wide `MessageStore` (`src/MessageStore.h`), not by `Persistence` directly.
+In rare cases, applets may store their own specific data separately (e.g. `ThreadedMessageApplet`)
 
-Settings are saved only on shutdown / reboot. Not saved if power is removed unexpectedly.
-
-Message history is saved periodically (every 2 hours by default), as well as on shutdown / reboot.
+Data saved only on shutdown / reboot. Not saved if power is removed unexpectedly.
 
 ---
 
@@ -468,21 +466,18 @@ Collected here, so various user applets don't all have to store their own copy o
 
 We keep this separate latest-message cache for this purpose, because:
 
-- we want to expose both the most recent broadcast and most recent DM independently
-- applets like `DMApplet` and `NotificationApplet` need quick access without scanning the full message history
-
-#### How messages reach the store
-
-Broadcasts and DMs take different paths into `messageStore`:
-
-- **Broadcasts** — `ThreadedMessageApplet::handleReceived()` calls `messageStore.addFromPacket()`. `Events::onReceiveTextMessage()` then updates `latestMessage.broadcast` separately for fast access by `AllMessageApplet` and `NotificationApplet`.
-- **DMs** — `ThreadedMessageApplet` skips DMs entirely. `Events::onReceiveTextMessage()` calls `messageStore.addFromPacket()` directly and stores the result in `latestMessage.dm`.
+- it is cleared by an outgoing text message
+- we want to store both a recent broadcast and a recent DM
 
 #### Saving / Loading
 
-The `LatestMessage` cache is not persisted to its own file. On boot, `InkHUD::begin()` calls `messageStore.loadFromFlash()` first, then `Persistence::loadLatestMessage()` rebuilds the cache by scanning the loaded messages for the most recent broadcast and DM.
+_A bit of a hack.._
+Stored to flash using `InkHUD::MessageStore`, which is really intended for storing a thread of messages (see `ThreadedMessageApplet`). Used because it stores strings more efficiently than `FlashData.h`.
 
-Text is stored in the firmware-wide shared text pool. Use `MessageStore::getText(msg)` to retrieve it from a `StoredMessage`.
+The hack is:
+
+- If most recent message was a DM, we only store the DM.
+- If most recent message was a broadcast, we store both a DM and a broadcast. The DM may be 0-length string.
 
 ---
 
@@ -587,17 +582,13 @@ Handles events which impact the InkHUD system generally (e.g. shutdown, button p
 
 Applets themselves do also listen separately for various events, but for the purpose of gathering information which they would like to display.
 
-#### Text Messages
-
-`Events::onReceiveTextMessage()` is the central handler for all incoming text messages. It updates the `LatestMessage` cache and, for DMs, also adds the message to `messageStore` (since `ThreadedMessageApplet` only handles broadcasts). See `Persistence::LatestMessage` for details on how the two message types are stored.
-
 #### Buttons
 
 Button input is sometimes handled by a system applet. `InkHUD::Events` determines whether the button should be handled by a specific system applet, or should instead trigger a default behavior
 
 #### Factory Reset
 
-The Events class handles the admin message(s) which trigger factory reset. We set `Events::eraseOnReboot = true`, which causes `Events::onReboot` to erase the contents of InkHUD's data directory (`/NicheGraphics/`) and also call `messageStore.clearAllMessages()` to wipe the firmware-wide message store (`/Messages_default.msgs`). Both are cleared during reboot rather than earlier, to avoid data being re-written by applets still running before shutdown.
+The Events class handles the admin messages(s) which trigger factory reset. We set `Events::eraseOnReboot = true`, which causes `Events::onReboot` to erase the contents of InkHUD's data directory. We do this because some applets (e.g. ThreadedMessageApplet) save their own data to flash, so if we erased earlier, that data would get re-written during reboot.
 
 ---
 

src/input/InputBroker.cpp

@@ -3,9 +3,6 @@
 #include "configuration.h"
 #include "graphics/Screen.h"
 #include "modules/ExternalNotificationModule.h"
-#ifdef MESHTASTIC_LOCKDOWN
-#include "security/LockdownDisplay.h"
-#endif
 
 #if ARCH_PORTDUINO
 #include "input/LinuxInputImpl.h"
@@ -125,22 +122,6 @@ int InputBroker::handleInputEvent(const InputEvent *event)
     }
 #endif
 
-#ifdef MESHTASTIC_LOCKDOWN
-    // Lockdown: when the display is redacted (storage locked, or screen-lock
-    // latch set after idle) the screen content is hidden, but local input
-    // would otherwise still flow into UI handlers — letting an operator
-    // drive menus, fire canned messages, change settings etc. blind. Eat
-    // the event here so input is no-op until the redaction clears.
-    // The latch is cleared only by unlockScreen() on a successful
-    // passphrase auth (see PhoneAPI::handleLockdownAuthInline) — local
-    // input does not clear it, even if storage happens to be unlocked.
-    // PowerFSM was already triggered above, so the backlight still wakes
-    // to show the LOCKED frame — the input just doesn't act on anything.
-    if (meshtastic_security::shouldRedactDisplay()) {
-        return 0;
-    }
-#endif
-
     this->notifyObservers(event);
     return 0;
 }

src/main.cpp

@@ -68,19 +68,6 @@ void nrf54l15Loop();
 NRF54L15Bluetooth *nrf54l15Bluetooth = nullptr;
 #endif
 
-#ifdef MESHTASTIC_ENABLE_APPROTECT
-#include "security/APProtect.h"
-#endif
-#ifdef MESHTASTIC_ENCRYPTED_STORAGE
-#include "security/EncryptedStorage.h"
-#endif
-#ifdef MESHTASTIC_PHONEAPI_ACCESS_CONTROL
-#include "mesh/PhoneAPI.h"
-#endif
-#ifdef MESHTASTIC_LOCKDOWN
-#include "security/LockdownDisplay.h"
-#endif
-
 #if HAS_WIFI || defined(USE_WS5500) || defined(USE_CH390D)
 #include "mesh/api/WiFiServerAPI.h"
 #include "mesh/wifi/WiFiAPClient.h"
@@ -149,10 +136,6 @@ void printPartitionTable()
 #include "motion/AccelerometerThread.h"
 AccelerometerThread *accelerometerThread = nullptr;
 #endif
-#if !defined(ARCH_STM32WL) && !MESHTASTIC_EXCLUDE_I2C && !MESHTASTIC_EXCLUDE_MAGNETOMETER
-#include "motion/MagnetometerThread.h"
-MagnetometerThread *magnetometerThread = nullptr;
-#endif
 
 #ifdef HAS_I2S
 #include "AudioThread.h"
@@ -223,8 +206,6 @@ bool osk_found = false;
 ScanI2C::DeviceAddress rtc_found = ScanI2C::ADDRESS_NONE;
 // The I2C address of the Accelerometer (if found)
 ScanI2C::DeviceAddress accelerometer_found = ScanI2C::ADDRESS_NONE;
-// The I2C address of the Magnetometer (if found)
-ScanI2C::DeviceAddress magnetometer_found = ScanI2C::ADDRESS_NONE;
 // The I2C address of the RGB LED (if found)
 ScanI2C::FoundDevice rgb_found = ScanI2C::FoundDevice(ScanI2C::DeviceType::NONE, ScanI2C::ADDRESS_NONE);
 /// The I2C address of our Air Quality Indicator (if found)
@@ -392,14 +373,6 @@ void setup()
     consoleInit(); // Set serial baud rate and init our mesh console
 #endif
 
-    // M23 (audit): APPROTECT engagement moved below fsInit() so we can gate
-    // on EncryptedStorage::isProvisioned(). Engaging on an unprovisioned dev
-    // board permanently locks SWD before the operator has even set a
-    // passphrase — a misconfigured CI build flashed to a developer device
-    // would brick its debug port on first boot. Now we only engage when the
-    // device has a DEK file on flash, i.e. the operator has explicitly
-    // committed to lockdown via passphrase provisioning.
-
 #ifdef UNPHONE
     unphone.printStore();
 #endif
@@ -430,12 +403,7 @@ void setup()
 #endif
 #endif
 
-    // The DEBUG_MUTE "we are muted, FYI" banner spills APP_VERSION / APP_ENV /
-    // APP_REPO out the USB CDC even with logging otherwise suppressed — a free
-    // firmware-fingerprinting primitive for an attacker holding the cable.
-    // Under MESHTASTIC_LOCKDOWN we want the device to look uniformly silent
-    // until the operator authenticates, so skip the banner entirely there.
-#if defined(DEBUG_MUTE) && defined(DEBUG_PORT) && !defined(MESHTASTIC_LOCKDOWN)
+#if defined(DEBUG_MUTE) && defined(DEBUG_PORT)
     DEBUG_PORT.printf("\r\n\r\n//\\ E S H T /\\ S T / C\r\n");
     DEBUG_PORT.printf("Version %s for %s from %s\r\n", optstr(APP_VERSION), optstr(APP_ENV), optstr(APP_REPO));
     DEBUG_PORT.printf("Debug mute is enabled, there will be no serial output.\r\n");
@@ -463,11 +431,6 @@ void setup()
     digitalWrite(VEXT_ENABLE, VEXT_ON_VALUE); // turn on the display power
 #endif
 
-#if defined(PIN_SENSOR_EN)
-    pinMode(PIN_SENSOR_EN, OUTPUT);
-    digitalWrite(PIN_SENSOR_EN, PIN_SENSOR_EN_ACTIVE); // turn on sensor power
-#endif
-
 #if defined(BIAS_T_ENABLE)
     pinMode(BIAS_T_ENABLE, OUTPUT);
     digitalWrite(BIAS_T_ENABLE, BIAS_T_VALUE); // turn on 5V for GPS Antenna
@@ -507,38 +470,6 @@ void setup()
 
     fsInit();
 
-#ifdef MESHTASTIC_ENCRYPTED_STORAGE
-    EncryptedStorage::initLocked();
-    if (!EncryptedStorage::isUnlocked()) {
-        if (!EncryptedStorage::isProvisioned()) {
-            LOG_WARN("Lockdown: Device not provisioned — connect and set a passphrase to unlock storage");
-        } else {
-            LOG_WARN("Lockdown: Device locked — connect and provide passphrase to unlock storage");
-        }
-    }
-#endif
-
-#if defined(MESHTASTIC_ENABLE_APPROTECT) && defined(MESHTASTIC_ENCRYPTED_STORAGE)
-    // M23 (audit): only engage the irreversible UICR APPROTECT lockout once
-    // the device has been provisioned with a passphrase. A misconfigured
-    // CI build of a lockdown variant flashed to a developer board would
-    // otherwise burn SWD on first boot before the operator has even set a
-    // passphrase, taking the board out of the dev/recovery workflow with
-    // no real security benefit (there's no DEK to protect yet). Once a
-    // DEK file exists, the operator has committed to lockdown — engaging
-    // APPROTECT then is the protection they asked for.
-    if (EncryptedStorage::isProvisioned()) {
-        enableAPProtect();
-    } else {
-        LOG_INFO("APPROTECT deferred: device not yet provisioned");
-    }
-#elif defined(MESHTASTIC_ENABLE_APPROTECT)
-    // Lockdown without encrypted storage shouldn't be reachable per
-    // configuration.h, but if it ever is, fall back to the unconditional
-    // engagement.
-    enableAPProtect();
-#endif
-
 #if !MESHTASTIC_EXCLUDE_I2C
 #if defined(I2C_SDA1) && defined(ARCH_RP2040)
     Wire1.setSDA(I2C_SDA1);
@@ -740,11 +671,6 @@ void setup()
     accelerometer_found = acc_info.type != ScanI2C::DeviceType::NONE ? acc_info.address : accelerometer_found;
     LOG_DEBUG("acc_info = %i", acc_info.type);
 #endif
-#if !defined(ARCH_STM32WL) && !MESHTASTIC_EXCLUDE_MAGNETOMETER
-    auto mag_info = i2cScanner->firstMagnetometer();
-    magnetometer_found = mag_info.type != ScanI2C::DeviceType::NONE ? mag_info.address : magnetometer_found;
-    LOG_DEBUG("mag_info = %i", mag_info.type);
-#endif
 
     scannerToSensorsMap(i2cScanner, ScanI2C::DeviceType::INA260, meshtastic_TelemetrySensorType_INA260);
     scannerToSensorsMap(i2cScanner, ScanI2C::DeviceType::INA226, meshtastic_TelemetrySensorType_INA226);
@@ -757,8 +683,6 @@ void setup()
     scannerToSensorsMap(i2cScanner, ScanI2C::DeviceType::QMI8658, meshtastic_TelemetrySensorType_QMI8658);
     scannerToSensorsMap(i2cScanner, ScanI2C::DeviceType::QMC5883L, meshtastic_TelemetrySensorType_QMC5883L);
     scannerToSensorsMap(i2cScanner, ScanI2C::DeviceType::HMC5883L, meshtastic_TelemetrySensorType_QMC5883L);
-    scannerToSensorsMap(i2cScanner, ScanI2C::DeviceType::MMC5983MA, meshtastic_TelemetrySensorType_MMC5983MA);
-    scannerToSensorsMap(i2cScanner, ScanI2C::DeviceType::ICM42607P, meshtastic_TelemetrySensorType_ICM42607P);
     scannerToSensorsMap(i2cScanner, ScanI2C::DeviceType::MLX90614, meshtastic_TelemetrySensorType_MLX90614);
     scannerToSensorsMap(i2cScanner, ScanI2C::DeviceType::ICM20948, meshtastic_TelemetrySensorType_ICM20948);
     scannerToSensorsMap(i2cScanner, ScanI2C::DeviceType::MAX30102, meshtastic_TelemetrySensorType_MAX30102);
@@ -842,11 +766,6 @@ void setup()
         accelerometerThread = new AccelerometerThread(acc_info.type);
     }
 #endif
-#if !defined(ARCH_STM32WL) && !MESHTASTIC_EXCLUDE_MAGNETOMETER
-    if (mag_info.type != ScanI2C::DeviceType::NONE) {
-        magnetometerThread = new MagnetometerThread(mag_info.type);
-    }
-#endif
 
 #if defined(HAS_NEOPIXEL) || defined(UNPHONE) || defined(RGBLED_RED)
     ambientLightingThread = new AmbientLightingThread(ScanI2C::DeviceType::NONE);
@@ -1056,12 +975,8 @@ void setup()
 #endif
 #endif
 
-    std::unique_ptr<RadioInterface> rIf;
-    if (!config.lora.serial_hal_only) {
-        rIf = initLoRa();
-    } else {
-        LOG_INFO("skipping LoRa radio init, for serialHal");
-    }
+    auto rIf = initLoRa();
+
     lateInitVariant(); // Do board specific init (see extra_variants/README.md for documentation)
 
 #if !MESHTASTIC_EXCLUDE_MQTT
@@ -1105,9 +1020,10 @@ void setup()
 
     // Start airtime logger thread.
     airTime = new AirTime();
-    if (!rIf && !config.lora.serial_hal_only)
+
+    if (!rIf)
         RECORD_CRITICALERROR(meshtastic_CriticalErrorCode_NO_RADIO);
-    else if (rIf) {
+    else {
         // Log bit rate to debug output
         LOG_DEBUG("LoRA bitrate = %f bytes / sec", (float(meshtastic_Constants_DATA_PAYLOAD_LEN) /
                                                     (float(rIf->getPacketTime(meshtastic_Constants_DATA_PAYLOAD_LEN)))) *
@@ -1138,11 +1054,6 @@ uint32_t rebootAtMsec;     // If not zero we will reboot at this time (used to r
 uint32_t shutdownAtMsec;   // If not zero we will shutdown at this time (used to shutdown from python or mobile client)
 bool suppressRebootBanner; // If true, suppress "Rebooting..." overlay (used for OTA handoff)
 
-#if defined(MESHTASTIC_ENCRYPTED_STORAGE) && defined(MESHTASTIC_PHONEAPI_ACCESS_CONTROL)
-volatile bool lockdownReloadPending;  // see main.h — deferred NodeDB reload after lockdown unlock
-volatile bool lockdownDisablePending; // see main.h — deferred decrypt-revert after lockdown disable
-#endif
-
 // If a thread does something that might need for it to be rescheduled ASAP it can set this flag
 // This will suppress the current delay and instead try to run ASAP.
 bool runASAP;
@@ -1194,7 +1105,7 @@ extern meshtastic_DeviceMetadata getDeviceMetadata()
 // No bluetooth on these targets (yet):
 // Pico W / 2W may get it at some point
 // Portduino and ESP32-C6 are excluded because we don't have a working bluetooth stacks integrated yet.
-#if defined(ARCH_RP2040) || defined(ARCH_PORTDUINO) || defined(ARCH_STM32) || defined(CONFIG_IDF_TARGET_ESP32C6)
+#if defined(ARCH_RP2040) || defined(ARCH_PORTDUINO) || defined(ARCH_STM32WL) || defined(CONFIG_IDF_TARGET_ESP32C6)
     deviceMetadata.excluded_modules |= meshtastic_ExcludedModules_BLUETOOTH_CONFIG;
 #endif
 
@@ -1227,85 +1138,6 @@ void loop()
 {
     runASAP = false;
 
-#if defined(MESHTASTIC_ENCRYPTED_STORAGE) && defined(MESHTASTIC_PHONEAPI_ACCESS_CONTROL)
-    if (lockdownDisablePending) {
-        lockdownDisablePending = false;
-        LOG_INFO("Lockdown: disabling — reverting encrypted storage to plaintext");
-        if (nodeDB->disableLockdownToPlaintext()) {
-            LOG_INFO("Lockdown: disabled, rebooting into normal mode");
-            PhoneAPI::broadcastLockdownStatus(meshtastic_LockdownStatus_State_DISABLED, "", 0, 0, 0);
-            rebootAtMsec = millis() + DEFAULT_REBOOT_SECONDS * 1000;
-        } else {
-            // Revert failed mid-way (a file couldn't be decrypted/rewritten).
-            // The DEK file is still present (it's deleted last), so the device
-            // stays in lockdown and the operator can retry disable. Surface
-            // the failure rather than leaving the client hanging.
-            LOG_ERROR("Lockdown: disable revert failed — device remains in lockdown");
-            PhoneAPI::broadcastLockdownStatus(meshtastic_LockdownStatus_State_LOCKED, "disable_failed", 0, 0, 0);
-        }
-    }
-
-    if (lockdownReloadPending) {
-        lockdownReloadPending = false;
-        LOG_INFO("Lockdown: reloading config from disk after unlock");
-        bool reloadOk = nodeDB->reloadFromDisk();
-        if (!reloadOk) {
-            // Storage decrypt/decode failed during reload. Treat as
-            // unrecoverable for this boot: lock storage, revoke any
-            // auth that managed to slip through (defense in depth — the
-            // cold-unlock path doesn't authorize until completion, but
-            // a concurrent re-verify-path call from another connection
-            // might have), and notify clients. Storage will be locked
-            // on next boot anyway; deferring to the user-visible
-            // notification path is sufficient for now.
-            LOG_ERROR("Lockdown: reload failed — locking and notifying clients");
-            EncryptedStorage::lockNow();
-            PhoneAPI::revokeAllAuth();
-        }
-        PhoneAPI::completePendingUnlocks(reloadOk);
-    }
-
-    // Periodic session-expiry check. Cheap — millis() comparison. Don't
-    // hammer it every loop tick; once a second is plenty.
-    static uint32_t lastSessionCheckMs = 0;
-    if (millis() - lastSessionCheckMs > 1000) {
-        lastSessionCheckMs = millis();
-        if (rebootAtMsec == 0 && EncryptedStorage::isUnlocked() && EncryptedStorage::isSessionExpired()) {
-            // The session expired. Two paths:
-            //   1. Budget remains (bootsRemaining > 0): decrement the
-            //      on-flash boot count in place, revoke per-connection
-            //      auth, re-engage screen redaction, re-arm the uptime
-            //      timer — all WITHOUT rebooting. Storage stays unlocked
-            //      so the mesh keeps routing. Clients must re-authenticate
-            //      to see content again. The decrement is what enforces
-            //      the rollback ceiling — bootsRemaining ticks down
-            //      monotonically whether the device reboots or not.
-            //   2. Budget exhausted (bootsRemaining == 0): no more
-            //      sessions to grant. Hard lock (token deleted, DEK
-            //      zeroed) and reboot. Operator must re-enter passphrase.
-            if (EncryptedStorage::getBootsRemaining() == 0) {
-                LOG_WARN("Lockdown: session limit reached and boot budget exhausted, locking and rebooting");
-                EncryptedStorage::lockNow();
-                PhoneAPI::revokeAllAuth();
-                PhoneAPI::broadcastLockdownStatus(meshtastic_LockdownStatus_State_LOCKED, "session_budget_exhausted", 0, 0, 0);
-                rebootAtMsec = millis() + DEFAULT_REBOOT_SECONDS * 1000;
-            } else {
-                uint8_t newBoots = EncryptedStorage::consumeSessionBoot();
-                LOG_WARN("Lockdown: session expired, rolled to next budget slot (boots=%u remaining)", newBoots);
-                PhoneAPI::revokeAllAuth();
-                meshtastic_security::lockScreen();
-                // Signal clients that they need to re-auth on this
-                // connection. Storage is still unlocked (DEK in RAM,
-                // mesh keeps routing) but per-connection auth is gone.
-                // Reusing the LOCKED(needs_auth) post-config emission
-                // pattern so existing clients don't need a new state.
-                PhoneAPI::broadcastLockdownStatus(meshtastic_LockdownStatus_State_LOCKED, "needs_auth", newBoots,
-                                                  EncryptedStorage::getValidUntilEpoch(), 0);
-            }
-        }
-    }
-#endif
-
 #ifdef ARCH_ESP32
     esp32Loop();
 #endif
@@ -1388,7 +1220,7 @@ void loop()
     }
 #endif
 #endif
-#if (HAS_SCREEN || defined(MESHTASTIC_INCLUDE_NICHE_GRAPHICS)) && ENABLE_MESSAGE_PERSISTENCE
+#if HAS_SCREEN && ENABLE_MESSAGE_PERSISTENCE
     messageStoreAutosaveTick();
 #endif
     long delayMsec = mainController.runOrDelay();

src/main.h

@@ -39,7 +39,6 @@ extern bool kb_found;
 extern bool osk_found;
 extern ScanI2C::DeviceAddress rtc_found;
 extern ScanI2C::DeviceAddress accelerometer_found;
-extern ScanI2C::DeviceAddress magnetometer_found;
 extern ScanI2C::FoundDevice rgb_found;
 extern ScanI2C::DeviceAddress aqi_found;
 
@@ -74,10 +73,6 @@ extern graphics::Screen *screen;
 #include "motion/AccelerometerThread.h"
 extern AccelerometerThread *accelerometerThread;
 #endif
-#if !defined(ARCH_STM32WL) && !MESHTASTIC_EXCLUDE_I2C && !MESHTASTIC_EXCLUDE_MAGNETOMETER
-#include "motion/MagnetometerThread.h"
-extern MagnetometerThread *magnetometerThread;
-#endif
 
 extern bool isVibrating;
 
@@ -92,19 +87,6 @@ extern uint32_t rebootAtMsec;
 extern uint32_t shutdownAtMsec;
 extern bool suppressRebootBanner;
 
-#if defined(MESHTASTIC_ENCRYPTED_STORAGE) && defined(MESHTASTIC_PHONEAPI_ACCESS_CONTROL)
-// Set by PhoneAPI::handleLockdownAuthInline after a successful unlock.
-// Serviced on the main loop thread because NodeDB::reloadFromDisk() is
-// too heavy for the BLE/serial transport callback stack.
-extern volatile bool lockdownReloadPending;
-
-// Set by PhoneAPI::handleLockdownAuthInline on a disable request (after the
-// passphrase is verified). Serviced on the main loop thread: decrypt every
-// pref back to plaintext, remove the lockdown artifacts, reboot. Heavy file
-// IO, same reason as lockdownReloadPending.
-extern volatile bool lockdownDisablePending;
-#endif
-
 extern uint32_t serialSinceMsec;
 
 // If a thread does something that might need for it to be rescheduled ASAP it can set this flag

src/memGet.cpp

@@ -14,7 +14,7 @@
 #include <malloc.h>
 #include <unistd.h> // sbrk
 
-#if defined(ARCH_STM32)
+#ifdef ARCH_STM32WL
 // Returns the uncommitted sbrk headroom: addressable space between the current heap
 // break and the stack pointer that has not yet been committed to the arena.
 static uint32_t sbrkHeadroom()

src/mesh/Channels.cpp

@@ -404,60 +404,6 @@ bool Channels::isDefaultChannel(ChannelIndex chIndex)
     return false;
 }
 
-bool cryptoKeyIsPublic(const CryptoKey &key)
-{
-    if (key.length == 0)
-        return true; // encryption disabled
-    // Match the defaultpsk family ignoring its last byte (getKey() bumps only that byte per 1-byte index).
-    if (key.length == (int)sizeof(defaultpsk) && memcmp(key.bytes, defaultpsk, sizeof(defaultpsk) - 1) == 0)
-        return true;
-    return false;
-}
-
-bool Channels::usesPublicKey(ChannelIndex chIndex)
-{
-    const meshtastic_Channel &ch = getByIndex(chIndex);
-    if (!ch.has_settings || ch.role == meshtastic_Channel_Role_DISABLED)
-        return false;
-
-    const auto &psk = ch.settings.psk;
-    if (psk.size == 0) {
-        // Secondary channels inherit the primary key when unset; primary size==0 means encryption disabled.
-        if (ch.role == meshtastic_Channel_Role_SECONDARY) {
-            // Guard against malformed configs with no PRIMARY channel (primaryIndex could point back to us).
-            if (primaryIndex == chIndex)
-                return true; // fail closed: treat as public
-            return usesPublicKey(primaryIndex);
-        }
-        return true;
-    }
-
-    if (psk.size == 1) {
-        // Short PSK aliases: 0 disables encryption; 1..255 are the public defaultpsk family.
-        return true;
-    }
-
-    return (psk.size == sizeof(defaultpsk) && memcmp(psk.bytes, defaultpsk, sizeof(defaultpsk) - 1) == 0);
-}
-
-bool Channels::isWellKnownChannel(ChannelIndex chIndex)
-{
-    const auto &ch = getByIndex(chIndex);
-    // Absent (unencrypted) or single-byte PSK — all the well-known key indexes
-    if (ch.settings.psk.size > 1)
-        return false;
-
-    const char *name = getName(chIndex);
-    for (int p = _meshtastic_Config_LoRaConfig_ModemPreset_MIN; p <= _meshtastic_Config_LoRaConfig_ModemPreset_MAX; p++) {
-        const char *presetName =
-            DisplayFormatters::getModemPresetDisplayName(static_cast<meshtastic_Config_LoRaConfig_ModemPreset>(p), false, true);
-        // Presets without a display name fall through to "Invalid" — never a match
-        if (strcmp(presetName, "Invalid") != 0 && strcmp(name, presetName) == 0)
-            return true;
-    }
-    return false;
-}
-
 bool Channels::hasDefaultChannel()
 {
     // If we don't use a preset or the default frequency slot, or we override the frequency, we don't have a default channel

src/mesh/Channels.h

@@ -86,15 +86,6 @@ class Channels
     // Returns true if the channel has the default name and PSK
     bool isDefaultChannel(ChannelIndex chIndex);
 
-    // Returns true if this channel's effective key is publicly decryptable (open or well-known/default PSK).
-    bool usesPublicKey(ChannelIndex chIndex);
-    // Returns true if the channel is "well known": its PSK is absent or a
-    // single-byte well-known key index, AND its name is any modem-preset
-    // display name (e.g. a channel named "LongFast" counts even while the
-    // radio runs MediumFast). Broader than isDefaultChannel, which only
-    // matches the current preset's name and PSK byte 1.
-    bool isWellKnownChannel(ChannelIndex chIndex);
-
     // Returns true if we can be reached via a channel with the default settings given a region and modem preset
     bool hasDefaultChannel();
 
@@ -153,9 +144,6 @@ extern Channels channels;
 static const uint8_t defaultpsk[] = {0xd4, 0xf1, 0xbb, 0x3a, 0x20, 0x29, 0x07, 0x59,
                                      0xf0, 0xbc, 0xff, 0xab, 0xcf, 0x4e, 0x69, 0x01};
 
-/// True if a getKey()-resolved key offers no privacy: length 0 (off) or the public defaultpsk family. Pure; for tests.
-bool cryptoKeyIsPublic(const CryptoKey &key);
-
 static const uint8_t eventpsk[] = {0x38, 0x4b, 0xbc, 0xc0, 0x1d, 0xc0, 0x22, 0xd1, 0x81, 0xbf, 0x36,
                                    0xb8, 0x61, 0x21, 0xe1, 0xfb, 0x96, 0xb7, 0x2e, 0x55, 0xbf, 0x74,
                                    0x22, 0x7e, 0x9d, 0x6a, 0xfb, 0x48, 0xd6, 0x4c, 0xb1, 0xa1};

src/mesh/CryptoEngine.cpp

@@ -12,18 +12,10 @@
 #include <Curve25519.h>
 #include <RNG.h>
 #include <SHA256.h>
-
-#if !(MESHTASTIC_EXCLUDE_XEDDSA)
-#include "XEdDSA.h"
-#include <Ed25519.h>
-
-#ifndef NUM_LIMBS_256BIT
-#define NUM_LIMBS_BITS(n) (((n) + sizeof(limb_t) * 8 - 1) / (8 * sizeof(limb_t)))
-#define NUM_LIMBS_256BIT NUM_LIMBS_BITS(256)
-#endif
-#endif
-
 #if !(MESHTASTIC_EXCLUDE_PKI_KEYGEN)
+#if !defined(ARCH_STM32WL)
+#define CryptRNG RNG
+#endif
 
 /**
  * Create a public/private key pair with Curve25519.
@@ -54,9 +46,6 @@ void CryptoEngine::generateKeyPair(uint8_t *pubKey, uint8_t *privKey)
     Curve25519::dh1(public_key, private_key);
     memcpy(pubKey, public_key, sizeof(public_key));
     memcpy(privKey, private_key, sizeof(private_key));
-#if !(MESHTASTIC_EXCLUDE_XEDDSA)
-    XEdDSA::priv_curve_to_ed_keys(private_key, xeddsa_private_key, xeddsa_public_key);
-#endif
 }
 
 /**
@@ -76,9 +65,6 @@ bool CryptoEngine::regeneratePublicKey(uint8_t *pubKey, uint8_t *privKey)
         }
         memcpy(private_key, privKey, sizeof(private_key));
         memcpy(public_key, pubKey, sizeof(public_key));
-#if !(MESHTASTIC_EXCLUDE_XEDDSA)
-        XEdDSA::priv_curve_to_ed_keys(private_key, xeddsa_private_key, xeddsa_public_key);
-#endif
     } else {
         LOG_WARN("X25519 key generation failed due to blank private key");
         return false;
@@ -86,97 +72,6 @@ bool CryptoEngine::regeneratePublicKey(uint8_t *pubKey, uint8_t *privKey)
     return true;
 }
 
-#if !(MESHTASTIC_EXCLUDE_XEDDSA)
-/**
- * Build a signing buffer that covers packet metadata and payload:
- *   [fromNode(4) | packetId(4) | portnum(4) | payload(N)]
- * This prevents replay, reattribution, and portnum redirection attacks.
- */
-static size_t buildSigningBuffer(uint8_t *buf, size_t bufSize, uint32_t fromNode, uint32_t packetId, uint32_t portnum,
-                                 const uint8_t *payload, size_t payloadLen)
-{
-    const size_t headerLen = sizeof(uint32_t) * 3;
-    size_t totalLen = headerLen + payloadLen;
-    if (totalLen > bufSize)
-        return 0;
-    // May need endian conversion for oddball platforms.
-    memcpy(buf, &fromNode, sizeof(uint32_t));
-    memcpy(buf + sizeof(uint32_t), &packetId, sizeof(uint32_t));
-    memcpy(buf + sizeof(uint32_t) * 2, &portnum, sizeof(uint32_t));
-    memcpy(buf + headerLen, payload, payloadLen);
-    return totalLen;
-}
-
-bool CryptoEngine::xeddsa_sign(uint32_t fromNode, uint32_t packetId, uint32_t portnum, const uint8_t *payload, size_t payloadLen,
-                               uint8_t *signature)
-{
-    if (memfll(xeddsa_private_key, 0, sizeof(xeddsa_private_key)))
-        return false;
-    uint8_t sigBuf[MAX_BLOCKSIZE];
-    size_t sigLen = buildSigningBuffer(sigBuf, sizeof(sigBuf), fromNode, packetId, portnum, payload, payloadLen);
-    if (sigLen == 0)
-        return false;
-    // the XEdDSA::sign function requires at least the first 32 bytes of signature to be pre-filled with randomness
-    HardwareRNG::fill(signature, 32);
-    XEdDSA::sign(signature, xeddsa_private_key, xeddsa_public_key, sigBuf, sigLen);
-    return true;
-}
-
-bool CryptoEngine::xeddsa_verify(const uint8_t *pubKey, uint32_t fromNode, uint32_t packetId, uint32_t portnum,
-                                 const uint8_t *payload, size_t payloadLen, const uint8_t *signature)
-{
-    // Use cached Ed25519 key if the Curve25519 key matches, avoiding expensive field inversion
-    if (memcmp(pubKey, cached_curve_pubkey, 32) != 0) {
-        curve_to_ed_pub(pubKey, cached_ed_pubkey);
-        memcpy(cached_curve_pubkey, pubKey, 32);
-    }
-    uint8_t sigBuf[MAX_BLOCKSIZE];
-    size_t sigLen = buildSigningBuffer(sigBuf, sizeof(sigBuf), fromNode, packetId, portnum, payload, payloadLen);
-    if (sigLen == 0)
-        return false;
-    return XEdDSA::verify(signature, cached_ed_pubkey, sigBuf, sigLen);
-}
-
-void CryptoEngine::curve_to_ed_pub(const uint8_t *curve_pubkey, uint8_t *ed_pubkey)
-{
-
-    // Apply the birational map defined in RFC 7748, section 4.1 "Curve25519" to calculate an Ed25519 public
-    // key from a Curve25519 public key. Because the serialization format of Curve25519 public keys only
-    // contains the u coordinate, the x coordinate of the corresponding Ed25519 public key can't be uniquely
-    // calculated as defined by the birational map. The x coordinate is represented in the serialization
-    // format of Ed25519 public keys only in a single sign bit. XEdDSA always normalizes the Ed25519 public
-    // key to a sign bit of zero (the signer negates its key pair when needed), so this function clears the
-    // sign bit unconditionally below instead of taking it as an input.
-    fe u, y;
-    fe one;
-    fe u_minus_one, u_plus_one, u_plus_one_inv;
-
-    // Parse the Curve25519 public key input as a field element containing the u coordinate. RFC 7748,
-    // section 5 "The X25519 and X448 Functions", mandates that the most significant bit of the Curve25519
-    // public key has to be zeroized. This is handled by fe_frombytes internally.
-    fe_frombytes(u, curve_pubkey);
-
-    // Calculate the parameters (u - 1) and (u + 1)
-    fe_1(one);
-    fe_sub(u_minus_one, u, one);
-    fe_add(u_plus_one, u, one);
-
-    // Invert u + 1
-    fe_invert(u_plus_one_inv, u_plus_one);
-
-    // Calculate y = (u - 1) * inv(u + 1) (mod p)
-    fe_mul(y, u_minus_one, u_plus_one_inv);
-
-    // Serialize the field element containing the y coordinate to the Ed25519 public key output
-    fe_tobytes(ed_pubkey, y);
-
-    // Set the sign bit to zero
-    ed_pubkey[31] &= 0x7f;
-
-    // need to convert the pubkey y = ( u - 1) * inv( u + 1) (mod p).
-}
-#endif
-
 bool CryptoEngine::ensurePkiKeys(meshtastic_Config_SecurityConfig &security, meshtastic_User &user)
 {
     if (user.is_licensed) {

src/mesh/CryptoEngine.h

@@ -23,7 +23,6 @@ struct CryptoKey {
 
 #define MAX_BLOCKSIZE 256
 #define TEST_CURVE25519_FIELD_OPS // Exposes Curve25519::isWeakPoint() for testing keys
-#define XEDDSA_SIGNATURE_SIZE 64
 
 class CryptoEngine
 {
@@ -38,12 +37,7 @@ class CryptoEngine
     virtual void generateKeyPair(uint8_t *pubKey, uint8_t *privKey);
     virtual bool regeneratePublicKey(uint8_t *pubKey, uint8_t *privKey);
     virtual bool ensurePkiKeys(meshtastic_Config_SecurityConfig &security, meshtastic_User &user);
-#endif
-#if !(MESHTASTIC_EXCLUDE_XEDDSA)
-    bool xeddsa_sign(uint32_t fromNode, uint32_t packetId, uint32_t portnum, const uint8_t *payload, size_t payloadLen,
-                     uint8_t *signature);
-    bool xeddsa_verify(const uint8_t *pubKey, uint32_t fromNode, uint32_t packetId, uint32_t portnum, const uint8_t *payload,
-                       size_t payloadLen, const uint8_t *signature);
+
 #endif
     void setDHPrivateKey(uint8_t *_private_key);
     // The remotePublic key parameter takes the public_key bytes container from
@@ -91,14 +85,6 @@ class CryptoEngine
 #if !(MESHTASTIC_EXCLUDE_PKI)
     uint8_t shared_key[32] = {0};
     uint8_t private_key[32] = {0};
-#if !(MESHTASTIC_EXCLUDE_XEDDSA)
-    uint8_t xeddsa_public_key[32] = {0};
-    uint8_t xeddsa_private_key[32] = {0};
-    void curve_to_ed_pub(const uint8_t *curve_pubkey, uint8_t *ed_pubkey);
-    // Single-entry cache for curve_to_ed_pub conversion (avoids expensive field inversion per packet)
-    uint8_t cached_curve_pubkey[32] = {0};
-    uint8_t cached_ed_pubkey[32] = {0};
-#endif
 #endif
     /**
      * Init our 128 bit nonce for a new packet

src/mesh/Default.cpp

@@ -60,26 +60,6 @@ uint32_t Default::getConfiguredOrDefaultMsScaled(uint32_t configured, uint32_t d
     return base * coef;
 }
 
-uint32_t Default::getConfiguredOrDefaultMsScaled(uint32_t configured, uint32_t defaultValue, uint32_t numOnlineNodes,
-                                                 TrafficType type)
-{
-    uint32_t baseMs = getConfiguredOrDefaultMsScaled(configured, defaultValue, numOnlineNodes);
-
-    if (!myRegion || !myRegion->profile)
-        return baseMs;
-
-    int8_t throttle =
-        (type == TrafficType::POSITION) ? myRegion->profile->positionThrottle : myRegion->profile->telemetryThrottle;
-
-    // throttle <= 0 means unset; 1 is the neutral multiplier — skip the multiply for performance
-    if (throttle <= 1)
-        return baseMs;
-
-    constexpr uint32_t MAX_MS = static_cast<uint32_t>(INT32_MAX);
-    uint64_t result = static_cast<uint64_t>(baseMs) * static_cast<uint64_t>(throttle);
-    return result >= static_cast<uint64_t>(MAX_MS) ? MAX_MS : static_cast<uint32_t>(result);
-}
-
 uint32_t Default::getConfiguredOrMinimumValue(uint32_t configured, uint32_t minValue)
 {
     // If zero, intervals should be coalesced later by getConfiguredOrDefault... methods

src/mesh/Default.h

@@ -18,9 +18,6 @@
 #define default_telemetry_broadcast_interval_secs IF_ROUTER(ONE_DAY / 2, 60 * 60)
 #define default_broadcast_interval_secs IF_ROUTER(ONE_DAY / 2, 60 * 60)
 #define default_broadcast_smart_minimum_interval_secs 5 * 60
-// Floor for our own position broadcasts when stationary (unchanged beyond the broadcast
-// precision) or fixed_position: identical positions get deduped by traffic management anyway.
-#define default_position_stationary_broadcast_secs (12 * 60 * 60)
 #define min_default_broadcast_interval_secs IF_ROUTER(ONE_DAY / 2, 60 * 60)
 #define min_default_broadcast_smart_minimum_interval_secs 5 * 60
 #define default_wait_bluetooth_secs IF_ROUTER(1, 60)
@@ -34,23 +31,9 @@
 #define min_neighbor_info_broadcast_secs 4 * 60 * 60
 #define default_map_publish_interval_secs 60 * 60
 
-enum class TrafficType { POSITION, TELEMETRY };
-
 // Traffic management defaults
-#define default_traffic_mgmt_position_precision_bits 19                // ~90m grid cells (±45m)
-#define default_traffic_mgmt_position_min_interval_secs (11 * 60 * 60) // 11 hours between identical positions
-// Role cap: tracker-role origins may refresh a duplicate position this often (vs the 11h default).
-#define default_traffic_mgmt_tracker_position_min_interval_secs (60 * 60) // 1 hour
-// Role cap: lost-and-found origins may refresh a duplicate position this often, so a lost
-// device updates frequently without flooding. (Quantised to the dedup tick: ~2 ticks.)
-// Unlike before, lost-and-found is NOT exempt from the relayed precision clamp.
-#define default_traffic_mgmt_lost_and_found_position_min_interval_secs (15 * 60) // 15 minutes
-
-// Hop scaling defaults
-#define default_hop_scaling_min_target_nodes 40          // walk threshold: first hop reaching this cumulative count
-#define default_hop_scaling_max_target_nodes 80          // generous extension ceiling (2 × min)
-#define default_hop_scaling_min_target_nodes_floor 5     // minimum allowed min_target_nodes
-#define default_hop_scaling_max_target_nodes_ceiling 512 // maximum allowed max_target_nodes
+#define default_traffic_mgmt_position_precision_bits 24               // ~10m grid cells
+#define default_traffic_mgmt_position_min_interval_secs (ONE_DAY / 2) // 12 hours between identical positions
 
 #ifdef USERPREFS_RINGTONE_NAG_SECS
 #define default_ringtone_nag_secs USERPREFS_RINGTONE_NAG_SECS
@@ -81,8 +64,6 @@ class Default
     // Note: numOnlineNodes uses uint32_t to match the public API and allow flexibility,
     // even though internal node counts use uint16_t (max 65535 nodes)
     static uint32_t getConfiguredOrDefaultMsScaled(uint32_t configured, uint32_t defaultValue, uint32_t numOnlineNodes);
-    static uint32_t getConfiguredOrDefaultMsScaled(uint32_t configured, uint32_t defaultValue, uint32_t numOnlineNodes,
-                                                   TrafficType type);
     static uint8_t getConfiguredOrDefaultHopLimit(uint8_t configured);
     static uint32_t getConfiguredOrMinimumValue(uint32_t configured, uint32_t minValue);
 

src/mesh/LR11x0Interface.cpp

@@ -368,10 +368,4 @@ template <typename T> bool LR11x0Interface<T>::sleep()
 
     return true;
 }
-
-template <typename T> int16_t LR11x0Interface<T>::getCurrentRSSI()
-{
-    float rssi = lora.getRSSI(false, true);
-    return (int16_t)round(rssi);
-}
 #endif

src/mesh/LR11x0Interface.h

@@ -37,8 +37,6 @@ template <class T> class LR11x0Interface : public RadioLibInterface
      */
     T lora;
 
-    int16_t getCurrentRSSI() override;
-
     /**
      * Glue functions called from ISR land
      */

src/mesh/LR20x0Interface.cpp

@@ -136,6 +136,17 @@ template <typename T> bool LR20x0Interface<T>::init()
     if (res == RADIOLIB_ERR_CHIP_NOT_FOUND || res == RADIOLIB_ERR_SPI_CMD_FAILED)
         return false;
 
+        // Some basic info about the module's explicit firmware version - no other info available
+        // Currently requires radiolib godmode
+
+#if RADIOLIB_GODMODE
+    uint8_t fwMajor = 0;
+    uint8_t fwMinor = 0;
+    int versionRes = lora.getVersion(&fwMajor, &fwMinor);
+    if (versionRes == RADIOLIB_ERR_NONE)
+        LOG_DEBUG("LR20x0 FW %d.%d", fwMajor, fwMinor);
+#endif
+
     LOG_INFO("Frequency set to %f", getFreq());
     LOG_INFO("Bandwidth set to %f", bw);
     LOG_INFO("Power output set to %d", power);
@@ -143,6 +154,17 @@ template <typename T> bool LR20x0Interface<T>::init()
     if (res == RADIOLIB_ERR_NONE)
         res = lora.setCRC(2);
 
+        // Standard DCDC ramp timing from RadioLib workarounds (register 0x00F20024)
+        // Currently requires radiolib godmode
+#if RADIOLIB_GODMODE
+    if (res == RADIOLIB_ERR_NONE) {
+        uint8_t rampTimes[4] = {15, 15, 15, 15}; // Standard case for all conditions
+        res = lora.setRegMode(RADIOLIB_LR2021_REG_MODE_SIMO_NORMAL, rampTimes);
+        if (res != RADIOLIB_ERR_NONE)
+            LOG_WARN("LR2021 setRegMode failed: %d", res);
+    }
+#endif
+
 #ifdef LR2021_DIO_AS_RF_SWITCH
     bool dioAsRfSwitch = true;
 #elif defined(ARCH_PORTDUINO)
@@ -374,10 +396,4 @@ template <typename T> bool LR20x0Interface<T>::sleep()
 
     return true;
 }
-
-template <typename T> int16_t LR20x0Interface<T>::getCurrentRSSI()
-{
-    float rssi = lora.getRSSI(false, true);
-    return (int16_t)round(rssi);
-}
 #endif

src/mesh/LR20x0Interface.h

@@ -37,8 +37,6 @@ template <class T> class LR20x0Interface : public RadioLibInterface
      */
     T lora;
 
-    int16_t getCurrentRSSI() override;
-
     /**
      * Glue functions called from ISR land
      */