Fix: Sporadig crashes and reboot (#2366)

* Fix: Sporadig crashes with reboot

* Revert "Fix: Sporadig crashes with reboot"

This reverts commit 59b65749f59b500fe8a6af6a20a993a70bd56b4f.

* Fix: Sporadig crashes and reboot
This commit is contained in:
Manuel
2023-03-17 19:53:29 -05:00
committed by GitHub
co-authored by GitHub
parent 7bbfa48b5d
commit 1f99d4756a
+4 -4
View File
@@ -164,13 +164,13 @@ bool ReliableRouter::stopRetransmission(GlobalPacketId key)
{
auto old = findPendingPacket(key);
if (old) {
auto p = old->packet;
auto numErased = pending.erase(key);
assert(numErased == 1);
// remove the 'original' (identified by originator and packet->id) from the txqueue and free it
cancelSending(getFrom(old->packet), old->packet->id);
// now free the pooled copy for retransmission too. tryfix for #2228
if (old->packet)
packetPool.release(old->packet);
cancelSending(getFrom(p), p->id);
// now free the pooled copy for retransmission too
packetPool.release(p);
return true;
} else
return false;